[Bug 852330] Review Request: hibernate - Relational persistence and query service
https://bugzilla.redhat.com/show_bug.cgi?id=852330
Marek Goldmann changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mgold...@redhat.com
Flags||fedora-review?
--- Comment #11 from Marek Goldmann ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
Issues:
===
[!]: Fully versioned dependency in subpackages, if present.
Note: Missing: 'Requires: %%{name} =' in: hibernate-c3p0, hibernate-core,
hibernate-ehcache, hibernate-entitymanager, hibernate-envers, hibernate-
infinispan, hibernate-proxool, hibernate-testing
See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage
[!]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Note: No /usr/share/javadoc/hibernate found
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later)", "Unknown or generated". 2 files have unknown
license.
Several files are under ASL 2.0 license, the lciense field should be
following:
LGPLv2+ and ASL 2.0
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
The package should install also the Apache license, as per:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text This
can be found here: http://www.apache.org/licenses/LICENSE-2.0.txt
[!]: Packaging. There is no main "hibernate" package, which may confuse people.
One option is to rename the "hibernate-core" package to "hibernate".
[!]: Packaging. It's still unsolved how we should deal with the same gid:aid
for artifacts in hibernate3 and hibernate (4) packages. This needs some thought
so we can fix it properly. Until it gets resolved, this review will not be
approved. This doesn't block you of course from fixing all above issues.
=== Notes ===
1. Some of the tests are commented out (lines ~305), the missing class is
available in jboss-jts package, in /usr/share/java/jboss-jts/jbossjts.jar jar.
Maybe you can enable them? If not, this is not a blocker.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later)", "Unknown or generated". 2 files have unknown
license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=840109
--- Comment #1 from Remi Collet ---
Could you update to latest version 0.3.8 before I do a formal review ?
Some notes
- you don't have to compress the generated man page (will be done by rpmbuild,
and compression tool could change, one day)
- tests are currently installed in /usr/share/php, which is in the default
include_path. There is no Guidelines about this, but I think it's a bad
practice.
Please consider moving to /usr/share/tests/php-lessphp
(you need to own /usr/share/tests or requires pear which own this dir)
- sed (to add shebang) is a bit hard to read.
Isn't simpler to use :
sed -e '1i#!/bin/bash\n' -i %{libname}/tests/bootstrap.sh
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870615] Review Request: snmptt - An SNMP trap handler written in Perl
https://bugzilla.redhat.com/show_bug.cgi?id=870615 --- Comment #13 from Andrew Colin Kissa --- Fixes have been implemented as requested. http://topdog-software.com/oss/SRPMS/fedora/snmptt/snmptt.spec http://topdog-software.com/oss/SRPMS/fedora/snmptt/snmptt-1.4-0.5.beta2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868939] Review Request: python-llfuse - Python Bindings for the low-level FUSE API
https://bugzilla.redhat.com/show_bug.cgi?id=868939 --- Comment #6 from Marcel Wysocki --- fixed those issued Update: Spec URL: http://maci.satgnu.net/rpmbuild/SPECS/python-llfuse.spec SRPM URL: http://maci.satgnu.net/rpmbuild/SRPMS/python-llfuse-0.37.1-5.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868879] Review Request: perl-TAP-SimpleOutput - Simple closure-driven TAP generator
https://bugzilla.redhat.com/show_bug.cgi?id=868879 Petr Pisar changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Petr Pisar --- New Package SCM Request === Package Name: perl-TAP-SimpleOutput Short Description: Simple closure-driven TAP generator Owners: ppisar, jplesnik, mmaslano, psabata Branches: InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852330] Review Request: hibernate - Relational persistence and query service
https://bugzilla.redhat.com/show_bug.cgi?id=852330 --- Comment #12 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/hibernate/4.1.7.Final/3/hibernate.spec SRPM URL: http://gil.fedorapeople.org/hibernate/4.1.7.Final/3/hibernate-4.1.7-4.fc16.src.rpm - fix license field - added ASL license txt file - renamed the "hibernate-core" package as "hibernate" -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866982] Review Request: rubygem-gem-patch - RubyGems plugin for patching gems.
https://bugzilla.redhat.com/show_bug.cgi?id=866982 --- Comment #11 from Josef Stribny --- New Package SCM Request === Package Name: rubygem-gem-patch Short Description: RubyGems plugin for patching gems Owners: jstribny Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866982] Review Request: rubygem-gem-patch - RubyGems plugin for patching gems.
https://bugzilla.redhat.com/show_bug.cgi?id=866982 Josef Stribny changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868908] Review Request: rubygem-gem-nice-install - A RubyGems plugin that improves gem installation user experience
https://bugzilla.redhat.com/show_bug.cgi?id=868908 --- Comment #5 from Josef Stribny --- New Package SCM Request === Package Name: rubygem-gem-nice-install Short Description: A RubyGems plugin that improves gem installation user experience Owners: jstribny vondruch bkabrda Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868908] Review Request: rubygem-gem-nice-install - A RubyGems plugin that improves gem installation user experience
https://bugzilla.redhat.com/show_bug.cgi?id=868908 Josef Stribny changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818458] Review Request: rubygem-ruby-debug19 - Command line interface (CLI) for ruby-debug-base
https://bugzilla.redhat.com/show_bug.cgi?id=818458 Vít Ondruch changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #11 from Vít Ondruch --- Hi Mamoru, Thanks for the packages. I see that you already retired rubygem-ruby-debug and rubygem-ruby-debug-base, but could you please also request RelEngs to block the packages? It would be nice to retire and block rubygem-linecache as well. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866012] Review Request: non-daw - a digital audio workstation using JACK
https://bugzilla.redhat.com/show_bug.cgi?id=866012 Matthias Runge changed: What|Removed |Added CC||mru...@redhat.com --- Comment #4 from Matthias Runge --- To intervene here, Jørn, please try to improve your review! From fedora-review output: [ ] = Manual review needed (means, the reviewer has to do work by hand) There are easy ones (GPLv2+ is absolutely an open source compatible license), changelog, but also harder things to check. You should do that! Fedora review also spits out the following text: fedora-review is automated tool, but *YOU* are responsible for manually reviewing the results and finishing the review. Do not just copy-paste the results without understanding them. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868325] Review Request: expatpp - A tiny OO C++ wrapper around expat
https://bugzilla.redhat.com/show_bug.cgi?id=868325 Mario Ceresa changed: What|Removed |Added Flags|fedora-review+ | Flags||fedora-review? Flags||fedora-cvs? --- Comment #7 from Mario Ceresa --- New Package SCM Request === Package Name: expatpp Short Description: A tiny OO C++ wrapper around expat Owners: mrceresa Branches: f17 f18 f19 el6 InitialCC: peter -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868325] Review Request: expatpp - A tiny OO C++ wrapper around expat
https://bugzilla.redhat.com/show_bug.cgi?id=868325 Peter Lemenkov changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869301] Review Request: erlpmd - A drop-in replacement for epmd written in Erlang
https://bugzilla.redhat.com/show_bug.cgi?id=869301 --- Comment #6 from Fedora Update System --- erlpmd-2.0.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/erlpmd-2.0.1-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870977] New: Review Request: glassfish-jaxws - JAX-WS Reference Implementation (RI) Project
https://bugzilla.redhat.com/show_bug.cgi?id=870977 Bug ID: 870977 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: glassfish-jaxws - JAX-WS Reference Implementation (RI) Project Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/glassfish-jaxws.spec SRPM URL: http://gil.fedorapeople.org/glassfish-jaxws-2.2.7-1.fc16.src.rpm Description: This project provides the core of Metro project, inside GlassFish community. This project develops and evolves the code base for the reference implementation of the Java API for XML Web Services (JAX-WS) specification. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870978] New: Review Request: libcdio-paranoia - CD paranoia on top of libcdio
https://bugzilla.redhat.com/show_bug.cgi?id=870978
Bug ID: 870978
QA Contact: extras...@fedoraproject.org
Severity: medium
Version: rawhide
Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Assignee: nob...@fedoraproject.org
Summary: Review Request: libcdio-paranoia - CD paranoia on top
of libcdio
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: adr...@lisas.de
Type: ---
Documentation: ---
Hardware: All
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
Spec URL: http://lisas.de/~adrian/rpm/libcdio-paranoia.spec
SRPM URL: http://lisas.de/~adrian/rpm/libcdio-paranoia-10.2+0.90-1.fc17.src.rpm
Description:
This CDDA reader distribution ('libcdio-cdparanoia') reads audio from the
CDROM directly as data, with no analog step between, and writes the
data to a file or pipe as .wav, .aifc or as raw 16 bit linear PCM.
Split off from libcdio to allow more flexible licensing and to be compatible
with cdparanoia-III-10.2's license. And also, libcdio is just too large.
Fedora Account System Username: adrian
libcdio has been updated t0 0.90 and libcdio-paranoia has been split off. To
provide the sane functionality as before the split libcdio-paranoia needs to be
imported before libcdio is updated to 0.90.
libcdio-paranoia.src: W: spelling-error %description -l en_US cdparanoia ->
paranoiac, paranoia, paranoid
libcdio-paranoia.src: W: spelling-error %description -l en_US wav -> av, wave,
wavy
libcdio-paranoia.src: W: spelling-error %description -l en_US aifc -> waif
libcdio-paranoia.x86_64: W: spelling-error %description -l en_US cdparanoia ->
paranoiac, paranoia, paranoid
libcdio-paranoia.x86_64: W: spelling-error %description -l en_US wav -> av,
wave, wavy
libcdio-paranoia.x86_64: W: spelling-error %description -l en_US aifc -> waif
libcdio-paranoia-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/libcdio-paranoia-10.2+0.90/src/getopt.h
4 packages and 1 specfiles checked; 1 errors, 6 warnings.
The spelling warnings can be ignored because cdparanoia is the name of the
package.
I will contact upstream about the incorrect-fsf-address.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869504] Review Request: mimepull - Streaming API to access attachments from a MIME message
https://bugzilla.redhat.com/show_bug.cgi?id=869504 gil cattaneo changed: What|Removed |Added Blocks||870977 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859111] Review Request: glassfish-pfl - GlassFish Primitive Function Library
https://bugzilla.redhat.com/show_bug.cgi?id=859111 gil cattaneo changed: What|Removed |Added Blocks||870977 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865787] Review Request: xmlstreambuffer - XML Stream Buffer
https://bugzilla.redhat.com/show_bug.cgi?id=865787 gil cattaneo changed: What|Removed |Added Blocks||870977 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870977] Review Request: glassfish-jaxws - JAX-WS Reference Implementation (RI) Project
https://bugzilla.redhat.com/show_bug.cgi?id=870977 gil cattaneo changed: What|Removed |Added Depends On||869610, 859112, 865787, ||859111, 859110, 869504 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859110] Review Request: glassfish-management-api - GlassFish Common APIs
https://bugzilla.redhat.com/show_bug.cgi?id=859110 gil cattaneo changed: What|Removed |Added Blocks||870977 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859112] Review Request: glassfish-gmbal - GlassFish MBean Annotation Library
https://bugzilla.redhat.com/show_bug.cgi?id=859112 gil cattaneo changed: What|Removed |Added Blocks||870977 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869610] Review Request: glassfish-saaj - JSR-67 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=869610 gil cattaneo changed: What|Removed |Added Blocks||870977 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870977] Review Request: glassfish-jaxws - JAX-WS Reference Implementation (RI) Project
https://bugzilla.redhat.com/show_bug.cgi?id=870977 gil cattaneo changed: What|Removed |Added Depends On||845735 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870977] Review Request: glassfish-jaxws - JAX-WS Reference Implementation (RI) Project
https://bugzilla.redhat.com/show_bug.cgi?id=870977 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870995] New: Review Request: glassfish-master-pom - Master POM for Glassfish Maven projects
https://bugzilla.redhat.com/show_bug.cgi?id=870995 Bug ID: 870995 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: glassfish-master-pom - Master POM for Glassfish Maven projects Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/glassfish-master-pom.spec SRPM URL: http://gil.fedorapeople.org/glassfish-master-pom-8-1.fc16.src.rpm Description: This is a shared POM parent for Glassfish Maven projects. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870996] New: Review Request: osgi-resource-locator - OSGi resource locator bundle
https://bugzilla.redhat.com/show_bug.cgi?id=870996 Bug ID: 870996 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: osgi-resource-locator - OSGi resource locator bundle Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/osgi-resource-locator.spec SRPM URL: http://gil.fedorapeople.org/osgi-resource-locator-1.0.1-1.fc16.src.rpm Description: OSGi resource locator bundle - used by various API providers that rely on META-INF/services mechanism to locate providers. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870997] New: Review Request: tiger-types - Type arithmetic library for Java5
https://bugzilla.redhat.com/show_bug.cgi?id=870997 Bug ID: 870997 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: tiger-types - Type arithmetic library for Java5 Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/tiger-types.spec SRPM URL: http://gil.fedorapeople.org/tiger-types-1.4-1.fc16.src.rpm Description: Tiger-types is a type arithmetic library for Java5. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870996] Review Request: osgi-resource-locator - OSGi resource locator bundle
https://bugzilla.redhat.com/show_bug.cgi?id=870996 gil cattaneo changed: What|Removed |Added Depends On||870995 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870995] Review Request: glassfish-master-pom - Master POM for Glassfish Maven projects
https://bugzilla.redhat.com/show_bug.cgi?id=870995 gil cattaneo changed: What|Removed |Added Blocks||870996 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871003] New: Review Request: obapps - Graphical tool for configuring per-application settings in Openbox
https://bugzilla.redhat.com/show_bug.cgi?id=871003 Bug ID: 871003 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: obapps - Graphical tool for configuring per-application settings in Openbox Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: mario.blaetterm...@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/obapps.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/obapps-0.1.7-1.fc17.src.rpm Description: A graphical tool for configuring the per-application settings (window matching) in the Openbox window manager Fedora Account System Username: mariobl -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871003] Review Request: obapps - Graphical tool for configuring per-application settings in Openbox
https://bugzilla.redhat.com/show_bug.cgi?id=871003 Mario Blättermann changed: What|Removed |Added Alias||obapps -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870615] Review Request: snmptt - An SNMP trap handler written in Perl
https://bugzilla.redhat.com/show_bug.cgi?id=870615
Volker Fröhlich changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #14 from Volker Fröhlich ---
== APPROVED ==
There's room for the same kind of simplification in %postun.
As a sidenote: I found Debian requires the netsnmp-perl module. I don't think
this is actually necessary.
Please notice the comment on the license of sendemail.sh below.
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
Package is designed to go to EPEL 5 as well
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
Package is designed to go to EPEL 5 as well
[-]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in
/media/speicher1/makerpm/rpmbuild/SPECS/870615-snmptt/licensecheck.txt
That's a single contributed trivial shell script we don't ship. It should
probably be clarified nevertheless.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: No %config files under /usr.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
Note: Invalid buildroot found:
%{_tmppath}/%{name}_%{version}-%{release}-root-%(%{__id_u} -n)
The preferred form would be %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XX), but the above is said to be
good as well.
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
Package is designed to go to EPEL 5 as well
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is p
[Bug 815018] Review Request: nodejs - javascript fast build framework
https://bugzilla.redhat.com/show_bug.cgi?id=815018 --- Comment #37 from Matthias Runge --- Adrian, since there is substantial interest in this package, please continue or close this review. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868936] Review Request: python-apsw - Another Python SQLite Wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=868936 --- Comment #8 from Mario Blättermann --- New scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4635014 $ rpmlint -i -v * python-apsw.src: I: checking python-apsw.src: W: spelling-error %description -l en_US pysqlite -> pyrites The value of this tag appears to be misspelled. Please double-check. python-apsw.src: I: checking-url http://code.google.com/p/apsw/ (timeout 10 seconds) python-apsw.src: I: checking-url http://apsw.googlecode.com/files/apsw-3.7.11-r1.zip (timeout 10 seconds) python-apsw.src: W: invalid-url Source0: http://apsw.googlecode.com/files/apsw-3.7.11-r1.zip HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. python-apsw.i686: I: checking python-apsw.i686: W: spelling-error %description -l en_US pysqlite -> pyrites The value of this tag appears to be misspelled. Please double-check. python-apsw.i686: I: checking-url http://code.google.com/p/apsw/ (timeout 10 seconds) python-apsw.x86_64: I: checking python-apsw.x86_64: W: spelling-error %description -l en_US pysqlite -> pyrites The value of this tag appears to be misspelled. Please double-check. python-apsw.x86_64: I: checking-url http://code.google.com/p/apsw/ (timeout 10 seconds) python-apsw-debuginfo.i686: I: checking python-apsw-debuginfo.i686: I: checking-url http://code.google.com/p/apsw/ (timeout 10 seconds) python-apsw-debuginfo.x86_64: I: checking python-apsw-debuginfo.x86_64: I: checking-url http://code.google.com/p/apsw/ (timeout 10 seconds) python-apsw.spec: I: checking-url http://apsw.googlecode.com/files/apsw-3.7.11-r1.zip (timeout 10 seconds) python-apsw.spec: W: invalid-url Source0: http://apsw.googlecode.com/files/apsw-3.7.11-r1.zip HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. 5 packages and 1 specfiles checked; 0 errors, 5 warnings. Ignorable issues, as already discussed. Still some objections: You have a -doc subpackage, but no files for it, that's why it won't be built. BTW, do we need such a separate doc package really? Moreover, the license there is still "zlib/libpng license" instead of just "zlib". In general, if the docs are not licensed differently from the main package, you won't need a license tag for that subpackage at all. Identical descriptions for main and doc package don't make sense. At least the -doc description should contain a hint that it is a documentation-only package. And it is up to you to decide if the doc package should depend on the main package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871018] New: Review Request: glassfish-hk2 - Hundred Kilobytes Kernel
https://bugzilla.redhat.com/show_bug.cgi?id=871018 Bug ID: 871018 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: glassfish-hk2 - Hundred Kilobytes Kernel Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/glassfish-hk2.spec SRPM URL: http://gil.fedorapeople.org/glassfish-hk2-2.1.37-1.fc16.src.rpm Description: HK2 for Hundred Kilobytes Kernel is an abstraction to a module subsystem coupled with a simple yet powerful component model to build server side software. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871018] Review Request: glassfish-hk2 - Hundred Kilobytes Kernel
https://bugzilla.redhat.com/show_bug.cgi?id=871018 gil cattaneo changed: What|Removed |Added Depends On||870997, 870996, 870995 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870995] Review Request: glassfish-master-pom - Master POM for Glassfish Maven projects
https://bugzilla.redhat.com/show_bug.cgi?id=870995 gil cattaneo changed: What|Removed |Added Blocks||871018 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870997] Review Request: tiger-types - Type arithmetic library for Java5
https://bugzilla.redhat.com/show_bug.cgi?id=870997 gil cattaneo changed: What|Removed |Added Blocks||871018 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870996] Review Request: osgi-resource-locator - OSGi resource locator bundle
https://bugzilla.redhat.com/show_bug.cgi?id=870996 gil cattaneo changed: What|Removed |Added Blocks||871018 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] New: Review Request: glassfish-ha-api - High Availability APIs and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=871021 Bug ID: 871021 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: glassfish-ha-api - High Availability APIs and SPI Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/glassfish-ha-api.spec SRPM URL: http://gil.fedorapeople.org/glassfish-ha-api-3.1.9-1.fc16.src.rpm Description: GlassFish High Availability APIs and SPI. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871018] Review Request: glassfish-hk2 - Hundred Kilobytes Kernel
https://bugzilla.redhat.com/show_bug.cgi?id=871018 gil cattaneo changed: What|Removed |Added Blocks||871021 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=871021 gil cattaneo changed: What|Removed |Added Depends On||871018 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=871021 gil cattaneo changed: What|Removed |Added Blocks||870977 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870977] Review Request: glassfish-jaxws - JAX-WS Reference Implementation (RI) Project
https://bugzilla.redhat.com/show_bug.cgi?id=870977 gil cattaneo changed: What|Removed |Added Depends On||871021 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 Mario Blättermann changed: What|Removed |Added CC||gdj2...@rit.edu, ||loganje...@gmail.com, ||volke...@gmx.at Blocks|177841 (FE-NEEDSPONSOR) | Alias||opencsg -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #2 from Mario Blättermann --- Lifting FE-NEEDSPONSOR, I will sponsor Miro. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825489] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=825489 Mario Blättermann changed: What|Removed |Added Status|NEW |CLOSED CC||mario.blaetterm...@gmail.co ||m Resolution|--- |DUPLICATE Last Closed||2012-10-29 08:23:46 --- Comment #15 from Mario Blättermann --- *** This bug has been marked as a duplicate of bug 870060 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871023] New: Review Request: glassfish-policy - GlassFish WS-Policy implementation
https://bugzilla.redhat.com/show_bug.cgi?id=871023 Bug ID: 871023 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: glassfish-policy - GlassFish WS-Policy implementation Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/glassfish-policy.spec SRPM URL: http://gil.fedorapeople.org/glassfish-policy-2.3.1-1.fc16.src.rpm Description: The policy project provides the WS-Policy implementation for Project Metro. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871023] Review Request: glassfish-policy - GlassFish WS-Policy implementation
https://bugzilla.redhat.com/show_bug.cgi?id=871023 gil cattaneo changed: What|Removed |Added Blocks||870977 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870977] Review Request: glassfish-jaxws - JAX-WS Reference Implementation (RI) Project
https://bugzilla.redhat.com/show_bug.cgi?id=870977 gil cattaneo changed: What|Removed |Added Depends On||871023 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825489] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=825489 --- Comment #16 from Mario Blättermann --- *** This bug has been marked as a duplicate of bug 870860 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #3 from Mario Blättermann --- *** Bug 825489 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825489] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=825489 --- Comment #17 from Mario Blättermann --- (In reply to comment #15) > > *** This bug has been marked as a duplicate of bug 870060 *** Forget this change, this was the wrong bug ... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863571] Review Request: flare - A single player, 2D-isometric, action Role-Playing Game
https://bugzilla.redhat.com/show_bug.cgi?id=863571 Volker Fröhlich changed: What|Removed |Added Assignee|nob...@fedoraproject.org|volke...@gmx.at -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 849026] Review Request: jam-control - audioserver gui app
https://bugzilla.redhat.com/show_bug.cgi?id=849026 --- Comment #25 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866982] Review Request: rubygem-gem-patch - RubyGems plugin for patching gems.
https://bugzilla.redhat.com/show_bug.cgi?id=866982 --- Comment #12 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868325] Review Request: expatpp - A tiny OO C++ wrapper around expat
https://bugzilla.redhat.com/show_bug.cgi?id=868325 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868879] Review Request: perl-TAP-SimpleOutput - Simple closure-driven TAP generator
https://bugzilla.redhat.com/show_bug.cgi?id=868879 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868908] Review Request: rubygem-gem-nice-install - A RubyGems plugin that improves gem installation user experience
https://bugzilla.redhat.com/show_bug.cgi?id=868908 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869610] Review Request: glassfish-saaj - JSR-67 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=869610 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871037] New: Review Request: librcc - RusXMMS Charset Conversion Library
https://bugzilla.redhat.com/show_bug.cgi?id=871037 Bug ID: 871037 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: librcc - RusXMMS Charset Conversion Library Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: dr...@land.ru Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: https://raw.github.com/drizt/librcc-package/334f07bb326bdfc5fa400ca0d477acaabe41738a/librcc.spec SRPM URL: https://raw.github.com/drizt/librcc-package/334f07bb326bdfc5fa400ca0d477acaabe41738a/librcc-0.2.9-1.fc17.src.rpm Description: The Abilities of LibRCC Library - Language Autodetection. - On the fly translation between languages, using online-services! - Encoding Autodetection for most of European Languages. - Support for encoding detection plugins (besides Enca and LibRCD) - Recoding/translation of multi-language playlists! - Cache to speed-up re-recoding. - Possibility to configure new languages and encodings. - Shared configuration file. For example mentioned TagLib and LibID3 patches do not have their own user interface, but will utilize the same recoding configuration as XMMS. - As well the separate program for configuration adjustment is available. - GTK2 UI Library: you can add properties page to your GTK application with 3 lines of code. - Menu localization opportunity. Fedora Account System Username: ivanromanov -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871037] Review Request: librcc - RusXMMS Charset Conversion Library
https://bugzilla.redhat.com/show_bug.cgi?id=871037 --- Comment #1 from Ivan Romanov --- Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4635240 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869861] Review Request: pam_openshift - Openshift PAM module
https://bugzilla.redhat.com/show_bug.cgi?id=869861 Troy Dawson changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Troy Dawson --- License: It is actually dual licensed code (BSD and/or GPL). We are choosing to use GPL. But ya, I'll see about getting that more clear upstream. Obsoletes: The original rpm was called pam-libra, and was then switched to pam-openshift. There are currently instructions for "Build your own PAAS" for building those rpm's on Fedora. So we know there are some people that need this. But yes, upstream is planning on only having those there until they feel confident that nobody needs them anymore. Man Pages: Good catch, we'll fix that. Upstream is also in the process of adding the missing man page. Requires: Another good catch. Upstream will soon have another release (with the man page fixes). I'll work on getting the other changes you talked about in that version and we'll just use that version, instead of patching this version up. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871037] Review Request: librcc - RusXMMS Charset Conversion Library
https://bugzilla.redhat.com/show_bug.cgi?id=871037 --- Comment #2 from Ivan Romanov --- $ rpmlint *.rpm librcc.i686: W: spelling-error %description -l en_US multi -> mulch, mufti librcc.i686: W: spelling-error %description -l en_US playlists -> play lists, play-lists, stylists librcc.i686: W: spelling-error %description -l en_US recoding -> recording, receding, decoding librcc.i686: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings librcc.src: W: spelling-error %description -l en_US multi -> mulch, mufti librcc.src: W: spelling-error %description -l en_US playlists -> play lists, play-lists, stylists librcc.src: W: spelling-error %description -l en_US recoding -> recording, receding, decoding librcc.src: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/ui/internal.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/internal.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/plugin.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rcclock.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rcctranslate.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rcctranslate.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/lngconfig.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/lngconfig.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/ui/rccmenu.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/ui/rccmenu.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/fs.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/librcc.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/fs.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/librcc.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccspell.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccspell.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rcchome.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccconfig.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/fake_rcd.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rcchome.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccconfig.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/plugin.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/opt.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/opt.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/engines/western.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccdb4.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/lng.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/lng.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccdb4.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/curconfig.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/ui/rccnames.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rcciconv.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rcciconv.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/ui/rccnames.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccstring.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccmutex.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccmutex.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/external/rcclibtranslate.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/external/rcclibtranslate.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rcclist.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rcclist.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccstring.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccxml.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/ui/librccui.c librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/rccxml.h librcc-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/librcc-0.2.9/src/engin
[Bug 868936] Review Request: python-apsw - Another Python SQLite Wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=868936 --- Comment #9 from Marcel Wysocki --- removed the -doc package, we dont really need it thank you for your patience :) Update: Spec URL: http://maci.satgnu.net/rpmbuild/SPECS/python-apsw.spec SRPM URL: http://maci.satgnu.net/rpmbuild/SRPMS/python-apsw-3.7.11.r1-6.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869610] Review Request: glassfish-saaj - JSR-67 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=869610 Marek Goldmann changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811661] Review Request: scirenderer - A Java rendering library based on JoGL
https://bugzilla.redhat.com/show_bug.cgi?id=811661 Brendan Jones changed: What|Removed |Added CC||brendan.jones...@gmail.com Assignee|nob...@fedoraproject.org|brendan.jones...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797203] Review Request: augeas-vala - Vala bindings for augeas.
https://bugzilla.redhat.com/show_bug.cgi?id=797203 --- Comment #15 from Jon Ciesla --- No SCM request found. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: libcommuni - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 Jan Kaluža changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-10-29 09:43:26 --- Comment #40 from Jan Kaluža --- Closing this one, package is in Fedora/EPEL now. Thanks you all for a review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866154] Review Request: rtaudio - a realtime audio I/O library (re-review orphaned package)
https://bugzilla.redhat.com/show_bug.cgi?id=866154 --- Comment #7 from Jon Ciesla --- Unretired devel, please take, and then submit Package Change request for new branches. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871003] Review Request: obapps - Graphical tool for configuring per-application settings in Openbox
https://bugzilla.redhat.com/show_bug.cgi?id=871003 Ivan Romanov changed: What|Removed |Added CC||dr...@land.ru --- Comment #1 from Ivan Romanov --- Why you use install and desktop-file-validate commands? Can you use single desktop-file-install instead? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797203] Review Request: augeas-vala - Vala bindings for augeas.
https://bugzilla.redhat.com/show_bug.cgi?id=797203 Fabian Deutsch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #16 from Fabian Deutsch --- New Package SCM Request === Package Name: augeas-vala Short Description: Vala bindings for augeas Owners: fabiand Branches: f17 f18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797203] Review Request: augeas-vala - Vala bindings for augeas.
https://bugzilla.redhat.com/show_bug.cgi?id=797203 --- Comment #17 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870649] Review Request: argtable - Cross platform C library for parsing GNU style command line arguments
https://bugzilla.redhat.com/show_bug.cgi?id=870649 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870649] Review Request: argtable - Cross platform C library for parsing GNU style command line arguments
https://bugzilla.redhat.com/show_bug.cgi?id=870649 --- Comment #7 from Fedora Update System --- argtable-2.13-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/argtable-2.13-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870649] Review Request: argtable - Cross platform C library for parsing GNU style command line arguments
https://bugzilla.redhat.com/show_bug.cgi?id=870649 --- Comment #8 from Fedora Update System --- argtable-2.13-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/argtable-2.13-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866982] Review Request: rubygem-gem-patch - RubyGems plugin for patching gems.
https://bugzilla.redhat.com/show_bug.cgi?id=866982 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866982] Review Request: rubygem-gem-patch - RubyGems plugin for patching gems.
https://bugzilla.redhat.com/show_bug.cgi?id=866982 --- Comment #13 from Fedora Update System --- rubygem-gem-patch-0.1.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-gem-patch-0.1.3-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866982] Review Request: rubygem-gem-patch - RubyGems plugin for patching gems.
https://bugzilla.redhat.com/show_bug.cgi?id=866982 --- Comment #14 from Fedora Update System --- rubygem-gem-patch-0.1.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-gem-patch-0.1.3-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869861] Review Request: pam_openshift - Openshift PAM module
https://bugzilla.redhat.com/show_bug.cgi?id=869861 --- Comment #3 from Michael Scherer --- The rpm seemed otherwise good, so do we wait for next upstream release ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868325] Review Request: expatpp - A tiny OO C++ wrapper around expat
https://bugzilla.redhat.com/show_bug.cgi?id=868325 --- Comment #9 from Fedora Update System --- expatpp-0-1.20121019gitd8c1bf8.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/expatpp-0-1.20121019gitd8c1bf8.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865303] Review Request: realTimeConfigQuickScan - inspect system settings for realtime performance
https://bugzilla.redhat.com/show_bug.cgi?id=865303 Clément DAVID changed: What|Removed |Added Status|NEW |ASSIGNED CC||c.davi...@gmail.com Assignee|nob...@fedoraproject.org|c.davi...@gmail.com Flags||fedora-review? --- Comment #5 from Clément DAVID --- /var/tmp/rpm-tmp.ttcbq9: line 40: desktop-file-install: command not found BuildRequires: desktop-file-utils -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868325] Review Request: expatpp - A tiny OO C++ wrapper around expat
https://bugzilla.redhat.com/show_bug.cgi?id=868325 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868325] Review Request: expatpp - A tiny OO C++ wrapper around expat
https://bugzilla.redhat.com/show_bug.cgi?id=868325 --- Comment #10 from Fedora Update System --- expatpp-0-1.20121019gitd8c1bf8.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/expatpp-0-1.20121019gitd8c1bf8.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854386] Review Request: rubygem-openstack-quantum-client - Ruby openstack quantum Client
https://bugzilla.redhat.com/show_bug.cgi?id=854386 --- Comment #8 from Alejandro_Perez --- Thanks for the notice. it has been done. http://aeperezt.fedorapeople.org/rpmdev/rubygem-openstack-quantum-client.spec http://aeperezt.fedorapeople.org/rpmdev/rubygem-openstack-quantum-client-0.1.5-3.fc17.src.rpm rpmlint SPECS/rubygem-openstack-quantum-client.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint SRPMS/rubygem-openstack-quantum-client-0.1.5-3.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint RPMS/noarch/rubygem-openstack-quantum-client-0.1.5-3.fc17.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 Miro Hrončok changed: What|Removed |Added Clone Of|864187 |825489 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869610] Review Request: glassfish-saaj - JSR-67 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=869610 --- Comment #5 from Fedora Update System --- glassfish-saaj-1.3.19-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/glassfish-saaj-1.3.19-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869610] Review Request: glassfish-saaj - JSR-67 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=869610 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869610] Review Request: glassfish-saaj - JSR-67 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=869610 --- Comment #6 from Fedora Update System --- glassfish-saaj-1.3.19-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/glassfish-saaj-1.3.19-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865303] Review Request: realTimeConfigQuickScan - inspect system settings for realtime performance
https://bugzilla.redhat.com/show_bug.cgi?id=865303 --- Comment #6 from Brendan Jones --- Apologies: Updated source also. SRPM: http://bsjones.fedorapeople.org/realTimeConfigQuickScan-0-0.4.20120506hg.fc18.src.rpm SPEC: http://bsjones.fedorapeople.org/realTimeConfigQuickScan.spec -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
https://bugzilla.redhat.com/show_bug.cgi?id=799702
--- Comment #6 from Tomas Radej ---
Sorry that it took so long.
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
[!]: License file installed when any subpackage combination is installed.
Licence file missing from demo and test packages. Please note that
the actual licence file is COPYING.LESSER, while COPYING is provided
for files used at compile time, which are not included in the final
package.
[!]: %check is present and all tests pass.
Check section is commented out. Please, either uncomment it or provide
reasons why tests aren't being run.
[!]: Requires correct, justified where necessary.
Test subpackage requires python2-nose. Should be python-nose
[!]: Permissions on files are set properly.
E. g. /usr/lib/python2.7/site-packages/ufl/test/test_lhs_rhs.py does not
have the +x permission. I didn't check if the file is to be run, but
since it has a shebang, I guess it is. Please also check these files:
/usr/lib/python2.7/site-packages/ufl/test/test_book_snippets.py
/usr/lib/python2.7/site-packages/ufl/test/test_tensoralgebra.py
/usr/lib/python2.7/site-packages/ufl/test/ufltestcase.py
Moreover, the file /usr/lib/python2.7/site-packages/ufl/demo/clean.sh
from the demo subpackage is not executable. Please, change that.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[!]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v3 or later)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown
or generated". 4 files have unknown license. Detailed output of
licensecheck in /home/tradej/reviews/799702-python-ufl/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Package installs properly.
Note: Installation errors (see attachment)
[x]: Package is not relocatable.
[!]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UT
[Bug 871092] New: Review Request: updf - Application to write to PDF
https://bugzilla.redhat.com/show_bug.cgi?id=871092 Bug ID: 871092 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: unspecified CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: updf - Application to write to PDF Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: trp...@katamail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://sagitter.fedorapeople.org/updf.spec SRPM URL: http://sagitter.fedorapeople.org/updf-0.0.2.4-1.fc17.src.rpm Description: A tool to write and paint to an existing PDF file. uPdf can insert pages of another PDF, insert new pages, remove and extract pages, rotate pages, paste an image in the existing PDF, and much more. Fedora Account System Username: sagitter -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868879] Review Request: perl-TAP-SimpleOutput - Simple closure-driven TAP generator
https://bugzilla.redhat.com/show_bug.cgi?id=868879 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-TAP-SimpleOutput-0.001 ||-1.fc19 Resolution|--- |RAWHIDE Last Closed||2012-10-29 11:30:00 --- Comment #4 from Petr Pisar --- Thank you for the review and repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871092] Review Request: updf - Application to write to PDF
https://bugzilla.redhat.com/show_bug.cgi?id=871092 Antonio Trande changed: What|Removed |Added Hardware|All |noarch Version|rawhide |17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871092] Review Request: updf - Application to write to PDF
https://bugzilla.redhat.com/show_bug.cgi?id=871092 Antonio Trande changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868908] Review Request: rubygem-gem-nice-install - A RubyGems plugin that improves gem installation user experience
https://bugzilla.redhat.com/show_bug.cgi?id=868908 --- Comment #7 from Fedora Update System --- rubygem-gem-nice-install-0.2.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-gem-nice-install-0.2.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868908] Review Request: rubygem-gem-nice-install - A RubyGems plugin that improves gem installation user experience
https://bugzilla.redhat.com/show_bug.cgi?id=868908 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868908] Review Request: rubygem-gem-nice-install - A RubyGems plugin that improves gem installation user experience
https://bugzilla.redhat.com/show_bug.cgi?id=868908 --- Comment #8 from Fedora Update System --- rubygem-gem-nice-install-0.2.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-gem-nice-install-0.2.0-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
