[Bug 884604] Review Request: rubygem-riot - An extremely fast, expressive, and context-driven unit-testing framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884604 Bohuslav "Slavek" Kabrda changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Bohuslav "Slavek" Kabrda --- Looks good now, APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Yao2npUuRk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877985] Review Request: pss - A power-tool for searching inside source code files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877985 --- Comment #4 from Kushal Das --- After more cleanup as suggested: Spec URL: http://kushal.fedorapeople.org/packages/pss.spec SRPM URL: http://kushal.fedorapeople.org/packages/pss-0.35-3.fc17.src.rpm EPEL6 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4802140 RAWHIDE build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4802142 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ldlPD35neH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 --- Comment #7 from Mamoru TASAKA --- (In reply to comment #6) > > * Enabling test suite > > - As this package contains test/ directory, please execute > > some tests in %check (like ruby -Ilib test/test_inifile.rb) > > Their tests require a separate gem be installed called bones. I would prefer > not to package that as it's not useful to me and isn't a runtime requirement > for inifile. - That is needed when you try to execute test suite using rake (bones is used only in Rakefile). See: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites the line "The tests should not be run using Rake". As I said before, it seems that "ruby -Ilib test/test_inifile.rb" does some test program, so please consider to enable %check section. > > * Documentation > > - Current ruby guideline says test/ directory should not be > > shipped in binary rpm > > > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > > Ruby#Running_test_suites > > Hrm, that should be in the -doc package. Looking in the packages built the > test directory is with the docs, per the specfile. - So the current guideline says test/ directory should not be included also in -doc subpackage (see "Do not ship tests" in https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites ) (If you think test/ directory in this gem is useful for users, I won't treat this as a blocker) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lq1fnX9eAu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874105] Review Request: qpid-proton - Proton is a high performance, lightweight messaging library
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=874105
--- Comment #8 from Mamoru TASAKA ---
(In reply to comment #7)
> > * Dependency between subpackage.
> > - As said before, usually dependency between subpackage must be
> > _full_ (Epoch)-Version-"Release" and isa specific (i.e.
> > Requires: %{name}%{?_isa} = %{version}-%{release} )
>
> Done.
So would you explain why you omit "release" dependency?
(i.e. not %{name}%{?_isa} = %{version}-%{release} but
%{name}%{?_isa} = %{version}))
Omitting %release allows user to update only -devel or some other
subpackage while not updating main package, which may result in
inconsistent state or malfunction (especially when both main
package and subpackages are changed between release).
Another point I missed before:
* %filter_setup
- %filter_setup is used, however no filters are actually defined,
so this %filter_setup should not be needed.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=H2qBpuMd5B&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885348] Review Request: ghc-stringsearch - Fast searching, splitting and replacing of ByteStrings
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885348 Lakshmi Narasimhan changed: What|Removed |Added Flags||needinfo?(maths...@gmail.co ||m) --- Comment #3 from Lakshmi Narasimhan --- Ben, The links do not work. I am getting this error. unable to resolve host address `benboeckel.net' -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CSP1i7BTRH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885348] Review Request: ghc-stringsearch - Fast searching, splitting and replacing of ByteStrings
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885348 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZPNjz95EZP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885350] Review Request: ghc-date-cache - Date cacher
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885350 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y0bIlcnCGn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885349] Review Request: ghc-wai-logger - A logging system for WAI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885349 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TmqbdALOS3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #7 from Lakshmi Narasimhan --- Spec file: http://narasim.fedorapeople.org/package_reviews/ghc-concrete-typerep.spec SRPM link: http://narasim.fedorapeople.org/package_reviews/ghc-concrete-typerep-0.1.0.1-4.fc17.src.rpm rpmlint output: rpmlint -i ghc-concrete-typerep-0.1.0.1-4.fc17.src.rpm ghc-concrete-typerep-devel-0.1.0.1-4.fc17.x86_64.rpm ghc-concrete-typerep-0.1.0.1-4.fc17.x86_64.rpm ../ghc-concrete-typerep.spec 3 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dOEuEReUyQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829580] Review Request: python-traitsui - User interface tools designed to complement Traits
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829580 --- Comment #9 from Orion Poplawski --- http://www.cora.nwra.com/~orion/fedora/python-traitsui.spec http://www.cora.nwra.com/~orion/fedora/python-traitsui-4.2.0-5.fc18.src.rpm * Tue Dec 18 2012 Orion Poplawski - 4.2.0-5 - Change BR to python2-devel -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uRtHjPGWpA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785480] Review Request: php-horde-Horde-Log - Horde Logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785480 Shawn Iwinski changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #14 from Shawn Iwinski --- After initial import: * Remove "Requires: php-simplexml php-libxml" as these are only build requires * Please remove "PHPRC=../php.ini" from %install No blockers. = APPROVED = -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M1aSvTOwFV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785480] Review Request: php-horde-Horde-Log - Horde Logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785480 Shawn Iwinski changed: What|Removed |Added Attachment #664213|0 |1 is obsolete|| --- Comment #13 from Shawn Iwinski --- Created attachment 665852 --> https://bugzilla.redhat.com/attachment.cgi?id=665852&action=edit php-horde-Horde-Log-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785480 --mock-config fedora-rawhide-x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HPswCy2VbS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785480] Review Request: php-horde-Horde-Log - Horde Logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785480 Shawn Iwinski changed: What|Removed |Added Attachment #665846|0 |1 is obsolete|| --- Comment #12 from Shawn Iwinski --- Created attachment 665851 --> https://bugzilla.redhat.com/attachment.cgi?id=665851&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=j5rewB0YQ4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785480] Review Request: php-horde-Horde-Log - Horde Logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785480 --- Comment #11 from Shawn Iwinski --- Created attachment 665846 --> https://bugzilla.redhat.com/attachment.cgi?id=665846&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9oMaO5h7fG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785479] Review Request: php-horde-Horde-Constraint - Horde Constraint library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785479 Shawn Iwinski changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #15 from Shawn Iwinski --- After initial import, please also remove "PHPRC=../php.ini" from %install. No blockers. = APPROVED = -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NCABIfwVlH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785479] Review Request: php-horde-Horde-Constraint - Horde Constraint library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785479 Shawn Iwinski changed: What|Removed |Added Attachment #664207|0 |1 is obsolete|| --- Comment #14 from Shawn Iwinski --- Created attachment 665845 --> https://bugzilla.redhat.com/attachment.cgi?id=665845&action=edit php-horde-Horde-Constraint-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785479 --mock-config fedora-rawhide-x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kjyZEILDPX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785479] Review Request: php-horde-Horde-Constraint - Horde Constraint library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785479 --- Comment #13 from Shawn Iwinski --- Created attachment 665844 --> https://bugzilla.redhat.com/attachment.cgi?id=665844&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X20pR0LF8q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837666] Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=837666 --- Comment #13 from Fedora Update System --- php-doctrine-DoctrineCommon-2.3.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-doctrine-DoctrineCommon-2.3.0-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=acgV39nuo9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837666] Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=837666 --- Comment #12 from Fedora Update System --- php-doctrine-DoctrineCommon-2.3.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-doctrine-DoctrineCommon-2.3.0-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hHOUtB7wGr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837666] Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=837666 --- Comment #11 from Fedora Update System --- php-doctrine-DoctrineCommon-2.3.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-doctrine-DoctrineCommon-2.3.0-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sBXMB0d1Xm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837666] Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=837666 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LrfIKr4ZwI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880 Shawn Iwinski changed: What|Removed |Added Whiteboard||NotReady --- Comment #3 from Shawn Iwinski --- (In reply to comment #2) > MUST: > > - Please clarify License (with upstream). > > Only MIT file is provided, GPLv3 only list in composer.json file... > > I also think it will be great to have License header in each file. Awaiting https://github.com/leafo/scssphp/issues/31 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xBs6dabdu7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885515] Review Request: php-Faker - A PHP library that generates fake data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885515 --- Comment #7 from Fedora Update System --- php-Faker-1.1.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-Faker-1.1.0-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AsV5zAxvtr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885515] Review Request: php-Faker - A PHP library that generates fake data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885515 --- Comment #6 from Fedora Update System --- php-Faker-1.1.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-Faker-1.1.0-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YKO3OGoFO5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885515] Review Request: php-Faker - A PHP library that generates fake data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885515 --- Comment #8 from Fedora Update System --- php-Faker-1.1.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-Faker-1.1.0-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KCB6LLS0mb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885515] Review Request: php-Faker - A PHP library that generates fake data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885515 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lBPvwHesYU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887543] Review Request: trac-sensitivetickets-plugin - Plugin for Trac that enables sensitive tickets
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=887543
Kevin Fenzi changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #4 from Kevin Fenzi ---
See below - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
no sha256sum, but diff of svn checkout matches.
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
Issues:
1. Do you plan on building for epel5 too? Otherwise, you can drop the first 2
lines.
2. On versioning, this is really a 'post release snapshot' no?
ie, 0.21 was a version as released, but this has some svn commits after this.
Really the only way to know for sure is to ask upstream, but if it's a post
release snap,
I would go with 'N.svn%{svn_rev}%{?dist}' where N is the increasing number for
the Fedora package, until 0.22 (or whatever comes out)
3. You might also ask upstream to clarify which version of the GPL they mean
and
if they want to specify "or later". In the absense of that information, GPL+
should be used.
You could also ask them to include a copy of the GPL COPYING file.
4. rpmlint says:
Ignore all these:
trac-sensitivetickets-plugin.noarch: W: spelling-error %description -l en_US
checkbox -> check box, check-box, checkbook
trac-sensitivetickets-plugin.noarch: W: spelling-error %description -l en_US
viewable -> view able, view-able, viable
trac-sensitivetickets-plugin.noarch: W: no-documentation
trac-sensitivetickets-plugin.src: W: spelling-error %description -l en_US
checkbox -> check box, check-box, checkbook
trac-sensitivetickets-plugin.src: W: spelling-error %description -l en_US
viewable -> view able, view-able, viable
trac-sensitivetickets-plugin.src: W: invalid-url Source0:
trac-sensitivetickets-plugin-0.21.svn12442.tar.gz
2 packages and 0 specfiles checked; 0 errors, 8 warnings.
Use %% for macros in "comments":
trac-sensitivetickets-plugin.src:15: W: macro-in-comment %{svn_rev}
trac-sensitivetickets-plugin.src:15: W: macro-in-comment %{svn_rev}
None of those are really blockers, although we should make sure the versioning
is all
figured out before import, so if there's any disagreement about that, we should
discuss it before importing. ;) This package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=gBJw06PFm3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785479] Review Request: php-horde-Horde-Constraint - Horde Constraint library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785479 --- Comment #12 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Constraint.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Constraint-2.0.1-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tLQ1ociD3h&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785480] Review Request: php-horde-Horde-Log - Horde Logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785480 --- Comment #10 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Log.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Log-2.0.1-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DQzxZAFPgO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785444] Review Request: php-horde-Horde-Alarm - Horde Alarm Libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785444 --- Comment #4 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Alarm.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Alarm-2.0.2-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RfVc5S1bj1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888598] New: Review Request: opengrm-ngram - Library for making and modifying n-gram language models
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888598 Bug ID: 888598 Summary: Review Request: opengrm-ngram - Library for making and modifying n-gram language models Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: loganje...@gmail.com Spec URL: http://jjames.fedorapeople.org/opengrm-ngram/opengrm-ngram.spec SRPM URL: http://jjames.fedorapeople.org/opengrm-ngram/opengrm-ngram-1.0.3-1.fc19.src.rpm Description: The OpenGrm NGram library is used for making and modifying n-gram language models encoded as weighted finite-state transducers (FSTs). It makes use of functionality in the OpenFst library to create, access and manipulate n-gram models. Operations for counting, smoothing, pruning, applying, and evaluating models are among those provided. Fedora Account System Username: jjames -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yixghTwXYz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848990] Review Request: libnetfilter_acct - A library providing interface to extended accounting infrastructure
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848990 --- Comment #20 from Hushan Jia --- thanks for git repo setup. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BUd4w07boQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887543] Review Request: trac-sensitivetickets-plugin - Plugin for Trac that enables sensitive tickets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|ke...@scrye.com Flags||fedora-review? --- Comment #3 from Kevin Fenzi --- I'll go ahead and review this. Look for a full review later today... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0TDoPnPbx5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882531] Review Request: mate-file-manager-sendto - Send to plugin for MATE file manager
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882531 Dan Mashal changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Dan Mashal --- New Package SCM Request === Package Name: mate-file-manager-sendto Short Description: MATE Desktop file manager send to plugin. Owners: vicodan rdieter nmarques Branches: f16 f17 f18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=csfv1Kmq0R&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823337] Review Request: rubygem-mixlib-shellout - mixin for running external commands
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823337 --- Comment #13 from Julian C. Dunn --- Updated spec and SRPM: http://fedorapeople.org/~jdunn/rubygem-mixlib-shellout/rubygem-mixlib-shellout.spec http://fedorapeople.org/~jdunn/rubygem-mixlib-shellout/rubygem-mixlib-shellout-1.1.0-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WnEWfXnlgv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878660] Review Request: openshift-origin-node-util - Utility scripts for the OpenShift Origin node
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878660 --- Comment #10 from Troy Dawson --- Spec URL: http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-node-util.spec SRPM URL: http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-node-util-1.2.7-3.fc18.src.rpm I had totally forgot about the systemd scripts. They are in there now, as well as a cleaner %if statement for checking for systemd. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TmglA8Iek6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882561] Review Request: mate-bluetooth - MATE Desktop Bluetooth applet
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882561 Dan Mashal changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Dan Mashal --- That is correct. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vwZ7aeiekj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878660] Review Request: openshift-origin-node-util - Utility scripts for the OpenShift Origin node
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878660 --- Comment #9 from Michael Scherer --- Sorry, I was not clear when i said macro for systemd, i wanted to speak about %post macros : https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f8eJrGh7Ic&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 750139] Review Request: lv2-mdala-plugins - LV2 port of the MDA VST plugins
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=750139 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4PJZh0GsZo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 750139] Review Request: lv2-mdala-plugins - LV2 port of the MDA VST plugins
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=750139 --- Comment #21 from Fedora Update System --- lv2-mdala-plugins-1.0.0-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ApxyKbwWei&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886103] Review Request: plexus-root-pom - Plexus Root POM file
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886103 --- Comment #7 from Fedora Update System --- plexus-root-pom-1.0.3-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QS1v71PWOZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886103] Review Request: plexus-root-pom - Plexus Root POM file
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886103 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y4YzwIjdZb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878660] Review Request: openshift-origin-node-util - Utility scripts for the OpenShift Origin node
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878660 --- Comment #8 from Troy Dawson --- Spec URL: http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-node-util.spec SRPM URL: http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-node-util-1.2.7-2.fc18.src.rpm - Updated to 1.2.7, the latest stable release, which also has your patches in it. - This release has the systemd macros - I have verified (as you did) that the %post script /sbin/restorecon /usr/sbin/oo-restorer* isn't needed on Fedora, and have removed it. I will check with upstream to see if it is possibly needed in RHEL. If so, we'll have it in an %if statement. If not, we'll remove it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OYg4j2IfBj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858841] Review Request: owncloud - Private file sync and share server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858841 --- Comment #37 from Gregor Tätzner --- here we go: Spec URL: http://brummbq.fedorapeople.org/owncloud.spec SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.8-6.fc17.src.rpm - php-when and phpass (pronounced ph-pass ;)) are out FPC-ticket: https://fedorahosted.org/fpc/ticket/236 -> we don't need to remove the js-libs, there are no guidelines -> the php class smb4php is adjusted to owncloud, I wouldn't dare to replace it with a genuine -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5olBBbZLmz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887778] Review Request: cutter - A Unit Testing Framework for C
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=887778
--- Comment #3 from Michael Schwendt ---
> %clean
> rm -rf %{buildroot}
Unless you want to build this for EL-5, %clean is not necessary anymore:
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=T3qP4oO4Vx&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887778] Review Request: cutter - A Unit Testing Framework for C
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=887778
--- Comment #2 from Michael Schwendt ---
> cxxtest
Misleading IMO. I've filed bug 888509 about that.
Btw, there's "cpptest" as an example of how to package something like this.
[...]
A first look at the submitted package:
> Summary: A Unit Testing Framework for C/C++
Similar to your -devel package %summary, omitting the leading article makes it
more readable.
Summary: Unit Testing Framework for C/C++
Once can more quickly focus on the importing part.
> Summary:Libraries and header files for Cutter development
And as one can see, here you also didn't start with "The libraries and ...".
:-)
> Group: Development/Tools
Rather "Development/Libraries". Perhaps "Development/Languages". Afterall, this
isn't just a utility/tool to install and run.
> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-%(%{__id_u} -n)
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
The "fedora-review" tool complains about this tag, too.
> cutter-1.2.2/glib-compatible/pcre/pcre_fullinfo.c
The fedore-review tool here discovers license "BSD (3 clause)", but a closer
look reveals that this is an old bundled PCRE lib for glib 2.12, which isn't
used for a newer glib2.
glib-compatible/gregex.c:
28 #ifdef USE_SYSTEM_PCRE
29 #include
30 #else
31 #include "pcre/pcre.h"
32 #endif
So, only for completeness and in case any older target system features an old
glib, I need to point at
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries and it may be
safer to delete this bundled lib at the end of the %prep section, so if used it
would cause a build failure. ;-)
> BuildRequires: intltool
> BuildRequires: glib2-devel
> BuildRequires: libsoup-devel
> checking for GTK+ - version >= 2.12.0... no
> *** Could not run GTK+ test program, checking why...
> *** The test program failed to compile or link. See the file config.log for
> the
> *** exact error that occured. This usually means GTK+ is incorrectly
> installed.
This warning in the build.log made me curious. What happens if one adds
"BuildRequires: gtk2-devel"? The build fails:
error: Installed (but unpackaged) file(s) found:
/usr/lib64/libgdkcutter-pixbuf.so
/usr/lib64/libgdkcutter-pixbuf.so.0
/usr/lib64/libgdkcutter-pixbuf.so.0.1.0
Why isn't gtk2-devel built with?
Is anything else missing? The build output contains a few more "No" answers to
configure existance checks.
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires
For sake of "reproducible builds", it's common practice to either add missing
BuildRequires or add --disable-foo options to explicitly build without certain
features, even if the build dependencies are installed.
> %package devel
> Group: Development/Tools
Same suggestion as above.
> Requires: %{name} = %{version}-%{release}
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
> make %{?_smp_mflags}
Please prepend V=1 for verbose build output. That makes build system
build.log contents much more useful in case of errors. That's also the only way
to see that the global compiler flags are used actually (not just prior for the
configure check):
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
> %install
> rm -rf %{buildroot}
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
> find %{buildroot} -name keep-me -size 0 -delete
Hmmm? :) An excellent opportunity to add a brief comment to the spec file
_why_ this is being done.
$ find cutter-1.2.2|grep keep
cutter-1.2.2/sample/stack/config/keep-me
> %find_lang %{name}
> %{_mandir}/ja/man1/*
You could use
%find_lang %{name} --with-man --all-name
and not only would it find and add also the translated (currently only
Japanese) manual pages (instead of you having to add then in the %files section
manually), it would also flag them with the corresponding lang(…) marker. For
example, the suggested %find_lang command would add these entries:
%lang(ja) /usr/share/locale/ja/LC_MESSAGES/cutter.mo
%lang(ja) /usr/share/man/ja/man1/*
> cutter-1.2.2/test/
Sounds like this could/should be added to %check section.
%check
V=1 LD_LIBRARY_PATH=$(pwd)/cutter/.libs make check
Objections? Should I take a second look? ;)
$ rpmls -p cutter-1.2.2-2.fc18.3.x86_64.rpm|grep ^d
drwxr-xr-x /usr/lib64/cutter/module
drwxr-xr-x /usr/lib64/cutter/module/factory
drwxr-xr-x /usr/lib64/cutter/module/factory/report
drwxr-xr-x /usr/lib64/cutter/module/factory/stream
drwxr-xr-x /usr/lib64/cutter/module/factory/ui
drwxr-xr-x /usr/lib64/cutter/module/report
drwxr-xr-x /usr/lib64/cutter/module/stream
drwxr-xr-x /usr/lib64/cutter/module/ui
drwxr-xr-x /usr/share/cutter/icons/kinotan
drwxr-xr-x /usr/share/cutter/ui
drwxr-xr-x /usr/share/doc/cutter-1.2.2
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
/usr/lib64/cutter is not included in the package.
/usr/share/cutt
[Bug 883478] Review Request: python-logging-tree - Introspect and display the logger tree inside "logging"
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883478 --- Comment #10 from Fedora Update System --- python-logging-tree-1.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-logging-tree-1.1-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5ml3eVCXA9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883478] Review Request: python-logging-tree - Introspect and display the logger tree inside "logging"
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883478 --- Comment #9 from Fedora Update System --- python-logging-tree-1.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-logging-tree-1.1-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n6rRRvkWnS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #26 from Fedora Update System --- log4c-1.2.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/log4c-1.2.2-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CWjLBrkHDc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883478] Review Request: python-logging-tree - Introspect and display the logger tree inside "logging"
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883478 --- Comment #8 from Fedora Update System --- python-logging-tree-1.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-logging-tree-1.1-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AEVNDNaqXa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883478] Review Request: python-logging-tree - Introspect and display the logger tree inside "logging"
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883478 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lLuWfO4U1F&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887907] Review Request: fcitx-anthy - Anthy Engine for Fcitx
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887907 Eduardo Echeverria changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|echevemas...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nliVDTjxTx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882561] Review Request: mate-bluetooth - MATE Desktop Bluetooth applet
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882561 Nelson Marques changed: What|Removed |Added Assignee|nob...@fedoraproject.org|nmo.marq...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BWgLRGU2gD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882561] Review Request: mate-bluetooth - MATE Desktop Bluetooth applet
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882561 Nelson Marques changed: What|Removed |Added CC||nmo.marq...@gmail.com --- Comment #1 from Nelson Marques --- Configure summary: Compiler: gcc Compiler Flags..: -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic Prefix..: /usr Moblin interface: no caja-sendto plugin..: yes Documentation...: no GObject-Introspection...: yes Your current setup doesn't build the caja-sendto plugin; This is bad as we truly want this feature to be enabled; This package can't be reviewed properly before BZ#882531 is properly closed and approved as we will need that development package to successfully build the caja-sendto extension for Bluetooth. The output above is from a personal test run locally and everything works fine, so lets first finish BZ#882531 and then think to closing this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nmbWCCPU5v&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=888301
--- Comment #3 from Antonio Trande ---
Note: this is an 'unofficial package review'; it could contain errors and is
not officially valid. :)
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: orthanc-0.4.0-2.fc17.spec should be orthanc.spec
See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name
Rename .spec file: orthanc.spec
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
There are two components differently licensed (according to the README file
included on package).
The 'License' tag for the rpm so should be 'GPLv3+ and BSD and MIT'. However
README file reports a
'GPLv3 license with the OpenSSL exception' that seems not compatible with GPLv3
(see http://fedoraproject.org/wiki/Licensing:Main)
In my opinion, you should contact Fedora Project Legal
(http://fedoraproject.org/wiki/Legal:Main) or wait other comments.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)",
"zlib/libpng", "BSD (3 clause)", "BSD (2 clause)". 6 files have unknown
license. Detailed output of licensecheck in
/home/sagitter/888301-orthanc-0.4.0-2.fc17/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: No %config files under /usr.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[!]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: orthanc-0.4.0-2.fc17.spec should be orthanc.spec
Rename .spec file: orthanc.spec
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 51200 bytes in 4 files.
[x]: Packages must not store files under /srv, /opt or /usr/lo
[Bug 887907] Review Request: fcitx-anthy - Anthy Engine for Fcitx
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887907 --- Comment #4 from Eduardo Echeverria --- Hi Liang I'll take the review But first some comments: - Please bump the release number of the spec file on changes and try to write a meaningful changelog entry (So far you have made three changes and these should be reflected in the changelog) https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs - I've seen the patch, and I find that has patched the COPYING file (license) --- a/COPYING +++ b/COPYING @@ -2,7 +2,7 @@ Version 2, June 1991 Copyright (C) 1989, 1991 Free Software Foundation, Inc. - 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. @@ -305,7 +305,7 @@ the "copyright" line and a pointer to where the full notice is found. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software -Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. In the explanation of the common rpmlint issues, can be read in https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address The license file, usually COPYING, must not be patched for legal reasons. Other files can be patched if deemed suitable -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tZnDkNmgUp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886164] Review Request: python-dogpile-cache - A caching front-end based on the Dogpile lock.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886164 --- Comment #8 from Fedora Update System --- python-dogpile-cache-0.4.0-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-dogpile-cache-0.4.0-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HXRRtvHXeG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886164] Review Request: python-dogpile-cache - A caching front-end based on the Dogpile lock.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886164 --- Comment #7 from Fedora Update System --- python-dogpile-cache-0.4.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-dogpile-cache-0.4.0-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EmfES8I8Iy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886164] Review Request: python-dogpile-cache - A caching front-end based on the Dogpile lock.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886164 --- Comment #6 from Fedora Update System --- python-dogpile-cache-0.4.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-dogpile-cache-0.4.0-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=is6Lm9u6S8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886164] Review Request: python-dogpile-cache - A caching front-end based on the Dogpile lock.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886164 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c1TcpreFTp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882559] Review Request: mate-file-manager-image-converter - MATE Desktop file manager image converter plugin
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882559 --- Comment #4 from Nelson Marques --- Dan, I have reworked the spec file to fix most issues I've found, and I'm happy I haven't pushed this forward as some issues passed. http://nmarques.fedorapeople.org/882559/mate-file-manager-image-converter.spec You have there the spec re-worked, see if you can use it or rework the current spec to address the following issues: 1) %post/%postun entries are not required; we don't install any files in the path of the dynamic linker; 2) Improved summary and description; 3) Removed find entry for static blobs; --disable-static is working properly, no static blobs are being generated; 4) Add mate-file-manager for runtime dependency; this is disputable, but the dependencies added by RPM can be complemented. About 2) I don't really care, but the others are need to be fixed, so you can either use 'ipsis verbis' my spec or you can rework yours to meet the criteria. Let me know so I can run stuff again. And please no more 'We can fix that later', later is now :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UrNS5YbGyI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886261] Review Request: php-when - Date/Calendar recursion library for PHP 5.2+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261 --- Comment #13 from Fedora Update System --- php-when-0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-when-0.3-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vFwW40DDok&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886261] Review Request: php-when - Date/Calendar recursion library for PHP 5.2+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261 --- Comment #12 from Fedora Update System --- php-when-0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-when-0.3-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PSQC5IG8ew&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886261] Review Request: php-when - Date/Calendar recursion library for PHP 5.2+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261 --- Comment #11 from Fedora Update System --- php-when-0.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-when-0.3-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TnookylE7B&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886230] Review Request: php-phpass - Portable password hashing framework for use in PHP applications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230 --- Comment #8 from Fedora Update System --- php-phpass-0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-phpass-0.3-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i5DSbRTF2J&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886261] Review Request: php-when - Date/Calendar recursion library for PHP 5.2+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wc2qPMepG3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886230] Review Request: php-phpass - Portable password hashing framework for use in PHP applications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230 --- Comment #6 from Fedora Update System --- php-phpass-0.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-phpass-0.3-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y8MTPvOpqp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886230] Review Request: php-phpass - Portable password hashing framework for use in PHP applications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230 --- Comment #7 from Fedora Update System --- php-phpass-0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-phpass-0.3-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tzBufFZSX1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886230] Review Request: php-phpass - Portable password hashing framework for use in PHP applications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZN0b6ZvHXU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823337] Review Request: rubygem-mixlib-shellout - mixin for running external commands
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823337 --- Comment #12 from Julian C. Dunn --- Upstream tickets and pull requests have been filed. http://tickets.opscode.com/browse/MIXLIB-6 http://tickets.opscode.com/browse/MIXLIB-7 I'll update the spec with these patches and rebuild. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LQX7irtneB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815018] Review Request: nodejs - javascript fast build framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815018 --- Comment #80 from Stephen Gallagher --- I'm actually planning to put together a Fedora 19 Feature Page for this, which I suppose I should do now so I don't forget. That will ensure that it shows up in the release notes. We still need to package npm to make Node.js fully useful for development, which I'm going to look into with T.C. Hollingsworth as per comment #48 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5GvShHlJ9y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815018] Review Request: nodejs - javascript fast build framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815018 --- Comment #79 from Peter Lemenkov --- (In reply to comment #78) > Amazing! > > This should be marketed! I just realized that I also think so. This is a huge step forward and worths mentioning in the marketing docs / release info. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AJqT82pufL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815018] Review Request: nodejs - javascript fast build framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815018 --- Comment #78 from Victor Costan --- Amazing! This should be marketed! Fedora has better support for Web development than competing distributions, and this is not very well known. I'm not just referring to node.js, I also like the up-to-date kernels, nginx, Rails 3.2. I hope this helps. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HlD8cVv9ca&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815018] Review Request: nodejs - javascript fast build framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815018 --- Comment #77 from Sergio Monteiro Basto --- Hi, Any particular reason to not build in F17 ? Thanks, -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JOnQS4wC4t&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815018] Review Request: nodejs - javascript fast build framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815018 --- Comment #76 from Fedora Update System --- nodejs-0.9.3-7.fc18,libuv-0.9.3-0.3.git09b0222.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-0.9.3-7.fc18,libuv-0.9.3-0.3.git09b0222.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EI6GMcrWyt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874689] Review Request: libuv - Platform layer for node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874689 --- Comment #11 from Fedora Update System --- nodejs-0.9.3-7.fc18,libuv-0.9.3-0.3.git09b0222.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-0.9.3-7.fc18,libuv-0.9.3-0.3.git09b0222.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UmzW76hJGe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 --- Comment #2 from Sebastien Jodogne --- Hi Antonio, Thank you much for your feedback! I have just uploaded an updated version of my package that takes your comments into account: Spec URL: http://www.montefiore.ulg.ac.be/~jodogne/Orthanc/Fedora/orthanc-0.4.0-2.fc17.spec SRPM URL: http://www.montefiore.ulg.ac.be/~jodogne/Orthanc/Fedora/orthanc-0.4.0-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DSyrEScfQU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879365] Review Request: system-config-network - network administration tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879365 Bill Nottingham changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #7 from Bill Nottingham --- Looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=464o2i7hgf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888385] Review Request: python-yapsy - Fat-free DIY Python plugin management toolkit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888385 --- Comment #1 from José Matos --- New version that requires at build time both python-setuptools (v2 and v3). Spec URL: http://jamatos.fedorapeople.org/python-yapsy.spec SRPM URL: http://jamatos.fedorapeople.org/python-yapsy-1.9.2-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8kAs7HV6FK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887907] Review Request: fcitx-anthy - Anthy Engine for Fcitx
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887907 --- Comment #3 from Liang Suilong --- Update: FSF address issue has been fixed. SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-anthy-0.1.1-1.fc17.src.rpm SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-anthy.spec Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4800140 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2S00c527sQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882482] Review Request: python-nikola - Static website and blog generator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882482 --- Comment #5 from José Matos --- The new version is here: Spec URL: http://jamatos.fedorapeople.org/python-nikola.spec SRPM URL: http://jamatos.fedorapeople.org/python-nikola-5-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=K68b4gieQB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882482] Review Request: python-nikola - Static website and blog generator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882482 --- Comment #4 from José Matos --- I am aware. :-) With version 5 it comes a new dependency that I need to submit in a new feature review (python-yapsy). OK, I did it while composing this message. :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zt06O7c2ZO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882482] Review Request: python-nikola - Static website and blog generator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882482 José Matos changed: What|Removed |Added Depends On||888385 --- Comment #3 from José Matos --- I am aware. :-) With version 5 it comes a new dependency that I need to submit in a new feature review (python-yapsy) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p12pIVWm7r&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888385] Review Request: python-yapsy - Fat-free DIY Python plugin management toolkit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888385 José Matos changed: What|Removed |Added Blocks||882482 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ng9QkyEC38&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888385] New: Review Request: python-yapsy - Fat-free DIY Python plugin management toolkit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888385 Bug ID: 888385 Summary: Review Request: python-yapsy - Fat-free DIY Python plugin management toolkit Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: jama...@fc.up.pt Spec URL: http://jamatos.fedorapeople.org/python-yapsy.spec SRPM URL: http://jamatos.fedorapeople.org/python-yapsy-1.9.2-1.fc18.src.rpm Description: A simple framework for plugin system development with as few dependencies as possible. It is designed to offer a set of very lean classes (plugin managers and plugin interfaces) which can easily be customised by decoration or inheritance. Fedora Account System Username: jamatos -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ArbfRNLXnd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886164] Review Request: python-dogpile-cache - A caching front-end based on the Dogpile lock.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886164 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aab47lpRNZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883478] Review Request: python-logging-tree - Introspect and display the logger tree inside "logging"
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883478 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s5i1PYBmrg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876404] Review Request: php-channel-aws - Adds the Amazon Web Services channel to PEAR
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mb0qxNWxWz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #25 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ysop4ilWkX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823338] Review Request: rubygem-moneta - unified interface for key/value stores
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823338 --- Comment #14 from Julian C. Dunn --- (In reply to comment #13) > I pulled a request to change Moneta dependency and use Juno instead [1]. > > [1] https://github.com/opscode/chef/pull/552 Awesome, thanks Josef! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y0gjaN8wl9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887907] Review Request: fcitx-anthy - Anthy Engine for Fcitx
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887907 --- Comment #2 from Liang Suilong --- I upload a new spec and a new srpm. SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-anthy-0.1.1-1.fc17.src.rpm SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-anthy.spec Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4799953 I have contacted with upstream and told him about FSF address issue. He will fix it soon. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NdMZ8lCY1x&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 František Dvořák changed: What|Removed |Added Flags||fedora-cvs? --- Comment #24 from František Dvořák --- Package Change Request == Package Name: log4c New Branches: f17 Owners: valtri Please add branch for f17, there will be packages depending on log4c. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3RUetN3G1m&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #23 from Joseph Marrero --- It is a dep for the owncloud-client. It would be nice If f17 support so I can deliver the newest updates since the current verision needs log4c thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=14GLHF3Jt1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876404] Review Request: php-channel-aws - Adds the Amazon Web Services channel to PEAR
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404 Joseph Marrero changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Joseph Marrero --- New Package SCM Request === Package Name: php-channel-aws Short Description: Adds the Amazon Web Services channel to PEAR Owners: jmarrero Branches: f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SWihOap2zM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884855] Review Request: python-webtest1.3 - Helper to test WSGI applications
Product: Fedora EPEL https://bugzilla.redhat.com/show_bug.cgi?id=884855 --- Comment #4 from Ralph Bean --- Thanks Tomas. This new release removes the python_sitelib macro definition from the top of the spec. koji build - http://koji.fedoraproject.org/koji/taskinfo?taskID=4799921 SPEC: http://threebean.org/rpm/python-webtest1.3.spec SRPM: http://threebean.org/rpm/python-webtest1.3-1.3.4-4.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YoV5lrHHkY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886164] Review Request: python-dogpile-cache - A caching front-end based on the Dogpile lock.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886164 --- Comment #3 from Ralph Bean --- Got it, Mario. Thanks again! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zBqptTpZBr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886164] Review Request: python-dogpile-cache - A caching front-end based on the Dogpile lock.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886164 Ralph Bean changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Ralph Bean --- New Package SCM Request === Package Name: python-dogpile-cache Short Description: A caching front-end based on the Dogpile lock Owners: ralph Branches: f18 f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=20FoSYdLph&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883478] Review Request: python-logging-tree - Introspect and display the logger tree inside "logging"
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883478 Ralph Bean changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Ralph Bean --- New Package SCM Request === Package Name: python-logging-tree Short Description: Introspect and display the logger tree inside "logging" Owners: ralph Branches: f18 f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4W6GuSoIzQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=888301
Antonio Trande changed:
What|Removed |Added
CC||trp...@katamail.com
--- Comment #1 from Antonio Trande ---
Hi Sebastien.
I'm not an official packager/reviewer; I'm just doing few comments.
Although this is your first package, it is already good in my opinion.
- You should pick a style and use it consistently throughout your packaging so
install -m 755 -d %{buildroot}%{_mandir}/man1 becomes install -m 755 -d
$RPM_BUILD_ROOT%{_mandir}/man1
and so on.
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
- BuildRequires: systemd-units
On Fedora 18 and newer, the systemd-units subpackage has been merged into the
base systemd package, so your package for those targets can instead include.
Fedora 18 is almost among us, maybe you could use DisTag to mark this requires
entry depending on Fedora release.
https://fedoraproject.org/wiki/Packaging:DistTag?rd=DistTag
https://fedoraproject.org/wiki/Packaging:Systemd?rd=Packaging:Guidelines:Systemd#Filesystem_locations
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ffTAyZqFAC&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848990] Review Request: libnetfilter_acct - A library providing interface to extended accounting infrastructure
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848990 --- Comment #19 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AHviFj5V8G&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
