[Bug 912602] Review Request: maven-shared-components - Maven Shared Components Parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912602 gil cattaneo punto...@libero.it changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |ERRATA Last Closed||2013-02-21 03:04:23 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8GZojXLD7Da=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912596] Review Request: maven-shared-resources - A collection of templates that are specific to the Maven project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596 Bug 912596 depends on bug 912602, which changed state. Bug 912602 Summary: Review Request: maven-shared-components - Maven Shared Components Parent POM https://bugzilla.redhat.com/show_bug.cgi?id=912602 What|Removed |Added Status|NEW |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oeNMWHvBzIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912596] Review Request: maven-shared-resources - A collection of templates that are specific to the Maven project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912596 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On|912602 | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4sU9mrzOVea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912602] Review Request: maven-shared-components - Maven Shared Components Parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912602 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks|912596 | Blocks||912596 Resolution|ERRATA |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DskSnF31qaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912602] Review Request: maven-shared-components - Maven Shared Components Parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912602 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Blocks|912596 | Blocks||912596 Resolution|ERRATA |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Z9OBrkAjCOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912132] Review Request: perl-Package-Variant - Parameterizable packages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #5 from Petr Šabata psab...@redhat.com --- Splendid. Approving. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YPUSqSXC3Na=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910125] Review Request: nodejs-formidable - A Node.js module for parsing form data, especially file uploads
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910125 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vb1q3SsIqpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910125] Review Request: nodejs-formidable - A Node.js module for parsing form data, especially file uploads
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910125 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- nodejs-formidable-1.0.11-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-formidable-1.0.11-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gQmt31Hiwka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911055] Review Request: nodejs-underscore - JavaScript's functional programming helper library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911055 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- nodejs-underscore-1.4.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-underscore-1.4.4-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wG9ZVI7l2ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911055] Review Request: nodejs-underscore - JavaScript's functional programming helper library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911055 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4BWyaUietUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910139] Review Request: nodejs-qs - Query string parser for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910139 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SiOoQXlvHha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910139] Review Request: nodejs-qs - Query string parser for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910139 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nodejs-qs-0.5.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-qs-0.5.3-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ikzqkN2PHJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910141] Review Request: nodejs-sax - A streaming SAX-style XML parser in JavaScript for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910141 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gxU3x4T3Jza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910141] Review Request: nodejs-sax - A streaming SAX-style XML parser in JavaScript for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910141 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- nodejs-sax-0.5.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-sax-0.5.2-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LSk7svhl2Aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=himqAUyzsRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- nodejs-pkginfo-0.3.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-pkginfo-0.3.0-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DQNBZwFvs0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911031] Review Request: nodejs-generic-pool - Generic resource pooling for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911031 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xRofI3P8zfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911031] Review Request: nodejs-generic-pool - Generic resource pooling for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911031 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- nodejs-generic-pool-2.0.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-generic-pool-2.0.3-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wYHQdDq088a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911175] Review Request: nodejs-cssom - CSS Object Model implementation and CSS parser for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911175 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yAMNrk3zXLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911175] Review Request: nodejs-cssom - CSS Object Model implementation and CSS parser for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911175 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- nodejs-cssom-0.2.5-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-cssom-0.2.5-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7qLNRGjMaOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865699] Review Request: ladish - LADI Audio session handler
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=865699
--- Comment #13 from Eduardo Echeverria echevemas...@gmail.com ---
(In reply to comment #12)
libalsapid is not a regular library. It is not explicitly linked (as in ld)
to any executable (public library) nor it is private library (plugin). It is
LD_PRELOAD-ed. If it has SONAME, will it properly hook libasound on Fedora?
Hi nedko, I'll try to explain me, the library is stored in LDPATH, here the
library should have SONAME, ok we agree, the lib is not public but should be
located outside LDPATH.
Debian's Packagers [1] took the same path as Brendan, moved the lib to
%{_libdir}/%{name} and symlink into the %{_libdir}, but I'm not sure that's the
best solution according to our guidelines.
However if someone is sure this does not conflict with our guidelines, I invite
you to look at this package and approve it
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641452
Kind Regards
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=cc5X86joDka=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910150] Review Request: nodejs-express - Sinatra inspired web development framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910150 --- Comment #2 from Jamie Nguyen jamieli...@fedoraproject.org --- Update to upstream release 3.1.0. Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-express.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-express-3.1.0-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rGkGW5qlFsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 --- Comment #3 from Jamie Nguyen jamieli...@fedoraproject.org --- Update to upstream release 2.7.3. Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-connect.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-connect-2.7.3-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d2clq3UkVqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913254] Review Request: arm-none-eabi-newlib - C library intended for use on arm-none-eabi embedded systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913254 --- Comment #2 from Michal Hlavinka mhlav...@redhat.com --- (In reply to comment #1) I regret not being able to avoid this, this step seems inevitable to me, because newlib repeatedly has been accused of not being compliant to Fedora's legal restrictions. Do you have any links to bugzilla, mail archives,... anything? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fLxgh1ALToa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910441] Review Request: perl-POSIX-AtFork - Hook registrations at fork(2)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910441 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #1 from Petr Šabata psab...@redhat.com --- No issues whatsoever, approving. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8LWO8IehOHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877985] Review Request: pss - A power-tool for searching inside source code files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877985 Kushal Das kushal...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Kushal Das kushal...@gmail.com --- New Package SCM Request === Package Name: pss Short Description: A power-tool for searching inside source code file Owners: kushal Branches: el6 f18 f17 InitialCC: kushal -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EUlTvrKYrNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 Matthias Runge mru...@redhat.com changed: What|Removed |Added CC||mru...@redhat.com Assignee|nob...@fedoraproject.org|mru...@redhat.com --- Comment #2 from Matthias Runge mru...@redhat.com --- will do the review. If anybody else is faster, please go ahead! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jvlEmf8dyca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829892] Review Request: python27 - Parallel-installable Python 2.7 for EPEL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829892 --- Comment #2 from Aurelien Bompard aurel...@bompard.org --- Oops, apparently I made a mistake which prevented the build on EPEL5. Here's a new version of my patch: http://abompard.fedorapeople.org/misc/python27/python27.patch The specfile and the SRPMs are here: http://abompard.fedorapeople.org/misc/python27/ Builds: EL5: http://koji.fedoraproject.org/koji/taskinfo?taskID=5039214 EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=5039258 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WqA2J6751Za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913481] New: Review Request: perl-Net-SFTP-Foreign - SSH File Transfer Protocol client for Perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913481 Bug ID: 913481 Summary: Review Request: perl-Net-SFTP-Foreign - SSH File Transfer Protocol client for Perl Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: fedora...@rule.lv Spec URL: http://unibackup.rule.lv/perl-Net-SFTP-Foreign.spec SRPM URL: http://unibackup.rule.lv/perl-Net-SFTP-Foreign-1.74.5-1.fc18.src.rpm Description: SSH File Transfer Protocol client for Perl Fedora Account System Username: normunds -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EG5xjPBHQra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913481] Review Request: perl-Net-SFTP-Foreign - SSH File Transfer Protocol client for Perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913481 --- Comment #1 from Normunds fedora...@rule.lv --- Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5026833 http://koji.fedoraproject.org/koji/taskinfo?taskID=5026938 http://koji.fedoraproject.org/koji/taskinfo?taskID=5026990 http://koji.fedoraproject.org/koji/taskinfo?taskID=5027114 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8Z39s5efY8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913254] Review Request: arm-none-eabi-newlib - C library intended for use on arm-none-eabi embedded systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913254 --- Comment #3 from Michal Hlavinka mhlav...@redhat.com --- licensecheck.txt from fedora-review contains (file paths omitted): BSD (4 clause) ISC LGPL (v2.1 or later) (with incorrect FSF address) LGPL (v2 or later) GPL (v2 or later) GPL (v3 or later) Unknown or generated #it's GPLv2+ BSD (4 clause) MIT/X11 (BSD like) Public domain BSD (3 clause) BSD (3 clause) ISC LGPL (v2 or later) (with incorrect FSF address) ISC *No copyright* Public domain *No copyright* BSD (2 clause) GPL (v2 or later) (with incorrect FSF address) BSD (3 clause) BSD (2 clause) zlib/libpng BSD I did not find any licensing issue myself. Newlib's homepage states: It is a conglomeration of several library parts, all under free software licenses that make them easily usable on embedded products. So I did not find any issue. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cRzE5GKxCja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749673] eclipse-mylyn: Build Eclipse Mylyn code review integration
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=749673 Fedora Admin XMLRPC Client fedora-admin-xml...@redhat.com changed: What|Removed |Added Assignee|sgehw...@redhat.com |kdan...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uauiVlRaMIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749673] eclipse-mylyn: Build Eclipse Mylyn code review integration
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=749673 --- Comment #9 from Fedora Admin XMLRPC Client fedora-admin-xml...@redhat.com --- This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ScHzXB40VVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913254] Review Request: arm-none-eabi-newlib - C library intended for use on arm-none-eabi embedded systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913254 --- Comment #4 from Ralf Corsepius rc040...@freenet.de --- (In reply to comment #2) Do you have any links to bugzilla, mail archives,... anything? Sorry, I don't have such references at hand and would have to google. However, I recall discussions on legal issues with newlib in context to Fedora in the early days of Fedora (IIRC, Spot was involved). [First of all, let me clarify my position: I am a long term contributor to newlib and co-maintainer of the RTEMS toolchains. Besides cygwin, RTEMS is one the primary users of newlib.] The topics, which repeatedly have caused discussions with newlib's licenses were: - Newlib's source-tarball contains GPL'ed files. The RH-newlib maintainers (Notably RH employee Jeff Johnston) have always claimed the newlib-runtimes to be free (non-GPL'ed), when the GPL'ed parts (e.g. linux + rdos) are not used during compilation. I.e. newlib's intention is to license the sources and runtime under different licenses. Besides this, the fact newlib carries GPL'ed files isn't new and is well known in the GCC-community and to my knowledge has never, ever been subject to complaints from Linus Torvalds, RMS nor other GPL-enforcement folks. - The number of licenses newlib files apply is large. Apparently this number of licenses is too large for some people to understand. However, it has always been newlib's intention to be licensed under a liberal BSDish license umbrella for all targets, except those targets which are subject to the GPL. To cut a long story short: I only blocked fe-legal to produce a precedent to have the newlib situation clarified once and for all times, to avoid further confusions. I regret it hit your package, but rest assured, it's not meant against you personally nor against your package. I personally do not see any problems with newlib's license. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=K1YCszh6Nua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913254] Review Request: arm-none-eabi-newlib - C library intended for use on arm-none-eabi embedded systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913254 --- Comment #5 from Ralf Corsepius rc040...@freenet.de --- (In reply to comment #3) licensecheck.txt from fedora-review contains (file paths omitted): BSD (4 clause) ISC LGPL (v2.1 or later) (with incorrect FSF address) LGPL (v2 or later) GPL (v2 or later) GPL (v3 or later) Unknown or generated #it's GPLv2+ BSD (4 clause) MIT/X11 (BSD like) Public domain BSD (3 clause) BSD (3 clause) ISC LGPL (v2 or later) (with incorrect FSF address) ISC *No copyright* Public domain *No copyright* BSD (2 clause) GPL (v2 or later) (with incorrect FSF address) BSD (3 clause) BSD (2 clause) zlib/libpng BSD I did not find any licensing issue myself. Newlib's homepage states: It is a conglomeration of several library parts, all under free software licenses that make them easily usable on embedded products. Correct. That's what I was referring to above. So I did not find any issue. This question is: Which license will your toolchain be under and which license will the binaries compiled/linked against your newlib be under? As newlib linked binaries are statically linked, and if not applying the runtime vs. source tarball license separation, but using the GPL umbrella, your toolchain and all compiled binaries automatically are GPLv3'ed (rsp. the sources required to be GPLv3 compatible). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MMMLr3wBTIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913152] Review Request: MUMPS - A MUltifrontal Massively Parallel sparse direct Solver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913152 --- Comment #2 from Antonio Trande trp...@katamail.com --- (In reply to comment #1) Run repoquery --whatprovides 'libopen-rte.4()(64bit)' to find that nothing provides that library SONAME. Hence nothing satisfies the dependency. The library file is include in some non-public path in openmpi-1.6.3-7.fc18.x86_64.rpm - http://koji.fedoraproject.org/koji/rpminfo?rpmID=3664682 - but it seems the automatic Provides are filtered. The %changelog mentions bug 741104 (Exclude private libraries from provides/requires). Some investigation is needed. Hi Michael. I have added %__requires_exclude_* macros to prevent the libraries request from openmpi. openmpi downgrading seems not resolve the problem. Spec URL: http://sagitter.fedorapeople.org/MUMPS/MUMPS.spec SRPM URL: http://sagitter.fedorapeople.org/MUMPS/MUMPS-4.10.0-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OOeQIdZvE6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913496] New: Review Request: cbi-plugins - A set of helpers for Eclipse CBI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913496 Bug ID: 913496 Summary: Review Request: cbi-plugins - A set of helpers for Eclipse CBI Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: kdan...@redhat.com Spec URL: http://kdaniel.fedorapeople.org/cbi-plugins/cbi-plugins.spec SRPM URL: http://kdaniel.fedorapeople.org/cbi-plugins/cbi-plugins-1.0.1-0.1.git120561.fc18.src.rpm Description: A set of helpers for Eclipse CBI Fedora Account System Username: kdaniel -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8pwbyYlSpUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913500] New: Review Request: coro-mock - A mock library for compiling JVM coroutine-using code on JVMs without coroutines
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913500 Bug ID: 913500 Summary: Review Request: coro-mock - A mock library for compiling JVM coroutine-using code on JVMs without coroutines Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: bkab...@redhat.com Spec URL: http://bkabrda.fedorapeople.org/pkgs/coro-mock/coro-mock.spec SRPM URL: http://bkabrda.fedorapeople.org/pkgs/coro-mock/coro-mock-1.0-0.2.e55ca83git.fc18.src.rpm Description: A mock library for compiling JVM coroutine-using code on JVMs without coroutines. Fedora Account System Username: bkabrda Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5039343 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NycNyCmpIra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913152] Review Request: MUMPS - A MUltifrontal Massively Parallel sparse direct Solver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913152 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added CC||mschwe...@gmail.com --- Comment #3 from Michael Schwendt mschwe...@gmail.com --- That sounds questionable. Either the libs are _private_ and nothing external ought to depend on them - then it's okay to hide their automatic Provides. Or external pieces may depend on them, and then it would not be okay to kill the RPM dependencies in any of the packages. I'll mail openmpi-owner(s) and Cc you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=plCOIQkp4ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330 --- Comment #5 from Normunds fedora...@rule.lv --- Thank you for your review :) * Description fixed * Unneeded chmod a-x removed. * Updated to version 0.18, ran tests. * Added perl(NetAddr::IP) build dependency as it is required in new module. Best regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SawaCnuUORa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 --- Comment #4 from Normunds fedora...@rule.lv --- Thanks :) * Removed BuildRequires except MakeMaker and samba dependency. * Added OPTIMIZE to Makefile.PL * Re-tested with Mock, currently re-testing with koji. Will post a note here if something fails (max 2 hours from now). Best regards. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UbaKpJhIKBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913496] Review Request: cbi-plugins - A set of helpers for Eclipse CBI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913496 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||akurt...@redhat.com Assignee|nob...@fedoraproject.org|akurt...@redhat.com Flags||fedora-review? --- Comment #1 from Alexander Kurtakov akurt...@redhat.com --- I'll do this one. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mGpyMfm4nMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330 --- Comment #6 from Petr Šabata psab...@redhat.com --- (In reply to comment #5) Thank you for your review :) * Description fixed Ack. * Unneeded chmod a-x removed. Ack. * Updated to version 0.18, ran tests. Ack. * Added perl(NetAddr::IP) build dependency as it is required in new module. Ack, but you'll also need those two: perl(lib) perl(Scalar::Util) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hkycpTHR91a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912132] Review Request: perl-Package-Variant - Parameterizable packages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Iain Arnell iarn...@gmail.com --- New Package SCM Request === Package Name: perl-Package-Variant Short Description: Parameterizable packages Owners: iarnell Branches: F17 F18 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eld1pUqGgya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913496] Review Request: cbi-plugins - A set of helpers for Eclipse CBI
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=913496
--- Comment #2 from Alexander Kurtakov akurt...@redhat.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Note: No javadoc subpackage present
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
Javadoc subpackage should be present.
- Packages have proper BuildRequires/Requires on jpackage-utils
See: https://fedoraproject.org/wiki/Packaging:Java
You need to require jpackage-utils as it's the owner of the directories files
are installed into.
- Javadoc documentation files are generated and included in -javadoc
subpackage
Note: No javadoc subpackage present
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[!]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in /home/akurtakov/tmp/913496-cbi-plugins/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
[x]: Fully versioned dependency in subpackages, if present.
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: Pom files have correct add_maven_depmap call
Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from
[Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330 --- Comment #7 from Normunds fedora...@rule.lv --- Ugh! How did I miss that? * Added build dependencies lib, Scalar::Util * Changed Download URI as it was changed. Thanks :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZBBx3WmLmca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from Petr Šabata psab...@redhat.com --- Awesome, approving :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B0hCPILrr2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913481] Review Request: perl-Net-SFTP-Foreign - SSH File Transfer Protocol client for Perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913481 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JjKrDltfspa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330 Normunds fedora...@rule.lv changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Normunds fedora...@rule.lv --- Thank you. Requesting CVS. New Package SCM Request === Package Name: perl-Data-Validate-IP Short Description: Perl IP address validation routines Owners: normunds psabata Branches: f17 f18 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1zVCSHLZ6ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913496] Review Request: cbi-plugins - A set of helpers for Eclipse CBI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913496 --- Comment #3 from Krzysztof Daniel kdan...@redhat.com --- Spec URL: http://kdaniel.fedorapeople.org/cbi-plugins2/cbi-plugins.spec SRPM URL: http://kdaniel.fedorapeople.org/cbi-plugins2/cbi-plugins-1.0.1-0.2.git120561.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=K7PhDSxrNma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913500] Review Request: coro-mock - A mock library for compiling JVM coroutine-using code on JVMs without coroutines
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913500 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||socho...@redhat.com Assignee|nob...@fedoraproject.org|socho...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3i30mvLRWla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913496] Review Request: cbi-plugins - A set of helpers for Eclipse CBI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913496 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Alexander Kurtakov akurt...@redhat.com --- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AyNOpQvH9aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913496] Review Request: cbi-plugins - A set of helpers for Eclipse CBI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913496 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Krzysztof Daniel kdan...@redhat.com --- New Package SCM Request === Package Name: cbi-plugins Short Description: A set of helpers for Eclipse CBI Owners: kdaniel Branches: f19 InitialCC: kdaniel -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IRt5kkEATwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756491] Review Request: python-libcloud - Python library that abstracts away differences among multiple cloud provider APIs.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=756491 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5Nj7dwdPtga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877985] Review Request: pss - A power-tool for searching inside source code files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877985 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XnJFjnbra3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1jhMQsGu3ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912132] Review Request: perl-Package-Variant - Parameterizable packages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SJv22i3j4Ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913496] Review Request: cbi-plugins - A set of helpers for Eclipse CBI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913496 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=H2FOq89vECa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 --- Comment #9 from Rex Dieter rdie...@math.unl.edu --- Spec URL: http://rdieter.fedorapeople.org/rpms/kdegames/klines.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegames/klines-4.10.0-3.fc18.src.rpm %changelog * Thu Feb 21 2013 Rex Dieter rdie...@fedoraproject.org 4.10.0-3 - update summary, fix typo in description -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MOJmU31FRya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flags||fedora-cvs? --- Comment #13 from Rex Dieter rdie...@math.unl.edu --- Package Change Request == Package Name: appmenu-qt New Branches: f17 Owners: jreznik rdieter rrix -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XahI102EKga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - A simple but highly addictive, one player game
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910510
nucleo alekc...@googlemail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #10 from nucleo alekc...@googlemail.com ---
MUST Items:
+ rpmlint output
$ rpmlint klines-4.10.0-1.fc18.i686.rpm
klines-debuginfo-4.10.0-1.fc18.i686.rpm klines-4.10.0-3.fc18.src.rpm
klines.spec
klines.i686: W: no-manual-page-for-binary klines
klines.src: W: spelling-error %description -l en_US Kolor - Color, Dolor
3 packages and 1 specfiles checked; 0 errors, 2 warnings.
+ named and versioned according to the Package Naming Guidelines.
Package name match the upstream tarball name klines-4.10.0.tar.xz
+ spec file name klines.spec matches base package name
+ complies with all the legal guidelines:
+ License: GPLv2+ and GFDL, matches actual license (added notices for parts
under different licenses)
+ No known patent problems
+ No emulator, no firmware, no binary-only or prebuilt components
+ COPYING (GNU GENERAL PUBLIC LICENSE Version 2), COPYING.DOC (GNU Free
Documentation License Version 1.2) packaged as %doc
+ source matches upstream:
MD5: c67ae3a077351397aeb96a33350aec4b klines-4.10.0.tar.xz
SHA1: 0886b2c788725034f4b8367a6f5db16344a87159 klines-4.10.0.tar.xz
SHA256: c97cbf53c71d05cd39068b07d8ab7948e681bbf87b9ccd567b405b1ec6371392
klines-4.10.0.tar.xz
+ builds on at least one arch
build from mock is in F18 kde-unstable repo
+ no known non-working arches, so no ExcludeArch needed
+ no missing BuildRequires (builds in mock)
+ locales are handled properly by using %find_lang %{name} --with-kde macro
+ ldconfig call not needed (no shared libraries)
+ no duplicated system libraries
+ package not relocatable (no Prefix tag)
+ directory ownership correct (doesn't own directories owned by another
package, owns all package-specific directories %{_kde4_appsdir}/%{name}/)
+ no duplicate files in %files
+ permissions correct, %defattr(-,root,root,-) not needed now, executables have
executable permissions
+ macros used where possible (%{name}, %{version}, %{buildroot},
%{_target_platform}, %{cmake_kde4}, %{_kde4_datadir}, %{_kde4_bindir},
%{_kde4_iconsdir},%{_kde4_appsdir}, %{_kde4_configdir})
+ non-code content: only permitted content, themes under license that matches
the code
+ no large documentation files, so no -doc package needed
+ no %doc files required at runtime
+ no header files, no -devel package needed
+ no static libraries, so no -static package needed
+ no devel symlinks which would need to be in a -devel subpackage
+ devel packages must require the base package (no -devel package)
+ no .la files
+ klines.desktop file for the GUI app klines present
+ desktop-file-validate is used in %check and the klines.desktop file passes
validation
+ all filenames are valid UTF-8
+ other packaging guidelines:
+ complies with the Filesystem Hierarchy Standard (all files in
%{_kde4_datadir}, %{_kde4_bindir},
%{_kde4_iconsdir},%{_kde4_appsdir},%{_kde4_configdir})
+ proper changelog, tags, BuildRequires, Summary, Description (got from
klines's documentation)
+ no non-UTF-8 characters
+ all relevant documentation included as %doc (COPYING, COPYING.DOC, AUTHORS
README.themes)
+ RPM_OPT_FLAGS are used in %{cmake_kde4} macro
+ debuginfo package is valid (contains stripped symbols from ELF binary and
source code related to it)
+ no rpaths (no check-rpaths error)
+ no configuration files, so %config guideline doesn't apply
+ no init scripts, so init script guideline doesn't apply
+ timestamps are preserved
+ %{?_smp_mflags} used
+ not a web application, so web application guideline doesn't apply
+ no conflicts (kdegames-4.10.0 is metapackage now which not includes apps)
SHOULD Items:
+ license already included upstream
+ no translations for description and summary provided by upstream
+ package builds in mock (built for kde-unstable)
- successfully tested the package functionality (no testing yet)
+ scriptlets are sane (updating icon chache in %post, %postun, %posttrans)
+ subpackages other than devel should require the base package using a fully
versioned dependency (no subpackages)
+ no .pc files, so placement of .pc files is irrelevant
+ no file dependencies
- package should contain man pages for binaries/scripts
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=pUx74aLvh6a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - Color lines game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 nucleo alekc...@googlemail.com changed: What|Removed |Added Summary|Review Request: klines - A |Review Request: klines - |simple but highly |Color lines game |addictive, one player game | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XIpLoj0gvka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881096] Review Request: openstack-packstack - OpenStack Install utility
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881096 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- openstack-packstack-2012.2.2-1.0.dev408.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/openstack-packstack-2012.2.2-1.0.dev408.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wQE08Wzzzka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FzkUS6jmira=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - Color lines game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Rex Dieter rdie...@math.unl.edu --- New Package SCM Request === Package Name: klines Short Description: Color lines game Owners: than rdieter jreznik kkofler ltinkl rnovacek Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IDiJu95GiUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907538] Review Request: python-django-extensions - extensions for Django
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907538 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6dPokFwIqja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907538] Review Request: python-django-extensions - extensions for Django
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907538 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- python-django-extensions-1.0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-django-extensions-1.0.3-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VSRpgpomYga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - Color lines game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EUO1KNx6eda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913574] New: Review Request: gnome-shell-extension-per-window-keyboard-layout - Remembers keyboard layout for each window
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913574 Bug ID: 913574 Summary: Review Request: gnome-shell-extension-per-window-keyboard-layout - Remembers keyboard layout for each window Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: jdor...@redhat.com Spec URL: http://www.misli.cz/gnome-shell-extension-per-window-keyboard-layout.spec SRPM URL: http://www.misli.cz/gnome-shell-extension-per-window-keyboard-layout-0-0.1.gitfcbc606ecf.fc18.src.rpm Description: This GNOME shell extension restores the previously available input-source behavior that made it possible to have a different keyboard layout per window. Fedora Account System Username: jdornak -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ESXZ1yulpva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910565] Review Request: python-github - A Python library implementing the full Github API v3.
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910565
Richard Marko rma...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #6 from Richard Marko rma...@redhat.com ---
(In reply to comment #5)
Fixed version according to c#3 c#4
http://jmoskovc.fedorapeople.org/python-github.spec
http://jmoskovc.fedorapeople.org/python-github-1.11.1-2.fc18.src.rpm
* Package name correct
* Packaging latest version
* License ok and good for fedora
* SPEC file clean and legible
* Builds fine in mock
* Sane filelist
* Sane reqs/provs
= Package approved.
Few minor issue that should be fixed:
[!]: Package contains BR: python2-devel or python3-devel
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
%install: rm -rf %{buildroot} present but not required
%clean: rm -rf %{buildroot} present but not required
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=4QrDXLNcwKa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913574] Review Request: gnome-shell-extension-per-window-keyboard-layout - Remembers keyboard layout for each window
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913574 Jakub Dorňák jdor...@redhat.com changed: What|Removed |Added Version|rawhide |18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=junv0ra9jga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913574] Review Request: gnome-shell-extension-per-window-keyboard-layout - Remembers keyboard layout for each window
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913574 --- Comment #1 from Jakub Dorňák jdor...@redhat.com --- I was not able to test this extension for rawhide, as gnome-tweek-tool, which I use to enable extension does not work in rawhide right now. Once I am able to test it, I will provide spec for rawhide too. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fqlQqBZAAfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913574] Review Request: gnome-shell-extension-per-window-keyboard-layout - Remembers keyboard layout for each window
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913574 Jakub Dorňák jdor...@redhat.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bZdQMs97YNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910510] Review Request: klines - Color lines game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910510 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-02-21 09:07:18 --- Comment #13 from Rex Dieter rdie...@math.unl.edu --- imported -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VYx90zggIVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907538] Review Request: python-django-extensions - extensions for Django
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907538 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- python-django-extensions-1.0.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-django-extensions-1.0.3-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bRI6qaFThYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907478] Review Request: rubypick - Stub to allow choosing Ruby runtime
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907478 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-02-21 09:08:26 --- Comment #7 from Vít Ondruch vondr...@redhat.com --- This was build in f19-ruby tag and is going to be merged into Rawhide prior branch of F19. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8QLQVbVhssa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #9 from Adam Miller admil...@redhat.com --- Awesome, greatly appreciated! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7wAEJQle0pa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913289] Review Request: gimp-separate+ - A plug-in providing rudimentary CMYK support for The GIMP
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=913289
Antonio Trande trp...@katamail.com changed:
What|Removed |Added
CC||trp...@katamail.com
--- Comment #1 from Antonio Trande trp...@katamail.com ---
Hi Peter.
Just few comment.
- There are more licenses in the source:
$ licensecheck * | grep -v UNKNOWN
import.c: GPL (v2 or later) (with incorrect FSF address)
jpeg.c: GPL (v2 or later) (with incorrect FSF address)
jpeg.h: GPL (v2 or later) (with incorrect FSF address)
psd.c: GPL (v2 or later) (with incorrect FSF address)
psd.h: GPL (v2 or later) (with incorrect FSF address)
separate-core.c: GPL (v2 or later) (with incorrect FSF address)
separate-core.h: GPL (v2 or later) (with incorrect FSF address)
separate-export.c: GPL (v2 or later) (with incorrect FSF address)
separate-export.h: GPL (v2 or later) (with incorrect FSF address)
separate-gui.c: GPL (v2 or later) (with incorrect FSF address)
separate.h: GPL (v2 or later) (with incorrect FSF address)
srgb_profile.h: MIT/X11 (BSD like)
tiff.c: GPL (v2 or later) (with incorrect FSF address)
tiff.h: GPL (v2 or later) (with incorrect FSF address)
util.c: GPL (v2 or later) (with incorrect FSF address)
util.h: GPL (v2 or later) (with incorrect FSF address)
I think, needs to indicate even the second:
License: GPLv2+ and BSD
See:
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios
- Source link not found
- [ %{buildroot} != / ] rm -rf %{buildroot}
Why do you use this form ?
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Prepping_BuildRoot_For_.25install
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=QGAhtcdp5ga=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913500] Review Request: coro-mock - A mock library for compiling JVM coroutine-using code on JVMs without coroutines
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913500 --- Comment #1 from Stanislav Ochotnicky socho...@redhat.com --- Since FPC temporarily forbidden new XMvn style packages from entering Fedora (at least temporarily), I'll have to ask you to revert to classic mvn-rpmbuild spec file. Thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Nmn2pyTqVba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913496] Review Request: cbi-plugins - A set of helpers for Eclipse CBI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913496 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-02-21 09:51:34 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LbpEstboYCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907538] Review Request: python-django-extensions - extensions for Django
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907538 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- python-django-extensions-1.0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-django-extensions-1.0.3-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=j5K3kDdavra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vWRhGc9Z8Va=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- perl-Data-Validate-IP-0.18-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Data-Validate-IP-0.18-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zqEaIh2meua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- perl-Data-Validate-IP-0.18-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Data-Validate-IP-0.18-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=42CFFX2vnMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913605] New: Review Request: NFStest - NFS Testing Tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913605 Bug ID: 913605 Summary: Review Request: NFStest - NFS Testing Tool Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: ste...@redhat.com Spec URL: http://steved.fedorapeople.org/NFStest/NFStest.spec SRPM URL: http://steved.fedorapeople.org/NFStest/NFStest-1.0.1-0.fc18.src.rpm Description: Provides a set of tools for testing either the NFS client or the NFS server, most of the functionality is focused mainly on testing the client. Fedora Account System Username: steved -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XwG22vNggCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896449] Package review: gnome-calculator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896449 --- Comment #6 from Michael Schwendt mschwe...@gmail.com --- Obsoletes looks reasonable. Too low because of dist tag - bug 913538 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FNn2wVgijra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896449] Package review: gnome-calculator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896449 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Status|CLOSED |ASSIGNED CC||mschwe...@gmail.com Blocks||913538 Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #7 from Michael Schwendt mschwe...@gmail.com --- I'm reopening this based on https://fedoraproject.org/wiki/Package_Renaming_Process gcalctool is still in Rawhide and has been updated by the mass-rebuild: http://koji.fedoraproject.org/koji/packageinfo?packageID=188 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CdwsSwp8Bza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912132] Review Request: perl-Package-Variant - Parameterizable packages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8GG2U2boAPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912132] Review Request: perl-Package-Variant - Parameterizable packages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- perl-Package-Variant-1.001002-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Package-Variant-1.001002-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0QhUu3JJzha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912132] Review Request: perl-Package-Variant - Parameterizable packages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- perl-Package-Variant-1.001002-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Package-Variant-1.001002-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BV05LtiVRxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913481] Review Request: perl-Net-SFTP-Foreign - SSH File Transfer Protocol client for Perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913481 --- Comment #2 from Petr Šabata psab...@redhat.com --- 2 %global real_version 1.74_05 3 Version:1.74.5 Upstream uses odd version numbers for previous even-numbered development releases so this is okay. However, I'd suggest using '1.74.05' to emphasize this is an unstable release, as done elsewhere. Missing BRs: * perl(Encode) from lib/Net/SFTP/Foreign.pm:17 * perl(Net::SFTP) from t/Net-SFTP-Foreign-Compat.t:5 * perl(POSIX) from lib/Net/SFTP/Foreign/Backend/Unix.pm:12 * perl(Tie::Handle) from lib/Net/SFTP/Foreign.pm:3049 You could also remove the Windows backend from the package completely as this won't ever be used in Fedora. Packaging debug.txt, TODO, rfc/ (even mentioned in %description), and samples/ (if you do, filter out their deps, e.g. with %perl_default_filter) in %doc would be nice. Also include LICENSE for sure. 38 Requires: perl(lib) 39 Requires: perl(Cwd) Those two are only used in tests, no reason to require them at runtime. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vsl2NSZutea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #5 from Petr Šabata psab...@redhat.com --- The current state is good enough for the review now. Approving. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pce3TwXEiBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 Normunds fedora...@rule.lv changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Normunds fedora...@rule.lv --- Thanks :) New Package SCM Request === Package Name: perl-Filesys-SmbClient Short Description: Samba client Perl module Owners: normunds psabata Branches: f17 f18 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uSoZjX5Vkta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0s3Kpoqfopa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913004] Review Request: perl-re-engine-RE2 - RE2 regex engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913004 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B7cVCdJn5Ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913152] Review Request: MUMPS - A MUltifrontal Massively Parallel sparse direct Solver
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=913152
Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed:
What|Removed |Added
CC||paulo.cesar.pereira.de.andr
||a...@gmail.com
--- Comment #4 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com ---
Since this package intersects with your ipopt, and my
coin-or-Ipopt review request, I did a simple review
request:
MUST:
1. %build honors applicable compiler flags or justifies otherwise.
Build does not honor compiler flags. See grep -r CFLAGS and
grep -r OPTC in the BUILD dir. Need to either patch, or just
pass CFLAGS to make call.
2. Changelog in prescribed format.
Minor issue, just break the line between the 2 changelog entries.
3. Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Self explanatory. Also remove the %clean section.
4. Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
Remove %defattr from all %files sections.
5. Development files must be in a -devel package
.so links are not in the -devel package and also should use
a relative link (target is in the same directory).
6. Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/lib64/MUMPS
Self explanatory.
7. If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
LICENSE file is not in %doc.
README is installed and not set as %doc.
Package is not owner of %{_docdir}/%{name}-%{version}.
Since the -seq package does not require the main package (error?)
it should also include LICENSE as %doc; I suggest making it require
the main package to also silence the warning about it not requiring
the main package...
The .ps and .pdf documentation is not installed. I suggest
%doc doc/*.pdf and %doc doc/%.ps
8. License file installed when any subpackage combination is installed.
See 7.
9. Package must own all directories that it creates.
As described in 8., package is not owner of %{_docdir}/%{name}-%{version}.
SHOULD:
1. Buildroot is not present
Note: Buildroot: present but not needed
Just remove the
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
line.
2. Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
Just remove the %clean section.
3. Spec use %global instead of %define.
Note: %define __provides_exclude_from
%{_libdir}/openmpi/lib/(lib(mca|o|v)|openmpi/).*.so %define
__requires_exclude libopen.*.so
Self explanatory.
EXTRA:
1. Please consider installing headers in /usr/include/MUMPS:
$ ls rpms-unpacked/MUMPS-devel-4.10.0-1.fc18.x86_64.rpm/usr/include/|wc -l
14
this may need some minor patching or adding -IMUMPS to build.
2. -devel package should have:
Requires: %{name}%{?_isa} = %{version}-%{release}
instead of
Requires: %{name} = %{version}-%{release}
3. Summary and description of the seq subpackage are a wrong, cutpaste
of the -devel package.
4. Please make a examples subpackage with the examples subdir, verify
the README there, and validate it works. *OR* make of the examples
subdirectory a %check section. This would help a reviewer to press
x in the Package functions as described field.
5. You should not do
chmod a-x $RPM_BUILD_ROOT%{_libdir}/%{name}/?simpletest
chmod a-x $RPM_BUILD_ROOT%{_libdir}/%{name}/input_*
in %install. This just causes it to install ELF binary files without
executable permission just for the bogus warning
'script-without-shebang'
6. Instead of using a single mumps-extra.tar.gz tarball, You should add
it as a Patch, with the proper link to
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/raring/mumps/raring/files/head:/debian/patches/$PATCH_NAME
and use %patch instead of calling patch in %build. At least, should
use patch in %prep (that is, to help in without prep partial
debug builds).
Should also give a brief description of what the patch does, and
if applicable, a link to where the patch was submitted upstream.
==
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files directly in %_libdir.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
[!]:
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #3 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- Created attachment 700667 -- https://bugzilla.redhat.com/attachment.cgi?id=700667action=edit mail regarding license I got a reply from author of the zip file, but I'm not quite sure whether it's satisfactory. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oHxsNGQK7La=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=839740 Miroslav Lichvar mlich...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #4 from Miroslav Lichvar mlich...@redhat.com --- Hm, I think we would need to get a list of all authors whose work is included in that zip and get a statement from all of them. Tom, can you please confirm that? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jRsa2Boqo3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887913] Review Request: perl-Math-Clipper - Polygon clipping in 2D
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887913 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- perl-Math-Clipper-1.15-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Math-Clipper-1.15-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BD13Za2Eita=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #27 from Marc-Andre Lureau marcandre.lur...@redhat.com --- Paolo, would you like some help? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6bYsA0fUira=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
