[Bug 947799] Review Request: python-flask-mongoengine - Flask extension that provides integration with MongoEngine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947799 --- Comment #2 from Robert Kuska rku...@redhat.com --- - Python eggs must not download any dependencies during the build process, but during the build it tries to download nose, cause - line 44 in [1] [1] https://github.com/MongoEngine/flask-mongoengine/blob/master/setup.py -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CvPL856e62a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 --- Comment #5 from Ricky Elrod rel...@redhat.com --- Thanks for the feedback, and sorry I uploaded the wrong RPM, I didn't even notice. :) I believe I've addressed everything you've pointed out so far - and yes, I will happily review one of yours in return. Look for it tomorrow. New SRPM: http://codeblock.fedorapeople.org/packages/rubygem-ronn/rubygem-ronn-0.7.3-2.fc18.src.rpm New Spec: http://codeblock.fedorapeople.org/packages/rubygem-ronn/rubygem-ronn.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7168QdCB3ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 923564] Review Request: NetworkManager-ssh - NetworkManager VPN plugin for SSH
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923564 --- Comment #33 from Dan Fruehauf malko...@gmail.com --- So the patch made it into NetworkManager 0.9.8.1, which is in updates-testing. Eduardo, should I change the spec to depend on NetworkManager 0.9.8.1 and send a build request? Pavel, even after updating to NetworkManager-0.9.8.1, it'll still require a restart of NetworkManager for things to work. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3WTcKFK5PPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909706] Review Request: php-horde-Horde-Vfs- Virtual File System API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909706 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dspKznzUhna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909706] Review Request: php-horde-Horde-Vfs- Virtual File System API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909706 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-Vfs-2.0.4-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Vfs-2.0.4-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=513nXSL4Nwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947861] Review Request: igor - Automated distribution life-cycle testing
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947861
Matthias Runge mru...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #4 from Matthias Runge mru...@redhat.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2.1 or later), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in
/home/mrunge/review/947861-igor/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Spec use %global instead of %define.
Note: %define gitorious_name ovirt-igord
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package
[Bug 909706] Review Request: php-horde-Horde-Vfs- Virtual File System API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909706 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-Vfs-2.0.4-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Vfs-2.0.4-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vr7PHZi8B9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 923564] Review Request: NetworkManager-ssh - NetworkManager VPN plugin for SSH
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923564 --- Comment #34 from Eduardo Echeverria echevemas...@gmail.com --- (In reply to comment #33) So the patch made it into NetworkManager 0.9.8.1, which is in updates-testing. Eduardo, should I change the spec to depend on NetworkManager 0.9.8.1 and send a build request? No, build the package for now in rawhide if you prefer. when nm pass to stable, then build in the other branches -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=deVI4yzYPEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947799] Review Request: python-flask-mongoengine - Flask extension that provides integration with MongoEngine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947799 --- Comment #3 from Matej Stuchlik mstuc...@redhat.com --- Fixed: Spec URL: http://mstuchli.fedorapeople.org/python-flask-mongoengine.spec SRPM URL: http://mstuchli.fedorapeople.org/python-flask-mongoengine-0.6-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SDOGoqXaNEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927894] Review Request: php-horde-Horde-SyncMl - Horde_SyncMl provides an API for processing SyncML requests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927894 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rpjPRoJP0Qa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927894] Review Request: php-horde-Horde-SyncMl - Horde_SyncMl provides an API for processing SyncML requests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927894 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-SyncMl-2.0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-SyncMl-2.0.3-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ttzeqls6Hja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927894] Review Request: php-horde-Horde-SyncMl - Horde_SyncMl provides an API for processing SyncML requests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927894 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-SyncMl-2.0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-SyncMl-2.0.3-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k1KXqEIjQia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919442] Review Request: R-Rsamtools - R interface to samtools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919442 --- Comment #4 from Pierre-YvesChibon pin...@pingoured.fr --- Spec is clean, sources seems fine, only two things: a) scratch build fails on F19: http://kojipkgs.fedoraproject.org//work/tasks/193/5210193/build.log missing dependency on http://cran.r-project.org/web/packages/bitops/ apparently b) the license tag says Artistics + LICENSE file which says MIT, but I wonder if that MIT isn't present only because of the samtools which is copied locally. Since we remove that copy, should the license tag in the spec file be simplified to Artistic only? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FHuf221sO0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859111] Review Request: glassfish-pfl - GlassFish Primitive Function Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=859111 Michal Srb m...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Michal Srb m...@redhat.com --- Looks good to me now, thanks. *** APPROVED *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4kUmKs5cgoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947799] Review Request: python-flask-mongoengine - Flask extension that provides integration with MongoEngine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947799 Robert Kuska rku...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Robert Kuska rku...@redhat.com --- Well-fixed, approving. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x7roygAQWfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947799] Review Request: python-flask-mongoengine - Flask extension that provides integration with MongoEngine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947799 Matej Stuchlik mstuc...@redhat.com changed: What|Removed |Added Flags|fedora-review+ | Flags||fedora-review? Flags||fedora-cvs? --- Comment #5 from Matej Stuchlik mstuc...@redhat.com --- New Package SCM Request === Package Name: python-flask-mongoengine Short Description: Flask extension that provides integration with MongoEngine Owners: mstuchli Branches: f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uRJNvDlOzua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947799] Review Request: python-flask-mongoengine - Flask extension that provides integration with MongoEngine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947799 Matej Stuchlik mstuc...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MUjky9bGHVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 923564] Review Request: NetworkManager-ssh - NetworkManager VPN plugin for SSH
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923564 --- Comment #35 from Dan Fruehauf malko...@gmail.com --- FYI Just build for Rawhide. Will build for f18 and f19 when NetworkManager-0.9.8.1 goes into stable. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=roOjwXVxDMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910699] Review Request: pagekite - makes localhost servers visible to the world
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910699 Lukas Zapletal l...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Lukas Zapletal l...@redhat.com --- New Package SCM Request === Package Name: pagekite Short Description: system for running publicly visible servers Owners: lzap Branches: f18 f19 el5 el6 (If there is f19 branch already - not sure :-) Thank you Mirek! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d4MxOuCZEIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947861] Review Request: igor - Automated distribution life-cycle testing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861 Fabian Deutsch fdeut...@redhat.com changed: What|Removed |Added Flags|fedora-review+ | Flags||fedora-review? --- Comment #5 from Fabian Deutsch fdeut...@redhat.com --- New Package SCM Request === Package Name: igor Short Description: Automated distribution life-cycle testing Owners: fabiand Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BlTv4anG3Ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947861] Review Request: igor - Automated distribution life-cycle testing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861 Fabian Deutsch fabian.deut...@gmx.de changed: What|Removed |Added CC||fabian.deut...@gmx.de Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GojBTa4AiXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889505] Review Request: libkqueue - A userspace implementation of the kqueue kernel event notification mechanism
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=889505
Alec Leamas leamas.a...@gmail.com changed:
What|Removed |Added
CC||leamas.a...@gmail.com
--- Comment #16 from Alec Leamas leamas.a...@gmail.com ---
In comment #13 you set cflags to $cflags -fpic. How will this ensure that
%{optflags} is applied?
Stated otherwise: if you check the build logs and compares it with the output
from 'rpm --eval %optflags', can you verify that %optflags is applied? See also
[1]
Patching or adding a COPYING file isn't kosher, only the copyright owner can do
that. You should file a bug upstream about the missing COPYING, leaving source
as-is until upstream fixes this. See also [2].
The normal way to handle the other stuff is to use the upstream sources and
create patches as needed. However, instead of using the upstream source from
http://mark.heily.com/project/libkqueue you have created an own archive,
effectively forking the project. Forking isn't necessary evil, but requires an
explanation beyond the review remarks discussed so far. So: why have you forked
the upstream project?
[1]
https://fedoraproject.org/wiki/Common_Rpmlint_issues#debuginfo-without-sources
[2] https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ukZ1GO4WPda=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #11 from Michal Schmidt mschm...@redhat.com --- From the spec: # No need to call to ldconfig for post installation/uninstallation as # the libglamor libglamoregl are dynamicly load through dl open by the # xserver or ddx driver. But to silence rpmlint just call them. Are you sure this comment is accurate? I can see that it is valid for libglamoregl.so, which gets dlopen'd by the X server using a full path, but this .so then depends on libglamor.so.0, which gets resolved using the standard dynamic linker search order. So I'd say ldconfig is in fact needed and not just to silence rpmlint. The -devel subpackage should require the base package using an arch-specific dependency. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package The explicit Requires: pkgconfig is redundant, because rpmbuild automatically added a requirement for /usr/bin/pkg-config for you. The explicit Requires: mesa-libEGL is redundant, because the devel subpackage depends on the main package, which in turn already requires libEGL.so.1()(64bit) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DXmibInDoSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947861] Review Request: igor - Automated distribution life-cycle testing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861 Matthias Runge mru...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=syHCBfMDL6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947861] Review Request: igor - Automated distribution life-cycle testing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861 Fabian Deutsch fabian.deut...@gmx.de changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v6HkuAYaMxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947861] Review Request: igor - Automated distribution life-cycle testing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861 Fabian Deutsch fabian.deut...@gmx.de changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cK36BaP1Mga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892625] Review Request: resiprocate - SIP reference implementation, SIP proxy, TURN server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892625 --- Comment #12 from Daniel Pocock dan...@pocock.com.au --- Discussion raised on the libtool and Fedora packaging lists: http://lists.gnu.org/archive/html/libtool/2013-04/msg0.html http://lists.fedoraproject.org/pipermail/packaging/2013-April/009005.html So far, the most probably immediate solution appears to be from this email http://lists.fedoraproject.org/pipermail/packaging/2010-June/007187.html sed -i.libdir_syssearch -e \ '/sys_lib_dlsearch_path_spec/s|/usr/lib |/usr/lib /usr/lib64 /lib /lib64 |' \ configure i.e. just add the needed paths to sys_lib_dlsearch_path_spec in configure (note that libtool in the build directory is generated by configure) before calling %configure. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IGNliJvavZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910699] Review Request: pagekite - makes localhost servers visible to the world
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910699 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KyfE9jslpDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910699] Review Request: pagekite - makes localhost servers visible to the world
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910699 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jtgcWDdBxfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911188] Review Request: nodejs-should - A test framework agnostic BDD-style assertions for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911188 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Z3Y5fc1zTla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911188] Review Request: nodejs-should - A test framework agnostic BDD-style assertions for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911188 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tTRFxEyJGPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947861] Review Request: igor - Automated distribution life-cycle testing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rcakmZUsNja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947861] Review Request: igor - Automated distribution life-cycle testing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wjfh6kO9bOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948013] Review Request: python-crank - Generalization of dispatch mechanism for use across frameworks
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948013 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XoOwFJGnDZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948013] Review Request: python-crank - Generalization of dispatch mechanism for use across frameworks
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948013 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k1wnIxomuMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863836] Review Request: NetworkManager-strongswan - NetworkManager VPN plugin for strongSwan
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863836 --- Comment #17 from Pavel Šimerda psime...@redhat.com --- (In reply to comment #16) The correct way to package NM VPN plugins and their daemons is this: Thanks for adding information that I didn't know. 1) the VPN package itself; does not depend on NEtworkManager or consume any NetworkManager libraries like libnm-glib or libnm-util. eg, the vpnc, openconnect, openvpn, etc packages For example, strongswan's charon-nm depends on NetworkManager-glib but I don't know yet what it is and what's the relation between the part that is in strongswan and the part that is in NetworkManager-strongswan. Do you think that charon-nm binary dependency on NetworkManager-glib is bad enough that I should file a bug report with Strongswan? 2) the NetworkManager VPN plugin itself: eg, the thing that NM talks to via dbus to start/stop the VPN connection, and any associated components. But *not* any GUI components. eg, /usr/libexec/nm-vpnc-service and /usr/libexec/nm-vpnc-service-vpnc-helper and /etc/NetworkManager/VPN/nm-vpnc-service.name and any translation files for the core plugin. 3) the GNOME desktop GUI pieces, like the auth dialog and connection editor pane, and associated translations for the GUI parts. I realize the existing plugins are not separated like 2 3, but we want to do that in the future. So new plugins should follow that separation. For consistency, #2 should be named NetworkManager-vpn service (ie, NetworkManager-strongswan) and #3 should be named NetworkManager-vpn service-gnome (ie, NetworkManager-strongswan-gnome). Thank you. We're talking about the following packages then. * strongswan (and optionally strongswan-charon-nm) * NetworkManager-strongswan * NetworkManager-strongswan-gnome -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5WDLo1tNV6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948275] New: Review Request: php-phpunit-Version - Managing the version number of Git-hosted PHP projects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948275 Bug ID: 948275 Summary: Review Request: php-phpunit-Version - Managing the version number of Git-hosted PHP projects Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: https://raw.github.com/remicollet/remirepo/a308590a88aa9b1535f8b45f1847cae4f1065677/php/phpunit/php-phpunit-Version/php-phpunit-Version.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-phpunit-Version-1.0.0-1.remi.src.rpm Description: Library that helps with managing the version number of Git-hosted PHP projects. Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Iv1X1xHm4ja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 923564] Review Request: NetworkManager-ssh - NetworkManager VPN plugin for SSH
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923564 --- Comment #36 from Pavel Šimerda psime...@redhat.com --- Please see: https://bugzilla.redhat.com/show_bug.cgi?id=863836#c16 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oXuDIfKLZha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889505] Review Request: libkqueue - Userspace implementation of the kqueue event notification mechanism
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=889505
Eric Radman erad...@entrproject.org changed:
What|Removed |Added
Summary|Review Request: libkqueue - |Review Request: libkqueue -
|A userspace implementation |Userspace implementation of
|of the kqueue kernel event |the kqueue event
|notification mechanism |notification mechanism
--- Comment #17 from Eric Radman erad...@entrproject.org ---
I finally get it, these flags are added at configure time, but I wasn't using
the standard %configure macro.
CFLAGS=%{optflags} -fpic %{_configure}
Also shortened the summary a bit. rpmlint is finnally free of warnings on
Fedora 17. New source:
http://static.eradman.com/src/libkqueue-1.0.1-6.src.rpm
Patching or adding a COPYING file isn't kosher
I'll ask the author if he wants to create this file in the official SVN repo.
His license isn't ambiguous, COPYING contains the exact text already included
in the project.
why have you forked the upstream project?
Primarily to maintain quick turnaround and minimize friction since Mark's
current work is focused on a 2.0 release. I'll write him and ask if he'd like
to create an official 1.0 maintenance branch with the changes I've made.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Sv4CQNtWrUa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 923564] Review Request: NetworkManager-ssh - NetworkManager VPN plugin for SSH
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923564 --- Comment #37 from Dan Fruehauf malko...@gmail.com --- Pavel, sounds good. much like in debian. I'll work shortly on separating it into a NetworkManager-ssh and NetworkManager-ssh-gnome plugin. Shouldn't be too difficult. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nSpE9bLPwia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #12 from Jerome Glisse jgli...@redhat.com --- I am pretty sure that given how X implement stuff it's not necessary but i don't feel like diving in that code again so i removed the comment. Fixed dependency http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor.spec http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor-0.5.0-3.20130401git81aadb8.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HkVMsE0Nvna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889505] Review Request: libkqueue - Userspace implementation of the kqueue event notification mechanism
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889505 --- Comment #18 from Alec Leamas leamas.a...@gmail.com --- (In reply to comment #17) [cut] why have you forked the upstream project? Primarily to maintain quick turnaround and minimize friction since Mark's current work is focused on a 2.0 release. I'll write him and ask if he'd like to create an official 1.0 maintenance branch with the changes I've made. Basically, this motivation isn't enough IMHO. I suggest that you go back to using the upstream sources. If you still need to fix config.inc you can use sed -i to patch it in place. If there are other changes, add a patch and/or new sources. The current situation will make maintenance hard and I would not let it pass if I was reviewing it. Of course, you should try to talk to upstream about merging the patches. However, the first step is to create those patches, not to create a new tarball. BTW, when building for reviews rawhide is the preferred platform. Use mock, and this is no problem. F17 is to old today. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XnN2Lr17Ufa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928226] Review Request: libmwaw: import library for some old mac text documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928226 David Tardon dtar...@redhat.com changed: What|Removed |Added CC||dtar...@redhat.com Alias||libmwaw -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oNabGnGxrRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910146 --- Comment #3 from Lukas Zapletal l...@redhat.com --- Many thanks with PageKite review, this is the last piece of the puzzle I need to package PageKite for EPEL5/6 and Fedoras ;-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ha1wbij3A7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 --- Comment #28 from Sebastien Jodogne s.jodo...@gmail.com --- Spec URL: http://www.montefiore.ulg.ac.be/~jodogne/Orthanc/Fedora/orthanc.spec SRPM URL: http://www.montefiore.ulg.ac.be/~jodogne/Orthanc/Fedora/orthanc-0.5.0-1.fc18.src.rpm Hello Mario, As jsoncpp is now available and as a new upstream version of Orthanc (0.5.0) has been released in the meantime, I have just uploaded a new version of the package that is ready for further review. Please note that the package is now suitable for Fedora 18 and dynamically links against jsoncpp. The Orthanc systemd service can be started through the following command: # sudo service orthanc start Best, Sébastien- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eytQKZudQQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916676] Review Request: python-django14 - A high-level Python Web framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916676 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YA4f6MOrgFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916676] Review Request: python-django14 - A high-level Python Web framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916676 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-django14-1.4.5-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-django14-1.4.5-4.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hp29VebDNXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948104] Review Request: python-gearbox - Command line toolkit born as a PasteScript replacement for TurboGears2
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948104 --- Comment #1 from Ralph Bean rb...@redhat.com --- Currently failing to build for me. Some BuildRequires are needed for the tests to run (like python-paste-deploy). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3bHf61Zji2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948345] New: Review Request: mozjs17 - JavaScript interpreter and libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948345 Bug ID: 948345 Summary: Review Request: mozjs17 - JavaScript interpreter and libraries Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: walt...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://fedorapeople.org/~walters/mozjs17.spec SRPM URL: http://fedorapeople.org/~walters/mozjs17-17.0.0-1.src.rpm Description: New version of mozjs, needed by GNOME 3.10+ Fedora Account System Username: walters -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3DjRmu0kTaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948014] Review Request: python-backlash - Standalone WebOb port of the Werkzeug Debugger
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948014 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #6 from Ralph Bean rb...@redhat.com --- Awesome. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DM4Ig5HOYXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948014] Review Request: python-backlash - Standalone WebOb port of the Werkzeug Debugger
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948014 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rb...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J8fXlqYJyua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859111] Review Request: glassfish-pfl - GlassFish Primitive Function Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=859111 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from gil cattaneo punto...@libero.it --- New Package SCM Request === Package Name: glassfish-pfl Short Description: GlassFish Primitive Function Library Owners: gil Branches: f18 f19 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KVrzQP7d8Oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859111] Review Request: glassfish-pfl - GlassFish Primitive Function Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=859111 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r90iJsxGM6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859111] Review Request: glassfish-pfl - GlassFish Primitive Function Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=859111 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OEjIwlWdpBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948359] New: Review Request: python-volatility, a digital artifact extraction framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948359 Bug ID: 948359 Summary: Review Request: python-volatility, a digital artifact extraction framework Product: Fedora Version: 19 Component: Package Review Severity: unspecified Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: al...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://people.freedesktop.org/~alon/volatility-fedpkg/python-volatility.spec SRPM URL: http://people.freedesktop.org/~alon/volatility-fedpkg/python-volatility-2.2-1.fc19.src.rpm Description: The Volatility Framework is a completely open collection of tools, implemented in Python under the GNU General Public License, for the extraction of digital artifacts from volatile memory (RAM) samples. The extraction techniques are performed completely independent of the system being investigated but offer unprecedented visibilty into the runtime state of the system. The framework is intended to introduce people to the techniques and complexities associated with extracting digital artifacts from volatile memory samples and provide a platform for further work into this exciting area of research. $ rpmlint python-volatility.spec python-volatility.spec: W: invalid-url Source0: http://volatility.googlecode.com/files/volatility-2.2.tar.gz HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings. I have no idea why it gives this error, since the file is downloadable with wget. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=obCwX6vAQda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=888301
Mario Ceresa mrcer...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #29 from Mario Ceresa mrcer...@gmail.com ---
Thanks Sebastien, here it goes the formal review:
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v3 or later), Unknown or generated, MIT/X11 (BSD like),
zlib/libpng, BSD (3 clause), BSD (2 clause). 6 files have unknown
license. Detailed output of licensecheck in
/home/mario/fedora/888301-orthanc/licensecheck.txt
This was already addressed in comment 16
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 51200 bytes in 4 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
[Bug 876404] Review Request: php-channel-aws - Adds the Amazon Web Services channel to PEAR
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- php-channel-aws-1.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yARG21aTdra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927894] Review Request: php-horde-Horde-SyncMl - Horde_SyncMl provides an API for processing SyncML requests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927894 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a7O8X6DBPua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927894] Review Request: php-horde-Horde-SyncMl - Horde_SyncMl provides an API for processing SyncML requests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927894 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-SyncMl-2.0.3-2.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fP7jprw0Cba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908329 Bug 908329 depends on bug 785447, which changed state. Bug 785447 Summary: Review Request: php-horde-Horde-Auth - Horde Authentication API https://bugzilla.redhat.com/show_bug.cgi?id=785447 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oJW9SYNhT7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785447] Review Request: php-horde-Horde-Auth - Horde Authentication API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785447 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2013-04-04 12:38:21 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=10X7YTL2rAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927894] Review Request: php-horde-Horde-SyncMl - Horde_SyncMl provides an API for processing SyncML requests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927894 Bug 927894 depends on bug 785447, which changed state. Bug 785447 Summary: Review Request: php-horde-Horde-Auth - Horde Authentication API https://bugzilla.redhat.com/show_bug.cgi?id=785447 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2iwlrJXSpKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929039] Review Request: php-horde-Horde-Kolab-Server - A package for manipulating the Kolab user database
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929039 Bug 929039 depends on bug 785447, which changed state. Bug 785447 Summary: Review Request: php-horde-Horde-Auth - Horde Authentication API https://bugzilla.redhat.com/show_bug.cgi?id=785447 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9BQsdh4bSja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909706] Review Request: php-horde-Horde-Vfs- Virtual File System API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909706 Bug 909706 depends on bug 785447, which changed state. Bug 785447 Summary: Review Request: php-horde-Horde-Auth - Horde Authentication API https://bugzilla.redhat.com/show_bug.cgi?id=785447 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FvjlDastkua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785447] Review Request: php-horde-Horde-Auth - Horde Authentication API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785447 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-Auth-2.0.4-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=quVvqfP2ETa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908329 Bug 908329 depends on bug 909520, which changed state. Bug 909520 Summary: Review Request: php-horde-Horde-Imap-Client - Horde IMAP abstraction interface https://bugzilla.redhat.com/show_bug.cgi?id=909520 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=siTDtBvteCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909520] Review Request: php-horde-Horde-Imap-Client - Horde IMAP abstraction interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909520 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-04 12:38:58 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cK7oTKpNl7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929040] Review Request: php-horde-Horde-Kolab-Session - A package managing an active Kolab session
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929040 Bug 929040 depends on bug 909520, which changed state. Bug 909520 Summary: Review Request: php-horde-Horde-Imap-Client - Horde IMAP abstraction interface https://bugzilla.redhat.com/show_bug.cgi?id=909520 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Gvdmna3Ixma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929041] Review Request: php-horde-Horde-Kolab-Storage - A package for handling Kolab data stored on an IMAP server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929041 Bug 929041 depends on bug 909520, which changed state. Bug 909520 Summary: Review Request: php-horde-Horde-Imap-Client - Horde IMAP abstraction interface https://bugzilla.redhat.com/show_bug.cgi?id=909520 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0vlDwxhFVEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909520] Review Request: php-horde-Horde-Imap-Client - Horde IMAP abstraction interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909520 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-Imap-Client-2.8.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5uteXslpkva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909706] Review Request: php-horde-Horde-Vfs- Virtual File System API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909706 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=I92BmupPoPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909706] Review Request: php-horde-Horde-Vfs- Virtual File System API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909706 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-Vfs-2.0.4-3.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HQkRlVY3Rea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928367] Review Request: php-horde-Horde-Feed - Horde Feed libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928367 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-Feed-2.0.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zAgwAuu7Ida=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928367] Review Request: php-horde-Horde-Feed - Horde Feed libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928367 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-04 12:44:22 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LWYAb3Sf2ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 --- Comment #30 from Mario Ceresa mrcer...@gmail.com --- @Peter: could you please sponsor Sebastian, so he can ask git access? @Sebastian: once sponsored, please do: * make a SCM admin request as detailed here: https://fedoraproject.org/wiki/Package_SCM_admin_requests * import the package into the repositories as detailed here: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner * read about maintaining for EPEL here: http://fedoraproject.org/wiki/EPEL/FAQ#I.27m_a_Fedora_contributor_and_want_to_maintain_my_packages_in_EPEL.2C_too._What_do_I_have_to_do_and_what_do_you_expect_from_me.3F Congratulations for a beautiful software and a nicely crafted package!!! Feel free to contact me for any doubt/question Mario -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lhrvG9qmjEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948345] Review Request: mozjs17 - JavaScript interpreter and libraries
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=948345
Kalev Lember kalevlem...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||kalevlem...@gmail.com
Assignee|nob...@fedoraproject.org|kalevlem...@gmail.com
--- Comment #1 from Kalev Lember kalevlem...@gmail.com ---
The header files all have the execute bit set, is it something we should try to
fix up in the downstream spec file?
Source0:http://ftp.mozilla.org/pub/mozilla.org/js/mozjs17.0.0.tar.gz
Should use the %{version} macro to make future updates easier.
%package devel
...
Requires: pkgconfig
rpmbuild generates the pkgconfig dep automatically for packages that have .pc
files, no need for the manual requires line.
%package devel
...
Requires: ncurses-devel readline-devel
Does it really need ncurses/readline headers? I couldn't find any
ncurses/readline includes in the js header files, at least.
%prep
...
(cd js/src autoconf-2.13)
Not sure the autoconf is necessary, might be cleaner to just remove it.
%clean
rm -rf %{buildroot}
The clean section is no longer needed with recent rpmbuild.
%files
%defattr(-,root,root,-)
...
%files devel
%defattr(-,root,root,-)
rpmbuild sets a sane defattr itself nowadays, no need to specify it here.
%doc js/src/README.html
Not sure the README.html is very interesting, just contains a link. Maybe add
README instead? One file that's definitely needs adding is the LICENSE file.
%{_bindir}/js17-config
This should be in -devel I guess, not in the main library package.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=erwZNiVBVZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948014] Review Request: python-backlash - Standalone WebOb port of the Werkzeug Debugger
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948014 Luke Macken lmac...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Luke Macken lmac...@redhat.com --- New Package SCM Request === Package Name: python-backlash Short Description: Standalone WebOb port of the Werkzeug Debugger Owners: lmacken ralph Branches: f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LZXty6ovV9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948104] Review Request: python-gearbox - Command line toolkit born as a PasteScript replacement for TurboGears2
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948104 --- Comment #2 from Luke Macken lmac...@redhat.com --- Sorry about that, forgot the BR on python-setuptools. I also removed the unnecessary %check until upstream ships them. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S6e0RbYK93a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #31 from Peter Lemenkov lemen...@gmail.com --- (In reply to comment #30) @Peter: could you please sponsor Sebastian, so he can ask git access? Sure! Unblocking FE-NEEDSPONSOR - I've just sponsored Sebastian. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ILYLkp5FRNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859111] Review Request: glassfish-pfl - GlassFish Primitive Function Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=859111 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aANSRAfeg2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859111] Review Request: glassfish-pfl - GlassFish Primitive Function Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=859111 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- glassfish-pfl-3.2.0-0.2.b001.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/glassfish-pfl-3.2.0-0.2.b001.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U1PtlrHSAZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948014] Review Request: python-backlash - Standalone WebOb port of the Werkzeug Debugger
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948014 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b5GtJmORVoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948014] Review Request: python-backlash - Standalone WebOb port of the Werkzeug Debugger
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948014 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9rE2LIaEQ2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948104] Review Request: python-gearbox - Command line toolkit born as a PasteScript replacement for TurboGears2
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948104 --- Comment #3 from Luke Macken lmac...@redhat.com --- Package updated with PYTHON 3000 support :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AfMZvIlFkDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859111] Review Request: glassfish-pfl - GlassFish Primitive Function Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=859111 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- glassfish-pfl-3.2.0-0.2.b001.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/glassfish-pfl-3.2.0-0.2.b001.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h9yKzEQorZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948104] Review Request: python-gearbox - Command line toolkit born as a PasteScript replacement for TurboGears2
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=948104
Ralph Bean rb...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|rb...@redhat.com
Flags||fedora-review+
--- Comment #4 from Ralph Bean rb...@redhat.com ---
Package is APPROVED.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[-]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-gearbox
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
MIT/X11 (BSD like), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in /home/threebean/948104
-python-gearbox/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 40960 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try
[Bug 948104] Review Request: python-gearbox - Command line toolkit born as a PasteScript replacement for TurboGears2
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948104 Luke Macken lmac...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Luke Macken lmac...@redhat.com --- New Package SCM Request === Package Name: python-gearbox Short Description: Command line toolkit born as a PasteScript replacement for TurboGears2 Owners: lmacken ralph Branches: f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M3uXOdk1Asa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948104] Review Request: python-gearbox - Command line toolkit born as a PasteScript replacement for TurboGears2
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948104 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kdbcVT4ygka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948104] Review Request: python-gearbox - Command line toolkit born as a PasteScript replacement for TurboGears2
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948104 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uReWBfjBq5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948275] Review Request: php-phpunit-Version - Managing the version number of Git-hosted PHP projects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948275 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added CC||shawn.iwin...@gmail.com Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8y9GLXUaCka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948275] Review Request: php-phpunit-Version - Managing the version number of Git-hosted PHP projects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948275 --- Comment #1 from Shawn Iwinski shawn.iwin...@gmail.com --- Created attachment 731690 -- https://bugzilla.redhat.com/attachment.cgi?id=731690action=edit fedora-review Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review --mock-config=fedora-rawhide-x86_64 -b 948275 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UT1DHSONgma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948275] Review Request: php-phpunit-Version - Managing the version number of Git-hosted PHP projects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948275 --- Comment #2 from Shawn Iwinski shawn.iwin...@gmail.com --- Created attachment 731691 -- https://bugzilla.redhat.com/attachment.cgi?id=731691action=edit phpci phpci version 2.13.2 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5CQHROxFuJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948275] Review Request: php-phpunit-Version - Managing the version number of Git-hosted PHP projects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948275 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Shawn Iwinski shawn.iwin...@gmail.com --- No blockers. = APPROVED = -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7Nu1HCQ23ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948589] New: Review Request: bookKeeper - Apache BookKeeper sub-project of ZooKeeper
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948589 Bug ID: 948589 Summary: Review Request: bookKeeper - Apache BookKeeper sub-project of ZooKeeper Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://gil.fedorapeople.org/bookkeeper.spec SRPM URL: http://gil.fedorapeople.org/bookkeeper-4.2.1-1.fc18.src.rpm Description: The Apache BookKeeper sub-project of ZooKeeper is made up of a distributed logging service called BookKeeper and a distributed publish/subscribe system built on top of BookKeeper called Hedwig. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UjbH8pkvGha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823122] Review Request: zookeeper - A high-performance coordination service for distributed applications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823122 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||948589 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CPDnSNZXvLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948589] Review Request: bookkeeper - Apache BookKeeper sub-project of ZooKeeper
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948589 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||823122 Summary|Review Request: bookKeeper |Review Request: bookkeeper |- Apache BookKeeper |- Apache BookKeeper |sub-project of ZooKeeper|sub-project of ZooKeeper -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dgvSvvC4Cja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948275] Review Request: php-phpunit-Version - Managing the version number of Git-hosted PHP projects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948275 --- Comment #4 from Shawn Iwinski shawn.iwin...@gmail.com --- Note that you used your personal email in the change log instead of your usual one so you may want to update that after initial import :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qdUkVpx1Qca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929214] Review Request: php-pear-Net-IMAP - Provides an implementation of the IMAP protocol
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929214 --- Comment #4 from Shawn Iwinski shawn.iwin...@gmail.com --- Created attachment 731701 -- https://bugzilla.redhat.com/attachment.cgi?id=731701action=edit fedora-review Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review --mock-config=fedora-rawhide-x86_64 -b 929214 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CoADyEBtk4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929214] Review Request: php-pear-Net-IMAP - Provides an implementation of the IMAP protocol
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929214 --- Comment #5 from Shawn Iwinski shawn.iwin...@gmail.com --- Created attachment 731702 -- https://bugzilla.redhat.com/attachment.cgi?id=731702action=edit phpci phpci version 2.13.2 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wbzmqgD2VZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929214] Review Request: php-pear-Net-IMAP - Provides an implementation of the IMAP protocol
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929214 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Shawn Iwinski shawn.iwin...@gmail.com --- No blockers. = APPROVED = -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9R9dQ1gNe2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
