[Bug 960849] New: Review Request: php-horde-Horde-Mongo - Horde Mongo Configuration
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960849 Bug ID: 960849 Summary: Review Request: php-horde-Horde-Mongo - Horde Mongo Configuration Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Mongo/php-horde-Horde-Mongo.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Mongo-1.0.0-0.1.beta1.remi.src.rpm Description: Fedora Account System Username: remi Provides an API to ensure that the PECL Mongo extension can be used consistently across various Horde packages. P.S. I will clean the EL-5 after import (buildroot, clean, ...) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KGafhjpAiB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960849] Review Request: php-horde-Horde-Mongo - Horde Mongo Configuration
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960849 Remi Collet changed: What|Removed |Added CC||n...@fedoraproject.org Alias||Horde_Mongo -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Cu1TH7TH26&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960851] New: Review Request: php-horde-Horde-Dav - Horde library for WebDAV, CalDAV, CardDAV
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960851 Bug ID: 960851 Summary: Review Request: php-horde-Horde-Dav - Horde library for WebDAV, CalDAV, CardDAV Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Dav/php-horde-Horde-Dav.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Dav-1.0.0-0.2.beta1.remi.src.rpm Description: This package contains all Horde-specific wrapper classes for the Sabre DAV library. Fedora Account System Username: remi P.S.1 : I will clean EL-5 stuff (Buildroot, clean, ...) after import P.S.2 : SabreDAV 1.8 is not yet available in Fedora, just to prepare future -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TtcJgNDzM6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960850] New: Review Request: php-horde-Horde-Dav - Horde library for WebDAV, CalDAV, CardDAV
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960850 Bug ID: 960850 Summary: Review Request: php-horde-Horde-Dav - Horde library for WebDAV, CalDAV, CardDAV Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Dav/php-horde-Horde-Dav.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Dav-1.0.0-0.2.beta1.remi.src.rpm Description: This package contains all Horde-specific wrapper classes for the Sabre DAV library. Fedora Account System Username: remi P.S.1 : I will clean EL-5 stuff (Buildroot, clean, ...) after import P.S.2 : SabreDAV 1.8 is not yet available in Fedora, just to prepare future -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sYVxb5zhNm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908329 Remi Collet changed: What|Removed |Added Blocks||960851 (Horde_Dav) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=84bzh3jslP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960851] Review Request: php-horde-Horde-Dav - Horde library for WebDAV, CalDAV, CardDAV
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960851 Remi Collet changed: What|Removed |Added CC||n...@fedoraproject.org Depends On||908329 (Horde_Core) Alias||Horde_Dav -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xtVrdNss2Q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: lang-table - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960839
--- Comment #1 from Mike FABIAN ---
BuildRequires: python-lxml
was missing, therefore the %check section always failed for
me when building with “mock”. Jens Petersen found the reason.
Fixed it like as below.
Spec URL: http://mfabian.fedorapeople.org/lang-table/lang-table.spec
SRPM URL:
http://mfabian.fedorapeople.org/lang-table/lang-table-0.0.1-1.fc18.src.rpm
updated.
diff --git a/lang-table.spec b/lang-table.spec
index 76f25d0..582bd73 100644
--- a/lang-table.spec
+++ b/lang-table.spec
@@ -9,6 +9,7 @@ License:GPLv3+
URL:https://github.com/mike-fabian/lang-table
Source0:
http://mfabian.fedorapeople.org/lang-table/%{name}-%{version}.tar.gz
BuildArch: noarch
+BuildRequires: python-lxml
BuildRequires: python-devel
%description
@@ -23,6 +24,7 @@ Summary:Python module to query the lang-table-data
Group: Development/Tools
Requires: %{name} = %{version}-%{release}
Requires: %{name}-data = %{version}-%{release}
+Requires: python-lxml
%description python
This package contains a Python module to query the data
@@ -47,7 +49,7 @@ perl -pi -e "s%datadir = '(.*)'%datadir =
'%{_datadir}/lang-table'%" langtable.p
%{__python} setup.py install --skip-build --prefix=%{_prefix}
--install-data=%{_datadir}/lang-table --root $RPM_BUILD_ROOT
%check
-#(cd $RPM_BUILD_DIR/%{name}-%{version}; %{__python} -m doctest test_cases.txt)
+(cd $RPM_BUILD_DIR/%{name}-%{version}; %{__python} -m doctest test_cases.txt)
%files
%doc README COPYING ChangeLog unicode-license.txt test_cases.txt
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=MfA8o9LQqK&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920879] Review Request: tali - GNOME tali game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920879 Christopher Meng changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed||2013-05-08 03:47:01 --- Comment #3 from Christopher Meng --- Hi, after doing the fedora-review there are still many things you should fix, like incorret address of FSF and large data should be packaged as tali-data and so on. But it seems the major problem is that this package is already in Fedora as "gnome-games-gtali". So, you've packaged a duplicated one. I think you can request to become a comaintainer of "gnome-games-gtali" package and update it.(The current version is 3.6.1) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=H7ys51Hfyc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890927] Review Request: php-horde-Horde-SessionHandler - Horde Session Handler API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890927 --- Comment #3 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/83418cbd23b166cddbbf80d050e57197e3e40d83/php/horde/php-horde-Horde-SessionHandler/php-horde-Horde-SessionHandler.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-SessionHandler-2.1.0-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8WaCzQc2vm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903246] Review Request: cpopen - Creates a subprocess in simpler safer manner
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903246 --- Comment #6 from Yaniv Bronhaim --- New update after merging cpopen to project vdsm. The only change is naming the library file to cpopen. http://bronhaim.fedorapeople.org/python-cpopen-1.2.2-1.fc17.src.rpm http://bronhaim.fedorapeople.org/python-cpopen.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XkiyMx3gzM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895921] Review Request: php-horde-Horde-Timezone - Timezone library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895921 --- Comment #2 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/df4406ea535b6ce2eaee1d89eaeae6c3a48b/php/horde/php-horde-Horde-Timezone/php-horde-Horde-Timezone.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Timezone-1.0.3-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yT1IzzVOPO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958810] Review Request: gfal2-plugin-xrootd - Provide xrootd support for GFAL2
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958810
--- Comment #2 from Adrien Devresse ---
Hi Alej,
Thank you for the review
I updated the src rpm from your comments :
Spec URL:
http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-plugin-xrootd/gfal2-plugin-xrootd.spec
SRPM URL:
http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-plugin-xrootd/gfal2-plugin-xrootd-0.2.2-2.el5.centos.src.rpm
Problems :
-> Only packaging related entries should appear. There are entries
related to upstream.
--> Done
> gfal2-devel requires glib2-devel, so this BuildRequires should
be removed.
--> Corrected
> It is manually installed under _docdir
--> All files under _docdir are automatically marked as "documentation" like
with the %doc macro. The usage of the doc macro is not needed in this case.
http://www.redhat.com/archives/rpm-list/2001-September/msg00152.html
> Missing make %{?_smp_mflags} in build, or those flags in install
--> Done, add missing make entry
Cheers,
Adrien
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=OCmxlf1V48&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957573] Review Request: php-aws-sdk - amazon web services sdk for php
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957573 --- Comment #25 from Gregor Tätzner --- * Wed May 08 2013 Gregor Tätzner - 1.6.2-5 - unbundle sfyaml - fix requires - mark doc in package.xml (In reply to comment #19) > 2/ bundled libraries yaml is out. these 3 are left: > - AWSSDKforPHP/lib/cachecore > - AWSSDKforPHP/lib/dom > - AWSSDKforPHP/lib/requestcore Do you want to create review requests? > 3/ cacert.pem > > I think this shouldn't be package, isn't the system one enough > (ca-certificates) ? probably, but we should handle this in our hypothetical php-requestcore package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2uhRHmfCPi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: lang-table - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960839
--- Comment #2 from Parag AN(पराग) ---
+ koji scratch build ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=5346037
+ rpmlint on rpms gave
lang-table-python.noarch: W: no-documentation
lang-table-data.noarch: W: summary-not-capitalized C data files for lang-table
lang-table-data.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 3 warnings.
==> Fix summary for lang-table-data
Issues:
===
1) Package contains BR: python2-devel or python3-devel
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
2) No Requires: %{name}%{?_isa} = %{version}-%{release} in lang-table-python ,
lang-table-data
3) No need to write for python packages now following in spec for only Fedora
specific packages
%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}
4) One more suggestion for upstream, I am confused actually with the usage of
lang-table and langtable words. Can upstream use any single word everywhere?
like package name is lang-table but python source file is langtable.py
Shouldn't then your package name be python-langtable for your python
subpackage.
See
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29
5) I am a bit confused about licensing here. all *.py files have header for
LGPLv3+ whereas setup.py says that module is in GPLv3+
Also, you need to specify "and MIT" in license tag and add comment about which
code is in which license.
I see unicode-license,txt refers to "Modern Style without sublicense (Unicode)"
license whose short form is MIT
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=J4aghVSSRJ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924310] Review Request: mate-document-viewer - Document viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924310 nucleo changed: What|Removed |Added CC||alekc...@googlemail.com --- Comment #3 from nucleo --- I tried to build src.rpm but mate-keyring-1 wasn't found, libmatekeyring-devel needed instead of mate-keyring-devel. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=earlULpVLH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 906161] Review Request: python-pelican - Generate static sites from reStructuredText or Markdown documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906161 --- Comment #6 from Ondřej Surý --- Ack, I can confirm that this issue has been fixed, and I also can confirm that I haven't found any other licensing issue in the source package. It will hit the Debian very soon (as soon as I have some time to finish the packaging). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Fc2Ek4Og9G&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956147] Review Request: wide-dhcpv6 - DHCPv6 Prefix Delegation client that works on PPP
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956147 --- Comment #10 from David Beveridge --- (In reply to comment #5) > - The upstream version is kinda awkward, but it's probably best to stick with > it as you did. > - I would include your patches as source, instead of adding a github > repository. done > > If you do the above, then the first section of macros can all go and it > would be much cleaner > and standard. it sure is > Just add: %global _hardened_build 1 at the top of the spec file, and make done > sure the cflags/linker flags make it properly. You can check using this > script that is not yet integrated into rpmlint: > https://nohats.ca/checksec.sh not done yet > - Add the sysconfig file(s) as SOURCEx: files, and remove the use of rh_dir > - Don't use systemctl directly, use the proper macros > - The exit 0 should not be needed in %post > - Remove the %clean section, unless you're building for EL-5 > - Remove the %defattr line in the %files section, unless building for EL-5 done > - You're using /etc/ppp which belongs to the ppp package, so add Requires: > for it removed, it was crap anyway. need to cover this better in docs when we know how initscripts will call it. > - Why do you require the static version of flex ? flex-static seems to just > install flex-devel? I do see it fails to compile without flex-devel, but > this changed > - The resolv.conf hackery is problematic, but that can be tackled after the >package has made it in. (one should use a NM plugin to rewrite that file, >and if local DNSSEC is enabled you cannot touch that file at all. And if >you chown, you probably also need chcon for SElinux) I'm not a big fan if having DHCPv6 set DNS. Pretty much everyone will be running dual stack for now, and the IPv4 stack can handle DNS, (or the administrator can just set it to 2001:4860:4860::) > - Looks like there are some "sample" configs. That's not allowed outside of > the %doc area. The config files should work from package install if placed > in /etc. Apart from the sample files I see mention in /etc/wide-dhcpv6 > / dhcp6c.conf of ethernet devices by names that are not valid for everyone. >That's also a problem. all moved to %doc, and these could be expanded on when I know whats happening with the initscripts. > - Your /etc/sysconfig files have empty VAR= entries, which systemd really > does not like. > (at least it did not in the past, not sure how it handles it these days) > removed, I also moved the systemd service files to %doc for now, as they contain config. > I haven't run the full fedora-review yet, but I will do so when you've > addressed most of the things listed here :) > I've made lots of changes and done not much testing at this point, and it's mothers day this weekend so I don't know how much time I'll have for that till next week. But here goes anyway... http://repo.bevhost.com/fedora/wide-dhcpv6.spec http://repo.bevhost.com/fedora/wide-dhcpv6-20080615-11.1.3.fc18.src.rpm PS: still not sure about SELINUX policies. I need to test this too. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nKmKQ25Vyu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785312] Review Request: e3 - Text editor with key bindings similar to WordStar, Emacs, pico, nedit, or vi
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785312 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=36IMm9Ld9R&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785312] Review Request: e3 - Text editor with key bindings similar to WordStar, Emacs, pico, nedit, or vi
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785312 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5wqDKfUcCX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wlr7HqA1Ck&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jYty4uR3tz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958150] Review Request: xfe - X File Explorer File Manager
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958150 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mLxMCIsOJ8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958150] Review Request: xfe - X File Explorer File Manager
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958150 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=orhfpxSGDJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957815] Review Request: edg-mkgridmap - tool to build the grid map-file from VO servers
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957815
Adrien Devresse changed:
What|Removed |Added
CC||ade...@gmail.com
Assignee|nob...@fedoraproject.org|ade...@gmail.com
--- Comment #1 from Adrien Devresse ---
Hi,
I take the responsability ofthis review.
I get a failure on EL5, you don't want to pacakge this software for EL5 ?
http://koji.fedoraproject.org/koji/taskinfo?taskID=5346381
First informal review :
- your patch for forcing the %doc macro is not needed, you can just use the
%{_docdir} macro.
- The %dir need to be used to define the ownership of
%{_libexecdir}/edg-mkgridmap to your package
Regards,
Adrien
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=UvfgGmkdh8&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957815] Review Request: edg-mkgridmap - tool to build the grid map-file from VO servers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957815 Adrien Devresse changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t2rJMz9nhA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949371] Review Request: StarCluster - Tool for managing computing clusters hosted on Amazon's EC2
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=949371
--- Comment #16 from Mamoru TASAKA ---
Ah sorry. Dependency on -doc subpackage should be:
Requires: %{name} = %{version}-%{release}
not
Requires: %{name}-%{version}-%{release}
Please fix this, thank you.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=EPdhT09eco&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957815] Review Request: edg-mkgridmap - tool to build the grid map-file from VO servers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957815 --- Comment #2 from Alejandro Alvarez --- Hi, It wasn't building in EL5 because I did a rpmbuild instead of a rpmbuild-md5. Sorry about that. I attach the new spec and srpm with the fix for the directory. I think the patch is appropriate, since the installation location in the Makefile is /usr/share/doc/edg-mkgridmap, without the version. Spec URL: https://aalvarez.web.cern.ch/aalvarez/fedora/edg-mkgridmap.spec SRPM URL: https://aalvarez.web.cern.ch/aalvarez/fedora/edg-mkgridmap-4.0.0-3.src.rpm EL5: http://koji.fedoraproject.org/koji/taskinfo?taskID=5346505 EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=5346507 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5346509 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iEsrsfldFd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956127] Review Request: entypo-fonts - Pictogram Suite Font
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956127 --- Comment #12 from Alec Leamas --- Created attachment 745238 --> https://bugzilla.redhat.com/attachment.cgi?id=745238&action=edit fontlint output entypo Output from repo-font-audit. The upstream website does not have a bugtracker, so I have sent an email with the results. The missing codepoints are easy to patch, the rest is beyond my abilities. It's worth noting that the three errors Self Intersecting Glyph, Missing Points at Extrema and Bad Glyph Name are quite common in currently packaged fonts. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Gn5QnmbLMt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957339] Review Request: openerp7 - Business Applications Server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957339 Alec Leamas changed: What|Removed |Added Depends On||956127 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NLUo6pj1HB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956127] Review Request: entypo-fonts - Pictogram Suite Font
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956127 Alec Leamas changed: What|Removed |Added Blocks||957339 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PqZOitST1J&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958810] Review Request: gfal2-plugin-xrootd - Provide xrootd support for GFAL2
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958810 Alejandro Alvarez changed: What|Removed |Added Assignee|nob...@fedoraproject.org|alejandro.alvarez.ayllon@ce ||rn.ch Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W0mgOzBTNN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956127] Review Request: entypo-fonts - Pictogram Suite Font
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956127 --- Comment #13 from Alec Leamas --- The webfont discussion seems to boil down to that there is no such thing. As a consequence, this is packaged as a regular ttf desktop font. Also because of this discussion, I don't package the @typeface fonts, just the desktop ones. The -Social fonts have trademarked symbols and are not packaged for these reasons. When installing the font, it does show up in Libreoffice for me (when using Format|Character). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=51KUZXkgX1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958810] Review Request: gfal2-plugin-xrootd - Provide xrootd support for GFAL2
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958810
--- Comment #3 from Alejandro Alvarez ---
Builds pass
Fedora 20 build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5346575
EL6 build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5346589
EL5 build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5346601
rpmlint output
==
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
MUST
[OK] The package must be named according to the Package Naming Guidelines.
[OK] Package does not use a name that already exist.
[OK] The spec file name must match the base package %{name}, in the format
%{name}.spec
[OK] Spec file lacks Packager, Vendor, PreReq tags.
[OK] Changelog in prescribed format.
[OK] The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
[OK] The License field in the package spec file must match the actual license.
[OK] The spec file must be written in American English.
[OK] The spec file for the package MUST be legible.
[--] If a rename, provides/obsoletes is specified.
[--] The spec file MUST handle locales properly.
[OK] Every binary RPM package which stores shared library files in any of the
dynamic linker's default paths, must call ldconfig in %post and %postun.
[OK] If the source package includes the text of the license(s) in its own file,
then that file, containing the text of the license(s) for the package must be
included in %doc.
[OK] -debuginfo package or justification otherwise.
[--] Development files must be in a -devel package.
[--] Static libraries must be in a -static package.
[--] Devel packages must require the base package using a fully versioned
dependency
[--] Large documentation files must go in a -doc subpackage.
[OK] The sources used to build the package must match the upstream source, as
provided in the spec URL.
[OK] The package must contain code, or permissable content.
[OK] Package obeys FHS, except libexecdir and /usr/target.
[OK] Packages must NOT contain any .la libtool archives.
[OK] Packages must not own files or directories already owned by other packages
[--] Packages containing GUI applications must include a %{name}.desktop file.
[OK] A Fedora package must not list a file more than once in the spec file's
%files listings.
[OK] A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
[OK] Packages must NOT bundle copies of system libraries
[--] If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package.
[OK] All filenames in rpm packages must be valid UTF-8.
[OK] Permissions on files must be set properly.
[OK] Each package must consistently use macros.
[OK] No external kernel modules
[OK] No inclusion of pre-built binaries or libraries
[OK] No need for external bits
[OK] All build dependencies must be listed in BuildRequires.
[--] If a package includes something as %doc, it must not affect the runtime of
the application.
[OK] %build honors applicable compiler flags or justifies otherwise.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags
[OK] The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
[--] If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[OK] Package installs properly.
SHOULD
==
[--] All patches have an upstream bug link or comment
[OK] The source package does not include license text(s) as a separate file
from upstream.
[OK] No PreReq
[OK] %makeinstall is not used
[OK] Timestamp is preserved
[OK] Parallel make
[--] Subpackages other than devel should require the base package using a fully
versioned dependency.
[--] If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[--] The placement of pkgconfig(.pc) files should be in a -devel pkg
[OK] The package builds in mock.
[OK] The package should compile and build into binary rpms on all supported
architectures.
[OK] The package functions as described.
[--] If scriptlets are used, those scriptlets must be sane.
[--] The package should contain man pages for binaries/scripts
[--] The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.
Checksums
=
http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-plugin-xrootd/gfal2-plugin-xrootd-0.2.2.tar.gz
:
CHECKSUM(SHA256) this package :
f609074eadb979aad71c810f56e0161a843cdbb7e0609c0c0b12a6c768ad030b
CHECKSUM(SHA256) upstream package :
f609074eadb979aad71c810f56e0161a843cdbb7e0609c0c0b12a6c768ad030b
Looks
[Bug 958810] Review Request: gfal2-plugin-xrootd - Provide xrootd support for GFAL2
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958810 Alejandro Alvarez changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KJ63MRayge&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957436] Review Request: lookat - A user-friendly text file viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957436 --- Comment #7 from Fedora Update System --- lookat-1.4.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lookat-1.4.2-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EtdnGMBZJI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951711] Review Request: impressjs - Javascript presentation framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951711 --- Comment #7 from Ralph Bean --- Thanks Tom. Upstream just responded to the ticket indicating this is MIT or GPLv2+. Spec file updated: Spec URL: http://threebean.org/rpm/impressjs.spec SRPM URL: http://threebean.org/rpm/impressjs-0.5.3-20130412gitgedff5a0.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RNxlBkl8W7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956134] Review Request: mnmlicons-fonts - Perkins Less Web Framework webfonts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956134 --- Comment #1 from Alec Leamas --- Created attachment 745253 --> https://bugzilla.redhat.com/attachment.cgi?id=745253&action=edit repo-font-audit output fontlint reports Self Intersecting Glyph, Wrong Direction and Missing Points at Extrema. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RBuxaDUw1s&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956134] Review Request: mnmlicons-fonts - Perkins Less Web Framework webfonts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956134 Alec Leamas changed: What|Removed |Added Blocks||957339 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zeEYFDW59F&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957339] Review Request: openerp7 - Business Applications Server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957339 Alec Leamas changed: What|Removed |Added Depends On||956134 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Dy2vZZkcqi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: lang-table - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960839
--- Comment #3 from Mike FABIAN ---
(In reply to comment #2)
> + koji scratch build ->
> http://koji.fedoraproject.org/koji/taskinfo?taskID=5346037
>
> + rpmlint on rpms gave
> lang-table-python.noarch: W: no-documentation
> lang-table-data.noarch: W: summary-not-capitalized C data files for
> lang-table
> lang-table-data.noarch: W: no-documentation
> 4 packages and 0 specfiles checked; 0 errors, 3 warnings.
>
> ==> Fix summary for lang-table-data
Done.
> Issues:
> ===
> 1) Package contains BR: python2-devel or python3-devel
> See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
Fixed.
> 2) No Requires: %{name}%{?_isa} = %{version}-%{release} in lang-table-python
> , lang-table-data
Not needed because the package is “noarch” and %{_isa} is needed
only for architecture dependend packages.
> 3) No need to write for python packages now following in spec for only
> Fedora specific packages
>
> %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from
> distutils.sysconfig import get_python_lib; print get_python_lib()")}
Removed.
> 4) One more suggestion for upstream, I am confused actually with the usage
> of lang-table and langtable words. Can upstream use any single word
> everywhere?
>
> like package name is lang-table but python source file is langtable.py
Renamed everything to just “langtable”.
> Shouldn't then your package name be python-langtable for your python
> subpackage.
> See
> http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.
> 28python_modules.29
Maybe langtable-python is OK as well, there are many other
-python packages.
> 5) I am a bit confused about licensing here. all *.py files have header for
> LGPLv3+ whereas setup.py says that module is in GPLv3+
>
> Also, you need to specify "and MIT" in license tag and add comment about
> which code is in which license.
>
> I see unicode-license,txt refers to "Modern Style without sublicense
> (Unicode)" license whose short form is MIT
Fixed and clarified in the .spec file and README.
New URLs coming in the next comment ...
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=7BurU8oUwu&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: lang-table - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960839 --- Comment #4 from Mike FABIAN --- New Urls for comment#3: Spec URL: http://mfabian.fedorapeople.org/langtable/langtable.spec SRPM URL: http://mfabian.fedorapeople.org/langtable/langtable-0.0.1-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wnggc75FXw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919265] Review Request: Bijiben - Note taking app
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 Kalev Lember changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #21 from Kalev Lember --- Alright, I see you've done an (unofficial) review for quadrapassel (bug 920875) and it looks good to me. I have now sponsored you to the packager group, use your new powers visely! Feel free to go ahead and approve quadrapassel officially. (Your new permissions might take up to an hour to sync before you can do that, though.) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n1IwtdQufq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956134] Review Request: mnmlicons-fonts - Perkins Less Web Framework webfonts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956134 --- Comment #2 from Alec Leamas --- Updating: only package ttf font after discussion on fedora-devel. Same links. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lgcigXdroV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919265] Review Request: Bijiben - Note taking app
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=919265
--- Comment #22 from Kalev Lember ---
A few comments / questions about this package:
1) The name and summary in the spec file should match up with the name and
summary in the review ticket (and also with the name and summary in the SCM
request that you are going to file soon). Right now the ticket here has:
Review Request: Bijiben - Note taking app
... and the spec file:
Name: bijiben
Summary:Simple Note Viewer
Can you update the ticket here with the lowercase 'bijiben' name and sync up
the descriptions? The scripts for creating new git repos check these.
2)
> autoreconf -i -f
The autoreconf call seems unneeded now that you are no longer patching the
build system.
3)
> %exclude %{_libdir}/%{name}/libgd.la
Shouldn't be needed any more now that the package is no longer installing the
libgd shared library.
4)
> %files
> %doc NEWS AUTHORS COPYING ChangeLog NEWS README
> %files -f %{name}.lang
Two issues here: you are repeating the %files section and the NEWS file is
listed twice. It should read:
%files -f %{name}.lang
%doc AUTHORS COPYING ChangeLog NEWS README
5)
/usr/share/bijiben/icons
/usr/share/bijiben/icons/hicolor
/usr/share/bijiben/icons/hicolor/16x16
/usr/share/bijiben/icons/hicolor/16x16/actions
/usr/share/bijiben/icons/hicolor/16x16/actions/note.png
/usr/share/bijiben/icons/hicolor/24x24
/usr/share/bijiben/icons/hicolor/24x24/actions
/usr/share/bijiben/icons/hicolor/24x24/actions/note.png
/usr/share/bijiben/icons/hicolor/48x48
/usr/share/bijiben/icons/hicolor/48x48/actions
/usr/share/bijiben/icons/hicolor/48x48/actions/note.png
/usr/share/bijiben/icons/hicolor/scalable
/usr/share/bijiben/icons/hicolor/scalable/actions
/usr/share/bijiben/icons/hicolor/scalable/actions/link.svg
/usr/share/bijiben/icons/hicolor/scalable/actions/note.svg
Are these supposed to get installed in /usr/share/bijiben ? The directory
layout looks like they should have gone to /usr/share/icons/hicolor instead.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=XInPP4jB9g&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949371] Review Request: StarCluster - Tool for managing computing clusters hosted on Amazon's EC2
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949371 --- Comment #17 from Orion Poplawski --- Thanks, fixed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kOTFOjgjyO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: lang-table - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960839 Parag AN(पराग) changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #5 from Parag AN(पराग) --- Thank you for updating upstream as well as fedora srpm. APPROVED this package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zrFVFcYCEj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: lang-table - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960839 Mike FABIAN changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Mike FABIAN --- New Package SCM Request === Package Name: langtable Short Description: For guessing reasonable defaults for locale, keyboard, territory, … Owners: mfabian Branches: f19 InitialCC: i18n-team -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XYLyNLD4YN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919265] Review Request: Bijiben - Note taking app
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #23 from Mathieu Bridon --- (In reply to comment #22) > 5) > /usr/share/bijiben/icons > /usr/share/bijiben/icons/hicolor > /usr/share/bijiben/icons/hicolor/16x16 > /usr/share/bijiben/icons/hicolor/16x16/actions > /usr/share/bijiben/icons/hicolor/16x16/actions/note.png > /usr/share/bijiben/icons/hicolor/24x24 > /usr/share/bijiben/icons/hicolor/24x24/actions > /usr/share/bijiben/icons/hicolor/24x24/actions/note.png > /usr/share/bijiben/icons/hicolor/48x48 > /usr/share/bijiben/icons/hicolor/48x48/actions > /usr/share/bijiben/icons/hicolor/48x48/actions/note.png > /usr/share/bijiben/icons/hicolor/scalable > /usr/share/bijiben/icons/hicolor/scalable/actions > /usr/share/bijiben/icons/hicolor/scalable/actions/link.svg > /usr/share/bijiben/icons/hicolor/scalable/actions/note.svg > > > Are these supposed to get installed in /usr/share/bijiben ? The directory > layout looks like they should have gone to /usr/share/icons/hicolor instead. I don't think so, or at least, they should probably be renamed then, to avoid conflicts with other packages. (these names are too generic for a shared location) But is there something in the guidelines that forbids installing icons here? That seems perfectly fine to me. (I'm asking because I thought it was fine when I did the initial review, and I'd be happy to learn if I was wrong :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SZst7eklAX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: lang-table - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960839 --- Comment #7 from Jon Ciesla --- Requested package name langtable doesn't match bug summary lang-table, please correct. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M8SSQrpvCU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: lang-table - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960839 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HgyU8ItzBb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: langtable - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960839 Mike FABIAN changed: What|Removed |Added Summary|Review Request: lang-table |Review Request: langtable - |- For guessing reasonable |For guessing reasonable |defaults for locale,|defaults for locale, |keyboard, territory, … |keyboard, territory, … -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MPBxlJ5emQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: langtable - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960839 Mike FABIAN changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Mike FABIAN --- Fixed bug summary. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0oaPZ6PKJr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919265] Review Request: Bijiben - Note taking app
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #24 from Kalev Lember --- No, nothing wrong with it, it's perfectly fine :) Just wanted to doublecheck that it's not a typo, easy to accidentally use pkgdatadir instead of datadir. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rXpAOCbCn1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951711] Review Request: impressjs - Javascript presentation framework
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=951711
Ricky Elrod changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #8 from Ricky Elrod ---
One remaining thing:
I was wrong in my comment above - rather than nuking the '1', it just needed a
period added after it. Sorry about that.
impressjs-0.5.3-20130412gitgedff5a0.fc20.noarch.rpm
becomes
impressjs-0.5.3-1.20130412gitgedff5a0.fc20.noarch.rpm
If you fix that, this is APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[-]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 61440 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -r
[Bug 951711] Review Request: impressjs - Javascript presentation framework
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=951711
--- Comment #9 from Ricky Elrod ---
One more thing - it might be more clean to do:
install -D -m 0644 js/impress.js %{buildroot}%{_datadir}/impressjs/impress.js
rather than
%{__mkdir_p} %{buildroot}%{_datadir}/impressjs
cp js/impress.js %{buildroot}%{_datadir}/impressjs/impress.js
but this is nonblocking, and still APPROVED. :)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=K8b3gIPjYT&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956127] Review Request: entypo-fonts - Pictogram Suite Font
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956127 --- Comment #14 from Orion Poplawski --- I thought the plan was only to ship the .ttf (and perhaps the .eot if ie9 support was needed)? Is the fontconfig file still correct, this seems wrong to me: $ cat /usr/share/fontconfig/conf.avail/70-entypo.conf entypo @font-face though I'm not sure what is correct. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qUHzNZhVNl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961048] New: Review Request: codemod - A tool to assist with large codebase refactors
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961048 Bug ID: 961048 Summary: Review Request: codemod - A tool to assist with large codebase refactors Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rel...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://codeblock.fedorapeople.org/packages/codemod/codemod.spec SRPM URL: http://codeblock.fedorapeople.org/packages/codemod/codemod-1.0-1.20130508giteac2165.fc19.src.rpm Description: Codemod is a tool/library to assist you with large-scale code base refactors that can be partially automated but still require human oversight and occasional intervention. Fedora Account System Username: codeblock -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nspSAkio5I&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: langtable - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960839 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vyEUHWcWqh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960839] Review Request: langtable - For guessing reasonable defaults for locale, keyboard, territory, …
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960839 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FY28hiaXWg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951711] Review Request: impressjs - Javascript presentation framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951711 --- Comment #10 from Ralph Bean --- Updated with your comments! Spec URL: http://threebean.org/rpm/impressjs.spec SRPM URL: http://threebean.org/rpm/impressjs-0.5.3-1.20130412gitgedff5a0.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AeSiAETN6W&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920909] Review Request: gnome-chess - GNOME Chess game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920909 Christopher Meng changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #4 from Christopher Meng --- Licensing problem is fixed or not? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=97o7xztUW9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951711] Review Request: impressjs - Javascript presentation framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951711 Ralph Bean changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Ralph Bean --- New Package SCM Request === Package Name: impressjs Short Description: Javascript presentation framework Owners: ralph Branches: f19 f18 f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hBrcrguXDR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959118] Review Request: fossil - A distributed SCM with bug tracking and wiki
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959118 Ralph Bean changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #11 from Ralph Bean --- Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CT7j2atD7v&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919703] Review Request: libgap - libGAP -- a C library version of the GAP kernel
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=919703
Christopher Meng changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #1 from Christopher Meng ---
1)Source0 URL is unreachable;
2)Summary is not good, try this:
"Summary:A C library version of the GAP kernel"
3)Is there any doc for devel package?
4)In %install section I often use this:
find %{buildroot} -name '*.la' -exec rm -f {} ';'
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=3rS06GWsv4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960664] Review Request: chicken - A practical and portable Scheme system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960664 Trever Fischer changed: What|Removed |Added CC||wm...@wm161.net Assignee|nob...@fedoraproject.org|wm...@wm161.net Flags||fedora-review? --- Comment #1 from Trever Fischer --- Taking for a review -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qyWspR4Lb2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960664] Review Request: chicken - A practical and portable Scheme system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960664
Trever Fischer changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Trever Fischer ---
Overall, looks to be an exemplary piece of packaging work. Well done.
My only question:
Provides: chicken-scheme-doc = %{version}-%{release}
Whats the point of that, if it already provides a chicken-doc package?
Alternatively, why not rename the whole package to chicken-scheme instead of
just chicken.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=WIiOhrACKv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961048] Review Request: codemod - A tool to assist with large codebase refactors
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=961048
Ralph Bean changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||rb...@redhat.com
Assignee|nob...@fedoraproject.org|rb...@redhat.com
Flags||fedora-review+
--- Comment #1 from Ralph Bean ---
Package is APPROVED.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)". Detailed output of licensecheck in
/home/threebean/961048-codemod/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of
[Bug 960664] Review Request: chicken - A practical and portable Scheme system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960664 --- Comment #3 from Ricky Elrod --- I will nuke the Provides in favor of keeping the package named "chicken" - it's called chicken in most distros: http://wiki.call-cc.org/platforms Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=koGUxgeRQv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960664] Review Request: chicken - A practical and portable Scheme system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960664 Ricky Elrod changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Ricky Elrod --- New Package SCM Request === Package Name: chicken Short Description: A practical and portable Scheme system Owners: codeblock Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P5dzxscK9R&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961048] Review Request: codemod - A tool to assist with large codebase refactors
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961048 Ricky Elrod changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Ricky Elrod --- New Package SCM Request === Package Name: codemod Short Description: A tool to assist with large codebase refactors Owners: codeblock Branches: el6 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UrfKyfjr7z&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 925971] Review Request: drupal6-prepopulate - Allows form elements to be pre-populated from the URL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=925971 --- Comment #6 from Fedora Update System --- drupal6-prepopulate-2.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal6-prepopulate-2.2-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x0CHF1DjBz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 925971] Review Request: drupal6-prepopulate - Allows form elements to be pre-populated from the URL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=925971 --- Comment #7 from Fedora Update System --- drupal6-prepopulate-2.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/drupal6-prepopulate-2.2-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nrUTZzkgqx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 925971] Review Request: drupal6-prepopulate - Allows form elements to be pre-populated from the URL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=925971 --- Comment #8 from Fedora Update System --- drupal6-prepopulate-2.2-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/drupal6-prepopulate-2.2-1.el5 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8fNPAeCKR9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 925971] Review Request: drupal6-prepopulate - Allows form elements to be pre-populated from the URL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=925971 --- Comment #9 from Fedora Update System --- drupal6-prepopulate-2.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/drupal6-prepopulate-2.2-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JcaaD7rRwW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 925971] Review Request: drupal6-prepopulate - Allows form elements to be pre-populated from the URL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=925971 --- Comment #10 from Fedora Update System --- drupal6-prepopulate-2.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/drupal6-prepopulate-2.2-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sZm2Qv5gHY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951711] Review Request: impressjs - Javascript presentation framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951711 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LlJuoIPsXM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951711] Review Request: impressjs - Javascript presentation framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951711 --- Comment #12 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CwOxKUWLqh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960664] Review Request: chicken - A practical and portable Scheme system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960664 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PVBv1T1yk4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960664] Review Request: chicken - A practical and portable Scheme system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960664 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xe0mJInlEn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961048] Review Request: codemod - A tool to assist with large codebase refactors
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961048 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nfs4svinSU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961048] Review Request: codemod - A tool to assist with large codebase refactors
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961048 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JlGJwshb7E&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953701] Review Request: python-webm - Python wrapper to WebM libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953701 T.C. Hollingsworth changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GPD2VYQuH8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928609] Review Request: xpra - screen for X
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928609 --- Comment #15 from T.C. Hollingsworth --- python-webm is now in Rawhide and updates-testing for all active branches as well. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4hzZT9iu53&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928841] Review Request: drupal7-theme-zen - Zen is a powerful, yet simple, HTML5 starting theme
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928841 --- Comment #12 from Fedora Update System --- drupal7-theme-zen-5.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/drupal7-theme-zen-5.1-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DZ6ndgp53y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928841] Review Request: drupal7-theme-zen - Zen is a powerful, yet simple, HTML5 starting theme
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928841 --- Comment #13 from Fedora Update System --- drupal7-theme-zen-5.1-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/drupal7-theme-zen-5.1-3.el5 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0maaKwOea3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928841] Review Request: drupal7-theme-zen - Zen is a powerful, yet simple, HTML5 starting theme
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928841 --- Comment #14 from Fedora Update System --- drupal7-theme-zen-5.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/drupal7-theme-zen-5.1-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gIGI85HExb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928841] Review Request: drupal7-theme-zen - Zen is a powerful, yet simple, HTML5 starting theme
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928841 --- Comment #15 from Fedora Update System --- drupal7-theme-zen-5.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal7-theme-zen-5.1-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XYj4PisXLp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928841] Review Request: drupal7-theme-zen - Zen is a powerful, yet simple, HTML5 starting theme
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928841 --- Comment #16 from Fedora Update System --- drupal7-theme-zen-5.1-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/drupal7-theme-zen-5.1-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UP5Vg8ieWQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961048] Review Request: codemod - A tool to assist with large codebase refactors
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961048 --- Comment #4 from Fedora Update System --- codemod-1.0-1.20130508giteac2165.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/codemod-1.0-1.20130508giteac2165.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ju3FuUXo6D&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961048] Review Request: codemod - A tool to assist with large codebase refactors
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961048 --- Comment #5 from Fedora Update System --- codemod-1.0-1.20130508giteac2165.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/codemod-1.0-1.20130508giteac2165.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2KYCA4feXQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907585] Review Request: repsnapper - RepRap control software
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907585 Miro Hrončok changed: What|Removed |Added Whiteboard|NotReady| --- Comment #10 from Miro Hrončok --- libreprap is no longer used updated to 2.2.0a2 will package this only for F19 and F20, so no Clipper lib issues are present anymore License issues solved. Spec URL: https://raw.github.com/hroncok/SPECS/master/repsnapper.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/repsnapper-2.2.0-0.1.a2.fc18.src.rpm You might notice W: invalid-license softSurfer, but it is not relevant, as it has been added to Fedora https://fedoraproject.org/wiki/Licensing/softSurfer -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rZddfoOCDW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961078] New: Review Request: rasdaemon - Daemon to collect RAS error tracing events from the Kernel drivers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961078 Bug ID: 961078 Summary: Review Request: rasdaemon - Daemon to collect RAS error tracing events from the Kernel drivers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mche...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: https://git.fedorahosted.org/cgit/rasdaemon.git/tree/misc/rasdaemon.spec SRPM URL: http://mchehab.fedorapeople.org/rasdaemon-0.2.0-1.fc18.src.rpm Description: Daemon to collect RAS error tracing events from the Kernel drivers Fedora Account System Username: mchehab -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h90Q29j1mD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960264] NetworkManager-openconnect - Update to commit e220f6c from NM_0_8 branch
Product: Fedora EPEL https://bugzilla.redhat.com/show_bug.cgi?id=960264 Rex Dieter changed: What|Removed |Added Keywords||Triaged CC||rdie...@math.unl.edu Blocks|177841 (FE-NEEDSPONSOR) | Summary|Review Request: |NetworkManager-openconnect |NetworkManager-openconnect |- Update to commit e220f6c |- Update to commit e220f6c |from NM_0_8 branch |from NM_0_8 branch | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LJMazZohmM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 923460] Review Request: libqmi - glib helper library for the Qualcomm MSM Interface (QMI) protocol
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923460 --- Comment #7 from Dan Williams --- Updated again; I added a comment for the SOURCE line; there won't always be fixes, and it's much smoother to make dist a tarball from git than it is to git format-patch -X and add those all to the fedora package. Thus there isn't an upstream source URL from the tarball I've used. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Gwkdd5cp1E&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 923460] Review Request: libqmi - glib helper library for the Qualcomm MSM Interface (QMI) protocol
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923460 --- Comment #8 from Dan Williams --- Spec URL: http://people.redhat.com/dcbw/libqmi.spec SRPM URL: http://people.redhat.com/dcbw/libqmi-1.3.0-1.git20130508.fc17.src.rpm Description: This package contains the libraries that make it easier to use QMI functionality from applications that use glib. Fedora Account System Username: dcbw -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZBMzHwgXUz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953701] Review Request: python-webm - Python wrapper to WebM libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953701 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- python-webm-0.2.2-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8CUweWnwjv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959118] Review Request: fossil - A distributed SCM with bug tracking and wiki
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959118 Patrick Uiterwijk changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Patrick Uiterwijk --- New Package SCM Request === Package Name: fossil Short Description: A distributed SCM with bug tracking and wiki Owners: puiterwijk Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YGMeKWbh5h&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957333] Review Request: quiterss - Qt-based RSS/Atom aggregator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957333 Fedora Update System changed: What|Removed |Added Status|NEW |ON_QA --- Comment #24 from Fedora Update System --- quiterss-0.12.5-3.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0Th34LYVk1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 925971] Review Request: drupal6-prepopulate - Allows form elements to be pre-populated from the URL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=925971 Fedora Update System changed: What|Removed |Added Status|NEW |ON_QA --- Comment #11 from Fedora Update System --- drupal6-prepopulate-2.2-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9rDqdeJoB1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960194] Review Request: qterminal - Qt-based terminal emulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960194 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #18 from Fedora Update System --- qterminal-0.4.0-3.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6FWUI7ad3l&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
