[Bug 1009967] Review Request: golang-googlecode-net - Supplementary Go networking libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1009967 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- golang-googlecode-net-0-0.7.hg84a4013f96e0.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.7.hg84a4013f96e0.fc20 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ODRpZmLY6Aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010613] Review Request: ck - Concurrency Kit
https://bugzilla.redhat.com/show_bug.cgi?id=1010613 Michael Schwendt bugs.mich...@gmx.net changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #2 from Michael Schwendt bugs.mich...@gmx.net --- The upstream name is Concurrency Kit, so IMO the package should be named concurrencykit or concurrency-kit. However, the tarball and git repo contain just ck. The FPC needs to clarify the naming guidelines, as else it's not clear what upstream name they have in mind. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qR0pfC2gVea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009967] Review Request: golang-googlecode-net - Supplementary Go networking libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1009967 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- golang-googlecode-net-0-0.7.hg84a4013f96e0.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.7.hg84a4013f96e0.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q3GjGgslOca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009967] Review Request: golang-googlecode-net - Supplementary Go networking libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1009967 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- golang-googlecode-net-0-0.7.hg84a4013f96e0.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.7.hg84a4013f96e0.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u8V61X005Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 Bug 1010565 depends on bug 1010551, which changed state. Bug 1010551 Summary: needs rebuild work -- broken deps on RAWHIDE https://bugzilla.redhat.com/show_bug.cgi?id=1010551 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B5CISNp8kna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010000] Review Request: devscripts - Scripts for Debian Package maintainers
https://bugzilla.redhat.com/show_bug.cgi?id=101
Dridi Boukelmoune dridi.boukelmo...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|dridi.boukelmo...@gmail.com
Flags||fedora-review?
--- Comment #8 from Dridi Boukelmoune dridi.boukelmo...@gmail.com ---
I've tried a review (with fedora-review) which obviously failed due to bug
100. You could also use the %{name} macro in both the replace and search
pattern in the sed command.
The package looks fine, I'll review it once perl-Parse-DebControl is available.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=SsXk4pPiiVa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010682] New: Review Request: telldus-core - driver and tools for Telldus TellStick
https://bugzilla.redhat.com/show_bug.cgi?id=1010682 Bug ID: 1010682 Summary: Review Request: telldus-core - driver and tools for Telldus TellStick Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ma...@linuxed.net QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Hello, This is a review request for packaging Telldus (www.telldus.se) software: Spec URL: http://www.linuxed.net/~madko/fedora/telldus-core.spec SRPM URL: http://www.linuxed.net/~madko/fedora/telldus-core-2.1.1-1.fc19.src.rpm Description: Telldus Core is the driver and tools for controlling a Telldus Technologies TellStick. It does not containing any GUI tools which makes it suitable for server use. TellStick is a USB stick compatible with RF433Mhz home automation devices. Telldus-core is a free and open-source software under LGPL 2.1 Fedora Account System Username: madko -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1Q8kaYliWpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010000] Review Request: devscripts - Scripts for Debian Package maintainers
https://bugzilla.redhat.com/show_bug.cgi?id=101 --- Comment #9 from Ralf Corsepius rc040...@freenet.de --- (In reply to Dridi Boukelmoune from comment #8) I've tried a review (with fedora-review) which obviously failed due to bug 100. My view: This Conflicts: renders it impossible to install this package. = This package does not comply to one of basic requirements of a package review. In other words: Instead of letting this package Conflict, I'd suggest to change this package shall be changed in such a way it (at least temporarily) uses tools provided by rpmdevtools (AFAICT, they are compatible) and switch the deps later for those Fedora release which switch to a newer rpmdevtools. Another surplus of this step would be, devscripts could also be provided for older Fedora releases, for which switching to rpmdevtools = 8.4 would be an arguable idea. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M5yyizbVDXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010000] Review Request: devscripts - Scripts for Debian Package maintainers
https://bugzilla.redhat.com/show_bug.cgi?id=101 --- Comment #10 from Sandro Mani manisan...@gmail.com --- How does the conflict render the package non-installable? From my test (using a rpmdevtools-8.4 with the conflicting files removed), everything works as expected. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iwBsLSDVW4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #16 from Volker Fröhlich volke...@gmx.at --- It seems like there's something going on with plug-ins. While two of them are installed, the are not visible on the plug-ins tab of Settings. It might be connected to the existence of PGMODELER_PLUGIN_DIR and PGMODELER_PLUGINS_DIR -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NmBxiYYdTga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 982204] Review Request: Elm - The Elm language module
https://bugzilla.redhat.com/show_bug.cgi?id=982204 Ricky Elrod rel...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Summary|Review Request: elm - The |Review Request: Elm - The |Elm language module |Elm language module -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i4JH558s3Xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010702] New: Review Request: ghc-union-find - Efficient union and equivalence testing of sets
https://bugzilla.redhat.com/show_bug.cgi?id=1010702 Bug ID: 1010702 Summary: Review Request: ghc-union-find - Efficient union and equivalence testing of sets Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rel...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://fedorapeople.org/~codeblock/packages/ghc-union-find/ghc-union-find.spec SRPM URL: http://fedorapeople.org/~codeblock/packages/ghc-union-find/ghc-union-find-0.2-1.fc19.src.rpm Description: The Union\/Find algorithm implements these operations in (effectively) constant-time: 1. Check whether two elements are in the same equivalence class. 2. Create a union of two equivalence classes. 3. Look up the descriptor of the equivalence class. Fedora Account System Username: codeblock -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fw1nydc7mza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010702] Review Request: ghc-union-find - Efficient union and equivalence testing of sets
https://bugzilla.redhat.com/show_bug.cgi?id=1010702 Ricky Elrod rel...@redhat.com changed: What|Removed |Added CC||haskell-devel@lists.fedorap ||roject.org Blocks||982204 (Elm) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8EFg6W6PESa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773502] Review Request: perl-Spreadsheet-read - universal API to read any spreadsheet
https://bugzilla.redhat.com/show_bug.cgi?id=773502 Michael Schwendt bugs.mich...@gmx.net changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|bugs.mich...@gmx.net|nob...@fedoraproject.org Flags|fedora-review+ | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TAgJKwI9rRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010000] Review Request: devscripts - Scripts for Debian Package maintainers
https://bugzilla.redhat.com/show_bug.cgi?id=101 --- Comment #11 from Ralf Corsepius rc040...@freenet.de --- (In reply to Sandro Mani from comment #10) How does the conflict render the package non-installable? All versions of Fedora provide rpmdevtools-8.3: ./development/rawhide/source/SRPMS/r/rpmdevtools-8.3-5.fc20.src.rpm ./development/rawhide/x86_64/os/Packages/r/rpmdevtools-8.3-5.fc20.noarch.rpm ./development/rawhide/i386/os/Packages/r/rpmdevtools-8.3-5.fc20.noarch.rpm ./development/20/source/SRPMS/r/rpmdevtools-8.3-5.fc20.src.rpm ./development/20/x86_64/os/Packages/r/rpmdevtools-8.3-5.fc20.noarch.rpm ./development/20/i386/os/Packages/r/rpmdevtools-8.3-5.fc20.noarch.rpm ./releases/18/Everything/source/SRPMS/r/rpmdevtools-8.3-1.fc18.src.rpm ./releases/18/Everything/x86_64/os/Packages/r/rpmdevtools-8.3-1.fc18.noarch.rpm ./releases/18/Everything/i386/os/Packages/r/rpmdevtools-8.3-1.fc18.noarch.rpm ./releases/19/Everything/source/SRPMS/r/rpmdevtools-8.3-3.fc19.src.rpm ./releases/19/Everything/x86_64/os/Packages/r/rpmdevtools-8.3-3.fc19.noarch.rpm ./releases/19/Everything/i386/os/Packages/r/rpmdevtools-8.3-3.fc19.noarch.rpm From my test (using a rpmdevtools-8.4 with the conflicting files removed), everything works as expected. Exactly this is the point: There currently are not rpmdevtools-8.4 packages anywhere in Fedora, ie. your package-as-is cannot be installed on any Fedora. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dYQys2NlRca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986550] Review Request: python-xmp-toolkit - Python toolkit for working with XMP metadata
https://bugzilla.redhat.com/show_bug.cgi?id=986550 Lars Kiesow lkie...@uos.de changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #10 from Lars Kiesow lkie...@uos.de --- Sorry for the late reply. I somehow missed your answer (has been a while since something happened here). New files can be found here: Spec URL: http://larskiesow.de/python-xmp-toolkit/python-xmp-toolkit.spec SRPM URL: http://larskiesow.de/python-xmp-toolkit/python-xmp-toolkit-1.0.2-4.fc18.src.rpm And here are new scratch builds: f18: http://koji.fedoraproject.org/koji/taskinfo?taskID=5968890 f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5968904 f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5968912 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=edgeYn4qNAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116
--- Comment #17 from Volker Fröhlich volke...@gmx.at ---
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #8)
(In reply to Volker Fröhlich from comment #6)
I'm not sure if everything that is below /etc really belongs there. I also
found an icon there, by the way.
Logo, not icon. What you think appropriate path for it? /usr/share/pgmodeler
I suppose? Most other files is *.conf and *.dtd which may be treated as conf
correctly.
You can install the icons in %{_datadir}/pixmaps. Please also update the
desktop file according to preferred form described in
http://fedoraproject.org/wiki/Packaging:Guidelines#Icon_tag_in_Desktop_Files
From the desktop file: Program with nice Qt interface for visual modeling
PostgreSQL database in terms on entity relationship model -- I'm not a native
speaker, but that on doesn't sound right.
I think you are by mistake speak about
%{_sysconfdir}/profile.d/%{name}.bash? It is just used to set environment
variables appropriately as theys used by application for function properly.
Yes, I was wrong there. Do we really need this profile? It's not like these
settings vary on a system-wide scope, as you defined them through packaging.
Are there no hard-coded defaults?
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libQtGui.so.4
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libm.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libm.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libQtGui.so.4
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libm.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libQtGui.so.4
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libpthread.so.0
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libm.so.6
There's some unnecessary linking going on. If these libraries are meant to
be used by other applications than that GUI, that should probably be
resolved.
I don't known other usages.
That said, I wonder if all the libraries should go to /usr/lib64/pgmodeler
instead. Some names are a bit generic and we could drop the devel sub-package
and the associated files too.
The locale script doesn't work because the locales are expected to have some
kind of prefix to
[Bug 978284] Review Request: rubygem-redis - A Ruby client library for Redis
https://bugzilla.redhat.com/show_bug.cgi?id=978284 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cqGb0eVMj3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1001351] Review Request: glite-lbjp-common-db - Database engine abstraction wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=1001351 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- glite-lbjp-common-db-3.2.8-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aZirxdYtnNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010000] Review Request: devscripts - Scripts for Debian Package maintainers
https://bugzilla.redhat.com/show_bug.cgi?id=101 --- Comment #12 from Sandro Mani manisan...@gmail.com --- Ah ok I see what you mean. So basically discussing this in bug #920163, Ville Skyttä suggested I notified him as soon as the review is complete, and that he'll take care of pushing rpmdevtools-8.4. Note that I'm open to other suggestions on how to proceed, but maybe it's worth mentioning those in bug #920163 so that we can hear Ville's opinion also. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l2RX9qzcTYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988938] Review Request: rubygem-orm_adapter - Provides a single point of entry for using basic features of ruby ORMs
https://bugzilla.redhat.com/show_bug.cgi?id=988938 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NFifB9QRoLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010725] New: Review Request: qt5-qttranslations - Qt5 - QtTranslations module
https://bugzilla.redhat.com/show_bug.cgi?id=1010725 Bug ID: 1010725 Summary: Review Request: qt5-qttranslations - Qt5 - QtTranslations module Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qttranslations.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qttranslations-5.1.1-1.fc19.src.rpm Description: Qt5 - QtTranslations module Fedora Account System Username: rdieter Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5969188 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mEtJxW2d3ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010725] Review Request: qt5-qttranslations - Qt5 - QtTranslations module
https://bugzilla.redhat.com/show_bug.cgi?id=1010725 --- Comment #1 from Rex Dieter rdie...@math.unl.edu --- better (noarch) scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5969193 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aBenT6poo8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010725] Review Request: qt5-qttranslations - Qt5 - QtTranslations module
https://bugzilla.redhat.com/show_bug.cgi?id=1010725 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||928937 (qt-reviews) Alias||qt5-qttranslations -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g2w5nNR22Ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010725] Review Request: qt5-qttranslations - Qt5 - QtTranslations module
https://bugzilla.redhat.com/show_bug.cgi?id=1010725 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||1010695 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IBQ5r3QAbma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010727] New: Review Request: qt5-qtdoc - Main Qt5 Reference Documentation
https://bugzilla.redhat.com/show_bug.cgi?id=1010727 Bug ID: 1010727 Summary: Review Request: qt5-qtdoc - Main Qt5 Reference Documentation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdoc.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdoc-5.1.1-1.fc19.src.rpm Description: QtDoc contains the main Qt Reference Documentation, which includes overviews, Qt topics, and examples not specific to any Qt module Fedora Account System Username: rdieter Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5969235 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P5MuQeAFada=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010727] Review Request: qt5-qtdoc - Main Qt5 Reference Documentation
https://bugzilla.redhat.com/show_bug.cgi?id=1010727 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||928937 (qt-reviews) Alias||qt5-qtdoc -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Kwu8dGoEO6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989859] Review Request: libxls - A multiplatform C/C++ library for parsing Excel files
https://bugzilla.redhat.com/show_bug.cgi?id=989859 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Assignee|nob...@fedoraproject.org|volke...@gmx.at Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wU24CC7KAHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 923960] Review Request: JMapViewer - JMapViewer is a java component to integrate an OSM map view into your Java application.
https://bugzilla.redhat.com/show_bug.cgi?id=923960 gil cattaneo punto...@libero.it changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #7 from gil cattaneo punto...@libero.it --- ping -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ac3pMTPdOJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989859] Review Request: libxls - A multiplatform C/C++ library for parsing Excel files
https://bugzilla.redhat.com/show_bug.cgi?id=989859
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #11 from Volker Fröhlich volke...@gmx.at ---
There are a few compiler warnings. Please tell upstream about them!
Shared-lib-calls-exit should be addressed by upstream. Please report if you
haven't already.
Please see below for further tasks!
As soon as you correct the license tag, this package is APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
File doesn't exist, see bottom!
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
BSD (2 clause), Unknown or generated, BSD (4 clause). 1 files have
unknown license. Detailed output of licensecheck in
/media/speicher1/makerpm/989859-libxls/licensecheck.txt
Due to getopt.c, the overall license should be stated as BSD with
advertising.
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
Builds on PPC as well!
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD
[Bug 1010741] New: python-nikola - Static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1010741 Bug ID: 1010741 Summary: python-nikola - Static website and blog generator Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: m...@petetravis.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://immanetize.fedorapeople.org/python-nikola.spec SRPM URL: http://immanetize.fedorapeople.org/python-nikola-6.0.1-1.fc21.src.rpm Description:Nikola is a static site and blog generator using Python. It generates sites with tags, feeds, archives, comments, and more from plain text files. Source can be unformatted, or formatted with reStructuredText or Markdown. It also automatically builds image galleries. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=byF0CugXeya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010741] python-nikola - Static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1010741 Pete Travis m...@petetravis.com changed: What|Removed |Added CC||jama...@fc.up.pt --- Comment #1 from Pete Travis m...@petetravis.com --- *** Bug 882482 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kLLb9gMWYBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 979738] Review Request: crawl-sdl - free roguelike game of exploration and treasure-hunting in dungeons
https://bugzilla.redhat.com/show_bug.cgi?id=979738 --- Comment #10 from Volker Fröhlich volke...@gmx.at --- It applies for the files you ship. You're probably not shipping MS' stdint.h, but I wouldn't bother removing this information from license.txt. As all of the mentioned are compatible to GPLv2 and 3, stating GPLv2+ is technically correct. We had another review where things were broken down for content/code. You could do the same and state GPLv2+ and CC0. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O3rCUUz9kfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nf3d-0.8-1.fc20 Resolution|--- |ERRATA Last Closed||2013-09-22 20:27:46 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nf3d-0.8-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aLBym67A12a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989859] Review Request: libxls - A multiplatform C/C++ library for parsing Excel files
https://bugzilla.redhat.com/show_bug.cgi?id=989859 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||supercyp...@gmail.com --- Comment #12 from Christopher Meng cicku...@gmail.com --- *** Bug 560240 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KK36FSo1dIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989859] Review Request: libxls - A multiplatform C/C++ library for parsing Excel files
https://bugzilla.redhat.com/show_bug.cgi?id=989859 --- Comment #13 from Christopher Meng cicku...@gmail.com --- Thanks Volker. Upstream refuse to add copying file because he thought it's bsd licensed... New Package SCM Request === Package Name: libxls Short Description: A multiplatform C/C++ library for parsing Excel files Owners: cicku Branches: f19 f20 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BrqutkTFrba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989859] Review Request: libxls - A multiplatform C/C++ library for parsing Excel files
https://bugzilla.redhat.com/show_bug.cgi?id=989859 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iwIq3WvhiRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nf3d-0.8-1.fc20 |nf3d-0.8-1.fc19 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nf3d-0.8-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pwJY8u6E7Pa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010741] python-nikola - Static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1010741 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? --- Comment #2 from Christopher Meng cicku...@gmail.com --- URL is http://getnikola.com/ Please update to the latest. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dbDNbFAUfja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010741] python-nikola - Static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1010741 --- Comment #3 from Christopher Meng cicku...@gmail.com --- Also need to be fixed: No python3 support. Leave a blank line between each changelog Not good:/usr/bin/nikola python 2.x stuffs need macro %__python2 and same to sitelib. Wrong:BuildRequires:python-- BuildRequires:python2-devel at least. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BgABPab95wa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009703] Review Request: roboJournal - Keep a journal/diary of day-to-day events in your life
https://bugzilla.redhat.com/show_bug.cgi?id=1009703
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC||cicku...@gmail.com
Summary|Review Request: RoboJournal |Review Request: roboJournal
|- Keep a journal/diary of |- Keep a journal/diary of
|day-to-day events in your |day-to-day events in your
|life|life
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
Just a note, don't put subpackage information at the bottom.
##
# RoboJournal Documentation Package SPEC (9/2/13)
%package doc
BuildArch: noarch
Summary: Documentation files for RoboJournal
Requires: qt-assistant, robojournal
%description doc
Documentation (compiled help file and collection file) for RoboJournal
%{version}.
%files doc
%{_defaultdocdir}/robojournal/robojournal.qhc
%{_defaultdocdir}/robojournal/robojournal.qch
Put them under %description of main package.
Also qmake-qt4 can be replaced by macro %qmake_qt4
${RPM_BUILD_ROOT} is weird, please use $RPM_BUILD_ROOT or %{buildroot}
%setup -q -n %{name}-%{version} can just be %setup -q
MUST NOT USE %{?_isa} IN BuildRequires!
See:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRequires_and_.25.7B_isa.7D
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=uOxFWicmRza=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
1. BuildRequires: python-setuptools-devel
--
BuildRequires: python-setuptools
AND
BuildRequires: python-devel
--
BuildRequires: python2-devel
2. rm -rf $RPM_BUILD_ROOT is not needed in modern system.
3. Good to see using %{__python2}, but you forgot it in %install
4. %{python_sitearch} -- %{python2_sitearch}
5. You forgot to use nose or tox to test as RPM %check.
https://github.com/racker/falcon/blob/master/README.md#test
6. No python3 support? Why?
7. You can add features listed on pypi as RPM %description:
Features
- Intuitive routing via URI templates and resource classes
- Easy access to headers and bodies through request and response classes
- Idiomatic HTTP error responses via a handy exception base class
- DRY request processing using global, resource, and method hooks
- Snappy unit testing through WSGI helpers and mocks
- 20% speed boost when Cython is available
- Python 2.6, Python 2.7, PyPy and Python 3.3 support
- Speed, speed, and more speed!
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=n36I0JyAnca=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
