[Bug 979793] Review Request: php-symfony2-Debug - Symfony2 Debug Component
https://bugzilla.redhat.com/show_bug.cgi?id=979793 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|fed...@famillecollet.com --- Comment #1 from Remi Collet fed...@famillecollet.com --- Created attachment 814160 -- https://bugzilla.redhat.com/attachment.cgi?id=814160action=edit phpci.log phpcompatinfo version 2.24.0. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 979793] Review Request: php-symfony2-Debug - Symfony2 Debug Component
https://bugzilla.redhat.com/show_bug.cgi?id=979793
Remi Collet fed...@famillecollet.com changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #3 from Remi Collet fed...@famillecollet.com ---
Koji scratch build
http://koji.fedoraproject.org/koji/taskinfo?taskID=6080475
Issues:
===
[!]: Sources used to build the package match the upstream source, as provided
in
the spec URL.
Note: Upstream MD5sum check error, diff is in
/home/extras/SPECS/review/979793-php-symfony2-Debug/diff.txt
See: http://fedoraproject.org/wiki/Packaging/SourceURL
= minor diff in the package.xml which have
obviously be regenerated, not an issue for the review
[~]: Package is named according to the Package Naming Guidelines.
New Guildelines recommend the use of lowercase names.
As all the symfony2 stack use CamelCase, I thinks
this could be ignored.
[!]: Package consistently uses macros (instead of hard-coded directory names).
= only a small comment
symfony_{min,max}_ver could be ambiguous, as according to various
composer.json, you have not a single minimal version, some
could require 2.0, 2.1, 2.2 or 2.3. So a per component version
seems clearer.
[~]: Package is named according to the Package Naming Guidelines.
New Guildelines recommend the use of lowercase names.
As all the symfony2 stack use CamelCase, I thinks
this could be ignored.
[!]: Requires correct, justified where necessary.
php-common = php(language)
[!]: Latest version is packaged.
2.3.6 available
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 979793] Review Request: php-symfony2-Debug - Symfony2 Debug Component
https://bugzilla.redhat.com/show_bug.cgi?id=979793 --- Comment #2 from Remi Collet fed...@famillecollet.com --- Created attachment 814161 -- https://bugzilla.redhat.com/attachment.cgi?id=814161action=edit review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 979793 Buildroot used: fedora-19-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018523] Review Request: golang-github-coreos-go-log - A golang library for logging to systemd
https://bugzilla.redhat.com/show_bug.cgi?id=1018523 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- golang-github-coreos-go-log-0-0.5.git840af6b.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-github-coreos-go-log-0-0.5.git840af6b.fc19 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018523] Review Request: golang-github-coreos-go-log - A golang library for logging to systemd
https://bugzilla.redhat.com/show_bug.cgi?id=1018523 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- golang-github-coreos-go-log-0-0.5.git840af6b.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-coreos-go-log-0-0.5.git840af6b.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018523] Review Request: golang-github-coreos-go-log - A golang library for logging to systemd
https://bugzilla.redhat.com/show_bug.cgi?id=1018523 Lokesh Mandvekar l...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-10-20 02:09:42 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1007225] Review Request: php-phpunit-diff - Diff implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1007225 Remi Collet fed...@famillecollet.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Summary|Review Request: |Review Request: |php-phpunit-Diff - Diff |php-phpunit-diff - Diff |implementation |implementation --- Comment #1 from Remi Collet fed...@famillecollet.com --- Renamed to lowercase Spec: https://raw.github.com/remicollet/remirepo/1ade5beee2609223881f6d5153f78a9c7f365623/php/phpunit/php-phpunit-diff/php-phpunit-diff.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-phpunit-diff-1.1.0-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1007234] Review Request: php-phpunit-exporter - Export PHP variables for visualization
https://bugzilla.redhat.com/show_bug.cgi?id=1007234 Remi Collet fed...@famillecollet.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Summary|Review Request: |Review Request: |php-phpunit-Exporter - |php-phpunit-exporter - |Export PHP variables for|Export PHP variables for |visualization |visualization --- Comment #1 from Remi Collet fed...@famillecollet.com --- Renamed to lowercase Spec: https://raw.github.com/remicollet/remirepo/b9b6cc1b86dfa7468578554daa742551d8bc83e9/php/phpunit/php-phpunit-exporter/php-phpunit-exporter.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-phpunit-exporter-1.0.0-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 734248] Review Request: apf - Adventure PHP Framework
https://bugzilla.redhat.com/show_bug.cgi?id=734248 Reiner Rottmann rei...@rottmann.it changed: What|Removed |Added Flags|needinfo?(reiner@rottmann.i | |t) | --- Comment #13 from Reiner Rottmann rei...@rottmann.it --- Thank you! I am still interested in packaging the APF. Of course I will recreate the RPM with the current version. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021160] Review Request: doge - wow very terminal doge
https://bugzilla.redhat.com/show_bug.cgi?id=1021160
--- Comment #3 from Ian Weller i...@ianweller.org ---
(In reply to Christopher Meng from comment #1)
1. This package should be named in python-doge and also a parallel
installable python3 subpackage named python3-doge.
This isn't a Python library; it's a program that happens to be a Python module.
It doesn't make sense to have a subpackage that runs on Python 3. (What would
we call the separate Python 3 binary? There are no packaging policies for
this.)
Examples of packages that provide Python modules but are not called
python-$module, because they are standalone programs and not libraries:
- anaconda
- yum
- ansible
- gnome-tweak-tool
2. I can't understand wow very terminal doge, can you change it to
something better?
As Ryan mentioned, this is the upstream summary description, and is directly
relevant to the package contents.
3. BuildRequires: python2-devel
missing
BuildRequires: python-setuptools
setup.py doesn't use setuptools, so this BuildRequires isn't needed at all.
For further evidence, see this Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6080518
4. Remove rm -rf %{buildroot}
5. %{__python} -- %{__python2}
%{python_sitelib} -- %{python2_sitelib}
4 and 5 fixed in 0.6.1-2:
Spec URL: http://ianweller.fedorapeople.org/SRPMS/doge/0.6.1-2/doge.spec
SRPM URL:
http://ianweller.fedorapeople.org/SRPMS/doge/0.6.1-2/doge-0.6.1-2.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972431] Review Request: airtsp - C++ Simulated Airline Travel Solution Provider Library
https://bugzilla.redhat.com/show_bug.cgi?id=972431 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Flags|needinfo?(bjoern.esser@gmai | |l.com) | --- Comment #12 from Björn besser82 Esser bjoern.es...@gmail.com --- (In reply to Christopher Meng from comment #10) You should check this unfinished one. You dont't say. :D I'm on it, but since this is a RENAME-request it doesn't hurry that much, because it's already available in the repos. (In reply to Christopher Meng from comment #11) Denis, do you want to support EL5? Since the package, to be renamed, is build for el5, too, the RENAME-request should cover el5 as well. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020457] Review Request: rubygem-vagrant-kvm - KVM plugin for Vagrant
https://bugzilla.redhat.com/show_bug.cgi?id=1020457 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Depends On||1020456 (vagrant) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1020456 [Bug 1020456] Review Request: vagrant - an automation tool used to manage development environments -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020456] Review Request: vagrant - an automation tool used to manage development environments
https://bugzilla.redhat.com/show_bug.cgi?id=1020456 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Blocks||1020457 Assignee|nob...@fedoraproject.org|saga...@gmail.com Alias||vagrant Flags||fedora-review? --- Comment #4 from Björn besser82 Esser bjoern.es...@gmail.com --- (In reply to Arun S A G from comment #2) I will do the review. Please assign and set the review(?)-flag, if you take the bug for review, so it will vanish from the new reviews-tracker. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1020457 [Bug 1020457] Review Request: rubygem-vagrant-kvm - KVM plugin for Vagrant -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020457] Review Request: rubygem-vagrant-kvm - KVM plugin for Vagrant
https://bugzilla.redhat.com/show_bug.cgi?id=1020457 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Assignee|nob...@fedoraproject.org|saga...@gmail.com Alias||rubygem-vagrant-kvm Flags||fedora-review? --- Comment #3 from Björn besser82 Esser bjoern.es...@gmail.com --- (In reply to Arun S A G from comment #2) I will do the review. Please assign and set the review(?)-flag, if you take the bug for review, so it will vanish from the new reviews-tracker. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854729] Review Request: bat-extratools-java - A collection of extra java tools for the BAT
https://bugzilla.redhat.com/show_bug.cgi?id=854729 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Blocks||854723 (bat) Depends On|854723 (bat)| Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=854723 [Bug 854723] Review Request: bat - Binary Analysis Tool -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854728] Review Request: bat-extratools - A collection of extra tools for the BAT
https://bugzilla.redhat.com/show_bug.cgi?id=854728 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Blocks||854723 (bat) Depends On|854723 (bat)| Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=854723 [Bug 854723] Review Request: bat - Binary Analysis Tool -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854729] Review Request: bat-extratools-java - A collection of extra java tools for the BAT
https://bugzilla.redhat.com/show_bug.cgi?id=854729 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com Flags||fedora-review? --- Comment #5 from Björn besser82 Esser bjoern.es...@gmail.com --- taken ;) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819480] Review Request: limesurvey - a web-based survey application
https://bugzilla.redhat.com/show_bug.cgi?id=819480 --- Comment #27 from Dridi Boukelmoune dridi.boukelmo...@gmail.com --- How can I help move this review forward ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892335] Review Request: AudioCuesheetEditor
https://bugzilla.redhat.com/show_bug.cgi?id=892335 --- Comment #30 from Sven Baus s.bau...@gmx.net --- Thanks for tagging this bug. How do I get sponsored? Still couldn't find someone?! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892335] Review Request: AudioCuesheetEditor
https://bugzilla.redhat.com/show_bug.cgi?id=892335 --- Comment #31 from Christopher Meng cicku...@gmail.com --- (In reply to Sven Baus from comment #30) Thanks for tagging this bug. How do I get sponsored? Still couldn't find someone?! https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892335] Review Request: AudioCuesheetEditor
https://bugzilla.redhat.com/show_bug.cgi?id=892335 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com Flags||fedora-review? --- Comment #32 from Björn besser82 Esser bjoern.es...@gmail.com --- I'll take this. ;) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892335] Review Request: AudioCuesheetEditor
https://bugzilla.redhat.com/show_bug.cgi?id=892335 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added CC||s.bau...@gmx.net Flags||needinfo?(s.bau...@gmx.net) --- Comment #33 from Björn besser82 Esser bjoern.es...@gmail.com --- INFO: Downloading .spec and .srpm files error: line 1: Unknown tag: !DOCTYPE html ERROR: Can't parse specfile: can't parse specfile\n (logs in /home/besser82/.cache/fedora-review.log) --- Please upload your recent spec and srpm to some place you can directly link from. To save you some difficulties, I just gave you permissions to access some webspace (~ 2GB) on `fedorapeople.org`. You just need to upload a RSA-key on the FAS [1] and start uploading your files using e.g. scp or filezilla (in SFTP-mode). In order to make your uploads available for public access, you'll need to create a `public_html`-dir inside your home on fp.org and put the files there. When your done with that please provide the links inside a new comment inside this bug. [1] https://admin.fedoraproject.org/accounts/ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892335] Review Request: AudioCuesheetEditor - Audio Cuesheet Editor
https://bugzilla.redhat.com/show_bug.cgi?id=892335 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Summary|Review Request: |Review Request: |AudioCuesheetEditor |AudioCuesheetEditor - Audio ||Cuesheet Editor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892335] Review Request: AudioCuesheetEditor - Audio Cuesheet Editor
https://bugzilla.redhat.com/show_bug.cgi?id=892335
--- Comment #34 from Christopher Meng cicku...@gmail.com ---
My point:
1. From your desktop entry I can see icon is located at:
Icon=/usr/lib/%{name}/resources/icons/application-x-cue-128.png
In common we put icons under /usr/share/pixmaps.
I also think that all data files should be installed to %{_datadir}/%{name} but
not /usr/lib/%{name}
2. Mix using %{buildroot} and ${RPM_BUILD_ROOT}, you should only use one of
them.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021199] New: Review Request: aspell-fi - Finnish dictionaries for Aspell
https://bugzilla.redhat.com/show_bug.cgi?id=1021199 Bug ID: 1021199 Summary: Review Request: aspell-fi - Finnish dictionaries for Aspell Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: k...@kupo.se QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://kupo.se/pub/review/aspell/aspell-fi.spec SRPM URL: http://kupo.se/pub/review/aspell/aspell-fi-0.7-1.fc19.src.rpm Description: Provides the word list/dictionaries for the following: Finnish Fedora Account System Username: opuk Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6080641 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell
https://bugzilla.redhat.com/show_bug.cgi?id=1021199 Johan Swensson k...@kupo.se changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853553] Review Request: guayadeque - Audio player and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=853553 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added CC||anto.tra...@gmail.com --- Comment #56 from Antonio Trande anto.tra...@gmail.com --- (In reply to MartinKG from comment #55) Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/guayadeque.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/guayadeque-0.3.6-14.svn1885. fc19.src.rpm These links are not reachable for me. Please, check them. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018492] Review Request: vcsh - Version Control System for $HOME
https://bugzilla.redhat.com/show_bug.cgi?id=1018492
Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #9 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com ---
Review:
[+] OK
[-] NA
[?] Issue
** Mandatory review guidelines: **
[+] rpmlint output:
[asinha@ankur-laptop SRPMS]$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
vcsh.noarch: W: spelling-error %description -l en_US config - con fig,
con-fig, configure
vcsh.noarch: W: spelling-error %description -l en_US configs - con figs,
con-figs, configure
vcsh.src: W: spelling-error %description -l en_US config - con fig, con-fig,
configure
vcsh.src: W: spelling-error %description -l en_US zsh - sh, ssh, ash
vcsh.src: W: spelling-error %description -l en_US configs - con figs,
con-figs, configure
vcsh.src:52: W: macro-in-%changelog %{buildroot}
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
[asinha@ankur-laptop SRPMS]$
[+] License is acceptable
[+] License field in spec is correct
[+] License files included in package %docs if included in source package
[+] License files installed when any subpackage combination is installed
[+] Spec written in American English
[+] Spec is legible
[+] Sources match upstream unless altered to fix permissibility issues
[asinha@ankur-laptop SRPMS]$ review-md5check.sh ../SPECS/vcsh.spec
Getting https://github.com/RichiH/vcsh/archive/v1.20130909.tar.gz to
/tmp/review/v1.20130909.tar.gz
% Total% Received % Xferd Average Speed TimeTime Time Current
Dload Upload Total SpentLeft Speed
100 124 100 1240 0 56 0 0:00:02 0:00:02 --:--:--56
100 23850 100 238500 0 6317 0 0:00:03 0:00:03 --:--:-- 30228
6007dba2d65db1a8fe32d22d28094fd5 /tmp/review/v1.20130909.tar.gz
6007dba2d65db1a8fe32d22d28094fd5
/home/asinha/rpmbuild/SOURCES/v1.20130909.tar.gz
removed ‘/tmp/review/v1.20130909.tar.gz’
removed directory: ‘/tmp/review’
[asinha@ankur-laptop SRPMS]$
[+] Build succeeds on at least one primary arch
[+] Build succeeds on all primary arches or has ExcludeArch + bugs filed
[+] BuildRequires correct, justified where necessary
[-] Locales handled with %find_lang, not %_datadir/locale/*
[-] %post, %postun call ldconfig if package contains shared .so files
[+] No bundled libs
[-] Relocatability is justified
[+] Package owns all directories it creates
[+] Package requires others for directories it uses but does not own
Note that the package owns the /usr/share/zsh directory which is owned by other
packages also. However, since this is for optional functionality, this is OK:
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function
[asinha@ankur-laptop SRPMS]$ sudo repoquery -l zsh | egrep '^/usr/share/zsh$'
/usr/share/zsh
[asinha@ankur-laptop SRPMS]$ rpmls
/var/lib/mock/fedora-rawhide-x86_64/result/vcsh-1.20130909-2.fc21.noarch.rpm
-rwxr-xr-x /usr/bin/vcsh
drwxr-xr-x /usr/share/doc/vcsh
-rw-r--r-- /usr/share/doc/vcsh/CONTRIBUTORS
-rw-r--r-- /usr/share/doc/vcsh/LICENSE
-rw-r--r-- /usr/share/doc/vcsh/README.md
-rw-r--r-- /usr/share/doc/vcsh/changelog
-rw-r--r-- /usr/share/doc/vcsh/hooks
-rw-r--r-- /usr/share/man/man1/vcsh.1.gz
drwxr-xr-x /usr/share/zsh
drwxr-xr-x /usr/share/zsh/site-functions
-rw-r--r-- /usr/share/zsh/site-functions/_vcsh
[asinha@ankur-laptop SRPMS]$
[+] No duplication in %files unless necessary for license files
[+] File permissions are sane
[+] Package contains permissible code or content
[-] Large docs go in -doc subpackage
[+] %doc files not required at runtime
[-] Static libs go in -static package/virtual Provides
[-] Development files go in -devel package
[-] -devel packages Require base with fully-versioned dependency, %_isa
[-] No .la files
[-] GUI app uses .desktop file, installs it with desktop-file-install
[+] File list does not conflict with other packages' without justification
[+] File names are valid UTF-8
** Optional review guidelines: **
[-] Query upstream about including license files
[-] Translations of description, summary
[+] Builds in mock
[+] Builds on all arches
[+] Functions as described (e.g. no crashes)
[-] Scriptlets are sane
[-] Subpackages require base with fully-versioned dependency if sensible
[-] .pc file subpackage placement is sensible
[+] No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin
[+] Include man pages if available
Naming guidelines:
[+] Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+
[+] Package names are sane
[+] No naming conflicts
[+] Spec file name matches base package name
[+] Version is sane
[+] Version does not contain ~
[+] Release is sane
[+] %dist tag
[-]
[Bug 875856] Review Request: ip-info - read/flash IP address info on a system with no monitor
https://bugzilla.redhat.com/show_bug.cgi?id=875856 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added CC||anto.tra...@gmail.com --- Comment #6 from Antonio Trande anto.tra...@gmail.com --- (In reply to Chris Tyler from comment #5) Updated package. Spec URL: http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info. spec SRPM URL: http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info-0. 2-1.fc18.src.rpm Hi Chris. Source0 link is uncomplete, its extension (tar.gz) is missing. Please, remove %defattr(-,root,root,-). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell
https://bugzilla.redhat.com/show_bug.cgi?id=1021199 --- Comment #1 from Johan Swensson k...@kupo.se --- Spec URL: http://kupo.se/pub/review/aspell/aspell-fi.spec SRPM URL: http://kupo.se/pub/review/aspell/aspell-fi-0.7-2.fc19.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6080809 %changelog * Sun Oct 20 2013 Johan Swensson k...@kupo.se - 0.7-2 - Remove irrelevant README file -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972431] Review Request: airtsp - C++ Simulated Airline Travel Solution Provider Library
https://bugzilla.redhat.com/show_bug.cgi?id=972431 --- Comment #13 from Denis Arnaud denis.arnaud_fed...@m4x.org --- (In reply to Christopher Meng from comment #11) Denis, do you want to support EL5? Yes, I do -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021164] Review Request: gpp - Customizable language-agnostic preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1021164 --- Comment #2 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- (In reply to Christopher Meng from comment #1) Do we really need this ancient tool? ;) I asked myself the same question. But the package is tiny, trivial to package, and Debian has it. I tried to reimplement the necessary functionality in perl, but it's not as trivial as packaging gpp. I guess that if users don't pop up, the package can be retired in the next release or something like that. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853553] Review Request: guayadeque - Audio player and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=853553 --- Comment #57 from MartinKG mgans...@alice.de --- (In reply to Antonio Trande from comment #56) (In reply to MartinKG from comment #55) Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/guayadeque.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/guayadeque-0.3.6-14.svn1885. fc19.src.rpm These links are not reachable for me. Please, check them. permission problem solved, links now available. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019824] Review Request: python-dopy - Python client for the Digital Ocean API
https://bugzilla.redhat.com/show_bug.cgi?id=1019824 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-dopy-0.2.2-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-dopy-0.2.2-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019824] Review Request: python-dopy - Python client for the Digital Ocean API
https://bugzilla.redhat.com/show_bug.cgi?id=1019824 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-dopy-0.2.2-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-dopy-0.2.2-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019824] Review Request: python-dopy - Python client for the Digital Ocean API
https://bugzilla.redhat.com/show_bug.cgi?id=1019824 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019824] Review Request: python-dopy - Python client for the Digital Ocean API
https://bugzilla.redhat.com/show_bug.cgi?id=1019824 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-dopy-0.2.2-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-dopy-0.2.2-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019824] Review Request: python-dopy - Python client for the Digital Ocean API
https://bugzilla.redhat.com/show_bug.cgi?id=1019824 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-dopy-0.2.2-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-dopy-0.2.2-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996311] Review Request: perl-CAD-Format-STL - Read and Write STL (STereo Lithography) format files
https://bugzilla.redhat.com/show_bug.cgi?id=996311 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- perl-CAD-Format-STL-0.2.1-5.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018540] Review Request: golang-github-goraft-raft - A Go implementation of the Raft distributed consensus protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1018540 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- golang-github-goraft-raft-0-0.3.gite138889.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018523] Review Request: golang-github-coreos-go-log - A golang library for logging to systemd
https://bugzilla.redhat.com/show_bug.cgi?id=1018523 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- golang-github-coreos-go-log-0-0.5.git840af6b.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014336] Review Request: python-halite - Web GUI for SaltStack
https://bugzilla.redhat.com/show_bug.cgi?id=1014336 --- Comment #16 from Mario Blättermann mario.blaetterm...@gmail.com --- @Erik, what about a SCM request? http://fedoraproject.org/wiki/Package_SCM_admin_requests#New_Packages -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853553] Review Request: guayadeque - Audio player and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=853553 --- Comment #58 from Antonio Trande anto.tra...@gmail.com --- There is a problem during the fedora 19+ package building related to svn: -- Found Subversion: /usr/bin/svn (found version 1.8.3) CMake Error at /usr/share/cmake/Modules/FindSubversion.cmake:83 (message): Command /usr/bin/svn info /builddir/build/BUILD/guayadeque-svn1885 failed with output: svn: E155036: Please see the 'svn upgrade' command svn: E155036: The working copy at '/builddir/build/BUILD/guayadeque-svn1885' is too old (format 29) to work with client version '1.8.3 (r1516576)' (expects format 31). You need to upgrade the working copy first. You need to upgrade the working copy with a 'svn upgrade' command in the %prep section if you build the package in fedora = 20, otherwise building fails. I don't know if this issue can be fixed only inside the RPM building or can be done even outside. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020961] Review Request: jq - Command-line JSON processor
https://bugzilla.redhat.com/show_bug.cgi?id=1020961 Pádraig Brady p...@draigbrady.com changed: What|Removed |Added CC||p...@draigbrady.com Flags||fedora-review- --- Comment #4 from Pádraig Brady p...@draigbrady.com --- Please use fedora-review flags for feedback This still needs a bit of work. It should have a basic man page. There is a jq.1.default one can use if not building. Building the manpage should be doable though. At a guess you just need to buildRequires rubygem-ronn and rake, and remove these seeminly redundundant deps from the source with a patch: -require 'bonsai' -require 'liquid' -require 'maruku' -require 'json' Also we should make check. Also we don't seem to need python to build. Also we do we really need flex-devel and bison-devel, as opposed to just flex and bison. I did a quick spec (attached) build with the above for f20, but it hit: jq_test.c: In function 'run_jq_tests': jq_test.c:42:10: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result [-Wunused-result] fgets(buf, sizeof(buf), testdata); ^ So that would require patching the source, or removing -Wall from the build args or something. I've left it there for now. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020961] Review Request: jq - Command-line JSON processor
https://bugzilla.redhat.com/show_bug.cgi?id=1020961 --- Comment #5 from Pádraig Brady p...@draigbrady.com --- Created attachment 814260 -- https://bugzilla.redhat.com/attachment.cgi?id=814260action=edit imcomplete spec for reference -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014336] Review Request: python-halite - Web GUI for SaltStack
https://bugzilla.redhat.com/show_bug.cgi?id=1014336 Erik Johnson e...@saltstack.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #17 from Erik Johnson e...@saltstack.com --- @Mario: yeah, sorry, I've had a busy last couple weeks and had meant to get to this sometime this upcoming week. New Package SCM Request === Package Name: python-halite Short Description: Web UI for SaltStack Owners: terminalmage Branches: f18 f19 f20 el5 el6 InitialCC: terminalmage -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021244] New: Review Request: aspell-la - Latin dictionaries for Aspell
https://bugzilla.redhat.com/show_bug.cgi?id=1021244 Bug ID: 1021244 Summary: Review Request: aspell-la - Latin dictionaries for Aspell Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: k...@kupo.se QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://kupo.se/pub/review/aspell/aspell-la.spec SRPM URL: http://kupo.se/pub/review/aspell/aspell-la-20020503-1.fc19.src.rpm Description: Provides the word list/dictionaries for the following: Latin Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6081348 Fedora Account System Username: opuk -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972480] Review Request: SkyX - Photorealistic sky simulator
https://bugzilla.redhat.com/show_bug.cgi?id=972480 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from Rich Mattes richmat...@gmail.com --- Thanks for the review! New Package SCM Request === Package Name: SkyX Short Description: Photo-realistic sky simulator Owners: rmattes Branches: f18 f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021244] Review Request: aspell-la - Latin dictionaries for Aspell
https://bugzilla.redhat.com/show_bug.cgi?id=1021244 Johan Swensson k...@kupo.se changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1002705] Review Request: felix-scr-generator - Descriptor Generator Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1002705 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- felix-scr-generator-1.8.2-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004556] Review Request: xmpcore - Java XMP Library
https://bugzilla.redhat.com/show_bug.cgi?id=1004556 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- xmpcore-5.1.2-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1002703] Review Request: juniversalchardet - A Java port of Mozilla's universalchardet
https://bugzilla.redhat.com/show_bug.cgi?id=1002703 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- juniversalchardet-1.0.3-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1002704] Review Request: boilerpipe - Boilerplate Removal and Fulltext Extraction from HTML pages
https://bugzilla.redhat.com/show_bug.cgi?id=1002704 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- boilerpipe-1.2.0-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- springframework-ws-2.1.1-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system
https://bugzilla.redhat.com/show_bug.cgi?id=1020839
Terje Røsten terje...@phys.ntnu.no changed:
What|Removed |Added
CC||terje...@phys.ntnu.no
--- Comment #10 from Terje Røsten terje...@phys.ntnu.no ---
Some comments:
- spec file mixes $RPM_BUILD_ROOT and %{buildroot}, pick one form only.
- %clean section is not needed:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean
- %defattr is not needed:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions
Add leading space when using \ :
desktop-file-install \
--dir=%{buildroot}%{_datadir}/applications \
%{buildroot}/%{_datadir}/applications/fedora-gooey-karma.desktop
- Most of empty lines seems unneeded.
- Summary is cryptic, please improve.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019436] Review Request: hawaii-widget-styles - Styles for applications using QtQuick Controls
https://bugzilla.redhat.com/show_bug.cgi?id=1019436
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6081307
$ rpmlint -i -v *hawaii-widget-styles.src: I: checking
hawaii-widget-styles.src: I: checking-url
https://github.com/hawaii-desktop/widget-styles (timeout 10 seconds)
hawaii-widget-styles.src: W: invalid-url Source0:
widget-styles-0.1.90.20130618.2b91741.tar.bz2
The value should be a valid, public HTTP, HTTPS, or FTP URL.
hawaii-widget-styles.armv7hl: I: checking
hawaii-widget-styles.armv7hl: I: checking-url
https://github.com/hawaii-desktop/widget-styles (timeout 10 seconds)
hawaii-widget-styles.armv7hl: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.
hawaii-widget-styles.armv7hl: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
hawaii-widget-styles.i686: I: checking
hawaii-widget-styles.i686: I: checking-url
https://github.com/hawaii-desktop/widget-styles (timeout 10 seconds)
hawaii-widget-styles.i686: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.
hawaii-widget-styles.i686: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
hawaii-widget-styles.x86_64: I: checking
hawaii-widget-styles.x86_64: I: checking-url
https://github.com/hawaii-desktop/widget-styles (timeout 10 seconds)
hawaii-widget-styles.x86_64: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.
hawaii-widget-styles.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
hawaii-widget-styles.spec: W: invalid-url Source0:
widget-styles-0.1.90.20130618.2b91741.tar.bz2
The value should be a valid, public HTTP, HTTPS, or FTP URL.
4 packages and 1 specfiles checked; 3 errors, 5 warnings.
Ok, due to the installation in /usr/lib(64), we get the appropriate messages
from rpmlint. We can ignore this.
Besides the false positive warning about the source URL, we have no
recognizable issues.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
LGPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[.] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
b550b590bf9718fbf4b043ef3a3b468c9ec314ff6907a1af6685cfa0d077b6cc
widget-styles-0.1.90.20130618.2b91741.tar.bz2
b0b569de1ffe248a012f72998e5140b6ff710da19a6d9b317a072cd72fb80560
widget-styles.tar.gz.orig
The checksums differ, but this is a common problem with VCS checkouts.
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging
[Bug 989791] Review Request: doublecmd-qt4 - Twin-panel (commander-style) file manager(Qt4)
https://bugzilla.redhat.com/show_bug.cgi?id=989791 --- Comment #6 from Mario Blättermann mario.blaetterm...@gmail.com --- Is there any decision made how to proceed with doublecmd? In any case, you should close one ticket of doublecmd-qt and doublecmd-gtk. It would be odd to generate to srpms for the two packages. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970407] Review Request: mingw-libtheora - Theora Video Compression Codec
https://bugzilla.redhat.com/show_bug.cgi?id=970407 Johan Swensson k...@kupo.se changed: What|Removed |Added CC||k...@kupo.se --- Comment #2 from Johan Swensson k...@kupo.se --- Build fails on rawhide. You have some files you're not taking care of properly. RPM build errors: Installed (but unpackaged) file(s) found: /usr/i686-w64-mingw32/sys-root/mingw/bin/libtheoraenc-1.dll /usr/i686-w64-mingw32/sys-root/mingw/lib/libtheoraenc.dll.a /usr/x86_64-w64-mingw32/sys-root/mingw/bin/libtheoraenc-1.dll /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libtheoraenc.dll.a -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018492] Review Request: vcsh - Version Control System for $HOME
https://bugzilla.redhat.com/show_bug.cgi?id=1018492
--- Comment #10 from Dridi Boukelmoune dridi.boukelmo...@gmail.com ---
(In reply to Ankur Sinha (FranciscoD) from comment #9)
Nitpicks:
- Please comment the patch, and send it upstream too.
I will, I have another ongoing issue (RFE) with uptream, I will send a pull
request before commiting to the SCM (and add a comment).
- Since you're installing to pkgdocdir, and the %doc macro already takes
ownership of it, you don't need to specify it again. From
http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_prefixes:
Usually, %doc is used to list documentation files within %{_builddir}
that were not copied to %{buildroot}. A README and INSTALL file is usually
included. They will be placed in an appropriate directory under
/usr/share/doc, whose ownership does not need to be declared.
Some files are installed with the %doc macro (LICENSE CONTRIBUTORS changelog)
and the others with `make install'. There shouldn't be any dupe in the %files
section.
Not blockers though. You can fix them up before you commit to SCM.
+++ APPROVED +++
Thanks,
Warm regards,
Ankur
Thank you for the review,
Dridi
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1001746] Review Request: python-theano - Mathematical expressions involving multidimensional arrays
https://bugzilla.redhat.com/show_bug.cgi?id=1001746 --- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com --- Any progress here? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1013807] Review Request: python-sendgrid - SendGrid library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1013807 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #8 from Mario Blättermann mario.blaetterm...@gmail.com --- All packages have been built and are at least in the testing repo. I change the status to ON_QA. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020309] Review Request: kde-connect - KDE Connect client for communication with smartphones
https://bugzilla.redhat.com/show_bug.cgi?id=1020309 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com --- Scratch build fails for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6081716 From build.log: CMake Error at kded/plugins/ping/CMakeLists.txt:2 (find_package): By not providing FindQJSON.cmake in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by QJSON, but CMake did not find one. Could not find a package configuration file provided by QJSON with any of the following names: QJSONConfig.cmake qjson-config.cmake Add the installation prefix of QJSON to CMAKE_PREFIX_PATH or set QJSON_DIR to a directory containing one of the above files. If QJSON provides a separate development package or SDK, be sure it has been installed. -- Configuring incomplete, errors occurred! See also /builddir/build/BUILD/kdeconnect-kde-0.3/x86_64-redhat-linux-gnu/CMakeFiles/CMakeOutput.log. See also /builddir/build/BUILD/kdeconnect-kde-0.3/x86_64-redhat-linux-gnu/CMakeFiles/CMakeError.log. RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.Px6LmD (%build) Bad exit status from /var/tmp/rpm-tmp.Px6LmD (%build) This confirms what Volker wrote. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] New: Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 Bug ID: 1021261 Summary: Review Request: kipi-plugins-elegant-theme - elegant theme for html export Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@dyroff.org QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://git.dyroff.org/?p=sdyroff-rpms.git;a=blob_plain;f=SPECS/kipi-plugins-elegant-theme.spec;h=f827196685901b1279a87d179c94915823922144;hb=HEAD SRPM URL: http://kojipkgs.fedoraproject.org//work/tasks/1769/6081769/kipi-plugins-elegant-theme-1.4.0-1.fc21.src.rpm Description: This is a theme for Digikam's Kipi HTML export function. Fedora Account System Username: sdyroff -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #1 from Sebastian Dyroff fed...@dyroff.org --- koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6081769 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020014] Review Request: pylcdsysinfo - Python interface to Coldtears Electronics LCD Sys Info device
https://bugzilla.redhat.com/show_bug.cgi?id=1020014
Till Maas opensou...@till.name changed:
What|Removed |Added
CC||opensou...@till.name
--- Comment #4 from Till Maas opensou...@till.name ---
It seems to me that the version is made up, because upstream does not provide
one. Please use 0 then instead of 0.0.1 - 0 is afaik the lowest possible
version.
Also the release should be formed like 0.%{X}.%{alphatag}, because it is a
pre-release (see the kismet example):
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1016200] Review Request: (unorphan) global - Source code tag system
https://bugzilla.redhat.com/show_bug.cgi?id=1016200 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- global-6.2.9-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/global-6.2.9-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1016200] Review Request: (unorphan) global - Source code tag system
https://bugzilla.redhat.com/show_bug.cgi?id=1016200 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1016200] Review Request: (unorphan) global - Source code tag system
https://bugzilla.redhat.com/show_bug.cgi?id=1016200 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- global-6.2.9-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/global-6.2.9-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 --- Comment #2 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- Looks like a fork based on upstream 1.3.2 version. However, there have been no new releases from original upstream, so we might just as well consider the fork as the new upstream: https://github.com/scarabeusiv/ucpp I'll prepare an updated package based on that, once I verify that the application for which ucpp is a dependency still builds and works. Thanks for pointing it out. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021160] Review Request: doge - wow very terminal doge
https://bugzilla.redhat.com/show_bug.cgi?id=1021160 --- Comment #4 from Christopher Meng cicku...@gmail.com --- Like I've said: doge.noarch: W: summary-not-capitalized C wow very terminal doge doge.noarch: W: name-repeated-in-summary C doge Upstream use this summary doesn't mean that it's readable and understandable. Please consider a change. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020292] Review Request: bitcoin - Peer-to-peer digital currency
https://bugzilla.redhat.com/show_bug.cgi?id=1020292 Bug 1020292 depends on bug 319901, which changed state. Bug 319901 Summary: missing ec and ecparam commands in openssl package https://bugzilla.redhat.com/show_bug.cgi?id=319901 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018588] Review Request: gssntlmssp - A GSSAPI mechanism for NTLMSSP
https://bugzilla.redhat.com/show_bug.cgi?id=1018588 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||gssntlmssp-0.2.0-0.fc19 Resolution|--- |ERRATA Last Closed||2013-10-20 20:58:02 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- gssntlmssp-0.2.0-0.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972480] Review Request: SkyX - Photorealistic sky simulator
https://bugzilla.redhat.com/show_bug.cgi?id=972480 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972480] Review Request: SkyX - Photorealistic sky simulator
https://bugzilla.redhat.com/show_bug.cgi?id=972480 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014336] Review Request: python-halite - Web GUI for SaltStack
https://bugzilla.redhat.com/show_bug.cgi?id=1014336 --- Comment #18 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014336] Review Request: python-halite - Web GUI for SaltStack
https://bugzilla.redhat.com/show_bug.cgi?id=1014336 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018541] Review Request: libreplaygain - Gain analysis library from Musepack
https://bugzilla.redhat.com/show_bug.cgi?id=1018541 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018541] Review Request: libreplaygain - Gain analysis library from Musepack
https://bugzilla.redhat.com/show_bug.cgi?id=1018541 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021091] Review Request: dnsyo - Check DNS against many global DNS servers
https://bugzilla.redhat.com/show_bug.cgi?id=1021091 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021091] Review Request: dnsyo - Check DNS against many global DNS servers
https://bugzilla.redhat.com/show_bug.cgi?id=1021091 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819274] Review Request: radeonhd-power - power settings for radeon cards
https://bugzilla.redhat.com/show_bug.cgi?id=819274 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #5 from Orion Poplawski or...@cora.nwra.com --- Please read https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 975266] Review Request: cmap-japan - Japanese character mapping resources from Adobe's cmap
https://bugzilla.redhat.com/show_bug.cgi?id=975266 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC||or...@cora.nwra.com, ||ti...@math.uh.edu Flags||needinfo?(ti...@math.uh.edu ||) --- Comment #4 from Orion Poplawski or...@cora.nwra.com --- Ping? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875087] Review Request: pbsclusterviz - Visualise the status of PBS clusters
https://bugzilla.redhat.com/show_bug.cgi?id=875087 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||or...@cora.nwra.com Assignee|nob...@fedoraproject.org|or...@cora.nwra.com --- Comment #6 from Orion Poplawski or...@cora.nwra.com --- I'll take this. It appears you want to target EPEL as well. What versions? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853553] Review Request: guayadeque - Audio player and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=853553
--- Comment #59 from Kevin Kofler ke...@tigcc.ticalc.org ---
Upstream's CMakeLists.txt does this:
FIND_PACKAGE(Subversion)
IF(Subversion_FOUND)
Subversion_WC_INFO(${PROJECT_SOURCE_DIR} GUAYADEQUE)
MESSAGE(Current revision is ${GUAYADEQUE_WC_REVISION})
SET( _GUREVISION_ ${GUAYADEQUE_WC_REVISION})
ELSE(Subversion_FOUND)
SET( _GUREVISION_ )
ENDIF(Subversion_FOUND)
In particular, this line:
Subversion_WC_INFO(${PROJECT_SOURCE_DIR} GUAYADEQUE)
runs svn info on the current directory to obtain the revision and store it in
the CMake variable GUAYADEQUE_WC_REVISION, which is then copies to the CMake
variable _GUREVISION_, presumably to show it in some about dialog or something.
And the tarball they ship is a working copy in an outdated format (outdated SVN
version). (IMHO, shipping SVN working copies rather than exports as tarballs is
broken in the first place.)
IMHO, just removing the .svn directories (i.e. converting the working copies to
a clean export) is the best fix, but you could also run svn upgrade in the
specfile (with BuildRequires: subversion) if you think it's important to have
the revision show up (but you could also manually specify
-D_GUREVISION_:STRING=1885 on the cmake command line to get that).
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969631] Review Request: dlib - A general purpose cross-platform C++ library
https://bugzilla.redhat.com/show_bug.cgi?id=969631 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Whiteboard||NotReady Flags|needinfo?(cicku...@gmail.co | |m) | --- Comment #5 from Christopher Meng cicku...@gmail.com --- This package is more than a crap. I will fix it later, but probably very hard. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972480] Review Request: SkyX - Photorealistic sky simulator
https://bugzilla.redhat.com/show_bug.cgi?id=972480 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972480] Review Request: SkyX - Photorealistic sky simulator
https://bugzilla.redhat.com/show_bug.cgi?id=972480 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- SkyX-0.4-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/SkyX-0.4-4.fc20 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks||656997 (kde-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021160] Review Request: doge - wow very terminal doge
https://bugzilla.redhat.com/show_bug.cgi?id=1021160 --- Comment #5 from Ian Weller i...@ianweller.org --- Spec URL: http://ianweller.fedorapeople.org/SRPMS/doge/0.7.1-1/doge.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/doge/0.7.1-1/doge-0.7.1-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924675] Review Request: epoptes - Computer lab management tool for LTSP
https://bugzilla.redhat.com/show_bug.cgi?id=924675 --- Comment #3 from Christopher Meng cicku...@gmail.com --- Ping. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 979767] Review Request: kapow - A punch clock program
https://bugzilla.redhat.com/show_bug.cgi?id=979767 --- Comment #4 from Christopher Meng cicku...@gmail.com --- URL 404. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928584] Review Request: ros-std_msgs - Standard ROS Messages
https://bugzilla.redhat.com/show_bug.cgi?id=928584 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Assignee|sanjay.an...@gmail.com |cicku...@gmail.com --- Comment #11 from Christopher Meng cicku...@gmail.com --- 0.5.8 is its latest version, right? https://github.com/ros/std_msgs/releases -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972346] Review Request: ros-common_msgs - Common ROS Messages
https://bugzilla.redhat.com/show_bug.cgi?id=972346 --- Comment #4 from Christopher Meng cicku...@gmail.com --- Seems 1.10.2 is its latest version? http://docs.ros.org/hydro/changelogs/common_msgs/changelog.html -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909674] Review Request: Ryu - Network operating system and Openflow controller
https://bugzilla.redhat.com/show_bug.cgi?id=909674 --- Comment #8 from Christopher Meng cicku...@gmail.com --- (In reply to Peter Lemenkov from comment #7) Hello! What's the current status of this ticket? He needs a sponsor... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018541] Review Request: libreplaygain - Gain analysis library from Musepack
https://bugzilla.redhat.com/show_bug.cgi?id=1018541 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018541] Review Request: libreplaygain - Gain analysis library from Musepack
https://bugzilla.redhat.com/show_bug.cgi?id=1018541 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- libreplaygain-0-0.1.20110810svn475.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/libreplaygain-0-0.1.20110810svn475.fc20 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018541] Review Request: libreplaygain - Gain analysis library from Musepack
https://bugzilla.redhat.com/show_bug.cgi?id=1018541 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- libreplaygain-0-0.1.20110810svn475.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libreplaygain-0-0.1.20110810svn475.fc19 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 979767] Review Request: kapow - A punch clock program
https://bugzilla.redhat.com/show_bug.cgi?id=979767
--- Comment #5 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com ---
(In reply to Christopher Meng from comment #3)
Yes. I'll do a full review.
And please fix the issues above.
Fixed.
Besides why there are
%{_datadir}/%{name}/translations/qt_it.qm
%{_datadir}/%{name}/translations/qt_nl.qm
but not in lang file?
The don't get picked by find lang. I'm assuming they're something to do with
qt5. I've commented in the spec.
I hadn't realized that I deleted the spec/srpm. Reuploaded them. Apologies:
Spec/srpm:
http://ankursinha.fedorapeople.org/kapow/kapow.spec
http://ankursinha.fedorapeople.org/kapow/kapow-1.4.4.1-1.fc21.src.rpm
Thanks,
Warm regards,
Ankur
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 982255] Re-Review Request: labyrinth - A light weight mind mapping tool
https://bugzilla.redhat.com/show_bug.cgi?id=982255 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- labyrinth-0.6-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/labyrinth-0.6-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 982255] Re-Review Request: labyrinth - A light weight mind mapping tool
https://bugzilla.redhat.com/show_bug.cgi?id=982255 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- labyrinth-0.6-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/labyrinth-0.6-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
