[Bug 1046122] Review Request: php-doctrine-collections - Collections abstraction library
https://bugzilla.redhat.com/show_bug.cgi?id=1046122 --- Comment #2 from Remi Collet fed...@famillecollet.com --- Created attachment 844863 -- https://bugzilla.redhat.com/attachment.cgi?id=844863action=edit review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1046122 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046122] Review Request: php-doctrine-collections - Collections abstraction library
https://bugzilla.redhat.com/show_bug.cgi?id=1046122
Remi Collet fed...@famillecollet.com changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #3 from Remi Collet fed...@famillecollet.com ---
[!]: Dist tag is present (not strictly required in GL).
Use %{?dist}
[!]: Package does not generate any conflict.
Conflicts: php-pear(pear.doctrine-project.org/DoctrineCommon) 2.4
Both packages provides Doctrine\Common\Collections
As /usr/share/pear is before /usr/share/php this will break
autoloader relying on include_path.
Also explain this package is a split-off DoctrineCommon
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048107] New: Review Request: rubygem-clutter - Ruby binding of Clutter
https://bugzilla.redhat.com/show_bug.cgi?id=1048107 Bug ID: 1048107 Summary: Review Request: rubygem-clutter - Ruby binding of Clutter Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mtas...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://mtasaka.fedorapeople.org/Review_request/ruby-gnome2-suite/rubygem-clutter.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/ruby-gnome2-suite/rubygem-clutter-2.1.0-1.fc.src.rpm Description: Ruby/Clutter is a Ruby binding of Clutter. Fedora Account System Username: mtasaka -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048107] Review Request: rubygem-clutter - Ruby binding of Clutter
https://bugzilla.redhat.com/show_bug.cgi?id=1048107 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Depends On||1047655 --- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org --- Depends on rubygem-cairo-gobject (bug 1047655). Mock build on rawhide i686 is successful with it: http://mtasaka.fedorapeople.org/Review_request/ruby-gnome2-suite/MOCK-rubygem-clutter.log Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1047655 [Bug 1047655] Review Request: rubygem-cairo-gobject - Ruby binding of cairo-gobject -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048045] Review Request: python-sphinx-theme-better - A Better Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1048045 --- Comment #2 from Sandro Mani manisan...@gmail.com --- I'll be doing fedora only. Actually, on second thoughts, I guess pillow won't get updated in RHEL7 at this time anyway (since it is already beta), so the conditionals can also be dropped. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047655] Review Request: rubygem-cairo-gobject - Ruby binding of cairo-gobject
https://bugzilla.redhat.com/show_bug.cgi?id=1047655 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Blocks||1048107 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1048107 [Bug 1048107] Review Request: rubygem-clutter - Ruby binding of Clutter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047762] Review Request: rubygem-rugged - Ruby binding to libgit2
https://bugzilla.redhat.com/show_bug.cgi?id=1047762 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org Flags||fedora-review? --- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org --- Taking. I would appreciate it if you would review my review request (bug 1048107) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1002166] Review Request: junit-benchmarks - Code benchmarking in JUnit4
https://bugzilla.redhat.com/show_bug.cgi?id=1002166 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- junit-benchmarks-0.7.2-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1044935] Review Request: perl-Email-Address-List - RFC close address list parsing
https://bugzilla.redhat.com/show_bug.cgi?id=1044935 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- perl-Email-Address-List-0.01-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036462] Review Request: unifont - Tools and glyph descriptions in a very simple text format
https://bugzilla.redhat.com/show_bug.cgi?id=1036462 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- unifont-6.3.20131221-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1044910] Review Request: perl-Data-GUID - Globally unique identifiers
https://bugzilla.redhat.com/show_bug.cgi?id=1044910 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- perl-Data-GUID-0.048-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024134] Review Request: gust-antykwa-torunska-fonts - Two-element typeface for typesetting of small prints
https://bugzilla.redhat.com/show_bug.cgi?id=1024134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||gust-antykwa-torunska-fonts ||-2.08-4.fc20 Resolution|--- |ERRATA Last Closed||2014-01-03 03:36:42 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- gust-antykwa-torunska-fonts-2.08-4.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1044875] Review Request: perl-Symbol-Global-Name - Finds name and type of a global variable
https://bugzilla.redhat.com/show_bug.cgi?id=1044875 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- perl-Symbol-Global-Name-0.04-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020309] Review Request: kde-connect - KDE Connect client for communication with smartphones
https://bugzilla.redhat.com/show_bug.cgi?id=1020309 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- kde-connect-0.4.2-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library
https://bugzilla.redhat.com/show_bug.cgi?id=1047418 Jens Petersen peter...@redhat.com changed: What|Removed |Added Status|ASSIGNED|POST --- Comment #6 from Jens Petersen peter...@redhat.com --- Built for f21 rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=487644 I will build for f20 in a few days after the https://admin.fedoraproject.org/updates/FEDORA-2013-24050/ghc-gtk-0.12.5.0-1.fc20 stack is pushed stable -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX capability library for the Go programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1032750 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|golang-github-syndtr-gocapa |golang-github-syndtr-gocapa |bility-0-0.3.git3454319.el6 |bility-0-0.3.git3454319.fc2 ||0 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- golang-github-syndtr-gocapability-0-0.3.git3454319.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1016753] Review Request: nodejs-bson - bson parser for node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1016753 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- nodejs-bson-0.2.3-3.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX capability library for the Go programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1032750 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|golang-github-syndtr-gocapa |golang-github-syndtr-gocapa |bility-0-0.3.git3454319.fc2 |bility-0-0.3.git3454319.fc1 |0 |9 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- golang-github-syndtr-gocapability-0-0.3.git3454319.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1002165] Review Request: hppc - High Performance Primitive Collections for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1002165 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- hppc-0.5.3-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1011960] Review Request: datanucleus-rdbms - plugin for RDBMS storage
https://bugzilla.redhat.com/show_bug.cgi?id=1011960 Bug 1011960 depends on bug 1011705, which changed state. Bug 1011705 Summary: Review Request: datanucleus-core - Java persistence abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=1011705 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1011705] Review Request: datanucleus-core - Java persistence abstraction layer
https://bugzilla.redhat.com/show_bug.cgi?id=1011705 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||datanucleus-core-3.2.9-3.fc ||20 Resolution|--- |ERRATA Last Closed||2014-01-03 03:44:40 --- Comment #30 from Fedora Update System upda...@fedoraproject.org --- datanucleus-core-3.2.9-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1011962] Review Request: datanucleus-api-jdo - plugin for JDO support
https://bugzilla.redhat.com/show_bug.cgi?id=1011962 Bug 1011962 depends on bug 1011705, which changed state. Bug 1011705 Summary: Review Request: datanucleus-core - Java persistence abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=1011705 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047746] Review Request: ghc-html - HTML combinator library
https://bugzilla.redhat.com/show_bug.cgi?id=1047746 --- Comment #5 from Jens Petersen peter...@redhat.com --- (In reply to Jens Petersen from comment #4) Thanks Christopher, do appreciate all the review you are contributing. Sorry I meant review work. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047804] Review Request: ghc-regex-base - Haskell regex base library
https://bugzilla.redhat.com/show_bug.cgi?id=1047804 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Jens Petersen peter...@redhat.com --- Thanks Christopher for reviewing. Package Change Request == Package Name: ghc-regex-base New Branches: f20 f19 Owners: petersen InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047804] Review Request: ghc-regex-base - Haskell regex base library
https://bugzilla.redhat.com/show_bug.cgi?id=1047804 Jens Petersen peter...@redhat.com changed: What|Removed |Added Whiteboard|Ready | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047746] Review Request: ghc-html - HTML combinator library
https://bugzilla.redhat.com/show_bug.cgi?id=1047746 Jens Petersen peter...@redhat.com changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047746] Review Request: ghc-html - HTML combinator library
https://bugzilla.redhat.com/show_bug.cgi?id=1047746 --- Comment #6 from Jens Petersen peter...@redhat.com --- Built for F21: http://koji.fedoraproject.org/koji/buildinfo?buildID=487649 I will backport later to F20, when more h-p packages have been unsubpackaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046513] Review Request: glite-lb-state-machine - gLite Logging and Bookkeeping state machine
https://bugzilla.redhat.com/show_bug.cgi?id=1046513 --- Comment #3 from František Dvořák val...@civ.zcu.cz --- (In reply to Christopher Meng from comment #2) Issues: === [x] Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages [?] ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in glite-lb-state-machine-plugins See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries I assume these libs are private, right? Basically yes. One library is normal (the glite-lb-state-machine package) and the other is a plugin (private library loaded at runtime, the glite-lb-state-machine-plugins package). Unknown or generated glite-lb-state-machine-2.0.7/interface/intjobstat_supp.h glite-lb-state-machine-2.0.7/src/intjobstat_supp.c glite-lb-state-machine-2.0.7/src/job_attrs.xsl glite-lb-state-machine-2.0.7/src/job_attrs2.xsl glite-lb-state-machine-2.0.7/src/jpis_config.xsl --- Since you are the upstream maintainer, please add license header later(not a blocker of this review.) OK. Rpmlint (installed packages) # rpmlint glite-lb-state-machine-plugins glite-lb-state-machine glite-lb-state-machine-devel glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol /usr/lib/glite_lb_plugin.so.0.0.0 glite_jppsbe_append_tags glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_attrval_free glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol /usr/lib/glite_lb_plugin.so.0.0.0 glite_jppsbe_pread glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_clear_error glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_stack_error - Are they caused by unreleased dependencies? Yes, these symbols are provided by the code using the plugin. It is used in glite-lb-utils package for example (not yet submitted for review). [rpmaker@fab Desktop]$ ldd -r ~/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so linux-gate.so.1 = (0xb7774000) libglite_lb_common.so.16 = not found libglite_security_gss.so.9 = not found libglite_jobid.so.2 = not found libc.so.6 = /lib/libc.so.6 (0xb756b000) /lib/ld-linux.so.2 (0xb7775000) The missing libraries looks wrong, but I guess the ldd were just called on extracted library here and rpms were not installed. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047804] Review Request: ghc-regex-base - Haskell regex base library
https://bugzilla.redhat.com/show_bug.cgi?id=1047804 Jens Petersen peter...@redhat.com changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #5 from Jens Petersen peter...@redhat.com --- Built for F21: http://koji.fedoraproject.org/koji/buildinfo?buildID=487650 I will backport later to F20, when further h-p packages have been unsubpackaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046513] Review Request: glite-lb-state-machine - gLite Logging and Bookkeeping state machine
https://bugzilla.redhat.com/show_bug.cgi?id=1046513 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046513] Review Request: glite-lb-state-machine - gLite Logging and Bookkeeping state machine
https://bugzilla.redhat.com/show_bug.cgi?id=1046513 František Dvořák val...@civ.zcu.cz changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from František Dvořák val...@civ.zcu.cz --- New Package SCM Request === Package Name: glite-lb-state-machine Short Description: gLite Logging and Bookkeeping state machine Owners: valtri Branches: f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014738] Review Request: python-astropy - A Community Python Library for Astronomy
https://bugzilla.redhat.com/show_bug.cgi?id=1014738 --- Comment #27 from Christopher Meng cicku...@gmail.com --- rawhide python-pillow is ill, please wait. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1000885] Tracker: Review Requests for Design related packages
https://bugzilla.redhat.com/show_bug.cgi?id=1000885 Bug 1000885 depends on bug 996209, which changed state. Bug 996209 Summary: Review Request: knotter - A free and open source customizable interlace designer https://bugzilla.redhat.com/show_bug.cgi?id=996209 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996209] Review Request: knotter - A free and open source customizable interlace designer
https://bugzilla.redhat.com/show_bug.cgi?id=996209 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|fedora-review? | |needinfo?(ib54003@fedorapro | |ject.org) | Last Closed||2014-01-03 05:43:51 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709928] Review Request: publican-openshift - Common documentation files for the OpenShift brand
https://bugzilla.redhat.com/show_bug.cgi?id=709928 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED CC||mhron...@redhat.com Resolution|--- |NOTABUG Last Closed||2014-01-03 05:45:59 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869228] Review Request: photo - Simple, yet powerful and good looking image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=869228 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED CC||mhron...@redhat.com Resolution|--- |NOTABUG Last Closed||2014-01-03 05:46:11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834747] Review Request: gps - IDE for C and Ada
https://bugzilla.redhat.com/show_bug.cgi?id=834747 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||mhron...@redhat.com Resolution|--- |NOTABUG Last Closed||2014-01-03 05:46:35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859671] Review Request: opencpn - A free and open source software for marine navigation
https://bugzilla.redhat.com/show_bug.cgi?id=859671 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED CC||mhron...@redhat.com Resolution|--- |NOTABUG Last Closed||2014-01-03 05:46:23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 869228] Review Request: photo - Simple, yet powerful and good looking image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=869228 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|CLOSED |NEW Resolution|NOTABUG |--- Keywords||Reopened --- Comment #10 from Miro Hrončok mhron...@redhat.com --- (sorry a mistake) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709928] Review Request: publican-openshift - Common documentation files for the OpenShift brand
https://bugzilla.redhat.com/show_bug.cgi?id=709928 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|CLOSED |NEW Resolution|NOTABUG |--- Keywords||Reopened --- Comment #9 from Miro Hrončok mhron...@redhat.com --- (sorry a mistake) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834747] Review Request: gps - IDE for C and Ada
https://bugzilla.redhat.com/show_bug.cgi?id=834747 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|NOTABUG |--- Keywords||Reopened --- Comment #16 from Miro Hrončok mhron...@redhat.com --- (sorry a mistake) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859671] Review Request: opencpn - A free and open source software for marine navigation
https://bugzilla.redhat.com/show_bug.cgi?id=859671 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|CLOSED |NEW Resolution|NOTABUG |--- Keywords||Reopened --- Comment #12 from Miro Hrončok mhron...@redhat.com --- (sorry a mistake) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048045] Review Request: python-sphinx-theme-better - A Better Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1048045
--- Comment #3 from Christopher Meng cicku...@gmail.com ---
I intended to let you change the python2 macro from un-versioned to versioned
like
%{__python}
to
%{__python2}.
You should add conditional lines for this.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924682] Review Request: gimp-elsamuko - Elsamukos script collection for the GIMP
https://bugzilla.redhat.com/show_bug.cgi?id=924682
--- Comment #7 from Palle Ravn ravn...@gmail.com ---
(In reply to Christopher Meng from comment #6)
1. You need to request a license file from upstream and ship it in the
tarball
I have emailed Samuel Elsamuko and awaiting his response.
2. %{_datarootdir} - %{_datadir}
Done.
3. Add a comment in %build like Nothing to build to indicate that no need
to build anything here.
I find it self explaining, but added it anyway.
4. If you don't have any special need, you should remove threaded blank
lines.
It's a topic for endless debate. I use 2 empty lines in all my SPEC files, and
I will continue doing so. All RPM sections, starting from %description, should
be separated by two empty lines. -cite
http://fedoraproject.org/wiki/PeterGordon/SpecFormattingGuidelines
The new SPEC and RPM files are hosted at gimp-elsamuko.zom.dk
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924682] Review Request: gimp-elsamuko - Elsamukos script collection for the GIMP
https://bugzilla.redhat.com/show_bug.cgi?id=924682
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #8 from Christopher Meng cicku...@gmail.com ---
(In reply to Palle Ravn from comment #7)
(In reply to Christopher Meng from comment #6)
1. You need to request a license file from upstream and ship it in the
tarball
I have emailed Samuel Elsamuko and awaiting his response.
Fine.
2. %{_datarootdir} - %{_datadir}
Done.
Done?
%{_datarootdir}/gimp/2.0/scripts/*.scm
4. If you don't have any special need, you should remove threaded blank
lines.
It's a topic for endless debate. I use 2 empty lines in all my SPEC files,
and I will continue doing so. All RPM sections, starting from %description,
should be separated by two empty lines. -cite
http://fedoraproject.org/wiki/PeterGordon/SpecFormattingGuidelines
The new SPEC and RPM files are hosted at gimp-elsamuko.zom.dk
Peter is not god or standard as far as I know. But I never force you to change
the style, I only wanted you to remove these:
Source0:https://sites.google.com/site/elsamuko/gimp/elsamuko.zip
Requires: gimp
BuildArch: noarch
---
Source0:https://sites.google.com/site/elsamuko/gimp/elsamuko.zip
Requires: gimp
BuildArch: noarch
PACKAGE APPROVED.
Please remember to add COPYING file as %doc when upstream releases new tarball.
*This is a MUST*.
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924682] Review Request: gimp-elsamuko - Elsamukos script collection for the GIMP
https://bugzilla.redhat.com/show_bug.cgi?id=924682 --- Comment #9 from Christopher Meng cicku...@gmail.com --- Also, it's better to leave a blank line between each changelog. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008532] Review Request: copr - Cool Other Package Repo
https://bugzilla.redhat.com/show_bug.cgi?id=1008532 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #20 from Miroslav Suchý msu...@redhat.com --- Package Change Request == Package Name: copr New Branches: el5 el6 Owners: msuchy -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1037443] Review Request: libqtxdg - Qt implementation of desktop specifications
https://bugzilla.redhat.com/show_bug.cgi?id=1037443 --- Comment #4 from Michael Schwendt bugs.mich...@gmx.net --- Well, after Lubomir's ping you should/could have waited a bit more, at least, following the existing policy for cases like this: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Reviewer_not_responding -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047062] Review Request: modem-manager-gui - Graphical interface for ModemManager
https://bugzilla.redhat.com/show_bug.cgi?id=1047062
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #3 from Christopher Meng cicku...@gmail.com ---
The fact is that selinux is blocking modemmanager from working normally but not
this gui frontend. So I think it's not a blocker.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v3 or later). Detailed output of licensecheck:
GPL (v3 or later)
-
modem-manager-gui-0.0.16/src/addressbooks.c
modem-manager-gui-0.0.16/src/addressbooks.h
modem-manager-gui-0.0.16/src/ayatana.c
modem-manager-gui-0.0.16/src/ayatana.h
modem-manager-gui-0.0.16/src/encoding.c
modem-manager-gui-0.0.16/src/encoding.h
modem-manager-gui-0.0.16/src/libpaths.c
modem-manager-gui-0.0.16/src/libpaths.h
modem-manager-gui-0.0.16/src/main.c
modem-manager-gui-0.0.16/src/main.h
modem-manager-gui-0.0.16/src/mmguicore.c
modem-manager-gui-0.0.16/src/mmguicore.h
modem-manager-gui-0.0.16/src/modules/mm06.c
modem-manager-gui-0.0.16/src/modules/mm07.c
modem-manager-gui-0.0.16/src/modules/nm09.c
modem-manager-gui-0.0.16/src/modules/pppd245.c
modem-manager-gui-0.0.16/src/netlink.c
modem-manager-gui-0.0.16/src/netlink.h
modem-manager-gui-0.0.16/src/notifications.c
modem-manager-gui-0.0.16/src/notifications.h
modem-manager-gui-0.0.16/src/settings.c
modem-manager-gui-0.0.16/src/settings.h
modem-manager-gui-0.0.16/src/smsdb.c
modem-manager-gui-0.0.16/src/smsdb.h
modem-manager-gui-0.0.16/src/strformat.c
modem-manager-gui-0.0.16/src/strformat.h
modem-manager-gui-0.0.16/src/trafficdb.c
modem-manager-gui-0.0.16/src/trafficdb.h
modem-manager-gui-0.0.16/src/ussdlist.c
modem-manager-gui-0.0.16/src/ussdlist.h
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/locale/bn_BD,
/usr/share/locale/bn_BD/LC_MESSAGES
-- File a bug against filesystem or remove that dir.
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/locale/bn_BD/LC_MESSAGES, /usr/share/locale/bn_BD
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does
[Bug 1006860] Review Request: libnatpmp - Library of The NAT Port Mapping Protocol (NAT-PMP)
https://bugzilla.redhat.com/show_bug.cgi?id=1006860 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Whiteboard|NotReady|Ready --- Comment #3 from Christopher Meng cicku...@gmail.com --- (In reply to Ralf Corsepius from comment #1) Package fails to build in mock: Even if I don't insert flags it can build well, not sure about the problem. Spec URL: http://cicku.me/libnatpmp.spec SRPM URL: http://cicku.me/libnatpmp-20131126-1.fc21.src.rpm This is a dep package of mldonkey. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1037443] Review Request: libqtxdg - Qt implementation of desktop specifications
https://bugzilla.redhat.com/show_bug.cgi?id=1037443 --- Comment #5 from Christopher Meng cicku...@gmail.com --- (In reply to Michael Schwendt from comment #4) Well, after Lubomir's ping you should/could have waited a bit more, at least, following the existing policy for cases like this: https://fedoraproject.org/wiki/ Policy_for_stalled_package_reviews#Reviewer_not_responding Well, see bug 967782. I don't want to explain anymore on this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1037443] Review Request: libqtxdg - Qt implementation of desktop specifications
https://bugzilla.redhat.com/show_bug.cgi?id=1037443
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #6 from Christopher Meng cicku...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2.1 or later), Unknown or generated. 5 files have unknown
license. Detailed output of licensecheck:
LGPL (v2.1 or later)
libqtxdg/xdgaction.cpp
libqtxdg/xdgaction.h
libqtxdg/xdgautostart.cpp
libqtxdg/xdgautostart.h
libqtxdg/xdgdesktopfile.cpp
libqtxdg/xdgdesktopfile.h
libqtxdg/xdgdirs.cpp
libqtxdg/xdgdirs.h
libqtxdg/xdgicon.cpp
libqtxdg/xdgicon.h
libqtxdg/xdgmenu.cpp
libqtxdg/xdgmenu.h
libqtxdg/xdgmenu_p.h
libqtxdg/xdgmenuapplinkprocessor.cpp
libqtxdg/xdgmenuapplinkprocessor.h
libqtxdg/xdgmenulayoutprocessor.cpp
libqtxdg/xdgmenulayoutprocessor.h
libqtxdg/xdgmenureader.cpp
libqtxdg/xdgmenureader.h
libqtxdg/xdgmenurules.cpp
libqtxdg/xdgmenurules.h
libqtxdg/xdgmenuwidget.cpp
libqtxdg/xdgmenuwidget.h
libqtxdg/xdgmime.cpp
libqtxdg/xdgmime.h
libqtxdg/xmlhelper.cpp
libqtxdg/xmlhelper.h
Unknown or generated
libqtxdg/examples/use-qtxdg/main.cpp
libqtxdg/qiconfix/qiconloader.cpp
libqtxdg/qiconfix/qiconloader_p.h
libqtxdg/test/qtxdg_test.cpp
libqtxdg/test/qtxdg_test.h
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must
[Bug 1047785] Review Request: python-pyarabic - Arabic text tools for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1047785 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047785] Review Request: python-pyarabic - Arabic text tools for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1047785
--- Comment #2 from Christopher Meng cicku...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 3 files have unknown license. Detailed output of
licensecheck:
Unknown or generated
PyArabic-0.4/pyarabic/__init__.py
PyArabic-0.4/pyarabic/araby.py
PyArabic-0.4/setup.py
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc,
[Bug 1048039] Review Request: qt5-qtsensors - Qt5 - Sensors module
https://bugzilla.redhat.com/show_bug.cgi?id=1048039 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? --- Comment #1 from Christopher Meng cicku...@gmail.com --- Taken. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046688] Review Request: netsurf-buildsystem - makefiles shared by NetSurf projects
https://bugzilla.redhat.com/show_bug.cgi?id=1046688 --- Comment #6 from Christopher Meng cicku...@gmail.com --- David, will netsurf* be available for f20? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008532] Review Request: copr - Cool Other Package Repo
https://bugzilla.redhat.com/show_bug.cgi?id=1008532 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048039] Review Request: qt5-qtsensors - Qt5 - Sensors module
https://bugzilla.redhat.com/show_bug.cgi?id=1048039 --- Comment #2 from Christopher Meng cicku...@gmail.com --- RPM build errors: Directory not found: /builddir/build/BUILDROOT/qt5-qtsensors-5.2.0-1.fc21.i386/usr/lib/qt5/qml/QtSensors -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008532] Review Request: copr - Cool Other Package Repo
https://bugzilla.redhat.com/show_bug.cgi?id=1008532 --- Comment #21 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046513] Review Request: glite-lb-state-machine - gLite Logging and Bookkeeping state machine
https://bugzilla.redhat.com/show_bug.cgi?id=1046513 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046513] Review Request: glite-lb-state-machine - gLite Logging and Bookkeeping state machine
https://bugzilla.redhat.com/show_bug.cgi?id=1046513 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046842] Review Request: python-ofxparse - Python library for working with the Open Financial Exchange file format
https://bugzilla.redhat.com/show_bug.cgi?id=1046842 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046842] Review Request: python-ofxparse - Python library for working with the Open Financial Exchange file format
https://bugzilla.redhat.com/show_bug.cgi?id=1046842 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1044884] Review Request: perl-Role-Basic - Simplified Moose-like roles
https://bugzilla.redhat.com/show_bug.cgi?id=1044884 --- Comment #3 from Christopher Meng cicku...@gmail.com --- Wrong cvs flag :-0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047532] Review Request: php-sabre-vobject - Library to parse and manipulate iCalendar and vCard objects
https://bugzilla.redhat.com/show_bug.cgi?id=1047532 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047532] Review Request: php-sabre-vobject - Library to parse and manipulate iCalendar and vCard objects
https://bugzilla.redhat.com/show_bug.cgi?id=1047532 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047551] Review Request: php-sabre-dav - WebDAV Framework for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1047551 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047551] Review Request: php-sabre-dav - WebDAV Framework for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1047551 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047746] Review Request: ghc-html - HTML combinator library
https://bugzilla.redhat.com/show_bug.cgi?id=1047746 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047746] Review Request: ghc-html - HTML combinator library
https://bugzilla.redhat.com/show_bug.cgi?id=1047746 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047804] Review Request: ghc-regex-base - Haskell regex base library
https://bugzilla.redhat.com/show_bug.cgi?id=1047804 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047804] Review Request: ghc-regex-base - Haskell regex base library
https://bugzilla.redhat.com/show_bug.cgi?id=1047804 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1045141] Review Request: python-jsonpath-rw - extended implementation of JSONPath for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1045141
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #9 from Christopher Meng cicku...@gmail.com ---
No problem, happy new yarr!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 16 files have unknown license. Detailed output of
licensecheck:
Unknown or generated
python-jsonpath-rw-1.2.3/%{py3dir}/jsonpath_rw/__init__.py
python-jsonpath-rw-1.2.3/%{py3dir}/jsonpath_rw/jsonpath.py
python-jsonpath-rw-1.2.3/%{py3dir}/jsonpath_rw/lexer.py
python-jsonpath-rw-1.2.3/%{py3dir}/jsonpath_rw/parser.py
python-jsonpath-rw-1.2.3/%{py3dir}/setup.py
python-jsonpath-rw-1.2.3/%{py3dir}/tests/test_jsonpath.py
python-jsonpath-rw-1.2.3/%{py3dir}/tests/test_lexer.py
python-jsonpath-rw-1.2.3/%{py3dir}/tests/test_parser.py
python-jsonpath-rw-1.2.3/jsonpath_rw/__init__.py
python-jsonpath-rw-1.2.3/jsonpath_rw/jsonpath.py
python-jsonpath-rw-1.2.3/jsonpath_rw/lexer.py
python-jsonpath-rw-1.2.3/jsonpath_rw/parser.py
python-jsonpath-rw-1.2.3/setup.py
python-jsonpath-rw-1.2.3/tests/test_jsonpath.py
python-jsonpath-rw-1.2.3/tests/test_lexer.py
python-jsonpath-rw-1.2.3/tests/test_parser.py
--- Tell upstream.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the
[Bug 1047532] Review Request: php-sabre-vobject - Library to parse and manipulate iCalendar and vCard objects
https://bugzilla.redhat.com/show_bug.cgi?id=1047532 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- php-sabre-vobject-2.1.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-sabre-vobject-2.1.3-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047532] Review Request: php-sabre-vobject - Library to parse and manipulate iCalendar and vCard objects
https://bugzilla.redhat.com/show_bug.cgi?id=1047532 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- php-sabre-vobject-2.1.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-sabre-vobject-2.1.3-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047532] Review Request: php-sabre-vobject - Library to parse and manipulate iCalendar and vCard objects
https://bugzilla.redhat.com/show_bug.cgi?id=1047532 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- php-sabre-vobject-2.1.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-sabre-vobject-2.1.3-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047532] Review Request: php-sabre-vobject - Library to parse and manipulate iCalendar and vCard objects
https://bugzilla.redhat.com/show_bug.cgi?id=1047532 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047414] Review Request: ioping - Simple disk I/O latency monitoring tool
https://bugzilla.redhat.com/show_bug.cgi?id=1047414 --- Comment #2 from Christopher Meng cicku...@gmail.com --- Spec URL: http://cicku.me/ioping.spec SRPM URL: http://cicku.me/ioping-0.8-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047414] Review Request: ioping - Simple disk I/O latency monitoring tool
https://bugzilla.redhat.com/show_bug.cgi?id=1047414 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Orion Poplawski or...@cora.nwra.com --- That does the trick - APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047497] Review Request: otcl - MIT Object Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1047497 --- Comment #3 from Christopher Meng cicku...@gmail.com --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: === - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: otcl. Illegal package name: otcl. Does not provide -static: otcl. See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: Unknown or generated. 4 files have unknown license. Detailed output of licensecheck: Unknown or generated otcl-1.14/otcl.c otcl-1.14/otcl.h otcl-1.14/otclAppInit.c otcl-1.14/otkAppInit.c --- Tell upstream. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/debug/.build-id/b4(gcc- debuginfo, glibc-debuginfo), /usr/lib/debug/usr/bin(gcc-debuginfo, sqlite-debuginfo, glibc-debuginfo-common, ncurses-debuginfo, lnav- debuginfo, bzip2-debuginfo, pcre-debuginfo, openssl-debuginfo), /usr/lib/debug/.build-id(readline-debuginfo, sqlite-debuginfo, glibc- debuginfo-common, gcc-base-debuginfo, gcc-debuginfo, glibc-debuginfo, zlib-debuginfo, ncurses-debuginfo, lnav-debuginfo, bzip2-debuginfo, pcre- debuginfo, openssl-debuginfo), /usr/lib/debug/.dwz(readline-debuginfo, sqlite-debuginfo, zlib-debuginfo, ncurses-debuginfo, bzip2-debuginfo, pcre-debuginfo, openssl-debuginfo), /usr/lib/debug(readline-debuginfo, sqlite-debuginfo, glibc-debuginfo-common, gcc-base-debuginfo, gcc- debuginfo, glibc-debuginfo, zlib-debuginfo, ncurses-debuginfo, lnav- debuginfo, bzip2-debuginfo, filesystem, pcre-debuginfo, openssl- debuginfo), /usr/lib/debug/usr(gcc-debuginfo, sqlite-debuginfo, glibc- debuginfo-common, gcc-base-debuginfo, glibc-debuginfo, zlib-debuginfo, ncurses-debuginfo, lnav-debuginfo, bzip2-debuginfo, filesystem, pcre- debuginfo), /usr/lib/debug/.build-id/73(gcc-debuginfo), /usr/lib/debug/usr/lib(readline-debuginfo, sqlite-debuginfo, gcc-base- debuginfo, gcc-debuginfo, glibc-debuginfo, zlib-debuginfo, ncurses- debuginfo, bzip2-debuginfo, pcre-debuginfo, openssl-debuginfo), /usr/lib/debug/.build-id/eb(glibc-debuginfo) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 296960 bytes in 9 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]:
[Bug 1047551] Review Request: php-sabre-dav - WebDAV Framework for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1047551 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- php-sabre-dav-1.8.7-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-sabre-dav-1.8.7-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047551] Review Request: php-sabre-dav - WebDAV Framework for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1047551 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- php-sabre-dav-1.8.7-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-sabre-dav-1.8.7-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047551] Review Request: php-sabre-dav - WebDAV Framework for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1047551 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047551] Review Request: php-sabre-dav - WebDAV Framework for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1047551 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- php-sabre-dav-1.8.7-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-sabre-dav-1.8.7-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047062] Review Request: modem-manager-gui - Graphical interface for ModemManager
https://bugzilla.redhat.com/show_bug.cgi?id=1047062 --- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com --- I've removed the bn_BD locale in %prep. Besides that, I've added summary, description and man page in German. New files: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/modem-manager-gui.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/modem-manager-gui-0.0.16-4.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048039] Review Request: qt5-qtsensors - Qt5 - Sensors module
https://bugzilla.redhat.com/show_bug.cgi?id=1048039 --- Comment #3 from Rex Dieter rdie...@math.unl.edu --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6353073 (sorry, refereshed the .src.rpm since original submission) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924682] Review Request: gimp-elsamuko - Elsamukos script collection for the GIMP
https://bugzilla.redhat.com/show_bug.cgi?id=924682
--- Comment #10 from Palle Ravn ravn...@gmail.com ---
(In reply to Christopher Meng from comment #8)
2. %{_datarootdir} - %{_datadir}
Done.
Done?
%{_datarootdir}/gimp/2.0/scripts/*.scm
I missed that one, sorry for that.
4. If you don't have any special need, you should remove threaded blank
lines.
It's a topic for endless debate. I use 2 empty lines in all my SPEC files,
and I will continue doing so. All RPM sections, starting from %description,
should be separated by two empty lines. -cite
http://fedoraproject.org/wiki/PeterGordon/SpecFormattingGuidelines
The new SPEC and RPM files are hosted at gimp-elsamuko.zom.dk
Peter is not god or standard as far as I know. But I never force you to
change the style, I only wanted you to remove these:
Source0:https://sites.google.com/site/elsamuko/gimp/elsamuko.zip
Requires: gimp
BuildArch: noarch
---
Source0:https://sites.google.com/site/elsamuko/gimp/elsamuko.zip
Requires: gimp
BuildArch: noarch
I misunderstood that one. I will remove the empty lines.
Please remember to add COPYING file as %doc when upstream releases new
tarball. *This is a MUST*.
I made a comment in the %files section to remember this.
(In reply to Christopher Meng from comment #9)
Also, it's better to leave a blank line between each changelog.
I will start doing that.
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048040] Review Request: qt5-qtserialport - Qt Serial Port provides the basic functionality, which includes configuring, I/O operations, getting and setting the control signals of the RS-232 pin
https://bugzilla.redhat.com/show_bug.cgi?id=1048040 --- Comment #1 from Rex Dieter rdie...@math.unl.edu --- scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6353143 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048259] Review Request: qt5-qtconnectivity - Qt5 Connectivity module
https://bugzilla.redhat.com/show_bug.cgi?id=1048259 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||928937 (qt-reviews) Alias||qt5-qtconnectivity Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048259] New: Review Request: qt5-qtconnectivity - Qt5 Connectivity module
https://bugzilla.redhat.com/show_bug.cgi?id=1048259 Bug ID: 1048259 Summary: Review Request: qt5-qtconnectivity - Qt5 Connectivity module Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtconnectivity.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtconnectivity-5.2.0-1.fc20.src.rpm Description: Qt5 Connectivity module Fedora Account System Username: rdieter scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6353147 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924682] Review Request: gimp-elsamuko - Elsamukos script collection for the GIMP
https://bugzilla.redhat.com/show_bug.cgi?id=924682 Palle Ravn ravn...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924682] Review Request: gimp-elsamuko - Elsamukos script collection for the GIMP
https://bugzilla.redhat.com/show_bug.cgi?id=924682 --- Comment #11 from Palle Ravn ravn...@gmail.com --- New Package SCM Request === Package Name: gimp-elsamuko Short Description: Script collection for the GIMP Owners: paller Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048260] New: Review Request: qt5-qtlocation - Qt5 Location module
https://bugzilla.redhat.com/show_bug.cgi?id=1048260 Bug ID: 1048260 Summary: Review Request: qt5-qtlocation - Qt5 Location module Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtlocation.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtlocation-5.2.0-1.fc20.src.rpm Description: The Qt Positioning API gives developers the ability to determine a position by using a variety of possible sources, including satellite, or wifi, or text file, and so on. That information can then be used to for example determine a position on a map. In addition satellite information can be retrieved and area based monitoring can be performed. Fedora Account System Username: rdieter scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6353069 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 979124] Review Request: qbs - Qt Build Suite
https://bugzilla.redhat.com/show_bug.cgi?id=979124 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Alias||qbs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924682] Review Request: gimp-elsamuko - Elsamukos script collection for the GIMP
https://bugzilla.redhat.com/show_bug.cgi?id=924682 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048040] Review Request: qt5-qtserialport - Qt5 Serialport module
https://bugzilla.redhat.com/show_bug.cgi?id=1048040 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Summary|Review Request: |Review Request: |qt5-qtserialport - Qt |qt5-qtserialport - Qt5 |Serial Port provides the|Serialport module |basic functionality, which | |includes configuring, I/O | |operations, getting and | |setting the control signals | |of the RS-232 pinouts. | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924682] Review Request: gimp-elsamuko - Elsamukos script collection for the GIMP
https://bugzilla.redhat.com/show_bug.cgi?id=924682 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046340] Review Request: qtkeychain - A cross platform password store library
https://bugzilla.redhat.com/show_bug.cgi?id=1046340 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Alias||qtkeychain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048260] Review Request: qt5-qtlocation - Qt5 Location module
https://bugzilla.redhat.com/show_bug.cgi?id=1048260 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||928937 (qt-reviews) Alias||qt5-qtlocation Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048040] Review Request: qt5-qtserialport - Qt5 Serialport module
https://bugzilla.redhat.com/show_bug.cgi?id=1048040 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|NEW |ASSIGNED CC||lkund...@v3.sk Assignee|nob...@fedoraproject.org|lkund...@v3.sk Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
