[Bug 1141494] New: Review Request: python-flask-whooshalchemy - Whoosh extension to Flask/SQLAlchemy
https://bugzilla.redhat.com/show_bug.cgi?id=1141494 Bug ID: 1141494 Summary: Review Request: python-flask-whooshalchemy - Whoosh extension to Flask/SQLAlchemy Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: tonet6...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://tonet666p.fedorapeople.org/python-flask-whooshalchemy.spec SRPM URL: https://tonet666p.fedorapeople.org/python-flask-whooshalchemy-0.56-1.fc20.src.rpm Description: Hi, I just finished packaging up this Flask extension, and i would appreciate a review so that I can get it in to Fedora Extras. Flask-WhooshAlchemy is a Flask extension that integrates the text-search functionality of Whoosh with the ORM of SQLAlchemy for use in Flask applications. Fedora Account System Username: tonet666p -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141494] Review Request: python-flask-whooshalchemy - Whoosh extension to Flask/SQLAlchemy
https://bugzilla.redhat.com/show_bug.cgi?id=1141494 Tonet Jallo changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140195] Review Request: Paper Shaper - Provides random wallpaper from webcams or saved images or both
https://bugzilla.redhat.com/show_bug.cgi?id=1140195 --- Comment #3 from pkcarlisle-dot-com --- Hi, thanks for commenting. >> Who is pkcarlisle-dot-com behind? I am sorry, I do not understand this question. pkcarlisle.com is my own domain. I wrote this utility because I use Linux and I thought this program was a nice enhancement to a desktop. That's all. No deep ulterior motive. No conspiracy-theory-deeply-hidden-corporate connection. Just me and my little Linux box. >> I really can't figure out what this package is. It violates FHS as well: I am not sure I can explain what the package IS better than I already have done. I am new to the prospect of submitting RPMs for inclusion in Linux. There are doubtless many things I do not know. That is why I have submitted this for review. With regard to the FHS, I wrote this program explicitly with the idea of providing individual users their own a) individual b) individually customizable and c) automated wallpaper randomizer. So I set it up to install in each user's /home/ folders individually. If this violates an inviolable standard (is the standard inviolable?) no doubt the review process will help determine that and/or a better approach. >> And even if this is a pretty small package, I think you need to cleanup the >> spec, it's messy. I am new to making RPMs and I welcome any specific criticisms I can address. “It's messy” is not something I can specifically address. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1139009] Review Request: perl-LV - Perl module to make lvalue subroutines easy and practical
https://bugzilla.redhat.com/show_bug.cgi?id=1139009 Emmanuel Seyman changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-09-13 21:08:06 --- Comment #6 from Emmanuel Seyman --- Built in Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141486] New: Review Request: perl-enum - C-style enumerated types and bitmask flags in Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1141486 Bug ID: 1141486 Summary: Review Request: perl-enum - C-style enumerated types and bitmask flags in Perl Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: de...@fateyev.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://www.fateyev.com/RPMS/Fedora20/testing/perl-enum.spec SRPM URL: http://www.fateyev.com/RPMS/Fedora20/testing/SRPMS/perl-enum-1.10-1.fc20.denf.src.rpm Description: This module is used to define a set of constants with ordered numeric values, similar to the enum type in the C programming language. The programmer can also define bitmask constants, where the value assigned to each constant has exactly one bit set (e.g. 1, 2, 4, 8, etc). Fedora Account System Username: dfateyev Koji scratch builds: https://koji.fedoraproject.org/koji/taskinfo?taskID=7575407 (Rawhide) https://koji.fedoraproject.org/koji/taskinfo?taskID=7575409 (Fedora 20) https://koji.fedoraproject.org/koji/taskinfo?taskID=7575411 (EPEL 6) https://koji.fedoraproject.org/koji/taskinfo?taskID=7575453 (EPEL 5) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 Martin changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX Last Closed||2014-09-13 17:33:59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140403] Review Request: dreamchess - open source chess game
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #5 from Raphael Groner ---
Christan, thanks for your review. All found issues are fixed.
Spec URL: https://raphgro.fedorapeople.org/review/dreamchess/dreamchess.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/dreamchess/dreamchess-0.2.1-2.RC1.fc20.src.rpm
Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7575357
(In reply to Christian Dersch from comment #4)
> Issues:
> ===
> - Package uses either %{buildroot} or $RPM_BUILD_ROOT
> Note: Using both %{buildroot} and $RPM_BUILD_ROOT
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
>
> ==> You can remove "rm -rf $RPM_BUILD_ROOT" for current Fedora releases (but
> required for EPEL5)
done.
> [!]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses found:
> "BSD (3 clause)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
> generated". 4 files have unknown license. Detailed output of
> licensecheck
> in /home/review/1140403-dreamchess/licensecheck.txt
>
> ==> Please check this, licensecheck.txt is below, but BSD license is also
> mentioned in COPYRIGHT file
done.
> [!]: Package requires other packages for directories it uses.
> Note: No known owner of /usr/share/dreamchess
> [!]: Package must own all directories that it creates.
> Note: Directories without known owners: /usr/share/dreamchess
>
> ==> Please check this
done.
> [!]: Package complies to the Packaging Guidelines
>
> ==> You are packaging RC1, not the final version! Please add this
> information in release tag
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning
done.
> [!]: Fully versioned dependency in subpackages if applicable.
> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
> dreamchess-
> data
> ==> Please fix this, Requires: %{name}-%{version} instead of %{name}
done.
> [!]: Spec use %global instead of %define unless justified.
> Note: %define requiring justification: %define _suffix -RC1, %define
> _engine dreamer
> ==> Please adjust this when fixing spec
done.
> licensecheck.txt
> …
> Unknown or generated
>
> dreamchess-0.2.1-RC1/src/dreamer/pgn_scanner.c
Cause the corresponding header is licensed properly, assume this file admits
it.
> dreamchess-0.2.1-RC1/src/include/git_rev.h
Could be ignored for licensing cause it gives only a checkout revision.
> dreamchess-0.2.1-RC1/src/macosx/makeapp.pl
MacOS? Perl? Not needed build script. Ignored.
> dreamchess-0.2.1-RC1/src/pgn_scanner.c
Cause the corresponding header is licensed properly, assume this file admits
it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1136972] Review Request: paflib - POWER Architecture facilities library
https://bugzilla.redhat.com/show_bug.cgi?id=1136972
--- Comment #15 from Michael Schwendt ---
> Name: paflib
> Group: Development/Libraries
The group for _runtime_ library packages has been "System
Environment/Libraries" for a very long time.
Alternatively, consider dropping the Group tag:
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
> %files
> %{_mandir}/man3/libpaf-dsc.3*
> %{_mandir}/man3/libpaf-ebb.3*
Those section 3 manuals belong into the -devel subpackage.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1083344] Review Request: hub - A command-line wrapper for git with github shortcuts
https://bugzilla.redhat.com/show_bug.cgi?id=1083344 Ralph Bean changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #13 from Ralph Bean --- Package Change Request == Package Name: hub New Branches: epel7 Owners: ralph -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber
https://bugzilla.redhat.com/show_bug.cgi?id=1138321 --- Comment #16 from Julien Enselme --- New Package SCM Request === Package Name: reneebeanie-fonts Short Description: Renie Beanie fonts by James Grieshaber Upstream URL: http://www.google.com/fonts/specimen/Reenie+Beanie Owners: jujens Branches: f20 f21 InitialCC: fonts-sig, i18n-team -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138338] Review Request: specialelite-fonts - Special Elite fonts by Brian J. Bonislawsky
https://bugzilla.redhat.com/show_bug.cgi?id=1138338 --- Comment #1 from Julien Enselme --- - Correct the SOURCEs URLs - Remove the files macro - Correct the prep section - Correct the version - Update the fontconf file Spec URL: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/specialelite-fonts.spec SRPM URL: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/specialelite-fonts-1.000-0.2.20140913hg.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber
https://bugzilla.redhat.com/show_bug.cgi?id=1138321 --- Comment #15 from Parag AN(पराग) --- (In reply to Julien Enselme from comment #13) > 1) The page already exists http://fedoraproject.org/wiki/Renee_Beanie_Fonts > (it is classified as In progress fonts so it doesn't appear on the Packaged > fonts list). Wow! nice. > > 2) I will try to think of this. Its recommended to add InitialCC. See about this InitialCC at http://fedoraproject.org/wiki/Package_SCM_admin_requests#Pseudo-users_for_SIGs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138330] Review Request: shadowsintolight-fonts - Shadows Into Light fonts by Kimberly Geswein
https://bugzilla.redhat.com/show_bug.cgi?id=1138330 --- Comment #6 from Julien Enselme --- - Correct the SOURCEs URLs - Correct the prep section Spec URL: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/shadowsintolight-fonts.spec SRPM URL: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/shadowsintolight-fonts-1.000-0.3.20140913hg.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1137021] Review Request: monofett-fonts - Monofett fonts released by Vernon Adams
https://bugzilla.redhat.com/show_bug.cgi?id=1137021 --- Comment #5 from Julien Enselme --- - Correct the SOURCEs URLs - Correct the prep section Spec URL: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/monofett-fonts.spec SRPM URL: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/monofett-fonts-1.000-0.3.20140913hg.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1137018] Review Request: labelleaurore-fonts -La Belle Aurore fonts by Kimberly Geswein
https://bugzilla.redhat.com/show_bug.cgi?id=1137018 --- Comment #3 from Julien Enselme --- I updated the URL and the SOURCE, removed %files and update %prep. I also corrected the version (1.001 instead of 1.00) and use a pre release tag name. The font is cursive and not handwritten (corrected). Spec URL: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/labelleaurore-fonts.spec SRPM URL: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/labelleaurore-fonts-1.001-0.2.20140913hg.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber
https://bugzilla.redhat.com/show_bug.cgi?id=1138321 Julien Enselme changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from Julien Enselme --- New Package SCM Request === Package Name: reneebeanie-fonts Short Description: Renie Beanie fonts by James Grieshaber Upstream URL: http://www.google.com/fonts/specimen/Reenie+Beanie Owners: jujens Branches: f20 f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber
https://bugzilla.redhat.com/show_bug.cgi?id=1138321 --- Comment #13 from Julien Enselme --- 1) The page already exists http://fedoraproject.org/wiki/Renee_Beanie_Fonts (it is classified as In progress fonts so it doesn't appear on the Packaged fonts list). 2) I will try to think of this. 3) Starting this now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138892] Review Request: python-gmpy2 - Python 2 interface to GMP, MPFR, and MPC
https://bugzilla.redhat.com/show_bug.cgi?id=1138892 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- python-gmpy2-2.0.3-2.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099166] Review Request: screenfetch - Display system information
https://bugzilla.redhat.com/show_bug.cgi?id=1099166 --- Comment #20 from Martín Buenahora --- (In reply to Raphael Groner from comment #19) > You could also "do the AUR way" and use a suffix, that means > 'screenfetch-git' as a (temporary) package name, till there would be any > main release at upstream. So there could be two packages (git and "official" > release). Just as an idea, you're of course free to name your package as you > prefer if the guidelines comply. > > See also > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non- > Numeric_Version_in_Release Well, the main reason for switching to git version was because the URL where I was downloading the sources died, and the tar.gz downloaded from git have a different name than the one in the URL, but now I know how to fix that. ¿It would be better to stay in release version? Because I don't want to make a new package for every commit... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1132971] Review Request: python-pyvmomi - pyVmomi is the Python SDK for the VMware vSphere API that allows you to manage ESX, ESXi, and vCenter
https://bugzilla.redhat.com/show_bug.cgi?id=1132971 Michael Rice changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Michael Rice --- New Package SCM Request === Package Name: python-pyvmomi Short Description: Python SDK for the VMware vSphere API Upstream URL: https://github.com/vmware/pyvmomi Owners: errr Branches: f19 f20 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099166] Review Request: screenfetch - Display system information
https://bugzilla.redhat.com/show_bug.cgi?id=1099166 --- Comment #19 from Raphael Groner --- (In reply to Martín Buenahora from comment #18) > I have a doubt about the version. The upstream have releases, as you have > seen, but they aren't really defined (I remember one commit that said > something like "Is been a while since a new release"), so I don't know if I > should come back to the releases, or if I should stay with the git version > (I would use "git" rather than "git"). You could also "do the AUR way" and use a suffix, that means 'screenfetch-git' as a (temporary) package name, till there would be any main release at upstream. So there could be two packages (git and "official" release). Just as an idea, you're of course free to name your package as you prefer if the guidelines comply. See also https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493
--- Comment #10 from Jamie Nguyen ---
(In reply to Raphael Groner from comment #9)
> > %files
> > …
> > %{_mandir}/man1/bashmount.1*
>
> Shouldn't that be with %doc in front?
> %doc %{_mandir}/man1/bashmount.1*
No. See other spec files or the guidelines on the wiki for more info.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493
--- Comment #9 from Raphael Groner ---
> %files
> …
> %{_mandir}/man1/bashmount.1*
Shouldn't that be with %doc in front?
%doc %{_mandir}/man1/bashmount.1*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099166] Review Request: screenfetch - Display system information
https://bugzilla.redhat.com/show_bug.cgi?id=1099166
--- Comment #18 from Martín Buenahora ---
(In reply to Raphael Groner from comment #17)
> This is no formal review. But I have some general comments to your spec file.
>
> > Name: screenFetch
> Try to keep a consistent name and don't mix upper/lower-case: screenfetch
>
> > Version:20140914git
> Do you plan to release always from git with date as version? Maybe we should
> think about a better versioning scheme to be able to switch to main
> releases. At least put 0. before: 0.20140914git
>
> > %description
> > screenFetch is a "Bash Screenshot Information Tool".
> You can remove that line from %description, because it's / should be the
> Summary.
>
> > %files
> > …
> > %{_mandir}/man1/screenfetch.1.gz
> That manpage should be with %doc in front:
> %doc %{_mandir}/man1/screenfetch.1.gz
>
>
> > %changelog
> > * Tue Sep 9 2014 Martín Buenahora -
> > 20140914git-1
> Please provide an official and working e-mail address. You can use your one
> from FAS (login: zironid).
Hello Raphael.
I've changed the Summary, the manpages location and the e-mail (I'm using an
Emacs that automatically adds entries to the changelog, and uses that as the
default e-mail), and changed the F from the name.
I have a doubt about the version. The upstream have releases, as you have seen,
but they aren't really defined (I remember one commit that said something like
"Is been a while since a new release"), so I don't know if I should come back
to the releases, or if I should stay with the git version (I would use
"git" rather than "git").
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber
https://bugzilla.redhat.com/show_bug.cgi?id=1138321 Parag AN(पराग) changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #12 from Parag AN(पराग) --- 1)Not a mandatory but if you think please add information about this font on fedora wiki. You can find other fonts added to wiki at http://fedoraproject.org/wiki/Category:Packaged_fonts 2) When you request for SCM do add following InitialCC: fonts-sig, i18n-team 3) Do update your other package review requests like what here we corrected. The above submitted update looks good now. APPROVED this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141446] New: Review Request: perl-Pod-Snippets - Extract and reformat snippets of POD
https://bugzilla.redhat.com/show_bug.cgi?id=1141446 Bug ID: 1141446 Summary: Review Request: perl-Pod-Snippets - Extract and reformat snippets of POD Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: robinlee.s...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://cheeselee.fedorapeople.org/perl-Pod-Snippets.spec SRPM URL: http://cheeselee.fedorapeople.org/perl-Pod-Snippets-0.14-1.fc20.src.rpm Description: This class is a very simple extension of Pod::Parser that extracts POD snippets from Perl code, and pretty-prints it so as to make it usable from other Perl code. As demonstrated above, Pod::Snippets is immediately useful to test-driven-development nutcases who want to put every single line of Perl code under test, including code that is in the POD (typically a SYNOPSIS section). There are other uses, such as storing a piece of information that is both human- and machine-readable (e.g. an XML schema) simultaneously as documentation and code. Fedora Account System Username: cheeselee -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber
https://bugzilla.redhat.com/show_bug.cgi?id=1138321 --- Comment #11 from Julien Enselme --- 1) Corrected, thanks. 2) Corrected, thanks. 3) I did not pay enough attention, sorry. I corrected this. Spec URL: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/reeniebeanie-fonts.spec SRPM URL: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/reeniebeanie-fonts-1.000-0.4.20140913hg.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #8 from Jamie Nguyen --- New Package SCM Request === Package Name: bashmount Short Description: A menu-driven bash script for mounting removable media Upstream URL: https://github.com/jamielinux/bashmount Owners: jamielinux Branches: f19 f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Jamie Nguyen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Jamie Nguyen --- Thanks very much for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber
https://bugzilla.redhat.com/show_bug.cgi?id=1138321
--- Comment #10 from Parag AN(पराग) ---
1) you added in the spec
cp ~/rpmbuild/SOURCES/{ReenieBeanie.ttf,OFL.txt} .
this is not going to work. Just do koji scratch build of above srpm.
You should add for any individual source files like
cp -p %{SOURCE0} %{SOURCE1} .
2) small change in summary needed as its only single font
Summary: Renie Beanie fonts by James Grieshaber
to
Summary: Renie Beanie font by James Grieshaber
3) you chose post-release snapshot naming. But if we look for any released
tarball on http://www.google.com/fonts/specimen/Reenie+Beanie page then its not
there. So, I will take that as no stable tarball ever released. So this is
pre-release snapshot so release tag should be
Release: 0.3.%{alphatag}%{?dist}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683150] Review Request: yad - Display graphical dialogs from shell scripts or command line
https://bugzilla.redhat.com/show_bug.cgi?id=683150 --- Comment #36 from Elder Marco --- Hi Raphael, No problem. Fixed, thanks! :) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber
https://bugzilla.redhat.com/show_bug.cgi?id=1138321 --- Comment #9 from Julien Enselme --- I guess it was a temporary problem. I am now also able to download the file with these URLs. I have update my SPEC file. Spec URL: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/reeniebeanie-fonts.spec SRPM URL: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/reeniebeanie-fonts-1.000-3.20140913hg.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022283] Review Request: gnulib - GNU Portability Library
https://bugzilla.redhat.com/show_bug.cgi?id=1022283 --- Comment #66 from Mosaab Alzoubi --- I'll do SOON ^_^ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140195] Review Request: Paper Shaper - Provides random wallpaper from webcams or saved images or both
https://bugzilla.redhat.com/show_bug.cgi?id=1140195 Christopher Meng changed: What|Removed |Added Component|Package Review |Package Review Version|el6 |rawhide Product|Fedora EPEL |Fedora --- Comment #2 from Christopher Meng --- (In reply to pkcarlisle-dot-com from comment #1) Who is pkcarlisle-dot-com behind? I really can't figure out what this package is. It violates FHS as well: /com.pkcarlisle/papershaper/ And even if this is a pretty small package, I think you need to cleanup the spec, it's messy. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074128] Review Request: libserialport - Library for accessing serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=1074128 Jamie Nguyen changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #13 from Jamie Nguyen --- Package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074128] Review Request: libserialport - Library for accessing serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=1074128
--- Comment #12 from Jamie Nguyen ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v3 or later)", "GPL (v2 or later)". Detailed output of
licensecheck in /home/mockbuild/libserialport/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
libserialport-doc
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright
[Bug 1138476] Review Request: percona-toolkit - A MySQL Toolkit by Percona
https://bugzilla.redhat.com/show_bug.cgi?id=1138476 --- Comment #5 from Christopher Meng --- Installation errors --- INFO: mock.py version 1.1.41 starting... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Mock Version: 1.1.41 INFO: Mock Version: 1.1.41 Start: lock buildroot INFO: installing package(s): /home/cawk/Desktop/percona-toolkit/results/percona-toolkit-2.2.10-2.fc22.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-x86_64/root/', '--releasever', '22', 'install', '/home/cawk/Desktop/percona-toolkit/results/percona-toolkit-2.2.10-2.fc22.noarch.rpm'] Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Lmo) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(AdvisorRules) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Lmo::Object) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(DiskstatsGroupByDisk) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(NibbleIterator) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Lmo::Utils) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(DiskstatsGroupByAll) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Lmo::Meta) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(DiskstatsGroupBySample) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Transformers) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Quoter) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(ReadKeyMini) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Lmo::Types) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Percona::Toolkit) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Diskstats) You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1091100] Review Request: python-affinity - control processor affinity on windows and linux
https://bugzilla.redhat.com/show_bug.cgi?id=1091100 Christopher Meng changed: What|Removed |Added Flags|needinfo?(i...@cicku.me) | --- Comment #7 from Christopher Meng --- (In reply to Nick Bebout from comment #6) > Christopher, any update on this review? You didn't remove the obsolete stuffs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683150] Review Request: yad - Display graphical dialogs from shell scripts or command line
https://bugzilla.redhat.com/show_bug.cgi?id=683150 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #35 from Raphael Groner --- You should adjust the URL cause of the reasoning at the old homepage: > !!! PROJECT MOVED to SourceForge due to google politics about file hosting !!! > New address - https://sourceforge.net/projects/yad-dialog/ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099166] Review Request: screenfetch - Display system information
https://bugzilla.redhat.com/show_bug.cgi?id=1099166
Raphael Groner changed:
What|Removed |Added
CC||projects...@smart.ms
--- Comment #17 from Raphael Groner ---
This is no formal review. But I have some general comments to your spec file.
> Name: screenFetch
Try to keep a consistent name and don't mix upper/lower-case: screenfetch
> Version:20140914git
Do you plan to release always from git with date as version? Maybe we should
think about a better versioning scheme to be able to switch to main releases.
At least put 0. before: 0.20140914git
> %description
> screenFetch is a "Bash Screenshot Information Tool".
You can remove that line from %description, because it's / should be the
Summary.
> %files
> …
> %{_mandir}/man1/screenfetch.1.gz
That manpage should be with %doc in front:
%doc %{_mandir}/man1/screenfetch.1.gz
> %changelog
> * Tue Sep 9 2014 Martín Buenahora -
> 20140914git-1
Please provide an official and working e-mail address. You can use your one
from FAS (login: zironid).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074128] Review Request: libserialport - Library for accessing serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=1074128 Jamie Nguyen changed: What|Removed |Added Flags|needinfo?(jamielinux@fedora | |project.org)| |needinfo?(mr.nuke.me@gmail. | |com)| --- Comment #11 from Jamie Nguyen --- Extremely sorry for the delay and lack of reply :( $LIFE stuff shifted many priorities.. Continuing review process now! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140136] Review Request: python-tooz - Coordination library for distributed systems
https://bugzilla.redhat.com/show_bug.cgi?id=1140136 Bug 1140136 depends on bug 1140099, which changed state. Bug 1140099 Summary: [PATCH] Introduce python3-posix_ipc subpackage https://bugzilla.redhat.com/show_bug.cgi?id=1140099 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
