[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191042] Review Request: perl-MouseX-App-Cmd - Mashes up MouseX::Getopt and App::Cmd
https://bugzilla.redhat.com/show_bug.cgi?id=1191042 --- Comment #1 from Petr Šabata psab...@redhat.com --- Missing BRs: - base, t/build_emulates_new.t:10 - English, lib/MouseX/App/Cmd.pm:5 - File::Basename, lib/MouseX/App/Cmd.pm:6 - lib, t/basic.t:8, t/configfile.t:19, t/moose.t:11 - MouseX::Getopt, t/moose.t:7 - strict, Makefile.PL:3 - warnings, Makefile.PL:4 Many missing dependencies from the resulting binary RPM. This is mostly from Moose-like keywords. - App::Cmd (0.321+, as mandated by META files) - App::Cmd::Command - Mouse::Object - MouseX::Getopt Explicitly require Getopt::Long::Descriptive 0.091+ and filter out the underspecified autogenerated dependency. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1189460] Review Request: dock - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1189460
--- Comment #4 from Jiri Popelka jpope...@redhat.com ---
(In reply to Jiri Popelka from comment #3)
%{python2_sitelib} in %files -n python3-dock
s/%{python2_sitelib}/%{python3_sitelib}/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1183258] Review Request: perl-Bytes-Random-Secure - Perl extension to generate cryptographically-secure random bytes
https://bugzilla.redhat.com/show_bug.cgi?id=1183258 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142491] Review Request: rubygem-ox - Fast XML parser and object serializer
https://bugzilla.redhat.com/show_bug.cgi?id=1142491 --- Comment #2 from František Dvořák val...@civ.zcu.cz --- Spec URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.7-1/rubygem-ox.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.7-1/rubygem-ox-2.1.7-1.fc22.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8884773 %changelog * Tue Feb 10 2015 František Dvořák val...@civ.zcu.cz - 2.1.7-1 - Update to 2.1.7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #2 from MartinKG mgans...@alice.de --- have found that the package contains bundled fonts files = SHOULD items = Generic: [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files In the doc path contains the fontawesome font /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts/FontAwesome.otf /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts/fontawesome-webfont.eot /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts/fontawesome-webfont.svg /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts/fontawesome-webfont.ttf /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts/fontawesome-webfont.woff Fedora itself brings already a fontawesome font package with this contents: rpm -ql fontawesome-fonts /etc/fonts/conf.d/60-fontawesome.conf /usr/share/doc/fontawesome-fonts /usr/share/doc/fontawesome-fonts/README-Trademarks.txt /usr/share/fontconfig/conf.avail/60-fontawesome.conf /usr/share/fonts/fontawesome /usr/share/fonts/fontawesome/FontAwesome.otf /usr/share/fonts/fontawesome/fontawesome-webfont.ttf how can I put links to the font package ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191319] New: Branch Request: ddclient
https://bugzilla.redhat.com/show_bug.cgi?id=1191319 Bug ID: 1191319 Summary: Branch Request: ddclient Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: i...@cicku.me QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org This is the branch request of package ddclient. Package Change Request == Package Name: ddclient New Branches: epel7 Owners: cicku -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191212] New: Review Request: nodejs-cli-table - Pretty unicode tables for the CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1191212 Bug ID: 1191212 Summary: Review Request: nodejs-cli-table - Pretty unicode tables for the CLI Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: rb...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://ralph.fedorapeople.org//nodejs-cli-table.spec SRPM URL: http://ralph.fedorapeople.org//nodejs-cli-table-0.3.1-1.fc21.src.rpm Description: This utility allows you to render unicode-aided tables on the command line from your node.js scripts. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191212] Review Request: nodejs-cli-table - Pretty unicode tables for the CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1191212 Ralph Bean rb...@redhat.com changed: What|Removed |Added Blocks||1115680 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1115680 [Bug 1115680] Review Request: nodejs-jscs - JavaScript Code Style -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115680] Review Request: nodejs-jscs - JavaScript Code Style
https://bugzilla.redhat.com/show_bug.cgi?id=1115680 Ralph Bean rb...@redhat.com changed: What|Removed |Added Depends On||1191212 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1191212 [Bug 1191212] Review Request: nodejs-cli-table - Pretty unicode tables for the CLI -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115680] Review Request: nodejs-jscs - JavaScript Code Style
https://bugzilla.redhat.com/show_bug.cgi?id=1115680 --- Comment #6 from Ralph Bean rb...@redhat.com --- Thanks Piotr! Here's the latest upstream with adjustments that address your concerns (except the man page, which I'll omit). Now just blocking on other dependencies for this one. Spec URL: http://threebean.org/rpm/SPECS/nodejs-jscs.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-jscs-1.11.2-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #3 from MartinKG mgans...@alice.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-livestreamer.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-livestreamer-1.11.1-2.fc21.src.rpm %changelog * Tue Feb 10 2015 Martin Gansser marti...@fedoraproject.org - 1.11.1-2 - Removd bundled fonts - Add fontawesome-fonts requires. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1183258] Review Request: perl-Bytes-Random-Secure - Perl extension to generate cryptographically-secure random bytes
https://bugzilla.redhat.com/show_bug.cgi?id=1183258 --- Comment #1 from Petr Šabata psab...@redhat.com --- Missing BR: - English, t/04-perlcritic.t:7 Suggested BR/R version constraint: - MIME::QuotedPrint: 3.03, from META.* Filter out the unversioned Scalar::Util dependency. No other issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129677] Review Request: gstreamer1-rtsp-server - gstreamer rtsp server version 1.x
https://bugzilla.redhat.com/show_bug.cgi?id=1129677 Debarshi Ray debars...@redhat.com changed: What|Removed |Added CC||debars...@redhat.com --- Comment #14 from Debarshi Ray debars...@redhat.com --- Are we only blocking on a sponsor for Stefan? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107800] Review Request: dl_poly - General purpose classical molecular dynamics (MD) simulation
https://bugzilla.redhat.com/show_bug.cgi?id=1107800
--- Comment #10 from Dave Love d.l...@liverpool.ac.uk ---
(In reply to Orion Poplawski from comment #9)
It could if there was a decision to change default ownership. It's unneeded
cruft in any case. While it's in the /etc/rpmdevtools/spectemplate* files,
rpmdev-newspec will remove it. Or did you get a template from elsewhere?
It was from that via Emacs C-x C-f, but I realize it's an old version of
devtools, but the latest that would install on RHEL6, since it's not in EPEL.
You can add (some) options if you'd like. In particular you're welcome to
add -ffast-math -funroll-loops.
I think the rules say you need to ask for a special exception.
-funroll-loops really should be in default FFLAGS.
I don't think anyone can rely on distro packages to get top performance
though.
In some cases I hope you can, but I'd at least hope to be able to rebuild with,
say, -march=native added to xFLAGS.
- Use %{?_isa} in Requires.
Done, but could confuse a stupid person, since the packages I looked
at originally didn't have it, and I don't remember seeing it in the
instructions.
I don't see this done, so to be explicit:
Apologies. I was sure I had done it...
- I don't think you need to duplicate the main description in all of the
sub-packages
- Use %global
I'm confused as I thought that's what I had done.
%define dobuild \
mkdir $MPI_COMPILER;\
make %{?_smp_mflags} build PAR=1 FFLAGS=-c %{optflags} %{native};\
mv ../execute/DLPOLY.X $MPI_COMPILER/%{name}$MPI_SUFFIX
should be %global dobuild ...
Oh, I see. I think the build fragment was copied from the MPI instructions
rather long ago; fixed. I've modified some of the descriptions and summaries
to be more in line with what I normally do now.
It's a pity fedora-review doesn't work in EPEL.
That is too bad. Is there a bug filed against it?
I don't remember. I don't know whether it's even supposed to work.
In haste, but I hope I updated correctly this time in
SRPM:
https://loveshack.fedorapeople.org/review/dl_poly-1.9.20140324-6.el6.src.rpm
SPEC: https://loveshack.fedorapeople.org/review/dl_poly.spec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 --- Comment #3 from Ralph Bean rb...@redhat.com --- Thanks for the review, Piotr! Here's a new release that that addresses your three comments: Spec URL: http://threebean.org/rpm/SPECS/nodejs-supports-color.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-supports-color-1.2.0-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191212] Review Request: nodejs-cli-table - Pretty unicode tables for the CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1191212 --- Comment #1 from Ralph Bean rb...@redhat.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8886443 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- tfdocgen-20150202git-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/tfdocgen-20150202git-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169793] Review Request: libstemmer - C stemming algorithm library
https://bugzilla.redhat.com/show_bug.cgi?id=1169793 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- libstemmer-0-2.585svn.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/libstemmer-0-2.585svn.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188648] Review Request: perl-Palm - Palm OS utility functions
https://bugzilla.redhat.com/show_bug.cgi?id=1188648 Emmanuel Seyman emman...@seyman.fr changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2015-02-10 05:41:37 --- Comment #8 from Emmanuel Seyman emman...@seyman.fr --- Built for rawhide and mashed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191042] New: Review Request: perl-MouseX-App-Cmd - Mashes up MouseX::Getopt and App::Cmd
https://bugzilla.redhat.com/show_bug.cgi?id=1191042 Bug ID: 1191042 Summary: Review Request: perl-MouseX-App-Cmd - Mashes up MouseX::Getopt and App::Cmd Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: emman...@seyman.fr QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://people.parinux.org/~seyman/fedora/perl-MouseX-App-Cmd/perl-MouseX-App-Cmd.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-MouseX-App-Cmd/perl-MouseX-App-Cmd-0.30-1.fc21.src.rpm Description: This module marries App::Cmd with MouseX::Getopt. Fedora Account System Username: eseyman Rpmlint output: perl-MouseX-App-Cmd.src: W: spelling-error Summary(en_US) Getopt - Get opt, Get-opt, Treetop perl-MouseX-App-Cmd.src: W: spelling-error %description -l en_US Getopt - Get opt, Get-opt, Treetop 1 packages and 1 specfiles checked; 0 errors, 2 warnings. MouseX-App-Cmd was split off in its own distribution in version 0.30 of MooseX-App-Cmd. Before updating to that version, I'ld like to add this package so that Fedora installations do not stop working. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902086] Review request: Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=902086 --- Comment #67 from jiri vanek jva...@redhat.com --- One colleague of me have packed optional build requirements, which are now xpathed out of pom. https://bugzilla.redhat.com/show_bug.cgi?id=1190728 https://bugzilla.redhat.com/show_bug.cgi?id=1190746 https://bugzilla.redhat.com/show_bug.cgi?id=1190733 https://bugzilla.redhat.com/show_bug.cgi?id=1190735 https://bugzilla.redhat.com/show_bug.cgi?id=1190740 They do not block release, but will be worthy to be included. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 --- Comment #3 from Lubomir Rintel lkund...@v3.sk --- Thank you (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) Issues: === - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in massif-visualizer See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database Fixed. - The license is GPLv2+. The sources might be mixed license, but the resulting binary can only be under GPL, so there's no need to make things complicated. Fixed. - Please add an appdata file [https://fedoraproject.org/wiki/Packaging:AppData]. I suggest you use appstream-util validate (w/o -relax) while developing it, but leave validate-relax in the spec file. Seems like it's SHOULD now. Given massif-visualizer targets hackers who are likely able to install the tool in a different way than GNOME software I don't believe it's worth patching the appdata file now. I've contacted upstream and asked them to add the appdata file, offering help if they need any. Could we do without the appdata file now and assume upstream is going to include it in a later version anyway? SPEC: http://v3.sk/~lkundrak/SPECS/massif-visualizer.spec SRPM: http://v3.sk/~lkundrak/SRPMS/massif-visualizer-0.4.0-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191058] Review Request: jenkins-guice - A lightweight dependency injection framework for Java 6 and above
https://bugzilla.redhat.com/show_bug.cgi?id=1191058 Michal Srb m...@redhat.com changed: What|Removed |Added Blocks||1147899 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1147899 [Bug 1147899] jenkins: maven-project plugin doesn't work -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471 --- Comment #16 from Peter Lemenkov lemen...@gmail.com --- (In reply to Jan Chaloupka from comment #15) Added: -devel subpackage -%repo, %provider, ... global variables Otherwise it looks good. Updated the package according to your comments (and added one additional patch): * https://peter.fedorapeople.org/fleet.spec * https://peter.fedorapeople.org/fleet-0.9.0-4.fc21.src.rpm Here is a scratchbuild for Rawhide: * http://koji.fedoraproject.org/koji/taskinfo?taskID=8883895 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471 --- Comment #17 from Jan Chaloupka jchal...@redhat.com --- I forget to add Requires to devel packages for all its BuildRequires. So when you install fleet devel subpackage, you must install all its deps if fleet devel happens to be a buildtime dependency of another package: Requires:golang(google.golang.org/api/googleapi) Requires:golang(github.com/coreos/go-semver/semver) Requires:golang(github.com/coreos/go-systemd/activation) Requires:golang(github.com/coreos/go-systemd/dbus) Requires:golang(github.com/coreos/go-systemd/unit) Requires:golang(github.com/docker/libcontainer/netlink) Requires:golang(github.com/godbus/dbus) Requires:golang(github.com/jonboulle/clockwork) Requires:golang(github.com/rakyll/globalconf) Requires:golang(github.com/rakyll/goini) Requires:golang(golang.org/x/crypto/ssh) Please add those below BuildRequires of devel subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #18 from Jan Chaloupka jchal...@redhat.com --- Otherwise spec file complies with Go packaging draft [1] [1] https://fedoraproject.org/wiki/PackagingDrafts/Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #19 from Peter Lemenkov lemen...@gmail.com --- (In reply to Jan Chaloupka from comment #17) I forget to add Requires to devel packages for all its BuildRequires. So when you install fleet devel subpackage, you must install all its deps if fleet devel happens to be a buildtime dependency of another package: Requires: golang(google.golang.org/api/googleapi) Requires: golang(github.com/coreos/go-semver/semver) Requires: golang(github.com/coreos/go-systemd/activation) Requires: golang(github.com/coreos/go-systemd/dbus) Requires: golang(github.com/coreos/go-systemd/unit) Requires: golang(github.com/docker/libcontainer/netlink) Requires: golang(github.com/godbus/dbus) Requires: golang(github.com/jonboulle/clockwork) Requires: golang(github.com/rakyll/globalconf) Requires: golang(github.com/rakyll/goini) Requires: golang(golang.org/x/crypto/ssh) Please add those below BuildRequires of devel subpackage. Done (didn't raise the %release number though). * https://peter.fedorapeople.org/fleet.spec * https://peter.fedorapeople.org/fleet-0.9.0-4.fc21.src.rpm (In reply to Jan Chaloupka from comment #18) Otherwise spec file complies with Go packaging draft [1] [1] https://fedoraproject.org/wiki/PackagingDrafts/Go Thanks! New Package SCM Request === Package Name: fleet Short Description: A distributed init system Upstream URL: https://github.com/coreos/fleet/ Owners: peter lsm5 jchaloup vbatts Branches: f21 epel7 InitialCC: golang-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190728] Review Request: forbidden-apis - Checks Java byte code against a list of forbidden API signatures.
https://bugzilla.redhat.com/show_bug.cgi?id=1190728 --- Comment #5 from Alexander Kurtakov akurt...@redhat.com --- One more comment to make srpm actual url: Spec URL: http://www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis.spec SRPM URL: http://www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis-1.7-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190728] Review Request: forbiddenapis - Checks Java byte code against a list of forbidden API signatures.
https://bugzilla.redhat.com/show_bug.cgi?id=1190728 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added CC||akurt...@redhat.com Assignee|nob...@fedoraproject.org|akurt...@redhat.com Flags||fedora-review? --- Comment #1 from Alexander Kurtakov akurt...@redhat.com --- I'm taking this one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190728] Review Request: forbiddenapis - Checks Java byte code against a list of forbidden API signatures.
https://bugzilla.redhat.com/show_bug.cgi?id=1190728 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190728] Review Request: forbiddenapis - Checks Java byte code against a list of forbidden API signatures.
https://bugzilla.redhat.com/show_bug.cgi?id=1190728 --- Comment #2 from Alexander Kurtakov akurt...@redhat.com --- As an initial comment it's always good to match upstream name as closely as possible - so renaming from forbiddenapis to forbidden-apis would make it easier for people following upstrame name to find the fedora package. Detailed review to follow when this one is fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1091659] Review Request: iwyu - #include analysis tool
https://bugzilla.redhat.com/show_bug.cgi?id=1091659
--- Comment #22 from Pierre-YvesChibon pin...@pingoured.fr ---
sed -i '1 s|^#!/usr/bin/python\b|#!%{__python2}|' fix_includes.py
Did you check that the macro is correctly expanded by sed?
(ie: that the file has #!/usr/bin/python2 and no directly #!%{__python2})
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190728] Review Request: forbidden-apis - Checks Java byte code against a list of forbidden API signatures.
https://bugzilla.redhat.com/show_bug.cgi?id=1190728 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Summary|Review Request: |Review Request: |forbiddenapis - Checks Java |forbidden-apis - Checks |byte code against a list of |Java byte code against a |forbidden API signatures. |list of forbidden API ||signatures. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191058] New: Review Request: jenkins-guice - A lightweight dependency injection framework for Java 6 and above
https://bugzilla.redhat.com/show_bug.cgi?id=1191058 Bug ID: 1191058 Summary: Review Request: jenkins-guice - A lightweight dependency injection framework for Java 6 and above Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://msrb.fedorapeople.org/review/jenkins-guice.spec SRPM URL: https://msrb.fedorapeople.org/review/jenkins-guice-4.0-0.1.beta.fc22.src.rpm Description: This package contains version of Google Guice library used in Jenkins. Fedora Account System Username: msrb The purpose of this package is to fix #1147899 in F21. It provides Google Guice library in version 4.0.beta, but groupId has been changed so it won't interfere with current version of the library in the system. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191058] Review Request: jenkins-guice - A lightweight dependency injection framework for Java 6 and above
https://bugzilla.redhat.com/show_bug.cgi?id=1191058 Michal Srb m...@redhat.com changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190728] Review Request: forbiddenapis - Checks Java byte code against a list of forbidden API signatures.
https://bugzilla.redhat.com/show_bug.cgi?id=1190728 --- Comment #3 from zzamb...@redhat.com --- Here reneamed: Spec URL: http://www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis.spec SRPM URL: www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis-1.7-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191062] New: Review Request: nodejs-samsam - Value identification and comparison functions
https://bugzilla.redhat.com/show_bug.cgi?id=1191062 Bug ID: 1191062 Summary: Review Request: nodejs-samsam - Value identification and comparison functions Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: apa...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://anishpatil.fedorapeople.org/nodejs-samsam.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-samsam-1.1.2-1.fc21.src.rpm Description: samsam is a collection of predicate and comparison functions useful for identifying the type of values Fedora Account System Username:anishpatil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1189460] Review Request: dock - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1189460 --- Comment #2 from Tomas Tomecek ttome...@redhat.com --- Spec and srpm updated. Added python 3 package (which may be problematic: there are no python 3 builds of GitPython and koji) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190728] Review Request: forbidden-apis - Checks Java byte code against a list of forbidden API signatures.
https://bugzilla.redhat.com/show_bug.cgi?id=1190728 --- Comment #4 from Alexander Kurtakov akurt...@redhat.com --- Spec URL: http://www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis.spec SRPM URL: www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis-1.7-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191042] Review Request: perl-MouseX-App-Cmd - Mashes up MouseX::Getopt and App::Cmd
https://bugzilla.redhat.com/show_bug.cgi?id=1191042 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||fleet-0.9.0-4.fc22 Resolution|--- |RAWHIDE Last Closed||2015-02-10 08:46:41 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 --- Comment #5 from Ben Rosser rosser@gmail.com --- tfdocgen has been approved and built for F20, F21, and Rawhide. I've updated the spec file with the %license tag for this package: Spec File: https://tc01.fedorapeople.org/tilp2/libticonv.spec SRPM URL: https://tc01.fedorapeople.org/tilp2/libticonv-1.1.4-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- tfdocgen-20150202git-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/tfdocgen-20150202git-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169898] Review Request: kbrickbuster - Destroy bricks with a ball
https://bugzilla.redhat.com/show_bug.cgi?id=1169898 --- Comment #6 from Ngo Than t...@redhat.com --- i uploaded new spec and srpm, it fixes 1 and 2. Spec URL: https://than.fedorapeople.org/f21/kbrickbuster.spec SRPM URL: https://than.fedorapeople.org/f21/kbrickbuster-4.14.3-1.fc21.src.rpm Rex, could you please review it? Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129677] Review Request: gstreamer1-rtsp-server - gstreamer rtsp server version 1.x
https://bugzilla.redhat.com/show_bug.cgi?id=1129677 --- Comment #15 from Stefan Ringel m...@stefanringel.de --- yes, I think. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1183258] Review Request: perl-Bytes-Random-Secure - Perl extension to generate cryptographically-secure random bytes
https://bugzilla.redhat.com/show_bug.cgi?id=1183258 --- Comment #2 from David Dick dd...@cpan.org --- Done. Fixes uploaded Spec URL: https://ddick.fedorapeople.org/packages/perl-Bytes-Random-Secure.spec SRPM URL: https://ddick.fedorapeople.org/packages/perl-Bytes-Random-Secure-0.28-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1189460] Review Request: dock - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1189460
--- Comment #3 from Jiri Popelka jpope...@redhat.com ---
s/%doc LICENSE/%license LICENSE/
Please comment (in spec) why
/usr/share/dock/images/privileged-builder/docker.sh
is not executable and why there's dock.tar.gz shipped ?
(In reply to Tomas Tomecek from comment #2)
Spec and srpm updated.
Next time please bump Release tag.
Added python 3 package
partially ;-)
You're missing:
%prep
%if 0%{?with_python3}
rm -rf %{py3dir}
cp -a . %{py3dir}
find %{py3dir} -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|'
%endif # with_python3
%build
%if 0%{?with_python3}
pushd %{py3dir}
%{__python3} setup.py build
popd
%endif # with_python3
%install
%if 0%{?with_python3}
pushd %{py3dir}
%{__python3} setup.py install --skip-build --root %{buildroot}
popd
%endif # with_python3
then use
%{python2_sitelib}
in %files
and
%{python2_sitelib}
in
%files -n python3-dock
https://fedoraproject.org/wiki/Packaging:Python#Guidelines
(which may be problematic: there are no python 3 builds of GitPython and koji)
Then don't define with_python3 until there are python3 versions of GitPython
koji.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1189460] Review Request: dock - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1189460 --- Comment #5 from Tomas Tomecek ttome...@redhat.com --- Oh, now I remember why I hated packaging. Will respin tomorrow. (I commented wrt dock.tar.gz within spec, not at files section) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1162234] Review Request: nss-securepass - NSS library for SecurePass.
https://bugzilla.redhat.com/show_bug.cgi?id=1162234 --- Comment #19 from Giuseppe Paterno' gpate...@gpaterno.com --- Hello! For 1) I have to apologise as I forgot to sync with upstream fixes. In the new package I also moved to the new release schema that has been adopted upstream. The reason is 0600 as the securepass.conf contains the private keys to access the server. I want this to be secure by default, so that the sysadmin is forcing the read attribute only if he/she needs it for other applications. I think I fixed the other suggestions. Builds are ok on koji. New files: SPEC: https://gpaterno.fedorapeople.org/nss-securepass.spec SRPM: https://gpaterno.fedorapeople.org/nss-securepass-0.2-5.el6.src.rpm Thanks a lot! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 Till Maas opensou...@till.name changed: What|Removed |Added CC||opensou...@till.name --- Comment #13 from Till Maas opensou...@till.name --- (In reply to Pierre-YvesChibon from comment #12) This is weird, Jehane did not get commit on any of the Fedora branches. I will fix things directly in pkgdb, but there is something odd going on here. It might be that a Package Change Request (or similar) is needed instead of a New Package SCM Request. Or it needs to be spotted manually by the process-git-process operator. Nevertheless, it will all get better with the new process. :-). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|ASSIGNED|POST Flags|needinfo?(i...@cicku.me) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Christopher Meng i...@cicku.me changed: What|Removed |Added CC||i...@cicku.me Blocks||182235 (FE-Legal) --- Comment #4 from Christopher Meng i...@cicku.me --- I'm afraid Fedora doesn't accept it, asking legal. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1178912] Review Request: cairo-dock-plug-ins - Plug-ins files for Cairo-Dock
https://bugzilla.redhat.com/show_bug.cgi?id=1178912
--- Comment #27 from Mamoru TASAKA mtas...@fedoraproject.org ---
1. It seems unfortunate to split CDBashApplet.{py,sh}.
Well, this makes more complicated packaging... Splitting these
must not be avoidable because python2/3 bindings are provided.
Instead -dbus subpackage is newly created.
2. I cannot find a reason why cairo-dock-vala-devel needs
to depend on cairo-dock-plug-ins
Directory ownership, but actually depends on dbus (changed on -12)
https://mtasaka.fedorapeople.org/Review_request/cairo-dock/cairo-dock-plug-ins.spec
https://mtasaka.fedorapeople.org/Review_request/cairo-dock/cairo-dock-plug-ins-3.4.0-12.fc.src.rpm
* Wed Feb 11 2015 Mamoru TASAKA mtas...@fedoraproject.org - 3.4.0-12
- Split out Dbus subpackage, modify internal dependency
- Make some package noarch
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179237] Review Request: kf5-kpackage - KDE Frameworks 5 Tier 2 library to load and install packages as plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1179237 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2015-02-10 09:49:12 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Lubomir Rintel lkund...@v3.sk --- Thank you! New Package SCM Request === Package Name: massif-visualizer Short Description: Visualizer for Massif heap memory profiler data files Upstream URL: https://projects.kde.org/massif-visualizer Owners: lkundrak Branches: f20 f21 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190728] Review Request: forbidden-apis - Checks Java byte code against a list of forbidden API signatures.
https://bugzilla.redhat.com/show_bug.cgi?id=1190728 jiri vanek jva...@redhat.com changed: What|Removed |Added CC||jva...@redhat.com --- Comment #7 from jiri vanek jva...@redhat.com --- Please when requesting for repo, request both f22 and rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187713] netty-tcnative
https://bugzilla.redhat.com/show_bug.cgi?id=1187713 --- Comment #19 from jiri vanek jva...@redhat.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #18) (In reply to jiri vanek from comment #17) (In reply to Zbigniew Jędrzejewski-Szmek from comment #16) The patch to load libraries is wrong. It makes the jar file architecture dependent, yes, intentionally but it should not be. Just try loading from /usr/lib64, and then from /usr/lib. This will work on both 64 and 32 bit archs. Well - this patch is fedora only, and fedora do not support multilib jni packages (http://fedoraproject.org/wiki/Packaging: Java#Packaging_JAR_files_that_use_JNI - uttermost end - . Java packages using JNI do not support multiarch installation. Although I see your point, I would rather stay with my approach - to fail immediately if wrong arch is found. If you disagree, and insists, I will follow your opinion. I do disagree. It generates an unnecessary conflict (which is detected only during transaction check, which is nasty for users): $ sudo dnf install results/netty-tcnative-1.1.30-0.fc22.x86_64.rpm ... Error: Transaction check error: file /usr/lib/java/netty-tcnative/netty-tcnative.jar from install of netty-tcnative-1.1.30-0.fc22.x86_64 conflicts with file from package netty-tcnative-1.1.30-0.fc22.i686 file /usr/share/maven-metadata/netty-tcnative.xml from install of netty-tcnative-1.1.30-0.fc22.x86_64 conflicts with file from package netty-tcnative-1.1.30-0.fc22.i686 ...snip... This seems unnecessary. This seems to be autoadded -javadoc should be noarch! I think it might go away when the package is noarch. javadoc made noarch. spec: https://jvanek.fedorapeople.org/elasticsearch/v4/netty-tcnative/netty-tcnative.spec srpm: https://jvanek.fedorapeople.org/elasticsearch/v4/netty-tcnative/netty-tcnative-1.1.30-0.fc21.src.rpm Last thing we disagree is the arch/noarch lib/path/lib64 convention. I'm still keeping my approach, beacuse I somehow feel that what you wont me to do is wrong: - from fedora guidelines the multilib jni packages are not supported - my main package contains both jar and nativelib = not noarch if I split natvie and java files to two packages and made jar multilib (search in both lib and lib64) then yes, your case you shown with dnf will work. However, - the multilib is not supposed to be supported - there is real danger that jar run in 64 jvm will load 32b library or vice versa (afaik it is why jni is not supported multilib) - the jar without so and vice versa dont have sense. Thank you for patience! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471 --- Comment #20 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). FYI, there is no 'c' in any of the branch names, and rawhide is automatic. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191058] Review Request: jenkins-guice - A lightweight dependency injection framework for Java 6 and above
https://bugzilla.redhat.com/show_bug.cgi?id=1191058 Michal Srb m...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Blocks|652183 (FE-JAVASIG),| |1147899 | Resolution|--- |NOTABUG Last Closed||2015-02-10 08:18:04 --- Comment #1 from Michal Srb m...@redhat.com --- After today's discussion with rest of the Java team, I decided to handle this differently. Closing as NOTABUG. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug https://bugzilla.redhat.com/show_bug.cgi?id=1147899 [Bug 1147899] jenkins: maven-project plugin doesn't work -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191068] New: Review Request: - nodejs-formatio-Human-readable object formatting
https://bugzilla.redhat.com/show_bug.cgi?id=1191068 Bug ID: 1191068 Summary: Review Request: - nodejs-formatio-Human-readable object formatting Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: apa...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://anishpatil.fedorapeople.org/nodejs-formatio.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-formatio-1.1.2-1.fc21.src.rpm Description: Pretty formatting of arbitrary JavaScript values. Currently only supports ascii formatting Fedora Account System Username:anishpatil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190728] Review Request: forbidden-apis - Checks Java byte code against a list of forbidden API signatures.
https://bugzilla.redhat.com/show_bug.cgi?id=1190728 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191062] Review Request: nodejs-samsam - Value identification and comparison functions
https://bugzilla.redhat.com/show_bug.cgi?id=1191062 anish apa...@redhat.com changed: What|Removed |Added Blocks||1191068 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1191068 [Bug 1191068] Review Request: - nodejs-formatio-Human-readable object formatting -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191068] Review Request: - nodejs-formatio-Human-readable object formatting
https://bugzilla.redhat.com/show_bug.cgi?id=1191068 anish apa...@redhat.com changed: What|Removed |Added Depends On||1191062 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1191062 [Bug 1191062] Review Request: nodejs-samsam - Value identification and comparison functions -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190728] Review Request: forbidden-apis - Checks Java byte code against a list of forbidden API signatures.
https://bugzilla.redhat.com/show_bug.cgi?id=1190728
--- Comment #6 from Alexander Kurtakov akurt...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated. 3 files have unknown license.
Detailed output of licensecheck in /home/akurtakov/tmp/1190728-forbidden-
apis/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/java/forbidden-apis, /usr/share/maven-
poms/forbidden-apis
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/maven-poms/forbidden-
apis, /usr/share/java/forbidden-apis
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Java:
[x]: Bundled jar/class files should be removed before build
Note: Test run failed
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[x]: If the source package
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- (In reply to Lubomir Rintel from comment #3) - Please add an appdata file [https://fedoraproject.org/wiki/Packaging:AppData]. I suggest you use appstream-util validate (w/o -relax) while developing it, but leave validate-relax in the spec file. Seems like it's SHOULD now. Given massif-visualizer targets hackers who are likely able to install the tool in a different way than GNOME software I don't believe it's worth patching the appdata file now. I've contacted upstream and asked them to add the appdata file, offering help if they need any. Could we do without the appdata file now and assume upstream is going to include it in a later version anyway? Makes sense. SPEC: http://v3.sk/~lkundrak/SPECS/massif-visualizer.spec SRPM: http://v3.sk/~lkundrak/SRPMS/massif-visualizer-0.4.0-3.fc21.src.rpm fedora-review has nothing interesting to say. The only thing is mime datebase snippets: they are different than those on http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo. Is this on purpose? Rpmlint --- Checking: massif-visualizer-0.4.0-3.fc22.x86_64.rpm massif-visualizer-0.4.0-3.fc22.src.rpm massif-visualizer.x86_64: W: spelling-error Summary(en_US) profiler - profile, profiles, profiled massif-visualizer.x86_64: W: spelling-error %description -l en_US pid - peed, dip, pud massif-visualizer.x86_64: W: spelling-error %description -l en_US Gzip - Zip, G zip, Grip massif-visualizer.x86_64: W: no-manual-page-for-binary massif-visualizer massif-visualizer.src: W: spelling-error Summary(en_US) profiler - profile, profiles, profiled massif-visualizer.src: W: spelling-error %description -l en_US pid - peed, dip, pud massif-visualizer.src: W: spelling-error %description -l en_US Gzip - Zip, G zip, Grip 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 Pierre-YvesChibon pin...@pingoured.fr changed: What|Removed |Added CC||pin...@pingoured.fr --- Comment #12 from Pierre-YvesChibon pin...@pingoured.fr --- This is weird, Jehane did not get commit on any of the Fedora branches. She got listed as PoC for master and el6 (that she had before). She got 'Awaiting Review' approveacls on master (she had el6 before). She got all the watch* ACLs on all branches but no commit ACL on any branch. The action from the script can be found there: https://admin.fedoraproject.org/pkgdb/package/fusioninventory-agent/timeline#n21 I will fix things directly in pkgdb, but there is something odd going on here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
