[Bug 1214834] Review Request:fbb - Packet radio mailbox and utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1214834
Jan Synacek changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||jsyna...@redhat.com
Assignee|nob...@fedoraproject.org|jsyna...@redhat.com
--- Comment #1 from Jan Synacek ---
Issues:
===
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /var/lib/fbb
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file COPYING is marked as %doc instead of %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later) (with incorrect FSF address)", "*No
copyright* GPL (v2 or later) (with incorrect FSF address)", "Unknown
or generated". 1 files have unknown license. Detailed output of
licensecheck in
/home/jsynacek/work/reviews/fbb/1214834-fbb/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/ax25
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 92160 bytes in 6 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fbb-doc
[ ]: Package functions as describe
[Bug 1211517] Review Request: docker-swarm - Docker-native clustering system
https://bugzilla.redhat.com/show_bug.cgi?id=1211517 --- Comment #11 from Michael Scherer --- The fpc ticket show a workaround. More ugly than what I believed however, but this can be defered for the EPEL6 package maybe ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219122] Review Request: rubygem-webkit-gtk - Ruby binding of WebKitGTK+ using GTK3
https://bugzilla.redhat.com/show_bug.cgi?id=1219122 Mamoru TASAKA changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #4 from Mamoru TASAKA --- $ fedpkg co rubygem-webkit-gtk Cloning into 'rubygem-webkit-gtk'... FATAL: R any rubygem-webkit-gtk mtasaka DENIED by fallthru (or you mis-spelled the reponame) fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Could not execute clone: Command '['git', 'clone', 'ssh://mtas...@pkgs.fedoraproject.org/rubygem-webkit-gtk', '--origin', 'origin']' returned non-zero exit status 128 cvs admin, would you check again? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889011] Review Request: rubygem-asciidoctor - AsciiDoc implementation in Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=889011 Dan Allen changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889011] Review Request: rubygem-asciidoctor - AsciiDoc implementation in Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=889011 --- Comment #31 from Dan Allen --- Package Change Request == Package Name: rubygem-asciidoctor Short Description: AsciiDoc implementation in Ruby New Branches: epel7 Owners: mojavelinux ktdreyer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1098965] Review Request: capstone - Multi-platform, multi-architecture disassembly framework.
https://bugzilla.redhat.com/show_bug.cgi?id=1098965
Stefan Cornelius changed:
What|Removed |Added
Attachment|0 |1
#1023527 is||
obsolete||
--- Comment #11 from Stefan Cornelius ---
Created attachment 1024818
--> https://bugzilla.redhat.com/attachment.cgi?id=1024818&action=edit
Addressed issued found during package audit.
(In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment
#10)
Thank you for the audit! New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=9717792
> > %files
> > %doc README LICENSE.TXT ChangeLog LICENSE_LLVM.TXT
>
> https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
Fixed by using %license
> > %files devel
> > %doc
>
> > %files java
> > %doc
>
> An empty %doc line is a no-op. Remember, %doc is not a section in the spec
> file like %build or %install.
Fixed by removing %doc.
> > %{_includedir}/*
> > %exclude %{_libdir}
> > %{_libdir}/*.so
> > %{_libdir}/pkgconfig/*
>
> So, somebody added this unusual %exclude line without commenting on it
> anywhere in the spec file. The %changelog doesn't tell why this was added.
> IMO, it is the cause of a broken build as it hides files that ought to be
> packaged. Just examine the contents of the capstone-devel package. There is
> no build-time library!
Can't explain this one. brainfart? Fixed.
> > %{_javadir}/
> > %{_javadir}/%{name}.jar
>
> The first line already includes %{_javadir} and everything in it. The second
> line is redundant.
>
Fixed by removing redundant line.
> > https://kojipkgs.fedoraproject.org//work/tasks/6949/9686949/build.log
>
> Notice the errors in make check. Solution: Adjust runtime linker's search
> path to make it find the freshly build shared lib.
Fixed by adopting the search path, as suggested. All checks work and pass now.
>
> > + make -j16
> > CC cs.o
> > CC MCInstrDesc.o
> > CC SStream.o
> > CC utils.o
>
> Build output is non-verbose. One cannot verify which compiler flags have
> been used actually:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
Fixed by enabling verbose mode.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810376] Review Request: python-pypng - Python PNG encoder/decoder
https://bugzilla.redhat.com/show_bug.cgi?id=810376 --- Comment #27 from Matthew Miller --- Pete, it looks like the package is approved and pushed in the other bug. I'm sure Ralph would be happy for a comaintainer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810376] Review Request: python-pypng - Python PNG encoder/decoder
https://bugzilla.redhat.com/show_bug.cgi?id=810376 --- Comment #26 from Pete Zaitcev --- Sadly I know of no alternative. I need to generate some kind of picture http://zaitcev.livejournal.com/220516.html https://github.com/zaitcev/glie I'm open to co-maintaining it in Fedora. I don't have a PP bit, but I have several packages, including Python based. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193923] Review Request: mbedtls - polarssl package renaming process
https://bugzilla.redhat.com/show_bug.cgi?id=1193923 --- Comment #8 from Morten Stevens --- Okay, please check the latest srpm and spec file. All complaints should be resolved. https://mstevens.fedorapeople.org/mbedtls/mbedtls-1.3.10-1.fc23.src.rpm https://mstevens.fedorapeople.org/mbedtls/mbedtls.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215732] Review Request: pypy3 - Python 3 implementation with a Just-In-Time compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1215732 --- Comment #26 from Fedora Update System --- pypy3-2.4.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/pypy3-2.4.0-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215732] Review Request: pypy3 - Python 3 implementation with a Just-In-Time compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1215732 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215732] Review Request: pypy3 - Python 3 implementation with a Just-In-Time compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1215732 --- Comment #25 from Fedora Update System --- pypy3-2.4.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/pypy3-2.4.0-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1204447] Review Request: python-geoip-geolite2 - GeoIP database access for Python under a BSD license
https://bugzilla.redhat.com/show_bug.cgi?id=1204447
--- Comment #9 from Julien Enselme ---
@Eduardo: I guess I was stuck with the old version.
- Changelog: OK
- %files: almost there. fedora-review spotted a directory without an owner:
_geoip_geolite2. You must remove the * after
%{python2_sitelib}/_geoip_geolite2/ to add both the directory and its content.
Below is the output of fedora-review:
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python2.7/site-
packages/_geoip_geolite2
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python2.7/site-
packages/_geoip_geolite2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219970] Review Request: petera - Tool for binding data and disks to a network
https://bugzilla.redhat.com/show_bug.cgi?id=1219970 Patrick Uiterwijk changed: What|Removed |Added CC||puiterw...@redhat.com Flags|needinfo?(limburgher@gmail. | |com)| --- Comment #7 from Patrick Uiterwijk --- This is caused by the script that generates the repositories after the package is created taking some time to run. You will get a fedmsg message automatically when the repo is created. If it still doesn't exist in about an hour or so, please ping me (puiterwijk) on #fedora-admin. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1210978] Review Request: python-contextlib2 - Backports and enhancements for the contextlib module
https://bugzilla.redhat.com/show_bug.cgi?id=1210978 --- Comment #11 from Fedora Update System --- python-contextlib2-0.4.0-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1211831] Review Request: copyq - Advanced Qt based clipboard manager
https://bugzilla.redhat.com/show_bug.cgi?id=1211831 Fedora Update System changed: What|Removed |Added Fixed In Version|copyq-2.4.6-4.fc22 |copyq-2.4.6-5.fc21 --- Comment #60 from Fedora Update System --- copyq-2.4.6-5.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1214840] Review Request: python-statsd - Python client for the statsd daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1214840 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-statsd-2.1.2-2.fc21 Resolution|--- |ERRATA Last Closed||2015-05-12 16:48:31 --- Comment #17 from Fedora Update System --- python-statsd-2.1.2-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1211362] Review Request: wildmagic5 - Wild Magic libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1211362 Fedora Update System changed: What|Removed |Added Fixed In Version|wildmagic5-5.13-9.fc22 |wildmagic5-5.13-9.fc21 --- Comment #33 from Fedora Update System --- wildmagic5-5.13-9.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1216055] Review Request: ardour4 - Digital Audio Workstation
https://bugzilla.redhat.com/show_bug.cgi?id=1216055 Fedora Update System changed: What|Removed |Added Fixed In Version|ardour4-4.0.0-2.fc22|ardour4-4.0.0-2.fc21 --- Comment #18 from Fedora Update System --- ardour4-4.0.0-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1210978] Review Request: python-contextlib2 - Backports and enhancements for the contextlib module
https://bugzilla.redhat.com/show_bug.cgi?id=1210978 --- Comment #10 from Fedora Update System --- python-contextlib2-0.4.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177442] Review Request: jbosh - XEP-0124: Bidirectional-streams Over Synchronous HTTP (BOSH)
https://bugzilla.redhat.com/show_bug.cgi?id=1177442 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jbosh-0.8.0-1.fc21 Resolution|--- |ERRATA Last Closed||2015-05-12 16:41:37 --- Comment #13 from Fedora Update System --- jbosh-0.8.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191498] Review Request: safelease - Legacy locking utility for VDSM
https://bugzilla.redhat.com/show_bug.cgi?id=1191498 --- Comment #21 from Fedora Update System --- safelease-1.0-4.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1191498] Review Request: safelease - Legacy locking utility for VDSM
https://bugzilla.redhat.com/show_bug.cgi?id=1191498 --- Comment #20 from Fedora Update System --- safelease-1.0-4.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127967] Review Request: python-releases - A Sphinx extension for changelog manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1127967 Bug 1127967 depends on bug 1124111, which changed state. Bug 1124111 Summary: Review Request: python-spec - Specification-style output for python2-nose https://bugzilla.redhat.com/show_bug.cgi?id=1124111 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1124111] Review Request: python-spec - Specification-style output for python2-nose
https://bugzilla.redhat.com/show_bug.cgi?id=1124111 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-spec-1.0.0-1.fc22 Resolution|--- |ERRATA Last Closed||2015-05-12 16:35:47 --- Comment #15 from Fedora Update System --- python-spec-1.0.0-1.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219970] Review Request: petera - Tool for binding data and disks to a network
https://bugzilla.redhat.com/show_bug.cgi?id=1219970 Nathaniel McCallum changed: What|Removed |Added CC||limburg...@gmail.com Flags||needinfo?(limburgher@gmail. ||com) --- Comment #6 from Nathaniel McCallum --- $ fedpkg clone petera Cloning into 'petera'... FATAL: R any petera npmccallum DENIED by fallthru (or you mis-spelled the reponame) fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Could not execute clone: Command '['git', 'clone', 'ssh://npmccal...@pkgs.fedoraproject.org/petera', '--origin', 'origin']' returned non-zero exit status 128 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021721] Review Request: python-salttesting - Testing library for SaltStack projects
https://bugzilla.redhat.com/show_bug.cgi?id=1021721 --- Comment #23 from Erik Johnson --- I'll have a look at this soon hopefully. I am responsible for a lot of things at work, and packaging has not been the highest priority. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219970] Review Request: petera - Tool for binding data and disks to a network
https://bugzilla.redhat.com/show_bug.cgi?id=1219970 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219970] Review Request: petera - Tool for binding data and disks to a network
https://bugzilla.redhat.com/show_bug.cgi?id=1219970 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1217857] Review Request: bandit - A framework for performing security analysis of Python source code
https://bugzilla.redhat.com/show_bug.cgi?id=1217857 --- Comment #10 from Michael Scherer --- Nope, still not working :/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177055] Tracker mesos - Cluster Manager to epel7
https://bugzilla.redhat.com/show_bug.cgi?id=1177055 --- Comment #14 from Ratnadeep Debnath --- Hey Timothy, I have uploaded the above packages to: https://rtnpro.fedorapeople.org/mesos/ as well. Looking forward for your feedback. Regards, rtnpro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219970] Review Request: petera - Tool for binding data and disks to a network
https://bugzilla.redhat.com/show_bug.cgi?id=1219970 Nathaniel McCallum changed: What|Removed |Added CC||nathan...@natemccallum.com Flags||fedora-cvs? --- Comment #4 from Nathaniel McCallum --- New Package SCM Request === Package Name: petera Short Description: Tool for binding data and disks to a network Upstream URL: https://github.com/npmccallum/petera Owners: npmccallum Branches: f22 f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219970] Review Request: petera - Tool for binding data and disks to a network
https://bugzilla.redhat.com/show_bug.cgi?id=1219970
Rob Crittenden changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Rob Crittenden ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane.
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in petera-
server
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /u
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 --- Comment #10 from Fedora Update System --- skylable-sx-1.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/skylable-sx-1.1-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220131] Review Request: perl-Test-Deep-Type - Test::Deep plugin for validating type constraints
https://bugzilla.redhat.com/show_bug.cgi?id=1220131 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220131] Review Request: perl-Test-Deep-Type - Test::Deep plugin for validating type constraints
https://bugzilla.redhat.com/show_bug.cgi?id=1220131 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186819] Review Request: burp - Network backup / restore program
https://bugzilla.redhat.com/show_bug.cgi?id=1186819 --- Comment #36 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186819] Review Request: burp - Network backup / restore program
https://bugzilla.redhat.com/show_bug.cgi?id=1186819 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957337] Review Request: jtoaster - Java utility class for swing applications
https://bugzilla.redhat.com/show_bug.cgi?id=957337 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957337] Review Request: jtoaster - Java utility class for swing applications
https://bugzilla.redhat.com/show_bug.cgi?id=957337 --- Comment #14 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219970] Review Request: petera - Tool for binding data and disks to a network
https://bugzilla.redhat.com/show_bug.cgi?id=1219970 Rob Crittenden changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219970] Review Request: petera - Tool for binding data and disks to a network
https://bugzilla.redhat.com/show_bug.cgi?id=1219970 Rob Crittenden changed: What|Removed |Added CC||rcrit...@redhat.com Assignee|nob...@fedoraproject.org|rcrit...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177055] Tracker mesos - Cluster Manager to epel7
https://bugzilla.redhat.com/show_bug.cgi?id=1177055 --- Comment #13 from Ratnadeep Debnath --- Hi Timothy, I have uploaded the RPMS for jetty, jtoaster, jdiff, checkstyle that I had built for epel7 here: https://www.dropbox.com/sh/y2awx8m5zj9n7j6/AADPBmH3-kSRQJqUNviEImhGa?dl=0 Please have a look and let me know if they are OK? If there's some thing that needs to be fixed, please let me know. Regards, rtnpro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810376] Review Request: python-pypng - Python PNG encoder/decoder
https://bugzilla.redhat.com/show_bug.cgi?id=810376 --- Comment #25 from Matthew Miller --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #24) > That's embarrassing. Heh. Well, happens sometimes. :) I forget what I even wanted this for, by now. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810376] Review Request: python-pypng - Python PNG encoder/decoder
https://bugzilla.redhat.com/show_bug.cgi?id=810376 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |DUPLICATE Last Closed||2015-05-12 13:03:14 --- Comment #24 from Zbigniew Jędrzejewski-Szmek --- That's embarrassing. *** This bug has been marked as a duplicate of bug 1096350 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096350] Review Request: python-pypng - Pure Python PNG image encoder/decoder
https://bugzilla.redhat.com/show_bug.cgi?id=1096350 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||mat...@redhat.com --- Comment #11 from Zbigniew Jędrzejewski-Szmek --- *** Bug 810376 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193923] Review Request: mbedtls - polarssl package renaming process
https://bugzilla.redhat.com/show_bug.cgi?id=1193923 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Flags|needinfo?(i...@cicku.me) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193923] Review Request: mbedtls - polarssl package renaming process
https://bugzilla.redhat.com/show_bug.cgi?id=1193923
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Assignee|i...@cicku.me |zbys...@in.waw.pl
--- Comment #7 from Zbigniew Jędrzejewski-Szmek ---
OK, since this a re-review, just the relevant points:
- spec file is nice and clean
- license is OK, but there's an additional exception. I think the license
should be 'GPLv2+ with exceptions', and a link provided to
https://tls.mbed.org/foss-license-exception in a comment. This extends
available options (compared to GPLv2+).
- provides/obsoletes are not OK:
According to
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages,
Obsoletes should have a concrete version number. It seems that %{?_isa} should
also be used, as the package is an arch dependent libary.
Obsoletes: polarssl%{?_isa} < 1.3.10
Provides: polarssl%{?_isa} = %{version}-%{release}
I tried upgrading a system with polarssl-devel installed. It fails:
Error: package polarssl-devel-1.3.9-3.fc22.x86_64 requires
libpolarssl.so.7()(64bit), but none of the providers can be installed
It seems that more obs/provs should be added:
In -devel:
Obsoletes: polarssl-devel%{?_isa} < 1.3.10
Provides: polarssl-devel%{?_isa} = %{version}-%{release}
In -utils:
Obsoletes: polarssl-utils < 1.3.10
Provides: polarssl-utils = %{version}-%{release}
I'm not 100% sure about the exact form though. Please check that upgrading
works :)
- doc subpackage should be noarch.
- I'd suggest adding:
%global _docdir_fmt %{name}
Currently there's /usr/share/doc/mbedtls with one file, and
/usr/share/doc/mbedtls-doc with the rest. No use to have two directories.
Some details pointed out by rpmlint:
mbedtls.src:67: W: macro-in-comment %check
mbedtls.src:45: W: mixed-use-of-spaces-and-tabs (spaces: line 26, tab: line 45)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186819] Review Request: burp - Network backup / restore program
https://bugzilla.redhat.com/show_bug.cgi?id=1186819 Andrew Niemantsverdriet changed: What|Removed |Added Flags||fedora-cvs? --- Comment #35 from Andrew Niemantsverdriet --- New Package SCM Request === Package Name: burp Short Description: A network-based backup and restore program Upstream URL: http://burp.grke.org/ Owners: kaptk2 Branches: f20 f21 f22 el5 el6 epel7 InitialCC: cicku -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220131] Review Request: perl-Test-Deep-Type - Test::Deep plugin for validating type constraints
https://bugzilla.redhat.com/show_bug.cgi?id=1220131 Emmanuel Seyman changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186819] Review Request: burp - Network backup / restore program
https://bugzilla.redhat.com/show_bug.cgi?id=1186819 gil cattaneo changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220131] Review Request: perl-Test-Deep-Type - Test::Deep plugin for validating type constraints
https://bugzilla.redhat.com/show_bug.cgi?id=1220131 Emmanuel Seyman changed: What|Removed |Added Flags||fedora-cvs+ --- Comment #4 from Emmanuel Seyman --- Once more, with the correct case. New Package SCM Request === Package Name: perl-Test-Deep-Type Short Description: Test::Deep plugin for validating type constraints Upstream URL: http://search.cpan.org/dist/Test-Deep-Type/ Owners: eseyman Branches: f22 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1165620] Review Request: biber - Command-line bibliographic manager, BibTeX replacement
https://bugzilla.redhat.com/show_bug.cgi?id=1165620
--- Comment #13 from Petr Šabata ---
So, after checking your long dep list:
Missing build-time dependencies:
- perl itself
- it is called in the spec file
- Log::Log4perl::Appender::File
- Log::Log4perl::Appender::Screen
- Log::Log4perl::Layout::PatternLayout
- Log::Log4perl::Layout::SimpleLayout
- these are via tests -> Biber -> Biber::Config
- re
- this is via tests -> Biber -> Biber::Utils
- Text::BibTeX::Name
- Text::BibTeX::NameFormat
- these are via tests -> Biber::Input::file::bibtex
I think you can safely drop the following build-time deps:
- Business::ISBN
- Business::ISSN
- Business::ISMN
- this code isn't tested
- Config::AutoConf
- Encode::EUCJPASCII
- Encode::HanExtra
- Encode::JIS2K
- ExtUtils::LibBuilder
- these aren't actually used anywhere
- Getopt::Long
- only used by the script and it's not tested
- List::MoreUtils
- again, not used anywhere
- LWP::Simple
- LWP::Protocol::https
- Mozila::CA
- this code isn't tested
- Pod::Usage
- only used by the script, not tested
- Readonly
- Readonly::XS
- not tested; furthermore, the XS variant is only recommended
for improved performance
- Unicode::Collate
- amusing, isn't it? It's not actually used anywhere; some of its
submodules are but not this one -- and with the dependency
constraint removed, you can just drop this completely
- XML::LibXSLT
- this code isn't tested
- XML::Writer::String
- this isn't used anywhere, not even mentioned in META;
where did you find it?...
Now, for the runtime dependencies. These can be dropped from the
list because rpmbuild's generators will automagically find them for you:
- autovivification
- Data::Dump
- Data::Compare
- Data::Simple
- File::Slurp
- IPC::Cmd
- IPC::Run3
- List::AllUtils
- Log::Log4perl
- Regexp::Common
- Unicode::GCString
- URI
- XML::Writer
And these just aren't needed at all:
- Encode::EUCJPASCII
- Encode::HanExtra
- Encode::JIS2K
- List::MoreUtils
- Unicode::Collate
- XML::Writer::String
Note Text::BibTeX gets autodetected too, however, it's missing the version
constraint. Therefore keep your explicit runtime dependency and filter out the
autogenerated one, like this, on one line:
%global __requires_exclude
%{?__requires_exclude:%__requires_exclude|}^perl\\(Text::BibTeX\\)$
You also need to add this to your runtime dep list, the generators won't
pick it up:
- Unicode::Collate::Locale
That should be all for the deps, next...
The license tag is incorrect. The README file states the distribution is
licensed under GPL+ or Artistic 2.0, however, all the code mentions Artistic
2.0 only. I would suggest using `(GPL+ or Artistic 2.0) and Artistic 2.0'
here.
And perhaps package TODO.org as %doc, too.
Hopefully that's all there is to this review :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957337] Review Request: jtoaster - Java utility class for swing applications
https://bugzilla.redhat.com/show_bug.cgi?id=957337 Timothy St. Clair changed: What|Removed |Added Flags||fedora-cvs? --- Comment #13 from Timothy St. Clair --- Package Change Request == Package Name: jtoaster New Branches: epel7 Owners: tstclair InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186819] Review Request: burp - Network backup / restore program
https://bugzilla.redhat.com/show_bug.cgi?id=1186819 --- Comment #34 from Andrew Niemantsverdriet --- (In reply to gil cattaneo from comment #33) > license field should be: AGPLv3 and BSD and GPLv2+ and LGPLv2+ I have updated the licence field. The new files are here: SPEC URL: https://fedorapeople.org/~kaptk2/burp.spec SRPM URL: https://fedorapeople.org/~kaptk2/burp-1.4.36-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1211517] Review Request: docker-swarm - Docker-native clustering system
https://bugzilla.redhat.com/show_bug.cgi?id=1211517 --- Comment #10 from Jan Chaloupka --- Yeah, valid from rpm >= 4.11. F20-rawhide are fine, epel6 is not. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220342] Review Request: compat-libgdata19 - Compat package with libgdata libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1220342 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220342] Review Request: compat-libgdata19 - Compat package with libgdata libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1220342 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218368] Review Request: python-django-fas - Django auth backend for FAS (Fedora Accounts System)
https://bugzilla.redhat.com/show_bug.cgi?id=1218368 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218368] Review Request: python-django-fas - Django auth backend for FAS (Fedora Accounts System)
https://bugzilla.redhat.com/show_bug.cgi?id=1218368 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220342] Review Request: compat-libgdata19 - Compat package with libgdata libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1220342 Kalev Lember changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Kalev Lember --- Thanks! New Package SCM Request === Package Name: compat-libgdata19 Short Description: Compat package with libgdata libraries Upstream URL: http://live.gnome.org/libgdata Owners: rishi kalev group::gnome-sig Branches: f22 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193842] Review Request: vagrant-registration - vagrant plugin for registration
https://bugzilla.redhat.com/show_bug.cgi?id=1193842 --- Comment #9 from Josef Stribny --- Can you please build this? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220770] Review Request: vim-fugitive - A Git wrapper so awesome, it should be illegal
https://bugzilla.redhat.com/show_bug.cgi?id=1220770 Bohuslav "Slavek" Kabrda changed: What|Removed |Added Flags||fedora-review+ --- Comment #3 from Bohuslav "Slavek" Kabrda --- - rpmlint output is OK (it only gives a couple of spelling error warnings which actually are false positives) - licensing is fine - everything else including %post and %postun scriptlets also seems to be fine, package builds cleanly in mock I can't find a single problem with this package, therefore it is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220779] New: Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries
https://bugzilla.redhat.com/show_bug.cgi?id=1220779 Bug ID: 1220779 Summary: Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dc...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://dchen.fedorapeople.org/files/rpms/7kaa.spec SRPM URL: https://dchen.fedorapeople.org/files/rpms/7kaa-2.14.4-1.fc22.src.rpm Description: Seven Kingdoms is a real-time strategy (RTS) computer game developed by Trevor Chan of Enlight Software. The game enables players to compete against up to six other kingdoms allowing players to conquer opponents by defeating them in war (with troops or machines), capturing their buildings with spies, or offering opponents money for their kingdom. Seven Kingdoms: Ancient Adversaries is a free patch provided by Interactive Magic and added three new cultures, the Egyptians, the Mughals and the Zulus, and a new war machine, Unicorn. Fedora Account System Username: dchen -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176307] Review Request: torrent-file-editor - Qt based GUI tool designed to create and edit .torrent files
https://bugzilla.redhat.com/show_bug.cgi?id=1176307 --- Comment #17 from Fedora Update System --- torrent-file-editor-0.2.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/torrent-file-editor-0.2.0-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220770] Review Request: vim-fugitive - A Git wrapper so awesome, it should be illegal
https://bugzilla.redhat.com/show_bug.cgi?id=1220770 Bohuslav "Slavek" Kabrda changed: What|Removed |Added Status|NEW |ASSIGNED CC||bkab...@redhat.com Assignee|nob...@fedoraproject.org|bkab...@redhat.com --- Comment #2 from Bohuslav "Slavek" Kabrda --- Taking this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220342] Review Request: compat-libgdata19 - Compat package with libgdata libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1220342
Debarshi Ray changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Debarshi Ray ---
MUST items
--
rpmlint output:
$ rpmlint compat-libgdata19-0.16.1-1.fc22.src.rpm
compat-libgdata19.src: W: spelling-error Summary(en_US) libgdata -> libation
compat-libgdata19.src: W: spelling-error %description -l en_US libgdata ->
libation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint compat-libgdata19-0.16.1-1.fc22.x86_64.rpm
compat-libgdata19.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint compat-libgdata19-debuginfo-0.16.1-1.fc22.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
The spelling mistakes are a false alarm, and there is no need for documentation
because this is a compat package and one can use the documentation from
libgdata just fine.
YES - package follows Naming Guidelines
The suffix 19 in the name was chosen to match the soname. This is consistent
with compat-libgdata13 that is shipped in RHEL.
YES - spec file name matches base package %{name}
YES - package follows Packaging Guidelines
YES - package is under a Fedora approved license
YES - license field matches actual license
YES - source package includes license text, which is included in %license
YES - spec file written in American English
YES - spec file is legible
YES - sources match upstream source
YES - package compiles on all primary architectures
YES - there is no need for ExcludeArch
YES - all build dependencies in BuildRequires
YES - handles locales properly
Translations are excluded. Possibly due to conflicts with libgdata.
YES - calls ldconfig in %post and %postun
YES - doesn't bundle system libraries
YES - package is not relocatable
YES - package owns all directories that it creates
YES - files are listed only once in %files
YES - file permissions are set properly
YES - consistent use of macros
YES - package contains code or permissible content
YES - no need for doc subpackage
There is no need for documentation because this is a compat package and one can
use the documentation from libgdata just fine.
YES - no chance of items marked as %doc affecting runtime
YES - no static libraries
YES - no need for devel subpackage
Development files are excluded because the purpose of this package is only to
retain binary compatibility. Newer versions of libgdata have retained API
stability, so new builds should be done against it.
YES - package removes all libtool archives
YES - package doesn't need a .desktop file
YES - doesn't own files or directories owned by other packages
YES - all filenames are valid UTF-8
SHOULD items
YES - package includes license text from upstream
NO - description and summary doesn't have translations
YES - package builds in Koji
YES - builds on all primary architectures
YES - package functions as described
YES - package doesn't use scriptlets
YES - no subpackages
YES - no dependencies outside of /etc/, /bin/, /sbin, etc.
YES - no need for man pages
ACCEPTED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212909] New package request: clufter - Tool for transforming/analyzing cluster configuration formats
https://bugzilla.redhat.com/show_bug.cgi?id=1212909 Libor Miksik changed: What|Removed |Added CC||lmik...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220770] Review Request: vim-fugitive - A Git wrapper so awesome, it should be illegal
https://bugzilla.redhat.com/show_bug.cgi?id=1220770 --- Comment #1 from Vít Ondruch --- Forgot to run rpmlint and it revealed some issues indeed. Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/vim-fugitive.git/tree/vim-fugitive.spec?id=15858d8b3e5eca7c29af4c6fb54d65d6b06e9e12 SRPM URL: http://people.redhat.com/vondruch/vim-fugitive-2.2-2.fc23.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9711686 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220770] New: Review Request: vim-fugitive - A Git wrapper so awesome, it should be illegal
https://bugzilla.redhat.com/show_bug.cgi?id=1220770 Bug ID: 1220770 Summary: Review Request: vim-fugitive - A Git wrapper so awesome, it should be illegal Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: vondr...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/vim-fugitive.git/tree/vim-fugitive.spec?id=ffe4f95c4f3707288ba1c893c050e3f6c201b17e SRPM URL: http://people.redhat.com/vondruch/vim-fugitive-2.2-1.fc23.src.rpm Description: fugitive.vim may very well be the best Git wrapper of all time. Fedora Account System Username: vondruch Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9711450 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218788] Review Request: yast2-filesystem - YaST filesystem layout
https://bugzilla.redhat.com/show_bug.cgi?id=1218788 Björn "besser82" Esser changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2015-05-12 07:18:22 --- Comment #6 from Björn "besser82" Esser --- Name: yast2-devtools Arch: noarch Epoch : 0 Version : 3.1.32 Release : 1.fc22 Size: 368 k Repo: @System From repo : updates-testing Summary : YaST Development Tools URL : https://en.opensuse.org/Portal:YaST License : GPLv2+ Description : Common scripts and templates for developing : and building YaST2 modules and components. Name: yast2-filesystem Arch: x86_64 Epoch : 0 Version : 0.1.0 Release : 1.fc22 Size: 1.4 k Repo: @System From repo : fedora Summary : YaST filesystem layout URL : https://en.opensuse.org/Portal:YaST License : Public Domain Description : : This package holds the common filesystem-layout used by YaST2 : and handles log-rotation for YaST2-logfiles. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218749] Review Request: yast2-devtools - YaST Development Tools
https://bugzilla.redhat.com/show_bug.cgi?id=1218749 Björn "besser82" Esser changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2015-05-12 07:17:21 --- Comment #6 from Björn "besser82" Esser --- Name: yast2-devtools Arch: noarch Epoch : 0 Version : 3.1.32 Release : 1.fc22 Size: 368 k Repo: @System From repo : updates-testing Summary : YaST Development Tools URL : https://en.opensuse.org/Portal:YaST License : GPLv2+ Description : Common scripts and templates for developing : and building YaST2 modules and components. Name: yast2-filesystem Arch: x86_64 Epoch : 0 Version : 0.1.0 Release : 1.fc22 Size: 1.4 k Repo: @System From repo : fedora Summary : YaST filesystem layout URL : https://en.opensuse.org/Portal:YaST License : Public Domain Description : : This package holds the common filesystem-layout used by YaST2 : and handles log-rotation for YaST2-logfiles. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218788] Review Request: yast2-filesystem - YaST filesystem layout
https://bugzilla.redhat.com/show_bug.cgi?id=1218788 Bug 1218788 depends on bug 1218749, which changed state. Bug 1218749 Summary: Review Request: yast2-devtools - YaST Development Tools https://bugzilla.redhat.com/show_bug.cgi?id=1218749 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220342] Review Request: compat-libgdata19 - Compat package with libgdata libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1220342 Debarshi Ray changed: What|Removed |Added CC||debars...@redhat.com Assignee|nob...@fedoraproject.org|debars...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150393] Review Request: tengine - A high performance web server and reverse proxy server
https://bugzilla.redhat.com/show_bug.cgi?id=1150393 Vladimir Stackov changed: What|Removed |Added CC||amigo.el...@gmail.com --- Comment #12 from Vladimir Stackov --- I would like to see tengine in EPEL and I can become reviewer (and co-maintainer for EPEL branches) because you don't need sponsorship but I see a reason that could prevent tengine from joining Fedora package collection: According to packaging guidelines for conflicts [1] you should contact Fedora Packaging Committee [2] because tengine may be considered as a drop-in replacement for nginx but not vice versa and this case isn't described properly in packaging guidelines. I think that you could use alternatives [3] for tengine and this will be the best solution but this decision is not in my responsibility. Could you contact Fedora Packaging Committee? [1] https://fedoraproject.org/wiki/Packaging:Conflicts#Other_Uses_of_Conflicts: [2] https://fedoraproject.org/wiki/Packaging_Committee [3] https://fedoraproject.org/wiki/Packaging:Alternatives -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218025] Review Request: cashe - program and libraries for accessing a CAS cache
https://bugzilla.redhat.com/show_bug.cgi?id=1218025 --- Comment #2 from Pavel Odvody --- rpmlint: cashe.src: W: name-repeated-in-summary C CAShe cashe.src: W: invalid-license LGPL+ cashe.src:6: E: hardcoded-library-path in /usr/lib/python?.?/site-packages cashe.src: W: invalid-url Source0: cashe-0.99.1.tar.gz and also: cashe.x86_64: W: incoherent-version-in-changelog 0.99-1 ['0.99.1-1.fc21', '0.99.1-1'] - Some quick notes: 1. The correct license name is LGPLv2+ 2. The repeated name is to keep the ``CAShe`` stylistics, so along with the hardocded-library path error, are both really false positives 3. The invalid URL - can you make a github release and link the URL in there, so the archive is globally reachable? Also please set the fedora-review flag to ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219948] Review Request: ardour2 - Digital Audio Workstation
https://bugzilla.redhat.com/show_bug.cgi?id=1219948 --- Comment #6 from Fedora Update System --- ardour2-2.8.16-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/ardour2-2.8.16-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219948] Review Request: ardour2 - Digital Audio Workstation
https://bugzilla.redhat.com/show_bug.cgi?id=1219948 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218025] Review Request: cashe - program and libraries for accessing a CAS cache
https://bugzilla.redhat.com/show_bug.cgi?id=1218025 Pavel Odvody changed: What|Removed |Added CC||podv...@redhat.com Assignee|nob...@fedoraproject.org|podv...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207847] Review Request: auto - A collection of source code generators for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1207847 --- Comment #6 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/auto.spec SRPM URL: https://gil.fedorapeople.org/auto-1.0-2.fc20.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9709171 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220451] Review Request: zuul - Trunk gating system developed for the OpenStack Project
https://bugzilla.redhat.com/show_bug.cgi?id=1220451 --- Comment #2 from Fabien Boucher --- Hi Tristan, Thanks you for the review. You are right python-setuptools was missing so I added it in BuildRequires. Also I removed all tabulations so fedora-review no longer reports that problem. I fixed the date too. The package does not install correctly "ERROR: 'mock build failed'" due to the missing python-statsd. I thought it was already included in fedora but apparently not yet. Cheers, Fabien Boucher -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 849470] Review Request: oscache - High performance J2EE caching solution
https://bugzilla.redhat.com/show_bug.cgi?id=849470 --- Comment #5 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/oscache.spec SRPM URL: http://gil.fedorapeople.org/oscache-2.4.2-1.fc20.src.rpm - update to 2.4.2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 849470] Review Request: oscache - High performance J2EE caching solution
https://bugzilla.redhat.com/show_bug.cgi?id=849470 gil cattaneo changed: What|Removed |Added Depends On||1106947 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1106947 [Bug 1106947] jgroups212: FTBFS in rawhide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177055] Tracker mesos - Cluster Manager to epel7
https://bugzilla.redhat.com/show_bug.cgi?id=1177055 --- Comment #12 from Ratnadeep Debnath --- Timothy, I had rebuilt most of the missing dependencies for epel7. I think I should have RPMs for the above. I will share the RPMs once I reach home. Regards, rtnpro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
