[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120
--- Comment #3 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
Thanks for the review. Please see my comments inline:
(In reply to Michal Cyprian from comment #2)
* There is non executable script
/usr/share/atomic-reactor/images/privileged-builder/docker.sh with
permissions 644.
As a comment on line 239 notes, this file is not executable since it's not
meant for direct use on user's system, but should only be used in a container
(therefore the 644 privileges defend user from making unwanted harm). So
hopefully, this is ok.
* The lastest revision of Packaging Guidelines:Python don't recommend to use
macro %{py3dir}.
Fixed (I just don't use separate dirs for py3 build any more, which should be
correct and still work).
* License of the package and license field in spec are alright.
* Package was compiled and build successfully.
* import of atomic_reactor module is working properly in both python2 and
python3 subpackages.
* It is still not possible to run it as you have already noticed.
Since fixing bug 1245523 makes python-docker-py work again (until it's fixed
properly as requested in bug 1245521), it should work now.
Spec URL:
https://bkabrda.fedorapeople.org/pkgs/atomic-reactor/atomic-reactor.spec
SRPM URL:
https://bkabrda.fedorapeople.org/pkgs/atomic-reactor/atomic-reactor-1.4.0-2.fc22.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246766] Review Request: golang-github-docker-libkv - Key/Value store abstraction library
https://bugzilla.redhat.com/show_bug.cgi?id=1246766 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246766] Review Request: golang-github-docker-libkv - Key/Value store abstraction library
https://bugzilla.redhat.com/show_bug.cgi?id=1246766 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- golang-github-docker-libkv-0-0.1.gitb68985b.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-github-docker-libkv-0-0.1.gitb68985b.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245929] Review Request: platform - Platform support library used by libCEC and binary add-ons for Kodi
https://bugzilla.redhat.com/show_bug.cgi?id=1245929 --- Comment #2 from Mohamed El Morabity pikachu.2...@gmail.com --- (In reply to Michael Cronenworth from comment #1) 1. License file is missing. You can add one and open a request for upstream to include it. Upstream provides a copyright file in the debian/ subfolder, probably to meet Debian's packaging guidelines. I should use it since it's already available. 2. licensecheck reveals BSD and LGPL licensed files, and also many files using an incorrect FSF address. You can ask upstream to update their license clauses and add the missing licenses to the spec. The BSD headers are only used when platform is built on Windows. By the way, two issues detected by a Debian packager may impact this review: 1) licensing issue: https://github.com/Pulse-Eight/platform/issues/12 2) bundled library I missed (fstrcmp): https://github.com/Pulse-Eight/platform/issues/13 Unbundling this library may solve the licensing conflict above (since latest versions seem to be full-GPLv2+). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243061] Review Request: dex-autostart - Generate and execute DesktopEntry files
https://bugzilla.redhat.com/show_bug.cgi?id=1243061 --- Comment #6 from Till Hofmann hofm...@kbsg.rwth-aachen.de --- Spec URL: https://thofmann.fedorapeople.org/dex-autostart.spec SRPM URL: https://thofmann.fedorapeople.org/dex-autostart-0.8-0.4.20150728git4bbd9f9.fc22.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10506514 Thanks for the comments! I've added python3 as requirement. This should be sufficient. (I thought the requirement would be detected automatically, but I actually never checked). I've added a substitution for the README to rename dex to dex-autostart. I wasn't aware of the included doctest, I've added a check section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246766] Review Request: golang-github-docker-libkv - Key/Value store abstraction library
https://bugzilla.redhat.com/show_bug.cgi?id=1246766 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- golang-github-docker-libkv-0-0.1.gitb68985b.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-docker-libkv-0-0.1.gitb68985b.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Bug 1246120 depends on bug 1245521, which changed state. Bug 1245521 Summary: docker-py gets broken by old python-websocket-client version https://bugzilla.redhat.com/show_bug.cgi?id=1245521 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246766] Review Request: golang-github-docker-libkv - Key/Value store abstraction library
https://bugzilla.redhat.com/show_bug.cgi?id=1246766 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- golang-github-docker-libkv-0-0.1.gitb68985b.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-docker-libkv-0-0.1.gitb68985b.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230949] Review Request: hid4java - A cross-platform Java Native Access (JNA) wrapper for the signal11/hidapi library
https://bugzilla.redhat.com/show_bug.cgi?id=1230949 --- Comment #12 from Alexander Kurtakov akurt...@redhat.com --- I would be fine with using this snapshot as Source0 if you want to see it in sooner. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Bohuslav Slavek Kabrda bkab...@redhat.com changed: What|Removed |Added Status|ASSIGNED|MODIFIED Fixed In Version||atomic-reactor-1.4.0-2.fc24 ||atomic-reactor-1.4.0-2.fc23 ||atomic-reactor-1.4.0-2.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243915] Review Request: perl-Pinto - Curate a repository of Perl modules
https://bugzilla.redhat.com/show_bug.cgi?id=1243915 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Šabata psab...@redhat.com --- That looks better. Approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243915] Review Request: perl-Pinto - Curate a repository of Perl modules
https://bugzilla.redhat.com/show_bug.cgi?id=1243915 Jitka Plesnikova jples...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Jitka Plesnikova jples...@redhat.com --- New Package SCM Request === Package Name: perl-Pinto Short Description: Curate a repository of Perl modules Upstream URL: http://search.cpan.org/dist/Pinto/ Owners: jplesnik ppisar psabata Branches: f23 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242091] Review Request: nodejs-smart-buffer - A smarter Buffer that keeps track of its own read and write positions while growing endlessly
https://bugzilla.redhat.com/show_bug.cgi?id=1242091 Zuzana Svetlikova zsvet...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Zuzana Svetlikova zsvet...@redhat.com --- Seems fine, APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244797] Review Request: libASL - Advanced Simulation Library
https://bugzilla.redhat.com/show_bug.cgi?id=1244797
--- Comment #4 from Michael Schwendt (Fedora Packager Sponsors Group)
bugs.mich...@gmx.net ---
Just a drive-by comment:
%packagedevel
Requires: cmake
Clearly overhead for a -devel package that also provides a pkg-config file.
If you only want cmake for directory ownership, it is permissible to include
also %{_libdir}/cmake in your package:
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function
Requires: pkgconfig
Nowadays there's an automatic dependency on /usr/bin/pkgconfig and automatic
dependencies for .pc file inter-dependencies, too. Even on RHEL6.
%{_libdir}/cmake/%{upstream}/*.cmake
Directory %{_libdir}/cmake/%{upstream} is not included in the package.
%exclude %{_pkgdocdir}/html
%exclude without a corresponding include of the same path name is dangerous.
%exclude hides the file(s) from all %files sections and can lead to missing
files in the built packages. Your spec file is not clear with regard to
movement/removal of some doc files, such as %{_docdir}/%{upstream}/html, and
how %_pkgdocdir/html fits into that.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245929] Review Request: platform - Platform support library used by libCEC and binary add-ons for Kodi
https://bugzilla.redhat.com/show_bug.cgi?id=1245929 --- Comment #3 from Michael Cronenworth m...@cchtml.com --- Unfortunately the debian copyright file is not the same as the license text. It's not a hard blocker for the review, but the bundled lib and PHP license is. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- atomic-reactor-1.4.0-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/atomic-reactor-1.4.0-2.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242724] Review Request: perl-File-Find-Rule-Age - Rule to match on file age
https://bugzilla.redhat.com/show_bug.cgi?id=1242724 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Šabata psab...@redhat.com --- Okay, that's better. A few more notes, however: * Sort your dependencies; they will be easier to read and you'll be less likely to miss something or list it twice. (`base' and `Carp', I'm looking at you!) * You still needlessly remove empty directories in %install, now on line 54. * You added some trailing whitespace, lines 36 and 69. That's just bad taste ;) * It looks like you forgot to bump the release number; now you have two changelog entries for one VR. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186558] Review Request: gfm - Texas Instruments handheld(s) file manipulation program
https://bugzilla.redhat.com/show_bug.cgi?id=1186558 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186558] Review Request: gfm - Texas Instruments handheld(s) file manipulation program
https://bugzilla.redhat.com/show_bug.cgi?id=1186558 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246740] Review Request: golang-github-mesos-mesos-go - Go language bindings for Apache Mesos
https://bugzilla.redhat.com/show_bug.cgi?id=1246740 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- golang-github-mesos-mesos-go-0-0.1.git83b52d7.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-mesos-mesos-go-0-0.1.git83b52d7.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246740] Review Request: golang-github-mesos-mesos-go - Go language bindings for Apache Mesos
https://bugzilla.redhat.com/show_bug.cgi?id=1246740 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242724] Review Request: perl-File-Find-Rule-Age - Rule to match on file age
https://bugzilla.redhat.com/show_bug.cgi?id=1242724 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245604] Review Request: vim-go - Go development plugin for Vim
https://bugzilla.redhat.com/show_bug.cgi?id=1245604 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245604] Review Request: vim-go - Go development plugin for Vim
https://bugzilla.redhat.com/show_bug.cgi?id=1245604 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 --- Comment #7 from Bohuslav Slavek Kabrda bkab...@redhat.com --- Note: this can't be built for epel7 now because of bug 1192534 comment 13. I'll leave this bug open and close it when f22, f23, rawhide and epel7 are built and gone through testing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 hgue...@redhat.com changed: What|Removed |Added CC||brdem...@cisco.com, ||hgue...@redhat.com Flags||needinfo?(brdem...@cisco.co ||m) --- Comment #9 from hgue...@redhat.com --- +1 I'd move the dos2unix one-liner in %setup too Is there a reason not to ship 0.8.3 ? it's the latest one and it provides license file? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246740] Review Request: golang-github-mesos-mesos-go - Go language bindings for Apache Mesos
https://bugzilla.redhat.com/show_bug.cgi?id=1246740 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- golang-github-mesos-mesos-go-0-0.1.git83b52d7.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-github-mesos-mesos-go-0-0.1.git83b52d7.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1247584] Review Request: python-pyldap - An object-oriented Python API to access LDAP directory servers
https://bugzilla.redhat.com/show_bug.cgi?id=1247584 Michal Cyprian mcypr...@redhat.com changed: What|Removed |Added CC||mcypr...@redhat.com --- Comment #1 from Michal Cyprian mcypr...@redhat.com --- * All rpmlint outputs were alright. * Text of the license is not in its own file nor in the sources, it is probably not necessary in this case. * Package was compiled and built successfully. * Import of the module and simple tests are working properly * There is unversioned so-file /usr/lib64/python3.4/site-packages/_ldap.cpython-34m.so -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245929] Review Request: platform - Platform support library used by libCEC and binary add-ons for Kodi
https://bugzilla.redhat.com/show_bug.cgi?id=1245929 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added Depends On||1247672 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1247672 [Bug 1247672] Review Request: fstrcmp - Fuzzy string compare library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1247584] Review Request: python-pyldap - An object-oriented Python API to access LDAP directory servers
https://bugzilla.redhat.com/show_bug.cgi?id=1247584 Michal Cyprian mcypr...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1247672] New: Review Request: fstrcmp - Fuzzy string compare library
https://bugzilla.redhat.com/show_bug.cgi?id=1247672 Bug ID: 1247672 Summary: Review Request: fstrcmp - Fuzzy string compare library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: pikachu.2...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://melmorabity.fedorapeople.org/packages/fstrcmp/fstrcmp.spec SRPM URL: https://melmorabity.fedorapeople.org/packages/fstrcmp/fstrcmp-0.7.D001-1.fc22.src.rpm Description: The fstrcmp package provides a library which may be used to make fuzzy comparisons of strings and byte arrays. It also provides simple commands for use in shell scripts. Fedora Account System Username: melmorabity -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1247672] Review Request: fstrcmp - Fuzzy string compare library
https://bugzilla.redhat.com/show_bug.cgi?id=1247672 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added Blocks||1245929 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1245929 [Bug 1245929] Review Request: platform - Platform support library used by libCEC and binary add-ons for Kodi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245929] Review Request: platform - Platform support library used by libCEC and binary add-ons for Kodi
https://bugzilla.redhat.com/show_bug.cgi?id=1245929 --- Comment #4 from Mohamed El Morabity pikachu.2...@gmail.com --- New release: - fstrcmp library is now unbundled (the fstrcmp.c file is no more used anymore, no more license conflict by the way) - new package review for this library here: https://bugzilla.redhat.com/show_bug.cgi?id=1247672 Spec URL: https://melmorabity.fedorapeople.org/packages/platform/platform.spec SRPM URL: https://melmorabity.fedorapeople.org/packages/platform/platform-1.0.10-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220491] Review Request: elastic-curator - Tools for managing Elasticsearch indices
https://bugzilla.redhat.com/show_bug.cgi?id=1220491 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- elastic-curator-3.2.3-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/elastic-curator-3.2.3-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1247584] Review Request: python-pyldap - An object-oriented Python API to access LDAP directory servers
https://bugzilla.redhat.com/show_bug.cgi?id=1247584 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|tra...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243915] Review Request: perl-Pinto - Curate a repository of Perl modules
https://bugzilla.redhat.com/show_bug.cgi?id=1243915 --- Comment #4 from Jitka Plesnikova jples...@redhat.com --- Updated files are on the same link. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Bohuslav Slavek Kabrda bkab...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Bohuslav Slavek Kabrda bkab...@redhat.com --- Great, thanks for your review! New Package SCM Request === Package Name: atomic-reactor Short Description: Improved builder for Docker images Upstream URL: https://github.com/projectatomic/atomic-reactor Owners: bkabrda ttomecek Branches: f22 f23 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245967] Review Request: golang-github-google-btree - BTree implementation for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1245967 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241808] Review Request: python-oslo-cache - Cache storage for Openstack projects.
https://bugzilla.redhat.com/show_bug.cgi?id=1241808 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-oslo-cache-0.2.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-oslo-cache-0.2.0-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245967] Review Request: golang-github-google-btree - BTree implementation for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1245967 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- golang-github-google-btree-0-0.1.gitcc6329d.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-google-btree-0-0.1.gitcc6329d.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241808] Review Request: python-oslo-cache - Cache storage for Openstack projects.
https://bugzilla.redhat.com/show_bug.cgi?id=1241808 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245604] Review Request: vim-go - Go development plugin for Vim
https://bugzilla.redhat.com/show_bug.cgi?id=1245604 Nikola Forró nfo...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Nikola Forró nfo...@redhat.com --- New Package SCM Request === Package Name: vim-go Short Description: Go development plugin for Vim Upstream URL: https://github.com/fatih/vim-go Owners: nforro jchaloup Branches: f21 f22 f23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1045963] Review Request: ghc-gtk3 - Binding to the Gtk+ graphical user interface library
https://bugzilla.redhat.com/show_bug.cgi?id=1045963 --- Comment #14 from Pranav Kant pranav...@gmail.com --- Other than that, everything seems to be OK to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images
https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Michal Cyprian mcypr...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Michal Cyprian mcypr...@redhat.com --- Everything seems to be alright now, It is possible to run it when python-websocket-client-0.32.0 is installed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246033] Review Request: golang-github-bradfitz-http2 - HTTP/2 support for Go (in active development)
https://bugzilla.redhat.com/show_bug.cgi?id=1246033 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- golang-github-bradfitz-http2-0-0.1.gitf8202bc.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-bradfitz-http2-0-0.1.gitf8202bc.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246033] Review Request: golang-github-bradfitz-http2 - HTTP/2 support for Go (in active development)
https://bugzilla.redhat.com/show_bug.cgi?id=1246033 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- golang-github-bradfitz-http2-0-0.1.gitf8202bc.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-github-bradfitz-http2-0-0.1.gitf8202bc.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246033] Review Request: golang-github-bradfitz-http2 - HTTP/2 support for Go (in active development)
https://bugzilla.redhat.com/show_bug.cgi?id=1246033 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245356] Review Request: python-ansi - ANSI cursor movement and graphics
https://bugzilla.redhat.com/show_bug.cgi?id=1245356 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- python-ansi-0.1.3-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-ansi-0.1.3-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1224265] Review Request: udiskie - Automounter for removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1224265 Jan Staněk jsta...@redhat.com changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-07-28 07:05:36 --- Comment #18 from Jan Staněk jsta...@redhat.com --- Approved package imported and successfully built for all branches. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245604] Review Request: vim-go - Go development plugin for Vim
https://bugzilla.redhat.com/show_bug.cgi?id=1245604
--- Comment #8 from Nikola Forró nfo...@redhat.com ---
(In reply to Vít Ondruch from comment #5)
I would suggest to add .metainfo.xml for Gnome Software [1]. You can find
inspiration in my vim-command-t package.
[1]
https://fedoraproject.org/wiki/Packaging:AppData#.metainfo.xml_file_creation
[2] http://pkgs.fedoraproject.org/cgit/vim-command-t.git/tree/
Added.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
One more thing: golang is not available everywhere, so your package should
not be built for architectures where the dependencies cannot be satisfied
anyway:
ExclusiveArch: %{go_arches} noarch
(taken from
https://fedoraproject.org/wiki/PackagingDrafts/Go#Libraries_and_Arch)
Fixed.
Spec URL: https://nforro.fedorapeople.org/vim-go.spec
Metainfo URL: https://nforro.fedorapeople.org/vim-go.metainfo.xml
SRPM URL: https://nforro.fedorapeople.org/vim-go-1.0.5-5.fc22.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Ihar Hrachyshka ihrac...@redhat.com changed: What|Removed |Added CC||ihrac...@redhat.com --- Comment #8 from Ihar Hrachyshka ihrac...@redhat.com --- Shouldn't release generally start from 1, not 0? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245967] Review Request: golang-github-google-btree - BTree implementation for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1245967 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- golang-github-google-btree-0-0.1.gitcc6329d.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-github-google-btree-0-0.1.gitcc6329d.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245967] Review Request: golang-github-google-btree - BTree implementation for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1245967 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- golang-github-google-btree-0-0.1.gitcc6329d.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-google-btree-0-0.1.gitcc6329d.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1045963] Review Request: ghc-gtk3 - Binding to the Gtk+ graphical user interface library
https://bugzilla.redhat.com/show_bug.cgi?id=1045963 --- Comment #13 from Jens Petersen peter...@redhat.com --- Thanks for following up. (In reply to Pranav Kant from comment #12) * Why the shared object file provided by the base package is unversioned. I think there is a bug related to this for all ghc packages, but I can't find it, right ? Right this is currently how ghc names shared libraries. The filenames are actually versioned - it is just that the version comes before the .so extension. I am happy to open a bug for that against ghc but I hope it need not block this review: it is not something we can fix in this package anyway. But note that ghc does not have the notion of major/minor libraries versions - every version bumps needs rebuilds anyway. If there is nothing like that, we should probably version this, and move the unversioned one to the -devel package ? I think it might be better to patch ghc to change how it names .so files: need to think a bit more. Basically it is how ghc has named them since it started supporting shared libraries many releases ago now. * Why there is no -debuginfo package ? I think the similar reason as above holds here also for ghc packages ? ghc-7.10 should introduce support for dwarf debuginfo I think, so I decided to wait with debuginfo until then - I don't think it is useful currently with ghc-7.8. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243915] Review Request: perl-Pinto - Curate a repository of Perl modules
https://bugzilla.redhat.com/show_bug.cgi?id=1243915
--- Comment #3 from Petr Šabata psab...@redhat.com ---
BRs are fine now.
Regarding the service... It looks rather obscure to me.
I suggest you put the configuration file in %{_sysconfdir}/sysconfig/pintod and
then use EnvironmentFiles in the unit file. See
https://fedoraproject.org/wiki/Packaging:Systemd#EnvironmentFiles_and_support_for_.2Fetc.2Fsysconfig_files
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1247584] New: Review Request: python-pyldap - An object-oriented Python API to access LDAP directory servers
https://bugzilla.redhat.com/show_bug.cgi?id=1247584 Bug ID: 1247584 Summary: Review Request: python-pyldap - An object-oriented Python API to access LDAP directory servers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mhron...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-pyldap.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-pyldap-2.4.20-1.fc21.src.rpm Description: pyldap provides an object-oriented API for working with LDAP within Python programs. It allows access to LDAP directory servers by wrapping the OpenLDAP 2.x libraries, and contains modules for other LDAP-related tasks (including processing LDIF, LDAPURLs, LDAPv3 schema, etc.). Fedora Account System Username: churchyard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246033] Review Request: golang-github-bradfitz-http2 - HTTP/2 support for Go (in active development)
https://bugzilla.redhat.com/show_bug.cgi?id=1246033 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- golang-github-bradfitz-http2-0-0.1.gitf8202bc.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-bradfitz-http2-0-0.1.gitf8202bc.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245356] Review Request: python-ansi - ANSI cursor movement and graphics
https://bugzilla.redhat.com/show_bug.cgi?id=1245356 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243061] Review Request: dex-autostart - Generate and execute DesktopEntry files
https://bugzilla.redhat.com/show_bug.cgi?id=1243061 --- Comment #5 from Marcin Haba marcin.h...@bacula.pl --- One more thing. I have seen that dex-autostart has a tests suit (doctest available to execute via --test switcher and visible tests results in verbose mode -v). I think that nice might be to add these tests call in %check section, according to: https://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
