[Bug 1284000] Review Request: rpmspectool - Utility for RPM spec files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284000



--- Comment #9 from Parag AN(पराग)  ---
Raphael, where exactly are you looking in git? I just checkout rpmspectool and
can find the spec file and sources file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] New: Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336

Bug ID: 1305336
   Summary: Review Request: R-RInside - C++ Classes to Embed R in
C++ Applications
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mattias.ell...@fysast.uu.se
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://www.grid.tsl.uu.se/review/R-RInside.spec
SRPM URL: http://www.grid.tsl.uu.se/review/R-RInside-0.2.13-1.fc24.src.rpm

Description:
The RInside packages makes it easier to have "R inside" your C++
application by providing a C++ wrapper class providing the R
interpreter.

Fedora Account System Username: ellert

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305335] New: Review Request: R-Rcpp - Seamless R and C++ Integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305335

Bug ID: 1305335
   Summary: Review Request: R-Rcpp - Seamless R and C++
Integration
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mattias.ell...@fysast.uu.se
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://www.grid.tsl.uu.se/review/R-Rcpp.spec
SRPM URL: http://www.grid.tsl.uu.se/review/R-Rcpp-0.12.3-1.fc24.src.rpm

Description:
The Rcpp package provides R functions as well as C++ classes which
offer a seamless integration of R and C++. Many R data types and
objects can be mapped back and forth to C++ equivalents which
facilitates both writing of new code as well as easier integration of
third-party libraries.
Documentation about Rcpp is provided by several vignettes included in
this package, via the Rcpp Gallery site at http://gallery.rcpp.org,
the paper by Eddelbuettel and Francois (2011, JSS), and the book by
Eddelbuettel (2013, Springer).
See citation("Rcpp") for details on the last two.

Fedora Account System Username: ellert

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305335] Review Request: R-Rcpp - Seamless R and C++ Integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305335

Mattias Ellert  changed:

   What|Removed |Added

 Blocks||1305336




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1305336
[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++
Applications
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305336] Review Request: R-RInside - C++ Classes to Embed R in C++ Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305336

Mattias Ellert  changed:

   What|Removed |Added

 Depends On||1305335




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1305335
[Bug 1305335] Review Request: R-Rcpp - Seamless R and C++ Integration
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305333

Mattias Ellert  changed:

   What|Removed |Added

 Blocks||1305335




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1305335
[Bug 1305335] Review Request: R-Rcpp - Seamless R and C++ Integration
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305334] Review Request: R-inline - Functions to Inline C, C++, Fortran Function Calls from R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305334

Mattias Ellert  changed:

   What|Removed |Added

 Blocks||1305335




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1305335
[Bug 1305335] Review Request: R-Rcpp - Seamless R and C++ Integration
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305335] Review Request: R-Rcpp - Seamless R and C++ Integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305335

Mattias Ellert  changed:

   What|Removed |Added

 Depends On||1305333, 1305334




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1305333
[Bug 1305333] Review Request: R-highlight - R Syntax Highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=1305334
[Bug 1305334] Review Request: R-inline - Functions to Inline C, C++,
Fortran Function Calls from R
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304145] Review Request: kf5-libkexiv2 - A wrapper around Exiv2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304145

Mattia Verga  changed:

   What|Removed |Added

   Docs Contact|mattia.ve...@tiscali.it |
   Assignee|nob...@fedoraproject.org|mattia.ve...@tiscali.it
  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Mattia Verga  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= ISSUES found =
- Package carries tests, so it SHOULD have a %check section with make tests.

This is not a blocker so package is APPROVED.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* BSD (3 clause)", "LGPL (v2 or later)", "GPL (v2
 or later)", "Unknown or generated". 5 files have unknown license.
 Detailed output of licensecheck in
 /home/rpmbuild/1304145-kf5-libkexiv2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/include/KF5
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane 

[Bug 1304145] Review Request: kf5-libkexiv2 - A wrapper around Exiv2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304145

Mattia Verga  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mattia.ve...@tiscali.it
   Docs Contact||mattia.ve...@tiscali.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284000] Review Request: rpmspectool - Utility for RPM spec files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284000



--- Comment #10 from Raphael Groner  ---
(In reply to Parag AN(पराग) from comment #9)
> Raphael, where exactly are you looking in git? 

http://pkgs.fedoraproject.org/cgit/rpmspectool.git/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289726] Review Request: apache-commons-weaver - Apache Commons Weaver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289726



--- Comment #11 from gil cattaneo  ---
Spec URL: https://gil.fedorapeople.org/apache-commons-weaver.spec
SRPM URL: https://gil.fedorapeople.org/apache-commons-weaver-1.2-1.fc23.src.rpm

- update to 1.2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294368] Review Request: erlang-p1_iconv - Erlang bindings for iconv

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294368

Randy Barlow  changed:

   What|Removed |Added

   Assignee|jer...@jcline.org   |rbar...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304882] Review Request: openqa - OS-level automated test framework and web UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304882

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jdula...@fedoraproject.org



--- Comment #16 from Zbigniew Jędrzejewski-Szmek  ---
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd says
"%systemd_requires macro must not be used".

If the generators fails, it will not log anything. Actually that's another
error in the generator script. See
http://www.freedesktop.org/software/systemd/man/systemd.generator.html#Notes.

For the permissions, (0640,root,geekotest) would seem more natural then. For
example cups has a bunch of files /etc/cups that follow this pattern,
/etc/ssmtp. It's nice because you can provide read permissions to other users
by adding them to the group.

Using (0460,geekotest,root) doesn't achieve the purpose of preventing writes,
because the owner of the file has permission to chmod +x. I don't know how
security sensitive the file is, but if you're going to implement a lock down of
the file, I think it should be done properly, not least because bad patterns
tend to get copied and end up in more important places. I wouldn't worry about
the upstream permissions: if you have an %attr() already, also setting the mode
doesn't change much.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297234] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and Astropy affiliated packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297234

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297234] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and Astropy affiliated packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297234



--- Comment #13 from Fedora Update System  ---
python-astropy-helpers-1.1.1-1.fc23 has been submitted as an update to Fedora
23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-39aab2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304882] Review Request: openqa - OS-level automated test framework and web UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304882



--- Comment #15 from awill...@redhat.com  ---
"%config(noreplace) %attr(-,geekotest,root) %{_sysconfdir}/openqa/openqa.ini
%config(noreplace) %attr(-,geekotest,root) %{_sysconfdir}/openqa/database.ini
Why are those owned by the user? Can they be updated dynamically at runtime?"

ah, so, I remember! This is not necessary for openqa.ini , I can fix that.

The reason for database.ini is that it may contain sensitive information
(specifically, the database password, depending on how you're doing database
auth); we need only the openqa server to be able to read it. There's really no
need for it to be writeable by the server, so perhaps we could make it 0440 or
0400 - IIRC root ignores perms and can write to anything that's not immutable,
though I'm not sure if it's 'bad practice' to set a file you expect root to
write to be read-only. We could do 0460, I guess, but that seems odd.

The perms are set by the upstream install script (we can always change them,
but since we have a good relationship with upstream it would really make sense
to change it there instead of having a downstream change).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304882] Review Request: openqa - OS-level automated test framework and web UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304882



--- Comment #14 from awill...@redhat.com  ---
So the %systemd_requires thing is only in a draft page so far as I can see -
https://fedoraproject.org/wiki/User:Zbyszek/SystemdLinksDraft - but I'm fine
with expanding it.

On the generator: I think maybe it's OK, because it's more a convenience thing
than a critical bit of functionality - I actually didn't know about that target
at all, I just run a 'for i in 1 .. 8' or whatever loop over the individual
worker services =) I guess nothing too ugly happens if the generator does fail,
there's just a log message and the target doesn't work right? I think we can
live with that, especially if the alternative is just 'no generator for anyone'
- unless there's a better way to achieve the same goal? For context, there's
really no rules about the numbers of workers, you can run as many on a system
as your hardware can cope with, and add them (and remove them) at any time.

I guess you've convinced me on the user creation...openQA *really needs* those
user accounts to exist, but I suppose someone might want to run their accounts
entirely out of FreeIPA or something. So I can change that, sure. It might be a
good idea to submit a revision request for the guidelines?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #7 from Upstream Release Monitoring 
 ---
epienbro's scratch build of
mingw-wine-gecko?#f6fe7e9688d9639fa7a1233a68a9862ce0b246e7 for f23 and
git://pkgs.fedoraproject.org/mingw-wine-gecko?#f6fe7e9688d9639fa7a1233a68a9862ce0b246e7
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12897715

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284000] Review Request: rpmspectool - Utility for RPM spec files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284000



--- Comment #11 from Parag AN(पराग)  ---
oh okay. That need to be reported to fedora-infra people. Something should be
wrong in pkgs git.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297234] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and Astropy affiliated packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297234



--- Comment #14 from Fedora Update System  ---
python-astropy-helpers-1.1.1-1.fc22 has been submitted as an update to Fedora
22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4622161117

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270776



--- Comment #12 from Fedora Update System  ---
restsharp-105.2.3-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-01a328bcee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Rex Dieter  changed:

   What|Removed |Added

  Flags||needinfo?(pierluigi.fiorini
   ||@gmail.com)



--- Comment #2 from Rex Dieter  ---
ping, do you plan on continuing reviewing this package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295035] Review Request: erlang-p1_pam - epam for ejabberd to help with PAM authentication support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295035

Randy Barlow  changed:

   What|Removed |Added

   Assignee|jer...@jcline.org   |rbar...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305382] New: Review Request: tristripper - Triangle stripification (algorithm by Tanguy Fautré)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305382

Bug ID: 1305382
   Summary: Review Request: tristripper - Triangle stripification
(algorithm by Tanguy Fautré)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: projects...@smart.ms
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raphgro.fedorapeople.org/review/chess/dreamchess/tristripper.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/chess/dreamchess/tristripper-1.10-1.fc23.src.rpm
Description: Triangle stripification (algorithm by Tanguy Fautré)
Fedora Account System Username: raphgro

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=12898920

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294730] Review Request: erlang-p1_pgsql - Pure Erlang PostgreSQL driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294730

Randy Barlow  changed:

   What|Removed |Added

   Assignee|jer...@jcline.org   |rbar...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305365] Review Request: concurrentunit - Toolkit for testing multi-threaded and asynchronous applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305365

Raphael Groner  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)
 Whiteboard||Trivial




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294842] Review Request: kf5-libkdcraw - A C++ interface around LibRaw library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294842



--- Comment #4 from Rex Dieter  ---
Re: dir ownership question from comment #2 ...

turns out that:
%{_kf5_includedir}/KDCRAW/

by itself already does recursive ownership, so that the dir *and* everything
under it is owned, it is the simplified equivalent to doing:

%dir %{_kf5_includedir}/KDCRAW/
%{_kf5_includedir}/KDCRAW/*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295035] Review Request: erlang-p1_pam - epam for ejabberd to help with PAM authentication support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295035

Randy Barlow  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-02-07 16:03:23



--- Comment #6 from Randy Barlow  ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=12898853

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295009] Review Request: erlang-p1_zlib - Native zlib driver for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295009

Randy Barlow  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-02-07 16:02:50



--- Comment #7 from Randy Barlow  ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=12898861

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305365] Review Request: concurrentunit - Toolkit for testing multi-threaded and asynchronous applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305365

Raphael Groner  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1287384
 Depends On|1287384 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1287384
[Bug 1287384] xbean-4.5 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305365] Review Request: concurrentunit - Toolkit for testing multi-threaded and asynchronous applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305365

Raphael Groner  changed:

   What|Removed |Added

 Depends On||1305015




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1305015
[Bug 1305015] Missing groovy-all JAR and depmap
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305382] Review Request: tristripper - Triangle stripification (algorithm by Tanguy Fautré)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305382



--- Comment #1 from Upstream Release Monitoring 
 ---
raphgro's scratch build of tristripper-1.10-1.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12898920

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305390] New: Review Request: dreamchess-tools - DreamChess Tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305390

Bug ID: 1305390
   Summary: Review Request: dreamchess-tools - DreamChess Tools
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: projects...@smart.ms
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raphgro.fedorapeople.org/review/chess/dreamchess/dreamchess-tools.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/chess/dreamchess/dreamchess-tools-0-0.1.20141101gitf8f32aa.fc23.src.rpm
Description: DreamChess Tools
Fedora Account System Username: raphgro

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1140403] Review Request: dreamchess - open source chess game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1140403

Raphael Groner  changed:

   What|Removed |Added

 Blocks||1305390




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1305390
[Bug 1305390] Review Request: dreamchess-tools - DreamChess Tools
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294331] Review Request: erlang-oauth2 - An Oauth2 implementation for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294331

Randy Barlow  changed:

   What|Removed |Added

  Flags|needinfo?(rbar...@redhat.co |
   |m)  |



--- Comment #13 from Randy Barlow  ---
It looks like this has been fixed upstream, but they have not made a release
with the fix:

https://github.com/kivra/oauth2/issues/59

I have requested a release since they have not made one in quite some time:

https://github.com/kivra/oauth2/issues/61

The patch does not seem too bad though, so I will attempt to apply it in the
spec file:

https://github.com/kivra/oauth2/pull/60/files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294331] Review Request: erlang-oauth2 - An Oauth2 implementation for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294331

Randy Barlow  changed:

   What|Removed |Added

  Flags||needinfo?(rbar...@redhat.co
   ||m)



--- Comment #14 from Randy Barlow  ---
Whoops, didn't mean to clear the needsinfo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170875] Review Request: budgie-desktop - An elegant desktop with GNOME integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1170875



--- Comment #28 from mikey  ---
I haven't tried to remove "libgnome-volume-control" from my updated spec file
as I'm not sure how to go about it, but perhaps with some guidance we can get
it packaged up in an acceptable form.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305365] Review Request: concurrentunit - Toolkit for testing multi-threaded and asynchronous applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305365

Raphael Groner  changed:

   What|Removed |Added

 Depends On||1287384




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1287384
[Bug 1287384] xbean-4.5 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295011] Review Request: erlang-p1_mysql - Erlang MySQL driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295011

Randy Barlow  changed:

   What|Removed |Added

   Assignee|jer...@jcline.org   |rbar...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305365] New: Review Request: concurrentunit - Toolkit for testing multi-threaded and asynchronous applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305365

Bug ID: 1305365
   Summary: Review Request: concurrentunit - Toolkit for testing
multi-threaded and asynchronous applications
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: projects...@smart.ms
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raphgro.fedorapeople.org/review/java/testing/concurrentunit.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/java/testing/concurrentunit-0.4.2-1.fc23.src.rpm
Description: Toolkit for testing multi-threaded and asynchronous applications 
Fedora Account System Username: raphgro

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=12898241

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305365] Review Request: concurrentunit - Toolkit for testing multi-threaded and asynchronous applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305365



--- Comment #2 from Raphael Groner  ---
(In reply to Upstream Release Monitoring from comment #1)
> raphgro's scratch build of concurrentunit-0.4.2-1.fc23.src.rpm for rawhide
> failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12898241

Error: nothing provides mvn(org.codehaus.groovy:groovy-all) needed by
xbean-4.4-2.fc24.noarch

Obviously, not a fault of my package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295011] Review Request: erlang-p1_mysql - Erlang MySQL driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295011

Randy Barlow  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-02-07 12:18:33



--- Comment #4 from Randy Barlow  ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=12898299

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294331] Review Request: erlang-oauth2 - An Oauth2 implementation for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294331



--- Comment #16 from Upstream Release Monitoring 
 ---
rbarlow's scratch build of erlang-oauth2-0.6.0-4.fc24.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12898526

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170875] Review Request: budgie-desktop - An elegant desktop with GNOME integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1170875



--- Comment #26 from mikey  ---
Created attachment 1121945
  --> https://bugzilla.redhat.com/attachment.cgi?id=1121945=edit
Updated SPEC for budgie desktop 10.2.2

This is my attempt to update the original spec to budgie desktop 10.2.2. 

I had some issues with the validation of the desktop files so had to disable
it. The reason it was failing was for the "xsession" desktop file there is an
entry "DesktopNames" for ligthDM, which is not in the XDG specification,
looking briefly into it they seemed to be saying that this file is not a "real"
desktop file so this entry shouldn't be added to the specification. Also the
other desktop files failed as they had a 'OnlyShowIn=Budgie' which the
validator does not recognise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170875] Review Request: budgie-desktop - An elegant desktop with GNOME integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1170875



--- Comment #29 from Rex Dieter  ---
Re: .desktop validation in comment #26 ...

You really only need to validate stuff under /usr/share/applications (ie, stuff
intended to be displayed in application menus)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294730] Review Request: erlang-p1_pgsql - Pure Erlang PostgreSQL driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294730

Randy Barlow  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-02-07 12:17:36



--- Comment #8 from Randy Barlow  ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=12898298

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294368] Review Request: erlang-p1_iconv - Erlang bindings for iconv

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294368

Randy Barlow  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-02-07 12:16:42



--- Comment #7 from Randy Barlow  ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=12898296

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305365] Review Request: concurrentunit - Toolkit for testing multi-threaded and asynchronous applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305365

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #3 from gil cattaneo  ---
(In reply to Raphael Groner from comment #2)
> (In reply to Upstream Release Monitoring from comment #1)
> > raphgro's scratch build of concurrentunit-0.4.2-1.fc23.src.rpm for rawhide
> > failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12898241
> 
> Error: nothing provides mvn(org.codehaus.groovy:groovy-all) needed by
> xbean-4.4-2.fc24.noarch
> 
> Obviously, not a fault of my package.

The issues is related to newer gradle macros (... maybe ...)
i open a bug https://bugzilla.redhat.com/show_bug.cgi?id=1305015

the bug https://bugzilla.redhat.com/show_bug.cgi?id=1287384 has nothing to do
with this problem

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170875] Review Request: budgie-desktop - An elegant desktop with GNOME integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1170875



--- Comment #30 from Rex Dieter  ---
Oh, and for OnlyShowIn=... I'd recommend patching things to use/recognize
X-Budgie instead for now, at least until Budgie is registered formally.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305365] Review Request: concurrentunit - Toolkit for testing multi-threaded and asynchronous applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305365



--- Comment #1 from Upstream Release Monitoring 
 ---
raphgro's scratch build of concurrentunit-0.4.2-1.fc23.src.rpm for rawhide
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12898241

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1198498] Review Request: libwebsockets - A lightweight C library for Websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1198498



--- Comment #21 from Rich Mattes  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 NOTE: According to the source files, the license is LGPLv2; there's no
 "or any later version" statement in the copyright headers.
 NOTE: License strings in the License: field must have "and" between them,
 so it should read "LGPLv2 and BSD and MIT and zlib"
 There should also be comments as to which license applies to which pieces
- 
 the main library is LGPL, and the some of the bundled deps are not.

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 174080 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
 translations for 

[Bug 1294331] Review Request: erlang-oauth2 - An Oauth2 implementation for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294331

Randy Barlow  changed:

   What|Removed |Added

  Flags|needinfo?(rbar...@redhat.co |
   |m)  |



--- Comment #15 from Randy Barlow  ---
jcline,

I've backported the upstream patch to fix the build for Erlang 18, and made
release 4 of the package here for your review:

Spec URL: https://rbarlow.fedorapeople.org/erlang-oauth2.spec
SRPM URL: https://rbarlow.fedorapeople.org/erlang-oauth2-0.6.0-4.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294331] Review Request: erlang-oauth2 - An Oauth2 implementation for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294331

Randy Barlow  changed:

   What|Removed |Added

  Flags||needinfo?(jer...@jcline.org
   ||)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295009] Review Request: erlang-p1_zlib - Native zlib driver for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295009



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/erlang-p1_zlib

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304576] Review Request: nodejs-is-buffer - Determine if an object is Buffer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304576



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/nodejs-is-buffer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295035] Review Request: erlang-p1_pam - epam for ejabberd to help with PAM authentication support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295035



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/erlang-p1_pam

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170875] Review Request: budgie-desktop - An elegant desktop with GNOME integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1170875



--- Comment #27 from mikey  ---
Created attachment 1121946
  --> https://bugzilla.redhat.com/attachment.cgi?id=1121946=edit
Updated patch for budgie desktop 10.2.2

Here is the updated patch to go along with the spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1198498] Review Request: libwebsockets - A lightweight C library for Websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1198498



--- Comment #22 from Andy Green  ---
I pushed a patch on v1.6-stable (and master)

https://github.com/warmcat/libwebsockets/commit/ebfdb0d24d9555d745d2457d0691a4ae9770624b

It lists in LICENSE the disposition of sources that had other licences.

I also took the opportunity to make the test apps public domain (cc-zero) since
they are intended to be adapted by users into their own code without any
'viralness'.

+3) Some sources included have their own, more liberal licenses, or options
+to get original sources with the liberal terms.
+
+Original liberal license retained
+
+  - lib/sha-1.c - 3-clause BSD license retained, link to original
+  - win32port/zlib  - ZLIB license (see zlib.h)
+
+Relicensed to libwebsocket license
+
+  - lib/base64-decode.c - relicensed to LGPL2.1+SLE, link to original
+  - lib/daemonize.c - relicensed from Public Domain to LGPL2.1+SLE,
+  link to original Public Domain version
+
+Public Domain (CC-zero) to simplify reuse
+
+  - test-server/*.c
+  - test-server/*.h

That's tagged as v1.6.3

About the ciphers, yes unless lws has some reason to do something fixed itself,
things can be set at runtime by the user code with a reasonable default if not.
 As you say the library doesn't enforce anything about ciphers itself but the
code using it may do so if it wants.  Otherwise it just uses what the SSL
library defaults to.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1303434] Review Request: erlang-p1_sip - ProcessOne SIP server component in Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303434

Randy Barlow  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-02-07 20:43:33



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292287] Review Request: nodejs-is-absolute - Returns true if a file path is absolute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292287
Bug 1292287 depends on bug 1292295, which changed state.

Bug 1292295 Summary: Review Request: nodejs-is-windows - Returns true if the 
platform is windows
https://bugzilla.redhat.com/show_bug.cgi?id=1292295

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292232



--- Comment #13 from Fedora Update System  ---
nodejs-delegates-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292232

Fedora Update System  changed:

   What|Removed |Added

 Resolution|RAWHIDE |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292413] Review Request: nodejs-es6-iterator - Iterator abstraction based on ES6 specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292413



--- Comment #24 from Fedora Update System  ---
nodejs-es6-iterator-2.0.0-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292295] Review Request: nodejs-is-windows - Returns true if the platform is windows

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292295



--- Comment #13 from Fedora Update System  ---
nodejs-is-windows-0.1.0-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292232



--- Comment #14 from Fedora Update System  ---
nodejs-delegates-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292412] Review Request: nodejs-es6-symbol - ECMAScript 6 Symbol polyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292412



--- Comment #21 from Fedora Update System  ---
nodejs-es6-symbol-3.0.2-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 187318] Review Request: mondo - A program which a Linux user can utilize to create a rescue/restore CD/tape

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=187318
Bug 187318 depends on bug 759818, which changed state.

Bug 759818 Summary: Review Request: buffer - General purpose buffer program
https://bugzilla.redhat.com/show_bug.cgi?id=759818

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 759818] Review Request: buffer - General purpose buffer program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=759818

Bruno Cornec  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-02-07 20:16:02



--- Comment #32 from Bruno Cornec  ---
I've finally build the buffer package successfully for f24. I think we can now
close this ticket :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1286867] Review Request: python-novaclient-os-virtual-interfaces - Adds Virtual Interfaces support to python-novaclient

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286867

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-02-07 22:23:29



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292412] Review Request: nodejs-es6-symbol - ECMAScript 6 Symbol polyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292412



--- Comment #22 from Fedora Update System  ---
nodejs-es6-symbol-3.0.2-2.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292232] Review Request: nodejs-delegates - Delegate methods and accessors to another property

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292232



--- Comment #15 from Fedora Update System  ---
nodejs-delegates-1.0.0-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 187318] Review Request: mondo - A program which a Linux user can utilize to create a rescue/restore CD/tape

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=187318



--- Comment #67 from Bruno Cornec  ---
Now that buffer has been pushed to Fedora (Cf:
https://bugzilla.redhat.com/show_bug.cgi?id=759818) I'll work on adding
mindi-busybox and mindi before adding mondo itself.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295209] Review Request: lua-fun - functional programming library for Lua and LuaJIT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295209



--- Comment #26 from Fedora Update System  ---
lua-fun-0.1.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292295] Review Request: nodejs-is-windows - Returns true if the platform is windows

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292295



--- Comment #12 from Fedora Update System  ---
nodejs-is-windows-0.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292295] Review Request: nodejs-is-windows - Returns true if the platform is windows

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292295

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2015-12-20 13:14:10 |2016-02-07 21:24:03



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264653] Review Request: php-guzzlehttp-guzzle6 - PHP HTTP client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264653

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-02-07 22:22:54



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264653] Review Request: php-guzzlehttp-guzzle6 - PHP HTTP client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264653



--- Comment #18 from Fedora Update System  ---
php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292295] Review Request: nodejs-is-windows - Returns true if the platform is windows

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292295



--- Comment #14 from Fedora Update System  ---
nodejs-is-windows-0.1.0-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1286867] Review Request: python-novaclient-os-virtual-interfaces - Adds Virtual Interfaces support to python-novaclient

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286867



--- Comment #27 from Fedora Update System  ---
python-novaclient-os-virtual-interfaces-0.19-1.fc23 has been pushed to the
Fedora 23 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302909] Review Request: drupal8 - An open source content management platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302909
Bug 1302909 depends on bug 1264653, which changed state.

Bug 1264653 Summary: Review Request: php-guzzlehttp-guzzle6 - PHP HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1264653

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297234] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and Astropy affiliated packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297234

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
python-astropy-helpers-1.1.1-1.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4622161117

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
restsharp-105.2.3-3.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-01a328bcee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1290199] Review Request: cmake3 - Cross-platform make system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290199

roidelapl...@inuits.eu changed:

   What|Removed |Added

 CC||roidelapl...@inuits.eu



--- Comment #6 from roidelapl...@inuits.eu ---
There are 2 requirements missing in the spec file

BuildRequires:  gcc-c++
BuildRequires:  make

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297215] Review Request: dnsdist - A highly DNS-, DoS- and abuse-aware loadbalancer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297215

Roman Tsisyk  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #8 from Roman Tsisyk  ---
+ Fixed: license file is present, %license macro is used
+ Fixed: BuildRequires: systemd instead of systemd-utils
+ Fixed: %post %preun %postun scriptlets for systemd were added
+ Fixed: man pages installed uncompressed
+ Fixed: RPM spec now compiles JS from sources during %build stage
+ Fixed: bundled mbedtls is not used anymore
+ Fixed: pdns and dnsdist relation is now clear for me
+ license is acceptable (GPLv2)
+ BuildRequires  are OK
+ %check is present and all tests pass
+ mock builds [1] are ok
+ installs and works properly [2]
+ rpmlint is OK - only false-positive spelling-error

Package is APPROVED.

Further things to consider (up to you):

* it would be nice to include a sample configuration file
* bundled yahttp is used at least by pdns and your package, probably
  yahttp needs its own package

[1] tested on fedora-rawhide-x86_64 and fedora-23-armv7hl
[2] tested on fedora23-armv7hl with a configuration file from
https://github.com/PowerDNS/pdns/blob/master/pdns/dnsdistconf.lua

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review