[Bug 1339736] Review Request: c-variant - GVariant Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1339736 Yanko Kaneti changed: What|Removed |Added Blocks||1339738 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339738 [Bug 1339738] Review Request: libbus1 - Bus1 IPC Library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339738] Review Request: libbus1 - Bus1 IPC Library
https://bugzilla.redhat.com/show_bug.cgi?id=1339738 Yanko Kaneti changed: What|Removed |Added CC||yan...@declera.com Depends On||1339730, 1339735, 1339736 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339730 [Bug 1339730] Review Request: c-sundry - Collection of sundry convenience headers https://bugzilla.redhat.com/show_bug.cgi?id=1339735 [Bug 1339735] Review Request: c-rbtree - Red-Black Tree Implementation https://bugzilla.redhat.com/show_bug.cgi?id=1339736 [Bug 1339736] Review Request: c-variant - GVariant Implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339735] Review Request: c-rbtree - Red-Black Tree Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1339735 Yanko Kaneti changed: What|Removed |Added Blocks||1339738 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339738 [Bug 1339738] Review Request: libbus1 - Bus1 IPC Library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339730] Review Request: c-sundry - Collection of sundry convenience headers
https://bugzilla.redhat.com/show_bug.cgi?id=1339730 Yanko Kaneti changed: What|Removed |Added Blocks||1339738 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339738 [Bug 1339738] Review Request: libbus1 - Bus1 IPC Library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1263905] Review Request: ghc-old-time - Time library
https://bugzilla.redhat.com/show_bug.cgi?id=1263905 Jens Petersen changed: What|Removed |Added Blocks||1339913 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339913 [Bug 1339913] ghc-7.10.3 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1223673] Review Request: llvm35 - The Low Level Virtual Machine
https://bugzilla.redhat.com/show_bug.cgi?id=1223673 Jens Petersen changed: What|Removed |Added Blocks||1339913 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339913 [Bug 1339913] ghc-7.10.3 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337120] Review Request: gyazo - Fast screen capture tool
https://bugzilla.redhat.com/show_bug.cgi?id=1337120 Patrik Opravil changed: What|Removed |Added Summary|Review Request: Gyazo - |Review Request: gyazo - |Fast screen capture tool|Fast screen capture tool -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337120] Review Request: gyazo - Fast screen capture tool
https://bugzilla.redhat.com/show_bug.cgi?id=1337120 Patrik Opravil changed: What|Removed |Added CC||limburg...@gmail.com Flags||needinfo?(limburgher@gmail. ||com) --- Comment #24 from Patrik Opravil --- I am sory, but there was mistake in name. I had Gyazo with upper case G but it needs to be lower case. i would like to do new CVS request. Thank you Opravil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337434] Review Request: flatpak - Application deployment framework for desktop apps
https://bugzilla.redhat.com/show_bug.cgi?id=1337434 Alexander Larsson changed: What|Removed |Added CC||al...@redhat.com --- Comment #14 from Alexander Larsson --- The canonical release is now on github, as everything else but the mailing list is there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336833] Review Request: python-resultsdb_api - API to resultsdb
https://bugzilla.redhat.com/show_bug.cgi?id=1336833 Martin Krizek changed: What|Removed |Added Summary|Review Request: |Review Request: |resultsdb_api - API to |python-resultsdb_api - API |resultsdb |to resultsdb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1244571] Review Request: drush - Command line shell and scripting interface for Drupal
https://bugzilla.redhat.com/show_bug.cgi?id=1244571 --- Comment #18 from Fedora Update System --- drush-6.7.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1329188] Review Request: nvml - Non-Volatile Memory Library
https://bugzilla.redhat.com/show_bug.cgi?id=1329188 Krzysztof Czurylo changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-26 04:20:35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332720] Review Request: kdepim-addons - Additional plugins for KDE PIM applications
https://bugzilla.redhat.com/show_bug.cgi?id=1332720 --- Comment #3 from Rex Dieter --- pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1319839] Review Request: rocket-depot - GTK+ 3 rdesktop/ xfreerdp front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1319839 --- Comment #11 from Fedora Update System --- rocket-depot-1.0.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333970] Review Request: plasma-applet-redshift-control - Plasma 5 applet for redshift
https://bugzilla.redhat.com/show_bug.cgi?id=1333970 --- Comment #13 from Fedora Update System --- plasma-applet-redshift-control-1.0.17-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1319839] Review Request: rocket-depot - GTK+ 3 rdesktop/ xfreerdp front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1319839 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-05-07 07:40:46 |2016-05-26 06:56:29 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1340061] systemd presets request - lircd.service, lircd.socket
https://bugzilla.redhat.com/show_bug.cgi?id=1340061 --- Comment #1 from Alec Leamas --- Perhaps in the wrong order, 0.9.4 is upcoming, but real soon (tm). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1340061] New: systemd presets request - lircd.service, lircd.socket
https://bugzilla.redhat.com/show_bug.cgi?id=1340061 Bug ID: 1340061 Summary: systemd presets request - lircd.service, lircd.socket Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: leamas.a...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org * Does the service require post-rpm-installation configuration in order to be useful (for example, does it need manual edits to a configuration file)? From version 0.9.4: No * Does the service listen on a network socket for connections originating on a separate physical or virtual machine? No, it listens to a socket created by itself (/var/run/lircd.socket). * Is the service non-persistent (i.e. run once at startup and exit)? No. * What is the exact name (or names) of the systemd unit files to be enabled? lircd.socket. * Is this request for all Fedora deliverables or only for some Editions: All. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1325351] Review Request: perl-RDF-NS - Popular RDF name space prefixes from prefix.cc
https://bugzilla.redhat.com/show_bug.cgi?id=1325351 Jitka Plesnikova changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-RDF-NS-20150725-1.fc25.noarch.rpm | sort | uniq -c 1 /usr/bin/perl 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(:VERSION) >= 5.10.0 1 perl(App::rdfns) 1 perl(Carp) 1 perl(File::ShareDir) >= 1.00 1 perl(RDF::NS) 1 perl(RDF::SN) 1 perl(RDF::Trine::Node::Blank) 1 perl(RDF::Trine::Node::Resource) 1 perl(Scalar::Util) 1 perl(URI) 1 perl(base) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-RDF-NS-20150725-1.fc25.noarch.rpm | sort | uniq -c 1 perl(App::rdfns) = 20150725 1 perl(RDF::NS) = 20150725 1 perl(RDF::NS::Trine) = 20150725 1 perl(RDF::NS::URIS) = 20150725 1 perl(RDF::SN) = 20150725 1 perl-RDF-NS = 20150725-1.fc25 Binary provides are Ok. $ rpmlint ./perl-RDF-NS* perl-RDF-NS.noarch: W: spelling-error %description -l en_US http -> HTTP perl-RDF-NS.src: W: spelling-error %description -l en_US http -> HTTP 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok TODO: Please add perl-generators Please consider fixing 'TODO' items. The package looks good. Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags|needinfo? | --- Comment #24 from Neil Horman --- I'm not worried about the license address, no, and would waive them, though you should contact upstream for those projects and provide them with patches to fix that. What worries me more is how you incorporated those projects to yours. While theres no license issue with doing so, of the three packages that you incorporate: jfreechart is already independently packaged for fedora hibernate is already independently packaged for fedora gritty is not packaged, but easily could be I'm sorry I didn't notice your 3rd party incorporations previously, but as a rule, you may not do that. separate projects need to be packaged independently so that other applications can use them and pick up updates automatically. At a minimum you need to not build or package the jfreechart and hibernate code, instead creating a BuildRequires for the corresponding existing packages, so those are used properly. Ideally you would also package gritty separately, but I can likely waive that as its not currently packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339737 Jan Grulich changed: What|Removed |Added CC||jgrul...@redhat.com Assignee|nob...@fedoraproject.org|jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339839] Review Request: kf5-mailimporter - Mail importer library
https://bugzilla.redhat.com/show_bug.cgi?id=1339839 Jan Grulich changed: What|Removed |Added CC||jgrul...@redhat.com Assignee|nob...@fedoraproject.org|jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339840] Review Request: kf5-mailcommon - Mail applications support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339840 Jan Grulich changed: What|Removed |Added CC||jgrul...@redhat.com Assignee|nob...@fedoraproject.org|jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339853] Review Request: kf5-libksieve - Sieve support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339853 Jan Grulich changed: What|Removed |Added CC||jgrul...@redhat.com Assignee|nob...@fedoraproject.org|jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1329668] Review Request: nodejs-rhea -reactive AMQP 1.0 library.
https://bugzilla.redhat.com/show_bug.cgi?id=1329668 Irina Boverman changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339004] Review Request: perl-libintl-perl - Internationalization library for Perl, compatible with gettext
https://bugzilla.redhat.com/show_bug.cgi?id=1339004 --- Comment #2 from Emmanuel Seyman --- (In reply to Petr Pisar from comment #1) > > FIX: The gettext_xs/Makefile.PL license comment is wrong. It should declare > `LGPLv2+'. I cannot find any `GPLv2+' declaration in the sources. Indeed. Fixed. > FIX: Build-require `perl-generators'. > FIX: Build-require `perl-devel' (gettext_xs/gettext_xs.xs:20). Fixed. > TODO: Do not build-require `perl(Carp)'. It's not used when running tests. > > TODO: You can replace the `-exec rm' command with `-delete' to avoid > executing `rm' in the %install section. Fixed. > FIX: Tests fails for me: > [...] > This is because the ./tests/03bind_textdomain_codeset_pp.t test expects > support de_AT locale. You have to build-require glibc-langpack-de. Wow, good catch. Fixed. > TODO: Report the old FSF address. Done. This is ticket #114731 on CPAN's RT: https://rt.cpan.org/Public/Bug/Display.html?id=114731 > TODO: You could correct the shell bang in the examples not to use > /usr/local/bin/perl. Done. I now also convert the non-UTF-8 files to UTF-8. > FIX: This new package must conflicts or obsoletes perl-libintl package. The > two clashes on files. I believe you need `Obsoletes: perl-libintl < 1.25'. I was convinced that a Provides was sufficient. Added. > TODO: List the optional run-time dependencies as Recommends or Suggests. Done. Spec URL: http://people.parinux.org/~seyman/fedora/perl-libintl-perl/perl-libintl-perl.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-libintl-perl/perl-libintl-perl-1.25-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339737 Jan Grulich changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jan Grulich --- Couldn't lunch fedora-review due to dependencies, but it looks good to me: 1) naming: ok 2) sources: ok 3) url: ok 4) macros: ok 5) scriptlets: ok Similar to other KF5 packages, nothing what could be wrong. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #26 from Neil Horman --- oh, you're right, my bad. I saw the license issues you put up and assumed you were using them direct from your project. You're good on hibernate and jfreechart As for gritty, I concur with your approach. Ideally it should be packaged independently, but given that upstream development is halted, I'd be ok with your current approach, though I would recommend looking for an alternate implementation, just in case something breaks Ok, Upload your new spec and srpm when you're ready and I'll give it a review. Thanks! Neil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #25 from Rick Tierney --- Created attachment 1162001 --> https://bugzilla.redhat.com/attachment.cgi?id=1162001&action=edit opa-fmgui spec file I'm a bit unsure of your use of the term "incorporations", so let me clarify... The only 3rd party library for which we include the source code is gritty. All other 3rd party libraries are being pulled in using BuildRequires in the spec file (see attached). Binary RPM -- Jar-files for these libraries are being placed in the lib/ folder along with their licenses files. Source RPM -- Only opa-fmgui and gritty source code is included in the SRPM Gritty -- It looks like the Gritty project was cancelled as shown on the GitHub website here: https://github.com/walterDurin/gritty/tree/master. I did find it in the Google Code Archive here: https://code.google.com/archive/p/gritty/downloads, but since it hasn't been packaged for Fedora it needed to be built. Is this an acceptable way to package our project? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339737 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Rex Dieter --- thanks, pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339004] Review Request: perl-libintl-perl - Internationalization library for Perl, compatible with gettext
https://bugzilla.redhat.com/show_bug.cgi?id=1339004
Petr Pisar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ---
Spec file changes:
--- perl-libintl-perl.spec.old 2016-05-24 00:12:27.0 +0200
+++ perl-libintl-perl.spec 2016-05-26 14:36:31.0 +0200
@@ -1,9 +1,9 @@
Summary:Internationalization library for Perl, compatible with gettext
Name: perl-libintl-perl
Version:1.25
-Release:1%{?dist}
+Release:2%{?dist}
# gettext_xs/gettext_xs.pm: GPLv3+
-# gettext_xs/Makefile.PL: GPLv2+
+# gettext_xs/Makefile.PL: LGPLv2+
# lib/Locale/gettext_xs.pod:LGPLv2+
# lib/Locale/RecodeData.pm: GPLv3+
# lib/Locale/libintlFAQ.pod:LGPLv2+
@@ -13,12 +13,15 @@
Source:
http://search.cpan.org/CPAN/authors/id/G/GU/GUIDO/libintl-perl-%{version}.tar.gz
# this module was renamed in the f25 dev cycle
Provides: perl-libintl = %{version}-%{release}
+Obsoletes: perl-libintl < 1.25
BuildRequires: coreutils
BuildRequires: findutils
BuildRequires: gcc
BuildRequires: make
BuildRequires: perl
+BuildRequires: perl-devel
+BuildRequires: perl-generators
BuildRequires: perl(Config)
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(File::Find)
@@ -28,7 +31,6 @@
# Run-time:
BuildRequires: perl(base)
BuildRequires: perl(bytes)
-BuildRequires: perl(Carp)
BuildRequires: perl(constant)
BuildRequires: perl(Cwd)
BuildRequires: perl(DynaLoader)
@@ -44,6 +46,8 @@
BuildRequires: perl(File::ShareDir)
BuildRequires: perl(I18N::Langinfo)
# Tests:
+# Needed for tests/03bind_textdomain_codeset_pp.t
+BuildRequires: glibc-langpack-de
BuildRequires: perl(File::Basename)
BuildRequires: perl(Test)
BuildRequires: perl(Test::Harness)
@@ -51,6 +55,8 @@
Requires: perl(Carp)
Requires: perl(Encode::Alias)
Requires: perl(POSIX)
+Recommends: perl(File::ShareDir)
+Recommends: perl(I18N::Langinfo)
%{?perl_default_filter}
@@ -65,6 +71,14 @@
find -type f -exec chmod -x {} \;
find lib/Locale gettext_xs \( -name '*.pm' -o -name '*.pod' \) \
-exec sed -i -e '/^#! \/bin\/false/d' {} \;
+# Fix rpmlint errors and warnings
+cd sample/simplecal
+sed -i -e '1i#!%{__perl}' bin/simplecal.pl Makefile.PL
+for file in po/*.po; do
+iconv -f ISO-8859-1 -t UTF-8 -o $file.new $file && \
+mv $file.new $file
+done
+
%build
perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}"
@@ -73,7 +87,7 @@
%install
make pure_install DESTDIR=%{buildroot}
find %{buildroot} -type f \( -name .packlist -o \
- -name '*.bs' -size 0 \) -exec rm -f {} ';'
+ -name '*.bs' -size 0 \) -delete
%{_fixperms} %{buildroot}
%check
@@ -88,6 +102,9 @@
%{_mandir}/man?/*
%changelog
+* Wed May 25 2016 Emmanuel Seyman - 1.25-2
+- Take into account the re-review comments (#1339004)
+
* Sat May 21 2016 Emmanuel Seyman - 1.25-1
- Update package to 1.25-1
- Rename package to perl-libintl-perl, the module's name on CPAN
All the issues are fixed.
TODO: Build-require `glibc-common' for iconv tool in %prep section.
$ rpmlint perl-libintl-perl.spec ../SRPMS/perl-libintl-perl-1.25-2.fc25.src.rpm
../RPMS/x86_64/perl-libintl-perl-*
perl-libintl-perl.src: W: spelling-error Summary(en_US) gettext -> get text,
get-text, Georgette
perl-libintl-perl.src: W: spelling-error %description -l en_US gettext -> get
text, get-text, Georgette
perl-libintl-perl.x86_64: W: spelling-error Summary(en_US) gettext -> get text,
get-text, Georgette
perl-libintl-perl.x86_64: W: spelling-error %description -l en_US gettext ->
get text, get-text, Georgette
perl-libintl-perl.x86_64: E: incorrect-fsf-address
/usr/share/perl5/vendor_perl/Locale/gettext_xs.pod
perl-libintl-perl.x86_64: E: incorrect-fsf-address
/usr/share/perl5/vendor_perl/Locale/libintlFAQ.pod
perl-libintl-perl.x86_64: W: manifest-in-perl-module
/usr/share/doc/perl-libintl-perl/sample/simplecal/MANIFEST
3 packages and 1 specfiles checked; 2 errors, 5 warnings.
rpmlint is Ok.
Package builds in F25
(http://koji.fedoraproject.org/koji/taskinfo?taskID=14261048). Ok.
Please consider fixing the `TODO' item before building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339737 --- Comment #3 from Jan Grulich --- One minor issue, licensecheck shows also LGPL (v2 or later) and GPL (v2 or later). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339839] Review Request: kf5-mailimporter - Mail importer library
https://bugzilla.redhat.com/show_bug.cgi?id=1339839 Jan Grulich changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jan Grulich --- Couldn't lunch fedora-review due to dependencies, but it looks good to me: 1) naming: ok 2) sources: ok 3) url: ok 4) macros: ok 5) scriptlets: ok 6) rpmlint: ok 7) license: ok Similar to other KF5 packages, nothing what could be wrong. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339839] Review Request: kf5-mailimporter - Mail importer library
https://bugzilla.redhat.com/show_bug.cgi?id=1339839 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Rex Dieter --- thanks, pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339853] Review Request: kf5-libksieve - Sieve support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339853 Jan Grulich changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jan Grulich --- Couldn't lunch fedora-review due to dependencies, but it looks good to me: 1) naming: ok 2) sources: ok 3) url: ok 4) macros: ok 5) scriptlets: ok 6) rpmlint: ok 7) license: missing LGPLv2 Similar to other KF5 packages, nothing what could be wrong. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339840] Review Request: kf5-mailcommon - Mail applications support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339840 Jan Grulich changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jan Grulich --- Couldn't lunch fedora-review due to dependencies, but it looks good to me: 1) naming: ok 2) sources: ok 3) url: ok 4) macros: ok 5) scriptlets: ok 6) rpmlint: ok 7) license: missing LGPLv2 Similar to other KF5 packages, nothing what could be wrong. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1285767] Review Request: golang-github-seccomp-libseccomp-golang - The libseccomp golang bindings repository
https://bugzilla.redhat.com/show_bug.cgi?id=1285767 --- Comment #10 from Fedora Update System --- golang-github-seccomp-libseccomp-golang-0-0.4.git60c9953.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-674de83204 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332719] Review Request: kdepim-apps-libs - KDE PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1332719 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kdepim-apps-libs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337434] Review Request: flatpak - Application deployment framework for desktop apps
https://bugzilla.redhat.com/show_bug.cgi?id=1337434 --- Comment #15 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/flatpak -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339853] Review Request: kf5-libksieve - Sieve support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339853 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Rex Dieter --- thanks, pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339703] Review Request: kf5-libgravatar - Gravatar support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339703 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-libgravatar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339840] Review Request: kf5-mailcommon - Mail applications support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339840 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Rex Dieter --- thanks, pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332719] Review Request: kdepim-apps-libs - KDE PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1332719 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Alias|kdepim-apps-lib | Last Closed||2016-05-26 10:20:21 --- Comment #6 from Rex Dieter --- imported, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339737 Bug 1339737 depends on bug 1332719, which changed state. Bug 1332719 Summary: Review Request: kdepim-apps-libs - KDE PIM common libraries https://bugzilla.redhat.com/show_bug.cgi?id=1332719 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332254] Review Request: kf5-calendarsupport - KDE PIM library for calendar and even handling
https://bugzilla.redhat.com/show_bug.cgi?id=1332254 Bug 1332254 depends on bug 1332719, which changed state. Bug 1332719 Summary: Review Request: kdepim-apps-libs - KDE PIM common libraries https://bugzilla.redhat.com/show_bug.cgi?id=1332719 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339703] Review Request: kf5-libgravatar - Gravatar support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339703 Rex Dieter changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-26 10:22:17 --- Comment #5 from Rex Dieter --- imported, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332720] Review Request: kdepim-addons - Additional plugins for KDE PIM applications
https://bugzilla.redhat.com/show_bug.cgi?id=1332720 Bug 1332720 depends on bug 1339703, which changed state. Bug 1339703 Summary: Review Request: kf5-libgravatar - Gravatar support library https://bugzilla.redhat.com/show_bug.cgi?id=1339703 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339737 Bug 1339737 depends on bug 1339703, which changed state. Bug 1339703 Summary: Review Request: kf5-libgravatar - Gravatar support library https://bugzilla.redhat.com/show_bug.cgi?id=1339703 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336833] Review Request: python-resultsdb_api - API to resultsdb
https://bugzilla.redhat.com/show_bug.cgi?id=1336833 --- Comment #6 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-resultsdb_api -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332720] Review Request: kdepim-addons - Additional plugins for KDE PIM applications
https://bugzilla.redhat.com/show_bug.cgi?id=1332720 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kdepim-addons -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1325351] Review Request: perl-RDF-NS - Popular RDF name space prefixes from prefix.cc
https://bugzilla.redhat.com/show_bug.cgi?id=1325351 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-RDF-NS -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339737 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-messagelib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339839] Review Request: kf5-mailimporter - Mail importer library
https://bugzilla.redhat.com/show_bug.cgi?id=1339839 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-mailimporter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339853] Review Request: kf5-libksieve - Sieve support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339853 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-libksieve -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339004] Review Request: perl-libintl-perl - Internationalization library for Perl, compatible with gettext
https://bugzilla.redhat.com/show_bug.cgi?id=1339004 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-libintl-perl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339840] Review Request: kf5-mailcommon - Mail applications support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339840 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-mailcommon -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1340152] New: Review Request: python-certbot-apache - Apache plugin to automatically configure certificate via certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1340152 Bug ID: 1340152 Summary: Review Request: python-certbot-apache - Apache plugin to automatically configure certificate via certbot Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: james.hoga...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jhogarth.fedorapeople.org/certbot-apache/python-certbot-apache.spec SRPM URL: https://jhogarth.fedorapeople.org/certbot-apache/python-certbot-apache-0.6.0-1.fc25.src.rpm Description: This is a plugin for the certbot tool to automatically authenticate and install an ssl certificate in a httpd mod_ssl instance. This adds the --apache option to certbot and will automatically lookup ssl configuration to adjust the vhost to the relevant domain being authenticated. Fedora Account System Username: jhogarth -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1340152] Review Request: python-certbot-apache - Apache plugin to automatically configure certificate via certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1340152 James Hogarth changed: What|Removed |Added Blocks||1339752 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339752 [Bug 1339752] Package the Apache httpd plugin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337120] Review Request: gyazo - Fast screen capture tool
https://bugzilla.redhat.com/show_bug.cgi?id=1337120 Jon Ciesla changed: What|Removed |Added Flags|needinfo?(limburgher@gmail. | |com)| --- Comment #25 from Jon Ciesla --- You'll need to resubmit a request with the corrected name, and follow the EOL procedure for the old one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332720] Review Request: kdepim-addons - Additional plugins for KDE PIM applications
https://bugzilla.redhat.com/show_bug.cgi?id=1332720 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-26 10:48:50 --- Comment #5 from Rex Dieter --- imported, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1325351] Review Request: perl-RDF-NS - Popular RDF name space prefixes from prefix.cc
https://bugzilla.redhat.com/show_bug.cgi?id=1325351 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-RDF-NS-20150725-1.fc25 Resolution|--- |RAWHIDE Last Closed||2016-05-26 10:49:55 --- Comment #3 from Petr Pisar --- Thank you for the review and the repository. I added the new dependency. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339004] Review Request: perl-libintl-perl - Internationalization library for Perl, compatible with gettext
https://bugzilla.redhat.com/show_bug.cgi?id=1339004 --- Comment #5 from Emmanuel Seyman --- (In reply to Petr Pisar from comment #3) > > TODO: Build-require `glibc-common' for iconv tool in %prep section. I've added this to my local copy so it will be imported in the repo. > Resolution: Package APPROVED. Repo requested. Thank you for the review, Petr. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339737 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-26 10:52:43 --- Comment #5 from Rex Dieter --- thanks, imported -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339840] Review Request: kf5-mailcommon - Mail applications support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339840 Bug 1339840 depends on bug 1339737, which changed state. Bug 1339737 Summary: Review Request: kf5-messagelib - KDE Message libraries https://bugzilla.redhat.com/show_bug.cgi?id=1339737 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332720] Review Request: kdepim-addons - Additional plugins for KDE PIM applications
https://bugzilla.redhat.com/show_bug.cgi?id=1332720 Bug 1332720 depends on bug 1339737, which changed state. Bug 1339737 Summary: Review Request: kf5-messagelib - KDE Message libraries https://bugzilla.redhat.com/show_bug.cgi?id=1339737 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339839] Review Request: kf5-mailimporter - Mail importer library
https://bugzilla.redhat.com/show_bug.cgi?id=1339839 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-26 10:55:43 --- Comment #4 from Rex Dieter --- thanks, imported -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339840] Review Request: kf5-mailcommon - Mail applications support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339840 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-26 10:59:20 --- Comment #4 from Rex Dieter --- thanks, imported -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332720] Review Request: kdepim-addons - Additional plugins for KDE PIM applications
https://bugzilla.redhat.com/show_bug.cgi?id=1332720 Bug 1332720 depends on bug 1339840, which changed state. Bug 1339840 Summary: Review Request: kf5-mailcommon - Mail applications support library https://bugzilla.redhat.com/show_bug.cgi?id=1339840 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339840] Review Request: kf5-mailcommon - Mail applications support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339840 Bug 1339840 depends on bug 1339839, which changed state. Bug 1339839 Summary: Review Request: kf5-mailimporter - Mail importer library https://bugzilla.redhat.com/show_bug.cgi?id=1339839 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339853] Review Request: kf5-libksieve - Sieve support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339853 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-26 11:02:08 --- Comment #4 from Rex Dieter --- imported, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1340152] Review Request: python-certbot-apache - Apache plugin to automatically configure certificate via certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1340152 --- Comment #1 from James Hogarth --- Rawhide koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14261800 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #27 from Rick Tierney --- Great, I'm glad that we cleared that up! We don't have immediate plans to replace gritty, but it is likely that we will implement our own version of this functionality in the future. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338999] Review Request: perl-MooseX-Role-Strict - Use strict 'roles' in Moose
https://bugzilla.redhat.com/show_bug.cgi?id=1338999 Emmanuel Seyman changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-26 11:17:04 --- Comment #4 from Emmanuel Seyman --- The package has been imported, built for rawhide and updates have been issued for F24 and F23. Thank you for the review, Jikta. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1335078] Review Request: perl-Template-Plugin-HTML-Strip - HTML:: Strip filter for Template Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1335078 Emmanuel Seyman changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-26 11:17:08 --- Comment #4 from Emmanuel Seyman --- The package has been imported, built for rawhide and updates have been issued for F24 and F23. Thank you for the review, Jikta. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339004] Review Request: perl-libintl-perl - Internationalization library for Perl, compatible with gettext
https://bugzilla.redhat.com/show_bug.cgi?id=1339004 Emmanuel Seyman changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-26 11:19:09 --- Comment #6 from Emmanuel Seyman --- That was fast... I've imported perl-libintl-perl and retired perl-libintl on the master branch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337434] Review Request: flatpak - Application deployment framework for desktop apps
https://bugzilla.redhat.com/show_bug.cgi?id=1337434 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337434] Review Request: flatpak - Application deployment framework for desktop apps
https://bugzilla.redhat.com/show_bug.cgi?id=1337434 --- Comment #16 from Fedora Update System --- flatpak-0.6.2-1.fc24 gnome-software-3.20.2-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8a483bb84c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339327] Review Request: libintelnvm-i18n - Internationalization library supporting a subset of internationalization functionality.
https://bugzilla.redhat.com/show_bug.cgi?id=1339327 --- Comment #3 from Namratha Kothapalli --- Updated tag to libintelnvm-i18n- from v Also, removed attr settings. Spec: https://github.com/01org/intelnvmi18nlibrary/releases/download/libintelnvm-i18n-1.0.0.1014/libintelnvm-i18n.spec SRPM: https://github.com/01org/intelnvmi18nlibrary/releases/download/libintelnvm-i18n-1.0.0.1014/libintelnvm-i18n-1.0.0.1014-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1340152] Review Request: python-certbot-apache - Apache plugin to automatically configure certificate via certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1340152 --- Comment #2 from James Hogarth --- Noticed a missing python2- provides so spec updated Spec URL: https://jhogarth.fedorapeople.org/certbot-apache/python-certbot-apache.spec SRPM URL: https://jhogarth.fedorapeople.org/certbot-apache/python-certbot-apache-0.6.0-2.fc25.src.rpm Rawhide koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14262347 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1340152] Review Request: python-certbot-apache - Apache plugin to automatically configure certificate via certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1340152 Tim Flink changed: What|Removed |Added Status|NEW |ASSIGNED CC||tfl...@redhat.com Assignee|nob...@fedoraproject.org|tfl...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparser - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 --- Comment #22 from Fedora Update System --- python-xunitparser-1.3.3-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333525] Review Request: python-xunitparser - Read JUnit/ XUnit XML files and map them to Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1333525 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-05-26 13:32:36 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1327566] Review Request: php-nikic-php-parser - A PHP parser written in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1327566 --- Comment #20 from Fedora Update System --- php-PHPParser-1.4.1-4.fc24, php-jeremeamia-superclosure-2.2.0-3.fc24, php-nikic-php-parser-2.1.0-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1331937] Review Request: php-composer-ca-bundle - Lets you find a path to the system CA
https://bugzilla.redhat.com/show_bug.cgi?id=1331937 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-05-26 13:33:27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1331937] Review Request: php-composer-ca-bundle - Lets you find a path to the system CA
https://bugzilla.redhat.com/show_bug.cgi?id=1331937 --- Comment #13 from Fedora Update System --- php-composer-ca-bundle-1.0.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1312939] Review Request: mongo-c-driver - Client library written in C for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1312939 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1312939] Review Request: mongo-c-driver - Client library written in C for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1312939 --- Comment #29 from Fedora Update System --- mongo-c-driver-1.3.5-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1327566] Review Request: php-nikic-php-parser - A PHP parser written in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1327566 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-05-26 13:33:22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339029] Review Request: libintelnvm-cim - Framework library for Intel NVM storage common information model (CIM) providers.
https://bugzilla.redhat.com/show_bug.cgi?id=1339029 --- Comment #2 from Namratha Kothapalli --- Incorporated feedback - Switched naming scheme, not disabling debug package, removed attr settings, deleted variables, got rid of fedora-review errors. Updated URLs - Spec URL: https://github.com/01org/intelnvmcimlibrary/releases/download/libintelnvm-cim-1.0.0.1036/libintelnvm-cim.spec SRPM URL: https://github.com/01org/intelnvmcimlibrary/releases/download/libintelnvm-cim-1.0.0.1036/libintelnvm-cim-1.0.0.1036-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336008] Review Request: keycloak-httpd-client-install - Tools to configure Apache HTTPD as Keycloak client
https://bugzilla.redhat.com/show_bug.cgi?id=1336008
--- Comment #4 from John Dennis ---
Thank you Rob for a good review, you caught a number of things I missed and I
learned something new (man --warnings) :-)
I've updated the spec and srpm in the same location.
I addressed all the issues you raised with the exception of the "Missing %dir
for %{_datadir}/python-%{srcname}". I believe that is the correct idiom. I want
*both* the directory and it's contents packaged, not just the directory (which
is what prefixing with %dir would do).
A couple of notes:
The package now contains a ChangeLog.
The package structure was reworked based on your suggestions. There is now a
main package (keycloak-httpd-client-install) and it will cause one of or both
of the python2-keycloak-httpd-client-install or the
python3-keycloak-httpd-client-install sub-packages to be installed depending up
which (system) python environment you're installing in. All the common files
are in the main package. The Python specific files are in either the
python2-keycloak-httpd-client-install or the
python3-keycloak-httpd-client-install sub-packages. Only the
python3-keycloak-httpd-client-install sub-package installs the
keycloak-httpd-client-install script per the packaging guidelines. This is why
if you install in a Py2 system environment you'll get all 3 packages, the main
package, the py2 package for Py2 tools that might import the package/module,
and the Py3 package so the script is present and can run. If all this sounds a
bit convoluted it is because the Python packaging guidelines require it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337434] Review Request: flatpak - Application deployment framework for desktop apps
https://bugzilla.redhat.com/show_bug.cgi?id=1337434 --- Comment #17 from Fedora Update System --- flatpak-0.6.2-1.fc23 ostree-2016.5-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f9167af92a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1329668] Review Request: nodejs-rhea -reactive AMQP 1.0 library.
https://bugzilla.redhat.com/show_bug.cgi?id=1329668 --- Comment #17 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-rhea -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339302] Review Request: libintelnvm-cli - Framework library supporting common Intel NVM storage CLI applications.
https://bugzilla.redhat.com/show_bug.cgi?id=1339302 --- Comment #3 from Namratha Kothapalli --- Updated URLs - Spec URL: https://github.com/01org/intelnvmclilibrary/releases/download/libintelnvm-cli-1.0.0.1094/libintelnvm-cli.spec SRPM URL: https://github.com/01org/intelnvmclilibrary/releases/download/libintelnvm-cli-1.0.0.1094/libintelnvm-cli-1.0.0.1094-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336833] Review Request: python-resultsdb_api - API to resultsdb
https://bugzilla.redhat.com/show_bug.cgi?id=1336833 --- Comment #7 from Fedora Update System --- python-resultsdb_api-1.2.2-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f02a31c029 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336833] Review Request: python-resultsdb_api - API to resultsdb
https://bugzilla.redhat.com/show_bug.cgi?id=1336833 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336833] Review Request: python-resultsdb_api - API to resultsdb
https://bugzilla.redhat.com/show_bug.cgi?id=1336833 --- Comment #8 from Fedora Update System --- python-resultsdb_api-1.2.2-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-bb935fa7df -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336833] Review Request: python-resultsdb_api - API to resultsdb
https://bugzilla.redhat.com/show_bug.cgi?id=1336833 --- Comment #9 from Fedora Update System --- python-resultsdb_api-1.2.2-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-701730b750 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co ||m) --- Comment #28 from Rick Tierney --- From Comment #12, you wrote: Package includes License files Third_Party_Copyright_Notices_and_Licenses.docx and THIRD-PARTY-README which seem to relate to code which is not packaged in this srpm. If that is the case, then these files should not be packaged. If it is the case, then the license needs to change in the spec file, the docx files needs to be converted to text and the binaries need to have thier licensing ennumerated. (In reply to Neil Horman from comment #13) > What you need to do is go through the code and determine which code is > licensed in which way. Your spec file indicates its all BSD, but the docs > in the source tarball indicate their are multiple licenses. You need to > figure out how the code is licensed and make the spec file agree with that, > following the conventions in the fedora packaging and licensing guidelines. Neil: The above statements come from comments 12 and 13 and were in response to Robert Amato's questions regarding license files. I'm trying to determine the correct course of action regarding whether to include certain files or not. The driving force here is to comply with Fedora Packaging Guidelines AND satisfy criteria set forth by the Intel Legal Dept for purposes that go beyond the Fedora Packaging process. If these two criteria conflict, then I will have to track two separate branches and I'd prefer not to do that if possible. On the one hand, our Legal team has instructed us to: 1. Include all the 3rd Party license files in same folder as the jar files for the binary RPM. 2. Include the following in both RPM and SRPM: a. Third_Party_Copyright_Notices_and_Licenses: Contains ALL applicable licenses for 3rd parties and more. This was originially a MS-Word document that I changed to a text file. b. LICENSE: BSD (3-clause) for opa-fmgui c. THIRD-PARTY-README: Listing of 3rd party libraries and the location of their license files On the other hand, based on your answers to previous questions we should: a. Remove the Third_Party_Copyright_Notices_and_Licenses and THIRD-PARTY-README files because their source code isn't packaged b. And this part isn't clear to me... whether the license files should be in the RPM lib/ folder with jar files or not. If it is okay to do this then I would rather leave it this way to comply with Intel Legal. I want to make sure I have everything in the right place and omit what is not permitted. Could you weigh in on this? Thanks! Rick -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Rick Tierney changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co ||m) --- Comment #29 from Rick Tierney --- (In reply to Rick Tierney from comment #28) > From Comment #12, you wrote: > > Package includes License files > Third_Party_Copyright_Notices_and_Licenses.docx > and THIRD-PARTY-README which seem to relate to code which is not packaged in > this srpm. If that is the case, then these files should not be packaged. > If it is the case, then the license needs to change in the spec file, the > docx files needs to be converted to text and the binaries need to have thier > licensing ennumerated. > > > (In reply to Neil Horman from comment #13) > > What you need to do is go through the code and determine which code is > > licensed in which way. Your spec file indicates its all BSD, but the docs > > in the source tarball indicate their are multiple licenses. You need to > > figure out how the code is licensed and make the spec file agree with that, > > following the conventions in the fedora packaging and licensing guidelines. > > Neil: > The above statements come from comments 12 and 13 and were in response to > Robert Amato's questions regarding license files. I'm trying to determine > the correct course of action regarding whether to include certain files or > not. The driving force here is to comply with Fedora Packaging Guidelines > AND satisfy criteria set forth by the Intel Legal Dept for purposes that go > beyond the Fedora Packaging process. If these two criteria conflict, then I > will have to track two separate branches and I'd prefer not to do that if > possible. > > On the one hand, our Legal team has instructed us to: > 1. Include all the 3rd Party license files in same folder as the jar files > for the binary RPM. > 2. Include the following in both RPM and SRPM: >a. Third_Party_Copyright_Notices_and_Licenses: Contains ALL applicable > licenses for 3rd parties and more. This was originially a MS-Word document > that I changed to a text file. >b. LICENSE: BSD (3-clause) for opa-fmgui >c. THIRD-PARTY-README: Listing of 3rd party libraries and the location of > their license files > > On the other hand, based on your answers to previous questions we should: >a. Remove the Third_Party_Copyright_Notices_and_Licenses and > THIRD-PARTY-README files because their source code isn't packaged >b. And this part isn't clear to me... whether the license files should be > in the RPM lib/ folder with jar files or not. If it is okay to do this then > I would rather leave it this way to comply with Intel Legal. > > I want to make sure I have everything in the right place and omit what is > not permitted. Could you weigh in on this? > > Thanks! > Rick Addendum: I have figured out all of the licenses that are being used and updated the License tag in the spec file. I think that part of the issue is complete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1317887] Review Request: libfastjson - C json library
https://bugzilla.redhat.com/show_bug.cgi?id=1317887 --- Comment #9 from Michael Schwendt --- > Name: libfastjson > Group: Development/Libraries And after many years, in 2016 the base group for runtime library packages still is "System Environment/Libraries". I wonder which packages you've looked at as examples? Btw, nowadays the Group tag is optional: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections > Requires: pkgconfig Unjustified and overly restrictive. There is absolutely no need for an explicit dependency on pkgconfig. Certainly you could use libfastjson-devel without using pkg-config. Further, for several years already, there are automatic Requires/Provides for packages containing and depending on .pc files. > %check > make V=1 check > > %install That's the wrong order of those sections. Not a major issue, but the %check section is processed _after_ %install (so it would be possible to run checks inside the buildroot). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
