[Bug 1338505] Review Request: planex - RPM build tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1338505

Robin Lee  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
Last Closed||2016-07-10 22:21:49




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354229] New: Review Request: nodejs-stringscanner - StringScanner performs lexical scanning operations on a string

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354229

Bug ID: 1354229
   Summary: Review Request: nodejs-stringscanner - StringScanner
performs lexical scanning operations on a string
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-stringscanner/nodejs-stringscanner.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-stringscanner/nodejs-stringscanner-0.0.3-1.fc24.src.rpm
Description: StringScanner performs lexical scanning operations on a string
Fedora Account System Username: jsmith

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354229] Review Request: nodejs-stringscanner - StringScanner performs lexical scanning operations on a string

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354229

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews),
   ||1269538 (IoT)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1269538
[Bug 1269538] Tracker for IoT on Fedora
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348160] Review Request: rubygem-em-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348160



--- Comment #2 from Germano Massullo  ---
Should I patch also other Shebangs in source code, as written in Ruby
guidelines?
https://fedoraproject.org/wiki/Packaging:Ruby#Shebang_lines
Example:
#!/usr/bin/ruby
instead of
#!/usr/bin/env ruby

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321687] Review Request: qpid-java - Apache Qpid Java Components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321687



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/qpid-java

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184



--- Comment #10 from Igor Gnatenko  ---
> %{?!_pkgdocdir:%global _pkgdocdir %{_docdir}/%{name}}
could be removed

> mkdir -p %{_target_platform}
better to move into %prep

> cp -ap examples %{buildroot}%{_pkgdocdir}
just mark as %doc in -doc subpkg

> pushd %{_target_platform}/tests
> ctest %{?_smp_mflags}
don't pushd to tests, just to _target_platform
add -VV to ctest invocation to easy identify bugs if there
also do popd after

> %{_pkgdocdir}/
mark as %doc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184



--- Comment #9 from Raphael Groner  ---
Tests and doc fixed. Sorry for being so dumb in first steps.

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14851458

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343977

Mario Blättermann  changed:

   What|Removed |Added

 CC||mario.blaetterm...@gmail.co
   ||m



--- Comment #1 from Mario Blättermann  ---
The spec file location is 404.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354210

Mario Blättermann  changed:

   What|Removed |Added

  Alias||xviewer



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354210



--- Comment #1 from Mario Blättermann  ---
Scratch build for f24 was successful:
http://koji.fedoraproject.org/koji/taskinfo?taskID=14850867

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354210] New: Review Request: xviewer - Fast and functional graphics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354210

Bug ID: 1354210
   Summary: Review Request: xviewer - Fast and functional graphics
viewer
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mario.blaetterm...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://mariobl.fedorapeople.org/Review/SPECS/xviewer.spec
SRPM URL:
https://mariobl.fedorapeople.org/Review/SRPMS/xviewer-1.0.4-1.fc24.src.rpm

Description:
Xviewer is a simple graphics viewer for the Cinnamon desktop and others
which uses the gdk-pixbuf library. It can deal with large images, and zoom
and scroll with constant memory usage. Its goals are simplicity and standards
compliance.

Fedora Account System Username: mariobl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350257



--- Comment #2 from Antonio Trande  ---
Spec URL: https://sagitter.fedorapeople.org/petsc/petsc.spec
SRPM URL: https://sagitter.fedorapeople.org/petsc/petsc-3.7.2-6.fc24.src.rpm

- Packed additional header files
- Tests performed on EPEL7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354202] Review Request: purple-hangouts - Adds support for Hangouts to libpurple-based clients

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354202

Igor Gnatenko  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #4 from Igor Gnatenko  ---
everything looks good except CFLAGS/LDFLAGS are not used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354202] Review Request: purple-hangouts - Adds support for Hangouts to libpurple-based clients

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354202



--- Comment #3 from Vitaly Zaitsev  ---
> actually it was never released, so version is: 0

Fixed.

> not needed, as library installs into private directory

Already removed in new SPEC.

> spec and SRPM's spec are different:

Resolved. New SRPM:
https://copr-be.cloud.fedoraproject.org/results/xvitaly/purple-hangouts/fedora-24-x86_64/00376098-purple-hangouts/purple-hangouts-0-31.20160710hg5378549.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354202] Review Request: purple-hangouts - Adds support for Hangouts to libpurple-based clients

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354202



--- Comment #2 from Igor Gnatenko  ---
> Version: 1.0
actually it was never released, so version is: 0

> BuildRequires: pkgconfig(nss)
not used

> %post -p /sbin/ldconfig
not needed, as library installs into private directory

spec and SRPM's spec are different:
Diff spec file in url and in SRPM
-
--- /home/brain/1354202-purple-hangouts/srpm/purple-hangouts.spec  
2016-07-10 20:34:47.236258515 +0200
+++ /home/brain/1354202-purple-hangouts/srpm-unpacked/purple-hangouts.spec 
2016-07-10 19:24:36.0 +0200
@@ -55,4 +55,9 @@
 chmod 755 %{buildroot}%{_libdir}/purple-2/lib%{plugin_name}.so

+# Installing icons...
+install -p hangouts16.png
%{buildroot}%{_datadir}/pixmaps/pidgin/protocols/16/%{plugin_name}.png
+install -p hangouts22.png
%{buildroot}%{_datadir}/pixmaps/pidgin/protocols/22/%{plugin_name}.png
+install -p hangouts48.png
%{buildroot}%{_datadir}/pixmaps/pidgin/protocols/48/%{plugin_name}.png
+
 %files
 %{_libdir}/purple-2/lib%{plugin_name}.so

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184



--- Comment #8 from Igor Gnatenko  ---
> All fixed, except tests. I don't know how to build/run the tests, please help.
%build
%cmake -DBUILD_TESTS=ON
%check
ctest -VV

Also documentation stuff should be fixed similar way, not by manual running
doxygen. There is -DBUILD_DOC

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184



--- Comment #7 from Raphael Groner  ---
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14849719

(In reply to Igor Gnatenko from comment #2)
> > Provides:   cmake(%{modname})
> I thought that it should come automatically... Rex?

Confirmed and fixed. It's a magic internal feature of rpmbuild.

> > Requires:   %{name} = %{version}-%{release}
> Missing %{?_isa}

Fixed.

> > %cmake
> I would recommend to make out-of-tree builds

What are out-of-tree builds? Do you mean to not build binaries into source
folder? If yes, fixed.

> Others from first glance looks great!

Thanks.

(In reply to Igor Gnatenko from comment #2)
> Issues:
> ===
> - ldconfig called in %post and %postun if required.
>   Note: /sbin/ldconfig not called in qhttpengine
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
> - %check is present and all tests pass.
>   Note: test suite is not built/ran
> - qhttpengine-devel.x86_64: E: useless-provides cmake(QHttpEngine)
>   Note: yeah, remove it
> - BuildRequires: gcc-c++ is missing
> - Would be great to build docs as well

All fixed, except tests. I don't know how to build/run the tests, please help.

(In reply to Igor Gnatenko from comment #4)
> > Requires:   cmake
> also add here %{?_isa} as well, because package installs cmake files in
> %{_libdir}

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354202] Review Request: purple-hangouts - Adds support for Hangouts to libpurple-based clients

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354202

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ignate...@redhat.com
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



--- Comment #1 from Igor Gnatenko  ---
Will make review in few hours.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354202] New: Review Request: purple-hangouts - Adds support for Hangouts to libpurple-based clients

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354202

Bug ID: 1354202
   Summary: Review Request: purple-hangouts - Adds support for
Hangouts to libpurple-based clients
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: vit...@easycoding.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/xvitaly/purple-hangouts/raw/master/purple-hangouts.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/xvitaly/purple-hangouts/fedora-24-x86_64/00376082-purple-hangouts/purple-hangouts-1.0-30.20160710hg5378549.fc24.src.rpm

Description: Adds support for Hangouts to Pidgin, Adium, Finch and other
libpurple based messengers.

Fedora Account System Username: xvitaly

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351097] Review Request: python-uritemplate - Simple python library to deal with URI Templates ( RFC 6570)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351097

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
python-github3py-1.0.0-0.1a4.fc24, python-uritemplate-0.3.0-1.fc24 has been
pushed to the Fedora 24 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d42fa6a33d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351138] Review Request: python-github3py - Python wrapper for the GitHub API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351138

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
python-github3py-1.0.0-0.1a4.fc24, python-uritemplate-0.3.0-1.fc24 has been
pushed to the Fedora 24 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d42fa6a33d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348006] Review Request: python-i3ipc - An improved Python library to control i3wm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348006



--- Comment #7 from Fedora Update System  ---
python-i3ipc-1.2.0-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9f18247b76

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1306353] Review Request: libunity - Library for integrating with Unity and Plasma

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306353



--- Comment #16 from Fedora Update System  ---
libunity-7.1.4-3.20151002.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-18e76d06b7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340513] Review Request: gap-pkg-gbnp - Computing Gröbner bases of noncommutative polynomials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340513

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
gap-pkg-gbnp-1.0.3-3.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3b2905f488

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1352666] Review Request: perl-Pod-Constants - Include constants from POD

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352666



--- Comment #10 from Fedora Update System  ---
perl-Pod-Constants-0.19-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-38370e4e95

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1242056] Review Request: rubygem-chake - serverless configuration management tool for chef

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242056

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #23 from Fedora Update System  ---
rubygem-chake-0.13-7.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7c1fb1c7c1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1309794] Review Request: qtscrob - Qt last.fm submitter for portable music devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309794

Raphael Groner  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|projects...@smart.ms



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1273134] Review Request: nodejs-tmatch - acilitate the `t.match() ` method in `tap`

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1273134

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #9 from Fedora Update System  ---
nodejs-tmatch-2.0.1-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9be88c573e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1279981] Review Request: nodejs-array-filter - Array#filter for older browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279981

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #5 from Fedora Update System  ---
nodejs-array-filter-1.0.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-bde2934afd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1280054] Review Request: nodejs-array-reduce - `[].reduce() ` for old browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1280054

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #5 from Fedora Update System  ---
nodejs-array-reduce-0.0.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c5a396bf83

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335278] Review Request: mame - Multiple Arcade Machine Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335278



--- Comment #47 from Fedora Update System  ---
mame-0.175-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ab1e111bf6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335988] Review Request: giac - Computer Algebra System, Symbolic calculus, Geometry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335988

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #27 from Fedora Update System  ---
giac-1.2.2-5.63.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f061f7bbb3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346018] Review Request: jmake - Make utility for large Java projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346018



--- Comment #19 from Fedora Update System  ---
jmake-1.3.8.8-2.20150716git7761ee3.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-bbb939d86b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1349575] Review Request: python-multidict - MultiDict implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349575

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
python-multidict-1.1.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-455512c317

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1353469] Review Request: python-marshmallow-enum - Enum serializer/ deserializer for use with Marshmallow

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353469

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
python-marshmallow-enum-1.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ebd97b4962

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1347987] Review Request: pasystray - PulseAudio system tray

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1347987



--- Comment #7 from Fedora Update System  ---
pasystray-0.5.2-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d06433e715

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1308480] Review Request: wlc - Wayland compositor library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308480



--- Comment #10 from Fedora Update System  ---
wlc-0.0.3-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1978f0497a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1352993] Review Request: python-args - Argument Parsing for Humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352993



--- Comment #11 from Fedora Update System  ---
python-args-0.1.0-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-fc0ec2f334

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1353572] Review Request: HikariCP - JDBC Connection Pool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353572

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
HikariCP-2.4.0-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f91521e392

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1309782] Review Request: bugyou_plugins - Plugins and Services for Bugyou

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309782



--- Comment #56 from Fedora Update System  ---
bugyou_plugins-0.1.5-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-47e441aac5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184

Igor Gnatenko  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323214] Review Request: git-evtag - Strong GPG verification of git tags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323214

Igor Gnatenko  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323214] Review Request: git-evtag - Strong GPG verification of git tags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323214



--- Comment #7 from Igor Gnatenko  ---
* no changelog section
* 2016.1 -> %{version}

Resolution: ALMOST GOOD

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1309794] Review Request: qtscrob - Qt last.fm submitter for portable music devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309794

Raphael Groner  changed:

   What|Removed |Added

 Attachment|0   |1
#1178088 is||
   obsolete||



--- Comment #3 from Raphael Groner  ---
Created attachment 1178089
  --> https://bugzilla.redhat.com/attachment.cgi?id=1178089=edit
my recommended qtscrob.spec

Please use this spec file.

Sorry, forgot some of the fixes in first upload.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323214] Review Request: git-evtag - Strong GPG verification of git tags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323214



--- Comment #6 from Igor Gnatenko  ---
> # For autosetup
> BuildRequires: git
not needed

> %autosetup -Sgit
don't think that you use any features from that, so %autosetup

> make %{?_smp_mflags}
%make_build

> make install DESTDIR=%{buildroot} INSTALL="install -p -c"
%make_install INSTALL="install -p -c"

> %doc COPYING README.md
%license COPYING
%doc README.md

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1309794] Review Request: qtscrob - Qt last.fm submitter for portable music devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309794



--- Comment #2 from Raphael Groner  ---
Created attachment 1178088
  --> https://bugzilla.redhat.com/attachment.cgi?id=1178088=edit
my recommendation for qtscrob.spec

Please use this spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1309794] Review Request: qtscrob - Qt last.fm submitter for portable music devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309794

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||projects...@smart.ms



--- Comment #1 from Raphael Groner  ---
Review swap with bug #1354184. Thanks for your interest! Below are some general
hints before I can do an official review.

1. Why do you use GPLv2 instead of GPLv2+? I don't see a restriction in
sources, the COPYING file clearly says "or later":
GNU General Public License v2.0 only  GPLv2 
GNU General Public License v2.0 or later  GPLv2+

2. Add Requires: hicolor-icon-theme, for ownership of
%{_datadir}/icons/hicolor/

3. Add documentation files:
%files
%doc AUTHORS CHANGELOG README


- Recommendations:

4. Can you build with Qt5 instead of Qt4? Qt4 development is stalled, but some
of the used classes are not available in Qt5:
http://stackoverflow.com/questions/26180311/qhttp-in-not-available-in-qt5
https://forum.qt.io/topic/23904/qtftp-and-qthttp-compatibility-add-ons-for-qhttp-and-qftp-classes-in-qt-5/3

You may also need a patch for the pro file:
sed -i -r 's/(VER = ).*/\1QT_VERSION/' src/%{name}.pro

5. My preference is to use BuildRequires: desktop-file-utils, instead of giving
a concrete path of own file desktop-file-validate.

6. Simplify build and install commands in a more convinient way:
%build
mkdir -p %{_target_platform}
pushd %{_target_platform}
%qmake_qt4 ../src/%{name}.pro PREFIX=%{_prefix}
popd
%make_build -C %{_target_platform}

%install
%make_install -C %{_target_platform} INSTALL_ROOT=%{buildroot}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323214] Review Request: git-evtag - Strong GPG verification of git tags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323214

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ignate...@redhat.com
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331175] Review Request: yadm - Yet Another Dotfiles Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331175

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||yadm



--- Comment #7 from Igor Gnatenko  ---
> install -m 755 yadm   ${RPM_BUILD_ROOT}%{_bindir}
> install -m 644 yadm.1 ${RPM_BUILD_ROOT}%{_mandir}/man1
add "-p" to "install" execution to preserve timestamps.

> %attr(755,root,root) %{_bindir}/yadm
> %attr(644,root,root) %{_mandir}/man1/*
drop %attr from here as you already install file with such attributes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184



--- Comment #6 from Igor Gnatenko  ---
https://bugzilla.redhat.com/show_bug.cgi?id=1309794

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1309794] Review Request: qtscrob - Qt last.fm submitter for portable music devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309794

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||qtscrob



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184



--- Comment #5 from Igor Gnatenko  ---
Raphael, would be happy if you will review simple qt package - bug qtscrob.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184



--- Comment #4 from Igor Gnatenko  ---
> Requires:   cmake
also add here %{?_isa} as well, because package installs cmake files in
%{_libdir}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184



--- Comment #3 from Igor Gnatenko  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in qhttpengine
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
- %check is present and all tests pass.
  Note: test suite is not built/ran
- qhttpengine-devel.x86_64: E: useless-provides cmake(QHttpEngine)
  Note: yeah, remove it
- BuildRequires: gcc-c++ is missing
- Would be great to build docs as well

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 15 files have
 unknown license. Detailed output of licensecheck in
 /home/brain/1354184-qhttpengine/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 qhttpengine-devel , qhttpengine-debuginfo
[!]: Package functions as described.
[x]: Latest version is packaged.

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||qhttpengine



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ignate...@redhat.com,
   ||rdie...@math.unl.edu
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



--- Comment #2 from Igor Gnatenko  ---
> Provides:   cmake(%{modname})
I thought that it should come automatically... Rex?

> Requires:   %{name} = %{version}-%{release}
Missing %{?_isa}

> %cmake
I would recommend to make out-of-tree builds

Others from first glance looks great!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 957422] Review Request: tea - A text editor with hundreds of features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=957422

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
Last Closed||2016-07-10 08:38:16



--- Comment #26 from Raphael Groner  ---
No response since several monthes. Closing.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184



--- Comment #1 from Raphael Groner  ---
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14847721

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] New: Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184

Bug ID: 1354184
   Summary: Review Request: qhttpengine - HTTP server for Qt
applications
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: projects...@smart.ms
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://raphgro.fedorapeople.org/review/util/qhttpengine.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/util/qhttpengine-0.1.0-1.fc24.src.rpm

Description: HTTP server for Qt applications
Simple set of classes for developing HTTP server applications in Qt.

Fedora Account System Username: raphgro

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14847630

Note: Main purpose of this package is to provide an (optional) feature of
nitroshare, a desktop util to easily share data over networks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354184

Raphael Groner  changed:

   What|Removed |Added

 Blocks||928937 (qt-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351092] Review Request: python-geoip2 - MaxMind GeoIP2 API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351092



--- Comment #4 from Fedora Update System  ---
python-geoip2-2.4.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8b9b1d53d8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351092] Review Request: python-geoip2 - MaxMind GeoIP2 API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351092

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1351092] Review Request: python-geoip2 - MaxMind GeoIP2 API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351092



--- Comment #3 from Fedora Update System  ---
python-geoip2-2.4.0-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7a45679909

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316982] Review Request: python-pytest-testmon - A py.test plug-in which executes only tests affected by recent changes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316982



--- Comment #13 from Fedora Update System  ---
python-pytest-testmon-0.8.2-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1344249] Review Request: libtaskotron - Taskotron Support Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344249



--- Comment #10 from Fedora Update System  ---
libtaskotron-0.4.13-3.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348207

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-07-10 02:00:01



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348207] Review Request: python-represent - create __repr__ automatically or declaratively

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348207



--- Comment #13 from Fedora Update System  ---
python-represent-1.5.1-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org