[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #50 from Yunying Sun ---
(running fedora-review on this package myself)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc gcc-c++
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (2 clause)", "Unknown or generated". 23 files have unknown
license. Detailed output of licensecheck in
/home/test/yunyings/rpmreview/1369708_tpm2-tss/review-
tpm2-tss/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr, /usr/include,
/usr/lib64, /usr/share/licenses, /usr/lib64/pkgconfig, /usr/share,
/usr/sbin, /usr/share/doc
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in tpm2
-tss-devel
[ ]: Package fun
[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS
https://bugzilla.redhat.com/show_bug.cgi?id=1369720
--- Comment #18 from Yunying Sun ---
(run a fedora-review over this package myself)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc gcc-c++
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "BSD (2 clause)". Detailed output of
licensecheck in /home/test/yunyings/rpmreview/1369720_tpm2-tools
/review-tpm2-tools/licensecheck.txt
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/sbin, /usr/share/doc,
/usr/share/licenses, /usr/share, /usr
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendo
[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application
https://bugzilla.redhat.com/show_bug.cgi?id=1396513 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application
https://bugzilla.redhat.com/show_bug.cgi?id=1396513 --- Comment #9 from Fedora Update System --- nitrokey-app-0.6.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e29a5887ae -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application
https://bugzilla.redhat.com/show_bug.cgi?id=1396513 --- Comment #10 from Fedora Update System --- nitrokey-app-0.6.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-94dfc033bb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #51 from Yunying Sun --- Regarding some of the rpmlint warnings: > tpm2-tss.src: W: invalid-license TCGL TCGL license has been added to the Fedora license list by Tom, see comment 43. tpm2-tss.src: W: strange-permission tpm2-tss.spec 0775L > fixed. tpm2-tss.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 6) > fixed. Updated SPEC: https://raw.githubusercontent.com/yunyings/share/master/tpm2-tss.spec Updated SRPM: https://github.com/yunyings/share/blob/master/tpm2-tss-1.0-1.el7.src.rpm?raw=true Succeeded Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16704153 Succeeded COPR build: https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tss/build/483970/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS
https://bugzilla.redhat.com/show_bug.cgi?id=1369720 --- Comment #19 from Yunying Sun --- Fixed below rpmlint warnings: tpm2-tools.src: W: summary-not-capitalized C a TPM2.0 testing tool build upon TPM2.0-TSS tpm2-tools.src: W: strange-permission tpm2-tools.spec 0775L tpm2-tools.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 6) Updated SPEC: https://raw.githubusercontent.com/yunyings/share/master/tpm2-tools.spec Updated SRPM: https://github.com/yunyings/share/blob/master/tpm2-tools-1.1.0-1.el7.src.rpm?raw=true Succeeded COPR build: https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/484002/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375765] Review Request: yosys - Yosys Open SYnthesis Suite, including Verilog synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=1375765 --- Comment #12 from Fedora Update System --- yosys-0.7-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-30a802e8c3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375765] Review Request: yosys - Yosys Open SYnthesis Suite, including Verilog synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=1375765 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400489] Review Request: perl-BSON - BSON serialization and deserialization
https://bugzilla.redhat.com/show_bug.cgi?id=1400489 Jitka Plesnikova changed: What|Removed |Added Status|NEW |ASSIGNED CC||jples...@redhat.com Assignee|nob...@fedoraproject.org|jples...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 673115] Review Request: dee-qt - Qt bindings and QML plugin for Dee
https://bugzilla.redhat.com/show_bug.cgi?id=673115 Ondrej Vasik changed: What|Removed |Added Assignee|ova...@redhat.com |nob...@fedoraproject.org -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 673096] Review Request: bamf-qt - Qt bindings and QML plugin for Bamf DBus server
https://bugzilla.redhat.com/show_bug.cgi?id=673096 Ondrej Vasik changed: What|Removed |Added Assignee|ova...@redhat.com |nob...@fedoraproject.org -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1400626 Shawn Iwinski changed: What|Removed |Added Status|NEW |ASSIGNED CC||sh...@iwin.ski Assignee|nob...@fedoraproject.org|sh...@iwin.ski Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1400626 --- Comment #1 from Shawn Iwinski --- Created attachment 1227327 --> https://bugzilla.redhat.com/attachment.cgi?id=1227327&action=edit phpcompatinfo-full.log phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1400626 --- Comment #2 from Shawn Iwinski --- Created attachment 1227328 --> https://bugzilla.redhat.com/attachment.cgi?id=1227328&action=edit phpcompatinfo-lib.log phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1400626 --- Comment #3 from Shawn Iwinski --- Created attachment 1227329 --> https://bugzilla.redhat.com/attachment.cgi?id=1227329&action=edit fedora-review.txt Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 1400626 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1400626
Shawn Iwinski changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Shawn Iwinski ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
As usual, remove EPEL 5 bits after initial import.
No blockers.
= APPROVED =
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1400626 --- Comment #5 from Remi Collet --- Thanks for the review. SCM requested. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449 --- Comment #6 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/zkclient -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400542] Review Request: colm - Programming language designed for the analysis and transformation of computer languages
https://bugzilla.redhat.com/show_bug.cgi?id=1400542 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/colm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1400626 --- Comment #6 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-gecko-packages-gecko-php-unit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1400626 --- Comment #9 from Fedora Update System --- php-gecko-packages-gecko-php-unit-2.0.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3d92223be1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1400626 --- Comment #8 from Fedora Update System --- php-gecko-packages-gecko-php-unit-2.0.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5b842fcf20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1400626 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1400626 --- Comment #7 from Fedora Update System --- php-gecko-packages-gecko-php-unit-2.0.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-745efbc9da -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1399648] Review Request: xl2tpd - Updated to 1.3.8 using github release
https://bugzilla.redhat.com/show_bug.cgi?id=1399648
--- Comment #5 from Petr ---
I checked official src, rebuilt in mock for el7.centos
https://kojipkgs.fedoraproject.org//packages/xl2tpd/1.3.8/1.fc26/src/xl2tpd-1.3.8-1.fc26.src.rpm
Rpmlint
xl2tpd.src:55: W: setup-not-quiet
xl2tpd.src:74: E: hardcoded-library-path in %{_prefix}/lib/tmpfiles.d/
xl2tpd.src:75: E: hardcoded-library-path in
%{_prefix}/lib/tmpfiles.d/%{name}.conf
xl2tpd.src:113: E: hardcoded-library-path in
%{_prefix}/lib/tmpfiles.d/%{name}.conf
xl2tpd.src: W: invalid-url Source0:
https://github.com/xelerance/xl2tpd/archive/xl2tpd-1.3.8.tar.gz HTTP Error 404:
Not Found
xl2tpd.x86_64: W: incoherent-version-in-changelog 1.3.8-1
['1.3.8-1.el7.centos', '1.3.8-1.centos']
xl2tpd.x86_64: W: only-non-binary-in-usr-lib
xl2tpd.x86_64: E: non-readable /etc/xl2tpd/l2tp-secrets 0600L
xl2tpd.x86_64: E: incorrect-fsf-address /usr/share/doc/xl2tpd-1.3.8/LICENSE
xl2tpd.x86_64: E: non-readable /var/run/xl2tpd/l2tp-control 0600L
xl2tpd.x86_64: E: non-readable /etc/ppp/chap-secrets.sample 0600L
xl2tpd.x86_64: W: no-manual-page-for-binary xl2tpd-control
3 packages and 0 specfiles checked; 7 errors, 5 warnings.
spec:
incorrect global commit, should be
global commit cec1ebe1523bf248f134647dd6030a333d93e19b
# upstream isn't using proper names, we manually rename v-VERSION.tar.gz to
xl2tpd-VERSION.tar.gz
Source0: https://github.com/xelerance/%{name}/archive/%{name}-%{version}.tar.gz
Also contains your marked moments
Besides inline comments(marked with yunying:), here are some additional:
1. "Group:" is not needed.
2. "rm -rf %{buildroot}" should be removed.
3. replace following "xl2tpd" in SPEC file with "%name".
yunying: LICENSE file contains text of license itself, so should be put under
"%license".
> yunying: use "%make_build" instead of "make".
> yunying: use %{_libdir} instead of hardcoded-library-path.
How did they pass??
--
I requested for LICENSE
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio
https://bugzilla.redhat.com/show_bug.cgi?id=1389971 --- Comment #31 from Antonio Trande --- (In reply to Ryan H. Lewis (rhl) from comment #28) > spec: > https://raw.githubusercontent.com/elemental/Elemental/master/redhat/ > elemental-release.spec > srpm: https://rhl.fedorapeople.org/elemental/elemental-0.87.5-2.fc24.src.rpm Please, leave a comment about why you have excluded PPC including eventual links. 'elemental' does not build on epel6/7 because of missing 'devtoolset-4-toolchain': http://koji.fedoraproject.org/koji/taskinfo?taskID=16707202 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1399648] Review Request: xl2tpd - Updated to 1.3.8 using github release
https://bugzilla.redhat.com/show_bug.cgi?id=1399648 --- Comment #6 from Paul Wouters --- huh? xl2tpd is a package I have maintained for many years already in fedora and epel. https://admin.fedoraproject.org/pkgdb/package/rpms/xl2tpd/ 1.3.8 package was released in august 2016 in fedora. I will update the el6/epel7 versions too. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400489] Review Request: perl-BSON - BSON serialization and deserialization
https://bugzilla.redhat.com/show_bug.cgi?id=1400489 Jitka Plesnikova changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok Binary requires are Ok. Binary provides are Ok. $ rpmlint ./perl-BSON* perl-BSON.noarch: W: spelling-error Summary(en_US) deserialization -> serialization, materialization, denationalization perl-BSON.noarch: W: spelling-error %description -l en_US versa -> avers, verse, verso perl-BSON.noarch: W: spelling-error %description -l en_US http -> HTTP perl-BSON.noarch: W: spelling-error %description -l en_US bsonspec -> conspectus perl-BSON.src: W: spelling-error Summary(en_US) deserialization -> serialization, materialization, denationalization perl-BSON.src: W: spelling-error %description -l en_US versa -> avers, verse, verso perl-BSON.src: W: spelling-error %description -l en_US http -> HTTP perl-BSON.src: W: spelling-error %description -l en_US bsonspec -> conspectus 2 packages and 1 specfiles checked; 0 errors, 8 warnings. Rpmlint is ok The package looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401013] New: Review Request: git-octopus - git commands for continuous delivery
https://bugzilla.redhat.com/show_bug.cgi?id=1401013 Bug ID: 1401013 Summary: Review Request: git-octopus - git commands for continuous delivery Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: and...@baita.pro QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/danoliv/git-octopus-spec/master/git-octopus.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/baitaand/git-octopus/fedora-25-x86_64/00484097-git-octopus/git-octopus-1.4-1.fc25.src.rpm Description: The continuous merge workflow is meant for continuous integration/delivery and is based on feature branching. git-octopus provides git commands to implement it. Fedora Account System Username: baitaand -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401013] Review Request: git-octopus - git commands for continuous delivery
https://bugzilla.redhat.com/show_bug.cgi?id=1401013 and...@baita.pro changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401013] Review Request: git-octopus - git commands for continuous delivery
https://bugzilla.redhat.com/show_bug.cgi?id=1401013 --- Comment #1 from and...@baita.pro --- This is my first package and I need a sponsor. I builded the rpm with copr : https://copr.fedorainfracloud.org/coprs/baitaand/git-octopus/build/484097/ The spec file is available on github: https://github.com/danoliv/git-octopus-spec/blob/master/git-octopus.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401035] New: Review Request: php-pear-math-biginteger - Pure-PHP arbitrary precision integer arithmetic library
https://bugzilla.redhat.com/show_bug.cgi?id=1401035 Bug ID: 1401035 Summary: Review Request: php-pear-math-biginteger - Pure-PHP arbitrary precision integer arithmetic library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/c913c7610f166f9e3a7371ab7a79b6661355ab8c/php/pear/php-pear-math-biginteger/php-pear-math-biginteger.spec SRPM URL: http://rpms.remirepo.net/SRPMS/php-pear-math-biginteger-1.0.3-1.remi.src.rpm Description: Supports base-2, base-10, base-16, and base-256 numbers. Uses the GMP or BCMath extensions, if available, and an internal implementation, otherwise. Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400489] Review Request: perl-BSON - BSON serialization and deserialization
https://bugzilla.redhat.com/show_bug.cgi?id=1400489 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-BSON -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio
https://bugzilla.redhat.com/show_bug.cgi?id=1389971 --- Comment #32 from Ryan H. Lewis (rhl) --- Should I just excludearch them as well? They do not have new enough compilers to build Elemental. devtoolset-4 makes this possible, and it works in the copr build. #fedora-devel says that the SCLs are not currently usable in fedora epel packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379830] Review Request: pdc-updater - Update the product definition center in response to fedmsg
https://bugzilla.redhat.com/show_bug.cgi?id=1379830 --- Comment #9 from Ralph Bean --- Specifically, I'll make the change before importing to SCM. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379830] Review Request: pdc-updater - Update the product definition center in response to fedmsg
https://bugzilla.redhat.com/show_bug.cgi?id=1379830 --- Comment #8 from Ralph Bean --- Good call! I'll make the update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 Don Bayly changed: What|Removed |Added Group|intel | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 Josh Boyer changed: What|Removed |Added Group|devel | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #52 from Dan Horák --- Björn, are you going to continue with the review here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401013] Review Request: git-octopus - git commands for continuous delivery
https://bugzilla.redhat.com/show_bug.cgi?id=1401013 and...@baita.pro changed: What|Removed |Added URL||https://github.com/lesfuret ||s/git-octopus -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 Don Bayly changed: What|Removed |Added Group|qa | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379830] Review Request: pdc-updater - Update the product definition center in response to fedmsg
https://bugzilla.redhat.com/show_bug.cgi?id=1379830 --- Comment #10 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/pdc-updater -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #53 from Dan Horák --- Isn't this request a duplicate of https://admin.fedoraproject.org/pkgdb/package/rpms/tss2/ ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 Dan Horák changed: What|Removed |Added Flags||needinfo? ||needinfo?(fedora@besser82.i ||o) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 Dan Horák changed: What|Removed |Added CC||yunying@intel.com Flags|needinfo? |needinfo?(yunying.sun@intel ||.com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400542] Review Request: colm - Programming language designed for the analysis and transformation of computer languages
https://bugzilla.redhat.com/show_bug.cgi?id=1400542 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400542] Review Request: colm - Programming language designed for the analysis and transformation of computer languages
https://bugzilla.redhat.com/show_bug.cgi?id=1400542 --- Comment #7 from Fedora Update System --- colm-0.13.0.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2e1979e23d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400542] Review Request: colm - Programming language designed for the analysis and transformation of computer languages
https://bugzilla.redhat.com/show_bug.cgi?id=1400542 --- Comment #6 from Fedora Update System --- colm-0.13.0.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d26bf451c0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379830] Review Request: pdc-updater - Update the product definition center in response to fedmsg
https://bugzilla.redhat.com/show_bug.cgi?id=1379830 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379830] Review Request: pdc-updater - Update the product definition center in response to fedmsg
https://bugzilla.redhat.com/show_bug.cgi?id=1379830 --- Comment #11 from Fedora Update System --- pdc-updater-0.4.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f82682427a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications
https://bugzilla.redhat.com/show_bug.cgi?id=1380942 --- Comment #18 from Fedora Update System --- jwebunit-3.3-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cdb8675ab2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications
https://bugzilla.redhat.com/show_bug.cgi?id=1380942 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1384242] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and affiliated package
https://bugzilla.redhat.com/show_bug.cgi?id=1384242 Mark Thacker changed: What|Removed |Added Depends On||1331062 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1386938] Review Request: libprelude - Prelude Library
https://bugzilla.redhat.com/show_bug.cgi?id=1386938
--- Comment #17 from Thomas Andrejak ---
New spec : https://www.prelude-siem.org/pkg/src/3.1.0/libprelude.spec
New srpm :
https://copr-be.cloud.fedoraproject.org/results/totol/Prelude/fedora-26-x86_64/00483991-libprelude/libprelude-3.1.0-26.fc26.src.rpm
(In reply to Zbigniew Jędrzejewski-Szmek from comment #15)
> (In reply to Thomas Andrejak from comment #13)
> > (In reply to Zbigniew Jędrzejewski-Szmek from comment #12)
> > > libprelude.x86_64: W: crypto-policy-non-compliance-gnutls-2
> > > /usr/lib64/libprelude.so.23.3.0 gnutls_priority_init
> > > prelude-tools.x86_64: W: crypto-policy-non-compliance-gnutls-1
> > > /usr/bin/prelude-admin gnutls_priority_set_direct
> > >
> > > This one is a bigger problem. It's been a while since I looked at the
> > > details, but basically you need to call gnutls_set_default_priority or
> > > gnutls_priority_set_direct("@SYSTEM")
> > > [https://fedoraproject.org/wiki/Packaging:CryptoPolicies]. If this policy
> > > does not apply to this package for some reason, please explain in a
> > > comment
> > > in the spec file. Looking at ./prelude-admin/server.c, it should be easy
> > > enough to patch.
> >
> > Done. I explain in the spec why it is OK for libprelude.so. For
> > prelude-admin, I made a patch to use what is required in the Wiki but I
> > still have the warning
>
> > # - crypto-policy-non-compliance-gnutls-2 in libprelude.so is normal
> > # because the user can configure it
>
> That's the only important issue. While it is true that the value
> can be overridden, most users of the library will not override the
> default, so the "default" provided by the library is what will be
> used most often in the end. IIUC, libprelude.so has
> tls_auth_init_priority() which calls gnutls_priority_init(tlsopts ?:
> "NORMAL"),
> and tls_auth_init_priority() is called in a few places as
> tls_auth_init_priority(NULL), e.g. from tls_auth_connection().
> So effectively "NORMAL" is the default. I think it should be changed
> to "@SYSTEM".
>
> For a similar case, consider libmicrohttpd. We patched it
> [http://pkgs.fedoraproject.org/cgit/rpms/libmicrohttpd.git/tree/gnutls-
> utilize-system-crypto-policy.patch]
> to use @SYSTEM, and all users of libmicrohttpd magically became
> compliant with the policy without any further work.
I fixed it but I still get the warning, dunno why ...
>
> > > # Force default attrs because libprelude force others
> > > %defattr(- , root, root, 755)
> > > → I think you don't need this anymore.
> >
> > => Just try it, I still need this
>
> > > - Provides: bundled(gnulib) in place as required.
> > > Note: Bundled gnulib but no Provides: bundled(gnulib)
> > > See:
> > >
> > > http://fedoraproject.org/wiki/Packaging:
> > > No_Bundled_Libraries#Requirement_if_you_bundle
> >
> > Done
>
> Note: it'd be nicer to include a specific "version", something like
> Provides: bundled(gnulib) = 20160508
> but if it's hard to determine or unclear or whatever, it's fine as is.
Done
>
> > > rpmlint also says:
> > > libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> > > /usr/src/debug/libprelude-3.1.0/src/libprelude-error/code-to-errno.h
> > > libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> > > /usr/src/debug/libprelude-3.1.0/src/libprelude-error/err-sources.h
> > > libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> > > /usr/src/debug/libprelude-3.1.0/src/libprelude-error/strsource.c
> > > libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> > > /usr/src/debug/libprelude-3.1.0/src/libprelude-error/code-from-errno.h
> > > libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> > > /usr/src/debug/libprelude-3.1.0/src/libprelude-error/err-codes.h
> > > libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> > > /usr/src/debug/libprelude-3.1.0/src/libprelude-error/strerror.c
> > > It's not a big issue, but probably to fix upstream at some point.
> >
> > I can't change this, this is not part of libprelude
>
> Those same files in libgpg-error sources are quite different. It seems that
> libprelude has an independent forked copy, so you *could* fix the address.
> But anyway, it doesn't matter much.
Done
>
> I noticed another issue: valgrind is used in tests, but is not listed in
> BuildRequires. Unfortunately, valgrind is not available on all architectures.
> There's a macro %{valgrind_arches}, but it is only available in rawhide.
> That could be used in the future, but for now:
> %ifnarch s390
> BuildRequires: valgrind
> %endif
> ... and you also have to make sure that the test still run without valgrind.
I have to check this but it should works
>
> >> And one more suggestion for upstream reconsideration:
> >> custom autoconf macros are horrible.
> > Interesting, I will share this with upstream
> Oh, I now see that there's a pkg-config file already. So my rant wasn't
> necessary. Sorry.
Don't worry ;)
> Scratch build in koji: http://koji.fedoraproject.org
> /koji/taskinfo?
[Bug 1392089] Review Request: python-zeroconf: Pure Python Multicast DNS Service Discovery Library
https://bugzilla.redhat.com/show_bug.cgi?id=1392089 --- Comment #5 from Peter Robinson --- SPEC: https://pbrobinson.fedorapeople.org/python-zeroconf.spec SRPM: https://pbrobinson.fedorapeople.org/python-zeroconf-0.17.6-2.fc25.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=16708202 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 --- Comment #2 from Peter Robinson --- (In reply to Athos Ribeiro from comment #1) > I am not sure if we can use this name for the package. See > https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging: > NamingGuidelines#Outdated_Python_package_naming_conventions The binary packages are called python2- and python3- so I don't see what the issue is. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 --- Comment #3 from Peter Robinson --- Updated, spec as before SRPM: https://pbrobinson.fedorapeople.org/pychromecast-0.7.7-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1331449] Review Request: zkclient - A Zookeeper Client
https://bugzilla.redhat.com/show_bug.cgi?id=1331449 gil cattaneo changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||zkclient-0.10-1.fc26 Resolution|--- |RAWHIDE Last Closed||2016-12-02 12:06:55 --- Comment #7 from gil cattaneo --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16708246 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376783] Review Request: python-can: The can package provides controller area network support for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1376783
--- Comment #2 from Peter Robinson ---
> You can replace the second and subsequent Summary texts with %{summary}, no
> need to repeat.
>
>
> Also, don't repeat the %description, it makes the spec file much harder to
> read than necessary:
>
> %global _description \
> XXX \
> YYY
>
> %description -n package-name %{_description}
>
> etc.
>
> In %files, please enumerate the items under %{pythonX_sitelib}/ explicitly.
> Something like
> %{python2_sitelib}/libname
> %{python2_sitelib}/libname-%{version}.egg-info
All of the above is a matter of opinion and hence the choice of the maintainer.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio
https://bugzilla.redhat.com/show_bug.cgi?id=1389971
--- Comment #33 from Antonio Trande ---
>Should I just excludearch them as well?
No.
I thought you wanted to compile on epel, too.
The review is almost done:
- Your are not using %license to pack the license files.
- You should use %doc or %_pkgdocdir macros for documentation, not
%{_docdir}/Elemental
(http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation):
$ rpm --eval %_pkgdocdir
%{_docdir}/%{name}
- 'elemental-common' provides arch-independent files, so it is a 'noarch'
package.
Please, modify in this sense
%package common
Summary: Files in common between mpich and openmpi
Group: Development/Libraries
BuildArch: noarch <---
Requires: qt5-qtbase
%description common
Files not specific to mpich or openmpi
Consequently, other packages which require 'elemental-common' use the line
Requires: %{name}-common = %{version}-%{release}
(without '%{?_isa}')
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376783] Review Request: python-can: The can package provides controller area network support for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #3 from Peter Robinson --- SPEC: as above SRPM: https://pbrobinson.fedorapeople.org/python-can-1.5.2-2.fc25.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=16708332 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 Josh Boyer changed: What|Removed |Added CC||jsnit...@redhat.com --- Comment #54 from Josh Boyer --- (In reply to Dan Horák from comment #53) > Isn't this request a duplicate of > https://admin.fedoraproject.org/pkgdb/package/rpms/tss2/ ? Maybe... but I think it is a separate implementation of similar functionality? Vicky and Tomas the the review on tss2 and Yunying was also commented on it. They're all on CC for this one as well, so I think we can get that cleared up soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1374982] Review Request: python-robosignatory - A fedmsg consumer that automatically signs artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=1374982 Peter Robinson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2016-12-02 12:49:41 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio
https://bugzilla.redhat.com/show_bug.cgi?id=1389971
--- Comment #34 from Ryan H. Lewis (rhl) ---
I definitely do want to compile on EPEL, but, it appears without devtoolset-4
this will not be possible.
I'm not sure what you want me to do with:
> - Your are not using %license to pack the license files.
> - You should use %doc or %_pkgdocdir macros for documentation, not
> %{_docdir}/Elemental
> (http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation):
I don't seem to be using ` %{_docdir}/Elemental`
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio
https://bugzilla.redhat.com/show_bug.cgi?id=1389971
--- Comment #35 from Ryan H. Lewis (rhl) ---
Oh I see you want me do to:
mv %{_docdir}/Elemental %_pkgdocdir
and then replace the %{_datadir}/doc/Elemental with %_pkgdocdir
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio
https://bugzilla.redhat.com/show_bug.cgi?id=1389971
--- Comment #36 from Antonio Trande ---
%_pkgdocdir = %{_docdir}/%{name} = %{_datadir}/doc/elemental !=
%{_datadir}/doc/Elemental
:)
Use %license to tag the license files like:
%license COPYING.txt
or
%license LICENSE
or
%license COPYRIGHT
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio
https://bugzilla.redhat.com/show_bug.cgi?id=1389971 --- Comment #37 from Ryan H. Lewis (rhl) --- I have this line: %license debian/copyright Is that the wrong location somehow? rpmlint isn't complaining about it obviously, so, i'm not sure offhand. Or do you mean that you want: the other COPYRIGHT file? that one just suggests you read the debian/copyright file so i'm not sure what the value is of that.. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio
https://bugzilla.redhat.com/show_bug.cgi?id=1389971 --- Comment #38 from Ryan H. Lewis (rhl) --- Ok, I believe I have addressed your concerns now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio
https://bugzilla.redhat.com/show_bug.cgi?id=1389971 --- Comment #40 from Ryan H. Lewis (rhl) --- done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio
https://bugzilla.redhat.com/show_bug.cgi?id=1389971
--- Comment #39 from Antonio Trande ---
(In reply to Ryan H. Lewis (rhl) from comment #38)
> Ok, I believe I have addressed your concerns now.
Not there. In this way:
%files common
%{_datadir}/elemental/*
%_pkgdocdir/
%license debian/copyright
%license LICENSE
'debian/copyright' and 'LICENSE' will be installed with 'elemental-common'
package, so they will be always present when 'elemental' libraries are
installed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1397051] Review Request: caffeine - High performance java 8 caching library
https://bugzilla.redhat.com/show_bug.cgi?id=1397051 --- Comment #19 from Fedora Update System --- caffeine-2.3.5-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7095ba897b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398355] Review Request: php-ast - Abstract Syntax Tree
https://bugzilla.redhat.com/show_bug.cgi?id=1398355 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- php-ast-0.1.2-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-48d3002507 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383416] Review Request: python-influxdb - InfluxDB Python client
https://bugzilla.redhat.com/show_bug.cgi?id=1383416 --- Comment #19 from Fedora Update System --- python-influxdb-3.0.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-603e246239 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1395554] Review Request: python-astral - Calculations for the position of the sun and moon
https://bugzilla.redhat.com/show_bug.cgi?id=1395554 --- Comment #15 from Fedora Update System --- python-astral-1.3.2-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-72d3dc1dd2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information
https://bugzilla.redhat.com/show_bug.cgi?id=1395804 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- python-batinfo-0.4.2-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6374c6c6ce -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398690] Review Request: perl-Module-Extract-Use - Pull out the modules a module explicitly uses
https://bugzilla.redhat.com/show_bug.cgi?id=1398690 --- Comment #13 from Fedora Update System --- perl-Module-Extract-Use-1.04-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e0885fdb1f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1391951] Review Request: php-cs-fixer - A tool to automatically fix PHP code style
https://bugzilla.redhat.com/show_bug.cgi?id=1391951 --- Comment #15 from Fedora Update System --- php-cs-fixer-1.13.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b4836e981b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398432] Review Request: playitagainsam - Record and replay interactive terminal sessions
https://bugzilla.redhat.com/show_bug.cgi?id=1398432 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- playitagainsam-0.5.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c1aa611d88 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1394788] Review Request: lua-mpack - Implementation of MessagePack for Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1394788 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- lua-mpack-1.0.3-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f5739610b8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379798] Review Request: pcsxr - A plugin based PlayStation (PSX) emulator with high compatibility
https://bugzilla.redhat.com/show_bug.cgi?id=1379798 --- Comment #29 from Fedora Update System --- pcsxr-1.9.94-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2b999e631a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1393934] Review Request: php-http-interop-http-middleware - Common interface for HTTP middleware
https://bugzilla.redhat.com/show_bug.cgi?id=1393934 --- Comment #12 from Fedora Update System --- php-http-interop-http-middleware-0.2.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6da16334da -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396636] Review Request: golang-github-knieriem-markdown - A translation of peg-markdown into Go
https://bugzilla.redhat.com/show_bug.cgi?id=1396636 --- Comment #10 from Fedora Update System --- golang-github-knieriem-markdown-0-1.git325ec6c.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-aca5a759b9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398799] Review Request: php-phpiredis - Client extension for Redis
https://bugzilla.redhat.com/show_bug.cgi?id=1398799 --- Comment #10 from Fedora Update System --- php-phpiredis-1.0.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b95b487a46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1365839] Review Request: python-django-notifications-hq - GitHub notifications alike app for Django
https://bugzilla.redhat.com/show_bug.cgi?id=1365839 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- python-django-notifications-hq-1.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cbdd135f0a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398929] Review Request: brightnessctl - Read and control device brightness
https://bugzilla.redhat.com/show_bug.cgi?id=1398929 --- Comment #10 from Fedora Update System --- brightnessctl-0.1.1_p2-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-064940f7b8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376783] Review Request: python-can: The can package provides controller area network support for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- > All of the above is a matter of opinion and hence the choice of the > maintainer. Sure, this was just a suggestion. I do think it makes life easier (certainly for a reviewer, but I think also for the maintainer). The license is specified incorrectly: it's LGPLv3+ according to the LICENSE file. rpmlint: python2-can.noarch: E: script-without-shebang /usr/bin/j1939_logger.py python2-can.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/can/util.py /usr/bin/env python3 python2-can.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/can/util.py 644 /usr/bin/env python3 python2-can.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/can/broadcastmanager.py /usr/bin/env python3 python2-can.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/can/broadcastmanager.py 644 /usr/bin/env python3 At least the first should be fixed. Requires python2-can (rpmlib, GLIBC filtered): /usr/bin/python3 <--- this looks wrong python(abi) Provides python3-can: python-can < this looks wrong python3-can python3.5dist(python-can) python3dist(python-can) Oh, it's a typo in python_provide for the py3 subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1376783 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Summary|Review Request: python-can: |Review Request: python-can |The can package provides|- Controller Area Network |controller area network |(CAN) support for Python |support for Python | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio
https://bugzilla.redhat.com/show_bug.cgi?id=1389971 --- Comment #41 from Antonio Trande --- Please, post new links (rebuild the src-rpm from new SPEC file). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1289717] Review Request: viennacl - Linear algebra and solver library using CUDA, OpenCL, and OpenMP
https://bugzilla.redhat.com/show_bug.cgi?id=1289717 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1386938] Review Request: libprelude - Prelude Library
https://bugzilla.redhat.com/show_bug.cgi?id=1386938 --- Comment #18 from Zbigniew Jędrzejewski-Szmek --- *** Bug 1380180 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1401013] Review Request: git-octopus - git commands for continuous delivery
https://bugzilla.redhat.com/show_bug.cgi?id=1401013 Guido Aulisi changed: What|Removed |Added CC||guido.aul...@gmail.com --- Comment #2 from Guido Aulisi --- This is an unofficial review. Please always use raw direct URLs for spec and SRPMS files, and the format you used in the first comment. fedora-review is failing to parse the spec file because it tries to parse the github page (https://github.com/danoliv/git-octopus-spec/blob/master/git-octopus.spec), instead of the plain txt spec file. This software requires the shasum command, which is a perl script from perl-Digest-SHA package. IMHO it would be better to use the sha1sum command from coreutils, but this would require an upstream patch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1386938] Review Request: libprelude - Prelude Library
https://bugzilla.redhat.com/show_bug.cgi?id=1386938
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|ASSIGNED|POST
Blocks|177841 (FE-NEEDSPONSOR) |
Flags|fedora-review? |fedora-review+
--- Comment #19 from Zbigniew Jędrzejewski-Szmek ---
fedora-review says:
- Package does not contain duplicates in %files.
Note: warning: File listed twice:
/usr/lib64/perl5/vendor_perl/auto/Prelude/Prelude.so
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
(Use "%dir %{perl_vendorarch}/auto/Prelude")
fedora-review has some other complaints, but they are invalid afaict.
Rpmlint
---
Checking: libprelude-3.1.0-26.fc26.x86_64.rpm
libprelude-devel-3.1.0-26.fc26.x86_64.rpm
prelude-tools-3.1.0-26.fc26.x86_64.rpm
python2-prelude-3.1.0-26.fc26.x86_64.rpm
python3-prelude-3.1.0-26.fc26.x86_64.rpm
perl-prelude-3.1.0-26.fc26.x86_64.rpm
ruby-prelude-3.1.0-26.fc26.x86_64.rpm
lua-prelude-3.1.0-26.fc26.x86_64.rpm
libprelude-doc-3.1.0-26.fc26.noarch.rpm
libprelude-debuginfo-3.1.0-26.fc26.x86_64.rpm
libprelude-3.1.0-26.fc26.src.rpm
libprelude.x86_64: W: crypto-policy-non-compliance-gnutls-2
/usr/lib64/libprelude.so.23.3.0 gnutls_priority_init
prelude-tools.x86_64: W: crypto-policy-non-compliance-gnutls-1
/usr/bin/prelude-admin gnutls_priority_set_direct
This is probably a bug in the rpmlint checker.
libprelude-devel.x86_64: W: only-non-binary-in-usr-lib
prelude-tools.x86_64: W: spelling-error Summary(en_US) libprelude -> lib
prelude, lib-prelude, prelude
prelude-tools.x86_64: W: no-manual-page-for-binary prelude-adduser
python2-prelude.x86_64: W: no-documentation
python3-prelude.x86_64: W: no-documentation
perl-prelude.x86_64: W: no-documentation
ruby-prelude.x86_64: W: no-documentation
lua-prelude.x86_64: W: no-documentation
libprelude-doc.noarch: W: spelling-error %description -l en_US gtk -> gt, gt k
11 packages and 0 specfiles checked; 0 errors, 11 warnings.
All OK.
+ package name is OK
+ license is ACCEPTABLE (various variants of GPL)
- license is specified correctly (see below)
+ builds and installs OK
+ P/R/BR look correct
+ scriptlets look OK
+ %check is present and passes
The license tag is not correct though: the license tag applies to the *binary*
rpms
[https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#Does_the_License:_tag_cover_the_SRPM_or_the_binary_RPM.3F,
https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F].
In this case:
# libmissing is LGPL-2.1+ → built as part of the final product, compatible with
GPL
# libmissing/test is GPL-3.0+ → can be ignored, because this is not distributed
as part of the binary rpm
# Prelude is GPL-2.0+ → This is the effective license
Build fails in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16709324, on arm64 this
time.
The error doesn't look to bad, but it's most likely an upstream issue,
so I think it's fine if you use ExcludeArch until it's fixed.
prelude-log.c: In function 'do_log_v':
prelude-log.c:51:50: error: incompatible type for argument 1 of 'memmove'
# define PRELUDE_VA_COPY(ap1, ap2) memmove ((ap1), (ap2),
sizeof(va_list))
^
prelude-log.c:229:9: note: in expansion of macro 'PRELUDE_VA_COPY'
PRELUDE_VA_COPY(bkp, ap);
^~~
In file included from /usr/include/features.h:397:0,
from /usr/include/sys/types.h:25,
from ../libmissing/sys/types.h:28,
from ../libmissing/ftw_.h:20,
from ./include/libmissing.h:34,
from prelude-log.c:24:
/usr/include/bits/string3.h:57:1: note: expected 'void *' but argument is of
type 'va_list {aka __va_list}'
__NTH (memmove (void *__dest, const void *__src, size_t __len))
^
prelude-log.c:51:57: error: incompatible type for argument 2 of 'memmove'
# define PRELUDE_VA_COPY(ap1, ap2) memmove ((ap1), (ap2),
sizeof(va_list))
^
prelude-log.c:229:9: note: in expansion of macro 'PRELUDE_VA_COPY'
PRELUDE_VA_COPY(bkp, ap);
^~~
In file included from /usr/include/features.h:397:0,
from /usr/include/sys/types.h:25,
from ../libmissing/sys/types.h:28,
from ../libmissing/ftw_.h:20,
from ./include/libmissing.h:34,
from prelude-log.c:24:
/usr/include/bits/string3.h:57:1: note: expected 'const void *' but argument is
of type 'va_list {aka __va_list}'
__NTH (memmove (void *__dest, const void *__src, size_t __len))
^
OK, so we have two simple issues (repeated file, license), and
[Bug 1279112] Review Request: kiss-fft - Fast Fourier Transform library
https://bugzilla.redhat.com/show_bug.cgi?id=1279112 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-12-02 16:24:49 --- Comment #20 from Fedora Update System --- kiss-fft-1.3.0-1.fc25, qm-dsp-1.7.1-1.fc25, qm-vamp-plugins-1.7.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1374898] Review Request: quasselc - API to access a Quassel Core in pure C
https://bugzilla.redhat.com/show_bug.cgi?id=1374898 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-12-02 16:25:04 --- Comment #16 from Fedora Update System --- quasselc-0-1.20160909gitfcd9669.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1374899] Review Request: quassel-irssi - An irssi plugin to connect to quassel core
https://bugzilla.redhat.com/show_bug.cgi?id=1374899 Bug 1374899 depends on bug 1374898, which changed state. Bug 1374898 Summary: Review Request: quasselc - API to access a Quassel Core in pure C https://bugzilla.redhat.com/show_bug.cgi?id=1374898 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396847] Review Request: screencloud - Easy to use screenshot sharing application
https://bugzilla.redhat.com/show_bug.cgi?id=1396847 Bug 1396847 depends on bug 1394149, which changed state. Bug 1394149 Summary: pythonqt: Switch to Python 3 https://bugzilla.redhat.com/show_bug.cgi?id=1394149 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396847] Review Request: screencloud - Easy to use screenshot sharing application
https://bugzilla.redhat.com/show_bug.cgi?id=1396847 Bug 1396847 depends on bug 1396846, which changed state. Bug 1396846 Summary: [PATCH] Update to 3.1; Switch to Qt5; Switch to Python3 https://bugzilla.redhat.com/show_bug.cgi?id=1396846 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility
https://bugzilla.redhat.com/show_bug.cgi?id=1394789 Bug 1394789 depends on bug 1394788, which changed state. Bug 1394788 Summary: Review Request: lua-mpack - Implementation of MessagePack for Lua https://bugzilla.redhat.com/show_bug.cgi?id=1394788 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1394788] Review Request: lua-mpack - Implementation of MessagePack for Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1394788 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-12-02 16:25:32 --- Comment #11 from Fedora Update System --- lua-mpack-1.0.3-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
