[Bug 1409382] Review Request: python36 - Version 3.6 of the Python programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1409382
--- Comment #1 from Iryna Shcherbina ---
-
NOTES
-
Upgrade path is clean from F24 to F25.
Rewheel mode is removed. [0]
Debug build is disabled. [1]
[0]
https://github.com/fedora-python/python36/commit/b5cda81775024ea2c7c74515f3593d7a5022a8fc
[1]
https://github.com/fedora-python/python36/commit/51bf9a17b445c120fbcc603246205ea225533f69
Package is flat, meaning that there are no subpackages, all the files and
directories are at the main package.
Binaries, libraries and man pages, which conflict with the system python3
package, are removed or renamed. The binary for this package is renamed to
python36.
python(abi) is not required/provided.
python3-setuptools and python3-pip come bundled with this package, so to comply
with the packaging guidelines, virtual provides are added:
$ rpm -q --provides python36
bundled(python3-pip) = 9.0.1
bundled(python3-setuptools) = 28.8.0
...
Libraries are installed into %{_libdir}/python3.6, so there is no conflict with
%{_libdir}/python3.5 at F24 and F25.
Tested on F24 virtual machine, which I upgraded to F25. No issues observed and
nothing conflicts with base python package.
Invoking 'python3' command fires up the python 3.5.1 (F24) or 3.5.2 (F25)
shell, and 'python36' - 3.6.0 shell.
Doing some more testing before approving the package.
---
RPMLINT
---
$ rpmlint python36-3.6.0-1.fc25.src.rpm
python36.src:205: W: macro-in-comment %{_lib}
python36.src:388: W: macro-in-comment %{pybasever}
python36.src:622: E: hardcoded-library-path in %{_prefix}/lib/debug/%{_libdir}
python36.src:668: E: hardcoded-library-path in
%{_prefix}/lib/python%{pybasever}/site-packages/__pycache__
python36.src:705: W: macro-in-comment %{_pyconfig32_h}
python36.src:707: W: macro-in-comment %{_pyconfig64_h}
python36.src:769: W: macro-in-comment %{pylibdir}
python36.src:829: E: use-of-RPM_SOURCE_DIR
python36.src:952: E: hardcoded-library-path in
%{_prefix}/lib/python%{pybasever}
python36.src:953: E: hardcoded-library-path in
%{_prefix}/lib/python%{pybasever}/site-packages
python36.src:954: E: hardcoded-library-path in
%{_prefix}/lib/python%{pybasever}/site-packages/__pycache__/
python36.src:40: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line
40)
python36.src: W: patch-not-applied Patch146: 00146-hashlib-fips.patch
1 packages and 0 specfiles checked; 6 errors, 7 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411984] Neofetch - a CLI system information tool written in Bash
https://bugzilla.redhat.com/show_bug.cgi?id=1411984
--- Comment #4 from Kees de Jong ---
I think I added all the (In reply to Mikolaj Izdebski from comment #1)
> SRPM URL points to HTML document.
> You should include your FAS account name.
>
> Spec file looks quite good. The only real problem I can see from it is that
> the package should own the whole %{_datadir}/%{name}. Also "rm -rf
> %{buildroot}" are not needed and should be removed.
FAS account is 'aqual1te', my OpenPGP key is still syncing across the SKS
servers, but can be found on this pool of servers already:
https://sks-keyservers.net/pks/lookup?op=vindex&search=0x0E45C98AB51428E6&fingerprint=on&exact=on
If there is no result, hit F5, the pool of servers is rotating the requests in
round robin. Most of the servers in the pool have my key already.
Please let me know if I corrected the problems now for the package (links
below).
(In reply to Michael Schwendt from comment #2)
> > %build
> >
> > %install
>
> Also be aware of:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
>
>
> > install -m755 config/config %{buildroot}%{_datadir}/%{name}/config
>
> There is no other configuration method in /etc or so? Just this executable
> shell script?
>
>
> > install -m644 %{name}.* %{buildroot}%{_mandir}/man1
>
> > %{_mandir}/man1/%{name}.1.gz
>
> More correct would be
>
> %{_mandir}/man1/%{name}.1*
>
> which would cover uncompressed manual pages as well as different
> compression, because the gzip compression of manual pages is not explicitly
> done inside this spec file but performed by rpmbuild on-the-fly depending on
> default rpmbuild configuration.
There is no system-wide configuration in e.g. /etc. When the script is ran for
the first time it copies a config to ~/.config/neofetch. I added your
suggestions, thanks!
(In reply to M. Herdiansyah from comment #3)
> Hello, I am one of the contributors of neofetch, and the maintainer for the
> third-party package for neofetch in copr.
>
> My only concern will be in
>
> >%install
>
> Since neofetch does have a Makefile, won't it be better to use
>
> %make_install
>
> instead of copying the files manually?
>
> Also, for
>
> > %{_datadir}/%{name}/ascii/distro/*
> > %{_datadir}/%{name}/config
>
> We can simplify it to
>
> %{_datadir}/%{name}/*
Because of the suggestions from comment #2 I couldn't use the Makefile. This is
because of the timestamps that need to be preserved. But still a very useful
suggestions just like your other suggestions. I added them.
Spec file: https://github.com/AquaL1te/neofetch/blob/master/neofetch.spec
SRPM:
https://github.com/AquaL1te/neofetch/raw/master/neofetch-2.0.2-1.fc25.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411467] Review Request: bitlbee-steam - Steam protocol plugin for BitlBee
https://bugzilla.redhat.com/show_bug.cgi?id=1411467 Garrett Holmstrom changed: What|Removed |Added Blocks|201449 (FE-DEADREVIEW) | --- Comment #1 from Garrett Holmstrom --- No, this review was less than three days old. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412128] Review Request: libpreludedb - Prelude DB Library
https://bugzilla.redhat.com/show_bug.cgi?id=1412128 --- Comment #11 from Fedora Update System --- libpreludedb-3.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7751501934 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412128] Review Request: libpreludedb - Prelude DB Library
https://bugzilla.redhat.com/show_bug.cgi?id=1412128 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework
https://bugzilla.redhat.com/show_bug.cgi?id=1268380 Björn "besser82" Esser changed: What|Removed |Added Blocks||1400748 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1400748 [Bug 1400748] shogun-5.0.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework
https://bugzilla.redhat.com/show_bug.cgi?id=1268380 --- Comment #37 from Stuart Campbell --- Spec URL:https://raw.githubusercontent.com/stuartcampbell/rpm-packages/master/sphinx-theme-bootstrap/python-sphinx-bootstrap-theme.spec SRPM URL:https://copr-be.cloud.fedoraproject.org/results/sic/packages/fedora-26-x86_64/00500519-python-sphinx-bootstrap-theme/python-sphinx-bootstrap-theme-0.4.13-1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework
https://bugzilla.redhat.com/show_bug.cgi?id=1268380 Björn "besser82" Esser changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #36 from Björn "besser82" Esser --- (In reply to Stuart Campbell from comment #34) > Thank you for the comments and the PR - much appreciated. You're welcome. Just update the links to srpm and spec here. I'll start a formal review then. =) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413203] Review Request: wingpanel-indicator-session - Session Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413203 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- wingpanel-indicator-session-2.0.1-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fdd9a40a00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413385] Review Request: wingpanel-indicator-keyboard - Keyboard Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413385 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- wingpanel-indicator-keyboard-2.0.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cc6adaf8d7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413301] Review Request: wingpanel-indicator-notifications - Notifications Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413301 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- wingpanel-indicator-notifications-2.0-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1afe43185e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413288] Review Request: wingpanel-indicator-power - Power indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413288 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- wingpanel-indicator-power-2.0.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2f0f2712ee -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413216] Review Request: wingpanel-indicator-sound - Sound Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413216 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- wingpanel-indicator-sound-2.0.3-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9ce1bd9168 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1408734] Review Request: php-victorjonsson-markdowndocs - Command line tool for generating markdown-formatted class documentation
https://bugzilla.redhat.com/show_bug.cgi?id=1408734 --- Comment #9 from Fedora Update System --- php-victorjonsson-markdowndocs-1.3.7-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5b7d52765c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413396] Review Request: wingpanel-indicator-network - Network Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413396 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- wingpanel-indicator-network-2.0.2-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-db305a3534 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1408734] Review Request: php-victorjonsson-markdowndocs - Command line tool for generating markdown-formatted class documentation
https://bugzilla.redhat.com/show_bug.cgi?id=1408734 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- php-victorjonsson-markdowndocs-1.3.7-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-369ecf6a9a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413133] Review Request: catimg - Print images in a terminal with 256 colors support
https://bugzilla.redhat.com/show_bug.cgi?id=1413133 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- catimg-2.2.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c304b14ce0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework
https://bugzilla.redhat.com/show_bug.cgi?id=1268380 --- Comment #35 from Björn "besser82" Esser --- Scratch builds with my proposed changes to the spec-file are working fine: el6: https://koji.fedoraproject.org/koji/taskinfo?taskID=17306345 el7: https://koji.fedoraproject.org/koji/taskinfo?taskID=17306347 f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=17306351 *** For el <= 6 you need to have explicit BR: epel-rpm-macros for local mock-builds to work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework
https://bugzilla.redhat.com/show_bug.cgi?id=1268380 --- Comment #34 from Stuart Campbell --- Thank you for the comments and the PR - much appreciated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409334] Review Request: kdiagram - Powerful libraries (KChart, KGantt) for creating business diagrams
https://bugzilla.redhat.com/show_bug.cgi?id=1409334 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kdiagram -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework
https://bugzilla.redhat.com/show_bug.cgi?id=1268380 --- Comment #33 from Björn "besser82" Esser --- Forgot to mention: You need to BR: python-setuptools / python3-setuptools as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework
https://bugzilla.redhat.com/show_bug.cgi?id=1268380
Björn "besser82" Esser changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||besse...@fedoraproject.org
Assignee|williamjmore...@gmail.com |besse...@fedoraproject.org
Summary|Review Request: |Review Request:
|python-sphinx-theme-bootstr |python-sphinx-bootstrap-the
|ap - A sphinx theme that|me - A sphinx theme that
|integrates the Bootstrap|integrates the Bootstrap
|framework |framework
--- Comment #32 from Björn "besser82" Esser ---
Since there was no progress within the last three months, I'll take over the
review…
***
Your link to the spec-file isn't valid, it must point to the raw spec-file…
Quick fix…
Spec URL:
https://raw.githubusercontent.com/stuartcampbell/rpm-packages/master/sphinx-theme-bootstrap/sphinx-theme-bootstrap.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sic/packages/fedora-rawhide-x86_64/00443690-python-sphinx-theme-bootstrap/python-sphinx-theme-bootstrap-0.4.5-2.fc26.src.rpm
***
Please update to the latest version: 0.4.13
***
Your spec-files is named wrong. It should be named
'python-python-sphinx-bootstrap-theme' according to naming guidelines. See:
https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Python_source_package_naming
***
Comments on the spec-file:
> %global summary A sphinx theme that integrates the Bootstrap framework
This isn't valid, since %{summary} is set by rpmbuild during parsing of the
spec-file and rotates it's contents for every sub-package. Use sth. like:
%{common_sum} instead:
%global common_sum A sphinx theme that integrates the Bootstrap framework
…
Summary: %{common_sum}
> # RHEL doesn't have python 3 and does not know about __python2
> %if 0%{?rhel}
> %global __python2 %{__python}
> %global python2_sitelib %{python_sitelib}
> %global with_python3 0
> %else
> %global with_python3 1
> %endif
Doing so is simply wrong… You are shadowing the settings of the system-macros
if present…
A cleaner solution would be:
%{?!__python2:%global __python2 %{__python}}
%{?!python2_sitelib:%global python2_sitelib %{python_sitelib}}
%if 0%{?fedora} >= 13 || 0%{?rhel} >= 8
%global with_py3 1
%endif # 0#{?fedora} >= 13 || 0#{?rhel} >= 8
This only evals if there is no system-preset for Python2 macros and works
without conditionals on a specific distro-release. Just setting with_py, when
it is present, simplyfies a lot of conditonals, especially one-liners can
profit from conditional expansion.
The Url for Source0 is wrong. See:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Python_Packages_.28pypi.29
> Requires: js-jquery1
Is wrong at this place. It must be placed into every sub-pkg, that needs it.
The BuildRequires should be moved into corresponding sub-pkg, too.
Repeating the same text in %description bloats the spec-file. You can use:
%global common_desc \
This sphinx theme integrates the Booststrap CSS / Javascript framework \
with various layout options, hierarchical menu navigation, and mobile-\
friendly responsive design. It is configurable, extensible and can use \
any number of different Bootswatch CSS themes.
And then use it in every %description like:
%description
%{common_desc}
The 'egg-info'-dir must be removed during %prep.
The package doesn't own the sub-dir it creates.
The installed egg-info-dirs should be packaged using the
%{pythonX_version}-macros.
There some other small adjustments. I've created a PR on github for this.
See: https://github.com/stuartcampbell/rpm-packages/pull/4/commits
***
Not approved. Please fix the spec-file and post updated links here; I'll give
it another shot then.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games
https://bugzilla.redhat.com/show_bug.cgi?id=1398949 --- Comment #35 from MartinKG --- Have implemented your suggestions. bear-0.7.0-0.12.20161230git781ec80.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-01992a871e bear-0.7.0-0.12.20161230git781ec80.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0e0b41d10 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1408620] Review Request: rdfind - Program that finds duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=1408620 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- rdfind-1.3.5-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-0e6638cc4e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1297550] Review Request: golang-github-jmespath-go-jmespath - Golang implementation of JMESPath
https://bugzilla.redhat.com/show_bug.cgi?id=1297550 --- Comment #25 from Fedora Update System --- golang-github-jmespath-go-jmespath-0.2.2-0.1.gitbd40a43.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c97327 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409660] Review Request: lxqt-build-tools - Packaging tools for LXQt
https://bugzilla.redhat.com/show_bug.cgi?id=1409660 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #17 from Fedora Update System --- lxqt-build-tools-0.3.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fad6f3d6a0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1270063] Review Request: golang-github-spf13-cast - Safe and easy casting from one type to another in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1270063 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #13 from Fedora Update System --- golang-github-spf13-cast-0-0.6.gite31f36f.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-b8a1a7b5ef -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1270064] Review Request: golang-github-spf13-viper - Go configuration with fangs
https://bugzilla.redhat.com/show_bug.cgi?id=1270064 Bug 1270064 depends on bug 1270063, which changed state. Bug 1270063 Summary: Review Request: golang-github-spf13-cast - Safe and easy casting from one type to another in Go https://bugzilla.redhat.com/show_bug.cgi?id=1270063 What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1297550] Review Request: golang-github-jmespath-go-jmespath - Golang implementation of JMESPath
https://bugzilla.redhat.com/show_bug.cgi?id=1297550 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #24 from Fedora Update System --- golang-github-jmespath-go-jmespath-0.2.2-0.1.gitbd40a43.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6054ad1a6f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1402675] Review Request: python-aiohttp-negotiate - Add-on for Python aiohttp library to support Negotiate authentication
https://bugzilla.redhat.com/show_bug.cgi?id=1402675 --- Comment #10 from Fedora Update System --- python-aiohttp-negotiate-0.11-1.fc24, python-www-authenticate-0.9.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1403314] Review Request: python-publicsuffix - Get a public suffix for a domain name using the Public Suffix List.
https://bugzilla.redhat.com/show_bug.cgi?id=1403314 --- Comment #19 from Fedora Update System --- python-publicsuffix-1.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1402673] Review Request: python-www-authenticate - Python library for parsing WWW-Authenticate HTTP header values
https://bugzilla.redhat.com/show_bug.cgi?id=1402673 --- Comment #10 from Fedora Update System --- python-aiohttp-negotiate-0.11-1.fc24, python-www-authenticate-0.9.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology
https://bugzilla.redhat.com/show_bug.cgi?id=1369213 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-01-16 14:51:12 --- Comment #47 from Fedora Update System --- python-django-netjsongraph-0.2.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1402675] Review Request: python-aiohttp-negotiate - Add-on for Python aiohttp library to support Negotiate authentication
https://bugzilla.redhat.com/show_bug.cgi?id=1402675 Bug 1402675 depends on bug 1402673, which changed state. Bug 1402673 Summary: Review Request: python-www-authenticate - Python library for parsing WWW-Authenticate HTTP header values https://bugzilla.redhat.com/show_bug.cgi?id=1402673 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1402673] Review Request: python-www-authenticate - Python library for parsing WWW-Authenticate HTTP header values
https://bugzilla.redhat.com/show_bug.cgi?id=1402673 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-01-16 14:50:35 --- Comment #9 from Fedora Update System --- python-aiohttp-negotiate-0.11-1.fc25, python-www-authenticate-0.9.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1402675] Review Request: python-aiohttp-negotiate - Add-on for Python aiohttp library to support Negotiate authentication
https://bugzilla.redhat.com/show_bug.cgi?id=1402675 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-01-16 14:50:31 --- Comment #9 from Fedora Update System --- python-aiohttp-negotiate-0.11-1.fc25, python-www-authenticate-0.9.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1403314] Review Request: python-publicsuffix - Get a public suffix for a domain name using the Public Suffix List.
https://bugzilla.redhat.com/show_bug.cgi?id=1403314 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-01-16 14:50:49 --- Comment #18 from Fedora Update System --- python-publicsuffix-1.1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1341099] Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs
https://bugzilla.redhat.com/show_bug.cgi?id=1341099 --- Comment #19 from Fedora Update System --- taskotron-trigger-0.4.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3eab8acf22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1341099] Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs
https://bugzilla.redhat.com/show_bug.cgi?id=1341099 --- Comment #20 from Fedora Update System --- taskotron-trigger-0.4.3-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b175c3dd22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1341099] Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs
https://bugzilla.redhat.com/show_bug.cgi?id=1341099 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409334] Review Request: kdiagram - Powerful libraries (KChart, KGantt) for creating business diagrams
https://bugzilla.redhat.com/show_bug.cgi?id=1409334 Christian Dersch changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409334] Review Request: kdiagram - Powerful libraries (KChart, KGantt) for creating business diagrams
https://bugzilla.redhat.com/show_bug.cgi?id=1409334
Christian Dersch changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Christian Dersch ---
Approved, but please add %post and %postun to call ldconfig on package import!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- ldconfig called in %post and %postun if required.
Note: /sbin/ldconfig not called in kdiagram
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated". 94 files have
unknown license. Detailed output of licensecheck in
/home/review/1409334-kdiagram/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/qt5,
/usr/lib64/qt5/mkspecs, /usr/lib64/cmake,
/usr/lib64/qt5/mkspecs/modules
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
N
[Bug 1409334] Review Request: kdiagram - Powerful libraries (KChart, KGantt) for creating business diagrams
https://bugzilla.redhat.com/show_bug.cgi?id=1409334 Christian Dersch changed: What|Removed |Added Status|NEW |ASSIGNED CC||lupi...@mailbox.org Assignee|nob...@fedoraproject.org|lupi...@mailbox.org Flags||fedora-review? --- Comment #2 from Christian Dersch --- Taken -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1365215] Review Request: drupal7-uuid - Adds support for universally unique identifiers
https://bugzilla.redhat.com/show_bug.cgi?id=1365215 --- Comment #14 from Fedora Update System --- drupal7-menu_token-1.0-0.9.beta7.el7, drupal7-uuid-1.0-0.1.beta2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1408988] Review Request: drupal7-drafty - Facilitates handling of draft revisions
https://bugzilla.redhat.com/show_bug.cgi?id=1408988 --- Comment #14 from Fedora Update System --- drupal7-drafty-1.0-0.1.beta3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1365215] Review Request: drupal7-uuid - Adds support for universally unique identifiers
https://bugzilla.redhat.com/show_bug.cgi?id=1365215 --- Comment #13 from Fedora Update System --- drupal7-menu_token-1.0-0.9.beta7.el6, drupal7-uuid-1.0-0.1.beta2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1408988] Review Request: drupal7-drafty - Facilitates handling of draft revisions
https://bugzilla.redhat.com/show_bug.cgi?id=1408988 --- Comment #13 from Fedora Update System --- drupal7-drafty-1.0-0.1.beta3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413694] Review Request: hawkinit - Hawkinit CLI Tool
https://bugzilla.redhat.com/show_bug.cgi?id=1413694 --- Comment #1 from Jirka Kremser --- Review Description: This is my first RPM package and according to [1] I need a sponsor build in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17303795 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413694] New: Review Request: hawkinit - Hawkinit CLI Tool
https://bugzilla.redhat.com/show_bug.cgi?id=1413694 Bug ID: 1413694 Summary: Review Request: hawkinit - Hawkinit CLI Tool Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jkrem...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://github.com/Jiri-Kremser/hawkinit/blob/master/rpm/hawkinit.spec SRPM URL: https://github.com/Jiri-Kremser/hawkinit/releases/download/1.3.2/hawkinit-1.3.2-1.fc25.src.rpm Description: CLI tool that sets up the Hawkular Services together with couple of servers to monitor Fedora Account System Username: jkremser Git repo with the readme file and the code here: https://github.com/Jiri-Kremser/hawkinit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405067] Review Request: golang-github-xeipuuv-gojsonpointer - JSON Pointer implementation in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1405067 Frantisek Kluknavsky changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405067] Review Request: golang-github-xeipuuv-gojsonpointer - JSON Pointer implementation in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1405067 --- Comment #3 from Frantisek Kluknavsky --- No. It seems OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411188] Review Request: php-echonest-api - PHP classes for the Echo Nest API
https://bugzilla.redhat.com/show_bug.cgi?id=1411188
Remi Collet changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #7 from Remi Collet ---
Blockers:
[!]: Requires correct, justified where necessary.
PHP virtual provides for extensions (curl, spl, ...) doesn't have version,
so you should not use version in requires (doesn't make sense for most of
ext.)
Only php(language) should have a version.
[!]: Package complies to the Packaging Guidelines
See https://fedoraproject.org/wiki/Packaging:Versioning
So Release should be 0..20131228git%{short_commit}%{?dist}
[!]: Rpmlint is run on all installed packages.
Drop excution right on all php scripts
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411188] Review Request: php-echonest-api - PHP classes for the Echo Nest API
https://bugzilla.redhat.com/show_bug.cgi?id=1411188 --- Comment #6 from Remi Collet --- Created attachment 1241328 --> https://bugzilla.redhat.com/attachment.cgi?id=1241328&action=edit review.txt Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1411188 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411188] Review Request: php-echonest-api - PHP classes for the Echo Nest API
https://bugzilla.redhat.com/show_bug.cgi?id=1411188 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|fed...@famillecollet.com --- Comment #5 from Remi Collet --- Created attachment 1241327 --> https://bugzilla.redhat.com/attachment.cgi?id=1241327&action=edit phpci.log phpCompatInfo version 5.0.3 DB version 1.16.0 built Dec 16 2016 06:59:17 CET static analyze results -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411188] Review Request: php-echonest-api - PHP classes for the Echo Nest API
https://bugzilla.redhat.com/show_bug.cgi?id=1411188 Remi Collet changed: What|Removed |Added Flags|needinfo?(fedora@famillecol | |let.com)| --- Comment #4 from Remi Collet --- > What do you think about that? It seems that the Ampache project is aware of > these dependencies, and does have plans to migrate to supported upstreams. > Can we package these abandoned dependencies until Ampache switches, and then > retire the packages once they are no longer needed? As discussed on devel ML, yes, it's ok. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396819] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1396819 --- Comment #10 from Zbigniew Jędrzejewski-Szmek --- (BTW: I plan to return to this soon...) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1114146] Review Request: rubygem-ffi-yajl - Ruby FFI wrapper around YAJL 2.x
https://bugzilla.redhat.com/show_bug.cgi?id=1114146 --- Comment #8 from Vít Ondruch --- (In reply to Julian C. Dunn from comment #7) > I can continue to work on it with your review as long as we are ok on the > approach of packaging rubygem-libyajl2 separately. I still think that packaging independent rubygem-libyajl2 is bad idea. But I am quite sure that with some effort, ffi-yajl can be made to use the system library. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405067] Review Request: golang-github-xeipuuv-gojsonpointer - JSON Pointer implementation in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1405067 --- Comment #2 from Jan Chaloupka --- Thanks for pointing that out. I will fix that in the spec file once built. Any other issues with the spec file? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405067] Review Request: golang-github-xeipuuv-gojsonpointer - JSON Pointer implementation in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1405067
--- Comment #1 from Frantisek Kluknavsky ---
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
%if 0%{?with_devel}
%files devel -f devel.file-list
%license LICENSE-APACHE-2.0.txt
%doc README.md
%dir %{gopath}/src/%{provider}.%{provider_tld}/%{project}
%endif
%if 0%{?with_unit_test} && 0%{?with_devel}
%files unit-test-devel -f unit-test-devel.file-list
%license LICENSE-APACHE-2.0.txt
%doc README.md
%endif
README.md in both subpackages is correct?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413646] New: Review Request: librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646 Bug ID: 1413646 Summary: Review Request: librealsense - Cross-platform camera capture for Intel RealSense Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: till.hofm...@posteo.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://thofmann.fedorapeople.org/librealsense.spec SRPM URL: https://thofmann.fedorapeople.org/librealsense-1.12.1-3.fc25.src.rpm Description: This project is a cross-platform library (Linux, OSX, Windows) for capturing data from the Intel® RealSense™ F200, SR300 and R200 cameras. This effort was initiated to better support researchers, creative coders, and app developers in domains such as robotics, virtual reality, and the internet of things. Several often-requested features of RealSense™ devices are implemented in this project, including multi-camera capture. Fedora Account System Username: thofmann COPR: https://copr.fedorainfracloud.org/coprs/thofmann/realsense/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405067] Review Request: golang-github-xeipuuv-gojsonpointer - JSON Pointer implementation in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1405067 Frantisek Kluknavsky changed: What|Removed |Added CC||fkluk...@redhat.com Assignee|nob...@fedoraproject.org|fkluk...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714 --- Comment #7 from Dusty Mabe --- Hey Igor, It looked like you were doing the review and Kyle was trying to address your comments so I thought he was waiting on feedback from you to finish the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1270063] Review Request: golang-github-spf13-cast - Safe and easy casting from one type to another in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1270063 --- Comment #12 from Fedora Update System --- golang-github-spf13-cast-0-0.6.gite31f36f.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-b8a1a7b5ef -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413394] Review Request: python-memory_profiler - Module for monitoring memory usage of a python program
https://bugzilla.redhat.com/show_bug.cgi?id=1413394 --- Comment #3 from Athos Ribeiro --- Basically running fedora-review. After that I tried just mock and got the same results. $ mock --version 1.3.3 sh-4.4# locale LANG=en_US.UTF-8 LC_CTYPE="en_US.UTF-8" LC_NUMERIC="en_US.UTF-8" LC_TIME="en_US.UTF-8" LC_COLLATE="en_US.UTF-8" LC_MONETARY="en_US.UTF-8" LC_MESSAGES="en_US.UTF-8" LC_PAPER="en_US.UTF-8" LC_NAME="en_US.UTF-8" LC_ADDRESS="en_US.UTF-8" LC_TELEPHONE="en_US.UTF-8" LC_MEASUREMENT="en_US.UTF-8" LC_IDENTIFICATION="en_US.UTF-8" LC_ALL= sh-4.4# exit logout Finish: shell [athos@host-machine]$ locale LANG=en_US.UTF-8 LC_CTYPE="en_US.UTF-8" LC_NUMERIC="en_US.UTF-8" LC_TIME="en_US.UTF-8" LC_COLLATE="en_US.UTF-8" LC_MONETARY="en_US.UTF-8" LC_MESSAGES="en_US.UTF-8" LC_PAPER="en_US.UTF-8" LC_NAME="en_US.UTF-8" LC_ADDRESS="en_US.UTF-8" LC_TELEPHONE="en_US.UTF-8" LC_MEASUREMENT="en_US.UTF-8" LC_IDENTIFICATION="en_US.UTF-8" LC_ALL= -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration
https://bugzilla.redhat.com/show_bug.cgi?id=1391457 --- Comment #14 from Charalampos Stratakis --- Also on line 82 it should be 'permissions' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #13 from Charalampos Stratakis ---
Regarding the python2 runtime requirements for ipaddress.
In order to test it at a machine or chroot where you have installed the python2
rpm you can run python2 -c 'import netjsonconfig' and you will see the
traceback about the missing module. fedora-review will not catch these issues.
You should add 'Requires: python-ipaddress' for the python2 subpackage.
rpmlint warns:
python-netjsonconfig.src:77: W: macro-in-comment %{__python2}
python-netjsonconfig.src:78: W: macro-in-comment %{__python3}
the macros in comments should be in the form of: %%{__python2}
Also a small typo at line 81, it should be 'templates'.
After these issues are fixed, the package should be fine.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1352714] Review Request: soup-sharp - libsoup C# bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1352714 Igor Gnatenko changed: What|Removed |Added Flags|needinfo?(ignatenko@redhat. | |com)| --- Comment #6 from Igor Gnatenko --- Dusty, why did you set needinfo? I just commented this request to provide my opinion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1057567] Review Request: ocltoys - Collection of OpenCL examples focused on Computer Graphics
https://bugzilla.redhat.com/show_bug.cgi?id=1057567 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX Flags|needinfo?(ignatenko@redhat. | |com)| Last Closed||2017-01-16 09:09:59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392977] Review Request: ocid - OCI-based implementation of Kubernetes Container Runtime Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1392977 Neil Horman changed: What|Removed |Added CC||nhor...@redhat.com --- Comment #17 from Neil Horman --- lokesh, is it possible to enable ppc64le and aarch64 on this package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1402319] Review Request: collectd-ceilometer-plugin - OpenStack Ceilometer plugin for collectd
https://bugzilla.redhat.com/show_bug.cgi?id=1402319 Haïkel Guémar changed: What|Removed |Added Status|NEW |ASSIGNED CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1408620] Review Request: rdfind - Program that finds duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=1408620 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1408620] Review Request: rdfind - Program that finds duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=1408620 --- Comment #17 from Fedora Update System --- rdfind-1.3.5-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-0e6638cc4e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413399] Review Request: wcstools - Software utilities to display and manipulate the WCS of a FITS image
https://bugzilla.redhat.com/show_bug.cgi?id=1413399
Christian Dersch changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #3 from Christian Dersch ---
Package is fine => Approved! Just use the %license tag for the COPYING files,
but as you can do this on import easily it is not a showstopper here. Also
thank you to use Debian patch to rename the library, other distributions use
this too => We have it similar in different distributions :)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file COPYING is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
===> Please use the %license tag for COPYING
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://admin.fedoraproject.org/pkgdb/package/wcstools
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
===> We will unretire this package => Fine
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 194560 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
===> Is ok in this case, we get build issues
[Bug 1413399] Review Request: wcstools - Software utilities to display and manipulate the WCS of a FITS image
https://bugzilla.redhat.com/show_bug.cgi?id=1413399 --- Comment #2 from Christian Dersch --- Koji scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=17299795 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
