[Bug 1468454] New: Review Request: php-pecl-timecop - Time travel and freezing extension
https://bugzilla.redhat.com/show_bug.cgi?id=1468454 Bug ID: 1468454 Summary: Review Request: php-pecl-timecop - Time travel and freezing extension Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://git.remirepo.net/cgit/rpms/php/pecl/php-pecl-timecop.git/plain/php-pecl-timecop.spec?id=6b21ee3b3cfa6d38fa661a30d372a1824217c8c1 SRPM URL: http://rpms.remirepo.net/SRPMS/php-pecl-timecop-1.2.7-1.fedora.src.rpm Description: A PHP extension providing "time travel" and "time freezing" capabilities, inspired by ruby timecop gem. Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1427085] Review Request: plantumlqeditor - Simple editor for PlantUML
https://bugzilla.redhat.com/show_bug.cgi?id=1427085 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-07 03:21:16 --- Comment #22 from Fedora Update System --- plantumlqeditor-1.2-9.20170403git964d4ef.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432983] Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1432983 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- camotics-1.1.1-6.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8e5487b2e9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467132] Review Request: json-c12 - JSON implementation in C
https://bugzilla.redhat.com/show_bug.cgi?id=1467132 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- json-c12-0.12.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-99ae3cbbfb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1444552] Review Request: python-sortedcontainers - A pure Python sorted collections library
https://bugzilla.redhat.com/show_bug.cgi?id=1444552 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #3 from Elliott Sales de Andrade --- A couple drive-by (informal) comments: * Why use GitHub source instead of PyPI? Upstream has bundled everything including docs and tests there, so it isn't lacking anything. It would reduce the number of %globals to track as well. * Docs are not built; the sources are in the tarball, so I don't see why they couldn't be built. Note that building docs would require additional dependencies [1]. The referenced .spec also shows how to run tests with nose, but I don't attempt to support RHEL builds. [1] https://gitlab.com/qulogic-rpms/dask/blob/master/python-sortedcontainers/python-sortedcontainers.spec#L16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432983] Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1432983 --- Comment #15 from Fedora Update System --- camotics-1.1.1-7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b10e857c05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432983] Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1432983 --- Comment #16 from Fedora Update System --- camotics-1.1.1-7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-25c9eb1f73 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467417] Review Request: python-plaster - Application configuration settings abstraction layer
https://bugzilla.redhat.com/show_bug.cgi?id=1467417 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- python-plaster-0.5-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-393cea5fb6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467417] Review Request: python-plaster - Application configuration settings abstraction layer
https://bugzilla.redhat.com/show_bug.cgi?id=1467417 --- Comment #6 from Fedora Update System --- python-plaster-0.5-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e95a7a2230 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421480] Review Request: js-jquery-prettyphoto - PrettyPhoto is a jQuery based lightbox clone
https://bugzilla.redhat.com/show_bug.cgi?id=1421480 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #4 from Fedora Update System --- js-jquery-prettyphoto-3.1.6-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8cdf8c4d94 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421480] Review Request: js-jquery-prettyphoto - PrettyPhoto is a jQuery based lightbox clone
https://bugzilla.redhat.com/show_bug.cgi?id=1421480 --- Comment #5 from Fedora Update System --- js-jquery-prettyphoto-3.1.6-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f8ba57a078 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465954] Review Request: python-pathspec - Utility library for gitignore style pattern matching of file paths
https://bugzilla.redhat.com/show_bug.cgi?id=1465954 --- Comment #2 from Adrien Vergé --- Thanks for reviewing! I've updated the spec and SRPM to include the license file: https://adrienverge.fedorapeople.org/packages/python-pathspec/python-pathspec.spec https://adrienverge.fedorapeople.org/packages/python-pathspec/python-pathspec-0.5.3-1.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440968] Review Request: python-setuptools_scm_git_archive - A setuptools_scm plugin that adds support for git archives
https://bugzilla.redhat.com/show_bug.cgi?id=1440968 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #1 from Elliott Sales de Andrade --- Note that the pytest command was only added with 3.0.0, which is only in F26, so you'd need to modify the testing if you plan to import into F25. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 812758] Review Request: trader - Star Traders, a simple game of interstellar trading
https://bugzilla.redhat.com/show_bug.cgi?id=812758 --- Comment #55 from Fedora Update System --- trader-7.11-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 812758] Review Request: trader - Star Traders, a simple game of interstellar trading
https://bugzilla.redhat.com/show_bug.cgi?id=812758 --- Comment #56 from Fedora Update System --- trader-7.11-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468545] New: Review Request: rust-packaging - RPM macros for building Rust packages on various architectures
https://bugzilla.redhat.com/show_bug.cgi?id=1468545 Bug ID: 1468545 Summary: Review Request: rust-packaging - RPM macros for building Rust packages on various architectures Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ignate...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-packaging.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-packaging-3-5.fc27.src.rpm Description: The package provides macros for building projects in Rust on various architectures. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1463429] Review Request: rust-srpm-macros - RPM macros for building Rust source packages
https://bugzilla.redhat.com/show_bug.cgi?id=1463429 Igor Gnatenko changed: What|Removed |Added Blocks||1468545 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1468545 [Bug 1468545] Review Request: rust-packaging - RPM macros for building Rust packages on various architectures -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468545] Review Request: rust-packaging - RPM macros for building Rust packages on various architectures
https://bugzilla.redhat.com/show_bug.cgi?id=1468545 Igor Gnatenko changed: What|Removed |Added Depends On||1463429 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1463429 [Bug 1463429] Review Request: rust-srpm-macros - RPM macros for building Rust source packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server
https://bugzilla.redhat.com/show_bug.cgi?id=1321449 Marek Cermak changed: What|Removed |Added CC||macer...@redhat.com Assignee|nob...@fedoraproject.org|macer...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server
https://bugzilla.redhat.com/show_bug.cgi?id=1321449 Marek Cermak changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1466961] Review Request: datamash - A statistical, numerical and textual operations tool
https://bugzilla.redhat.com/show_bug.cgi?id=1466961 --- Comment #6 from Dave Love --- (In reply to Hannes Frederic Sowa from comment #5) > Do I need to add a version to bundled(gnulib)? rpmlint complains right now. Yes, I noticed that. You can't add a version, as it doesn't have one. I'd just note/explain the error in the spec file. You don't need to remove buildroot in %install these days, but it doesn't hurt. Also the packaging guidelines say not to use macros like %_rm > Dave, I would love to make this package compatible to EPEL. I am going to > read into that but feel free to dump any links on me. :) I'll attach a patch. I realize it's only really for el6, but _I think_ the location for completions should be changed on others, as in the patch. Otherwise the diff is mostly moot. (I don't know if using pkg-config is the right way to get the completions directory.) Handling completions should be in packaging guidelines. You do need to own the completions directories with %dir anyhow, which I patched in. Hope that helps, and apologies if I'm stepping on reviewer toes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1466961] Review Request: datamash - A statistical, numerical and textual operations tool
https://bugzilla.redhat.com/show_bug.cgi?id=1466961 --- Comment #7 from Dave Love --- Created attachment 1295270 --> https://bugzilla.redhat.com/attachment.cgi?id=1295270&action=edit spec patch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468454] Review Request: php-pecl-timecop - Time travel and freezing extension
https://bugzilla.redhat.com/show_bug.cgi?id=1468454 --- Comment #1 from Remi Collet --- Scratch build https://twitter.com/patrick_allaert/status/883322972529975296 Spec: https://git.remirepo.net/cgit/rpms/php/pecl/php-pecl-timecop.git/plain/php-pecl-timecop.spec?id=e352e7d880853b15c950285b4938636aad93a2a1 Srpm: http://rpms.remirepo.net/SRPMS/php-pecl-timecop-1.2.8-1.fedora.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468454] Review Request: php-pecl-timecop - Time travel and freezing extension
https://bugzilla.redhat.com/show_bug.cgi?id=1468454 --- Comment #2 from Remi Collet --- Sorry.. scratch build is http://rpms.remirepo.net/SRPMS/php-pecl-timecop-1.2.8-1.fedora.src.rpm (s390x not yet run... no builder available) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468454] Review Request: php-pecl-timecop - Time travel and freezing extension
https://bugzilla.redhat.com/show_bug.cgi?id=1468454 --- Comment #3 from Remi Collet --- I'm damned with copy/paste... https://koji.fedoraproject.org/koji/taskinfo?taskID=20381748 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465954] Review Request: python-pathspec - Utility library for gitignore style pattern matching of file paths
https://bugzilla.redhat.com/show_bug.cgi?id=1465954 Adam Miller changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Adam Miller --- Looks good, thanks! APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468665] New: Review Request: gsettings-qt - QML bindings for GSettings
https://bugzilla.redhat.com/show_bug.cgi?id=1468665 Bug ID: 1468665 Summary: Review Request: gsettings-qt - QML bindings for GSettings Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: szts...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://zsun.fedorapeople.org/pub/pkgs/gsettings-qt/gsettings-qt.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/gsettings-qt/gsettings-qt-0.1.r83-1.fc25.src.rpm Description: QML bindings for GSettings Fedora Account System Username: zsun -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440968] Review Request: python-setuptools_scm_git_archive - A setuptools_scm plugin that adds support for git archives
https://bugzilla.redhat.com/show_bug.cgi?id=1440968 --- Comment #2 from Athos Ribeiro --- Oh, Thanks for pointing that out, Elliot. I had not noticed that! Since f26 is almost out, I will just not build this package for f25, unless someone needs it there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468665] Review Request: gsettings-qt - QML bindings for GSettings
https://bugzilla.redhat.com/show_bug.cgi?id=1468665 Zamir SUN changed: What|Removed |Added Blocks||1465889 ||(DeepinDEPackageReview) Alias||gsettings-qt Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 Zamir SUN changed: What|Removed |Added Depends On||1468665 (gsettings-qt) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1468665 [Bug 1468665] Review Request: gsettings-qt - QML bindings for GSettings -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468665] Review Request: gsettings-qt - QML bindings for GSettings
https://bugzilla.redhat.com/show_bug.cgi?id=1468665 --- Comment #1 from Zamir SUN --- > gsettings-qt.x86_64: W: no-documentation > gsettings-qt-devel.x86_64: W: no-documentation This is a binding so do not have documentation. > gsettings-qt.src: W: invalid-url Source0: gsettings-qt-r83.tgz As explained in the spec file, since the source code is stored in launchpad bzr and its download link does not end with the source code name, so make it a manual source. This is a dependency for some other packages we will send for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects
https://bugzilla.redhat.com/show_bug.cgi?id=1467322 --- Comment #10 from Adam Miller --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #9) > I wouldn't sweat it. In decreasing order of compliance with the guidelines: > - just use a date: Provides: bundled(golang(golang.org/x/net)) = 20170305 >(where the date is the date where the vendorization was done or something) > - just use unversioned provides: Provides: bundled(golang(golang.org/x/net)) > > (The latter is pretty common, try "rpm -q -a --provides|grep bundled"... The > guidelines are well-intentioned, but if it's so hard to find which version > exactly is bundled, *and* this is something you'd have to do after every > update, I just don't think it's worth your time.) Neither of those options is in line with the Guidelines that went through FPC and FESCo for approval, please don't advocate for their use. Neither of those options provide a proper mechanism for auditing. I have opened a ticket with FESCo to determine appropriate action for dealing with all the not versioned bundled entries currently in existence. https://pagure.io/fesco/issue/1734 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/ Qt Developer work on Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421047 Zamir SUN changed: What|Removed |Added Depends On||1468665 (gsettings-qt) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1468665 [Bug 1468665] Review Request: gsettings-qt - QML bindings for GSettings -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468665] Review Request: gsettings-qt - QML bindings for GSettings
https://bugzilla.redhat.com/show_bug.cgi?id=1468665 Zamir SUN changed: What|Removed |Added Blocks||1421047 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1421047 [Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/Qt Developer work on Deepin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1419330] Review Request: deepin-menu - deepin menu service
https://bugzilla.redhat.com/show_bug.cgi?id=1419330 Zamir SUN changed: What|Removed |Added Depends On||1421047 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1421047 [Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/Qt Developer work on Deepin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/ Qt Developer work on Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421047 Zamir SUN changed: What|Removed |Added Blocks||1419330 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1419330 [Bug 1419330] Review Request: deepin-menu - deepin menu service -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/ Qt Developer work on Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421047 Felix Yan changed: What|Removed |Added Depends On||1419332 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1419332 [Bug 1419332] Review Request: deepin-shortcut-viewer - deepin shortcut viewer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1419332] Review Request: deepin-shortcut-viewer - deepin shortcut viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1419332 Felix Yan changed: What|Removed |Added CC||felixonm...@archlinux.org Blocks||1421047 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1421047 [Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/Qt Developer work on Deepin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/ Qt Developer work on Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421047 Felix Yan changed: What|Removed |Added Depends On|1419332 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1419332 [Bug 1419332] Review Request: deepin-shortcut-viewer - deepin shortcut viewer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1419332] Review Request: deepin-shortcut-viewer - deepin shortcut viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1419332 Felix Yan changed: What|Removed |Added Blocks|1421047 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1421047 [Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/Qt Developer work on Deepin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1419332] Review Request: deepin-shortcut-viewer - deepin shortcut viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1419332 Felix Yan changed: What|Removed |Added Depends On||1421047 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1421047 [Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/Qt Developer work on Deepin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/ Qt Developer work on Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421047 Felix Yan changed: What|Removed |Added CC||felixonm...@archlinux.org Blocks||1419332 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1419332 [Bug 1419332] Review Request: deepin-shortcut-viewer - deepin shortcut viewer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421044] Review Request: deepin-qml-widgets - Deepin QML widgets
https://bugzilla.redhat.com/show_bug.cgi?id=1421044 Felix Yan changed: What|Removed |Added Depends On||1421047 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1421047 [Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/Qt Developer work on Deepin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/ Qt Developer work on Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421047 Felix Yan changed: What|Removed |Added Blocks||1421044 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1421044 [Bug 1421044] Review Request: deepin-qml-widgets - Deepin QML widgets -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1419330] Review Request: deepin-menu - deepin menu service
https://bugzilla.redhat.com/show_bug.cgi?id=1419330 Felix Yan changed: What|Removed |Added Depends On||1421065 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1421065 [Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 Felix Yan changed: What|Removed |Added CC||felixonm...@archlinux.org Blocks||1419330 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1419330 [Bug 1419330] Review Request: deepin-menu - deepin menu service -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421066] Review Request: deepin-wm-switcher - Window manager switcher for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421066 Felix Yan changed: What|Removed |Added Depends On||1421058 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1421058 [Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421058 Felix Yan changed: What|Removed |Added CC||felixonm...@archlinux.org Blocks||1421066 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1421066 [Bug 1421066] Review Request: deepin-wm-switcher - Window manager switcher for Deepin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467418] Review Request: python-plaster-pastedeploy - A PasteDeploy binding to the plaster configuration loader
https://bugzilla.redhat.com/show_bug.cgi?id=1467418 --- Comment #6 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-plaster-pastedeploy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467762] Review Request: btrbk - Tool for creating snapshots and remote backups of btrfs subvolumes
https://bugzilla.redhat.com/show_bug.cgi?id=1467762 --- Comment #6 from Mike Goodwin --- Upstream patch was merged, will remove hack for their next release -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1466961] Review Request: datamash - A statistical, numerical and textual operations tool
https://bugzilla.redhat.com/show_bug.cgi?id=1466961 --- Comment #8 from Hannes Frederic Sowa --- Hi, (In reply to Dave Love from comment #6) > (In reply to Hannes Frederic Sowa from comment #5) > > Do I need to add a version to bundled(gnulib)? rpmlint complains right now. > > Yes, I noticed that. You can't add a version, as it doesn't have one. > I'd just note/explain the error in the spec file. According to rpm --whatprovides 'bundled(gnulib)' at least some libraries specify version attributes. I just couldn't figure out yet how they do it. > You don't need to remove buildroot in %install these days, but it doesn't > hurt. Yep, I understood. I did it for grepability and cosmetic reasons. ;) > Also the packaging guidelines say not to use macros like %_rm I will change that. > > Dave, I would love to make this package compatible to EPEL. I am going to > > read into that but feel free to dump any links on me. :) > > I'll attach a patch. I realize it's only really for el6, but _I think_ the > location for completions should be changed on others, as in the patch. > Otherwise the diff is mostly moot. (I don't know if using pkg-config is the > right > way to get the completions directory.) Handling completions should be in > packaging guidelines. > You do need to own the completions directories with %dir anyhow, which I > patched in. > > Hope that helps, and apologies if I'm stepping on reviewer toes. No no, any help is welcome. Thanks a lot for the patch. Can I just use it and apply it to my version? How can I attribute your help in the spec file correctly? Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467762] Review Request: btrbk - Tool for creating snapshots and remote backups of btrfs subvolumes
https://bugzilla.redhat.com/show_bug.cgi?id=1467762 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Igor Gnatenko --- %systemd_requires is required only for scriptlets, so it's fine to just remove it Also remove perl from Requires, it will be automatically generated. Don't see any other issues, APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467418] Review Request: python-plaster-pastedeploy - A PasteDeploy binding to the plaster configuration loader
https://bugzilla.redhat.com/show_bug.cgi?id=1467418 --- Comment #7 from Randy Barlow --- Thanks for the review! I've removed the period in this commit, which was made before any builds were built: http://pkgs.fedoraproject.org/cgit/rpms/python-plaster-pastedeploy.git/commit/?id=f4465ac5b4e2ef98c754d9a8f5e1e9d05b3e341f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 Carl George changed: What|Removed |Added Status|NEW |CLOSED CC||carl@george.computer Resolution|--- |CURRENTRELEASE Last Closed||2017-07-07 16:52:00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468766] New: Review Request: openzwave - OpenZWave is a library to support for Z-Wave home-automation devices
https://bugzilla.redhat.com/show_bug.cgi?id=1468766 Bug ID: 1468766 Summary: Review Request: openzwave - OpenZWave is a library to support for Z-Wave home-automation devices Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@cchtml.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://michael.cronenworth.com/RPMS/openzwave.spec SRPM URL: http://michael.cronenworth.com/RPMS/openzwave-1.4.164-1.src.rpm Description: OpenZWave is an open-source, cross-platform library designed to enable anyone to add support for Z-Wave home-automation devices Fedora Account System Username: mooninite This is required for "Domoticz", which I will also be adding for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 --- Comment #16 from Carl George --- Pushed to EPEL 7 stable on 2016-03-04. https://bodhi.fedoraproject.org/updates/bash-completion-extras-2.1-8.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468768] New: Review Request: domoticz - Open source Home Automation System
https://bugzilla.redhat.com/show_bug.cgi?id=1468768 Bug ID: 1468768 Summary: Review Request: domoticz - Open source Home Automation System Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@cchtml.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://michael.cronenworth.com/RPMS/domoticz.spec SRPM URL: http://michael.cronenworth.com/RPMS/domoticz-3.5877-1.fc25.src.rpm Description: Domoticz is a Home Automation System that lets you monitor and configure various devices like: Lights, Switches, various sensors/meters like Temperature, Rain, Wind, UV, Electra, Gas, Water and much more. Notifications/Alerts can be sent to any mobile device Fedora Account System Username: mooninite -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468766] Review Request: openzwave - OpenZWave is a library to support for Z-Wave home-automation devices
https://bugzilla.redhat.com/show_bug.cgi?id=1468766 Michael Cronenworth changed: What|Removed |Added Blocks||1468768 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1468768 [Bug 1468768] Review Request: domoticz - Open source Home Automation System -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468768] Review Request: domoticz - Open source Home Automation System
https://bugzilla.redhat.com/show_bug.cgi?id=1468768 Michael Cronenworth changed: What|Removed |Added Depends On||1468766 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1468766 [Bug 1468766] Review Request: openzwave - OpenZWave is a library to support for Z-Wave home-automation devices -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1461368] Review Request: mingw-pcre2 - MinGW Windows pcre2 library
https://bugzilla.redhat.com/show_bug.cgi?id=1461368
Ben Rosser changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #1 from Ben Rosser ---
A couple of initial comments. I'm not terribly familiar with MinGW, so
apologies if any of these are stupid things to ask.
- What's the purpose of these four lines?
rm -rf %{buildroot}%{mingw32_datadir}/doc/*
rm -rf %{buildroot}%{mingw64_datadir}/doc/*
rm -rf %{buildroot}%{mingw32_datadir}/man/*
rm -rf %{buildroot}%{mingw64_datadir}/man/*
https://fedoraproject.org/wiki/Packaging:MinGW?rd=Packaging/MinGW#Filesystem_location_macros
implies that this is indeed where man pages should be installed. Is there a
reason they're being removed by %install? If so that should be stated in a
comment somewhere.
- Closely related to the above comment, but all four built packages have no
documentation. Is there something that can be installed somwehere? Is there a
reason that whatever gets installed in %install isn't kept?
- The -static subpackages should have a %license tag as well, as they can be
installed separately from the main packages.
- pcre2grep and pcre2test are listed twice in both the mingw32 and mingw64 file
lists; is there a reason for this?
%{mingw32_bindir}/pcre2grep.exe
%{mingw32_bindir}/pcre2test.exe
%{mingw32_bindir}/pcre2grep.exe
%{mingw32_bindir}/pcre2test.exe
Otherwise, I think the package is okay.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1426962] Review Request: nodejs-net-browserify-alt - A port of the net module for the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1426962 Michael Cronenworth changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@cchtml.com Assignee|nob...@fedoraproject.org|m...@cchtml.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1463821] Review Request: nodejs-simple-markdown - Javascript markdown parsing, made simple
https://bugzilla.redhat.com/show_bug.cgi?id=1463821 Michael Cronenworth changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@cchtml.com Assignee|nob...@fedoraproject.org|m...@cchtml.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1463797] Review Request: nodejs-irc-colors - Color and formatting for irc made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1463797 Michael Cronenworth changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@cchtml.com Assignee|nob...@fedoraproject.org|m...@cchtml.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467418] Review Request: python-plaster-pastedeploy - A PasteDeploy binding to the plaster configuration loader
https://bugzilla.redhat.com/show_bug.cgi?id=1467418 Randy Barlow changed: What|Removed |Added Fixed In Version||python-plaster-pastedeploy- ||0.3.2-1.fc27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos
https://bugzilla.redhat.com/show_bug.cgi?id=1465588 --- Comment #2 from Ben Rosser --- - Remove spurious rm -rf of the buildroot from install section. - Switch to make build/install macros. Spec URL: https://tc01.fedorapeople.org/xoreos/xoreos-tools.spec SRPM URL: https://tc01.fedorapeople.org/xoreos/xoreos-tools-0.0.4-2.fc25.src.rpm > - empty /usr/lib in xoreos-tools-0.0.4-1.fc27.x86_64.rpm It's not actually empty; it contains the new debuginfo build-id stuff that seems to be a consequence of this F27 change: https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo. (that sadly rpmlint doesn't seem to know about yet). In other words, I don't think it's a problem with this package. But I could be wrong. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468766] Review Request: openzwave - OpenZWave is a library to support for Z-Wave home-automation devices
https://bugzilla.redhat.com/show_bug.cgi?id=1468766 Ben Rosser changed: What|Removed |Added CC||rosser@gmail.com Assignee|nob...@fedoraproject.org|rosser@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468768] Review Request: domoticz - Open source Home Automation System
https://bugzilla.redhat.com/show_bug.cgi?id=1468768 Ben Rosser changed: What|Removed |Added CC||rosser@gmail.com Assignee|nob...@fedoraproject.org|rosser@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos
https://bugzilla.redhat.com/show_bug.cgi?id=1465588 Sandro Mani changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Sandro Mani --- > It's not actually empty; it contains the new debuginfo build-id stuff that > seems to be a consequence of this F27 change: > > https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo. (that > sadly rpmlint doesn't seem to know about yet). In other words, I don't think > it's a problem with this package. But I could be wrong. Ah yes, correct. All good then, approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1461368] Review Request: mingw-pcre2 - MinGW Windows pcre2 library
https://bugzilla.redhat.com/show_bug.cgi?id=1461368 --- Comment #2 from Sandro Mani --- Spec URL: https://smani.fedorapeople.org/review/mingw-pcre2.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-pcre2-10.23-2.fc27.src.rpm %changelog * Fri Jul 07 2017 Sandro Mani - 10.23-2 - Remove duplicate listed files in %%files - Add %%license to static packages In MinGW packages, generic documentation isn't installed according to [1]. The files listed twice are indeed a typo. And correct, the static subpackages need a %license also. [1] https://fedoraproject.org/wiki/Packaging:MinGW?rd=Packaging/MinGW#Files_which_are_already_part_of_native_packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1426962] Review Request: nodejs-net-browserify-alt - A port of the net module for the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1426962
Michael Cronenworth changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Michael Cronenworth ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 16 files have
unknown license. Detailed output of licensecheck in
/home/michael/Projects/fedora/review/1426962-nodejs-net-browserify-
alt/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 235520 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless just
[Bug 1440968] Review Request: python-setuptools_scm_git_archive - A setuptools_scm plugin that adds support for git archives
https://bugzilla.redhat.com/show_bug.cgi?id=1440968 --- Comment #3 from Elliott Sales de Andrade --- I'm not sure if anyone needs it, but the py.test command still exists in F26, so it should be straightforward to support it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467762] Review Request: btrbk - Tool for creating snapshots and remote backups of btrfs subvolumes
https://bugzilla.redhat.com/show_bug.cgi?id=1467762 --- Comment #8 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/btrbk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467418] Review Request: python-plaster-pastedeploy - A PasteDeploy binding to the plaster configuration loader
https://bugzilla.redhat.com/show_bug.cgi?id=1467418 --- Comment #8 from Fedora Update System --- python-plaster-pastedeploy-0.3.2-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ef8636cd85 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467418] Review Request: python-plaster-pastedeploy - A PasteDeploy binding to the plaster configuration loader
https://bugzilla.redhat.com/show_bug.cgi?id=1467418 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1463821] Review Request: nodejs-simple-markdown - Javascript markdown parsing, made simple
https://bugzilla.redhat.com/show_bug.cgi?id=1463821
Michael Cronenworth changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Michael Cronenworth ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 11 files have
unknown license. Detailed output of licensecheck in
/home/michael/Projects/fedora/review/1463821-nodejs-simple-
markdown/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justifi
[Bug 1445412] Review Request: python-fpylll - A Python wrapper for fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-07 18:54:45 --- Comment #10 from Fedora Update System --- python-fpylll-0.2.3dev-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1427085] Review Request: plantumlqeditor - Simple editor for PlantUML
https://bugzilla.redhat.com/show_bug.cgi?id=1427085 --- Comment #23 from Fedora Update System --- plantumlqeditor-1.2-9.20170403git964d4ef.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1445412] Review Request: python-fpylll - A Python wrapper for fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412 Bug 1445412 depends on bug 1445411, which changed state. Bug 1445411 Summary: Review Request: python-cysignals - Interrupt and signal handling for Cython https://bugzilla.redhat.com/show_bug.cgi?id=1445411 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython
https://bugzilla.redhat.com/show_bug.cgi?id=1445411 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-05-04 11:31:39 |2017-07-07 18:54:41 --- Comment #12 from Fedora Update System --- python-cysignals-1.3.2-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1461769] Review Request: module-macros - provides macros for module development
https://bugzilla.redhat.com/show_bug.cgi?id=1461769 --- Comment #8 from Fedora Update System --- module-macros-0.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462983] Review Request: python-phonenumbers - A Python port of Google's libphonenumber
https://bugzilla.redhat.com/show_bug.cgi?id=1462983 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-07 18:57:31 --- Comment #14 from Fedora Update System --- python-phonenumbers-8.5.2-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432076] Review Request: urh - Universal Radio Hacker: investigate wireless protocols like a boss
https://bugzilla.redhat.com/show_bug.cgi?id=1432076 --- Comment #12 from Fedora Update System --- urh-1.6.6-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343710] Review Request: chrome-gnome-shell - Support for managing GNOME Shell Extensions through web browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1343710 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-07 18:57:17 --- Comment #54 from Fedora Update System --- chrome-gnome-shell-9-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451054] Review Request: python-terminaltables - Generate tables in terminals from list of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1451054 --- Comment #11 from Fedora Update System --- python-terminaltables-3.1.0-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library
https://bugzilla.redhat.com/show_bug.cgi?id=1462443 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-07 18:57:42 --- Comment #13 from Fedora Update System --- libaec-1.0.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440704] Review Request: cpprest - C++ REST SDK
https://bugzilla.redhat.com/show_bug.cgi?id=1440704 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-07 18:59:49 --- Comment #26 from Fedora Update System --- cpprest-2.9.1-16.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462412] Review Request: tworld - a puzzle game
https://bugzilla.redhat.com/show_bug.cgi?id=1462412 --- Comment #16 from Fedora Update System --- tworld-1.3.2-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465817] Review Request: perl-Mail-Box-IMAP4 - Handle IMAP4 folders as client
https://bugzilla.redhat.com/show_bug.cgi?id=1465817 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-07 19:05:48 --- Comment #8 from Fedora Update System --- perl-Mail-Box-IMAP4-3.002-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409654] Review Request: python-pydocstyle - Python docstring style checker
https://bugzilla.redhat.com/show_bug.cgi?id=1409654 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-07 19:06:15 --- Comment #18 from Fedora Update System --- python-pydocstyle-2.0.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1466685] Review Request: python-sphinxcontrib-websupport - Sphinx API for Web Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1466685 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-07 19:06:20 --- Comment #5 from Fedora Update System --- python-sphinxcontrib-websupport-1.0.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2
https://bugzilla.redhat.com/show_bug.cgi?id=1372892 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com Flags||needinfo?(ignatenko@redhat. ||com) --- Comment #6 from Elliott Sales de Andrade --- Are you going to import this? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440971] Review Request: python-pyclipper - Cython wrapper for the C++ translation of the Angus Johnson 's Clipper library
https://bugzilla.redhat.com/show_bug.cgi?id=1440971
Elliott Sales de Andrade changed:
What|Removed |Added
CC||quantum.anal...@gmail.com
--- Comment #1 from Elliott Sales de Andrade ---
This is not a formal review. The major problems are:
* Pyclipper embeds the C++ clipper code; this is generally frowned upon, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries
for more information.
* Relatedly, the C++ code is licensed under the Boost Software License, not
MIT.
Minor issues:
* %{srcname} could be used for the .so file.
* Rpmlint output can generally be ignored; spelling errors are not really
errors.
However, the source files should not really be executable. That should
probably
be fixed upstream.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "*No copyright* BSL", "Unknown or
generated". 14 files have unknown license. Detailed output of
licensecheck in 1440971-python-pyclipper/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[?]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs
[Bug 1440992] Review Request: python-booleanOperations - Boolean operations on paths
https://bugzilla.redhat.com/show_bug.cgi?id=1440992 Elliott Sales de Andrade changed: What|Removed |Added Depends On||1440971 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1440971 [Bug 1440971] Review Request: python-pyclipper - Cython wrapper for the C++ translation of the Angus Johnson's Clipper library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440971] Review Request: python-pyclipper - Cython wrapper for the C++ translation of the Angus Johnson 's Clipper library
https://bugzilla.redhat.com/show_bug.cgi?id=1440971 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1440992 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1440992 [Bug 1440992] Review Request: python-booleanOperations - Boolean operations on paths -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
