[Bug 1491172] Review Request: golang-github-templexxx-xor - XOR code engine in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491172



--- Comment #10 from Fedora Update System  ---
golang-github-templexxx-xor-0.1.1-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d387cf3689

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487884] Review Request: python-sortedcontainers - Python Sorted Container Types: SortedList, SortedDict, and SortedSet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487884



--- Comment #11 from Fedora Update System  ---
python-sortedcontainers-1.5.7-3.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6a554669de

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490068] Review Request: python-graphitesend - Easy python bindings to write to Carbon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490068



--- Comment #17 from Fedora Update System  ---
python-graphitesend-0.10.0-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-57804d0746

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491172] Review Request: golang-github-templexxx-xor - XOR code engine in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491172



--- Comment #9 from Fedora Update System  ---
golang-github-templexxx-xor-0.1.1-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-332ee44470

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490068] Review Request: python-graphitesend - Easy python bindings to write to Carbon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490068



--- Comment #16 from Fedora Update System  ---
python-graphitesend-0.10.0-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-05a3ffe8b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484331] Review Request: python-incremental - Incremental is a small library that versions your Python projects.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484331



--- Comment #7 from Fedora Update System  ---
python-incremental-17.5.0-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350



--- Comment #12 from Fedora Update System  ---
python-treq-17.8.0-2.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1488611] Review Request: ghc-cryptonite - Cryptography Primitives sink

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1488611

Jens Petersen  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #7 from Jens Petersen  ---
https://koji.fedoraproject.org/koji/buildinfo?buildID=967177

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1489668] Review Request: slurm - HPC cluster management and job scheduling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1489668

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Robert-André Mauchin  ---
Everything seems good, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1236364] Review Request: ghc-comonad - Comonads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1236364



--- Comment #8 from Jens Petersen  ---
Thanks a lot

Sorry I was travelling and had completely missed this.

https://pagure.io/releng/fedora-scm-requests/issue/1146
https://pagure.io/releng/fedora-scm-requests/issue/1147

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491632] Review Request: ghc-hxt-charproperties - Character properties and classes for XML and Unicode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491632



--- Comment #3 from Jens Petersen  ---
Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/1145

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1454481] Review Request: grimmer-proggy-squaresz-fonts - Proggy Square with slashed zero programming font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1454481



--- Comment #5 from Bojan Smojver  ---
(In reply to Robert-André Mauchin from comment #4)
> Everything is good, package accepted.

Thank you for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1489668] Review Request: slurm - HPC cluster management and job scheduling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1489668



--- Comment #9 from Philip Kovacs  ---
Latest spec URL:
https://raw.githubusercontent.com/pkovacs/fedora-slurm/master/slurm.spec

Latest SRPM:
https://copr-be.cloud.fedoraproject.org/results/pkfed/slurm/fedora-rawhide-x86_64/00602696-slurm/slurm-17.02.7-1.fc28.src.rpm

Latest koji scratch for f28:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21870948

Changes:

 - installs for root
 - no slurm account creation
 - added slurm_setuser script

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376885] Review Request: libxml++30 - C++ wrapper for the libxml2 XML parser library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376885

Kalev Lember  changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 CC||klem...@redhat.com
 Resolution|NOTABUG |---
   Assignee|nob...@fedoraproject.org|klem...@redhat.com
Summary|Dummy package review ticket |Review Request: libxml++30
   |for multiply-versioned  |- C++ wrapper for the
   |packages|libxml2 XML parser library
  Flags||fedora-review+



--- Comment #9 from Kalev Lember  ---
libxml++30 is being requested without review under the blanket exception for
multi-versioned packages.

Existing package: libxml++
New package: libxml++30

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256089] Review Request: ghc-connection - Simple and easy network connections API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256089
Bug 1256089 depends on bug 1487898, which changed state.

Bug 1487898 Summary: Review Request: ghc-socks - Socks proxy (version 5) 
implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1487898

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487898] Review Request: ghc-socks - Socks proxy (version 5) implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487898

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-14 17:54:40



--- Comment #9 from Fedora Update System  ---
ghc-socks-0.5.5-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487894] Review Request: ghc-pem - Privacy Enhanced Mail (PEM) format reader and writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487894

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-14 17:54:26



--- Comment #9 from Fedora Update System  ---
ghc-pem-0.2.2-5.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1489306] Review Request: ghc-asn1-encoding - ASN1 data reader and writer in RAW, BER and DER forms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1489306
Bug 1489306 depends on bug 1487893, which changed state.

Bug 1487893 Summary: Review Request: ghc-hourglass - Simple performant time 
related library
https://bugzilla.redhat.com/show_bug.cgi?id=1487893

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487896] Review Request: ghc-sandi - Data encoding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487896

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-14 17:54:32



--- Comment #11 from Fedora Update System  ---
ghc-sandi-0.4.1-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487893] Review Request: ghc-hourglass - Simple performant time related library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487893

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-14 17:54:17



--- Comment #11 from Fedora Update System  ---
ghc-hourglass-0.2.10-5.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256076] Review Request: ghc-asn1-types - ASN.1 types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256076
Bug 1256076 depends on bug 1487893, which changed state.

Bug 1487893 Summary: Review Request: ghc-hourglass - Simple performant time 
related library
https://bugzilla.redhat.com/show_bug.cgi?id=1487893

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1488606] Review Request: ghc-asn1-types - ASN.1 types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1488606
Bug 1488606 depends on bug 1487893, which changed state.

Bug 1487893 Summary: Review Request: ghc-hourglass - Simple performant time 
related library
https://bugzilla.redhat.com/show_bug.cgi?id=1487893

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256083] Review Request: ghc-x509 - X509 reader and writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256083
Bug 1256083 depends on bug 1487894, which changed state.

Bug 1487894 Summary: Review Request: ghc-pem - Privacy Enhanced Mail (PEM) 
format reader and writer
https://bugzilla.redhat.com/show_bug.cgi?id=1487894

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484331] Review Request: python-incremental - Incremental is a small library that versions your Python projects.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484331

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-14 17:53:35



--- Comment #6 from Fedora Update System  ---
python-incremental-17.5.0-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-14 17:53:39



--- Comment #11 from Fedora Update System  ---
python-treq-17.8.0-2.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474301] Review Request: rubygem-aws-sigv4 - AWS Signature Version 4 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474301



--- Comment #4 from Fedora Update System  ---
rubygem-aws-sigv4-1.0.2-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6271f0d278

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474301] Review Request: rubygem-aws-sigv4 - AWS Signature Version 4 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474301

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474301] Review Request: rubygem-aws-sigv4 - AWS Signature Version 4 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474301



--- Comment #3 from Fedora Update System  ---
rubygem-aws-sigv4-1.0.2-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-922cdd7bce

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491281] Review Request: python-libsass - python bindings for libsass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491281



--- Comment #5 from Miro Hrončok  ---
See https://src.fedoraproject.org/rpms/libsass/pull-request/1

This will allow you to read the libsass version in two possible ways:

 1) parse /usr/include/sass/version.h

 2) write and compile a small program:

#include 
#include 

int main() {
  puts(libsass_version());
  return 0;
}


gcc -Wall version.c -lsass -o version && ./version

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456



--- Comment #5 from Fedora Update System  ---
hatch-0.11.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5489417b3a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426896] Review Request: ghc-file-embed - Use Template Haskell to embed file contents directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426896



--- Comment #13 from Elliott Sales de Andrade  ---
It's only required for the git-annex webapp, which I'd like to enable
eventually, but it's not a high priority at the moment since I'm focusing on
the core dependencies to be able to update git-annex

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491710] Review Request: GLee - GL Easy Extension library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491710

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,

 - Group: is not used in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - Not needed:

Requires(post):   /sbin/ldconfig
Requires(postun): /sbin/ldconfig

 - make %{?_smp_mflags} → %make_build

 - make install → %make_install

 - You forgot to bump Release: to 12:

Release:12%{?dist}

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "NTP", "Unknown or generated". 7 files have unknown license.
 Detailed output of licensecheck in /home/bob/packaging/review/GLee
 /review-GLee/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/include/GL
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see 

[Bug 1489668] Review Request: slurm - HPC cluster management and job scheduling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1489668



--- Comment #8 from Philip Kovacs  ---
After a discussion on an upstream forum, it's clear to me now that adding a
dedicated slurm user with a static uid is not the best approach for this
package.
We don't to make incorrect assumptions about how installations will manage
their users and slurm clusters are often managed with ldap-type tools. 
End-users of slurm must also have consistent uids on all nodes, so installers
will likely turn to ldap/nis, etc. anyway to create a working system.

I am going to alter the rpm spec to remove the slurm user creation, install for
root, and leave the user-management issues to the installers.  

I will also add a "bonus" script for Fedora that eases the ownership change of
a node to whatever user/group the installer wants after installation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456



--- Comment #4 from Fedora Update System  ---
hatch-0.11.0-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1fef6c00ec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491632] Review Request: ghc-hxt-charproperties - Character properties and classes for XML and Unicode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491632

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
All good, package accepted.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 11 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/ghc-hxt-charproperties/review-ghc-hxt-
 charproperties/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 471040 bytes in 31 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does 

[Bug 1491172] Review Request: golang-github-templexxx-xor - XOR code engine in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491172

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
golang-github-templexxx-xor-0.1.1-1.fc27 has been pushed to the Fedora 27
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8d7ad76075

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #26 from Alexander Ploumistos  ---
It's good to have an extra check, so I'll keep them enabled for local builds
and disable them before submitting to koji.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487884] Review Request: python-sortedcontainers - Python Sorted Container Types: SortedList, SortedDict, and SortedSet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487884

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
python-sortedcontainers-1.5.7-3.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9ed86f49e2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490068] Review Request: python-graphitesend - Easy python bindings to write to Carbon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490068

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
python-graphitesend-0.10.0-2.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0c2d85973e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426896] Review Request: ghc-file-embed - Use Template Haskell to embed file contents directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426896

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
ghc-file-embed-0.0.10-5.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-36682cafae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #25 from Antonio Trande  ---
Choice is your; they're not essential in my opinion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491492] Review Request: Coturn - TURN/STUN & ICE Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491492

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #1 from Robert-André Mauchin  ---
You don't seem to be a member of the Packager Group. Please read
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers on how
to becoming a member. You'll need a sponsor (FE-NEEDSPONSOR), introduce
yourself on the fedora-devel mailing list and do informal package reviews to
show a potential sponsor that you understand the Packaging Guidelines.


Regarding the package itself:

 - That's not how you package a systemd service file. Check
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd


%post
/bin/systemctl --system daemon-reload

%preun
if [ $1 = 0 ]; then
  /bin/systemctl stop turnserver.service
  /bin/systemctl disable turnserver.service 2> /dev/null
fi

%postun
/bin/systemctl --system daemon-reload

   should be:

%post
%systemd_user_post turnserver.service

%preun
%systemd_user_preun turnserver.service


  with a special BR:

%{?systemd_requires}
BuildRequires: systemd


 - That's not how to add a group and user:

%pre
%{_sbindir}/groupadd -r turnserver 2> /dev/null || :
%{_sbindir}/useradd -r -g turnserver -s /bin/false -c "TURN Server daemon" -d \
%{_datadir}/%{name} turnserver 2> /dev/null || :

  See: https://fedoraproject.org/wiki/Packaging:UsersAndGroups

  You need:

Requires(pre): shadow-utils

  Then:

%pre
getent group GROUPNAME >/dev/null || groupadd -r turnserver
getent passwd USERNAME >/dev/null || \
useradd -r -g turnserver -d %{_datadir}/%{name} -s /sbin/nologin \
-c "TURN Server daemon" turnserver
exit 0


 - %defattr(-,root,root) is not needed in %files

 - You can use * in %files instead of listead each file one by one.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491163] Review Request: nvidia-query-resource-opengl - Querying OpenGL resource usage of applications using the NVIDIA OpenGL driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491163

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Robert-André Mauchin  ---
Hello,


 - Use this Source0: instead:

Source0:%{url}/archive/v%{version}/%{name}-%{version}.tar.gz

 - You description line is too long, split it to stay below 80 characters per
line:

nvidia-query-resource-opengl-lib.x86_64: E: description-line-too-long C The
nvidia-query-resource-opengl-lib package contains library for
nvidia-query-resource-opengl.

 - Koji ain't happy, build fails on all arches:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21864018

The package won't be accepted until it builds successfully in Koji.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 1 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/nvidia-query-resource-opengl/review-nvidia-
 query-resource-opengl/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec 

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #24 from Alexander Ploumistos  ---
Created attachment 1326150
  --> https://bugzilla.redhat.com/attachment.cgi?id=1326150=edit
Test results

(In reply to Antonio Trande from comment #23)
> (In reply to Alexander Ploumistos from comment #22)
> > > You can also run the tests by running 'unittests' file inside 'test'
> > > directory:
> > > 
> > > xvfb-run -a ./unittests
> > 
> > Are these worth the Xorg dependencies? If you think they are, I will add
> > them too.
> 
> Just 'xorg-x11-server-Xvfb', i think.

The dependencies that get pulled in are ~2MB of downloads, plus another ~10MB
on disk (in other words, a drop in the ocean).

I added xorg-x11-server-Xvfb to the BuildRequires and "cd test && xvfb-run -a
./unittests" in %check.

I am attaching the test results from a local mock build, are they interesting
enough to keep testing enabled?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1454925] Review Request: rtags - A indexer for the c language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1454925

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Robert-André Mauchin  ---
Everything checks out, package is accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485458] Review Request: orangefs - parallel network file system ( formerly PVFS2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485458

Jonathan Dieter  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|jdie...@lesbg.com



--- Comment #8 from Jonathan Dieter  ---
(In reply to Martin Brandenburg from comment #0)
> This is my first package.  I represent the upstream developers.  I have
> fixed many problems since our last release 2.9.6 while making this
> package.  We intend to fix any further problems uncovered by this review
> and make a new release 2.9.7 if this package is accepted.  As such, my
> RPM currently builds our SVN trunk.

As Alexander pointed out, at least until 2.9.7 has been built you really need
to use proper pre-release versioning
(https://fedoraproject.org/wiki/Package_Versioning_Examples#Complex_versioning_examples,
scroll down to  pkg pre-release svn checkout)

This allows us to verify that the code submitted matches the upstream code.

> I have several questions which have arison from my reading of the wiki
> and fedora-review's output.
> 
> The OrangeFS server and client (which is all I have packaged) are
> intended to be LGPL v2.1 or later.  There are a few files which are
> under various open licenses:
> 
> *No copyright* LGPL (v2)
> 
> orangefs-2.9.7/src/apps/admin/pvfs2-config.in
> 
> BSD (2 clause)
> --
> orangefs-2.9.7/maint/config/ssl.m4
> 
> BSD (3 clause)
> --
> orangefs-2.9.7/src/client/usrint/fts.c
> orangefs-2.9.7/src/client/usrint/fts.h
> 
> ISC
> ---
> orangefs-2.9.7/src/common/lmdb/mdb.c
> 
> LGPL (v2.1)
> ---
> orangefs-2.9.7/src/common/dotconf/dotconf.c
> 
> NTP
> ---
> orangefs-2.9.7/maint/config/install-sh
> 
> zlib/libpng
> ---
> orangefs-2.9.7/src/common/misc/md5.c
> orangefs-2.9.7/src/common/misc/md5.h
> 
> Then there is code under other licenses in our source tree but which are
> not built by this package.  The kernel module is GPL v2.  Parts of our
> Hadoop integration are Apache v2.0.  Parts of the webpack (a set of
> Apache modules) is GPL v3.  None of this is built.

If it's not built, you don't need to list the licenses.  But I would wonder why
you're not building these modules (obviously excepting the kernel module), and
splitting them into subpackages so your users can easily get the parts of
OrangeFS that they want.

I noticed the following options not being set by configure:
PVFS2 configured to build karma gui   :  no
PVFS2 configured to build visualization tools :  no
PVFS2 configured to perform coverage analysis :  no
PVFS2 configured to use FUSE  :  no
PVFS2 configured for the 2.6/3 kernel module  :  no
PVFS2 configured for the 2.4.x kernel module  :  no
PVFS2 configured for using the ra-cache   :  no
PVFS2 configured for resetting file position  :  no
PVFS2 will use workaround for redhat 2.4 kernels  :  no
PVFS2 will use workaround for buggy NPTL  :  no
PVFS2 server capability cache enabled :  no
PVFS2 server credential cache enabled :  no
PVFS2 server certificate cache enabled:  no
PVFS2 configured with key-based security  :  no
PVFS2 configured with certificate-based security  :  no
PVFS2 configured with profiling enabled   :  no
PVFS2 user interface libraries will be built  :  no
PVFS2 symbolic libraries will be built:  no
PVFS2 user environment variables enabled  :  no
PVFS2 user interface library cache enabled:  no
PVFS2 client JNI enabled  :  no

Obviously some of those are irrelevant to Fedora, but what about the karma gui,
visualization tools, ra-cache, server caches, key-based security,
certificate-based security, etc.  Are these all obsolete or irrelevant to
Fedora, or would some of those be useful to your users?

> I am not sure how to handle this.  I assume that the BSD/MIT style
> licenses will not pose a problem, but I don't know where to document it.

Normally like this: GPLv3 and BSD and ...

> OrangeFS includes a copy of LMDB.  It does not link against any external
> package.  Does this need to be changed in upstream?

According to the Guidelines, if upstream *can't* be built against the system
version of LMDB, then you can bundle it, while following the guidelines on how
to do that
(https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries),
but, given that you are upstream, it would be *much* better if you could make
the changes required to build against the system library.  You really don't
want to be in a position where your bundled library has a vulnerability that's
been patched in the system library, but not in your bundled library.  I've been
there.  It sucks.

> OrangeFS requires some configuration 

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #23 from Antonio Trande  ---
(In reply to Alexander Ploumistos from comment #22)
> > You can also run the tests by running 'unittests' file inside 'test'
> > directory:
> > 
> > xvfb-run -a ./unittests
> 
> Are these worth the Xorg dependencies? If you think they are, I will add
> them too.

Just 'xorg-x11-server-Xvfb', i think.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442550] Review Request: nodejs-option-cache - Simple API for managing options in JavaScript applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442550

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends On||1442506, 1442514
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Latest version is 4.0.0, please bump your package.

It needs arr-flatten and has-value for tests:

%if 0%{?enable_tests}
BuildRequires:mocha
BuildRequires:npm(arr-flatten)
BuildRequires:npm(component-emitter)
BuildRequires:npm(get-value)
BuildRequires:npm(has-value)
BuildRequires:npm(kind-of)
BuildRequires:npm(set-value)
BuildRequires:npm(should)
BuildRequires:npm(to-object-path)
%endif)

arr-flatten needs to be updated to at least 1.0.3.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1442506
[Bug 1442506] Review Request: nodejs-has-value - Returns true if a value
exists, false if empty
https://bugzilla.redhat.com/show_bug.cgi?id=1442514
[Bug 1442514] Review Request: nodejs-collection-visit - Visit a method over
 items in object, or map visit over objects in array
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442506] Review Request: nodejs-has-value - Returns true if a value exists, false if empty

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442506

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1442550




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1442550
[Bug 1442550] Review Request: nodejs-option-cache - Simple API for managing
options in JavaScript applications
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442514] Review Request: nodejs-collection-visit - Visit a method over items in object, or map visit over objects in array

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442514

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1442550




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1442550
[Bug 1442550] Review Request: nodejs-option-cache - Simple API for managing
options in JavaScript applications
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1454925] Review Request: rtags - A indexer for the c language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1454925



--- Comment #5 from Robert-André Mauchin  ---
Huh sorry it's late, you're right. I'll finish the review ASAP.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491017] Review Request: needrestart -- checks which daemons need to be restarted after library upgrades

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491017



--- Comment #1 from Marc Dequènes (Duck)  ---
When you install needrestart, it's a commitment for *life*. Any attempt would
result in a crash. Joking :-).

So I fixed the YUM and DNF plugins to detect the situation and handle it
gracefully.


Btw, I'm still in need of a reviewer and a sponsor. o-negai itashimasu!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1454925] Review Request: rtags - A indexer for the c language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1454925



--- Comment #4 from Christian Kellner  ---
(In reply to Robert-André Mauchin from comment #3)
> You forgot to include:
> 
> %postun
> %systemd_postun_with_restart %{name}.service

Are you sure? I am using user unit files and this seems to be for non-user unit
files. I followed the "user unit" sections ion the guide you linked about.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491712] Review Request: atanua - Real Time Logic Simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491712

Antonio Trande  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com



--- Comment #1 from Antonio Trande  ---
Hi.

Is open source version still developed?
I don't see any commit since near 3 years.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #22 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #21)
> Before reviewing, please add the patch for fixing the bug #316:
> https://sourceforge.net/p/scidavis/scidavis-bugs/316/

I have backported the patch, but I didn't bump the version, so the links remain
the same.

Fresh build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21862381

> You can also run the tests by running 'unittests' file inside 'test'
> directory:
> 
> xvfb-run -a ./unittests

Are these worth the Xorg dependencies? If you think they are, I will add them
too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491172] Review Request: golang-github-templexxx-xor - XOR code engine in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491172



--- Comment #7 from Fedora Update System  ---
golang-github-templexxx-xor-0.1.1-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-332ee44470

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491172] Review Request: golang-github-templexxx-xor - XOR code engine in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491172



--- Comment #6 from Fedora Update System  ---
golang-github-templexxx-xor-0.1.1-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d387cf3689

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491172] Review Request: golang-github-templexxx-xor - XOR code engine in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491172

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491172] Review Request: golang-github-templexxx-xor - XOR code engine in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491172



--- Comment #5 from Fedora Update System  ---
golang-github-templexxx-xor-0.1.1-1.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8d7ad76075

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442514] Review Request: nodejs-collection-visit - Visit a method over items in object, or map visit over objects in array

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442514

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
All ok, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442512] Review Request: nodejs-map-visit - Map _visit_ over an array of objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442512

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
No issue, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442511] Review Request: nodejs-clone-deep - Recursively (deep) clone types, like Object, Array, RegExp, Date, primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442511

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Please update the package to version 1.0.0. before importing. Package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1454925] Review Request: rtags - A indexer for the c language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1454925



--- Comment #3 from Robert-André Mauchin  ---
You forgot to include:

%postun
%systemd_postun_with_restart %{name}.service

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442508] Review Request: nodejs-mixin-object - Mixin the own and inherited properties of other objects onto the first object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442508

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1442510




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1442510
[Bug 1442510] Review Request: nodejs-shallow-clone - Make a shallow clone
of an object, array or primitive
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491172] Review Request: golang-github-templexxx-xor - XOR code engine in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491172



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-templexxx-xor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442510] Review Request: nodejs-shallow-clone - Make a shallow clone of an object, array or primitive

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442510

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
 Depends On||1442508
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Please bump the package to version 1.0.0.

You'll probably need to bump the versions in package.json to handle the
dependencies correctly:

diff -up package/package.json.fix_metadata package/package.json
--- package/package.json.fix_metadata2017-09-14 17:32:47.905729241 +0200
+++ package/package.json2017-09-14 17:33:25.442646994 +0200
@@ -24,9 +24,9 @@
 "test": "mocha"
   },
   "dependencies": {
-"is-extendable": "^0.1.1",
+"is-extendable": "^1.0.0",
 "kind-of": "^5.0.0",
-"mixin-object": "^2.0.1"
+"mixin-object": "^3.0.0"
   },
   "devDependencies": {
 "gulp-format-md": "^1.0.0",


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1442508
[Bug 1442508] Review Request: nodejs-mixin-object - Mixin the own and
inherited properties of other objects onto the first object
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491172] Review Request: golang-github-templexxx-xor - XOR code engine in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491172



--- Comment #3 from Fabio Valentini  ---
Thanks very much!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491172] Review Request: golang-github-templexxx-xor - XOR code engine in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491172

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Neal Gompa  ---
Package was generated through gofed, simplifying the review considerably.

- Conforms to packaging guidelines (gofed generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442508] Review Request: nodejs-mixin-object - Mixin the own and inherited properties of other objects onto the first object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442508

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
 Depends On||1321486
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Please bump to version 3.0.0.

You'll also need to update npm(for-in) >= 1.0.2 (bug #1321486), which in turn
requires an update of npm(for-own), which in turn requires an update of
npm(object-dot-omit), which itself needs an update of npm(is-extendable), which
requires an update of npm(extend-shallow) to handle npm(is-extendable) >= 0.2.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1321486
[Bug 1321486] nodejs-for-in-0.1.8 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491172] Review Request: golang-github-templexxx-xor - XOR code engine in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491172

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491725] Review Request: tracker-miners - Tracker miners and metadata extractors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491725

Debarshi Ray  changed:

   What|Removed |Added

 CC||debars...@redhat.com
   Assignee|nob...@fedoraproject.org|debars...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476590] Review Request: deepin-daemon - Daemon handling the DDE session settings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476590



--- Comment #22 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-daemon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442509] Review Request: nodejs-object-visit - Call a specified method on each value in the given object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442509

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Please bump your package to release 1.0.1.

Everything else is ok, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491725] Review Request: tracker-miners - Tracker miners and metadata extractors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491725



--- Comment #1 from Kalev Lember  ---
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21860831
Test builds in copr: https://copr.fedorainfracloud.org/coprs/kalev/tracker/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426972



--- Comment #37 from Athos Ribeiro  ---
Hi Fabio,

HTML_SMARTYPANTS_QUOTES_NBSP is a const that was defined in a newer version of
russross/blackfriday. Jan updated this package 1 or 2 days ago, so the error
shall not be triggered as soon as the update reaches the mirrors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376885] Dummy package review ticket for multiply-versioned packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376885

Kalev Lember  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC|klem...@redhat.com  |
 Resolution|--- |NOTABUG
   Assignee|klem...@redhat.com  |nob...@fedoraproject.org
Summary|Review Request: mozjs52 -   |Dummy package review ticket
   |JavaScript interpreter and  |for multiply-versioned
   |libraries   |packages
  Flags|fedora-review+  |
Last Closed|2016-09-16 14:27:53 |2017-09-14 09:59:04



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376885] Review Request: mozjs52 - JavaScript interpreter and libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376885



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/mozjs52

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1482202

Tom Gundersen  changed:

   What|Removed |Added

  Flags|needinfo?(tgunders@redhat.c |
   |om) |



--- Comment #22 from Tom Gundersen  ---
Created attachment 1326029
  --> https://bugzilla.redhat.com/attachment.cgi?id=1326029=edit
proposed srpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376885] Review Request: mozjs52 - JavaScript interpreter and libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376885

Kalev Lember  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|klem...@redhat.com
Summary|Dummy package review ticket |Review Request: mozjs52 -
   |for multiply-versioned  |JavaScript interpreter and
   |packages|libraries
  Flags||fedora-review+



--- Comment #7 from Kalev Lember  ---
mozjs52 is being requested without review under the blanket exception for
multi-versioned packages.

Existing package: mozjs45
New package: mozjs52

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1482202



--- Comment #21 from Tom Gundersen  ---
Created attachment 1326028
  --> https://bugzilla.redhat.com/attachment.cgi?id=1326028=edit
proposed spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491725] New: Review Request: tracker-miners - Tracker miners and metadata extractors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491725

Bug ID: 1491725
   Summary: Review Request: tracker-miners - Tracker miners and
metadata extractors
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: klem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://kalev.fedorapeople.org/tracker-miners.spec
SRPM URL: https://kalev.fedorapeople.org/tracker-miners-2.0.0-1.fc27.src.rpm
Description:
Tracker is a powerful desktop-neutral first class object database,
tag/metadata database, search tool and indexer.

This package contains various miners and metadata extractors for tracker.

Fedora Account System Username: kalev

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442506] Review Request: nodejs-has-value - Returns true if a value exists, false if empty

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442506

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
 Depends On||1442416
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
Latest version is 1.0.0, please bump your package.

It depends on:

"get-value": "^2.0.6",
"has-values": "^1.0.0",
"isobject": "^3.0.0" 

Package is good otherwise and is accepted.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1442416
[Bug 1442416] Review Request: nodejs-get-value - Use property paths (a.b.c)
to get a nested value from an object
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442416] Review Request: nodejs-get-value - Use property paths (a.b.c ) to get a nested value from an object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442416

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1442506




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1442506
[Bug 1442506] Review Request: nodejs-has-value - Returns true if a value
exists, false if empty
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375383] Review Request: arachne-pnr - Place and route for FPGA compilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375383

mpr...@redhat.com  changed:

   What|Removed |Added

 CC||mpr...@redhat.com



--- Comment #5 from mpr...@redhat.com  ---
Please disregard my above comment. This was testing done in staging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375383] Review Request: arachne-pnr - Place and route for FPGA compilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375383



--- Comment #4 from mpr...@redhat.com  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.stg.fedoraproject.org/rpms/arachne-pnr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359412] Review Request: gawkextlib - library providing support functions for gawk extension libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359412



--- Comment #21 from Andrew Schorr  ---
I should also note that not all gawk extension libraries will require
gawkextlib. It is an optional support library. So we cannot rely upon solving
the problem that way. I guess you are saying that the new gawk could say that
it conflicts with a specific version of gawkextlib, but that gets messy if it
also needs to Conflict with 10 other gawk extension libraries. I think the
clean solution is to specify the API version. Am I missing something?

Regards,
Andy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487776] Review Request: wsjtx - Weak Signal communication by K1JT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487776



--- Comment #9 from Jaroslav Škarvada  ---
(In reply to Robert-André Mauchin from comment #8)
> You're right, sorry, I had not updtated the patch, only the SPEC. Everything
> is okay now, package accepted.

Great, thanks.

Btw, I really enjoyed the WSJT/WSPR operation all around the world with the
wsjtx package during my vacation (and I even blasted off my 1:1 balun with
overpower :).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491714] New: Review Request: linuxcnc - CNC Machine Controller

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491714

Bug ID: 1491714
   Summary: Review Request: linuxcnc - CNC Machine Controller
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: lkund...@v3.sk
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/lkundrak/cnc/linuxcnc.git/plain/linuxcnc.spec?id=02de4a21060ceb18f14db17000c9f15d6921ea0d
SRPM:
https://copr-be.cloud.fedoraproject.org/results/lkundrak/cnc/fedora-rawhide-x86_64/00575087-linuxcnc/linuxcnc-2.7.9-1.fc27.src.rpm

Description:

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d 
printers, laser cutters, plasma cutters, robot arms, hexapods, and more.

Note that with stock (non-realtime) kernel the package is unfit for controlling 
the hardware. It can be used for software simulation.

IT IS EXTREMELY UNWISE TO RELY ON SOFTWARE ALONE FOR SAFETY!

Any machinery capable of harming persons must have provisions for completely 
removing power from all motors, etc, before persons enter any danger area.

All machinery must be designed to comply with local and national safety codes, 
and the authors of this software can not, and do not, take any responsibility 
for such compliance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491712] New: Review Request: atanua - Real Time Logic Simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491712

Bug ID: 1491712
   Summary: Review Request: atanua - Real Time Logic Simulator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: lkund...@v3.sk
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Depends On: 1491710



Note this is a re-review of a package that used to be in Fedora but was retired
because GLee dependency was orphaned.

SPEC:
http://pkgs.fedoraproject.org/cgit/rpms/atanua.git/plain/atanua.spec?id=c559d938ce335422055cbe258b1e761b74105af7
SRPM:
https://kojipkgs.fedoraproject.org//packages/atanua/1.3.141220/6.fc26/src/atanua-1.3.141220-6.fc26.src.rpm
mock: https://koji.fedoraproject.org/koji/buildinfo?buildID=840701

Description:

Atanua is a real-time logic simulator, designed to help in learning of basic 
boolean logic and electronics. It uses OpenGL hardware-accelerated rendering 
and a custom UI designed for a fast workflow and a very low learning curve, 
letting the students concentrate on learning the subject instead of spending 
time learning the tool.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1491710
[Bug 1491710] Review Request: GLee - GL Easy Extension library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491710] Review Request: GLee - GL Easy Extension library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491710

Lubomir Rintel  changed:

   What|Removed |Added

 Blocks||1491712




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1491712
[Bug 1491712] Review Request: atanua - Real Time Logic Simulator
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487776] Review Request: wsjtx - Weak Signal communication by K1JT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487776

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Robert-André Mauchin  ---
You're right, sorry, I had not updtated the patch, only the SPEC. Everything is
okay now, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1454925] Review Request: rtags - A indexer for the c language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1454925



--- Comment #2 from Christian Kellner  ---
Thanks for the review.

Updated spec: https://github.com/gicmo/spec/blob/master/rtags/rtags.spec
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21859678

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359412] Review Request: gawkextlib - library providing support functions for gawk extension libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359412



--- Comment #20 from Andrew Schorr  ---
Hi Dee'Kej,

Maybe I am confused, but on my Fedora 26 laptop with gawkextlib and gawk-xml
installed, I see this:

[schorr@ajs-t530 ~]$ rpm --requires -q gawkextlib
/sbin/ldconfig
/sbin/ldconfig
gawk
libc.so.6()(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rtld(GNU_HASH)
[schorr@ajs-t530 ~]$ rpm --requires -q gawk-xml
/bin/sh
/bin/sh
/bin/sh
expat
gawk
info
info
libc.so.6()(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libexpat.so.1()(64bit)
libgawkextlib.so.0()(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rtld(GNU_HASH)

So yes, I can modify the gawkextlib rpm spec file to require a specific version
of gawk, but I don't think that's a great idea. The gawk version and the API
version are two different things, and I think the gawk rpm should provide the
API version that it actually supports. If gawkextlib requires gawk >= 4.2.0,
that won't help us if gawk 4.3 actually changes the API. Then we would have
breakage.

Also, as you can see, the gawk-xml rpm does not currently require any
particular version of gawkextlib, so we are not transitively saved on that
front. I think both gawkextlib and gawk-xml may need to require the correct
gawk API version.

Am I confused, or do we need to add a Provides to the gawk rpm specifying the
API version? And if so, how do we handle major/minor issues?

Thanks,
Andy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491710] New: Review Request: GLee - GL Easy Extension library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491710

Bug ID: 1491710
   Summary: Review Request: GLee - GL Easy Extension library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: lkund...@v3.sk
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



This is a re-review of a package that used to be in Fedora but got orphaned.
Sadly orphaning it caused atanua to be dropped too.

SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/lkundrak/varia/GLee.git/plain/GLee.spec?id=5be6dd187902a429c3aecb20e81ecd72a30403aa
SRPM:
https://copr-be.cloud.fedoraproject.org/results/lkundrak/varia/fedora-rawhide-x86_64/00602182-GLee/GLee-5.4.0-11.fc28.src.rpm
mock:
https://copr-be.cloud.fedoraproject.org/results/lkundrak/varia/fedora-rawhide-x86_64/00602182-GLee/

Description:

GLee (GL Easy Extension library) is a free cross-platform extension loading
library for OpenGL. It provides seamless support for OpenGL functions up
to version 3.0 and 399 extensions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368855] Review Request: radare2 - The reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368855

Lubomir Rintel  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



--- Comment #18 from Lubomir Rintel  ---
Also, please drop the last %changelog message. tito is arguably something
different from this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368855] Review Request: radare2 - The reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368855

Lubomir Rintel  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review+



--- Comment #17 from Lubomir Rintel  ---
This starts to look well. Sorry for the delays. Let's help get this sorted out.
Thanks for your work on this, having radare in the distro would be very nice.

There's a couple of issues remaining, but I think there's a clear way forward.
Feel free to ping me on freenode (I'm "lubko", on #nm and #fedora-devel) if
anything I suggested below is wrong or unclear, or you need help. That might
improve the chances of a speedier response. Also, feel free to reach me with a
direct e-mail if this bug needs attention, because the regular bugzilla traffic
seems to drown in the loads of bug-mail :(

Are you in touch with upstream? Are they by chance open to making life easier
for distro maintainers? I'm asking because they seem to be opinionated about
the "right" way to install the software, but that doesn't seem to be too well
aligned with what we'd need.

0.) Simple things first:

>>> URL:http://radare.org/
>>> #URL:   https://github.com/radare/radare2
>>Drop a useless comment please.
>No. I consider it useful when updating the package. While the browser friendly 
>is the radare.org, when updating the package it is more handy the link to 
>github.

That sounds reasonable. Please don't make it masquerade as a commented out URL
tag then though. Something like this would look less messy:

  # GitHub project: https://github.com/radare/radare2

>>> Source0:
>>> https://github.com/%{gituser}/%{gitname}/archive/%{commit}/%{name}-%{version}-%{shortcommit}.tar.gz
>>> Source1:
>>> https://github.com/%{gituser}/%{sdbgitname}/archive/%{sdbcommit}/%{sdbgitname}-%{version}-%{sdbshort}.tar.gz
>>This source is not used at all.
>True. Not used for the release packing. Source0 used when packing from git 
>directly (in case of patches preventing build on fedora).

This looks like a general issue here -- you seem to include a lot of cruft
that's only useful for snapshot builds:

> %global gituser radare
> %global gitname radare2
> %global commit  4b77cb2c36f8c99d09d14ee411e9c5c14b55c609
> %global shortcommit %(c=%{commit}; echo ${c:0:7})
...
> #Release:   1.git%{shortcommit}%{?dist}
...
> #Source0:   
> https://github.com/%{gituser}/%{gitname}/archive/%{commit}/%{name}-%{version}-%{shortcommit}.tar.gz

It arguably harms readability of the SPEC file. Snapshot builds are largely
irrelevant to Fedora and I'd prefer if you left that out.

Nevertheless, this seems not to be an exceptional practice, so I don't consider
this a review blocker if you insist on leaving it in place.

>>> %build
>>> %configure --with-sysmagic --with-syszip --with-syscapstone
>>You don't enable openssl. Why? (no idea what is it used for)
>Option is in the configure, but it is not working in radare for anything now.
>At least that was answer from Pancake last time I asked about that (see 
>sys/*.sh for the recommended build path - doesn't contain this option).

Fair enough. I'm wondering if you add a comment explaining how do you determine
the right configure arguments?

>Radare has custom build which doesn't have 2 links to library, but just one.
>For example:
>/lib64/libr_core.so -> /lib64/libr_core.so.1.6.0
>
>Radare2 is linked against the /lib64/libr_core.so:
>ldd `which radare2`
>linux-vdso.so.1 (0x7ffce9dfb000)
>   libdl.so.2 => /lib64/libdl.so.2 (0x7f349242f000)
>   libr_core.so => /lib64/libr_core.so (0x7f34920e1000)
>   libr_parse.so => /lib64/libr_parse.so (0x7f3491e8f000)
>...
>
> So it is needed in the binary package in order to run, not just for linking.

This is clearly a bug. Their SONAME is wrong:

> [lkundrak@belphegor SPECS]$ readelf -a /usr/lib64/libr_core.so.1.4.0 |grep 
> SONAME
>  0x000e (SONAME) Library soname: [libr_core.so]
> [lkundrak@belphegor SPECS]$

It should be libr_core.so.1.4.0, not libr_core.so. This is a review blocker
since, apart from the proper slit of the -devel package, the SONAME is used for
generating the package dependencies and ensuring packages built against
incompatible version won't run (and, presumably, crash encountering undefined
behavior) against the wrong library. (I can help with a fix if needed.)

1.) Now onto the difficult stuff, which arguably is the overabundance of
bundling:

1.1.) The License tag:

>> Changed to GPLv3+ due to its viral nature, although majority of the package 
>> is > meant to be licensed LGPL.
>
>I think you need to list all licenses:
>https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

Yes. The 

[Bug 1442504] Review Request: nodejs-has-values - Returns true if any values exist, false if empty

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442504

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Latest version is 1.0.0, please bump your package.
It build-requires:

BuildRequires:npm(is-number)

for tests.

And it requires npm(is-number) >= 3.0.0 (bug #1376258).

npm(is-number) requires npm(kind-of) < 4.0.0 and npm(has-values) requires
npm(kind-of) > 4.0.0, have fun with managing the dependencies! I've elected to
bump everyone to npm(kind-of) == 5.0.0 by patching package.json.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487776] Review Request: wsjtx - Weak Signal communication by K1JT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487776



--- Comment #7 from Jaroslav Škarvada  ---
(In reply to Robert-André Mauchin from comment #6)
> I've got build error because you didn't include the rigctl-wsjtx and
> rigctld-wsjtx binaries into %files.
> 
> Anyway, I've still got the error at install:
> Error: Transaction check error:
>   file /usr/lib/.build-id/01/2abbfd0bab84face20330c556905f12951a638
> conflicts between attempted installs of wsjtx-1.8.0-0.3.rc2.fc28.x86_64 and
> hamlib-3.1-9.fc28.x86_64
>   file /usr/lib/.build-id/72/eb0590dacbdfb833fe7f2cbf0345572b3639fb
> conflicts between attempted installs of wsjtx-1.8.0-0.3.rc2.fc28.x86_64 and
> hamlib-3.1-9.fc28.x86_64
> 
> I don't know how to fix it.

Hmm, is the compile-fix patch applied? You need up-to-date version of it from
the SRPM. It dropped creation of the rigctl* files, not only the packaging in
%files section which is in the spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/hatch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org