[Bug 1506413] Review Request: R-stringr - Simple, Consistent Wrappers for Common String Operations
https://bugzilla.redhat.com/show_bug.cgi?id=1506413 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506413] Review Request: R-stringr - Simple, Consistent Wrappers for Common String Operations
https://bugzilla.redhat.com/show_bug.cgi?id=1506413 --- Comment #4 from Fedora Update System --- R-stringr-1.2.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f5a3e9ee26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1485107] Review Request: R-pbdZMQ - Programming with Big Data -- Interface to ZeroMQ
https://bugzilla.redhat.com/show_bug.cgi?id=1485107 --- Comment #8 from Fedora Update System --- R-pbdZMQ-0.2.6-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0f68edc235 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1489340] Review Request: R-jsonlite - A Robust, High Performance JSON Parser and Generator for R
https://bugzilla.redhat.com/show_bug.cgi?id=1489340 --- Comment #9 from Fedora Update System --- R-jsonlite-1.5-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-583b13f08f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1484746] Review Request: R-Cairo - Use cairo as a high-quality graphics device
https://bugzilla.redhat.com/show_bug.cgi?id=1484746 --- Comment #6 from Fedora Update System --- R-Cairo-1.5.9-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c83743060d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507103] Review Request: kronosnet - VPNs on steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1507103
--- Comment #2 from Michele Baldessari ---
Thanks for starting this Madison :) Some quick drive-by comments:
So you might want to run 'fedora-review -n kronosnet' in the folder where you
have your .spec + .src.rpm kronosnet files. That will spit out a bunch of nits
that we need to fix. For example:
WARNING: Cannot download url:
https://github.com/fabbione/kronosnet/archive/kronosnet-0.8.tar.gz
WARNING: Package kronosnet-debuginfo-0.8-1.fc28 not built
Once we fix the URLs:
--- a/kronosnet.spec
+++ b/kronosnet.spec
@@ -72,8 +72,8 @@ Version: 0.8
Release:
1%{?numcomm:.%{numcomm}}%{?alphatag:.%{alphatag}}%{?dirty:.%{dirty}}%{?dist}
License: GPLv2+ and LGPLv2+
Group: System Environment/Base
-URL: https://github.com/fabbione/kronosnet/
-Source0:
https://github.com/fabbione/kronosnet/archive/%{name}-%{version}%{?numcomm:.%{numcomm}}%{?alphatag:-%{alphatag}}%{?dirty:-%{dirty}}.tar.gz
+URL: https://github.com/kronosnet/kronosnet/
+Source0:
https://github.com/kronosnet/kronosnet/archive/v%{version}%{?numcomm:.%{numcomm}}%{?alphatag:-%{alphatag}}%{?dirty:-%{dirty}}.tar.gz
We will need to call autogen.sh explicitely because ./configure is not shipped
in the tarball. Also, I am not sure those if defined macros are working as
expected, so we'll need to look into that as well.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506949] Review Request: psblas3 - Parallel Sparse Basic Linear Algebra Subroutines
https://bugzilla.redhat.com/show_bug.cgi?id=1506949 --- Comment #9 from Antonio Trande --- (In reply to Alexander Ploumistos from comment #8) > Oops, I forgot to set the review flag. > > > (In reply to Antonio Trande from comment #7) > > Just 'psblas3-serial' needs ldconfig scriptlets since it installs files in > > the public lib directory. > > All library-without-ldconfig-* errors are false positive for the MPI libs. > > OK, got it. > > > With regard to the ownership issue, I suppose if anyone wants to use pblas3, > they will also need the other packages that own those directories, so adding > these particular dependencies would be moot. Those dependencies are already satisfied. > > > As a user, I might start to worry about filesystem corruption if I found > zero-length images in one of my folders, but I guess as far as that and the > remaining rpmlint warnings go, they're not really an issue. I will erase them. > > > Package is APPROVED. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506331] Review Request: golang-github-tjfoc-gmsm - GM SM2/3/ 4 library based on Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1506331 --- Comment #7 from Fedora Update System --- golang-github-tjfoc-gmsm-1.0.1-1.20171023.git9d99fac.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-20c0d32691 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506405] Review Request: python-rstcheck - Checks syntax of reStructuredText and code blocks nested within it
https://bugzilla.redhat.com/show_bug.cgi?id=1506405 --- Comment #12 from Fedora Update System --- python-rstcheck-3.1-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-81ca3751bc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506413] Review Request: R-stringr - Simple, Consistent Wrappers for Common String Operations
https://bugzilla.redhat.com/show_bug.cgi?id=1506413 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- R-stringr-1.2.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f5a3e9ee26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506451] Review Request: rubygem-vault - A Ruby API client for interacting with a Vault server
https://bugzilla.redhat.com/show_bug.cgi?id=1506451 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- rubygem-hiera-vault-0.2.2-1.fc26, rubygem-vault-0.10.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5f1d7ab985 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506453] Review Request: rubygem-hiera-vault - Module for using vault as a hiera backend
https://bugzilla.redhat.com/show_bug.cgi?id=1506453 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- rubygem-hiera-vault-0.2.2-1.fc26, rubygem-vault-0.10.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5f1d7ab985 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506428] Review Request: gnome-shell-extension-historymanager-prefix-search - Use PageUp and PageDown to search for previous GNOME Shell commands
https://bugzilla.redhat.com/show_bug.cgi?id=1506428
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #5 from Robert-André Mauchin ---
Hello again Andrew,
- Please use a more meaningful name for your archive, with:
Source0:
https://github.com/sustmi/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz
Package is fine otherwise, it is accepted.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506429] Review Request: gnome-shell-extension-windowoverlay-icons - Show app icons on top of the windows thumbnails in Activities Overview
https://bugzilla.redhat.com/show_bug.cgi?id=1506429
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #3 from Robert-André Mauchin ---
- Please use a more meaningful name for your archive, with:
Source0:
https://github.com/sustmi/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz
Package accepted.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1502200] Review Request: ghc-hxt - A collection of tools for processing XML with Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=1502200 --- Comment #7 from Robert-André Mauchin --- > Well the right thing to do first is probably Provide: ghc-*-doc in all devel packages and then BR: ghc-*-doc in addition to ghc-*-devel deps. Then we can consider moving them to a separate package more easily. I don't understand why you are complicating this matter, why do you want to apply it to *all* ghc packages? It just applies to ones with large doc, no need to add a BR either, the user will choose to install the doc subpackage or not. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] New: Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235 Bug ID: 1507235 Summary: Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sanjay.an...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2.spec SRPM URL: https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2-0.5.5-20170705git05510bb.fc26.src.rpm Description: It is a Python library which provides a client interface for MPD Fedora Account System Username: ankursinha -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1404618 CC||m...@kushaldas.in --- Comment #1 from Ankur Sinha (FranciscoD) --- *** Bug 1368911 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1404618 [Bug 1404618] mpdris2: Switch to Python 3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1368911] Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1368911 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |DUPLICATE Last Closed||2017-10-28 11:41:34 --- Comment #8 from Ankur Sinha (FranciscoD) --- Hi Kushal, Parag: Since there hasn't been much activity on this recently, I'm going to close this review and submit a fresh one. Please feel free to comment on it if you'd like to co-maintain etc. Thanks for the work you've already done on this :) Frank, I'll update the spec in the new review ticket with your suggestions. Thanks for helping out :) Ankur *** This bug has been marked as a duplicate of bug 1507235 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)
https://bugzilla.redhat.com/show_bug.cgi?id=1506722
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Summary|Review Request: |Review Request:
|python-octaviaclient- |python-octaviaclient -
|Client for OpenStack|Client for OpenStack
|Octavia (Load Balancer as a |Octavia (Load Balancer as a
|Service)|Service)
--- Comment #1 from Robert-André Mauchin ---
Hello,
- Did you forget to put the Version and Release infos?
Version:XXX
Release:XXX
⇒
Version:1.1.0
Release:1%{?dist}
- There is no %changelog entry either!
* Thu Oct 26 2017 Carlos Goncalves - 1.1.0-1
- Initial RPM release
- No need to complicate things, use version instead of upstream_version and
remove upstream_version definition
%autosetup -n %{name}-%{version}
- You could use the %{py2_dist/%{py3_dist macros to handle your BR and R. See
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names
- BuildRequires: openstack-macros
There is no package openstack-macros in Fedora repositories. You'll have to
package it beforehand.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235 --- Comment #2 from Ankur Sinha (FranciscoD) --- A few updates made. New spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2.spec SRPM URL: https://ankursinha.fedorapeople.org/python-mpd2/python-mpd2-0.5.5-20171028git05510bb.fc27.src.rpm Succesful scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22761119 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506918] Review Request: adobe-source-han-serif-jp-fonts - Adobe OpenType Pan-CJK font family for Japanese
https://bugzilla.redhat.com/show_bug.cgi?id=1506918 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Hello, Package is good and accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506925] Review Request: adobe-source-han-sans-kr-fonts - Adobe OpenType Pan-CJK font family for Korean
https://bugzilla.redhat.com/show_bug.cgi?id=1506925 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235 --- Comment #3 from Ankur Sinha (FranciscoD) --- A few more fixes and an F27 scratch build here: https://koji.fedoraproject.org/koji/taskinfo?taskID=22761458 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235
--- Comment #4 from Robert-André Mauchin ---
Hello
- Group: is not used in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- Any particular reasons for using a development snapshot?
- Your Release tag must be prefixed:
Release:1.20171028git%{shortcommit0}%{?dist}
- Please include tests in %check: https://github.com/Mic92/python-mpd2#testing
- The Summary/Description is a bit awkward, just use:
Python library providing a client interface for MPD
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507235] Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD
https://bugzilla.redhat.com/show_bug.cgi?id=1507235
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #5 from Robert-André Mauchin ---
It turns out the test are, pardon my French, a PITA. To help you here what
you need:
BuildRequires: python2-mock
BuildRequires: python2-tox
BuildRequires: python2-twisted
And:
BuildRequires: python3-mock
BuildRequires: python3-tox
BuildRequires: python3-twisted
And the tests themselves:
%check
TOX_TESTENV_PASSENV=PYTHONPATH TOXENV=py27 %{__python2} setup.py test
%if %{with_python3}
TOX_TESTENV_PASSENV=PYTHONPATH TOXENV=py36 %{__python3} setup.py test
%endif
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506926] Review Request: adobe-source-han-serif-kr-fonts - Adobe OpenType Pan-CJK font family for Korean
https://bugzilla.redhat.com/show_bug.cgi?id=1506926 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package is good and accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1506916] Review Request: adobe-source-han-sans-jp-fonts - Adobe OpenType Pan-CJK font family for Japanese
https://bugzilla.redhat.com/show_bug.cgi?id=1506916 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #2 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
