[Bug 1534747] Review Request: libblocksruntime - Development files for LLVM's Blocks runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1534747 --- Comment #2 from Ron Olson --- I made the changes and thanks to the friendly folks in the IRC #fedora-devel channel was able to get rid of my global define and use the %setup macro instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534116] Review Request: python-rasterio - Fast and direct raster I/ O for use with Numpy and SciPy
https://bugzilla.redhat.com/show_bug.cgi?id=1534116 --- Comment #4 from Elliott Sales de Andrade --- Oops, forgot to update the srpm before building on koji; here's the correct build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24223632 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang
https://bugzilla.redhat.com/show_bug.cgi?id=1534188 Randy Barlow changed: What|Removed |Added Blocks||1494854 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1494854 [Bug 1494854] ejabberd needs to be able to use port 5281 for ejabberd_http -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534116] Review Request: python-rasterio - Fast and direct raster I/ O for use with Numpy and SciPy
https://bugzilla.redhat.com/show_bug.cgi?id=1534116 --- Comment #3 from Elliott Sales de Andrade --- koji build is now done: https://koji.fedoraproject.org/koji/taskinfo?taskID=24223398 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS
https://bugzilla.redhat.com/show_bug.cgi?id=1534799 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1534067 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1534067 [Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534787] Review Request: python-fastavro - Fast Avro for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1534787 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1534799 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1534799 [Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Ankur Sinha (FranciscoD) changed: What|Removed |Added Depends On||1534799 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1534799 [Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS
https://bugzilla.redhat.com/show_bug.cgi?id=1534799 Ankur Sinha (FranciscoD) changed: What|Removed |Added Depends On||1534787 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1534787 [Bug 1534787] Review Request: python-fastavro - Fast Avro for Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534799] New: Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS
https://bugzilla.redhat.com/show_bug.cgi?id=1534799 Bug ID: 1534799 Summary: Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sanjay.an...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ankursinha.fedorapeople.org/python-hdfs/python-hdfs.spec SRPM URL: https://ankursinha.fedorapeople.org/python-hdfs/python-hdfs-2.1.0-1.fc27.src.rpm Description: Python (2 and 3) bindings for the WebHDFS (and HttpFS) :API, supporting both secure and insecure clusters. Command line interface to transfer files and start an interactive client shell, with aliases for convenient namenode URL caching. Additional functionality through optional extensions: avro, to read and write Avro files directly from HDFS. dataframe, to load and save Pandas dataframes. kerberos, to support Kerberos authenticated clusters. Fedora Account System Username: ankursinha -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534787] Review Request: python-fastavro - Fast Avro for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1534787 Ankur Sinha (FranciscoD) changed: What|Removed |Added Whiteboard|NOTREADY| --- Comment #2 from Ankur Sinha (FranciscoD) --- Built, scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24222921 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534787] Review Request: python-fastavro - Fast Avro for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1534787 Ankur Sinha (FranciscoD) changed: What|Removed |Added Whiteboard||NOTREADY --- Comment #1 from Ankur Sinha (FranciscoD) --- This is still a WIP. Just setting up the whole dep tree for python-pybids. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534787] New: Review Request: python-fastavro - Fast Avro for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1534787 Bug ID: 1534787 Summary: Review Request: python-fastavro - Fast Avro for Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sanjay.an...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ankursinha.fedorapeople.org/python-fastavro/python-fastavro.spec SRPM URL: https://ankursinha.fedorapeople.org/python-fastavro/python-fastavro-0.17.1-1.fc27.src.rpm Description: Fast Avro for Python Fedora Account System Username: ankursinha -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534335] Review Request: gap-pkg-groupoids - Groupoids, group graphs, and groupoid graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1534335 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534335] Review Request: gap-pkg-groupoids - Groupoids, group graphs, and groupoid graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1534335 --- Comment #4 from Fedora Update System --- gap-pkg-groupoids-1.54-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-21449061ef -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534336] Review Request: gap-pkg-laguna - Lie AlGebras and UNits of group Algebras
https://bugzilla.redhat.com/show_bug.cgi?id=1534336 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534336] Review Request: gap-pkg-laguna - Lie AlGebras and UNits of group Algebras
https://bugzilla.redhat.com/show_bug.cgi?id=1534336 --- Comment #5 from Fedora Update System --- gap-pkg-laguna-3.8.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d3d5146a89 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534110] Review Request: python-affine - Matrices describing affine transformation of the plane
https://bugzilla.redhat.com/show_bug.cgi?id=1534110 --- Comment #6 from Fedora Update System --- python-affine-2.1.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-808430e513 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534110] Review Request: python-affine - Matrices describing affine transformation of the plane
https://bugzilla.redhat.com/show_bug.cgi?id=1534110 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534110] Review Request: python-affine - Matrices describing affine transformation of the plane
https://bugzilla.redhat.com/show_bug.cgi?id=1534110 --- Comment #5 from Fedora Update System --- python-affine-2.1.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-447232dd4a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534113] Review Request: python-snuggs - Snuggs are s-expressions for Numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1534113 --- Comment #6 from Fedora Update System --- python-snuggs-1.4.1-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d26f313e28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534113] Review Request: python-snuggs - Snuggs are s-expressions for Numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1534113 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534113] Review Request: python-snuggs - Snuggs are s-expressions for Numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1534113 --- Comment #5 from Fedora Update System --- python-snuggs-1.4.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c83fe9ca74 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534747] Review Request: libblocksruntime - Development files for LLVM's Blocks runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1534747 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? --- Comment #1 from Robert-André Mauchin --- - Group: is not needed in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - %defattr(-,root,root,-) in %files is not needed as it is the default. - Package fails to install: DEBUG util.py:479: Error: DEBUG util.py:479: Problem 1: conflicting requests DEBUG util.py:479:- nothing provides libBlocksRuntime.so.0()(64bit) needed by libblocksruntime-devel-5.0.1-1.fc28.x86_64 DEBUG util.py:479: Problem 2: package libblocksruntime-static-5.0.1-1.fc28.x86_64 requires libblocksruntime-devel = 5.0.1-1.fc28, but none of the providers can be installed DEBUG util.py:479:- conflicting requests DEBUG util.py:479:- nothing provides libBlocksRuntime.so.0()(64bit) needed by libblocksruntime-devel-5.0.1-1.fc28.x86_64 DEBUG util.py:617: Child return code was: 1 It seems libblocksruntime doesn't have the correct Provides but I don't know why. Oh now I get it, you installed the lib with non-executable bits. Lib should be executable, fix this with: install -m 755 %{builddir}/lib/libBlocksRuntime.so.0.%{shlibver} %{buildroot}/%{_libdir} - No need for %{builddir} here, just use: %license LICENSE.TXT Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (3 clause)", "Unknown or generated". 2497 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/libblocksruntime/review- libblocksruntime/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM
[Bug 1534268] Review Request: erlang-jose - JSON Object Signing and Encryption (JOSE) for Erlang and Elixir
https://bugzilla.redhat.com/show_bug.cgi?id=1534268 Randy Barlow changed: What|Removed |Added Fixed In Version||erlang-jose-1.8.4-1.fc28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534279] Review Request: catch1 - A modern, C++-native, header-only, framework for unit-tests, TDD and BDD
https://bugzilla.redhat.com/show_bug.cgi?id=1534279 Tom Hughes changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-15 17:39:21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534336] Review Request: gap-pkg-laguna - Lie AlGebras and UNits of group Algebras
https://bugzilla.redhat.com/show_bug.cgi?id=1534336 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-laguna. You may commit to the branch "f27" in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534335] Review Request: gap-pkg-groupoids - Groupoids, group graphs, and groupoid graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1534335 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-groupoids. You may commit to the branch "f27" in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #2 from Ankur Sinha (FranciscoD) --- Thanks for the review! The tests require python grabbit, so I'm afraid I'll have to package that up first. https://pypi.python.org/pypi/grabbit Doing that now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1532364] Review Request: rpcsvc-proto - RPC protocol definition
https://bugzilla.redhat.com/show_bug.cgi?id=1532364 --- Comment #32 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rpcsvc-proto -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534137] Review Request: fluxcapacitor - run programs without blocking on syscalls
https://bugzilla.redhat.com/show_bug.cgi?id=1534137 --- Comment #9 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fluxcapacitor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #16 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libkcapi. You may commit to the branch "f27" in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME
https://bugzilla.redhat.com/show_bug.cgi?id=1533719 --- Comment #7 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/twolame -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534279] Review Request: catch1 - A modern, C++-native, header-only, framework for unit-tests, TDD and BDD
https://bugzilla.redhat.com/show_bug.cgi?id=1534279 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/catch1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534110] Review Request: python-affine - Matrices describing affine transformation of the plane
https://bugzilla.redhat.com/show_bug.cgi?id=1534110 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-affine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534113] Review Request: python-snuggs - Snuggs are s-expressions for Numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1534113 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-snuggs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534268] Review Request: erlang-jose - JSON Object Signing and Encryption (JOSE) for Erlang and Elixir
https://bugzilla.redhat.com/show_bug.cgi?id=1534268 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/erlang-jose -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534226] Review Request: rust-maud_htmlescape - Internal support code used by Maud
https://bugzilla.redhat.com/show_bug.cgi?id=1534226 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534225] Review Request: rust-literalext - Helper crate for interpreting proc-macro `Literal` values
https://bugzilla.redhat.com/show_bug.cgi?id=1534225 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Latest version is 0.2.0, published 2 days ago, which includes your two PR (license and deps bump). - License ok - Builds in mock - No rpmlint errors Package is approved, but you need to: - bump to 0.2.0 - remove the deps patch - add %license LICENSE-APACHE LICENSE-MIT to %files before import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534223] Review Request: rust-url_serde - Serde support for URL types
https://bugzilla.redhat.com/show_bug.cgi?id=1534223 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534747] New: Review Request: libblocksruntime - Development files for LLVM's Blocks runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1534747 Bug ID: 1534747 Summary: Review Request: libblocksruntime - Development files for LLVM's Blocks runtime Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: tachokni...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://tachoknight.fedorapeople.org/libblocksruntime.spec SRPM URL: https://tachoknight.fedorapeople.org/libblocksruntime-5.0.1-1.fc27.src.rpm Description: LLVM's compiler-rt project contains a subproject called "Blocksruntime", which is a proposed extension to the C-family of languages to use Grand Central Dispatch (GCD). This package provides only the Blocksruntime part of compiler-rt for using Blocks (and is necessary as a dependency for building the Swift programming language). Fedora Account System Username: tachoknight -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534179] Review Request: rust-crates-io - Helpers for interacting with crates.io
https://bugzilla.redhat.com/show_bug.cgi?id=1534179 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534567] Review Request: golang-github-spacemonkeygo-openssl - OpenSSL bindings for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1534567 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? --- Comment #1 from Robert-André Mauchin --- - If you package a dev snapshot, you should provide the commit date in the Release: field. %global commit e863d83e403e8d694fa7d17f4af3cd176624ef12 %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global commitdate 20171219 Name: golang-%{provider}-%{project}-%{repo} Version:0 Release:0.1.%{commitdate}git%{shortcommit}%{?dist} And: * Mon Jan 15 2018 Marek Skalický - 0-0.1.20171219gite863d83 - You should remove: %files %license LICENSE %doc README.md AUTHORS as it only contains doc and license - Tests fail on all arches: https://koji.fedoraproject.org/koji/taskinfo?taskID=24218445 + go test -compiler gc -ldflags ' -extldflags '\''-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\''' github.com/spacemonkeygo/openssl # github.com/spacemonkeygo/openssl ../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/key_test.go:80: Fatal call has possible formatting directive %s ../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/key_test.go:294: Fatal call has possible formatting directive %s ../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha1_test.go:38: Fatal call has possible formatting directive %x ../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha1_test.go:76: Fatal call has possible formatting directive %x ../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha256_test.go:38: Fatal call has possible formatting directive %x ../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha256_test.go:76: Fatal call has possible formatting directive %x FAILgithub.com/spacemonkeygo/openssl [build failed] To solve this, I propose you a simple patch which replaces the problematic "Fatal" with "Fatalf": diff -up openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go.fix_go_warning openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go --- openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go.fix_go_warning 2018-01-06 00:06:25.0 +0100 +++ openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go2018-01-15 20:00:40.727292766 +0100 @@ -77,7 +77,7 @@ func TestMarshal(t *testing.T) { } tls_der := x509.MarshalPKCS1PrivateKey(tls_key) if !bytes.Equal(der, tls_der) { -t.Fatal("invalid private key der bytes: %s\n v.s. %s\n", +t.Fatalf("invalid private key der bytes: %s\n v.s. %s\n", hex.Dump(der), hex.Dump(tls_der)) } @@ -291,7 +291,7 @@ func TestMarshalEC(t *testing.T) { t.Fatal(err) } if !bytes.Equal(der, tls_der) { -t.Fatal("invalid private key der bytes: %s\n v.s. %s\n", +t.Fatalf("invalid private key der bytes: %s\n v.s. %s\n", hex.Dump(der), hex.Dump(tls_der)) } diff -up openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go.fix_go_warning openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go --- openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go.fix_go_warning 2018-01-06 00:06:25.0 +0100 +++ openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go2018-01-15 20:01:38.878103115 +0100 @@ -35,7 +35,7 @@ func TestSHA1(t *testing.T) { } if expected != got { -t.Fatal("exp:%x got:%x", expected, got) +t.Fatalf("exp:%x got:%x", expected, got) } } } @@ -73,7 +73,7 @@ func TestSHA1Writer(t *testing.T) { } if got != exp { -t.Fatal("exp:%x got:%x", exp, got) +t.Fatalf("exp:%x got:%x", exp, got) } } } diff -up openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go.fix_go_warning openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go --- openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go.fix_go_warning 2018-01-06 00:06:25.0 +0100 +++ openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go 2018-01-15 20:02:17.046978632 +0100 @@ -35,7 +35,7 @@ func TestSHA256(t *testing.T) { } if expected != got {
[Bug 1534446] Review Request: timeshift - System restore tool for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1534446 --- Comment #5 from Robert-André Mauchin --- >or > * (at your option) any later version Timeshift author choose the later version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534446] Review Request: timeshift - System restore tool for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1534446 --- Comment #4 from srakitnican --- (In reply to Robert-André Mauchin from comment #3) > (In reply to srakitnican from comment #2) > > > > I am confused about that one, I've added this file because it is the only > > text that describes the actual license used (GPLv2+). COPYING and LICENSE.md > > contains license text for GPLv3 and LGPLv3 respectively. I am not an expert, > > but I think there is quiet a difference between the two, and I would say > > there is at least some difference between GPLv2 and GPLv3. > > Nothing indicates that this app is GPLv2+. License: should be GPLv3+ or > LGPLv3+ and you should include both COPYING and LICENSE.md in %license. Well, *.vala files contains header that specifies that is GPLv2+. no? For example: /* * DeleteWindow.vala * * Copyright 2012-17 Tony George * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, * MA 02110-1301, USA. * * */ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534446] Review Request: timeshift - System restore tool for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1534446 --- Comment #3 from Robert-André Mauchin --- (In reply to srakitnican from comment #2) > > I am confused about that one, I've added this file because it is the only > text that describes the actual license used (GPLv2+). COPYING and LICENSE.md > contains license text for GPLv3 and LGPLv3 respectively. I am not an expert, > but I think there is quiet a difference between the two, and I would say > there is at least some difference between GPLv2 and GPLv3. Nothing indicates that this app is GPLv2+. License: should be GPLv3+ or LGPLv3+ and you should include both COPYING and LICENSE.md in %license. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534336] Review Request: gap-pkg-laguna - Lie AlGebras and UNits of group Algebras
https://bugzilla.redhat.com/show_bug.cgi?id=1534336 --- Comment #3 from Jerry James --- (In reply to Jerry James from comment #2) > Hmmm, that's odd. I thought I had done so. I've got this in my copy of the > spec file: > > # Fix end of line encodings > sed -i 's/\r//' doc/{manual.bib,theory.xml} > > Did I submit the wrong version of the spec file? Well, I will investigate > and make sure this is fixed before importing. Okay, I see the problem. Those files do not have newline-return pairs; they have returns only, like with old Apple files. So the correct invocation is this: sed -i 's/\r/\n/g' doc/{manual.bib,theory.xml} I will make that correction. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534336] Review Request: gap-pkg-laguna - Lie AlGebras and UNits of group Algebras
https://bugzilla.redhat.com/show_bug.cgi?id=1534336 --- Comment #2 from Jerry James --- Thank you again. (In reply to Robert-André Mauchin from comment #1) > gap-pkg-laguna.noarch: E: incorrect-fsf-address > /usr/share/licenses/gap-pkg-laguna/COPYING > > You should notify upstream about this, they are using an obsolete FSF > address. Okay, I will do so. That wrong address is pervasive throughout the GAP universe, I'm afraid. I'll do what I can to get it corrected. > gap-pkg-laguna.noarch: W: wrong-file-end-of-line-encoding > /usr/lib/gap/pkg/laguna/doc/manual.bib > gap-pkg-laguna.noarch: W: wrong-file-end-of-line-encoding > /usr/lib/gap/pkg/laguna/doc/theory.xml > > You should fix the line encodings for these files. Hmmm, that's odd. I thought I had done so. I've got this in my copy of the spec file: # Fix end of line encodings sed -i 's/\r//' doc/{manual.bib,theory.xml} Did I submit the wrong version of the spec file? Well, I will investigate and make sure this is fixed before importing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534335] Review Request: gap-pkg-groupoids - Groupoids, group graphs, and groupoid graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1534335 --- Comment #2 from Jerry James --- Thank you for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529593] Review Request: adapta-gtk-theme - An adaptive Gtk+ theme based on Material Design Guidelines
https://bugzilla.redhat.com/show_bug.cgi?id=1529593 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #16 from Fedora Update System --- adapta-gtk-theme-3.93.0.43-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-28781a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529705] Review Request: adapta-backgrounds - A wallpaper collection for adapta-project
https://bugzilla.redhat.com/show_bug.cgi?id=1529705 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #13 from Fedora Update System --- adapta-backgrounds-0.5.2.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-95fb606a17 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534446] Review Request: timeshift - System restore tool for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1534446 --- Comment #2 from srakitnican --- Thank you for your review! (In reply to Robert-André Mauchin from comment #1) > - I don't think it's necessary to add Debian packaging files, remove > %license debian/copyright I am confused about that one, I've added this file because it is the only text that describes the actual license used (GPLv2+). COPYING and LICENSE.md contains license text for GPLv3 and LGPLv3 respectively. I am not an expert, but I think there is quiet a difference between the two, and I would say there is at least some difference between GPLv2 and GPLv3. > - Add a "Requires: hicolor-icon-theme" to own the icons directories > > - Add a "Requires: polkit" to own /usr/share/polkit-1 and > /usr/share/polkit-1/actions > > - Add a "Requires: cronie" to own /etc/cron.d > > - Add "%config(noreplace)" for this file unless you don't expect it to be > modified by the user: > > timeshift.x86_64: W: conffile-without-noreplace-flag > /etc/default/timeshift.json I don't think this file is supposed to be modified by user since the program creates and maintaines /etc/timeshift.json. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1532364] Review Request: rpcsvc-proto - RPC protocol definition
https://bugzilla.redhat.com/show_bug.cgi?id=1532364 --- Comment #31 from Steve Dickson --- Waiting for approval: fedrepo-req: https://pagure.io/releng/fedora-scm-requests/issue/4175 fedrepo-req-branch: https://pagure.io/releng/fedora-scm-requests/issue/4176 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530771] Review Request: python-lupa - Lupa integrates the runtimes of Lua or LuaJIT2 into CPython
https://bugzilla.redhat.com/show_bug.cgi?id=1530771 --- Comment #11 from Fedora Update System --- python-lupa-1.6-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c7e6fc7faa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508126] Review Request: micro - A modern and intuitive terminal-based text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1508126 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- micro-1.3.4-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8aee8cc4b9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534545] Review Request: ykushcmd - YKUSH Boards Control Application
https://bugzilla.redhat.com/show_bug.cgi?id=1534545 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- - Latest version is 1.1.0, thus if your snapshot is after it, that version should be in the Version: field. - Remove the spurious executable bits from these files in %prep: ykushcmd/commandParser.cpp ykushcmd/commandParser.h ykushcmd/yk_usb_device.cpp ykushcmd/yk_usb_device.h ykushcmd/ykushcmd.cpp ykushcmd/ykushcmd.cpp You should probably notify upstream too (or provide a PR). Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "MIT/X11 (BSD like)", "GPL (v3)", "Unknown or generated". 24 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/ykushcmd/review- ykushcmd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description
[Bug 1530771] Review Request: python-lupa - Lupa integrates the runtimes of Lua or LuaJIT2 into CPython
https://bugzilla.redhat.com/show_bug.cgi?id=1530771 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- python-lupa-1.6-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5949e8d511 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1532023] Review Request: ddupdate - A Dynamic DNS Updater
https://bugzilla.redhat.com/show_bug.cgi?id=1532023 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1532023] Review Request: ddupdate - A Dynamic DNS Updater
https://bugzilla.redhat.com/show_bug.cgi?id=1532023 --- Comment #8 from Fedora Update System --- ddupdate-0.2.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c9b7a8419a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534446] Review Request: timeshift - System restore tool for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1534446 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- - I don't think it's necessary to add Debian packaging files, remove %license debian/copyright - Add a "Requires: hicolor-icon-theme" to own the icons directories - Add a "Requires: polkit" to own /usr/share/polkit-1 and /usr/share/polkit-1/actions - Add a "Requires: cronie" to own /etc/cron.d - Add "%config(noreplace)" for this file unless you don't expect it to be modified by the user: timeshift.x86_64: W: conffile-without-noreplace-flag /etc/default/timeshift.json Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 138 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/timeshift/review- timeshift/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/polkit-1, /etc/cron.d, /usr/share/polkit-1/actions [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/default/timeshift.json [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Fi
[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions
https://bugzilla.redhat.com/show_bug.cgi?id=1481630 Hans de Goede changed: What|Removed |Added Blocks||1534595 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1534595 [Bug 1534595] VirtualBox Guest Integration -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392838] Review Request: python-mlpy - Python module for Machine Learning
https://bugzilla.redhat.com/show_bug.cgi?id=1392838 --- Comment #19 from Fedora Update System --- python-mlpy-3.5.0-6.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392838] Review Request: python-mlpy - Python module for Machine Learning
https://bugzilla.redhat.com/show_bug.cgi?id=1392838 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-01-15 11:49:17 --- Comment #18 from Fedora Update System --- python-mlpy-3.5.0-6.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534336] Review Request: gap-pkg-laguna - Lie AlGebras and UNits of group Algebras
https://bugzilla.redhat.com/show_bug.cgi?id=1534336 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - Just a couble of trivial rpmlint errors: gap-pkg-laguna.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-laguna/COPYING You should notify upstream about this, they are using an obsolete FSF address. gap-pkg-laguna.noarch: W: wrong-file-end-of-line-encoding /usr/lib/gap/pkg/laguna/doc/manual.bib gap-pkg-laguna.noarch: W: wrong-file-end-of-line-encoding /usr/lib/gap/pkg/laguna/doc/theory.xml You should fix the line encodings for these files. Package otherwise approved. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 52 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gap-pkg-laguna /review-gap-pkg-laguna/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architect
[Bug 1534137] Review Request: fluxcapacitor - run programs without blocking on syscalls
https://bugzilla.redhat.com/show_bug.cgi?id=1534137 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- Seems good, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534137] Review Request: fluxcapacitor - run programs without blocking on syscalls
https://bugzilla.redhat.com/show_bug.cgi?id=1534137 --- Comment #7 from Iwicki Artur --- Okay. Changes done. spec: https://svgames.pl/fedora/fluxcapacitor-0-4.spec srpm: https://svgames.pl/fedora/fluxcapacitor-0-4.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=24215576 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534335] Review Request: gap-pkg-groupoids - Groupoids, group graphs, and groupoid graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1534335 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package approved. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 94 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gap-pkg-groupoids/review-gap-pkg- groupoids/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a wo
[Bug 1534137] Review Request: fluxcapacitor - run programs without blocking on syscalls
https://bugzilla.redhat.com/show_bug.cgi?id=1534137 --- Comment #6 from Robert-André Mauchin --- Yes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432997] Review Request: multimc - Minecraft launcher with ability to manage multiple instances
https://bugzilla.redhat.com/show_bug.cgi?id=1432997 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #3 from Robert-André Mauchin --- - Group: is not needed. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - This package incjudes many other licenses than Apache 2.0. Please include them all and explain the licenses breakdown in a comment: BSD (3 clause) -- MultiMC5-0.6.0/application/ColumnResizer.cpp MultiMC5-0.6.0/application/ColumnResizer.h MultiMC5-0.6.0/libraries/LocalPeer/include/LocalPeer.h MultiMC5-0.6.0/libraries/LocalPeer/src/LocalPeer.cpp MultiMC5-0.6.0/libraries/LocalPeer/src/LockedFile.cpp MultiMC5-0.6.0/libraries/LocalPeer/src/LockedFile.h MultiMC5-0.6.0/libraries/LocalPeer/src/LockedFile_unix.cpp MultiMC5-0.6.0/libraries/LocalPeer/src/LockedFile_win.cpp MultiMC5-0.6.0/libraries/ganalytics/LICENSE.txt GPL (v2) MultiMC5-0.6.0/libraries/pack200/include/unpack200.h MultiMC5-0.6.0/libraries/pack200/src/bands.cpp MultiMC5-0.6.0/libraries/pack200/src/bands.h MultiMC5-0.6.0/libraries/pack200/src/bytes.cpp MultiMC5-0.6.0/libraries/pack200/src/bytes.h MultiMC5-0.6.0/libraries/pack200/src/coding.cpp MultiMC5-0.6.0/libraries/pack200/src/coding.h MultiMC5-0.6.0/libraries/pack200/src/constants.h MultiMC5-0.6.0/libraries/pack200/src/defines.h MultiMC5-0.6.0/libraries/pack200/src/unpack.cpp MultiMC5-0.6.0/libraries/pack200/src/unpack.h MultiMC5-0.6.0/libraries/pack200/src/unpack200.cpp MultiMC5-0.6.0/libraries/pack200/src/utils.cpp MultiMC5-0.6.0/libraries/pack200/src/utils.h MultiMC5-0.6.0/libraries/pack200/src/zip.cpp MultiMC5-0.6.0/libraries/pack200/src/zip.h GPL (v3) MultiMC5-0.6.0/libraries/libnbtplusplus/COPYING.LESSER ISC --- MultiMC5-0.6.0/libraries/hoedown/LICENSE LGPL (v2 or later) -- MultiMC5-0.6.0/libraries/rainbow/include/rainbow.h MultiMC5-0.6.0/libraries/rainbow/src/rainbow.cpp LGPL (v2.1 or later) MultiMC5-0.6.0/libraries/iconfix/xdgicon.cpp MultiMC5-0.6.0/libraries/iconfix/xdgicon.h MultiMC5-0.6.0/libraries/quazip/quazip/JlCompress.cpp MultiMC5-0.6.0/libraries/quazip/quazip/JlCompress.h MultiMC5-0.6.0/libraries/quazip/quazip/quaadler32.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quaadler32.h MultiMC5-0.6.0/libraries/quazip/quazip/quachecksum32.h MultiMC5-0.6.0/libraries/quazip/quazip/quacrc32.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quacrc32.h MultiMC5-0.6.0/libraries/quazip/quazip/quagzipfile.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quagzipfile.h MultiMC5-0.6.0/libraries/quazip/quazip/quaziodevice.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quaziodevice.h MultiMC5-0.6.0/libraries/quazip/quazip/quazip.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quazip.h MultiMC5-0.6.0/libraries/quazip/quazip/quazip_global.h MultiMC5-0.6.0/libraries/quazip/quazip/quazipdir.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quazipdir.h MultiMC5-0.6.0/libraries/quazip/quazip/quazipfile.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quazipfile.h MultiMC5-0.6.0/libraries/quazip/quazip/quazipfileinfo.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quazipfileinfo.h MultiMC5-0.6.0/libraries/quazip/quazip/quazipnewinfo.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quazipnewinfo.h MultiMC5-0.6.0/libraries/quazip/qztest/qztest.cpp MultiMC5-0.6.0/libraries/quazip/qztest/qztest.h MultiMC5-0.6.0/libraries/quazip/qztest/testjlcompress.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testjlcompress.h MultiMC5-0.6.0/libraries/quazip/qztest/testquachecksum32.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquachecksum32.h MultiMC5-0.6.0/libraries/quazip/qztest/testquagzipfile.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquagzipfile.h MultiMC5-0.6.0/libraries/quazip/qztest/testquaziodevice.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquaziodevice.h MultiMC5-0.6.0/libraries/quazip/qztest/testquazip.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquazip.h MultiMC5-0.6.0/libraries/quazip/qztest/testquazipdir.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquazipdir.h MultiMC5-0.6.0/libraries/quazip/qztest/testquazipfile.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquazipfile.h LGPL (v2.1 or v3) - MultiMC5-0.6.0/libraries/iconfix/internal/qiconloader.cpp MultiMC5-0.6.0/libraries/iconfix/internal/qiconloader_p.h LGPL (v2.1) --- MultiMC5-0.6.0/libraries/quazip/COPYING zlib/libpng --- MultiMC5-0.6.0/libraries/quazip/quazip/unzip.h MultiMC5-0.6.0/libraries/quazip/quazip/zip.h - Also read COPYING.md, there are other licenses, such as SIL Open Font License for fonts. - [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable Add a "Requires: hicolor-icon-theme" to ow
[Bug 1501992] Review Request: opam - Source-based package manager for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1501992 --- Comment #17 from Richard W.M. Jones --- I have now created ocaml-re & ocaml-dose3 branches for f26 & f27 and done all 4 builds: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c56b4822b3 https://bodhi.fedoraproject.org/updates/FEDORA-2018-043eee3c5e https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ad6a42912 https://bodhi.fedoraproject.org/updates/FEDORA-2018-88034d4413 If you want to build against these packages before they go into stable, you will need to request build overrides via https://bodhi.fedoraproject.org/overrides/new -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534137] Review Request: fluxcapacitor - run programs without blocking on syscalls
https://bugzilla.redhat.com/show_bug.cgi?id=1534137 --- Comment #5 from Iwicki Artur --- Should it go in %{_libdir}/%{name}, then? I think that's most other packages do with their modules and such. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions
https://bugzilla.redhat.com/show_bug.cgi?id=1481630 --- Comment #49 from Sergio Monteiro Basto --- (In reply to Hans de Goede from comment #38) > Here is a new version of the pkg, updated to 5.2.2: > > SPEC: https://fedorapeople.org/~jwrdegoede/VirtualBox-guest-additions.spec > SRPM: > https://fedorapeople.org/~jwrdegoede/VirtualBox-guest-additions-5.2.2-1.fc27. > src.rpm > > Unfortunately the kernel patches are still awaiting review by the misc > subsys maintainers upstream. I did manage to get a review done by another > kernel contributor (and addressed his comments), so hopefully something will > happen wrt this soon. Hello why keep VirtualBox-5.0.18-xserver_guest.patch [1] ?, I think the new kmk option VBOX_USE_SYSTEM_GL_HEADERS=1 do exactly the same or at least is for that propose . Thanks [1] Patch1: VirtualBox-5.0.18-xserver_guest.patch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534137] Review Request: fluxcapacitor - run programs without blocking on syscalls
https://bugzilla.redhat.com/show_bug.cgi?id=1534137 --- Comment #4 from Robert-André Mauchin --- (In reply to Iwicki Artur from comment #3) > I put the .so in /usr/share, since it's something that, by design, should > only be loaded by the fluxcapacitor binary and not really linked to anything > else (there's no "libfluxcapacitor-devel" package that other programs can > link against). Still, if it's preferred to put it in %{_libdir} either way, > I can change the spec. It is, there shouldn't be any platform dependent code in /usr/share -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534137] Review Request: fluxcapacitor - run programs without blocking on syscalls
https://bugzilla.redhat.com/show_bug.cgi?id=1534137 --- Comment #3 from Iwicki Artur --- I put the .so in /usr/share, since it's something that, by design, should only be loaded by the fluxcapacitor binary and not really linked to anything else (there's no "libfluxcapacitor-devel" package that other programs can link against). Still, if it's preferred to put it in %{_libdir} either way, I can change the spec. Thanks for the test case patch! I wanted to do something like this, but my Python knowledge is rather limited. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534567] New: Review Request: golang-github-spacemonkeygo-openssl - OpenSSL bindings for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1534567 Bug ID: 1534567 Summary: Review Request: golang-github-spacemonkeygo-openssl - OpenSSL bindings for Go Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mskal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://mskalick.fedorapeople.org/golang-github-spacemonkeygo-openssl/golang-github-spacemonkeygo-openssl.spec SRPM URL: https://mskalick.fedorapeople.org/golang-github-spacemonkeygo-openssl/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc27.src.rpm Description: OpenSSL bindings for Go Fedora Account System Username: mskalick -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534137] Review Request: fluxcapacitor - run programs without blocking on syscalls
https://bugzilla.redhat.com/show_bug.cgi?id=1534137 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #2 from Robert-André Mauchin --- - Quite curious to install the *.so int /usr/share: fluxcapacitor.x86_64: E: arch-dependent-file-in-usr-share /usr/share/fluxcapacitor/fluxcapacitor_preload.so fluxcapacitor.x86_64: E: arch-dependent-file-in-usr-share /usr/share/fluxcapacitor/fluxcapacitor_test.so Shouldn't you instead install them in %{_libdir}/%{name} as they are arch dependant? /usr/share is reserved for architecture-independent data. I modified your patch this way: fluxcapacitor-0b6a11b729d1f5461b49fd0b0b4e2142175aa6ff/src/misc.c --- fluxcapacitor-0b6a11b729d1f5461b49fd0b0b4e2142175aa6ff/src/misc.c.fix_libdir 2018-01-14 17:43:01.0 +0100 +++ fluxcapacitor-0b6a11b729d1f5461b49fd0b0b4e2142175aa6ff/src/misc.c 2018-01-15 14:20:23.825681581 +0100 @@ -118,6 +118,12 @@ void ensure_libpath(const char *argv_0) if (!options.libpath) { char *path = NULL; do { +path = "/usr/lib/fluxcapacitor"; +if (dl_checkpath(path, TEST_LIBNAME)) break; + +path = "/usr/lib64/fluxcapacitor"; +if (dl_checkpath(path, TEST_LIBNAME)) break; + // 1. Relative to executable, useful for development char tmp[PATH_MAX]; if (!realpath(argv_0, tmp)) { - Patches shouldn't be applied within %ifarch, they need to be applied to all arches identically. If you need to restrict it to a certain arch, do it within the patch itself. fluxcapacitor.src: W: %ifarch-applied-patch Patch1: %{name}-disable-wraparound-test.patch I modified your patch this way: diff -up fluxcapacitor-0b6a11b729d1f5461b49fd0b0b4e2142175aa6ff/tests/tests_basic.py.fix_wraparound fluxcapacitor-0b6a11b729d1f5461b49fd0b0b4e2142175aa6ff/tests/tests_basic.py --- fluxcapacitor-0b6a11b729d1f5461b49fd0b0b4e2142175aa6ff/tests/tests_basic.py.fix_wraparound 2018-01-14 17:43:01.0 +0100 +++ fluxcapacitor-0b6a11b729d1f5461b49fd0b0b4e2142175aa6ff/tests/tests_basic.py 2018-01-15 14:26:00.260915110 +0100 @@ -205,12 +205,12 @@ class SingleProcess(tests.TestCase): after_fork_fds = len(stdout.split('\n')) assert normal_fds == after_fork_fds - -@at_most(seconds=4) -def test_2546_wraparound(self): -stdout = self.system("bash -c 'for i in `seq 1 55`; do sleep 31536; done; date +%Y'", - capture_stdout=True) -assert int(stdout) > 2500 +if os.uname()[4] == "x86_64": +@at_most(seconds=4) +def test_2546_wraparound(self): +stdout = self.system("bash -c 'for i in `seq 1 55`; do sleep 31536; done; date +%Y'", +capture_stdout=True) +assert int(stdout) > 2500 if __name__ == '__main__': Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 28 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/fluxcapacitor/review- fluxcapacitor/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: fluxcapacitor (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [!]: Package obeys FH
[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1532541 Petr Viktorin changed: What|Removed |Added Blocks||1534542 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1534542 [Bug 1534542] Django 2.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534545] New: Review Request: ykushcmd - YKUSH Boards Control Application
https://bugzilla.redhat.com/show_bug.cgi?id=1534545 Bug ID: 1534545 Summary: Review Request: ykushcmd - YKUSH Boards Control Application Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: lkund...@v3.sk QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org SPEC: http://v3.sk/~lkundrak/SPECS/ykushcmd.spec SRPM: http://v3.sk/~lkundrak/SRPMS/ykushcmd-1.0.0-1.20180108git01aff0b.fc27.src.rpm mock: https://koji.fedoraproject.org/koji/taskinfo?taskID=24214703 Description: Control application for Yepkit YKUSH Switchable USB Hub boards. FAS Account: lkundrak -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management
https://bugzilla.redhat.com/show_bug.cgi?id=1518262 --- Comment #8 from Tom Hughes --- Also this is installing in /usr/lib/node_modules/nodejs-yarn which should be /usr/lib/node_modules/yarn. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management
https://bugzilla.redhat.com/show_bug.cgi?id=1518262 Tom Hughes changed: What|Removed |Added CC||t...@compton.nu --- Comment #7 from Tom Hughes --- That doesn't alter the fact that it is bundling those modules, but not even as proper bundled modules in a node_modules subdirectory - it seems everything has been smashed together in one file. I'm not sure what the answer is but I don't see how using the prebuilt tar ball here meets the requirement to build from source, even ignoring the bundling issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1532541 Matthias Runge changed: What|Removed |Added CC||mru...@redhat.com Assignee|nob...@fedoraproject.org|mru...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533731] Review Request: ocaml-sedlex - Unicode-friendly lexer generator
https://bugzilla.redhat.com/show_bug.cgi?id=1533731 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin --- All ok, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #15 from Robert-André Mauchin --- Seems ok for me, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534446] New: Review Request: timeshift - System restore tool for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1534446 Bug ID: 1534446 Summary: Review Request: timeshift - System restore tool for Linux Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: samuel.rakitni...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://copr-be.cloud.fedoraproject.org/results/srakitnican/default/fedora-rawhide-x86_64/00701388-timeshift/timeshift.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/srakitnican/default/fedora-rawhide-x86_64/00701388-timeshift/timeshift-18.1-1.fc28.src.rpm Description: TimeShift for Linux is a application that provides functionality similar to the System Restore feature in Windows and the Time Machine tool in Mac OS. TimeShift protects your system by taking incremental snapshots of the file system at regular intervals. These snapshots can be restored later to bring your system to the exact state it was in at the time when the snapshot was taken. Snapshots are taken using rsync and hard-links. Common files are shared between snapshots which saves disk space. Each snapshot is a full system backup that can be browsed with a file manager. Fedora Account System Username: srakitnican Builds can be found in Copr: https://copr.fedorainfracloud.org/coprs/srakitnican/default/builds/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org