[Bug 1548797] Review Request: python-cartopy - Cartographic Python library with Matplotlib visualisations
https://bugzilla.redhat.com/show_bug.cgi?id=1548797 --- Comment #5 from Elliott Sales de Andrade --- Yes, that was due to updated FreeType. I've added a patch to get that working as well as a few others to work on non-x86 arches. Spec URL: https://qulogic.fedorapeople.org/python-cartopy.spec SRPM URL: https://qulogic.fedorapeople.org/python-cartopy-0.16.0-2.fc27.src.rpm koji build on rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=25356103 koji build on f26 (which requires more patching due to old matplotlib): https://koji.fedoraproject.org/koji/taskinfo?taskID=25356166 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549686] Review Request: f28-backgrounds - Fedora 28 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1549686 --- Comment #5 from Luya Tshimbalanga --- Thanks Robert-André and Rex. Here is the updated spec and srpm based on feedback: SPECS: https://copr-be.cloud.fedoraproject.org/results/luya/f28-backgrounds/fedora-rawhide-x86_64/00722063-f28-backgrounds/f28-backgrounds.spec SRPMS: https://copr-be.cloud.fedoraproject.org/results/luya/f28-backgrounds/fedora-rawhide-x86_64/00722063-f28-backgrounds/f28-backgrounds-28.1.0-1.fc28.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications
https://bugzilla.redhat.com/show_bug.cgi?id=1507103
Fabio Massimo Di Nitto changed:
What|Removed |Added
Flags||needinfo?(jpokorny@redhat.c
||om)
--- Comment #56 from Fabio Massimo Di Nitto ---
(In reply to Jan Pokorný from comment #55)
> Re macros in %changelog:
>
> Common way of escaping that convey what was meant down the road
> (e.g. to rpm -q --changelog query) is to use doubled '%', i.e.,
> %{_isa} -> %%{_isa}, not to drop the per cent character.
>
>
> Some concerns that remain:
>
> A. [Comment 28] 4.: no reason to mangle with debuginfo generation
> - one can always use command-line switches to achieve the same:
> http://lists.rpm.org/pipermail/rpm-list/2013-April/001416.html
> (definitely not a mainstream need, even less in Fedora context)
>
> B. [Comment 11]: I'd still suggest using
>
> %{configure} \
> > %{?with_sctp:--enable-libknet-sctp} \
> > %{!?with_sctp:--disable-libknet-sctp} \
> > [...]
>
> Reason is also practical, e.g. the whole "configure" statement
> barely fits a single laptop screen for me currently, because
> the notation of choice is excessively line-hungry.
This is only a matter of personal preference. It doesn´t interfere in any way
with the review.
>
>
> Also, please:
>
> C. Refrain from initial spaces/indentation in %description-s.
rationale?
>
> D. Check whether there are some tests that could be run as part of
>the build under %check scriptlet (to be added if that's the case).
this is a good point, but FYI upstream already has an extensive CI/CD including
different versions of Fedora.
My only concern is that the testsuite does play with the network (loopback
interface) and should be very safe, but in the unlucky event of bugs, we should
probably avoid DoS´ing the fedora builders by generating unwanted traffic. I
think that Digimer choice to avoid running the test suite is more of a safe
precaution.
>
> E. Because libknet1-devel requires (indirectly) libknet1, it may
>drop the %license files, as these will be present thanks to
>libknet1 installed in parallel, hence satisfying:
>
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#Subpackage_Licensing
Is this a blocker for the review or a wishlist level? what are the consequences
of not doing it?
>
>
> Rather for future consideration:
> - if the documentation for the API functions will keep growing,
> it might be desirable to split those manpages to a separate
> subpackage:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
> ("Or if there's a lot of documentation...")
Hardly, the API is pretty stable at this point.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548173] Review Request: yubikey-piv-manager - Tool for configuring your PIV-enabled YubiKey
https://bugzilla.redhat.com/show_bug.cgi?id=1548173 --- Comment #2 from Orion Poplawski --- Thanks for the review * Tue Feb 27 2018 Orion Poplawski - 1.4.2-2 - Fix license field - Install man page and documentation - Add requires yubico-piv-tool Spec URL: https://www.cora.nwra.com/~orion/fedora/yubikey-piv-manager.spec SRPM URL: https://www.cora.nwra.com/~orion/fedora/yubikey-piv-manager-1.4.2-2.fc29.src.rpm Filed https://github.com/Yubico/yubikey-piv-manager/issues/35 upstream about license differences. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android
https://bugzilla.redhat.com/show_bug.cgi?id=1501522 --- Comment #67 from Yaakov Selkowitz --- Both Legal and FESCo have approved this; can we please move this forward? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549003] Review Request: python-libevdev - Python bindings to the libevdev evdev device wrapper library
https://bugzilla.redhat.com/show_bug.cgi?id=1549003 Peter Hutterer changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-02-27 18:29:20 --- Comment #5 from Peter Hutterer --- Fixed, thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549003] Review Request: python-libevdev - Python bindings to the libevdev evdev device wrapper library
https://bugzilla.redhat.com/show_bug.cgi?id=1549003 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-libevdev -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549317] Review Request: rust-humantime - Parser and formatter for std::time::{Duration, SystemTime}
https://bugzilla.redhat.com/show_bug.cgi?id=1549317 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-humantime -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #17 from Ron Olson ---
Hey Richard, thanks for the feedback. My responses to each of your points:
1: Will do
2: Will do
3: Will investigate and will do if possible
4: Swift builds and requires its own version of LLDB for its REPL, which would
cause a conflict with an existing install of LLDB that already exists as a
package (and does not include Swift support). The symlinking is to get Swift to
work in an environment where the user has already installed LLDB.
5: %{_libdir} wants to install to /usr/lib64, but Swift expects to find
everything in /usr/lib; no amount of coaxing from ldconfig made it work. I'll
take another crack at putting everything in lib64; it's probably another
hardcoded path that needs to be changed through a patch.
6: Probably sheer ignorance on how to package properly :)
7: Will do
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1536780 --- Comment #16 from Richard Shaw --- I forgot to post the links to the guidelines... https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots and https://fedoraproject.org/wiki/Packaging:Versioning#Prerelease_versions It would be helpful to show an example of both used together but oh well... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Richard Shaw changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||hobbes1...@gmail.com
Assignee|nob...@fedoraproject.org|hobbes1...@gmail.com
--- Comment #15 from Richard Shaw ---
I don't have a review submitted at the moment but I can fix that this week.
Here's a quick spec review while I have a mock build going...
1. Need to tweak your release tag. Since this is a prerelease you have the 0
correct but per the guidelines[1] it should be 0.X where in this case X would
be 1, so the full package name would be something like:
swift-lang-4.1-0.1.20180214git5a1a34b.fc28
Also, since there shouldn't be a problem using more generic global variables,
you could remove the "swift..." from each one to aid readability.
2. This is a suggestion not a requirement but it helps readability to put two
lines between major sections, i.e. %prep, %build, %install, etc.
3. This doesn't use the typical build system but verbose output is preferred.
If you can pass settings directly to CMAKE somehow just set the environment
variable "VERBOSE=1". Perhaps just setting prior to the build command will
work:
export VERBOSE=1
4. What is the purpose of all the symbolic linking? Most of it you're creating
links into the builddir but I don't see it used anywhere...
A couple you've got hardcoded paths in /usr/lib which you shouldn't do during
package building.
5. Since you've pretty much excluded all arches except x86_64 it would be
/usr/lib64, but either way you shouldn't be creating files in the build system
and it should error out.
6. Is there a reason you're installing into %{_builddir} instead of
%{buildroot}?
7. Like your original post you should post new links after every review,
include what you've changed in the %changelog, and bump the release so the next
one would be 0.2.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549317] Review Request: rust-humantime - Parser and formatter for std::time::{Duration, SystemTime}
https://bugzilla.redhat.com/show_bug.cgi?id=1549317 Josh Stone changed: What|Removed |Added Blocks||1548838 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1548838 [Bug 1548838] rust-env_logger-0.5.4 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547611] Review Request: python-certbot-dns-cloudxns - CloudXNS DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547611 --- Comment #13 from Fedora Update System --- python-certbot-dns-cloudxns-0.21.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547617] Review Request: python-certbot-dns-cloudflare - Cloudflare DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547617 --- Comment #13 from Fedora Update System --- python-certbot-dns-cloudflare-0.21.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546851] Review Request: python-certbot-dns-dnsmadeeasy - DNS Made Easy DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1546851 --- Comment #13 from Fedora Update System --- python-certbot-dns-dnsmadeeasy-0.21.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547135] Review Request: python-certbot-dns-nsone - NS1 DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547135 --- Comment #12 from Fedora Update System --- python-certbot-dns-nsone-0.21.1-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547601] Review Request: python-certbot-dns-luadns - LuaDNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547601 --- Comment #13 from Fedora Update System --- python-certbot-dns-luadns-0.21.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520570] Review Request: perl-Scalar-String - String aspects of scalars
https://bugzilla.redhat.com/show_bug.cgi?id=1520570 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-12-26 11:30:03 |2018-02-27 15:39:24 --- Comment #14 from Fedora Update System --- perl-Scalar-String-0.003-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520585] Review Request: perl-Test-SQL-Data - Helps running SQL tests : database preparing and result matching
https://bugzilla.redhat.com/show_bug.cgi?id=1520585 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-12-19 14:47:36 |2018-02-27 15:39:37 --- Comment #16 from Fedora Update System --- perl-Test-SQL-Data-0.0.6-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520568] Review Request: perl-Crypt-MySQL - Emulate MySQL PASSWORD() function
https://bugzilla.redhat.com/show_bug.cgi?id=1520568 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-12-19 14:47:32 |2018-02-27 15:39:15 --- Comment #13 from Fedora Update System --- perl-Crypt-MySQL-0.04-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547122] Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547122 --- Comment #13 from Fedora Update System --- python-certbot-dns-dnsimple-0.21.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520572] Review Request: perl-Authen-DecHpwd - DEC VMS password hashing
https://bugzilla.redhat.com/show_bug.cgi?id=1520572 Bug 1520572 depends on bug 1520571, which changed state. Bug 1520571 Summary: Review Request: perl-Data-Integer - Details of the native integer data type https://bugzilla.redhat.com/show_bug.cgi?id=1520571 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520581] Review Request: perl-Authen-Passphrase - Hashed passwords/ passphrases as objects
https://bugzilla.redhat.com/show_bug.cgi?id=1520581 Bug 1520581 depends on bug 1520568, which changed state. Bug 1520568 Summary: Review Request: perl-Crypt-MySQL - Emulate MySQL PASSWORD() function https://bugzilla.redhat.com/show_bug.cgi?id=1520568 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520581] Review Request: perl-Authen-Passphrase - Hashed passwords/ passphrases as objects
https://bugzilla.redhat.com/show_bug.cgi?id=1520581 Bug 1520581 depends on bug 1520572, which changed state. Bug 1520572 Summary: Review Request: perl-Authen-DecHpwd - DEC VMS password hashing https://bugzilla.redhat.com/show_bug.cgi?id=1520572 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520569] Review Request: perl-Crypt-UnixCrypt_XS - Perl xs interface for a portable traditional crypt function
https://bugzilla.redhat.com/show_bug.cgi?id=1520569 Bug 1520569 depends on bug 1522917, which changed state. Bug 1522917 Summary: Review Request: perl-Algorithm-Loops - Perl module for looping constructs https://bugzilla.redhat.com/show_bug.cgi?id=1522917 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520581] Review Request: perl-Authen-Passphrase - Hashed passwords/ passphrases as objects
https://bugzilla.redhat.com/show_bug.cgi?id=1520581 Bug 1520581 depends on bug 1520569, which changed state. Bug 1520569 Summary: Review Request: perl-Crypt-UnixCrypt_XS - Perl xs interface for a portable traditional crypt function https://bugzilla.redhat.com/show_bug.cgi?id=1520569 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520572] Review Request: perl-Authen-DecHpwd - DEC VMS password hashing
https://bugzilla.redhat.com/show_bug.cgi?id=1520572 Bug 1520572 depends on bug 1520570, which changed state. Bug 1520570 Summary: Review Request: perl-Scalar-String - String aspects of scalars https://bugzilla.redhat.com/show_bug.cgi?id=1520570 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs
https://bugzilla.redhat.com/show_bug.cgi?id=1522917 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-12-26 11:30:35 |2018-02-27 15:39:11 --- Comment #15 from Fedora Update System --- perl-Algorithm-Loops-1.032-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520569] Review Request: perl-Crypt-UnixCrypt_XS - Perl xs interface for a portable traditional crypt function
https://bugzilla.redhat.com/show_bug.cgi?id=1520569 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-12-26 11:30:58 |2018-02-27 15:39:19 --- Comment #16 from Fedora Update System --- perl-Crypt-UnixCrypt_XS-0.11-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type
https://bugzilla.redhat.com/show_bug.cgi?id=1520571 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2018-01-02 11:23:02 |2018-02-27 15:39:29 --- Comment #17 from Fedora Update System --- perl-Data-Integer-0.006-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520572] Review Request: perl-Authen-DecHpwd - DEC VMS password hashing
https://bugzilla.redhat.com/show_bug.cgi?id=1520572 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2018-01-02 11:25:26 |2018-02-27 15:39:33 --- Comment #17 from Fedora Update System --- perl-Authen-DecHpwd-2.007-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1473314] Review Request: rclone - rsync for cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1473314 Bug 1473314 depends on bug 1476281, which changed state. Bug 1476281 Summary: Please update the package to a more recent version https://bugzilla.redhat.com/show_bug.cgi?id=1476281 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1387131] Review Request: golang-github-pkg-sftp - SFTP support for the go.crypto/ssh package
https://bugzilla.redhat.com/show_bug.cgi?id=1387131 --- Comment #15 from Fedora Update System --- golang-github-pkg-sftp-0-0.1.git8197a2e.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1433617] Review Request: proselint - A linter for English prose
https://bugzilla.redhat.com/show_bug.cgi?id=1433617 --- Comment #15 from Peter Oliver --- Thanks for your help, everyone. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1433617] Review Request: proselint - A linter for English prose
https://bugzilla.redhat.com/show_bug.cgi?id=1433617 --- Comment #14 from Fedora Update System --- proselint-0.8.0-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4cb899f95e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1433617] Review Request: proselint - A linter for English prose
https://bugzilla.redhat.com/show_bug.cgi?id=1433617 --- Comment #13 from Fedora Update System --- proselint-0.8.0-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2014ebe2e6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1433617] Review Request: proselint - A linter for English prose
https://bugzilla.redhat.com/show_bug.cgi?id=1433617 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548671] rockboxUtility does not compile on ppc64le
https://bugzilla.redhat.com/show_bug.cgi?id=1548671 --- Comment #5 from Jason Tibbitts --- Why is this filed as a package review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549686] Review Request: f28-backgrounds - Fedora 28 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1549686
--- Comment #4 from Rex Dieter ---
first off: (more thorough items coming soon)
1. file ownership referenced in comment #1
%files extras-base
...
%{_datadir}/backgrounds/%{bgname}/extras/*.jpg
%{_datadir}/backgrounds/%{bgname}/extras/*.png
%{_datadir}/backgrounds/%{bgname}/extras/%{bgname}-extras.xml
could be replaced by simple:
%{_datadir}/backgrounds/%{bgname}/extras/
or add
%dir %{_datadir}/backgrounds/%{bgname}/extras/
/usr/share/wallpapers is already owned by kde-filesystem
/usr/share/backgrounds/f28 is owned by -base subpkg
For /usr/share/xfce4/backdrops, I think those should be added here (I don't see
anything else better to provide ownership)
%files xfce
%dir %{_datadir}/xfce4/
%dir %{_datadir}/xfce4/backdrops/
Same for /usr/share/gnome-background-properties, add to
%files gnome
...
%dir %{_datadir}/gnome-background-properties/
Same for -mate,
%files mate
...
%dir %{_datadir}/mate-background-properties/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549686] Review Request: f28-backgrounds - Fedora 28 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1549686 --- Comment #3 from Rex Dieter --- fyi, embedded metadata.desktop for the kde wallpaper still says Twenty-Seven/f27, but I can help fix that post review so that it's more future proof (ie, will minimize or remove any need for manual editing for future releases). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549686] Review Request: f28-backgrounds - Fedora 28 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1549686 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@gmail.com Assignee|nob...@fedoraproject.org|rdie...@gmail.com Flags||fedora-review? --- Comment #2 from Rex Dieter --- I can review today -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1532696] Review Request: gcin - An input method focused on Chinese users
https://bugzilla.redhat.com/show_bug.cgi?id=1532696 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- gcin-2.8.5-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-16c106298c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management
https://bugzilla.redhat.com/show_bug.cgi?id=1518262
Peter Oliver changed:
What|Removed |Added
CC||ma...@mavit.org.uk
--- Comment #15 from Peter Oliver ---
(In reply to Zuzana Svetlikova from comment #4)
> > Also, I don't know of any conflicts that exist for "%{_bindir}/yarnpkg".
>
> I wanted some consistency, so I renamed both yarn and yarnpkg.
yarnpkg is an alias to yarn. Presumably, the reason that this alias exists is
to provide a consistent name in places where yarn is already taken by something
else, as is the case here.
Consequently, I think it would be best to leave yarnpkg at /usr/bin/yarnpkg.
If this were so, I can't see any reason why anyone would want to use
Fedora-specific /usr/bin/nodejs-yarn in preference to works-everywhere
/usr/bin/yarnpkg, so it would probably be reasonable to leave
/usr/bin/nodejs-yarn unpackaged.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549686] Review Request: f28-backgrounds - Fedora 28 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1549686
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- https://fedoraproject.org/wiki/F28_Artwork is empty
- [!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/backgrounds/f28/extras, /usr/share/wallpapers,
/usr/share/backgrounds/f28, /usr/share/gnome-background-properties,
/usr/share/mate-background-properties, /usr/share/xfce4,
/usr/share/xfce4/backdrops
Check out whether you own these directories correctly. I think one that should
be owned in the extras subpackage is:
%dir %{_datadir}/backgrounds/%{bgname}/extras
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547601] Review Request: python-certbot-dns-luadns - LuaDNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547601 --- Comment #12 from Fedora Update System --- python-certbot-dns-luadns-0.21.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547617] Review Request: python-certbot-dns-cloudflare - Cloudflare DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547617 --- Comment #12 from Fedora Update System --- python-certbot-dns-cloudflare-0.21.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547611] Review Request: python-certbot-dns-cloudxns - CloudXNS DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547611 --- Comment #12 from Fedora Update System --- python-certbot-dns-cloudxns-0.21.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547135] Review Request: python-certbot-dns-nsone - NS1 DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547135 --- Comment #11 from Fedora Update System --- python-certbot-dns-nsone-0.21.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546851] Review Request: python-certbot-dns-dnsmadeeasy - DNS Made Easy DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1546851 --- Comment #12 from Fedora Update System --- python-certbot-dns-dnsmadeeasy-0.21.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547122] Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547122 --- Comment #12 from Fedora Update System --- python-certbot-dns-dnsimple-0.21.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545621] Review Request: golang-github-rasky-go-xdr - Implements the XDR standard as specified in RFC 4506 in pure Google Go (Golang)
https://bugzilla.redhat.com/show_bug.cgi?id=1545621 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:20:09 --- Comment #7 from Fedora Update System --- golang-github-rasky-go-xdr-0-0.1.20150914git1a41d1a.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540553] Review Request: glusterd2- new management daemon for GlusterFS
https://bugzilla.redhat.com/show_bug.cgi?id=1540553 Bug 1540553 depends on bug 1545614, which changed state. Bug 1545614 Summary: Review Request: golang-github-justinas-alice - Painless middleware chaining for Go https://bugzilla.redhat.com/show_bug.cgi?id=1545614 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545614] Review Request: golang-github-justinas-alice - Painless middleware chaining for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1545614 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:20:04 --- Comment #7 from Fedora Update System --- golang-github-justinas-alice-0-0.1.20171023git03f45bd.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1544716 --- Comment #10 from Fedora Update System --- golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540553] Review Request: glusterd2- new management daemon for GlusterFS
https://bugzilla.redhat.com/show_bug.cgi?id=1540553 Bug 1540553 depends on bug 1545621, which changed state. Bug 1545621 Summary: Review Request: golang-github-rasky-go-xdr - Implements the XDR standard as specified in RFC 4506 in pure Google Go (Golang) https://bugzilla.redhat.com/show_bug.cgi?id=1545621 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541566] Review Request: whipper - Python CD-DA ripper
https://bugzilla.redhat.com/show_bug.cgi?id=1541566 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:20:32 --- Comment #19 from Fedora Update System --- whipper-0.6.0-6.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540553] Review Request: glusterd2- new management daemon for GlusterFS
https://bugzilla.redhat.com/show_bug.cgi?id=1540553 Bug 1540553 depends on bug 1545610, which changed state. Bug 1545610 Summary: Review Request: golang-github-cespare-xxhash - A Go implementation of the 64-bit xxHash algorithm (XXH64) https://bugzilla.redhat.com/show_bug.cgi?id=1545610 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545610] Review Request: golang-github-cespare-xxhash - A Go implementation of the 64-bit xxHash algorithm (XXH64)
https://bugzilla.redhat.com/show_bug.cgi?id=1545610 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:19:59 --- Comment #5 from Fedora Update System --- golang-github-cespare-xxhash-1.0.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540553] Review Request: glusterd2- new management daemon for GlusterFS
https://bugzilla.redhat.com/show_bug.cgi?id=1540553 Bug 1540553 depends on bug 1545611, which changed state. Bug 1545611 Summary: Review Request: golang-github-spaolacci-murmur3 - Native MurmurHash3 Go implementation https://bugzilla.redhat.com/show_bug.cgi?id=1545611 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545610] Review Request: golang-github-cespare-xxhash - A Go implementation of the 64-bit xxHash algorithm (XXH64)
https://bugzilla.redhat.com/show_bug.cgi?id=1545610 Bug 1545610 depends on bug 1545611, which changed state. Bug 1545611 Summary: Review Request: golang-github-spaolacci-murmur3 - Native MurmurHash3 Go implementation https://bugzilla.redhat.com/show_bug.cgi?id=1545611 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545611] Review Request: golang-github-spaolacci-murmur3 - Native MurmurHash3 Go implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1545611 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:19:52 --- Comment #8 from Fedora Update System --- golang-github-spaolacci-murmur3-1.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545816] Review Request: perl-CryptX - Cryptographic toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1545816 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:19:49 --- Comment #11 from Fedora Update System --- perl-CryptX-0.053-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545941] Review Request: vim-jellybeans - A colorful, dark color scheme for Vim
https://bugzilla.redhat.com/show_bug.cgi?id=1545941 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:19:47 --- Comment #9 from Fedora Update System --- vim-jellybeans-1.6-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs
https://bugzilla.redhat.com/show_bug.cgi?id=1428202 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:19:25 --- Comment #32 from Fedora Update System --- sirikali-1.3.3-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1543813 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:19:09 --- Comment #13 from Fedora Update System --- pwkickstart-1.0.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1492475] Review Request: aftertheflood-sparks-fonts - a font to display charts within text
https://bugzilla.redhat.com/show_bug.cgi?id=1492475 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:19:12 --- Comment #15 from Fedora Update System --- aftertheflood-sparks-fonts-2.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542654] Review Request: quentier - Cross-platform desktop Evernote client
https://bugzilla.redhat.com/show_bug.cgi?id=1542654 Bug 1542654 depends on bug 1542650, which changed state. Bug 1542650 Summary: Review Request: qevercloud - Unofficial Evernote Cloud API for Qt5 https://bugzilla.redhat.com/show_bug.cgi?id=1542650 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542651] Review Request: libquentier - Set of Qt/ C++ APIs for feature rich desktop clients for Evernote service
https://bugzilla.redhat.com/show_bug.cgi?id=1542651 Bug 1542651 depends on bug 1542650, which changed state. Bug 1542650 Summary: Review Request: qevercloud - Unofficial Evernote Cloud API for Qt5 https://bugzilla.redhat.com/show_bug.cgi?id=1542650 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542650] Review Request: qevercloud - Unofficial Evernote Cloud API for Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1542650 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:18:48 --- Comment #8 from Fedora Update System --- qevercloud-4.0.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 --- Comment #13 from Fedora Update System --- patool-1.12-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1536852] Review Request: molsketch - Molecular Structures Editor
https://bugzilla.redhat.com/show_bug.cgi?id=1536852 --- Comment #43 from Fedora Update System --- molsketch-0.5.1-7.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542902] Review Request: php-pecl-redis4 - Extension for communicating with the Redis key-value store
https://bugzilla.redhat.com/show_bug.cgi?id=1542902 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:18:11 --- Comment #10 from Fedora Update System --- php-pecl-redis4-4.0.0~RC1-4.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663 --- Comment #10 from Fedora Update System --- bitlbee-discord-0.4.1-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1525698] Review Request: jid - Json Incremental Digger
https://bugzilla.redhat.com/show_bug.cgi?id=1525698 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:18:01 --- Comment #8 from Fedora Update System --- jid-0.7.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539209] Review Request: ddgr - DuckDuckGo from the terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1539209 --- Comment #11 from Fedora Update System --- ddgr-1.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1198196] Review Request: ghc-auto-update - Efficiently run periodic, on-demand actions
https://bugzilla.redhat.com/show_bug.cgi?id=1198196 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 12:17:34 --- Comment #10 from Fedora Update System --- ghc-auto-update-0.1.4-8.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546851] Review Request: python-certbot-dns-dnsmadeeasy - DNS Made Easy DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1546851 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 11:56:18 --- Comment #11 from Fedora Update System --- python-certbot-dns-dnsmadeeasy-0.21.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547611] Review Request: python-certbot-dns-cloudxns - CloudXNS DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547611 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 11:56:32 --- Comment #11 from Fedora Update System --- python-certbot-dns-cloudxns-0.21.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547601] Review Request: python-certbot-dns-luadns - LuaDNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547601 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 11:56:37 --- Comment #11 from Fedora Update System --- python-certbot-dns-luadns-0.21.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547617] Review Request: python-certbot-dns-cloudflare - Cloudflare DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547617 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 11:56:28 --- Comment #11 from Fedora Update System --- python-certbot-dns-cloudflare-0.21.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547135] Review Request: python-certbot-dns-nsone - NS1 DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547135 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 11:56:23 --- Comment #10 from Fedora Update System --- python-certbot-dns-nsone-0.21.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547122] Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547122 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 11:56:12 --- Comment #11 from Fedora Update System --- python-certbot-dns-dnsimple-0.21.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1544716 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 11:55:27 --- Comment #9 from Fedora Update System --- golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1536852] Review Request: molsketch - Molecular Structures Editor
https://bugzilla.redhat.com/show_bug.cgi?id=1536852 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 11:53:08 --- Comment #42 from Fedora Update System --- molsketch-0.5.1-7.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 11:52:47 --- Comment #9 from Fedora Update System --- bitlbee-discord-0.4.1-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1519747] Review request: libdigidocpp - Library offers creating, signing and verification of digitally signed documents, according to XAdES and XML-DSIG standards
https://bugzilla.redhat.com/show_bug.cgi?id=1519747 Bug 1519747 depends on bug 1519751, which changed state. Bug 1519751 Summary: Estonia ID card patch (OpenSC <= 0.17 only) https://bugzilla.redhat.com/show_bug.cgi?id=1519751 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549676] Review Request: golang-github-client9-gospell - Pure golang spelling based on hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=1549676 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-client9-gospell -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549686] Review Request: f28-backgrounds - Fedora 28 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1549686 Luya Tshimbalanga changed: What|Removed |Added Alias||f28-backgrounds -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549686] New: Review Request: f28-backgrounds - Fedora 28 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1549686 Bug ID: 1549686 Summary: Review Request: f28-backgrounds - Fedora 28 default desktop background Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: l...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://copr-be.cloud.fedoraproject.org/results/luya/f28-backgrounds/fedora-rawhide-x86_64/00721636-f28-backgrounds/f28-backgrounds.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/luya/f28-backgrounds/fedora-rawhide-x86_64/00721636-f28-backgrounds/f28-backgrounds-28.0.0-1.fc28.src.rpm Description: This package contains desktop backgrounds for the Fedora 28 default theme. Pulls in themes for GNOME, KDE, Mate and Xfce desktops. Fedora Account System Username: luya -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549676] Review Request: golang-github-client9-gospell - Pure golang spelling based on hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=1549676
Jared Smith changed:
What|Removed |Added
Status|NEW |POST
CC||jsmith.fed...@gmail.com
Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com
Flags||fedora-review+
--- Comment #1 from Jared Smith ---
Package is APPROVED. Please note that the spec file given was slightly
different than the one in the SRPM.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 32 files have
unknown license. Detailed output of licensecheck in
/home/jsmith/Documents/Fedora/Reviews/1549676-golang-github-
client9-gospell/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-client9-gospell-devel , golang-github-client9-gospell-unit-
test-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[Bug 1549676] New: Review Request: golang-github-client9-gospell - Pure golang spelling based on hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=1549676 Bug ID: 1549676 Summary: Review Request: golang-github-client9-gospell - Pure golang spelling based on hunspell dictionaries Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: e...@mayorgalinux.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://fedorapeople.org/~mayorga/golang-github-client9-gospell.spec SRPM URL: https://fedorapeople.org/~mayorga/golang-github-client9-gospell-0-0.1.git90dfc71.fc26.src.rpm Description: Pure golang spelling dictionary based on hunspell dictionaries. Fedora Account System Username: mayorga -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1250025] Review Request: rocksdb - A Persistent Key-Value Store for Flash and RAM Storage
https://bugzilla.redhat.com/show_bug.cgi?id=1250025 Matej Mužila changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2018-02-27 10:23:32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1548759] Review Request: bcal - Storage conversion and expression calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1548759 Jared Smith changed: What|Removed |Added Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526705] Review Request: python-f5-icontrol-rest - F5 BIG-IP iControl REST API client
https://bugzilla.redhat.com/show_bug.cgi?id=1526705 --- Comment #8 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-f5-icontrol-rest -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1549317] Review Request: rust-humantime - Parser and formatter for std::time::{Duration, SystemTime}
https://bugzilla.redhat.com/show_bug.cgi?id=1549317 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications
https://bugzilla.redhat.com/show_bug.cgi?id=1507103
Jan Pokorný changed:
What|Removed |Added
Status|POST|ASSIGNED
Assignee|jfrie...@redhat.com |jpoko...@redhat.com
Flags|fedora-review+ |fedora-review?
--- Comment #55 from Jan Pokorný ---
Re macros in %changelog:
Common way of escaping that convey what was meant down the road
(e.g. to rpm -q --changelog query) is to use doubled '%', i.e.,
%{_isa} -> %%{_isa}, not to drop the per cent character.
Some concerns that remain:
A. [Comment 28] 4.: no reason to mangle with debuginfo generation
- one can always use command-line switches to achieve the same:
http://lists.rpm.org/pipermail/rpm-list/2013-April/001416.html
(definitely not a mainstream need, even less in Fedora context)
B. [Comment 11]: I'd still suggest using
%{configure} \
> %{?with_sctp:--enable-libknet-sctp} \
> %{!?with_sctp:--disable-libknet-sctp} \
> [...]
Reason is also practical, e.g. the whole "configure" statement
barely fits a single laptop screen for me currently, because
the notation of choice is excessively line-hungry.
Also, please:
C. Refrain from initial spaces/indentation in %description-s.
D. Check whether there are some tests that could be run as part of
the build under %check scriptlet (to be added if that's the case).
E. Because libknet1-devel requires (indirectly) libknet1, it may
drop the %license files, as these will be present thanks to
libknet1 installed in parallel, hence satisfying:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Subpackage_Licensing
Rather for future consideration:
- if the documentation for the API functions will keep growing,
it might be desirable to split those manpages to a separate
subpackage:
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
("Or if there's a lot of documentation...")
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications
https://bugzilla.redhat.com/show_bug.cgi?id=1507103
--- Comment #54 from Jan Pokorný ---
Re macros in %changelog:
Common way of escaping that convey what was meant down the road
(e.g. to rpm -q --changelog query) is to use doubled '%', i.e.,
%{_isa} -> %%{_isa}, not to drop the per cent character.
Some concerns that remain:
A. [Comment 28] 4.: no reason to mangle with debuginfo generation
- one can always use command-line switches to achieve the same:
http://lists.rpm.org/pipermail/rpm-list/2013-April/001416.html
(definitely not a mainstream need, even less in Fedora context)
B. [Comment 11]: I'd still suggest using
%{configure} \
> %{?with_sctp:--enable-libknet-sctp} \
> %{!?with_sctp:--disable-libknet-sctp} \
> [...]
Reason is also practical, e.g. the whole "configure" statement
barely fits a single laptop screen for me currently, because
the notation of choice is excessively line-hungry.
Also, please:
C. Refrain from initial spaces/indentation in %description-s.
D. Check whether there are some tests that could be run as part of
the build under %check scriptlet (to be added if that's the case).
E. Because libknet1-devel requires (indirectly) libknet1, it may
drop the %license files, as these will be present thanks to
libknet1 installed in parallel, hence satisfying:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Subpackage_Licensing
Rather for future consideration:
- if the documentation for the API functions will keep growing,
it might be desirable to split those manpages to a separate
subpackage:
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
("Or if there's a lot of documentation...")
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications
https://bugzilla.redhat.com/show_bug.cgi?id=1507103 Jan Friesse changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications
https://bugzilla.redhat.com/show_bug.cgi?id=1507103 Jan Friesse changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications
https://bugzilla.redhat.com/show_bug.cgi?id=1507103
--- Comment #53 from Jan Friesse ---
Package is ok to go into Fedora.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_s
