[Bug 1834932] Review Request: python-google-i18n-address - Address validation helpers for Google's i18n address database
https://bugzilla.redhat.com/show_bug.cgi?id=1834932
Fabian Affolter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
|needinfo?(mail@fabian-affol |
|ter.ch) |
--- Comment #3 from Fabian Affolter ---
Could you please add %{?python_provide:%python_provide python3-%{pypi_name}}
for the Python 3 package before the import?
Other issues were addressed, package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820850] Review Request: golang-github-jpillora-tld - TLD parser
https://bugzilla.redhat.com/show_bug.cgi?id=1820850 --- Comment #4 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793 Fabian Affolter changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@fabian-affolter.ch Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 --- Comment #13 from Fedora Update System --- FEDORA-2020-08bcf86079 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-08bcf86079 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-08bcf86079 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832979] Review Request: python-ovirt-engine-sdk4 - Python SDK for version 4 of the oVirt Engine API
https://bugzilla.redhat.com/show_bug.cgi?id=1832979 --- Comment #9 from Fedora Update System --- FEDORA-2020-344e3095e3 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-344e3095e3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-344e3095e3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808406] Review Request: python-cooldict - Some useful dict-like structures
https://bugzilla.redhat.com/show_bug.cgi?id=1808406 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #4 from Fedora Update System --- FEDORA-2020-a6f35f6d56 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-a6f35f6d56 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a6f35f6d56 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787452] Review Request: python-devtools - Dev tools for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1787452 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- FEDORA-2020-08986a1cad has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-08986a1cad \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-08986a1cad See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820851] Review Request: golang-github-jpillora-sizestr - Pretty print byte counts
https://bugzilla.redhat.com/show_bug.cgi?id=1820851 --- Comment #6 from Fedora Update System --- FEDORA-2020-b800d5de3e has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-b800d5de3e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b800d5de3e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- FEDORA-2020-6b578c45df has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-6b578c45df \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6b578c45df See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820851] Review Request: golang-github-jpillora-sizestr - Pretty print byte counts
https://bugzilla.redhat.com/show_bug.cgi?id=1820851 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- FEDORA-2020-9e20bc1019 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-9e20bc1019 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9e20bc1019 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832979] Review Request: python-ovirt-engine-sdk4 - Python SDK for version 4 of the oVirt Engine API
https://bugzilla.redhat.com/show_bug.cgi?id=1832979 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2020-f3ed4c9caf has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f3ed4c9caf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f3ed4c9caf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 Erich Eickmeyer changed: What|Removed |Added Flags||needinfo?(fed...@svgames.pl ||) --- Comment #2 from Erich Eickmeyer --- >You should use the %cmake macro instead of a "raw" cmake call here, it'll >ensure that CFLAGS/CXXFLAGS/LDFLAGS are set up properly Fixed. >>%install >>rm -rf $RPM_BUILD_ROOT >Don't do this. >https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections There is nothing in that link that says that `rm -rf $RPM_BUILD_ROOT` should not be used. It says `BuildRoot:` should not be used, but that's not what is being done there. Besides, that was part of the default rpm spec template, so does that mean there's a bug in the template? I'll have new SRPM/SPEC files as soon as COPR starts working again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1570551] Review Request: pgcli - Postgres CLI with autocompletion and syntax highlighting
https://bugzilla.redhat.com/show_bug.cgi?id=1570551 Bug 1570551 depends on bug 1833783, which changed state. Bug 1833783 Summary: Review Request: python-pgspecial - Meta-commands handler for Postgres Database https://bugzilla.redhat.com/show_bug.cgi?id=1833783 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833612] Review Request: ttyd - Share your terminal over the web
https://bugzilla.redhat.com/show_bug.cgi?id=1833612 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-20 03:19:56 --- Comment #9 from Fedora Update System --- FEDORA-2020-813ccb5fac has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833785] Review Request: pgcli - CLI for Postgres Database. With auto-completion and syntax highlighting
https://bugzilla.redhat.com/show_bug.cgi?id=1833785 Bug 1833785 depends on bug 1833783, which changed state. Bug 1833783 Summary: Review Request: python-pgspecial - Meta-commands handler for Postgres Database https://bugzilla.redhat.com/show_bug.cgi?id=1833783 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833785] Review Request: pgcli - CLI for Postgres Database. With auto-completion and syntax highlighting
https://bugzilla.redhat.com/show_bug.cgi?id=1833785 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-20 03:20:06 --- Comment #12 from Fedora Update System --- FEDORA-2020-f312bca70b has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830323] Review Request: gap-pkg-images - Minimal and canonical images in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830323 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-20 03:20:00 --- Comment #6 from Fedora Update System --- FEDORA-2020-4e613ff4fd has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833783] Review Request: python-pgspecial - Meta-commands handler for Postgres Database
https://bugzilla.redhat.com/show_bug.cgi?id=1833783 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-20 03:20:09 --- Comment #7 from Fedora Update System --- FEDORA-2020-8d61301e1e has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833842] Review Request: pg_activity - Top like application for PostgreSQL server activity monitoring
https://bugzilla.redhat.com/show_bug.cgi?id=1833842 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-20 03:20:01 --- Comment #8 from Fedora Update System --- FEDORA-2020-e6df854f91 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793 Carson Black changed: What|Removed |Added Blocks||1837798 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1837798 [Bug 1837798] Review Request: golang-github-elves-elvish - Elvish shell -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837798] Review Request: golang-github-elves-elvish - Elvish shell
https://bugzilla.redhat.com/show_bug.cgi?id=1837798 Carson Black changed: What|Removed |Added Depends On||1837793 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1837793 [Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837798] New: Review Request: golang-github-elves-elvish - Elvish shell
https://bugzilla.redhat.com/show_bug.cgi?id=1837798 Bug ID: 1837798 Summary: Review Request: golang-github-elves-elvish - Elvish shell Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: uhh...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://appadeia.fedorapeople.org/packaging/golang-github-elves-elvish/golang-github-elves-elvish.spec SRPM URL: https://appadeia.fedorapeople.org/packaging/golang-github-elves-elvish/golang-github-elves-elvish-0.13.1-1.fc32.src.rpm Description: Friendly Interactive Shell and Expressive Programming Language Fedora Account System Username: appadeia -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837793] New: Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793 Bug ID: 1837793 Summary: Review Request: golang-github-xiaq-persistent - Persistent data structures for Go Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: uhh...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://appadeia.fedorapeople.org/packaging/golang-github-xiaq-persistent/golang-github-xiaq-persistent.spec SRPM URL: https://appadeia.fedorapeople.org/packaging/golang-github-xiaq-persistent/golang-github-xiaq-persistent-0-0.1.20200520gita1d9ac4.fc32.src.rpm Description: Persistent data structure in Go Fedora Account System Username: appadeia -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825560] Review Request: setzer - LaTeX editor written in Python with Gtk
https://bugzilla.redhat.com/show_bug.cgi?id=1825560 --- Comment #3 from Lyes Saadi --- Hi! I can confirm that L10n support was added for 0.2.6! I unfortunately missed the update. Upstream uses tags and not GitHub releases, so I wasn't aware of a new version... Also, I cannot find any unit test in the project? Are you referring to the "tests" directory? It only contains a meson file that validate the metainfo, but since it is already done in the check section, I think it is better to leave it as is for clarity. If you don't agree, don't hesitate to tell me why, I'll gladly change it! It also has a new manual entry :D! Updated version to 0.2.6: Spec URL: https://lyessaadi.fedorapeople.org/setzer/setzer.spec Manpage Patch: https://lyessaadi.fedorapeople.org/setzer/setzer-manpage-installation-path.patch SRPM URL: https://lyessaadi.fedorapeople.org/setzer/setzer-0.2.6-1.fc32.src.rpm Copr Build: https://copr.fedorainfracloud.org/coprs/lyessaadi/setzer/build/1398516/ Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44714414 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837757] Review Request: python-threadpoolctl - Thread-pool Controls
https://bugzilla.redhat.com/show_bug.cgi?id=1837757 Sergio Pascual changed: What|Removed |Added Blocks||1836744 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1836744 [Bug 1836744] Current version is not importable -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837757] New: Review Request: python-threadpoolctl - Thread-pool Controls
https://bugzilla.redhat.com/show_bug.cgi?id=1837757 Bug ID: 1837757 Summary: Review Request: python-threadpoolctl - Thread-pool Controls Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sergio.pa...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://sergiopr.fedorapeople.org/python-threadpoolctl.spec SRPM URL: https://sergiopr.fedorapeople.org/python-threadpoolctl-2.0.0-1.fc33.src.rpm Description: Python helpers to limit the number of threads used in the threadpool-backed of common native libraries used for scientific computing and data science (e.g. BLAS and OpenMP). Fine control of the underlying thread-pool size can be useful in workloads that involve nested parallelism so as to mitigate oversubscription issues. Fedora Account System Username: sergiopr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 --- Comment #11 from Fedora Update System --- FEDORA-2020-6b578c45df has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6b578c45df -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2020-08bcf86079 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-08bcf86079 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834932] Review Request: python-google-i18n-address - Address validation helpers for Google's i18n address database
https://bugzilla.redhat.com/show_bug.cgi?id=1834932 Paul Wouters changed: What|Removed |Added Flags||needinfo?(mail@fabian-affol ||ter.ch) --- Comment #2 from Paul Wouters --- Thanks for review. Issues resolved: Spec URL: https://nohats.ca/ftp/python-google-i18n-address/python-google-i18n-address.spec SRPM URL: https://nohats.ca/ftp/python-google-i18n-address/python-google-i18n-address-2.3.5-2.fc32.src.rpm Description: This package contains a copy of Google’s i18n address metadata repository that contains great data but comes with no uptime guarantees. Contents of this package will allow you to programatically build address forms that adhere to rules of a particular region or country, validate local addresses and format them to produce a valid address label for delivery. The package also contains a Python interface for address validation.} Fedora Account System Username: pwouters rpmlint output: python-google-i18n-address.src: W: spelling-error %description -l en_US uptime -> up time, up-time, suppertime python-google-i18n-address.src: W: spelling-error %description -l en_US programatically -> grammatically, problematically, pragmatically python3-google-i18n-address.noarch: W: spelling-error %description -l en_US uptime -> up time, up-time, suppertime python3-google-i18n-address.noarch: W: spelling-error %description -l en_US programatically -> grammatically, problematically, pragmatically 2 packages and 0 specfiles checked; 0 errors, 4 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835023] Review Request: openbgpd - OpenBGPD Routing Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1835023 --- Comment #1 from Robert Scheck --- Spec URL: https://labs.linuxnetz.de/bugzilla/openbgpd.spec SRPM URL: https://labs.linuxnetz.de/bugzilla/openbgpd-6.7p0-1.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832979] Review Request: python-ovirt-engine-sdk4 - Python SDK for version 4 of the oVirt Engine API
https://bugzilla.redhat.com/show_bug.cgi?id=1832979 --- Comment #7 from Fedora Update System --- FEDORA-2020-f3ed4c9caf has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f3ed4c9caf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832979] Review Request: python-ovirt-engine-sdk4 - Python SDK for version 4 of the oVirt Engine API
https://bugzilla.redhat.com/show_bug.cgi?id=1832979 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2020-344e3095e3 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-344e3095e3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 Neil Horman changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621
--- Comment #19 from Neil Horman ---
New review looks good! Theres only two things left to handle:
1) I checked on the pem certificates, and I can't find any explicit rule about
inclusion of pem certificates, so I think we're good, and as its marked as a
conf file it should be replaceable without getting flagged as an rpm change
post install, so I'm good there
2) The bundling of extra packages. I didn't fully comprehend how fedora
implemented that. I was under the impression that bundled packages in golang
could have an exception to download from the internet, but I was mistaken. The
build system unilaterally disallows network access during builds, so its
guaranteed to not be able to do that. When the docs say bundled, they mean
included in the source rpm. Fortunately thats an easy fix. To correct that we
need to:
a) Take a snapshot of the packages that you need from the gopath after a
clean install, and tar it up (I've taken the liberty of doing so for you here:
https://people.redhat.com/nhorman/rpms/rmd-extra.pkgs.tbz2
Note that this is just a quick and dirty tarballing, and its about 400MB,
you might be better off trying to pair that down a little if you can (I'm not
sure if go allows you to trim out commit history to
save space, but you can use it if need be.
b) Modify the spec file as follows:
[nhorman@hmswarspite SPECS]$ diff -u ~/1826621-rmd/srpm/rmd.spec ./rmd.spec
--- /home/nhorman/1826621-rmd/srpm/rmd.spec 2020-05-19 13:51:10.014546923
-0400
+++ ./rmd.spec 2020-05-19 15:13:43.579637705 -0400
@@ -5,6 +5,7 @@
License:ASL 2.0
URL:https://github.com/intel/rmd
Source0:
https://github.com/arunprabhu123/rmd/blob/master/rmd-1.0.tar.gz
+Source1: rmd-extra-pkgs.tbz2
BuildRequires: go
BuildRequires: make
@@ -61,8 +62,13 @@
%prep
%setup -q
-
+mkdir app
+
%build
+mkdir _pkg
+tar -C _pkg -x -v -f %{SOURCE1}
+find _pkg -type d -exec chmod 755 {} \;
+export GOPATH=$PWD/_pkg:/usr/lib/golang
make %{?_smp_mflags}
%install
This will place the extra packages you need in a subdir (the _pkg directory is
created so go build ignores the path when running go build). We then explode
the extra packages into that subdir, and ammend our GOPATH to point to it, so
that can reference them without having to download them from the internet.
Once thats done you should be good to go.
I'm approving this review request, since you'll need to fix this before the
package will build in koji.
When you are ready please continue the fedora packaging process by requesting a
repo be created for this package using the fedpkg request-repo command (see
https://fedoraproject.org/wiki/Package_Review_Process)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834977] Review Request: python-cchardet - High speed universal character encoding detector
https://bugzilla.redhat.com/show_bug.cgi?id=1834977 Carl George 🤠 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Carl George 🤠 --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833741] Review Request: python-colcon-lcov-result - Extension for colcon to provide test results using LCOV
https://bugzilla.redhat.com/show_bug.cgi?id=1833741 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-colcon-lcov-result -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834496] Review Request: python-colcon-coveragepy-result - Extension for colcon to collect coverage.py results
https://bugzilla.redhat.com/show_bug.cgi?id=1834496 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-colcon-coveragepy-result -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833745] Review Request: python-colcon-ed - Extension for colcon to edit a file within a package
https://bugzilla.redhat.com/show_bug.cgi?id=1833745 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-colcon-ed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 --- Comment #18 from Neil Horman --- In regards to your koji issue, the build system uses kerberos to authenticate, and you need to configure the FEDORAPROJECT.ORG realm. You should get the realm configuration file installed with the fedora-packager package. just run: dnf install fedora-packager and you should be good to go. I'll review the package shortly -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787452] Review Request: python-devtools - Dev tools for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1787452 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2020-08986a1cad has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-08986a1cad -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gearhead1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 aegor...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from aegor...@redhat.com --- > The textmode build of the game does not include any external libraries, so > it doesn't link to anything more. As such, if anything, this would be a bug > against FPC. I see that the build process is pretty straight forward. I checked FPC man and tried different options, but the result is the same. I think it should be escalated to FPC. > I'm using tabs for indentation everywhere. Apparently rpmlint really doesn't > like me using more than 1 space to separate command arguments in some places. This shouldn't be a problem. Looks good to me. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 --- Comment #17 from ArunPrabhu Vijayan --- Hi, I was trying to Setup Koji Build system. I'm getting this error with kinit. kinit avija...@fedoraproject.org kinit: Cannot contact any KDC for realm 'FEDORAPROJECT.ORG' while getting initial credentials Can you please tell me what is this error and how to solve it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)
https://bugzilla.redhat.com/show_bug.cgi?id=1837107
Dominik 'Rathann' Mierzejewski changed:
What|Removed |Added
CC||domi...@greysector.net
--- Comment #1 from Dominik 'Rathann' Mierzejewski ---
BuildRequires: gcc-c++
BuildRequires: SDL2-devel, SDL2_net-devel
BuildRequires: enet-devel
BuildRequires: openal-soft-devel, autoconf
BuildRequires: gettext-devel
BuildRequires: desktop-file-utils
BuildRequires: ImageMagick
BuildRequires: libcurl-devel
BuildRequires: automake
It is a matter of taste, but I'd put one dependency per line and sort
alphabetically.
It's easier to follow and makes diffs smaller in case of dependency changes.
%postun music
if [ $1 -eq 0 ] ; then
## When Uninstall
rm -fr %{prj_music_dir}
fi
This is unnecessary (and rpmlint warns about it being dangerous).
You can get the list of files that autodownloader will download and include it
with %ghost marker instead.
cd /tmp/%{name}-music
tar xjvf /tmp/%{name}-music/%{name}-music.tar.bz2
sudo install -v -m 644 /tmp/%{name}-music/%{name}-music/music/*
%{_datadir}/%{name}/music
sudo install -v -m 644 /tmp/%{name}-music/%{name}-music/*.txt
%{_docdir}/%{name}-music
This should use mktemp instead of a hard-coded directory name.
Moreover, /tmp is an in-memory file system and may not have enough space.
mktemp -p /var/tmp -d looks like a good solution here.
Also, you should not assume that sudo will be configured.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #43 from Miro Hrončok --- (In reply to Martin Liška from comment #41) > > > > Also note that there are 162 skipped tests (from 241). Maybe a dependency is > > missing? > > They should be run in separate pytest context: > https://github.com/noxdafox/pebble/blob/master/test/run-tests.sh > > because one can't change start method multiple times: > https://github.com/noxdafox/pebble/blob/master/test/ > test_concurrent_process_forkserver.py#L21 Consider adapting the test section to do the same thing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
Miro Hrončok changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #42 from Miro Hrončok ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License (v3
or later)".
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into bi
[Bug 1576792] Review Request: python-webthing - HTTP Web Thing implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1576792 Peter Robinson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-19 14:30:34 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1576792] Review Request: python-webthing - HTTP Web Thing implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1576792 --- Comment #21 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-webthing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787452] Review Request: python-devtools - Dev tools for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1787452 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-devtools -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820859] Review Request: golang-github-jpillora-backoff - Simple backoff algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1820859 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-jpillora-backoff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820857] Review Request: golang-github-andrew-d-termutil - Terminal utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1820857 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-andrew-d-termutil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833405] Review Request: python-ufoLib2 - A library to deal with UFO font sources
https://bugzilla.redhat.com/show_bug.cgi?id=1833405 Fabian Affolter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Fabian Affolter --- Issues addressed, package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing
https://bugzilla.redhat.com/show_bug.cgi?id=1828205 David Cantrell changed: What|Removed |Added Flags|fedora-review? |fedora-review+ |requires_doc_text? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing
https://bugzilla.redhat.com/show_bug.cgi?id=1828205 --- Comment #22 from David Cantrell --- Everything looks good, thanks for the update. My only comment is to change the %description. Rather than duplicating the Summary string, I suggest the first paragraph from the doctest README file: doctest is a new C++ testing framework but is by far the fastest both in compile times (by orders of magnitude) and runtime compared to other feature-rich alternatives. It brings the ability of compiled languages such as D / Rust / Nim to have tests written directly in the production code thanks to a fast, transparent and flexible test runner with a clean interface. Up to you, but generally the %description blocks are meant to be more text and explanation about what the package actually is. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing
https://bugzilla.redhat.com/show_bug.cgi?id=1828205 --- Comment #21 from David Cantrell --- > = MUST items = > > C/C++: > [ ]: Package does not contain kernel modules. It does not. > [ ]: Package contains no static executables. It does now. > Generic: > [ ]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. MIT is approved. > [ ]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "Expat License", "Boost Software > License (v1.0)", "Expat License Boost Software License (v1.0)", "*No > copyright* GNU General Public License (v3)", "Apache License (v2.0)". > 199 files have unknown license. Detailed output of licensecheck in > /home/dcantrell/doctest/licensecheck.txt Everything in the project is licensed under the MIT license noted in LICENSE.txt in the source. licensecheck.txt contains false information where it is misdetecting some licenses. > [ ]: %build honors applicable compiler flags or justifies otherwise. Yep. > [ ]: Package contains no bundled libraries without FPC exception. None. > [ ]: Changelog in prescribed format. Yes. > [ ]: Sources contain only permissible code or content. Yes. > [ ]: Package contains desktop file if it is a GUI application. N/A > [ ]: Development files must be in a -devel package Yes. > [ ]: Package uses nothing in %doc for runtime. Correct. > [ ]: Package consistently uses macros (instead of hard-coded directory > names). Yes. > [ ]: Package is named according to the Package Naming Guidelines. Yes. > [ ]: Package does not generate any conflict. None. > [ ]: Package obeys FHS, except libexecdir and /usr/target. Yes, as much as cmake allows. > [ ]: If the package is a rename of another package, proper Obsoletes and > Provides are present. N/A > [ ]: Requires correct, justified where necessary. N/A > [ ]: Spec file is legible and written in American English. Yes. > [ ]: Package contains systemd file(s) if in need. N/A > [ ]: Useful -debuginfo package or justification otherwise. N/A > [ ]: Package is not known to require an ExcludeArch tag. N/A > [ ]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 61440 bytes in 3 files. N/A > [ ]: Package complies to the Packaging Guidelines Yes > = SHOULD items = > > Generic: > [ ]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. N/A, license already included. > [ ]: Final provides and requires are sane (see attachments). Yes. > [ ]: Package functions as described. Yes. > [ ]: Latest version is packaged. Yes. > [ ]: Package does not include license text files separate from upstream. Yes. > [ ]: Sources are verified with gpgverify first in %prep if upstream > publishes signatures. > Note: gpgverify is not used. N/A > [ ]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. N/A > [ ]: Package should compile and build into binary rpms on all supported > architectures. N/A > [ ]: %check is present and all tests pass. Yes > [ ]: Packages should try to preserve timestamps of original installed > files. Yes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833405] Review Request: python-ufoLib2 - A library to deal with UFO font sources
https://bugzilla.redhat.com/show_bug.cgi?id=1833405 --- Comment #3 from Parag Nemade --- Thank you for taking this package for review. I have fixed both the issues -2 release Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/python-ufoLib2.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/python-ufoLib2-0.7.1-2.fc32.src.rpm Koji scratch build -> https://koji.fedoraproject.org/koji/taskinfo?taskID=44687907 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing
https://bugzilla.redhat.com/show_bug.cgi?id=1828205
--- Comment #20 from David Cantrell ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "Boost Software
License (v1.0)", "Expat License Boost Software License (v1.0)", "*No
copyright* GNU General Public License (v3)", "Apache License (v2.0)".
199 files have unknown license. Detailed output of licensecheck in
/home/dcantrell/doctest/licensecheck.txt
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 3 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the packag
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #41 from Martin Liška --- > > Also note that there are 162 skipped tests (from 241). Maybe a dependency is > missing? They should be run in separate pytest context: https://github.com/noxdafox/pebble/blob/master/test/run-tests.sh because one can't change start method multiple times: https://github.com/noxdafox/pebble/blob/master/test/test_concurrent_process_forkserver.py#L21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132
Artur Iwicki changed:
What|Removed |Added
Flags|needinfo?(fed...@svgames.pl |
|) |
--- Comment #7 from Artur Iwicki ---
>gearhead1-textmode.x86_64: E: statically-linked-binary
>/usr/libexec/gearhead1/gearhead1-textmode
A "Hello world" program build with FPC on Fedora 32 does not link to anything:
>$ echo "program helloworld; begin writeln('Hello, world.') end." >
>hello_world.pas && fpc hello_world.pas && ./hello_world && ldd ./hello_world
>Free Pascal Compiler version 3.2.0-beta [2020/05/04] for x86_64
>Copyright (c) 1993-2020 by Florian Klaempfl and others
>Target OS: Linux for x86-64
>Compiling hello_world.pas
>Linking hello_world
>1 lines compiled, 0.1 sec
>Hello, world.
> not a dynamic executable
The textmode build of the game does not include any external libraries, so it
doesn't link to anything more. As such, if anything, this would be a bug
against FPC.
>gearhead1.src:153: W: mixed-use-of-spaces-and-tabs (spaces: line 153, tab:
>line 153)
I'm using tabs for indentation everywhere. Apparently rpmlint really doesn't
like me using more than 1 space to separate command arguments in some places.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #40 from Martin Liška --- (In reply to Miro Hrončok from comment #38) > It seem to me that the license should be LGPLv3+, see > https://github.com/noxdafox/pebble/blob/4.5.3/pebble/common.py#L7 -- it says > "or (at your option) any later version" > > > Also note that there are 162 skipped tests (from 241). Maybe a dependency is > missing? Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #39 from Miro Hrončok --- > Also note that there are 162 skipped tests (from 241). Maybe a dependency is > missing? Seem like it's all about support for various features in Python. I'll trust upstream the detection is OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #38 from Miro Hrončok --- It seem to me that the license should be LGPLv3+, see https://github.com/noxdafox/pebble/blob/4.5.3/pebble/common.py#L7 -- it says "or (at your option) any later version" Also note that there are 162 skipped tests (from 241). Maybe a dependency is missing? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 aegor...@redhat.com changed: What|Removed |Added Flags||needinfo?(fed...@svgames.pl ||) --- Comment #6 from aegor...@redhat.com --- I'm sorry for not pointing it in the initial review comment. There is one more problem pointed by rpmlint. - $ rpmlint RPMS/x86_64/gearhead1-textmode-1.310-4.fc31.x86_64.rpm ... gearhead1-textmode.x86_64: E: statically-linked-binary /usr/libexec/gearhead1/gearhead1-textmode ... https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries Also there are more mixed-use-of-spaces-and-tabs warnings. - $ rpmlint SRPMS/gearhead1-1.310-4.fc31.src.rpm ... gearhead1.src:153: W: mixed-use-of-spaces-and-tabs (spaces: line 153, tab: line 153) ... after fixing this "spaces and tabs" warning please run rpmlint again, I saw that there is more places like that -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825139] Review Request: python-pymata-express - Python Protocol Abstraction Library For Arduino Firmata
https://bugzilla.redhat.com/show_bug.cgi?id=1825139 --- Comment #1 from Fabian Affolter --- %changelog * Mon May 18 2020 Fabian Affolter - 1.13-1 - Update to latest upstream release 1.13 Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pymata-express.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pymata-express-1.13-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #37 from Martin Liška --- Fixed: SRPM: https://github.com/marxin/fedora-Pebble/raw/master/python-pebble-4.5.3-1.fc31.src.rpm SPEC: https://raw.githubusercontent.com/marxin/fedora-Pebble/master/python-pebble.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 ArunPrabhu Vijayan changed: What|Removed |Added Flags|needinfo?(arunprabhu.vijaya | |n...@intel.com)| --- Comment #16 from ArunPrabhu Vijayan --- Spec URL: https://raw.githubusercontent.com/arunprabhu123/rmd/master/rmd.spec SRPM URL: https://github.com/arunprabhu123/rmd/raw/master/rmd-1.0-1.fc32.src.rpm Note: Fixed review comments, 1. Added go packages to SPEC file.Remaining packages will be as used bundled exception in go.mod file. 2. RMD now runs as a Demeon. systemd file support added to RMD. 3. Fixed additional comments as given in review Please review and kindly let us know if any errors. We will correct them. Thanks in advance. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820608] golang-github-davecgh-spew - pretty printer for golang data structures library
https://bugzilla.redhat.com/show_bug.cgi?id=1820608 Fabian Affolter changed: What|Removed |Added CC||m...@fabian-affolter.ch Doc Type|--- |If docs needed, set a value --- Comment #1 from Fabian Affolter --- This package is already available: https://src.fedoraproject.org/rpms/golang-github-davecgh-spew -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 --- Comment #2 from Fabian Affolter --- (In reply to Robert-André Mauchin from comment #1) > - License is GPLv2 not MIT: Fixed > - Add BR gcc Added > - Tests are not properly run: > > + /usr/bin/python3 setup.py test > running test > running egg_info > WARNING: Testing via this command is deprecated and will be removed in a > future version. Users looking for a generic test entry point independent of > test runner are encouraged to use tox. > writing mysqlclient.egg-info/PKG-INFO > writing dependency_links to mysqlclient.egg-info/dependency_links.txt > writing top-level names to mysqlclient.egg-info/top_level.txt > reading manifest file 'mysqlclient.egg-info/SOURCES.txt' > reading manifest template 'MANIFEST.in' > writing manifest file 'mysqlclient.egg-info/SOURCES.txt' > running build_ext > copying > build/lib.linux-x86_64-3.8/MySQLdb/_mysql.cpython-38-x86_64-linux-gnu.so -> > MySQLdb > -- > Ran 0 tests in 0.000s > > They seem to be run using Pytest, but they need a mysql server I think. Yes, they need a DB instance. Add but not enabled by default. %changelog * Mon May 18 2020 Fabian Affolter - 1.4.6-2 - Add tests and missing BR - Fix license (rhbz#1816295) Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-mysqlclient.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-mysqlclient-1.4.6-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836768] Review Request: postfix-mta-sts-resolver - Daemon providing MTA-STS map to Postfix
https://bugzilla.redhat.com/show_bug.cgi?id=1836768 --- Comment #1 from Marc Dequènes (Duck) --- I made fixes. Here is the SRPM: https://download.copr.fedorainfracloud.org/results/duck/osas-infra-team-rpm-repo-devel/fedora-rawhide-x86_64/01394846-postfix-mta-sts-resolver/postfix-mta-sts-resolver-0.8.2-1.fc33.src.rpm And build log: https://copr.fedorainfracloud.org/coprs/duck/osas-infra-team-rpm-repo-devel/build/1394846/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1776669] Review Request: python-pycdio - A Python interface to the CD Input and Control library
https://bugzilla.redhat.com/show_bug.cgi?id=1776669 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 11:03:23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821158] Review Request: python-click-help-colors - Colorization of help messages in Click
https://bugzilla.redhat.com/show_bug.cgi?id=1821158 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 11:03:57 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #36 from Miro Hrončok --- Sources in SRPM do not match what can be downloaded from the URL. https://files.pythonhosted.org/packages/source/P/Pebble/Pebble-4.5.1.tar.gz : CHECKSUM(SHA256) this package : 89828b4ebe1654b81c64d3b1aecc19d651a05231f86cc981af6f9e18f9825c38 CHECKSUM(SHA256) upstream package : 26fdcc0f36d93d8e07559d36b942b7800c6b9622626d5b587ab1a74820d02732 diff -r also reports differences -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1598779] Review Request: python-bigsuds - Library for F5 Networks iControl API
https://bugzilla.redhat.com/show_bug.cgi?id=1598779 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 11:01:32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1596727] Review Request: python-f5-sdk - F5 Networks Python SDK
https://bugzilla.redhat.com/show_bug.cgi?id=1596727 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 11:00:52 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808023] Review Request: python-git-url-parse - A simple GIT URL parser similar to giturlparse.py
https://bugzilla.redhat.com/show_bug.cgi?id=1808023 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:59:39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796653] Review Request: python-pynetbox - Python API client library for Netbox
https://bugzilla.redhat.com/show_bug.cgi?id=1796653 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:57:31 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796735] Review Request: python-py-gfm - Github-Flavored Markdown for Python-Markdown
https://bugzilla.redhat.com/show_bug.cgi?id=1796735 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:56:54 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796734] Review Request: python-markdown_2 - Python implementation of Markdown
https://bugzilla.redhat.com/show_bug.cgi?id=1796734 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:56:37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796750] Review Request: python-coreschema - Core Schema
https://bugzilla.redhat.com/show_bug.cgi?id=1796750 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:55:57 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796754] Review Request: python-coreapi - Python client library for Core API
https://bugzilla.redhat.com/show_bug.cgi?id=1796754 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:55:27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796753] Review Request: python-itypes - Simple immutable types for python
https://bugzilla.redhat.com/show_bug.cgi?id=1796753 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:55:00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #35 from Miro Hrončok --- Running a build now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796759] Review Request: python-swagger-spec-validator - Validation of Swagger specifications
https://bugzilla.redhat.com/show_bug.cgi?id=1796759 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:54:26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796764] Review Request: python-drf-yasg - Automated generation of real Swagger/OpenAPI 2.0 schemas from Django Rest
https://bugzilla.redhat.com/show_bug.cgi?id=1796764 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:53:54 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1735723] Review Request: python-freecell_solver - cffi-based bindings for libfreecell-solver
https://bugzilla.redhat.com/show_bug.cgi?id=1735723 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:52:26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796721] Review Request: python-whatever - Easy way to make anonymous functions by partial application of operators
https://bugzilla.redhat.com/show_bug.cgi?id=1796721 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:50:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1687178] Review Request: python-apprise - Push Notifications that work with just about every platform!
https://bugzilla.redhat.com/show_bug.cgi?id=1687178 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:48:04 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824156] Review Request: exfatprogs - Userspace utilities for exFAT filesystems
https://bugzilla.redhat.com/show_bug.cgi?id=1824156 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #23 from Neal Gompa --- No serious issues found. PACKAGE APPROVED (sans FE-LEGAL!). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762471] Review Request: python-upt-cpan - CPAN front-end for upt
https://bugzilla.redhat.com/show_bug.cgi?id=1762471 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed|2019-11-27 14:22:11 |2020-05-19 10:47:00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824156] Review Request: exfatprogs - Userspace utilities for exFAT filesystems
https://bugzilla.redhat.com/show_bug.cgi?id=1824156
Neal Gompa changed:
What|Removed |Added
Flags|needinfo?(ngomp...@gmail.co |
|m) |
--- Comment #22 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License". 27
files have unknown license. Detailed output of licensecheck in
/home/ngompa/1824156-exfatprogs/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libexfat
, libexfat-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if ups
[Bug 1732822] Review Request: python-tox-current-env - Tox plugin to run tests in current Python environment
https://bugzilla.redhat.com/show_bug.cgi?id=1732822 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:45:19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1526705] Review Request: python-f5-icontrol-rest - F5 BIG-IP iControl REST API client
https://bugzilla.redhat.com/show_bug.cgi?id=1526705 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:44:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly
https://bugzilla.redhat.com/show_bug.cgi?id=1328248 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:42:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #34 from Martin Liška --- May I please ping that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1550685 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:39:35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1550655] Review Request: python-tree-format - Python library to generate nicely formatted trees, like the UNIX tree command
https://bugzilla.redhat.com/show_bug.cgi?id=1550655 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:38:45 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1550685 Bug 1550685 depends on bug 1552883, which changed state. Bug 1552883 Summary: Review Request: python-jinja2-time - Jinja2 Extension for Dates and Times https://bugzilla.redhat.com/show_bug.cgi?id=1552883 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1552883] Review Request: python-jinja2-time - Jinja2 Extension for Dates and Times
https://bugzilla.redhat.com/show_bug.cgi?id=1552883 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:37:00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1563353] Review Request: python-click-completion - Add automatic completion support for fish, Zsh, Bash and PowerShell to Click
https://bugzilla.redhat.com/show_bug.cgi?id=1563353 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:36:06 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1782532] Review Request: python-npyscreen - python library to create forms using python ncurses
https://bugzilla.redhat.com/show_bug.cgi?id=1782532 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC||m...@fabian-affolter.ch Resolution|--- |RAWHIDE Last Closed||2020-05-19 10:35:18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
