[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)
https://bugzilla.redhat.com/show_bug.cgi?id=810049 --- Comment #123 from leenaji --- (In reply to gil cattaneo from comment #0) > Spec URL: http://gil.fedorapeople.org/netbeans.spec > SRPM URL: http://gil.fedorapeople.org/netbeans-7.1.1-1.fc16.src.rpm > Description: NetBeans IDE is an Integrated Development Environment (IDE) for > Java/JavaFX, > C/C++, Ruby, PHP, etc. The NetBeans IDE is oriented on wide audience of > developers from beginners up to experts. A developer can find useful set of > the development tools that are embedded in the IDE or can be integrated > with. > The NetBeans IDE is the modular system and it can be configured according to > user needs. Please, visit http://www.netbeans.org/ for more information > about > this open-source project. https://udaipurcallgirlsandescort.com/ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844313] Review Request: python-daphne - Django ASGI (HTTP/WebSocket) server
https://bugzilla.redhat.com/show_bug.cgi?id=1844313 Carl George 鸞 changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||python-daphne-2.5.0-1.fc33 Resolution|--- |RAWHIDE Last Closed||2020-06-06 03:23:08 --- Comment #3 from Carl George 鸞 --- Thanks Fabian. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5f2ceba4a9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844303] Review Request: python-watchgod - Simple, modern file watching and code reload
https://bugzilla.redhat.com/show_bug.cgi?id=1844303 Carl George 鸞 changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||python-watchgod-0.6-1.fc33 Resolution|--- |RAWHIDE Last Closed||2020-06-06 03:21:49 --- Comment #3 from Carl George 鸞 --- Thanks Fabian. https://bodhi.fedoraproject.org/updates/FEDORA-2020-886875ea9e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844308] Review Request: python-uvicorn - The lightning-fast ASGI server
https://bugzilla.redhat.com/show_bug.cgi?id=1844308 Bug 1844308 depends on bug 1844303, which changed state. Bug 1844303 Summary: Review Request: python-watchgod - Simple, modern file watching and code reload https://bugzilla.redhat.com/show_bug.cgi?id=1844303 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 Carl George 鸞 changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||gnome-shell-extension-emoji ||-selector-19-2.fc33 Resolution|--- |RAWHIDE Last Closed||2020-06-06 03:19:56 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 --- Comment #9 from Carl George 鸞 --- https://bodhi.fedoraproject.org/updates/FEDORA-2020-8bb0db68cd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840870] Review Request: golang-github-harrymichal-version - Version normalizer and comparison library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1840870 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-harrymichal-version -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1842579] Review Request: golang-github-acobaugh-osrelease - Golang package to read and parse /etc/os-release
https://bugzilla.redhat.com/show_bug.cgi?id=1842579 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-acobaugh-osrelease -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844313] Review Request: python-daphne - Django ASGI (HTTP/WebSocket) server
https://bugzilla.redhat.com/show_bug.cgi?id=1844313 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-daphne -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-emoji-selector -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844303] Review Request: python-watchgod - Simple, modern file watching and code reload
https://bugzilla.redhat.com/show_bug.cgi?id=1844303 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-watchgod -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830712] Review Request: kronometer - A simple KDE stopwatch application
https://bugzilla.redhat.com/show_bug.cgi?id=1830712 --- Comment #6 from Kevin Kofler --- At a first glance, the specfile looks reasonable to me. Just please also write your name in the changelog and not only the e-mail address. I have sponsored Andrea. Benvenuto! (Welcome!) Please read https://fedoraproject.org/wiki/Join_the_package_collection_maintainers carefully and follow the process. I am fluent in Italian (it's the language of my citizenship after all), so if you have any questions you have to ask me, feel free to ask them in Italian if it is easier for you. (Though I guess that as a Red Hat employee, you are probably also used to communicating in English.) Raphael, can you complete the formal review? (You can approve the package now that the contributor is sponsored.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1060920] Review Request: openni2 - OpenNI libraries for 3D-sensing
https://bugzilla.redhat.com/show_bug.cgi?id=1060920 Scott K Logan changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX Last Closed||2020-06-05 22:39:02 --- Comment #26 from Scott K Logan --- This packages has largely been abandoned, and I'm not aware of any modern products being released that utilize it. So many patches are needed to get it where it needs to be (debian has 18 for this package), and the spec file isn't very maintainable. I'm going to abandon this review. If someone is interested in taking it on, please feel free. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844643] Review Request: qwt5-qt5 - Qt Widgets for Technical Applications adapted to Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1844643 Alexander Ploumistos changed: What|Removed |Added Blocks||1830463 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1830463 [Bug 1830463] scidavis-2.1.4 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844643] New: Review Request: qwt5-qt5 - Qt Widgets for Technical Applications adapted to Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1844643 Bug ID: 1844643 Summary: Review Request: qwt5-qt5 - Qt Widgets for Technical Applications adapted to Qt5 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: alex.ploumis...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://alexpl.fedorapeople.org/packages/qwt5-qt5/qwt5-qt5.spec SRPM URL: https://alexpl.fedorapeople.org/packages/qwt5-qt5/qwt5-qt5-5.2.3a-3.20190819giteeacc44.fc32.src.rpm COPR: https://copr.fedorainfracloud.org/coprs/alexpl/scidavis/ Scratch builds: https://koji.fedoraproject.org/koji/taskinfo?taskID=45467281 https://koji.fedoraproject.org/koji/taskinfo?taskID=45467298 Description: The Qwt library contains GUI Components and utility classes which are primarily useful for programs with a technical background. Besides a 2D plot widget it provides scales, sliders, dials, compasses, thermometers, wheels and knobs to control or display values, arrays or ranges of type double. While we do have various qwt and qwt5 packages in Fedora, we do not have Qwt5 built with Qt5, which is needed in order to update SciDAVis to version 2.x. The source of this package is essentially a fork of the last maintenance release of the Qwt 5.x branch: https://sourceforge.net/projects/qwt/files/qwt/5.2.3/ As far as I know, it's used by other distributions that carry SciDAVis 2.x. The differences from the original are that a few bugs have been fixed and that installation paths in configuration files have been patched to comply with our guidelines (the developer who forked the code is also a Fedora user and he works on SciDAVis upstream). I have been using this fork since November 2018 and a little after that I added it to my COPR, in order to provide pre-release builds of SciDAVis 2.x. Fedora Account System Username: alexpl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840870] Review Request: golang-github-harrymichal-version - Version normalizer and comparison library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1840870 Fabiano Fidêncio changed: What|Removed |Added Assignee|m...@fabian-affolter.ch |fiden...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1842579] Review Request: golang-github-acobaugh-osrelease - Golang package to read and parse /etc/os-release
https://bugzilla.redhat.com/show_bug.cgi?id=1842579 Fabiano Fidêncio changed: What|Removed |Added Assignee|nob...@fedoraproject.org|fiden...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833471] Review Request: ocaml-variantslib - OCaml variants as first class values
https://bugzilla.redhat.com/show_bug.cgi?id=1833471 --- Comment #2 from Jerry James --- As in the ocaml-fieldslib case, CONTRIBUTING.md has been removed and a boolean expression has been added to the spec file for ocaml-base. New URLs: Spec URL: https://jjames.fedorapeople.org/ocaml-variantslib/ocaml-variantslib.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-variantslib/ocaml-variantslib-0.13.0-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833469] Review Request: ocaml-fieldslib - OCaml record fields as first class values
https://bugzilla.redhat.com/show_bug.cgi?id=1833469
--- Comment #2 from Jerry James ---
(In reply to dan.cermak from comment #1)
> Sorry for taking so long to review this Jerry. I've found the following
> minor issues:
> - CONTRIBUTING.md is imho not necessary to include as %doc
Agreed. I have dropped it.
> - upstream's opam file notes the following dependency on ocaml-base: {>=
> "v0.13" & < "v0.14"} but the spec has only >= 0.13. If that is intended,
> maybe add a comment explaining that?
I didn't realize it was possible to express both constraints. I've added a
boolean expression that does the job.
> - since it took me so long to review this, upstream released 0.14 in the
> meantime
They did. I need to update all of the Jane Street packages from 0.13 to 0.14,
but haven't had time to work through the mock builds yet. With the datacenter
move looming, I probably won't get around to it for a couple of weeks or so.
Can we finish the review with the 0.13 version, then I can update the whole
Jane Street ecosystem to 0.14 later?
> Otherwise this looks perfectly fine to me!
Thanks for the review, Dan. No worries on the delay. $DAYJOB has been keeping
me pretty busy lately anyway.
New URLs:
Spec URL: https://jjames.fedorapeople.org/ocaml-fieldslib/ocaml-fieldslib.spec
SRPM URL:
https://jjames.fedorapeople.org/ocaml-fieldslib/ocaml-fieldslib-0.13.0-1.fc33.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833469] Review Request: ocaml-fieldslib - OCaml record fields as first class values
https://bugzilla.redhat.com/show_bug.cgi?id=1833469 --- Comment #3 from Jerry James --- Oops. I meant this of course: Spec URL: https://jjames.fedorapeople.org/ocaml-fieldslib/ocaml-fieldslib.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-fieldslib/ocaml-fieldslib-0.13.0-2.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837019] Review Request: theme-switcher - Switch dark/light GTK theme automatically during day/night
https://bugzilla.redhat.com/show_bug.cgi?id=1837019 --- Comment #9 from Artem --- Custom user unit will be better for sure, i even remembered i wanted to add it long time ago, but need some time for this. Hope it's OK for now to make conditional for F31: https://download.copr.fedorainfracloud.org/results/atim/theme-switcher/fedora-32-x86_64/01427789-theme-switcher/theme-switcher.spec https://download.copr.fedorainfracloud.org/results/atim/theme-switcher/fedora-32-x86_64/01427789-theme-switcher/theme-switcher-2.0.4-3.fc32.src.rpm I'll try to ask few people for testing this, but they are on F32 already. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833413] Review Request: vomsxrd - VOMS attribute extractor plug-in for XRootD
https://bugzilla.redhat.com/show_bug.cgi?id=1833413 Mattias Ellert changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Doc Type|--- |If docs needed, set a value Last Closed||2020-06-05 19:16:47 --- Comment #1 from Mattias Ellert --- vomsxrd has been integrated into the main xrootd package. Available as xrootd-voms starting from version 4.12.2. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844435] Review Request: jc - Convert output of popular CLI tools to JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1844435 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-2020-61b58f10e7 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-61b58f10e7 --- Comment #8 from Fedora Update System --- FEDORA-2020-e2e8ac2b5f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e2e8ac2b5f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 --- Comment #24 from Fedora Update System --- FEDORA-2020-8c39388753 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8c39388753 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #23 from Fedora Update System --- FEDORA-2020-cdfe6eabff has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-cdfe6eabff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839477] Review Request: python-google-api-core - Core Library for Google Client Libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1839477 --- Comment #5 from Fedora Update System --- FEDORA-2020-69d4fc98f9 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-69d4fc98f9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839470] Review Request: python-googleapis-common-protos - Common protobufs used in Google APIs
https://bugzilla.redhat.com/show_bug.cgi?id=1839470 --- Comment #9 from Fedora Update System --- FEDORA-2020-69d4fc98f9 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-69d4fc98f9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839470] Review Request: python-googleapis-common-protos - Common protobufs used in Google APIs
https://bugzilla.redhat.com/show_bug.cgi?id=1839470 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2020-2a556e082f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-2a556e082f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839477] Review Request: python-google-api-core - Core Library for Google Client Libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1839477 --- Comment #6 from Fedora Update System --- FEDORA-2020-69d4fc98f9 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-69d4fc98f9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839477] Review Request: python-google-api-core - Core Library for Google Client Libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1839477 --- Comment #4 from Fedora Update System --- FEDORA-2020-2a556e082f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-2a556e082f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839477] Review Request: python-google-api-core - Core Library for Google Client Libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1839477 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #3 from Fedora Update System --- FEDORA-2020-2a556e082f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-2a556e082f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456
Miro Hrončok changed:
What|Removed |Added
CC||mhron...@redhat.com
--- Comment #5 from Miro Hrončok ---
%check
%if %{with_python3}
%{__python3} setup.py test
%else
%{__python2} setup.py test
%endif
%build
%if %{with_python3}
%py3_build
%else
%py2_build
%endif
%install
%if %{with_python3}
%py3_install
%else
%py2_install
%endif
...
%files
%if %{with_python2}
%{python2_sitelib}/libvirt_test_api*
%{python2_sitelib}/libvirttestapi*
%endif
%if %{with_python3}
%{python3_sitelib}/libvirt_test_api*
%{python3_sitelib}/libvirttestapi*
%endif
What about:
%if %{with_python3}
%global __python %{__python3}
%else
%global __python %{__python2}
%endif
...
%check
%{__python} setup.py test
%build
%py_build
%install
%py_install
...
%files
%{python_sitelib}/libvirt_test_api*
%{python_sitelib}/libvirttestapi*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844526] New: Review Request: python-ssdp - Python library for Simple Service Discovery Protocol (SSDP)
https://bugzilla.redhat.com/show_bug.cgi?id=1844526 Bug ID: 1844526 Summary: Review Request: python-ssdp - Python library for Simple Service Discovery Protocol (SSDP) Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-ssdp.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-ssdp-1.0.1-1.fc31.src.rpm Project URL: https://github.com/codingjoe/ssdp Description: Python asyncio library for Simple Service Discovery Protocol (SSDP). SSDP is a UPnP sub standard. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45457040 rpmlint output: $ rpmlint python-ssdp-1.0.1-1.fc31.src.rpm python-ssdp.src: W: spelling-error %description -l en_US asyncio -> syncopation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint python3-ssdp-1.0.1-1.fc31.noarch.rpm python3-ssdp.noarch: W: spelling-error %description -l en_US asyncio -> syncopation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Bug 1773720 depends on bug 1773719, which changed state. Bug 1773719 Summary: Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API https://bugzilla.redhat.com/show_bug.cgi?id=1773719 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Bug 1773719 depends on bug 1773717, which changed state. Bug 1773717 Summary: Review Request: golang-github-haproxytech-models - HAProxy Go structs for API https://bugzilla.redhat.com/show_bug.cgi?id=1773717 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Bug 1773720 depends on bug 1773717, which changed state. Bug 1773717 Summary: Review Request: golang-github-haproxytech-models - HAProxy Go structs for API https://bugzilla.redhat.com/show_bug.cgi?id=1773717 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Brandon Perkins changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 15:29:41 --- Comment #16 from Brandon Perkins --- CLOSED. In Rawhide (f33) and in progress for f32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Bug 1773719 depends on bug 1773718, which changed state. Bug 1773718 Summary: Review Request: golang-github-haproxytech-config-parser - HAProxy configuration parser https://bugzilla.redhat.com/show_bug.cgi?id=1773718 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773718] Review Request: golang-github-haproxytech-config-parser - HAProxy configuration parser
https://bugzilla.redhat.com/show_bug.cgi?id=1773718 Brandon Perkins changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 15:29:32 --- Comment #12 from Brandon Perkins --- CLOSED. In Rawhide (f33) and in progress for f32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Bug 1773720 depends on bug 1833511, which changed state. Bug 1833511 Summary: Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation https://bugzilla.redhat.com/show_bug.cgi?id=1833511 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Bug 1773720 depends on bug 1773718, which changed state. Bug 1773718 Summary: Review Request: golang-github-haproxytech-config-parser - HAProxy configuration parser https://bugzilla.redhat.com/show_bug.cgi?id=1773718 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773717] Review Request: golang-github-haproxytech-models - HAProxy Go structs for API
https://bugzilla.redhat.com/show_bug.cgi?id=1773717 Brandon Perkins changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 15:29:36 --- Comment #13 from Brandon Perkins --- CLOSED. In Rawhide (f33) and in progress for f32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 Brandon Perkins changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 15:29:27 --- Comment #15 from Brandon Perkins --- CLOSED. In Rawhide (f33) and in progress for f32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Bug 1773720 depends on bug 1773716, which changed state. Bug 1773716 Summary: Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation https://bugzilla.redhat.com/show_bug.cgi?id=1773716 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Brandon Perkins changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 15:29:24 --- Comment #23 from Brandon Perkins --- CLOSED. In Rawhide (f33) and in progress for f32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511 Brandon Perkins changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 15:29:19 --- Comment #6 from Brandon Perkins --- CLOSED. In Rawhide (f33) and in progress for f32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #4 from Richard W.M. Jones --- https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/thread/2IXDR32RWPKHZWA43HVHBZFL5FHHBKNH/ Please fix the other things while we're waiting for a response from the Fedora community. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844435] Review Request: jc - Convert output of popular CLI tools to JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1844435 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/jc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839542] Review Request: snallygaster - Tool to scan for secret files on HTTP servers
https://bugzilla.redhat.com/show_bug.cgi?id=1839542
--- Comment #3 from Lyes Saadi ---
(In reply to Fabian Affolter from comment #2)
> (In reply to Lyes Saadi from comment #1)
> > Tests fail on mock because pycodestyle, pyflakes, pylint and flake8 are
> > missing.
>
> This is the reason why I limited the tests. Guidelines say not to run
> lintings and alike.
Yes, this is why I questioned the relevancy ;).
> %check
> # Not running the lint test
> %{__python3} tests/test_scan_testdata.py
I think you sent the wrong spec?
Here (https://fab.fedorapeople.org/packages/SRPMS/snallygaster.spec), I can see
this:
> %check
> %{__python3} setup.py test
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840377] Review Request: socialscan - CLI and library for usage checking of user names and email addresses
https://bugzilla.redhat.com/show_bug.cgi?id=1840377 --- Comment #2 from Fabian Affolter --- Looks like that I didn't upload the latest files. The latest spec file uses "%bcond_with network". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839542] Review Request: snallygaster - Tool to scan for secret files on HTTP servers
https://bugzilla.redhat.com/show_bug.cgi?id=1839542
--- Comment #2 from Fabian Affolter ---
(In reply to Lyes Saadi from comment #1)
> Tests fail on mock because pycodestyle, pyflakes, pylint and flake8 are
> missing.
This is the reason why I limited the tests. Guidelines say not to run lintings
and alike.
%check
# Not running the lint test
%{__python3} tests/test_scan_testdata.py
> And since test_scan_testdata do not run because there's no internet
> connection, only coding style tests are running, which raises the question
> of relevancy of those tests...
The tests only run if the env var RUN_ONLINETESTS is set as upstream uses a
decorator (@unittest.skipUnless(os.environ.get("RUN_ONLINETESTS")) to skip it.
Thus, the tests should not run on mock. At least in Koji, they don't.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844435] Review Request: jc - Convert output of popular CLI tools to JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1844435 --- Comment #5 from Artur Iwicki --- Hm, I was quite sure that the %py3_build and %py3_install macros complain when non-PyPi sources are used, but either that has been changed some time ago, or it only applies to modules. Either way, I tried a build with only the GitHub source and it worked fine, so yeah, I'm gonna switch to that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844435] Review Request: jc - Convert output of popular CLI tools to JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1844435 --- Comment #4 from Fabian Affolter --- Upps, sorry, the Licensing issue is a false-positive. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844435] Review Request: jc - Convert output of popular CLI tools to JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1844435
Fabian Affolter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Fabian Affolter ---
How about to switch to the upstream source from GItHub completely? Would save
you the trouble of dealing with two sources. Not a blocker and your call.
There is lint issue: jc.src:36: W: mixed-use-of-spaces-and-tabs (spaces: line
3, tab: line 36)
Beside that, nothing more. Please fix lint issue before the import.
Package APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Expat License", "Unknown or generated", "*No copyright* BSD
(unspecified)". 708 files have unknown license. Detailed output of
licensecheck in
/home/fab/Documents/repos/reviews/1844435-jc/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 266240 bytes in 54 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456
--- Comment #3 from Richard W.M. Jones ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
License if GPLv2+ and upstream includes a license file.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License",
"GNU General Public License (v2 or later)", "GPL (v2 or later)". 414
files have unknown license. Detailed output of licensecheck in
/var/tmp/1825456-libvirt-test-api/licensecheck.txt
The vast majority of files have correct licenses in them, and
the ones which don't are things like documentation, conf, XML
where adding a license is hard.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
Not really applicable because this isn't a library.
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
I started a thread on devel list which should appear here:
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/2020/6/
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
Requires: qemu-img may be missing.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
There is documentation supplied upstream but it is not packaged.
[ ]: Package complies to the Packaging Guidelines
Unclear on whether Python packaging guidelines apply. See
thread on devel list.
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0: https://gitlab.com/libvirt/libvirt-
[Bug 1839542] Review Request: snallygaster - Tool to scan for secret files on HTTP servers
https://bugzilla.redhat.com/show_bug.cgi?id=1839542 Lyes Saadi changed: What|Removed |Added CC||fed...@lyes.eu --- Comment #1 from Lyes Saadi --- Hi! Tests fail on mock because pycodestyle, pyflakes, pylint and flake8 are missing. And since test_scan_testdata do not run because there's no internet connection, only coding style tests are running, which raises the question of relevancy of those tests... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812435] Review Request: python-beautifultable - Print ASCII tables for terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1812435 --- Comment #10 from Fedora Update System --- FEDORA-EPEL-2020-c459a8024e has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-c459a8024e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812435] Review Request: python-beautifultable - Print ASCII tables for terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1812435 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #9 from Fedora Update System --- FEDORA-2020-22b9b5930f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-22b9b5930f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844435] Review Request: jc - Convert output of popular CLI tools to JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1844435 Fabian Affolter changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #2 from Fabian Affolter --- I removed FE-NEEDSPONSOR. You don't need a sponsor ;-) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839887] Review Request: python-cle - A Python interface for analyzing binary formats
https://bugzilla.redhat.com/show_bug.cgi?id=1839887 W. Michael Petullo changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 13:39:09 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839889] Review Request: python-angr - A multi-architecture binary analysis toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1839889 Bug 1839889 depends on bug 1839887, which changed state. Bug 1839887 Summary: Review Request: python-cle - A Python interface for analyzing binary formats https://bugzilla.redhat.com/show_bug.cgi?id=1839887 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844435] Review Request: jc - Convert output of popular CLI tools to JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1844435 Fabian Affolter changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@fabian-affolter.ch Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839887] Review Request: python-cle - A Python interface for analyzing binary formats
https://bugzilla.redhat.com/show_bug.cgi?id=1839887 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2020-9e72bd8f8b has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9e72bd8f8b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456
--- Comment #2 from Richard W.M. Jones ---
Some general comments on the spec file:
(1) There are some typos / formatting issues in the very first # comment
at the top of the file. It would be better reformatted as:
# Disable the shebangs checks on scripts that currently don't
# define a Python version. The point here is that these scripts
# will be copied to guest VM instances, which may be running
# operating systems that can have either Python 2 or Python 3,
# but it's impossible to know for sure at packaging time.
(2) In the section %if %{with_python3} ... %else ... %endif that
defines BuildRequires and Requires, it is better to factor out the
common BRs/Rs, ie:
BuildRequires: mock
%if %{with_python3}
BuildRequires: python3-devel
BuildRequires: python3-lxml
BuildRequires: python3-pytest
BuildRequires: python3-setuptools
BuildRequires: python3-six
BuildRequires: python3-attrs
BuildRequires: python3-libvirt
BuildRequires: python3-pexpect
Requires: qemu-img
Requires: python3-six
Requires: python3-lxml
Requires: python3-libvirt
%else
BuildRequires: python2-devel
BuildRequires: python2-pytest
BuildRequires: python2-setuptools
BuildRequires: python2-attrs
BuildRequires: python-six
BuildRequires: python2-pexpect
Requires: python-six
Requires: python-lxml
%endif
Requires: libvirt
Requires: qemu-kvm
Requires: virt-install
(3) Is it really the case that qemu-img is only required if using
Python 3, or is that a mistake revealed by the refactoring?
(4) Whitespace in:
%if 0%{?rhel} && 0%{?rhel} < 8
Requires: libvirt-python
%endif
(5) The %files section should also be refactored. You can see that
it's much clearer afterwards:
%files
%doc README.md
%license LICENSE
%{_bindir}/%{name}
%if %{with_python2}
%{python2_sitelib}/libvirt_test_api*
%{python2_sitelib}/libvirttestapi*
%endif
%if %{with_python3}
%{python3_sitelib}/libvirt_test_api*
%{python3_sitelib}/libvirttestapi*
%endif
%{_datadir}/libvirt-test-api*
I'll do a formal review in a minute.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 --- Comment #22 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/opensurge -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 Richard W.M. Jones changed: What|Removed |Added CC||rjo...@redhat.com Assignee|nob...@fedoraproject.org|rjo...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 Lyes Saadi changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Lyes Saadi --- Ok! Package approved! Thank you for your work :D! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848 Artur Iwicki changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |DUPLICATE Last Closed||2020-06-05 11:51:10 --- Comment #37 from Artur Iwicki --- Sure. Made a couple changes to the spec along the way. *** This bug has been marked as a duplicate of bug 1844435 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844435] Review Request: jc - Convert output of popular CLI tools to JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1844435 Artur Iwicki changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) CC||kellyjonbra...@gmail.com --- Comment #1 from Artur Iwicki --- *** Bug 1824848 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844435] New: Review Request: jc - Convert output of popular CLI tools to JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1844435 Bug ID: 1844435 Summary: Review Request: jc - Convert output of popular CLI tools to JSON Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@svgames.pl QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora spec: https://svgames.pl/fedora/jc-1.11.2-2/jc.spec srpm: https://svgames.pl/fedora/jc-1.11.2-2/jc-1.11.2-2.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=45450662 Description: jc is a command line tool that takes the output of dozens of commands and converts it into JSON for easier parsing. Fedora Account System Username: suve -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 --- Comment #5 from Charalampos Stratakis --- Created attachment 1695411 --> https://bugzilla.redhat.com/attachment.cgi?id=1695411=edit Proposed SPEC Here is a proposed SPEC. With it the package builds fine, install and imports under python3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840870] Review Request: golang-github-harrymichal-version - Version normalizer and comparison library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1840870 Ondřej Míchal changed: What|Removed |Added Summary|Review Request: |Review Request: |golang-github-HarryMichal-g |golang-github-harrymichal-v |o-version - Version |ersion - Version normalizer |normalizer and comparison |and comparison library for |library for Go |Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844392] Review Request: python-httpcore - Minimal low-level HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1844392 Fabian Affolter changed: What|Removed |Added Blocks||1844395 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1844395 [Bug 1844395] Review Request: python-httpx - Python HTTP client -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844395] Review Request: python-httpx - Python HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1844395 Fabian Affolter changed: What|Removed |Added Depends On||1844392, 1844385, 1844405 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1844385 [Bug 1844385] Review Request: python-hstspreload - Chromium HSTS Preload list https://bugzilla.redhat.com/show_bug.cgi?id=1844392 [Bug 1844392] Review Request: python-httpcore - Minimal low-level HTTP client https://bugzilla.redhat.com/show_bug.cgi?id=1844405 [Bug 1844405] python-rfc3986-1.4.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844385] Review Request: python-hstspreload - Chromium HSTS Preload list
https://bugzilla.redhat.com/show_bug.cgi?id=1844385 Fabian Affolter changed: What|Removed |Added Blocks||1844395 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1844395 [Bug 1844395] Review Request: python-httpx - Python HTTP client -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844395] New: Review Request: python-httpx - Python HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1844395 Bug ID: 1844395 Summary: Review Request: python-httpx - Python HTTP client Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-httpx.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-httpx-0.13.3-1.fc31.src.rpm Project URL: https://github.com/encode/httpx Description: HTTPX is a fully featured HTTP client for Python 3, which provides sync and async APIs, and support for both HTTP/1.1 and HTTP/2. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45448201 rpmlint output: $ rpmlint python-httpx-0.13.3-1.fc31.src.rpm python-httpx.src: W: spelling-error %description -l en_US async -> sync, a sync 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint python3-httpx-0.13.3-1.fc31.noarch.rpm python3-httpx.noarch: W: spelling-error %description -l en_US async -> sync, a sync python3-httpx.noarch: E: zero-length /usr/lib/python3.7/site-packages/httpx/py.typed 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844392] New: Review Request: python-httpcore - Minimal low-level HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1844392 Bug ID: 1844392 Summary: Review Request: python-httpcore - Minimal low-level HTTP client Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-httpcore.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-httpcore-0.9.1-1.fc31.src.rpm Project URL: https://github.com/encode/httpcore Description: The HTTP Core package provides a minimal low-level HTTP client, which does one thing only: Sending HTTP requests. It does not provide any high level model abstractions over the API, does not handle redirects, multipart uploads, building authentication headers, transparent HTTP caching, URL parsing, etc. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45448015 rpmlint output: $ rpmlint python-httpcore-0.9.1-1.fc31.src.rpm python-httpcore.src: W: spelling-error %description -l en_US multipart -> multiparty, multiplier 1 packages and 0 specfiles checked; 0 errors, 1 warnings $ rpmlint python3-httpcore-0.9.1-1.fc31.noarch.rpm python3-httpcore.noarch: W: spelling-error %description -l en_US multipart -> multiparty, multiplier python3-httpcore.noarch: E: zero-length /usr/lib/python3.7/site-packages/httpcore/py.typed 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844225] Review Request: python-sphinx-pyreverse - A simple sphinx extension to generate UML diagrams with pyreverse
https://bugzilla.redhat.com/show_bug.cgi?id=1844225 --- Comment #2 from sumantro --- (In reply to Parag AN(पराग) from comment #1) > The fedora-review tool does not work if you do not give direct downloadable > files. Hence, your package links should be > > SPEC URL: > https://raw.githubusercontent.com/sumantro93/python-sphinx-pyreverse/master/ > python-sphinx-pyreverse.spec > SRPM URL: > https://github.com/sumantro93/python-sphinx-pyreverse/raw/master/python- > sphinx-pyreverse-0.0.13-1.fc32.src.rpm Noted. Do I have to change anything in this bug? I will keep this in mind for the next time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844385] New: Review Request: python-hstspreload - Chromium HSTS Preload list
https://bugzilla.redhat.com/show_bug.cgi?id=1844385 Bug ID: 1844385 Summary: Review Request: python-hstspreload - Chromium HSTS Preload list Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-hstspreload.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-hstspreload-2020.6.5-1.fc31.src.rpm Project URL: https://github.com/sethmlarson/hstspreload Description: Chromium HSTS Preload list as a Python package. The package provides a single function: in_hsts_preload() which takes an IDNA-encoded host and returns either True or False regarding whether that host should be only accessed via HTTPS. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45447346 rpmlint output: $ rpmlint python-hstspreload-2020.6.5-1.fc31.src.rpm python-hstspreload.src: W: spelling-error %description -l en_US hsts -> hats, hosts, hits python-hstspreload.src: W: spelling-error %description -l en_US preload -> reload, p reload, freeload 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint python3-hstspreload-2020.6.5-1.fc31.noarch.rpm python3-hstspreload.noarch: W: spelling-error %description -l en_US hsts -> hats, hosts, hits python3-hstspreload.noarch: W: spelling-error %description -l en_US preload -> reload, p reload, freeload 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 Antonio T. sagitter changed: What|Removed |Added Assignee|anto.tra...@gmail.com |trp...@rocketmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844303] Review Request: python-watchgod - Simple, modern file watching and code reload
https://bugzilla.redhat.com/show_bug.cgi?id=1844303
Fabian Affolter changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||m...@fabian-affolter.ch
Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch
Flags||fedora-review+
--- Comment #1 from Fabian Affolter ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 18 files have unknown
license. Detailed output of licensecheck in
/home/fab/Documents/repos/reviews/1844303-python-
watchgod/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[- ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
[Bug 1844313] Review Request: python-daphne - Django ASGI (HTTP/WebSocket) server
https://bugzilla.redhat.com/show_bug.cgi?id=1844313
Fabian Affolter changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||m...@fabian-affolter.ch
Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch
Flags||fedora-review+
--- Comment #1 from Fabian Affolter ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License", "*No copyright* BSD (unspecified)". 24 files have unknown
license. Detailed output of licensecheck in
/home/fab/Documents/repos/reviews/1844313-python-
daphne/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/python3.9/site-
packages/twisted/plugins/__pycache__(python3-carbon, python3-autobahn,
python3-magic-wormhole-mailbox-server, python3-magic-wormhole-transit-
relay, python3-txtorcon)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build
process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439 Honggang LI changed: What|Removed |Added Flags||needinfo?(mschmidt@redhat.c ||om) --- Comment #17 from Honggang LI --- @mschmidt, could you please add iivanov into packager group? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439 igor.ivanov...@gmail.com changed: What|Removed |Added Flags|needinfo?(igor.ivanov.va@gm | |ail.com)| --- Comment #16 from igor.ivanov...@gmail.com --- May FCA : iivanov -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813182] Review Request: python-jaraco-collections - Collection objects similar to those in stdlib by jaraco
https://bugzilla.redhat.com/show_bug.cgi?id=1813182 Miro Hrončok changed: What|Removed |Added Blocks||1777494 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1777494 [Bug 1777494] python-cherrypy-18.6.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 Miro Hrončok changed: What|Removed |Added Blocks||1777494 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1777494 [Bug 1777494] python-cherrypy-18.6.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844225] Review Request: python-sphinx-pyreverse - A simple sphinx extension to generate UML diagrams with pyreverse
https://bugzilla.redhat.com/show_bug.cgi?id=1844225 --- Comment #1 from Parag AN(पराग) --- The fedora-review tool does not work if you do not give direct downloadable files. Hence, your package links should be SPEC URL: https://raw.githubusercontent.com/sumantro93/python-sphinx-pyreverse/master/python-sphinx-pyreverse.spec SRPM URL: https://github.com/sumantro93/python-sphinx-pyreverse/raw/master/python-sphinx-pyreverse-0.0.13-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181
--- Comment #4 from Matthias Runge ---
(In reply to Robert-André Mauchin from comment #1)
> - Source0:
> https://files.pythonhosted.org/packages/source/j/%{pypi_name}/%{pypi_name}-
> %{version}.tar.gz → Source0:%{pypi_source}
>
> - Please use a glob or it won't work for Python >= 3.10
>
> %{python3_sitelib}/%{pypi_name}-%{version}-py*.egg-info
>
> - License is MIT:
>
> License:MIT
>
> - Not installable:
>
> DEBUG util.py:600: Error:
> DEBUG util.py:600: Problem: conflicting requests
> DEBUG util.py:600:- nothing provides python3dist(importlib-resources)
> needed by python3-jaraco.text-3.2.0-1.fc33.noarch
> DEBUG util.py:600:- nothing provides python3dist(pytest-black-multipy)
> needed by python3-jaraco.text-3.2.0-1.fc33.noarch
> DEBUG util.py:600:- nothing provides python3dist(pytest-checkdocs) >=
> 1.2.3 needed by python3-jaraco.text-3.2.0-1.fc33.noarch
> DEBUG util.py:602: (try to add '--skip-broken' to skip uninstallable
> packages or '--nobest' to use not only best candidate packages)
Thank you for your review. I'm sorry that I missed this for so long.
The dependencies were misdeclarations. They are test dependencies. I'll be
working through these slowly
to get tests running during build in a subsequent update.
jaraco.text is blocking cherrypy updates right now.
SPEC: http://matthias-runge.de/fedora/python-jaraco-text.spec
SRPM: http://matthias-runge.de/fedora/python-jaraco-text-3.2.0-1.fc32.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844225] Review Request: python-sphinx-pyreverse - A simple sphinx extension to generate UML diagrams with pyreverse
https://bugzilla.redhat.com/show_bug.cgi?id=1844225 Parag AN(पराग) changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844225] Review Request: python-sphinx-pyreverse - A simple sphinx extension to generate UML diagrams with pyreverse
https://bugzilla.redhat.com/show_bug.cgi?id=1844225 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com Assignee|nob...@fedoraproject.org|panem...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844336] New: Review Request: php-phpunit-php-timer4 - PHP Utility class for timing
https://bugzilla.redhat.com/show_bug.cgi?id=1844336 Bug ID: 1844336 Summary: Review Request: php-phpunit-php-timer4 - PHP Utility class for timing Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://git.remirepo.net/cgit/rpms/php/phpunit/php-phpunit-php-timer4.git/plain/php-phpunit-php-timer4.spec?id=31cf4c33bb73ab39a1d41482306ec0cfd61b93df SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-timer4-4.0.0-1.remi.src.rpm Description: Utility class for timing things, factored out of PHPUnit into a stand-alone component. Fedora Account System Username: remi -- New dependency og PHPUnit 9.2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813182] Review Request: python-jaraco-collections - Collection objects similar to those in stdlib by jaraco
https://bugzilla.redhat.com/show_bug.cgi?id=1813182 --- Comment #1 from Matthias Runge --- This blocks the update to cherrypy 18.5.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 --- Comment #3 from Matthias Runge --- all these jaraco packages are floating around in many packages, especially in cherrypy releated ones. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
