[Bug 1872427] Review Request: ec2-hibinit-agent - support for hibernation for Amazon ec2
https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan changed: What|Removed |Added Flags|needinfo?(davd...@amazon.co |needinfo?(package-review@li |m) |sts.fedoraproject.org) --- Comment #6 from David Duncan --- Updated Spec URL: https://davdunc.fedorapeople.org/ec2-hibinit-agent.spec SRPM URL: https://davdunc.fedorapeople.org/ec2-hibinit-agent-1.0.3-2.fc33.src.rpm Updated with a comment for the source0. Waiting on final approval for the source uri to be valid. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
needinfo requested: [Bug 1872427] Review Request: ec2-hibinit-agent - support for hibernation for Amazon ec2
Product: Fedora Version: rawhide Component: Package Review David Duncan has asked Package Review for needinfo: Bug 1872427: Review Request: ec2-hibinit-agent - support for hibernation for Amazon ec2 https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #6 from David Duncan --- Updated Spec URL: https://davdunc.fedorapeople.org/ec2-hibinit-agent.spec SRPM URL: https://davdunc.fedorapeople.org/ec2-hibinit-agent-1.0.3-2.fc33.src.rpm Updated with a comment for the source0. Waiting on final approval for the source uri to be valid. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1876736] Review Request: ghc-http-client-restricted - Restricting the servers that http-client will use
https://bugzilla.redhat.com/show_bug.cgi?id=1876736 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2020-592bc836ad has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-592bc836ad -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1876737] Review Request: ghc-git-lfs - Git-lfs protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1876737 --- Comment #6 from Fedora Update System --- FEDORA-2020-c8beae383f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-c8beae383f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1882703] Review Request: python-inject - Dependency injection, the Python way
https://bugzilla.redhat.com/show_bug.cgi?id=1882703 --- Comment #8 from Fedora Update System --- FEDORA-2020-ab72625959 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-ab72625959 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ab72625959 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878101] Review Request: cozy - Modern audiobook player
https://bugzilla.redhat.com/show_bug.cgi?id=1878101 --- Comment #11 from Fedora Update System --- FEDORA-2020-ab72625959 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-ab72625959 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ab72625959 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1882703] Review Request: python-inject - Dependency injection, the Python way
https://bugzilla.redhat.com/show_bug.cgi?id=1882703 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- FEDORA-2020-f22aa1693c has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f22aa1693c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f22aa1693c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878902] Review Request: naga - Simplified Java NIO asynchronous sockets
https://bugzilla.redhat.com/show_bug.cgi?id=1878902 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2020-f28bd01371 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-f28bd01371` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f28bd01371 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878903] Review Request: jmol - Java viewer for chemical structures in 3D
https://bugzilla.redhat.com/show_bug.cgi?id=1878903 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- FEDORA-2020-f28bd01371 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-f28bd01371` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f28bd01371 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878101] Review Request: cozy - Modern audiobook player
https://bugzilla.redhat.com/show_bug.cgi?id=1878101 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- FEDORA-2020-f22aa1693c has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f22aa1693c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f22aa1693c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1871697] Review Request: dhall - A configuration language guaranteed to terminate
https://bugzilla.redhat.com/show_bug.cgi?id=1871697 --- Comment #17 from Fedora Update System --- FEDORA-2020-99da0c3c33 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877961] Review Request: python-epson-projector - Python support for Epson projector
https://bugzilla.redhat.com/show_bug.cgi?id=1877961 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-10-02 00:34:26 --- Comment #6 from Fedora Update System --- FEDORA-2020-ece62c3243 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877859] Review Request: python-gekitchen - Python SDK for GE Kitchen Appliances
https://bugzilla.redhat.com/show_bug.cgi?id=1877859 Bug 1877859 depends on bug 1877855, which changed state. Bug 1877855 Summary: Review Request: python-bidict - Bidirectional mapping library for Python https://bugzilla.redhat.com/show_bug.cgi?id=1877855 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877855] Review Request: python-bidict - Bidirectional mapping library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1877855 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-10-02 00:34:35 --- Comment #6 from Fedora Update System --- FEDORA-2020-14086fc77a has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1875868] Review Request: python-aioflo - Python library for Flo by Moen Smart Water Detectors
https://bugzilla.redhat.com/show_bug.cgi?id=1875868 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-10-02 00:34:32 --- Comment #6 from Fedora Update System --- FEDORA-2020-ae8f9629aa has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877215] Review Request: python-aiounifi - Python library for communicating with Unifi Controller API
https://bugzilla.redhat.com/show_bug.cgi?id=1877215 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-10-02 00:34:29 --- Comment #6 from Fedora Update System --- FEDORA-2020-70af49d3b4 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1883977] Review Request: llmnrd - Link-Local Multicast Resolution Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1883977 Pavel Zhukov changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Pavel Zhukov --- Reported issue can be ignored (or better bug against fedora-review reported). LGTM! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1883977] Review Request: llmnrd - Link-Local Multicast Resolution Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1883977
--- Comment #2 from Pavel Zhukov ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in llmnrd
See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets
<<>>
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GNU Lesser General Public License", "Unknown or generated",
"GPL (v2)", "GNU General Public License (v2)". 6 files have unknown
license. Detailed output of licensecheck in /home/pavel/llmnrd/review-
llmnrd/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should
[Bug 1878903] Review Request: jmol - Java viewer for chemical structures in 3D
https://bugzilla.redhat.com/show_bug.cgi?id=1878903 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #9 from Fedora Update System --- FEDORA-2020-f28bd01371 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f28bd01371 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878902] Review Request: naga - Simplified Java NIO asynchronous sockets
https://bugzilla.redhat.com/show_bug.cgi?id=1878902 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-2020-f28bd01371 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f28bd01371 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1883977] Review Request: llmnrd - Link-Local Multicast Resolution Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1883977 Pavel Zhukov changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1883977] Review Request: llmnrd - Link-Local Multicast Resolution Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1883977 Pavel Zhukov changed: What|Removed |Added CC||pzhu...@redhat.com Assignee|nob...@fedoraproject.org|pzhu...@redhat.com Flags||fedora-review? --- Comment #1 from Pavel Zhukov --- I'll review it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881370] Review Request: wwl - Calculates distance and azimuth between two Maidenhead locators
https://bugzilla.redhat.com/show_bug.cgi?id=1881370 Jaroslav Škarvada changed: What|Removed |Added Flags|needinfo?(jskarvad@redhat.c | |om) | --- Comment #5 from Jaroslav Škarvada --- (In reply to aegorenk from comment #4) Thanks for the review. > Notes: > > - [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > > I think it's fine in this case since there is only one source file, which > contains license information. > > - Please pay attention to rpmlint output. > > wwl.x86_64: W: invalid-license Semi-Permissive > should be fine > I am ready to rename the license if the fedora-legal will come up with some different name. > wwl.x86_64: W: spurious-executable-perm /usr/share/man/man1/wwl.1.gz > should be fixed > It should be fixed now. > wwl.x86_64: W: spelling-error %description -l en_US hamradio -> ham radio, > ham-radio, radiogram > should be fine if you think this is the correct way to spell it > Fixed. I took the original description from the upstream, I think "ham radio" is better. > (none): E: no installed packages by name wwl > Not sure about this one. Rather looks like the fedora-review tool problem > than the package itself > Probably. Spec URL: https://jskarvad.fedorapeople.org/wwl/wwl.spec SRPM URL: https://jskarvad.fedorapeople.org/wwl/wwl-1.3-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1883937] Review Request: perl-Term-Terminfo - Access the terminfo database
https://bugzilla.redhat.com/show_bug.cgi?id=1883937 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Term-Terminfo-0.09-1.f ||c34 Resolution|--- |RAWHIDE Last Closed||2020-10-01 16:13:13 --- Comment #4 from Petr Pisar --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878101] Review Request: cozy - Modern audiobook player
https://bugzilla.redhat.com/show_bug.cgi?id=1878101 --- Comment #9 from Fedora Update System --- FEDORA-2020-ab72625959 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ab72625959 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1882703] Review Request: python-inject - Dependency injection, the Python way
https://bugzilla.redhat.com/show_bug.cgi?id=1882703 --- Comment #6 from Fedora Update System --- FEDORA-2020-ab72625959 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ab72625959 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1882703] Review Request: python-inject - Dependency injection, the Python way
https://bugzilla.redhat.com/show_bug.cgi?id=1882703 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2020-f22aa1693c has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f22aa1693c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1883937] Review Request: perl-Term-Terminfo - Access the terminfo database
https://bugzilla.redhat.com/show_bug.cgi?id=1883937 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Term-Terminfo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878101] Review Request: cozy - Modern audiobook player
https://bugzilla.redhat.com/show_bug.cgi?id=1878101 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2020-f22aa1693c has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f22aa1693c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1883937] Review Request: perl-Term-Terminfo - Access the terminfo database
https://bugzilla.redhat.com/show_bug.cgi?id=1883937 --- Comment #2 from Petr Pisar --- https://pagure.io/releng/fedora-scm-requests/issue/29336 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881183] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game
https://bugzilla.redhat.com/show_bug.cgi?id=1881183 --- Comment #11 from josef radinger --- builds now on f32, f33 and rawhide on architecture x86_64. aarch64 build is still underway (i have a very slow emulation). new Spec URL: http://www.nosuchhost.net/~cheese/temp/freeorion.spec new SRPM URL: http://www.nosuchhost.net/~cheese/temp/freeorion-0.4.10-4.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884255] Review Request: python-patiencediff - Contains the implementation of the patiencediff algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1884255
--- Comment #2 from Miro Hrončok ---
Spec sanity
===
> License:GNU GPLv2 or later
This is not a valid license tag, see
https://fedoraproject.org/wiki/Licensing:Main#SoftwareLicenses
That should be:
License:GPLv2+
BTW upstream says GPLv2+ everywhere, but uses the 'License :: OSI Approved ::
GNU General Public License v3 or later (GPLv3+)' classifier. Could you please
contact them about the confusion?
> %{?python_provide:%python_provide python3-%{pypi_name}}
If you target Fedora 33+ only, you don't need this. If you target older
releases, you should use
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro
instead.
> # Remove bundled egg-info
> rm -rf %{pypi_name}.egg-info
This is most likely not needed.
> %{__python3} setup.py test
Please, use %{python3} rather than %{__python3}.
> %{python3_sitearch}/%{pypi_name}
> %{python3_sitearch}/%{pypi_name}-%{version}-py%{python3_version}.egg-info
Please add trailing slashes to assert those are directories:
%{python3_sitearch}/%{pypi_name}/
%{python3_sitearch}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884255] Review Request: python-patiencediff - Contains the implementation of the patiencediff algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1884255 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? --- Comment #1 from Miro Hrončok --- Pasting URLs that lead to spec directly: SPEC URL: https://fedorapeople.org/cgit/opohorel/public_git/python-patiencediff.git/plain/python-patiencediff.spec SRPM URL: https://people.redhat.com/opohorel/python-patiencediff-0.2.0-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884255] New: Review Request: python-patiencediff - Contains the implementation of the patiencediff algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1884255 Bug ID: 1884255 Summary: Review Request: python-patiencediff - Contains the implementation of the patiencediff algorithm Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: opoho...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora SPEC URL: https://fedorapeople.org/cgit/opohorel/public_git/python-patiencediff.git/tree/python-patiencediff.spec SRPM URL: https://people.redhat.com/opohorel/python-patiencediff-0.2.0-1.fc32.src.rpm Description: Contains the implementation of the patiencediff algorithm. This package was separated from Breezy package. Fedora Account System Username: opohorel Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=52579868 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878101] Review Request: cozy - Modern audiobook player
https://bugzilla.redhat.com/show_bug.cgi?id=1878101 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cozy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884235] New: Review Request: php-ramsey-collection - Library for representing and manipulating collections
https://bugzilla.redhat.com/show_bug.cgi?id=1884235 Bug ID: 1884235 Summary: Review Request: php-ramsey-collection - Library for representing and manipulating collections Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://git.remirepo.net/cgit/rpms/php/ramsey/php-ramsey-collection.git/plain/php-ramsey-collection.spec?id=f8b89adf6eec42be1a6fe40926a6b0e1d7e67079 SRPM URL: https://rpms.remirepo.net/SRPMS/php-ramsey-collection-1.1.1-1.remi.src.rpm Description: ramsey/collection is a PHP library for representing and manipulating collections. Much inspiration for this library comes from the Java Collections Framework. Autoloader: /usr/share/php/Ramsey/Collection/autoload.php Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884222] Review Request: rust-weezl - Fast LZW compression and decompression
https://bugzilla.redhat.com/show_bug.cgi?id=1884222 Fabio Valentini changed: What|Removed |Added Blocks||1880868 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1880868 [Bug 1880868] rust-gif-0.11.1 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884222] New: Review Request: rust-weezl - Fast LZW compression and decompression
https://bugzilla.redhat.com/show_bug.cgi?id=1884222 Bug ID: 1884222 Summary: Review Request: rust-weezl - Fast LZW compression and decompression Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://decathorpe.fedorapeople.org/packages/rust-weezl.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/rust-weezl-0.1.0-1.fc32.src.rpm Description: Fast LZW compression and decompression. Fedora Account System Username: decathorpe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884218] New: Review Request: php-brick-math - Arbitrary-precision arithmetic library
https://bugzilla.redhat.com/show_bug.cgi?id=1884218 Bug ID: 1884218 Summary: Review Request: php-brick-math - Arbitrary-precision arithmetic library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://git.remirepo.net/cgit/rpms/php/brick/php-brick-math.git/plain/php-brick-math.spec?id=2268de1284b0438f40b4cfce1e151afeeb2e03dd SRPM URL: https://rpms.remirepo.net/SRPMS/php-brick-math-0.9.1-1.remi.src.rpm Description: A PHP library to work with arbitrary precision numbers. Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1883937] Review Request: perl-Term-Terminfo - Access the terminfo database
https://bugzilla.redhat.com/show_bug.cgi?id=1883937 Jitka Plesnikova changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-Term-Terminfo-0.09-1.fc34.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libpthread.so.0()(64bit) 1 libpthread.so.0(GLIBC_2.2.5)(64bit) 1 libunibilium.so.4()(64bit) 1 perl(Carp) 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-Term-Terminfo-0.09-1.fc34.x86_64.rpm | sort | uniq -c 1 perl(Term::Terminfo) = 0.09 1 perl-Term-Terminfo = 0.09-1.fc34 1 perl-Term-Terminfo(x86-64) = 0.09-1.fc34 Binary provides are Ok. $ rpmlint ./perl-Term-Terminfo* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881370] Review Request: wwl - Calculates distance and azimuth between two Maidenhead locators
https://bugzilla.redhat.com/show_bug.cgi?id=1881370 aegor...@redhat.com changed: What|Removed |Added Flags||needinfo?(jskarvad@redhat.c ||om) --- Comment #4 from aegor...@redhat.com --- Notes: - [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. I think it's fine in this case since there is only one source file, which contains license information. - Please pay attention to rpmlint output. wwl.x86_64: W: invalid-license Semi-Permissive should be fine wwl.x86_64: W: spurious-executable-perm /usr/share/man/man1/wwl.1.gz should be fixed wwl.x86_64: W: spelling-error %description -l en_US hamradio -> ham radio, ham-radio, radiogram should be fine if you think this is the correct way to spell it (none): E: no installed packages by name wwl Not sure about this one. Rather looks like the fedora-review tool problem than the package itself -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881370] Review Request: wwl - Calculates distance and azimuth between two Maidenhead locators
https://bugzilla.redhat.com/show_bug.cgi?id=1881370
--- Comment #3 from aegor...@redhat.com ---
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 4 files have unknown license. Detailed
output of licensecheck in
/home/eam/workspace/wwl/bz1881370/wwl/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include
[Bug 1884176] New: Review Request: rust-adler - Simple clean-room implementation of the Adler-32 checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1884176 Bug ID: 1884176 Summary: Review Request: rust-adler - Simple clean-room implementation of the Adler-32 checksum Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://decathorpe.fedorapeople.org/packages/rust-adler.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/rust-adler-0.2.3-1.fc32.src.rpm Description: Simple clean-room implementation of the Adler-32 checksum Fedora Account System Username: decathorpe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884176] Review Request: rust-adler - Simple clean-room implementation of the Adler-32 checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1884176 Fabio Valentini changed: What|Removed |Added Blocks||1851752 Depends On||1828077 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1828077 [Bug 1828077] rust-criterion-0.3.3 is available https://bugzilla.redhat.com/show_bug.cgi?id=1851752 [Bug 1851752] rust-miniz_oxide-0.4.2 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification
https://bugzilla.redhat.com/show_bug.cgi?id=1877006
--- Comment #2 from Jordi Sanfeliu ---
(In reply to Robert-André Mauchin from comment #1)
> All these things have been obsolete for years:
>
> # Do a systemd-based build from F-15; otherwise, a sysvinit-based build
> %global use_systemd %([ "(" 0%{?fedora} -gt 14 ")" -o "(" 0%{?rhel} -gt 6
> ")" ] && echo 1 || echo 0)
>
> # This macro only defined by default around Fedora 10 time
> %{!?_initddir:%global _initddir %{_initrddir}}
>
> # With systemd, the run directory is /run; otherwise it's /var/run
> %if %{use_systemd}
> %global rundir /run
> %else
> %global rundir %{_localstatedir}/run
> %endif
>
>
> F15? F10? Older than my nephew. Don't include them.
LOL, sorry. Removed.
> - Source must either be an url or you need to add a comment explaining how
> the archive got generated:
>
> Source0: %{name}-%{version}.tar.gz
Hmm ... if I put the line:
Source0:https://github.com/jcbf/smf-spf/archive/v2.4.3.tar.gz
then I get the following message:
# rpmbuild -ba smf-spf.spec
error: Bad source: /root/rpmbuild/SOURCES/v2.4.3.tar.gz: No such file or
directory
How/where should I include the URL?
> - Not needed:
>
> BuildRoot:%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
>
> Group:System Environment/Daemons
>
> rm -rf %{buildroot}
>
> %clean
> rm -rf %{buildroot}
>
>
> %defattr(-,root,root,-)
OK, removed.
> - Use the System scriptlets, see:
OK, done.
> - COPYING must be installed with %license, not %doc:
OK, done.
> - make %{?_smp_mflags} OPTFLAGS="%{optflags}"
>
> →
>
> %set_build_flags
Sorry, I don't understand this.
> - Add the comment regarding the patches above each PatchX line
OK, done.
> - Requires(pre): /usr/bin/getent, /usr/sbin/groupadd, /usr/sbin/useradd,
> /usr/sbin/usermod → Requires(pre): shadow-utils
OK, done.
> - One BR per line would be nice:
>
> BuildRequires:libspf2-devel >= 1.2.5
> BuildRequires:sendmail-milter-devel >= 8.12
OK, done.
> %make_build
>
> - Explicitly BR gcc
I don't understand this.
Refreshed files:
Spec URL: http://ftp.fibranet.cat/smf-spf/smf-spf.spec
SRPM URL: http://ftp.fibranet.cat/smf-spf/smf-spf-2.4.3-1.el8.src.rpm
Thank you very much.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881167] Review Request: mvel - MVFLEX Expression Language
https://bugzilla.redhat.com/show_bug.cgi?id=1881167 --- Comment #9 from Severin Gehwolf --- Other than the 2.3.2 vs. 2.4.10 (latest) issue, this seems fine to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881169] Review Request: lz4-java - LZ4 compression for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1881169 --- Comment #9 from Severin Gehwolf --- A couple of comments: 1. lz4-java seems to include lz4 itself (in the current form) 2. lz4 included in this spec also include xxhash 3. lz4[1] and xxhash[2] are available in Fedora themselves 4. If the spec was changed to use system xxhash and lz4, then what's left to compile with cpptasks is two JNI files. Consider compiling those manually and drop the build dependency on cpptasks. cpptasks seems seems largely dead upstream. No release since 2008. 5. Why are tests disabled? I'd try to run the tests during the build. 6. If you opt to include lz4 with lz4-java, then a 'Provides: bundled(lz4) = ' is needed. [1] https://koji.fedoraproject.org/koji/packageinfo?packageID=17099 Add BR: lz4-devel [2] https://koji.fedoraproject.org/koji/packageinfo?packageID=25457 Add BR: xxhash-devel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1552767] Review Request: godot - Multi-platform 2D and 3D game engine with a feature-rich editor
https://bugzilla.redhat.com/show_bug.cgi?id=1552767 Rémi Verschelde changed: What|Removed |Added Flags|needinfo?(rverschelde@gmail | |.com) | --- Comment #24 from Rémi Verschelde --- No I don't plan to package the Mono version. It has strict requirements on the way Mono is built (including patches), and distribution requirements which do not fit well with a system-wide installation. It also depends on some of the .NET stack which is not available in Fedora, such as msbuild or dotnet CLI. Use the version for godotengine.org if you want to use C#. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1552767] Review Request: godot - Multi-platform 2D and 3D game engine with a feature-rich editor
https://bugzilla.redhat.com/show_bug.cgi?id=1552767 Neko-san changed: What|Removed |Added CC||knight00...@gmail.com Flags||needinfo?(rverschelde@gmail ||.com) --- Comment #23 from Neko-san --- I'm new to Fedora; sorry if this is bad etiquette. I wanted to ask if I could request the official Godot-mono specifically to be added as well, since base Godot doesn't include C# support out of the box. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1883937] Review Request: perl-Term-Terminfo - Access the terminfo database
https://bugzilla.redhat.com/show_bug.cgi?id=1883937 Jitka Plesnikova changed: What|Removed |Added Status|NEW |ASSIGNED CC||jples...@redhat.com Assignee|nob...@fedoraproject.org|jples...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881169] Review Request: lz4-java - LZ4 compression for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1881169 Severin Gehwolf changed: What|Removed |Added Flags|fedora-review- |fedora-review? --- Comment #8 from Severin Gehwolf --- Same here, it's not been determined what the outcome of the review is. Let's keep it at '?' and move it to '+/-' once we have a clear picture. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881167] Review Request: mvel - MVFLEX Expression Language
https://bugzilla.redhat.com/show_bug.cgi?id=1881167 Severin Gehwolf changed: What|Removed |Added Flags|fedora-review- |fedora-review? --- Comment #8 from Severin Gehwolf --- Lets set fedora-review to '?' for neutrality. I wouldn't set it to '-' (basically saying not suitable for Fedora). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
