[Bug 1991202] Review Request: xpp3 - XML Pull Parser

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991202



--- Comment #3 from Stefan Bluhm  ---
Updated links:

Spec URL:
https://download.copr.fedorainfracloud.org/results/sbluhm/nodejs/epel-8-x86_64/02467915-xpp3/xpp3.spec

SRPM URL:
https://download.copr.fedorainfracloud.org/results/sbluhm/nodejs/epel-8-x86_64/02467915-xpp3/xpp3-1.1.4-28.c.el8.src.rpm

Change: Updated Maven links to https.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1991343] Review Request: omemo-utils - Utilities for OMEMO media sharing

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991343

Matthieu Saulnier  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Matthieu Saulnier  ---
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=73540001


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1991343] New: Review Request: omemo-utils - Utilities for OMEMO media sharing

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991343

Bug ID: 1991343
   Summary: Review Request: omemo-utils - Utilities for OMEMO
media sharing
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: cas...@casperlefantom.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://fantom.fedorapeople.org/omemo-utils.spec
SRPM URL: https://fantom.fedorapeople.org/omemo-utils-1.0.0-1.fc33.src.rpm
Description: Omut is a command-line utility for OMEMO media sharing.

It provides an easy way to encrypt a separate file like a document or
a picture, then you are able to send the data to your contacts (single
or multiple contacts at the same time).

This tool provides also a feature to decrypt a file sent by your
contact, by using the direct URL location of the encrypted file. URLs
are prefixed with aesgcm://

This package contains only the "omut" executable and the README for
documentation.

Fedora Account System Username: fantom


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


needinfo canceled: [Bug 1686307] Review Request: python-distributed - Distributed scheduler for Dask

2021-08-08 Thread bugzilla


Product: Fedora
Version: rawhide
Component: Package Review

Elliott Sales de Andrade  has canceled Package
Review 's request for Elliott Sales de
Andrade 's needinfo:
Bug 1686307: Review Request: python-distributed - Distributed scheduler for
Dask
https://bugzilla.redhat.com/show_bug.cgi?id=1686307



--- Comment #6 from Elliott Sales de Andrade  ---
Nearly working now; will post later today.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1686307] Review Request: python-distributed - Distributed scheduler for Dask

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1686307

Elliott Sales de Andrade  changed:

   What|Removed |Added

  Flags|needinfo?(quantum.analyst@g |
   |mail.com)   |



--- Comment #6 from Elliott Sales de Andrade  ---
Nearly working now; will post later today.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1723013] Review Request: mne-cpp - A Framework for Electrophysiology

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1723013



--- Comment #20 from Ben Beasley  ---
Note that a source RPM built on Fedora 33 or 34 works just fine as an input for
a Rawhide mock build; there’s no expectation that your source RPM has to have a
“.fc35” (soon “.fc36”) in its name.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1723013] Review Request: mne-cpp - A Framework for Electrophysiology

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1723013



--- Comment #19 from Ben Beasley  ---
(In reply to b38ghk29 from comment #18)
> Please advise as to the current version of fedora core in use for package
> testing/review.

Reviews are generally done using Rawhide, the development version of Fedora
Linux. Reviewers use the “fedora-review” tool to help find things that need a
second look, and you can run it too; it saves a lot of time if you’ve already
handled the issues that the tool can find automatically.

Rawhide is where an approved package would initially appear. You could then
request branches for other supported releases (f34, f33), or for EPEL
(epel8/epel7). See https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/.

You can do your development on another version, like Fedora 33 or 34, using
mock (https://github.com/rpm-software-management/mock/wiki). Some people even
use CentOS or RHEL. You’ll have the best results using a release that’s
currently receiving updates rather than one that’s end-of-life (Fedora 32 or
older).

Please see https://fedoraproject.org/wiki/Package_Review_Process and
https://fedoraproject.org/wiki/New_package_process_for_existing_contributors,
and https://fedoraproject.org/wiki/Join_the_package_collection_maintainers if
you are not yet a Fedora packager.

(The name “Fedora Core” was last used for Fedora Core 6, in 2006.)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1977229] Review Request: perl-Date-Range - Work with a range of dates

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1977229



--- Comment #16 from Fedora Update System  ---
FEDORA-2021-e3a72947fc has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2021-e3a72947fc \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-e3a72947fc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1977229] Review Request: perl-Date-Range - Work with a range of dates

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1977229



--- Comment #15 from Fedora Update System  ---
FEDORA-2021-7cebef36b5 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2021-7cebef36b5 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-7cebef36b5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1977229] Review Request: perl-Date-Range - Work with a range of dates

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1977229



--- Comment #14 from Fedora Update System  ---
FEDORA-EPEL-2021-09198bbd59 has been pushed to the Fedora EPEL 7 testing
repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-09198bbd59

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1977229] Review Request: perl-Date-Range - Work with a range of dates

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1977229



--- Comment #13 from Fedora Update System  ---
FEDORA-EPEL-2021-589df368c0 has been pushed to the Fedora EPEL 8 testing
repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-589df368c0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1979081



--- Comment #6 from Georg Sauthoff  ---
As I wrote in my initial posting:

> I started from a spec file generated by gem2rpm, but modified some 
> fields/sections where necessary.

I revisited it again, the rspec build-requires comes from my modified gem2rpm
fedora template. So, I take this back:

> Sure, but if a requirement is indeed superfluous on fedora, then gem2rpm 
> could filter it, i.e. when using a fedora template.

(since there is nothing to filter for gem2rpm)

This is also the reason why you see the different summary/description.

I still think that my summary/description is an improvement over the default
ones.

> ~~~
> Summary: Just allows you to upload gists
> ~~~
> Which to me seems good enough.

I disagree. If you don't already know what 'gists' are and that rubygem-gist
uploads to github, then it doesn't tell you much.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1979081



--- Comment #5 from Georg Sauthoff  ---
> Those are BuildRequires taken from gemspec, the maintainer should then decide 
> what makes sense to be included and what does not ;)

Sure, but if a requirement is indeed superfluous on fedora, then gem2rpm could
filter it, i.e. when using a fedora template.

However,

> This minimal patch should work
> ~~~
> -%if 0%{?fedora} < 34
> -BuildRequires: rubygem(ronn)
> -%else
> -BuildRequires: rubygem(ronn-ng)
> -%endif
> +BuildRequires: %{_bindir}/ronn
> ~~~

No, it doesn't work. With that change the build fails on Copr:

+ rspec spec
/var/tmp/rpm-tmp.UCjJBV: line 33: rspec: command not found

https://copr.fedorainfracloud.org/coprs/gsauthof/fedora/build/2454151/


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1979081



--- Comment #4 from Jarek Prokop  ---
(In reply to Georg Sauthoff from comment #3)
> Hm, the summary is pretty much what upstream provides:
> 
> rpm: Upload code to gist.github.com 
> upstream: upload code to https://gist.github.com
> 
> So this is from the upstream readme/man page.
> 
> Whereas the upstream help starts with another tag line:
> 
> > Gist (v#{Gist::VERSION}) lets you upload to https://gist.github.com/
> 
> However, I don't mind adding the https:// prefix to the RPM summary.

Hmm, fresh run of gem2rpm gives me:
~~~
Summary: Just allows you to upload gists
~~~
Which to me seems good enough.

and description:
~~~
%description
Provides a single function (Gist.gist) that uploads a gist.
~~~

JFTR the fresh specfile:
https://gist.github.com/jackorp/3e88a6abe5c5e57f933d6dc6130a1df2

IIRC both these values are taken from the gem's gemspec, which should be our
source of truth for these things (most of the time anyways).

> 
> The RPM description basically summarizes the README.md. I think it is a
> better summary than just copying the Synopsis from the README/man page
> because it describes additional key points while still keeping it very short.
> 
> 
> 
> I'll remove the vendored json and the superfluous rspec dependency.
> 
> FWIW, the rspec depedency comes from the gem2rpm template.

Those are BuildRequires taken from gemspec, the maintainer should then decide
what makes sense to be included and what does not ;)

>  I recommend querying upstream if they could include it in the built gem on 
> RubyGems.

Just found out it was removed on purpose.

https://github.com/defunkt/gist/commit/b58ff3eb9dd8403af3f801be0eafcb2eb6f4ab2a

But I think we can still take the generated manpage from upstream (if they are
current that is), which eases up on build dependencies and we don't have to
generate it ourselves.
(Writing it again, as I forgot that it should be a raw textfile) `Source1:
https://raw.githubusercontent.com/defunkt/gist/v6.0.0/build/gist.1`


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1991292] Review Request: rust-trash - Moving files and folders to the Recycle Bin

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991292



--- Comment #1 from Rémi Lauzier  ---
pr that fix some end-of-line encoding problem
https://github.com/ArturKovacs/trash-rs/pull/33


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1991292] Review Request: rust-trash - Moving files and folders to the Recycle Bin

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991292

Rémi Lauzier  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value
 Blocks||1991267
 CC||remilauz...@protonmail.com





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1991267
[Bug 1991267] rust-image-roll-1.3.1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1991292] New: Review Request: rust-trash - Moving files and folders to the Recycle Bin

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991292

Bug ID: 1991292
   Summary: Review Request: rust-trash - Moving files and folders
to the Recycle Bin
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: remilauz...@protonmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://download.copr.fedorainfracloud.org/results/remilauzier/trash/fedora-rawhide-x86_64/02452127-rust-trash/rust-trash.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/remilauzier/trash/fedora-rawhide-x86_64/02452127-rust-trash/rust-trash-2.0.1-1.fc35.src.rpm
Description: A library for moving files and folders to the Recycle Bin
Fedora Account System Username: remilauzier


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1979081



--- Comment #3 from Georg Sauthoff  ---
Hm, the summary is pretty much what upstream provides:

rpm: Upload code to gist.github.com 
upstream: upload code to https://gist.github.com

So this is from the upstream readme/man page.

Whereas the upstream help starts with another tag line:

> Gist (v#{Gist::VERSION}) lets you upload to https://gist.github.com/

However, I don't mind adding the https:// prefix to the RPM summary.


The RPM description basically summarizes the README.md. I think it is a better
summary than just copying the Synopsis from the README/man page because it
describes additional key points while still keeping it very short.



I'll remove the vendored json and the superfluous rspec dependency.

FWIW, the rspec depedency comes from the gem2rpm template.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1860688] Review Request: epic5 - irc client (currently retired)

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860688

Andy Mender  changed:

   What|Removed |Added

  Flags||needinfo?(p...@kobol.org)



--- Comment #8 from Andy Mender  ---
Any movement on this review request? Did you manage to find a sponsor? Or
should it be closed?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1350884



--- Comment #64 from Andy Mender  ---
Apologies for the massive delay on this. I would mark armhfp and s390x as no-go
platforms and proceed as is. Unfortunately, virtualized hardware doesn't always
cut it and as far as I know, the armhfp builds aren't always reliable due to
resource allocation constraints.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1111691] Review Request: qore - multithreaded programming/scripting language

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=691

Andy Mender  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|ASSIGNED|CLOSED
Last Closed||2021-08-08 20:38:30



--- Comment #55 from Andy Mender  ---
No updates for a long while. Closing as deadreview.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1888351] Review Request: python-volvooncall - Communicate with Volvo On Call

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1888351
Bug 1888351 depends on bug 1888345, which changed state.

Bug 1888345 Summary: Review Request: python-hbmqtt - MQTT client/broker
https://bugzilla.redhat.com/show_bug.cgi?id=1888345

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |WONTFIX




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1888345] Review Request: python-hbmqtt - MQTT client/broker

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1888345

Andy Mender  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2021-08-08 20:36:45



--- Comment #7 from Andy Mender  ---
Pagure repo created, but no RPMs uploaded. Closing as deadreview.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1896742] Review Request: python-radexreader - Reader for the RADEX RD1212 Geiger counter

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1896742

Andy Mender  changed:

   What|Removed |Added

 Status|POST|ASSIGNED



--- Comment #21 from Andy Mender  ---
Changing to ASSIGNED to hopefully unblock this.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1887970] Review Request: bats-support - Supporting library for Bats test helpers

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1887970

Andy Mender  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2021-08-08 20:33:37



--- Comment #3 from Andy Mender  ---
No response from submitter. Closing as deadreview.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1979081

Jarek Prokop  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #2 from Jarek Prokop  ---
if both packages provide the `ronn` binary, it is better to use `BuildRequires:
%{_bindir}/ronn`:
This minimal patch should work
~~~
-%if 0%{?fedora} < 34
-BuildRequires: rubygem(ronn)
-%else
-BuildRequires: rubygem(ronn-ng)
-%endif
+BuildRequires: %{_bindir}/ronn
~~~

  JFTR upstream provides man pages which could be used as additional source
instead like this: `Source1:
https://github.com/defunkt/%{gem_name}/blob/v%{version}/build/%{gem_name}.1`
  I recommend querying upstream if they could include it in the built gem on
RubyGems.

* The Summary and Descriptions seem to differ from the upstream, let's keep it
consistent with upstream.

* Vendored library `vendor/json.rb`
  - While upstream has a use-case for this we do not as it is for homebrew
users (AFAICT from the repo), the file should be deleted for distribution in
Fedora Linux.
  - There should probably be added a license header on that file and an
addition to the package's `License:` field if the file is kept in the resulting
RPM, since it looks like it was copied from merging 2 files from upstream Ruby:
https://github.com/flori/json/tree/master/lib/json/pure

And a small nit: 
* The `BuildRequires: rubygem(rspec) > 3` restricting condition is probably not
needed as Fedora in general ships rubygem-rspec > 3.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1982210] Review Request: shutter - GTK+3-based screenshot application written in Perl

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1982210



--- Comment #4 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/shutter.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/shutter-0.98-3.fc34.src.rpm

%changelog
* Sun Aug 08 2021 Martin Gansser  - 0.98-3
- Unbundle tango-icon-theme
- Add RR tango-icon-theme


rpmlint -v shutter.spec /home/martin/rpmbuild/SRPMS/shutter-0.98-3.fc34.src.rpm
/home/martin/rpmbuild/RPMS/noarch/shutter-0.98-3.fc34.noarch.rpm
shutter.spec: I: checking
shutter.spec: I: checking-url
https://github.com/shutter-project/shutter/archive/v0.98.tar.gz#/shutter-0.98.tar.gz
(timeout 10 seconds)
shutter.src: I: checking
shutter.src: I: checking-url https://shutter-project.org/ (timeout 10 seconds)
shutter.src: I: checking-url
https://github.com/shutter-project/shutter/archive/v0.98.tar.gz#/shutter-0.98.tar.gz
(timeout 10 seconds)
shutter.noarch: I: checking
shutter.noarch: I: checking-url https://shutter-project.org/ (timeout 10
seconds)
shutter.noarch: W: cross-directory-hard-link /usr/share/pixmaps/shutter.png
/usr/share/icons/hicolor/48x48/apps/shutter.png
shutter.noarch: W: cross-directory-hard-link
/usr/share/shutter/resources/icons/drawing_tool/draw-image.svg
/usr/share/shutter/resources/icons/Image.svg
shutter.noarch: W: cross-directory-hard-link
/usr/share/shutter/resources/icons/drawing_tool/objects/Cursors/Normal.cur
/usr/share/shutter/resources/icons/Normal.cur
shutter.noarch: W: dangling-symlink
/usr/share/shutter/resources/icons/drawing_tool/objects/Tango
/usr/share/icons/Tango/scalable
shutter.noarch: E: invalid-lc-messages-dir
/usr/share/locale/ber/LC_MESSAGES/shutter.mo
2 packages and 1 specfiles checked; 1 errors, 4 warnings.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1991202] Review Request: xpp3 - XML Pull Parser

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991202



--- Comment #2 from Stefan Bluhm  ---
Thank you for your feedback. I will incorporate the https in the next revision.
Homepage is indeed dead. there is an alternative github page but it is not
official. So I rather not put that.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1977229] Review Request: perl-Date-Range - Work with a range of dates

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1977229



--- Comment #11 from Fedora Update System  ---
FEDORA-2021-e3a72947fc has been submitted as an update to Fedora 33.
https://bodhi.fedoraproject.org/updates/FEDORA-2021-e3a72947fc


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1977229] Review Request: perl-Date-Range - Work with a range of dates

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1977229



--- Comment #10 from Fedora Update System  ---
FEDORA-EPEL-2021-589df368c0 has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-589df368c0


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1977229] Review Request: perl-Date-Range - Work with a range of dates

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1977229



--- Comment #12 from Fedora Update System  ---
FEDORA-2021-7cebef36b5 has been submitted as an update to Fedora 34.
https://bodhi.fedoraproject.org/updates/FEDORA-2021-7cebef36b5


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1991202] Review Request: xpp3 - XML Pull Parser

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991202

Didik Supriadi  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value
 CC||didiksupriad...@gmail.com



--- Comment #1 from Didik Supriadi  ---
Hi,
I notice the URL to repo1.maven.org must use HTTPS to be able to connect to the
pom files.
And also extreme.indiana.edu domain has been expired.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1979081

Jarek Prokop  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jpro...@redhat.com
 CC||jpro...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Jarek Prokop  ---
Taking this for a review.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1977229] Review Request: perl-Date-Range - Work with a range of dates

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1977229

Paul Howarth  changed:

   What|Removed |Added

 Resolution|--- |RAWHIDE
 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Date-Range-1.41-2.fc35
Last Closed||2021-08-08 10:35:34



--- Comment #9 from Paul Howarth  ---
Build done for Rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=73444308


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1991208] New: Review Request: pluma-plugins - Modules for the pluma text editor

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991208

Bug ID: 1991208
   Summary: Review Request: pluma-plugins - Modules for the pluma
text editor
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@raveit.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://raveit65.fedorapeople.org/Mate/Specs/pluma-plugins.spec
SRPM URL:
https://raveit65.fedorapeople.org/Mate/SRPM/1.26/pluma-plugins-1.26.0-1.fc34.src.rpm
Description: Modules for the pluma text editor
Fedora Account System Username: raveit65


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1348932] Review Request: bash-git-prompt - An informative and fancy bash prompt for Git users

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1348932

Didik Supriadi  changed:

   What|Removed |Added

Version|33  |rawhide



--- Comment #17 from Didik Supriadi  ---
You still need to find a sponsor. 

You can find a sponsor here: https://docs.pagure.org/fedora-sponsors/
Here's the tips how to get sponsored:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1348932] Review Request: bash-git-prompt - An informative and fancy bash prompt for Git users

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1348932

Didik Supriadi  changed:

   What|Removed |Added

  Flags||fedora-review?
 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|didiksupriad...@gmail.com



--- Comment #16 from Didik Supriadi  ---
> License:BSD-2-Clause

This is true but it must be filled with its short name.
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names
See https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses

> Source0:
> https://github.com/magicmonty/%{name}/archive/%{name}-%{version}.tar.gz

Invalid URL.
To correctly reference the source, See
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

> %post
> # enable bash-git-prompt
> cat << EOF >> /etc/bashrc
> %{START_TOKEN}
> if [ -f %{_datadir}/%{name}/gitprompt.sh ]; then
> # Set config variables first
>
> GIT_PROMPT_ONLY_IN_REPO=1
> GIT_PROMPT_THEME=Default
> source %{_datadir}/%{name}/gitprompt.sh
> fi
> %{END_TOKEN}
> EOF
>
> %postun
> # remove bash-git-prompt setup
> sed -i -e '/^%{START_TOKEN}/, /^%{END_TOKEN}/{d}' /etc/bashrc

You should not edit the file that you don't own.

> files
> %defattr(-,root,root,-)

This is not needed anymore.
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions

> install -pm 644 README.md %{buildroot}%{_datadir}/%{name}

README already in %doc, right?

> * Sat Mar 31 2018 Koustubh Sinkar 
> - Making the spec file more standards compliant
> - support for new lines
> 
> * Tue Jun 28 2016 Koustubh Sinkar 
> - Updating the spec file to reflect more recent changes

You should write the version in changelog.
See https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1991202] New: Review Request: xpp3 - XML Pull Parser

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991202

Bug ID: 1991202
   Summary: Review Request: xpp3 - XML Pull Parser
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: redhat@bluhm-de.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://download.copr.fedorainfracloud.org/results/sbluhm/nodejs/epel-8-x86_64/02365568-xpp3/xpp3.spec

SRPM URL:
https://download.copr.fedorainfracloud.org/results/sbluhm/nodejs/epel-8-x86_64/02365568-xpp3/xpp3-1.1.4-27.c.el8.src.rpm

Description: XML Pull Parser 3rd Edition (XPP3) MXP1 is an XmlPull 
parsing engine that is based on ideas from XPP and in particular XPP2 but
completely revised and rewritten.

Fedora Account System Username: sbluhm

Additional information: Package already existed but has been orphaned.

Primary aim: Required in EPEL8 repository for xstream package and Uyuni
solutions.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1991092] Review Request: nodejs-diagnostic-language-server - Diagnostic language server that integrate with linters

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991092

Sahana Prasad  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1991092] Review Request: nodejs-diagnostic-language-server - Diagnostic language server that integrate with linters

2021-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1991092

Sahana Prasad  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure