[Bug 2161003] Review Request: pyjwkest - Python implementation of JWT, JWE, JWS and JWK
https://bugzilla.redhat.com/show_bug.cgi?id=2161003 --- Comment #6 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5350114 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161003-pyjwkest/fedora-rawhide-x86_64/05350114-python-pyjwkest/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161003 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161003] Review Request: pyjwkest - Python implementation of JWT, JWE, JWS and JWK
https://bugzilla.redhat.com/show_bug.cgi?id=2161003 --- Comment #5 from lichaoran --- > You can do this if you prefer. But the general practice is adding the > new ... > lines to the new comment. New uploads now @Jakub Kadlčík: Spec URL: https://github.com/pkking/oidc-in-fedora/raw/main/pyjwkest/python-pyjwkest.spec SRPM URL: https://github.com/pkking/oidc-in-fedora/raw/main/pyjwkest/python-pyjwkest-1.4.2-1.fc37.src.rpm > You can remove this comment as well :-) Done. > Did you update both the spec file and the SRPM? I suspect you forgot > to upload the new spec file because I am seeing some of the previous > errors, like this You are right, forget to update the SRPM :-) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161003 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2121759] Review Request:python-reactivex - ReactiveX (Rx) for Python
https://bugzilla.redhat.com/show_bug.cgi?id=2121759
Troy Curtis changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #7 from Troy Curtis ---
I suppose either way is imperfect. The two sources method just seems more
likely to mix code which might not actually be the same release, as it relies
mostly on the intention/convention versus any explicit relationship. Presumably
upstream has the the right automation in place to make sure tarballs in the two
places are the same thing. Regardless, the package looks good. Approved! Sorry
for taking so long, I forgot this was back in my court!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT License", "*No copyright* MIT License", "Unknown or
generated". 379 files have unknown license. Detailed output of
licensecheck in
/home/troycurtisjr/working/oss/fedora/reviews/2121759-python-
reactivex/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager
[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python
https://bugzilla.redhat.com/show_bug.cgi?id=2161739 Fabio Valentini changed: What|Removed |Added Depends On|2061101 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2061101 [Bug 2061101] rust-pyo3-0.18.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161739 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161112] Review Request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.redhat.com/show_bug.cgi?id=2161112 --- Comment #11 from Fedora Update System --- FEDORA-2023-282158d26e has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-282158d26e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-282158d26e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161112 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161112] Review Request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.redhat.com/show_bug.cgi?id=2161112 --- Comment #10 from Fedora Update System --- FEDORA-2023-2295b35268 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-2295b35268 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-2295b35268 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161112 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161942] Review Request: bind9-next - The Berkeley Internet Name Domain (BIND) DNS (Domain Name System) server
https://bugzilla.redhat.com/show_bug.cgi?id=2161942 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #24 from Fedora Update System --- FEDORA-EPEL-2023-116ae883fe has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-116ae883fe See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161942 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161112] Review Request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.redhat.com/show_bug.cgi?id=2161112 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- FEDORA-EPEL-2023-11bb7b880d has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-11bb7b880d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161112 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165224] Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections
https://bugzilla.redhat.com/show_bug.cgi?id=2165224 --- Comment #4 from h-k...@hotmail.com --- > I forgot to add: We already use cargo-c for building rav1e (an AV1 encoder > library). > It might be helpful to look at its spec file to see how to use cargo-c for > Fedora RPM builds: > https://src.fedoraproject.org/rpms/rust-rav1e/blob/rawhide/f/rust-rav1e.spec#_543-560 Thanks for the tip!! Much appreciated since I am still new to the packaging scene :D. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165224 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161003] Review Request: pyjwkest - Python implementation of JWT, JWE, JWS and JWK
https://bugzilla.redhat.com/show_bug.cgi?id=2161003 Neil Hanlon changed: What|Removed |Added Depends On||2161156 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2161156 [Bug 2161156] Review Request: - -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161003 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161156] Review Request: -
https://bugzilla.redhat.com/show_bug.cgi?id=2161156 Neil Hanlon changed: What|Removed |Added CC||n...@shrug.pw Blocks||2161003 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2161003 [Bug 2161003] Review Request: pyjwkest - Python implementation of JWT, JWE, JWS and JWK -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161156 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2151289] Review Request: numberstation - TOTP Authenticator application
https://bugzilla.redhat.com/show_bug.cgi?id=2151289 Petr Menšík changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #9 from Petr Menšík --- It seems okay now, passing the review. Please follow steps described in: https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/ to get sponsored. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2151289 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161164] Review Request: importlib-resources -
https://bugzilla.redhat.com/show_bug.cgi?id=2161164 Neil Hanlon changed: What|Removed |Added Blocks||2161163 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2161163 [Bug 2161163] Review Request: flask-pyoidc - -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161164 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161156] Review Request: -
https://bugzilla.redhat.com/show_bug.cgi?id=2161156 Neil Hanlon changed: What|Removed |Added Blocks||2161163 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2161163 [Bug 2161163] Review Request: flask-pyoidc - -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161156 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161163] Review Request: flask-pyoidc -
https://bugzilla.redhat.com/show_bug.cgi?id=2161163 Neil Hanlon changed: What|Removed |Added Whiteboard||NotReady CC||n...@shrug.pw Doc Type|--- |If docs needed, set a value Depends On||2161156, 2161164 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2161156 [Bug 2161156] Review Request: - https://bugzilla.redhat.com/show_bug.cgi?id=2161164 [Bug 2161164] Review Request: importlib-resources - -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161163 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161337] Review Request: python-types-python-dateutil - Typing stubs for dateutil
https://bugzilla.redhat.com/show_bug.cgi?id=2161337 --- Comment #6 from Neil Hanlon --- oops. I apologize, i didn't read the whole discussion before taking. Still happy to take this as my first review if it is necessary. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161337 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161337] Review Request: python-types-python-dateutil - Typing stubs for dateutil
https://bugzilla.redhat.com/show_bug.cgi?id=2161337 Neil Hanlon changed: What|Removed |Added CC||n...@shrug.pw Assignee|nob...@fedoraproject.org|n...@shrug.pw -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161337 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161519] Review Request: python-ypy-websocket - WebSocket connector for Ypy
https://bugzilla.redhat.com/show_bug.cgi?id=2161519 --- Comment #3 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ypy-websocket -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161519 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165224] Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections
https://bugzilla.redhat.com/show_bug.cgi?id=2165224 --- Comment #3 from Fabio Valentini --- I forgot to add: We already use cargo-c for building rav1e (an AV1 encoder library). It might be helpful to look at its spec file to see how to use cargo-c for Fedora RPM builds: https://src.fedoraproject.org/rpms/rust-rav1e/blob/rawhide/f/rust-rav1e.spec#_543-560 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165224 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165224] Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections
https://bugzilla.redhat.com/show_bug.cgi?id=2165224 Fabio Valentini changed: What|Removed |Added Flags||fedora-review+ Assignee|nob...@fedoraproject.org|decatho...@gmail.com Status|NEW |POST CC||decatho...@gmail.com Doc Type|--- |If docs needed, set a value --- Comment #2 from Fabio Valentini --- Oh, another library that was rewritten from C in Rust. :D Reading the upstream README, I recommend that use use cargo-c to build the shared library. In my experience, it is the least painful option for building C-style shared libraries, especially because it handles setting SONAME and generating headers and pkg-config files. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Once releng has processed the unretirement, please also request an f37 branch for this package. It makes it much easier for Rust SIG members to update things if there's not "holes" (i.e. this package would be present in rawhide and f36, but not f37, which would be weird). I also recommend to re-enable tracking for the package in koschei for the rawhide and f37 branches once they have been created. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2165224 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2164882] Review Request: python3-pyrate_limiter - The request rate limiter using Leaky-bucket algorithm.
https://bugzilla.redhat.com/show_bug.cgi?id=2164882
--- Comment #6 from Steve Cossette ---
Thanks for all the work, I'm guessing it wasn't easy to investigate all of
this. I'm still new to packaging python packages.
I applied all your changes and refreshed the sources. Building on f37 works,
but when I build on rawhide using fedora-review, python tests fail with this:
=== FAILURES
===
__ test_concurrency[ProcessPoolExecutor-SQLiteBucket]
__
concurrent.futures.process._RemoteTraceback:
"""
Traceback (most recent call last):
File "/usr/lib64/python3.11/concurrent/futures/process.py", line 256, in
_process_worker
r = call_item.fn(*call_item.args, **call_item.kwargs)
^
File "/usr/lib64/python3.11/concurrent/futures/process.py", line 205, in
_process_chunk
return [fn(*args) for args in chunk]
^
File "/usr/lib64/python3.11/concurrent/futures/process.py", line 205, in
return [fn(*args) for args in chunk]
^
File
"/builddir/build/BUILD/PyrateLimiter-103252ca8d5336dc19b69fda6b65798eac932fd2/tests/test_concurrency.py",
line 75, in _send_request
with limiter.ratelimit(*bucket_ids, delay=True):
File
"/builddir/build/BUILD/PyrateLimiter-103252ca8d5336dc19b69fda6b65798eac932fd2/pyrate_limiter/limit_context_decorator.py",
line 66, in __enter__
self.delayed_acquire()
File
"/builddir/build/BUILD/PyrateLimiter-103252ca8d5336dc19b69fda6b65798eac932fd2/pyrate_limiter/limit_context_decorator.py",
line 82, in delayed_acquire
self.try_acquire()
File
"/builddir/build/BUILD/PyrateLimiter-103252ca8d5336dc19b69fda6b65798eac932fd2/pyrate_limiter/limiter.py",
line 92, in try_acquire
volume = bucket.size()
^
File
"/builddir/build/BUILD/PyrateLimiter-103252ca8d5336dc19b69fda6b65798eac932fd2/pyrate_limiter/sqlite_bucket.py",
line 95, in size
self._size = self._query_size()
^^
File
"/builddir/build/BUILD/PyrateLimiter-103252ca8d5336dc19b69fda6b65798eac932fd2/pyrate_limiter/sqlite_bucket.py",
line 100, in _query_size
return self.connection.execute(f"SELECT COUNT(*) FROM
{self.table}").fetchone()[0]
^^^
File
"/builddir/build/BUILD/PyrateLimiter-103252ca8d5336dc19b69fda6b65798eac932fd2/pyrate_limiter/sqlite_bucket.py",
line 73, in connection
self._connection.execute(
sqlite3.OperationalError: database is locked
"""
The above exception was the direct cause of the following exception:
executor_class =
bucket_class =
@pytest.mark.parametrize("bucket_class", [SQLiteBucket])
@pytest.mark.parametrize("executor_class", [ThreadPoolExecutor,
ProcessPoolExecutor])
def test_concurrency(executor_class, bucket_class):
"""Make a fixed number of concurrent requests using a shared Limiter,
and check the total time
they take to run
"""
logger.info(f"Testing {bucket_class.__name__} with
{executor_class.__name__}")
# Set up limiter
bucket_kwargs = {
"path": join(gettempdir(),
f"test_{executor_class.__name__}.sqlite"),
}
limiter = Limiter(
RequestRate(LIMIT_REQUESTS_PER_SECOND, Duration.SECOND),
bucket_class=bucket_class,
bucket_kwargs=bucket_kwargs,
)
# Set up request function
bucket_ids = [f"{executor_class.__name__}_bucket_{i}" for i in
range(N_BUCKETS)]
start_time = perf_counter()
request_func = partial(_send_request, limiter, bucket_ids, start_time)
# Distribute requests across workers
with executor_class(max_workers=N_WORKERS) as executor:
> list(executor.map(request_func, range(N_REQUESTS), timeout=300))
tests/test_concurrency.py:57:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/usr/lib64/python3.11/concurrent/futures/process.py:597: in
_chain_from_iterable_of_lists
for element in iterable:
/usr/lib64/python3.11/concurrent/futures/_base.py:621: in result_iterator
yield _result_or_cancel(fs.pop(), end_time - time.monotonic())
/usr/lib64/python3.11/concurrent/futures/_base.py:317: in _result_or_cancel
return fut.result(timeout)
/usr/lib64/python3.11/concurrent/futures/_base.py:449: in result
return self.__get_result()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = None
def __get_result(self):
if self._exception:
try:
> raise self._exception
E sqlite3.OperationalError: database is locked
/usr/lib64/python3.11/concurrent/futures/_base.py:401: OperationalError
- Captured stderr call
-
INFO:pyrate_limiter.tests:Testing SQLiteBucket with ProcessPoolExecutor
-- Captured log call
--
[Bug 2164882] Review Request: python3-pyrate_limiter - The request rate limiter using Leaky-bucket algorithm.
https://bugzilla.redhat.com/show_bug.cgi?id=2164882 Steve Cossette changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://api.nicehomeservices.com/images/temp/python-pyrate-limiter.spec SRPM URL: https://api.nicehomeservices.com/images/temp/python-pyrate-limiter-2.8.5-1.fc37.src.rpm Description: The request rate limiter using Leaky-bucket algorithm. Fedora Account System Username: farchord -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2164882 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2134972] Review Request: sdubby - shimming utilities for systemd-boot, like grubby
https://bugzilla.redhat.com/show_bug.cgi?id=2134972
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
CC||zbys...@in.waw.pl
--- Comment #12 from Zbigniew Jędrzejewski-Szmek ---
Sorry, but this package seems like a step in the wrong direction.
It hardcodes too many things and in general seems like trying to repeat the way
that things were done in the past.
The package does two things:
1. It provides /boot/efi/loader/entries.srel
2. It provides /sbin/updateloaderentries.sh
Re 1: This is a fixed path. We should be adding any more packages that contain
*any* files under /boot or /efi. Those shouldn't be managed by rpm, but instead
by boot loader installation tools that take into account the state of the
system. A user should be allowed to install a package and if things are not
configured so, the package should not modify the system. Thus, we shouldn't
have files in those paths as rpm payload.
Also, it really seems easy enough to do
`pathlib.Path('…').write_text('type1')`, no need to this via the package
manager.
Also, this hardcodes /boot/efi as the path. We have machinery to detect the
location of the EFI partition dynamically instead.
Also, the package has Conflicts:grubby, and grubby is depended-on
(transitively) by many packages, so this would prevent this package from being
installed, or grubby from being installed. It's much better to avoid Conflicts,
and instead allow packages to be installed together, and DTRT depending on the
state of the system. See first para above.
Re 2:
> /usr/bin/ln -s /usr/bin/kernel-install /sbin/installkernel
This seems very wrong. Stuff like this should be part of the package payload.
I see that grubby has a script there, that generally completely ignores the
kernel-install machinery that the rest of the distro uses. AFAIK, installkernel
is used by kernel's make install, so it's not directly related to the changes
in Anaconda. If you think we should have this symlink, let's drop the old file
from grubby and add the symlink to systemd-udev.rpm.
> /usr/bin/awk -i inplace "$fixcmdline" /boot/efi/loader/entries/*
Yikes. That just seems so complicated: Anaconda → bash → updateloaderentries.sh
→ awk.
Instead of "fixing up" entries after the fact, let's not write broken entries
in the first place. The thing that writes those entries should do stripping.
And really, it's much nicer to have a few clean lines of Python code than go
through three layers to do some awk.
Please don't introduce this package. Instead of adding workarounds for
brokenness or missing functionality in other places, let's fix the original
issue. This is all free software under our control.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2134972
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165224] Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections
https://bugzilla.redhat.com/show_bug.cgi?id=2165224 --- Comment #1 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5344965 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2165224-rust-fallible_collections/fedora-rawhide-x86_64/05344965-rust-fallible_collections/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2165224 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2165224] New: Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections
https://bugzilla.redhat.com/show_bug.cgi?id=2165224 Bug ID: 2165224 Summary: Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: h-k...@hotmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/blinxen/rust-fallible_collections/fedora-37-x86_64/05344958-rust-fallible_collections/rust-fallible_collections.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/blinxen/rust-fallible_collections/fedora-37-x86_64/05344958-rust-fallible_collections/rust-fallible_collections-0.4.6-1.fc37.src.rpm Description: Implement Fallible collections on allocation errors, quite as describe in RFC 2116. This was used in the turbofish OS hobby project to mitigate the lack of faillible allocation in rust. Fedora Account System Username: blinxen The purpose of this package review is to unretire the fallible_collections crate. See https://pagure.io/releng/issue/11245. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2165224 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2164882] Review Request: python3-pyrate_limiter - The request rate limiter using Leaky-bucket algorithm.
https://bugzilla.redhat.com/show_bug.cgi?id=2164882
--- Comment #5 from Ben Beasley ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= Issues =
- This is not needed and should be removed:
BuildRequires: python3-setuptools
- The Summary should not end with a period:
Summary:The request rate limiter using Leaky-bucket algorithm.
This is flagged by rpmlint:
python-pyrate_limiter.src: W: summary-ended-with-dot The request rate
limiter using Leaky-bucket algorithm.
python3-PyrateLimiter.noarch: W: summary-ended-with-dot The request rate
limiter using Leaky-bucket algorithm.
- The LICENSE file installed directly in site-packages is an upstream packaging
error and should be removed. Try:
%install
%pyproject_install
%pyproject_save_files pyrate_limiter
# LICENSE file is installed directly in site-packages
# https://github.com/vutran1710/PyrateLimiter/issues/92
rm '%{buildroot}%{python3_sitelib}/LICENSE'
and omit from %files:
%{python3_sitelib}/LICENSE
- You should add:
%doc CHANGELOG.md
- A nicer source URL would be:
Source0:
https://github.com/vutran1710/PyrateLimiter/archive/v%{version}/PyrateLimiter-%{version}.tar.gz
which, if you liked, you could shorten to:
Source0:%{url}/archive/v%{version}/PyrateLimiter-%{version}.tar.gz
- The package SHOULD be named using the canonical project name:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_library_naming
In this case, that means the base package really ought to be
python-pyrate-limiter instead of python-pyrate_limiter, and the subpackage
for the binary RPM should be python3-pyrate-limiter instead of
python3-PyrateLimiter.
- Wherever possible, you should have metapackages for the Extras:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Extras
You would use:
%pyproject_buildrequires -x all
and add:
%pyproject_extras_subpkg -n python3-pyrate-limiter all
However, in this case redis is pinned to an old version and redis-py-cluster
is not packaged, so you don’t actually need to change anything. At most, you
might add a comment about the dependency problem.
Problem 1: nothing provides requested (python3dist(redis) < 4~~ with
python3dist(redis) >= 3.3)
Problem 2: nothing provides requested (python3dist(redis-py-cluster) < 3~~
with python3dist(redis-py-cluster) >= 2.1.3)
- We can run the upstream tests.
I added:
# Test dependencies, taken from [tool.poetry.dev-dependencies]:
#
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters
# Don’t BR: coverage, flake8_polyfill, pre-commit, pytest-cov.
#
# We use pytest directly, so we don’t need: nox, nox-poetry
#
# Upstream runs tests in parallel, but we find there are race conditions;
# therefore, we do not need: pytest-xdist
#
# These appear to be unused: logzero, PyYAML, schedule
# Since we can only work with what’s packaged, let’s convert SemVer pins to
# lower bounds for test dependencies, dealing with possible future test
# failures if and when they happen.
# Django = "^3.2.8"
BuildRequires: %{py3_dist Django} >= 3.2.8
# django-redis = "^5.0.0"
# Currently too old:
# https://bugzilla.redhat.com/show_bug.cgi?id=1445556
# BuildRequires: %%{py3_dist django-redis} >= 5
# fakeredis = "^1.1.0"
# Not yet packaged:
# BuildRequires: %%{py3_dist fakeredis} >= 1.1
# pytest = "^6.2"
BuildRequires: %{py3_dist pytest} >= 6.2
# pytest-asyncio = "^0.12"
BuildRequires: %{py3_dist pytest-asyncio} >= 0.12
Then I replaced:
%pyproject_check_import pyrate_limiter
with:
# Needs python3dist(fakeredis)
ignore="${ignore-} --ignore=tests/test_02.py"
# Needs python3dist(django-redis)
ignore="${ignore-} --ignore=tests/test_with_django.py"
%pytest -v ${ignore-}
I also needed a patch:
# Allow for sleep to be called more times than expected
# https://github.com/vutran1710/PyrateLimiter/pull/93
Patch: %{url}/pull/93.patch
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests
- You can package the latest version even without the git tag:
Version:2.8.5
Release:1%{?dist}
and
# Missing git tag:
# Build on pypi is not on github?
# https://github.com/vutran1710/PyrateLimiter/issues/91
# It is clear which commit corresponds to the PyPI release. We eschew the
# snapinfo field that would normally be needed for packaging from a
particular
# commit, since this is equivalent to packaging from the missing tag.
%global commit 103252ca8d5336dc19b69fda6b65798eac932fd2
Source0:%{url}/archive/%{commit}/PyrateLimiter-%{commit}.tar.gz
and
%autosetup -p1 -n PyrateLimiter-%{commit}
= MUST items =
Generic:
[x]: Pa
[Bug 2163518] Review Request: python-r128gain - Fast audio loudness scanner & tagger
https://bugzilla.redhat.com/show_bug.cgi?id=2163518 Bug 2163518 depends on bug 2161095, which changed state. Bug 2161095 Summary: Review Request: python-ffmpeg-python - Python bindings for FFmpeg https://bugzilla.redhat.com/show_bug.cgi?id=2161095 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2163518 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161095] Review Request: python-ffmpeg-python - Python bindings for FFmpeg
https://bugzilla.redhat.com/show_bug.cgi?id=2161095 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|MODIFIED|CLOSED Last Closed||2023-01-28 13:55:47 --- Comment #18 from Fedora Update System --- FEDORA-2023-771e7b785d has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161095 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161095] Review Request: python-ffmpeg-python - Python bindings for FFmpeg
https://bugzilla.redhat.com/show_bug.cgi?id=2161095 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #17 from Fedora Update System --- FEDORA-2023-771e7b785d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-771e7b785d -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161095 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161095] Review Request: python-ffmpeg-python - Python bindings for FFmpeg
https://bugzilla.redhat.com/show_bug.cgi?id=2161095 --- Comment #16 from Ondrej Mosnáček --- (In reply to Neal Gompa from comment #14) > Review notes: > > * Package follows general packaging guidelines > * Package follows Python packaging guidelines > * Package builds and installs > * No serious issues from rpmlint Thanks for the review! > Something to consider: maybe rework the upstream tests to use Free codecs > like VP9 and Opus on WebM rather than H264 and AAC on MP4. That way you can > turn them on later. :) Yeah, I do tend to tinker with tests, so it's likely I will get to that eventually :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161095 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161095] Review Request: python-ffmpeg-python - Python bindings for FFmpeg
https://bugzilla.redhat.com/show_bug.cgi?id=2161095 --- Comment #15 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ffmpeg-python -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161095 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161095] Review Request: python-ffmpeg-python - Python bindings for FFmpeg
https://bugzilla.redhat.com/show_bug.cgi?id=2161095 Neal Gompa changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ |needinfo?(ngomp...@gmail.co | |m) | --- Comment #14 from Neal Gompa --- Review notes: * Package follows general packaging guidelines * Package follows Python packaging guidelines * Package builds and installs * No serious issues from rpmlint Something to consider: maybe rework the upstream tests to use Free codecs like VP9 and Opus on WebM rather than H264 and AAC on MP4. That way you can turn them on later. :) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161095 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161095] Review Request: python-ffmpeg-python - Python bindings for FFmpeg
https://bugzilla.redhat.com/show_bug.cgi?id=2161095 Ondrej Mosnáček changed: What|Removed |Added Flags||needinfo?(ngomp...@gmail.co ||m) --- Comment #13 from Ondrej Mosnáček --- @ngomp...@gmail.com Gentle ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161095 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161519] Review Request: python-ypy-websocket - WebSocket connector for Ypy
https://bugzilla.redhat.com/show_bug.cgi?id=2161519
Miro Hrončok changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
Status|ASSIGNED|POST
--- Comment #2 from Miro Hrončok ---
Spec sanity
===
I've tried adding this:
BuildRequires: /usr/bin/node
...
%prep
...
# Problem with tests reported
# https://github.com/y-crdt/ypy-websocket/issues/62
# Workaround:
sed -i '0,/@pytest.fixture/{s/@pytest.fixture/import
pytest_asyncio\n@pytest_asyncio.fixture/}' tests/conftest.py
But the tests still fail with:
node:internal/modules/cjs/loader:1042
throw err;
^
Error: Cannot find module 'yjs'
Require stack:
- /builddir/build/BUILD/ypy_websocket-0.8.2/tests/yjs_client_1.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1039:15)
at Module._load (node:internal/modules/cjs/loader:885:27)
at Module.require (node:internal/modules/cjs/loader:1105:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object.
(/builddir/build/BUILD/ypy_websocket-0.8.2/tests/yjs_client_1.js:1:11)
at Module._compile (node:internal/modules/cjs/loader:1218:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
at Module.load (node:internal/modules/cjs/loader:1081:32)
at Module._load (node:internal/modules/cjs/loader:922:12)
at Function.executeUserEntryPoint [as runMain]
(node:internal/modules/run_main:81:12) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/builddir/build/BUILD/ypy_websocket-0.8.2/tests/yjs_client_1.js' ]
}
This makes me think the comment in %check should be:
%check
# test_ypy_yjs.py requires https://www.npmjs.com/package/yjs
%pytest --ignore=tests/test_ypy_yjs.py
And the @pytest_asyncio.fixture problem is moot.
> BuildRequires: python3-pytest
> BuildRequires: python3-pytest-asyncio
> BuildRequires: python3-websockets
There is a [test] extra, but it also has mypy and pre-commit. I suggest working
with upstream to split mypy and pre-commit to a lint extra and autogenerate the
tests dependencies. If not worth your time (which frankly probably isn't),
let's add a comment above those BRs so others know why they are manual instead,
please.
The spec is sane.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT License", "Unknown or generated". 15 files have unknown
license. Detailed output of licensecheck in
/home/churchyard/rpmbuild/FedoraReview/2161519-python-ypy-
websocket/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in
[Bug 2161113] Review Request: libopenshot - Library for creating and editing videos
https://bugzilla.redhat.com/show_bug.cgi?id=2161113 Benson Muite changed: What|Removed |Added Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #3 from Benson Muite --- Thanks. Will do. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161113 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161519] Review Request: python-ypy-websocket - WebSocket connector for Ypy
https://bugzilla.redhat.com/show_bug.cgi?id=2161519 Miro Hrončok changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mhron...@redhat.com Status|NEW |ASSIGNED Flags||fedora-review? CC||mhron...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161519 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161520] Review Request: python-jupyter-ydoc - Document structures for collaborative editing using Ypy
https://bugzilla.redhat.com/show_bug.cgi?id=2161520 Bug 2161520 depends on bug 2161518, which changed state. Bug 2161518 Summary: Review Request: python-y-py - Python bindings for the Y-CRDT built from yrs (Rust) https://bugzilla.redhat.com/show_bug.cgi?id=2161518 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161520 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161518] Review Request: python-y-py - Python bindings for the Y-CRDT built from yrs (Rust)
https://bugzilla.redhat.com/show_bug.cgi?id=2161518 Miro Hrončok changed: What|Removed |Added Fixed In Version||python-y-py-0.5.5-1.fc38 Resolution|--- |RAWHIDE Status|POST|CLOSED Last Closed||2023-01-28 10:50:34 --- Comment #46 from Miro Hrončok --- $ koji wait-repo f38-build --build python-y-py-0.5.5-1.fc38 Successfully waited 0:00 for python-y-py-0.5.5-1.fc38 to appear in the f38-build repo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161518 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161519] Review Request: python-ypy-websocket - WebSocket connector for Ypy
https://bugzilla.redhat.com/show_bug.cgi?id=2161519 Bug 2161519 depends on bug 2161518, which changed state. Bug 2161518 Summary: Review Request: python-y-py - Python bindings for the Y-CRDT built from yrs (Rust) https://bugzilla.redhat.com/show_bug.cgi?id=2161518 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161519 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161942] Review Request: bind9-next - The Berkeley Internet Name Domain (BIND) DNS (Domain Name System) server
https://bugzilla.redhat.com/show_bug.cgi?id=2161942 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #23 from Fedora Update System --- FEDORA-EPEL-2023-116ae883fe has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-116ae883fe -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161942 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161113] Review Request: libopenshot - Library for creating and editing videos
https://bugzilla.redhat.com/show_bug.cgi?id=2161113 Neal Gompa changed: What|Removed |Added CC||hobbes1...@gmail.com Flags||needinfo?(benson_muite@emai ||lplus.org) --- Comment #2 from Neal Gompa --- libopenshot-audio is now imported into Fedora, can you review this now? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161113 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161112] Review Request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.redhat.com/show_bug.cgi?id=2161112 --- Comment #8 from Fedora Update System --- FEDORA-2023-2295b35268 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2295b35268 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2161112 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161112] Review Request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.redhat.com/show_bug.cgi?id=2161112 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-EPEL-2023-11bb7b880d has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-11bb7b880d -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161112 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161112] Review Request: libopenshot-audio - Audio library used by OpenShot
https://bugzilla.redhat.com/show_bug.cgi?id=2161112 --- Comment #5 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/libopenshot-audio -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161112 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
