[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Dmytro Shyshchenko changed: What|Removed |Added CC||shysche...@gmail.com --- Comment #22 from Dmytro Shyshchenko --- The included version 1.2.1 of wondershaper is really a problematic one, but the tool itself is quite useful and easy to operate. Could its version be updated to the latest 1.4? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #21 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Mosaab Alzoubi changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #20 from Mosaab Alzoubi --- Package Change Request == Package Name: wondershaper New Branches: epel7 Owners: moceap -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #19 from Fedora Update System --- wondershaper-1.2.1-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #18 from Fedora Update System --- wondershaper-1.2.1-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #17 from Fedora Update System --- wondershaper-1.2.1-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||wondershaper-1.2.1-2.el6 Resolution|--- |ERRATA Last Closed||2013-11-27 16:21:50 --- Comment #16 from Fedora Update System --- wondershaper-1.2.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- wondershaper-1.2.1-2.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #14 from Fedora Update System --- wondershaper-1.2.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #12 from Fedora Update System --- wondershaper-1.2.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #13 from Fedora Update System --- wondershaper-1.2.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #11 from Fedora Update System --- wondershaper-1.2.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Mosaab Alzoubi changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #9 from Mosaab Alzoubi --- Thank You Christopher. New Package SCM Request === Package Name: wondershaper Short Description: Simple network shaper Owners: moceap Branches: f18 f19 f20 el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Christopher Meng changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Christopher Meng --- PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #7 from Mosaab Alzoubi --- Thanks alot Christopher, Your suggestion in 1.2.1 now. --- - Update to 1.2.1 . - Replace URL with main program page. - General tweaks. - Remove VERSION file from %%doc. Spec URL: http://ojuba.org/oji/SPECS/wondershaper.spec SRPM URL: http://ojuba.org/oji/SRPMS/wondershaper-1.2.1-1.oji.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498
Christopher Meng changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|cicku...@gmail.com
Flags||fedora-review?
--- Comment #6 from Christopher Meng ---
1. URL should be:
http://sourceforge.net/projects/wondershaper/
2. Because nothing need to be built during %build, please add a note about
this:
%build
# Nothing to build.
3. install -Dm 755 wshaper %{buildroot}/%{_sbindir}/%{name}
-->
install -pDm755 wshaper %{buildroot}%{_sbindir}/%{name}
4. %files
%doc ChangeLog COPYING README VERSION
I don't think you need to ship VERSION file...
Others are fine.
---
Suggestion:
In function show_help of this shell script, please consider this change:
function show_help {
echo "Wonder Shaper 1.2"
echo
echo "Usage: $0 [device] clean|[upload speed in Kb/s] [download speed in
Kb/s]"
echo "Example: $0 eth0 20 500"
echo
echo "Report bugs at http://bugzilla.redhat.com/.";
exit
}
to
function show_help {
echo "Wonder Shaper 1.2"
echo
echo "Usage: $0 [device] clean|[upload speed in Kb/s] [download speed in
Kb/s]"
echo "Example: $0 eth0 20 500"
echo
echo "Report bugs at
https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&version=rawhide&component=wondershaper.";
exit
}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Parag AN(पराग) changed: What|Removed |Added CC||panem...@gmail.com Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #5 from Mosaab Alzoubi --- Ok , thank you Michael. It's done: Spec URL: http://ojuba.org/oji/SPECS/wondershaper.spec SRPM URL: http://ojuba.org/oji/SRPMS/wondershaper-1.2-3.oji.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #4 from Michael Schwendt --- %defattr(-,root,root,-) is not needed anymore at all by any of the active dist releases, because they all include RPM >= 4.4. https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 --- Comment #3 from Mosaab Alzoubi --- I used "%defattr(-,root,root,-)" due to single sbin application. - To zero warnings by rpmlint. Spec URL: http://ojuba.org/oji/SPECS/wondershaper.spec SRPM URL: http://ojuba.org/oji/SRPMS/wondershaper-1.2-2.oji.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Johan Swensson changed: What|Removed |Added CC||k...@kupo.se --- Comment #2 from Johan Swensson --- I'm not a current package maintainer but here's an informal review: $ rpmlint wondershaper1.2-1.fc19.noarch.rpm wondershaper.noarch: W: spelling-error Summary(en_US) shaper -> shape, sharper, shapes wondershaper.noarch: W: spelling-error %description -l en_US cablemodem -> cable modem, cable-modem, demonstrable wondershaper.noarch: E: incorrect-fsf-address /usr/share/doc/wondershaper-1.2/COPYING wondershaper.noarch: W: no-manual-page-for-binary wondershaper 1 packages and 0 specfiles checked; 1 errors, 3 warnings. $ rpmlint wondershaper.spec wondershaper.spec: W: no-%build-section 0 packages and 1 specfiles checked; 0 errors, 1 warnings. Also: %defattr(-,root,root,-) isn't needed -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Christopher Meng changed: What|Removed |Added CC||cicku...@gmail.com Blocks|201449 (FE-DEADREVIEW) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Christopher Meng changed: What|Removed |Added Blocks||201449 (FE-DEADREVIEW) CC||mma...@redhat.com --- Comment #1 from Christopher Meng --- *** Bug 458379 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Mosaab Alzoubi changed: What|Removed |Added Blocks||1015775 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1015775 [Bug 1015775] Review Request: TuxCut - TuxCut is a netcut "in windows os " like software written in PyQt -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper
https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Mosaab Alzoubi changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
