[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|bashmount-3.2.0-3.fc20 |bashmount-3.2.0-3.el7 --- Comment #31 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-3.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|bashmount-3.2.0-3.fc21 |bashmount-3.2.0-3.fc19 --- Comment #29 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|bashmount-3.2.0-3.fc19 |bashmount-3.2.0-3.fc20 --- Comment #30 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||bashmount-3.2.0-3.fc21 Resolution|RAWHIDE |ERRATA --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-3.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/bashmount-3.2.0-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/bashmount-3.2.0-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/bashmount-3.2.0-3.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/bashmount-3.2.0-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/bashmount-3.2.0-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags|needinfo?(jamielinux@fedora | |project.org)| --- Comment #16 from Jamie Nguyen jamieli...@fedoraproject.org --- (In reply to Raphael Groner from comment #15) Ping? I am wondering: Are you still interested in bringing bashmount into Fedora? In SCM, there's already bashmount available (initial import done by you in 02.2012), but obsoleted currently due to a udisks2 failure (02.2013). Yes, in the process of importing. Had so many things on todo list, I just kept forgetting about this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/bashmount-3.2.0-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/bashmount-3.2.0-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/bashmount-3.2.0-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/bashmount-3.2.0-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- bashmount-3.2.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/bashmount-3.2.0-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-11-03 14:47:30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #22 from Raphael Groner projects...@smart.ms --- (In reply to Jamie Nguyen from comment #16) … Yes, in the process of importing. Had so many things on todo list, I just kept forgetting about this. Thanks. I'll test when the package is pushed into @updates-testing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Raphael Groner projects...@smart.ms changed: What|Removed |Added CC||jamieli...@fedoraproject.or ||g Flags||needinfo?(jamielinux@fedora ||project.org) --- Comment #15 from Raphael Groner projects...@smart.ms --- Ping? I am wondering: Are you still interested in bringing bashmount into Fedora? In SCM, there's already bashmount available (initial import done by you in 02.2012), but obsoleted currently due to a udisks2 failure (02.2013). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Raphael Groner projects...@smart.ms changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=787858 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Till Maas opensou...@till.name changed: What|Removed |Added CC||opensou...@till.name --- Comment #12 from Till Maas opensou...@till.name --- (In reply to Jamie Nguyen from comment #8) New Package SCM Request === Package Name: bashmount Short Description: A menu-driven bash script for mounting removable media Upstream URL: https://github.com/jamielinux/bashmount Owners: jamielinux Branches: f19 f20 f21 el6 epel7 InitialCC: There is only a master branch, therefore I guess this needs to be a Package Change Request: http://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #13 from Jamie Nguyen jamieli...@fedoraproject.org --- Package Change Request == Package Name: bashmount New Branches: f19 f20 f21 el6 epel7 Owners: jamielinux -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Jamie Nguyen jamieli...@fedoraproject.org --- Thanks very much for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #8 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: bashmount Short Description: A menu-driven bash script for mounting removable media Upstream URL: https://github.com/jamielinux/bashmount Owners: jamielinux Branches: f19 f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493
--- Comment #9 from Raphael Groner projects...@smart.ms ---
%files
…
%{_mandir}/man1/bashmount.1*
Shouldn't that be with %doc in front?
%doc %{_mandir}/man1/bashmount.1*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493
--- Comment #10 from Jamie Nguyen jamieli...@fedoraproject.org ---
(In reply to Raphael Groner from comment #9)
%files
…
%{_mandir}/man1/bashmount.1*
Shouldn't that be with %doc in front?
%doc %{_mandir}/man1/bashmount.1*
No. See other spec files or the guidelines on the wiki for more info.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #5 from jiri vanek jva...@redhat.com --- If this will go to f21 then suggest will not be here. But I guess this depends on maintainer. Thank you for watching (not just this ) review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #6 from Christopher Meng i...@cicku.me --- (In reply to jiri vanek from comment #5) If this will go to f21 then suggest will not be here. But I guess this depends on maintainer. It will go to f21. But yum doesn't support this feature... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493
jiri vanek jva...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||jva...@redhat.com
Assignee|nob...@fedoraproject.org|jva...@redhat.com
--- Comment #2 from jiri vanek jva...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin,
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 jiri vanek jva...@redhat.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #3 from jiri vanek jva...@redhat.com --- Two non blocking questions - Any tests (for %check skope) are I guess out of any scope, right? Sad :( - Is this pure bash? If it depends on bashism, can it be fixed to not relay onbashism but be ok with any shell? If not, shouldnt be bash as requires? I know that bash is in group of not necessary (== sure) requires, but maybe in this case it is worthy to include. Anyway grate job. I 'm happy that I found this in reviwe waiting list. Tank you for it. If you are wiling of swap review, see https://bugzilla.redhat.com/show_bug.cgi?id=1121402 , but dont feel yourself in debt. Ok. to go. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #4 from Christopher Meng i...@cicku.me --- You should give a try for rpm 4.12+, it supports Suggests: udisks2 now. http://rpm.org/wiki/Releases/4.12.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #1 from Jamie Nguyen jamieli...@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/bashmount/bashmount.spec SRPM URL: http://jamielinux.fedorapeople.org/bashmount/SRPMS/bashmount-3.2.0-2.fc21.src.rpm * Sat Apr 26 2014 Jamie Nguyen jamieli...@fedoraproject.org - 3.2.0-2 - do not depend on udisks2 on EL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
