[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|drupal7-admin_theme-1.0-2.e |drupal7-admin_theme-1.0-2.f |l6 |c21 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- drupal7-admin_theme-1.0-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|drupal7-admin_theme-1.0-2.f |drupal7-admin_theme-1.0-2.e |c19 |l7 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- drupal7-admin_theme-1.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|drupal7-admin_theme-1.0-2.e |drupal7-admin_theme-1.0-2.e |l7 |l6 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- drupal7-admin_theme-1.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||drupal7-admin_theme-1.0-2.f ||c20 Resolution|--- |ERRATA Last Closed||2014-10-22 04:52:14 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- drupal7-admin_theme-1.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|drupal7-admin_theme-1.0-2.f |drupal7-admin_theme-1.0-2.f |c20 |c19 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- drupal7-admin_theme-1.0-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- drupal7-admin_theme-1.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/drupal7-admin_theme-1.0-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- drupal7-admin_theme-1.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/drupal7-admin_theme-1.0-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- drupal7-admin_theme-1.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/drupal7-admin_theme-1.0-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- drupal7-admin_theme-1.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal7-admin_theme-1.0-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Parag pnem...@redhat.com changed: What|Removed |Added CC||pnem...@redhat.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from Parag pnem...@redhat.com --- I got the permission from this package submitter to build his packages. I see this package missed f21 branch please create it. Package Change Request === Package Name: drupal7-admin_theme New Branches: f21 Owners: cycloptivity asrob siwinski -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- drupal7-admin_theme-1.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 --- Comment #14 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- drupal7-admin_theme-1.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/drupal7-admin_theme-1.0-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Sam Wilson cycloptiv...@internode.on.net changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Sam Wilson cycloptiv...@internode.on.net --- New Package SCM Request === Package Name: drupal7-admin_theme Short Description: Drupal allows you to define a different theme for administration pages. By default this only applies to pages with a path starting with 'admin' and content editing pages. Upstream URL: http://www.drupal.org/project/admin_theme Owners: cycloptivity asrob siwinski Branches: f19 f20 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Parag AN(पराग) panem...@gmail.com --- Thanks, the update in comment 3 looks good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 --- Comment #4 from Sam Wilson cycloptiv...@internode.on.net --- Hi Guys, Any chance to review this updated package? Cheers, Sam -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 --- Comment #3 from Sam Wilson cycloptiv...@internode.on.net --- Spec URL: http://cycloptivity.fedorapeople.org/drupal7-admin_theme/1.0-2/drupal7-admin_theme.spec SRPM URL: http://cycloptivity.fedorapeople.org/drupal7-admin_theme/1.0-2/drupal7-admin_theme-1.0-2.fc19.src.rpm Thanks for the reviews guys. @Parag 1. As Shawn pointed out this is from the Drupal guidelines 2. This is my mistake. The module SPEC template doesnt include a buildroot so thats been removed. 3. As per Shawn's update we discussed this on drupal-devel and its a bug that will be fixed via the Drupal release mechanism. @Shawn 4. I missed that in the guidelines where its mentioned drupal7-rpmbuild handling the PHP lang dep. I've now removed it. 5. Pure failure on my part. theme in name != drupal theme :) Its now a module as expected. Also, I will start running each scratch build against EPEL 6 rather than F21 since that's the intended target. http://koji.fedoraproject.org/koji/taskinfo?taskID=6869385 Cheers, Sam -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 --- Comment #1 from Parag AN(पराग) panem...@gmail.com --- Review: + Package builds successful in F21 x86_64 mock + rpmlint on generated rpms gave drupal7-admin_theme.noarch: W: spelling-error Summary(en_US) Drupal - Drupe drupal7-admin_theme.noarch: W: spelling-error %description -l en_US Drupal - Drupe drupal7-admin_theme.noarch: E: incorrect-fsf-address /usr/share/doc/drupal7-admin_theme/LICENSE.txt drupal7-admin_theme.src: W: spelling-error Summary(en_US) Drupal - Drupe drupal7-admin_theme.src: W: spelling-error %description -l en_US Drupal - Drupe 2 packages and 0 specfiles checked; 1 errors, 4 warnings. + Source verified with upstream as (sha256sum) srpm tarball: ab3b742c9854ddad5862e197b17bcc2bc655a5f101df7ab31a055c0e7f25c00f upstream tarball : ab3b742c9854ddad5862e197b17bcc2bc655a5f101df7ab31a055c0e7f25c00f + License is valid GPLv2+ and included in its own text file LICENSE.txt + Package follows drupal7 packaging guidelines Suggestions: 1) Group tag is not necessary in Fedora now and can be removed from spec file. See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag 2) Buildroot tag is not needed. See https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag 3) File upstream bug/ticket to correct the FSF address in LICENSE.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269
--- Comment #2 from Shawn Iwinski shawn.iwin...@gmail.com ---
(In reply to Parag AN(पराग) from comment #1)
Suggestions:
1) Group tag is not necessary in Fedora now and can be removed from spec
file. See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
Drupal 7 packaging guidelines template
(https://fedoraproject.org/wiki/Packaging:Drupal7#Module) has the Group tag.
Per overall packaging guidelines
(https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag) it can stay to
be compatible with EPEL and all Drupal pkgs are packaged for EPEL.
2) Buildroot tag is not needed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
This is an EPEL5 item that needs to be removed unless planning to package for
EPEL5 -- and in that case there are several other things missing. I would
suggest not packaging for EPEL5 unless you need it so drop the buildroot.
3) File upstream bug/ticket to correct the FSF address in LICENSE.txt
No upstream bug/ticket necessary because it will automatically get fixed on
next upstream release by the Drupal buildbot that automatically adds the
LICENSE.txt file -- the upstream module owner has no control over the
LICENSE.txt file added.
Additional items:
4) Requires: php(language) = 4.1 not required and should not be present.
You do need to run phpcompatinfo on the module though -- see
https://fedoraproject.org/wiki/Packaging:Drupal7#PHP_Extensions
5) This is a module, not a theme, so %{module} not %{theme}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1099269] Review Request: drupal7-admin_theme - Allows you to define a different theme for admin pages
https://bugzilla.redhat.com/show_bug.cgi?id=1099269 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com Assignee|nob...@fedoraproject.org|panem...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
