[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Raphael Groner projects...@smart.ms changed: What|Removed |Added Status|NEW |CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |CANTFIX Last Closed||2014-10-25 16:59:34 --- Comment #32 from Raphael Groner projects...@smart.ms --- Due to unclear reasoning for the bundled stuff (booster/boost, json2, etc.), I don't see any possible solution for the short run. Unfortunately, I have to decline my review request till there's a working and easy fix found. Thanks for your help. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Christian Dersch chrisder...@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|chrisder...@gmail.com |nob...@fedoraproject.org Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #30 from Christian Dersch chrisder...@gmail.com --- If you think the exception is neccessary: Please ask for it! Will review after things are clarified. Greetings, Christian -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #31 from Raphael Groner projects...@smart.ms --- Thanks a lot for your interest. I'll give some thought and come back later to the open issues. Sorry for the delay. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #29 from Raphael Groner projects...@smart.ms --- IIRC, we should also ask for an exception to keep booster as it is and embedded: * Exception for using bundled bullet library for supertuxkart - https://fedorahosted.org/fpc/ticket/459 (spot, 16:12:03) * ACTION: Permit supertuxkart to include and use its forks of irrlicht and bullet. (+1:5, 0:0, -1:0) (spot, 16:19:28) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #27 from Raphael Groner projects...@smart.ms --- https://copr.fedoraproject.org/coprs/raphgro/CppCMS/build/51936/ I don't know why COPR can not build for F21. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #28 from Raphael Groner projects...@smart.ms --- https://copr.fedoraproject.org/coprs/raphgro/CppCMS/build/51938/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Christian Dersch chrisder...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #25 from Christian Dersch chrisder...@gmail.com --- Taken, a detailed review will follow on friday. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #26 from Raphael Groner projects...@smart.ms --- The changelog is not in sync with the actual release no. Thanks to rpmdev-bumpspec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Raphael Groner projects...@smart.ms changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) |504493 ||(DuplicSysLibsTracker) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=504493 [Bug 504493] Tracker: Duplication of system libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Christian Dersch chrisder...@gmail.com changed: What|Removed |Added CC||chrisder...@gmail.com Assignee|nob...@fedoraproject.org|chrisder...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #20 from Raphael Groner projects...@smart.ms --- Thanks for taking care about my request. (In reply to Ralf Corsepius from comment #4) 3. Bundled libraries: This package bundles quite a number of sources from other origins (boost, json2*.js, sha1, etc.). Please modify the package to use external versions whenever possible. What do you think how we could handle those issues? (In reply to Raphael Groner from comment #10) According to booster / boost: Please read the commented discussion at upstream. I don't know what to do about that in Fedora. Having to remove all that forking code has less sense and would be just ridiculous. http://thread.gmane.org/gmane.comp.lib.boost.devel/204117 http://cppcms.com/wikipp/en/page/cppcms_1x_coding_standards#Libraries Fork the fork? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Raphael Groner projects...@smart.ms changed: What|Removed |Added Attachment #911481|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Raphael Groner projects...@smart.ms changed: What|Removed |Added Attachment #911480|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #21 from Ralf Corsepius rc040...@freenet.de --- (In reply to Raphael Groner from comment #20) Thanks for taking care about my request. (In reply to Ralf Corsepius from comment #4) 3. Bundled libraries: This package bundles quite a number of sources from other origins (boost, json2*.js, sha1, etc.). Please modify the package to use external versions whenever possible. What do you think how we could handle those issues? Quite simple. There are 3 ways 1. Patch the sources. 2. Report it to upstream and wait until they implement it. 3. Abstain from packaging a package. 1. is the way of least resistance and should not be difficult to implement. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #22 from Raphael Groner projects...@smart.ms --- https://raphgro.fedorapeople.org/review/cppcms/cppcms.spec https://raphgro.fedorapeople.org/review/cppcms/cppcms-1.0.4-5.fc20.src.rpm Don't do rpmlint for now. I'll invest later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #23 from Raphael Groner projects...@smart.ms --- (In reply to Ralf Corsepius from comment #21) There are 3 ways 1. Patch the sources. 2. Report it to upstream and wait until they implement it. 3. Abstain from packaging a package. 1. is the way of least resistance and should not be difficult to implement. So that would mean a fork of the fork for booster. I hoped that my two links make it more clear to understand why Fedora policy doesn't comply with upstream guidelines. So instead 3. seems to be the best way to handle it with lowest resistance. :-( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #24 from Ralf Corsepius rc040...@freenet.de --- (In reply to Raphael Groner from comment #23) (In reply to Ralf Corsepius from comment #21) There are 3 ways 1. Patch the sources. 2. Report it to upstream and wait until they implement it. 3. Abstain from packaging a package. 1. is the way of least resistance and should not be difficult to implement. So that would mean a fork of the fork for booster. I hoped that my two links make it more clear to understand why Fedora policy doesn't comply with upstream guidelines. So instead 3. seems to be the best way to handle it with lowest resistance. :-( So be it - Sometimes upstreams need to learn the hard way they are doing a poor job. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Raphael Groner projects...@smart.ms changed: What|Removed |Added Flags|needinfo? | --- Comment #11 from Raphael Groner projects...@smart.ms --- Created attachment 911467 -- https://bugzilla.redhat.com/attachment.cgi?id=911467action=edit cppcms-20140623.spec At least, some little progess. Here it is a new spec file but it won't work. I think I run into an issue with c++11: error: provided for 'templateclass T1, class T2 struct cppcms::traits, similiar like with this guy: http://www.copyquery.com/boostvariant-boostshared_ptrt-wont-compile/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #12 from Raphael Groner projects...@smart.ms --- http://koji.fedoraproject.org/koji/taskinfo?taskID=7068248 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #13 from Raphael Groner projects...@smart.ms --- (In reply to Raphael Groner from comment #12) Now with --scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=7068257 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #14 from Raphael Groner projects...@smart.ms --- Created attachment 911476 -- https://bugzilla.redhat.com/attachment.cgi?id=911476action=edit build-20140623.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #15 from Raphael Groner projects...@smart.ms --- Created attachment 911477 -- https://bugzilla.redhat.com/attachment.cgi?id=911477action=edit cppcms src rpm (20140623) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Raphael Groner projects...@smart.ms changed: What|Removed |Added Attachment #901321|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #16 from Christopher Meng i...@cicku.me --- CMake Error at CMakeLists.txt:495 (message): Can't build without Python interpreter -- Configuring incomplete, errors occurred! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554
--- Comment #17 from Raphael Groner projects...@smart.ms ---
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:571:33: error: provided for
'templateclass T1, class T2 struct cppcms::traits'
struct traitsstd::pairT1,T2 {
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:686:27: error: wrong number of
template arguments (1, should be 2)
struct traitslong double {
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:571:33: error: provided for
'templateclass T1, class T2 struct cppcms::traits'
struct traitsstd::pairT1,T2 {
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:703:26: error: wrong number of
template arguments (1, should be 2)
struct traitsjson::null {
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:571:33: error: provided for
'templateclass T1, class T2 struct cppcms::traits'
struct traitsstd::pairT1,T2 {
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:711:23: error: wrong number of
template arguments (1, should be 2)
struct traitschar[n] {
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:571:33: error: provided for
'templateclass T1, class T2 struct cppcms::traits'
struct traitsstd::pairT1,T2 {
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:719:30: error: wrong number of
template arguments (1, should be 2)
struct traitschar const [n] {
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:571:33: error: provided for
'templateclass T1, class T2 struct cppcms::traits'
struct traitsstd::pairT1,T2 {
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:729:28: error: wrong number of
template arguments (1, should be 2)
struct traitschar const * {
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:571:33: error: provided for
'templateclass T1, class T2 struct cppcms::traits'
struct traitsstd::pairT1,T2 {
^
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:740:1: error: expected
declaration before '}' token
} // cppcms
^
CMakeFiles/cppcms_config_find_param.dir/build.make:80: recipe for target
'CMakeFiles/cppcms_config_find_param.dir/src/json.cpp.o' failed
make[2]: Leaving directory '/builddir/build/BUILD/cppcms-1.0.4'
CMakeFiles/Makefile2:308: recipe for target
'CMakeFiles/cppcms_config_find_param.dir/all' failed
make[1]: Leaving directory '/builddir/build/BUILD/cppcms-1.0.4'
Makefile:150: recipe for target 'all' failed
RPM build errors:
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h: In instantiation of 'T
cppcms::value::get_value() const [with T = std::basic_stringchar]':
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:365:37: required from here
/builddir/build/BUILD/cppcms-1.0.4/cppcms/json.h:239:3: warning: no return
statement in function returning non-void [-Wreturn-type]
}
^
make[2]: *** [CMakeFiles/cppcms_config_find_param.dir/src/json.cpp.o] Error 1
make[1]: *** [CMakeFiles/cppcms_config_find_param.dir/all] Error 2
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.R8XHoK (%build)
Bad exit status from /var/tmp/rpm-tmp.R8XHoK (%build)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target i686 --nodeps
builddir/build/SPECS/cppcms.spec']
Traceback (most recent call last):
File /usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py, line
70, in trace
result = func(*args, **kw)
File /usr/lib/python2.7/site-packages/mockbuild/util.py, line 376, in do
raise mockbuild.exception.Error, (Command failed. See logs for output.\n #
%s % (command,), child.returncode)
Error: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target i686 --nodeps
builddir/build/SPECS/cppcms.spec']
LEAVE do -- EXCEPTION RAISED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Raphael Groner projects...@smart.ms changed: What|Removed |Added Attachment #911476|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Raphael Groner projects...@smart.ms changed: What|Removed |Added Attachment #911467|0 |1 is obsolete|| --- Comment #18 from Raphael Groner projects...@smart.ms --- Created attachment 911480 -- https://bugzilla.redhat.com/attachment.cgi?id=911480action=edit cppcms.spec (20140623.2) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Raphael Groner projects...@smart.ms changed: What|Removed |Added Attachment #911477|0 |1 is obsolete|| --- Comment #19 from Raphael Groner projects...@smart.ms --- Created attachment 911481 -- https://bugzilla.redhat.com/attachment.cgi?id=911481action=edit src.rpm (20140623.2) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Raphael Groner projects...@smart.ms changed: What|Removed |Added Flags||needinfo? --- Comment #10 from Raphael Groner projects...@smart.ms --- According to booster / boost: Please read the commented discussion at upstream. I don't know what to do about that in Fedora. Having to remove all that forking code has less sense and would be just ridiculous. http://thread.gmane.org/gmane.comp.lib.boost.devel/204117 http://cppcms.com/wikipp/en/page/cppcms_1x_coding_standards#Libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #9 from Michael Schwendt bugs.mich...@gmx.net --- Why Bugzilla doesn't accept that?? At https://bugzilla.redhat.com/userprefs.cgi?tab=account there are two (separate) fields for real name and email address. Enter the data and your password to confirm. That has worked before for other people, who had been asked to enter the real name. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added CC||robinlee.s...@gmail.com Summary|Review Request: CppCMS - a |Review Request: cppcms - a |Free High Performance Web |Free High Performance Web |Development Framework |Development Framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554
--- Comment #5 from Christopher Meng i...@cicku.me ---
1. Please setup your real name in bugzilla, not just an email address.
2. Why disable %check?
3.
%build
%ifarch x86_64
CMAKE_OPT=-DLIBDIR=lib64
%endif
%cmake $CMAKE_OPT
--
Well, you can try RPM macro %{_lib} and change it to this:
%cmake -DLIBDIR=%{_lib}
4. Besides, you are new people, please follow:
http://fedoraproject.org/wiki/Join_the_package_collection_maintainers
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554
--- Comment #6 from raph...@web.de projects...@smart.ms ---
(In reply to Christopher Meng from comment #5)
1. Please setup your real name in bugzilla, not just an email address.
Sorry, I had to adjust the address to confirm with FAS.
2. Why disable %check?
Because some tests fail. See my initial comment.
3.
%build
%ifarch x86_64
CMAKE_OPT=-DLIBDIR=lib64
%endif
%cmake $CMAKE_OPT
--
Well, you can try RPM macro %{_lib} and change it to this:
%cmake -DLIBDIR=%{_lib}
I'll fix that. Thanks for the hint.
4. Besides, you are new people, please follow:
http://fedoraproject.org/wiki/Join_the_package_collection_maintainers
Ey.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #7 from raph...@web.de projects...@smart.ms --- My name is Raphael Groner projects...@smart.ms. Why Bugzilla doesn't accept that?? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #8 from raph...@web.de projects...@smart.ms --- (In reply to Ralf Corsepius from comment #4) This package has lot of issues. I do not want to sound too negative, but I fear it'll be a long and tiresome process to get this package into Fedora. Well, having to do homework isn't a good point to argue against required bot worth effort. Upstream is not forced to apply each Fedora policy... ;) 1. Packaging: Please properly split the package into main and *-devel subpackages: - *.so.* belong into *-devel unless they are dlopened by name. - man3/ are devel doc and therefore belong into *-devel. - *.a are not supposed to be shipped in Fedora at all. - Please be more selective in %files sections. The way you have written them is very sensitive to accidentially picking up files a package is not supposed to contain (cf. *devel vs. main). I'll clean up the build, so only the important files should be packaged in. Not sure what to do about manpages, I should skip them completely. 2. Contents: - Most of the man3/* manpages are junk and are likely to conflict with other packages. So just ignore and leave them out of the package? - The *-doc package contains a lot of files which are not supposed to be shipped. Please tell me the concrete file names. The sense is to ship html documentation cause doxygen produces that, but we could just ship Doxyfile in -devel and let the user decide if it wants to generate by itself. 3. Bundled libraries: This package bundles quite a number of sources from other origins (boost, json2*.js, sha1, etc.). Please modify the package to use external versions whenever possible. Hmmm. That's Fedora's policy and a good one. Maybe I have to work with upstream to fix that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: CppCMS - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #4 from Ralf Corsepius rc040...@freenet.de --- This package has lot of issues. I do not want to sound too negative, but I fear it'll be a long and tiresome process to get this package into Fedora. Let start with pointing out a few selected issues. 1. Packaging: Please properly split the package into main and *-devel subpackages: - *.so.* belong into *-devel unless they are dlopened by name. - man3/ are devel doc and therefore belong into *-devel. - *.a are not supposed to be shipped in Fedora at all. - Please be more selective in %files sections. The way you have written them is very sensitive to accidentially picking up files a package is not supposed to contain (cf. *devel vs. main). 2. Contents: - Most of the man3/* manpages are junk and are likely to conflict with other packages. - The *-doc package contains a lot of files which are not supposed to be shipped. 3. Bundled libraries: This package bundles quite a number of sources from other origins (boost, json2*.js, sha1, etc.). Please modify the package to use external versions whenever possible. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: CppCMS - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added CC||bjoern.es...@gmail.com Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #1 from raph...@web.de projects...@smart.ms --- Created attachment 901321 -- https://bugzilla.redhat.com/attachment.cgi?id=901321action=edit $ rpmlint rpmbuild/SPECS/cppcms.spec rpmbuild/RPMS/x86_64/cppcms-* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #2 from raph...@web.de projects...@smart.ms --- Not sure about: 1) %prep: Should I patch Doxyfile or provide my complete own one? Upstream seems to use an outdated format of the file. 2) %check: Two tests fail on my local system. So I decided to comment that. 3) %files doc: Do we need latex files, e.g. for pdf generation? I included manpages instead into the main package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: CppCMS - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 raph...@web.de projects...@smart.ms changed: What|Removed |Added Summary|Review Request: cppcms - a |Review Request: CppCMS - a |Free High Performance Web |Free High Performance Web |Development Framework |Development Framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: CppCMS - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #3 from raph...@web.de projects...@smart.ms --- Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=6916686 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
