[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 Fedora Update System changed: What|Removed |Added Fixed In Version|onionshare-0.6-5.fc21 |onionshare-0.6-5.el7 --- Comment #26 from Fedora Update System --- onionshare-0.6-5.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 Fedora Update System changed: What|Removed |Added Fixed In Version|onionshare-0.6-5.fc20 |onionshare-0.6-5.fc21 --- Comment #25 from Fedora Update System --- onionshare-0.6-5.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 Fedora Update System changed: What|Removed |Added Fixed In Version|onionshare-0.6-5.fc19 |onionshare-0.6-5.fc20 --- Comment #24 from Fedora Update System --- onionshare-0.6-5.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||onionshare-0.6-5.fc19 Resolution|--- |ERRATA Last Closed||2014-10-31 21:38:35 --- Comment #23 from Fedora Update System --- onionshare-0.6-5.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 --- Comment #22 from Robert Mayr --- Updated el6 build to 0.6-7 fixing the name of pyQt4. Probably it needs to be done also for all other builds to be consistent. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System --- onionshare-0.6-5.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 --- Comment #17 from Fedora Update System --- onionshare-0.6-5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/onionshare-0.6-5.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 --- Comment #16 from Fedora Update System --- onionshare-0.6-5.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/onionshare-0.6-5.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 --- Comment #20 from Fedora Update System --- onionshare-0.6-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/onionshare-0.6-6.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 --- Comment #19 from Fedora Update System --- onionshare-0.6-5.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/onionshare-0.6-5.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 --- Comment #18 from Fedora Update System --- onionshare-0.6-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/onionshare-0.6-5.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 pjp changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from pjp --- New Package SCM Request === Package Name: onionshare Short Description: Securely and anonymously share files of any size Upstream URL: https://onionshare.org/ Owners: pjp robyduck Branches: f19 f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 --- Comment #13 from Robert Mayr --- Yes sure! Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 --- Comment #12 from pjp --- (In reply to Robert Mayr from comment #11) > Ok, works for me now! Cool! Thanks so much for the review Robert, I appreciate it. Would you like to co-maintain 'onionshare' package with me? Thank you. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 Robert Mayr changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Robert Mayr --- Ok, works for me now! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 --- Comment #10 from pjp --- (In reply to Robert Mayr from comment #9) > Oh, and maybe it's better to put your instruction to get rif of the Encoding > key into %prep, before the %build section. done. Please see: -> https://pjp.fedorapeople.org/onionshare.spec -> https://pjp.fedorapeople.org/onionshare-0.6-5.fc19.src.rpm -> http://koji.fedoraproject.org/koji/taskinfo?taskID=7857651 Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 --- Comment #9 from Robert Mayr --- Oh, and maybe it's better to put your instruction to get rif of the Encoding key into %prep, before the %build section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747
--- Comment #8 from Robert Mayr ---
In addition to:
4) onionshare.desktop should better be %{name}.desktop
Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747
--- Comment #7 from pjp ---
Hello Robert,
(In reply to Robert Mayr from comment #6)
> 1) The guidelines for the github commit contain also a shortcommit
> instruction. I think it's better to add it.
It's not used in the spec file. I think it's used for 'pre-release'
packages.[1]
---
...If no numeric version is indicated in the code, you may set Version to 0,
and treat the package as a "pre-release" package (and make use of the
%{shortcommit} macro).
---
> 2) You should use either $RPM_BUILD_ROOT or %{buildroot}, don't mix them up.
Fixed.
> 3) in the %files section you have %{_datadir}/* - is the package the owner
> of all the stuff beside it? It's better to define the single directories
> separately, IMHO.
done.
> 4) Use valid macros for the name instead of hardcoding
...?
> 5) Your desktop file has a deprecated "Encoding" instruction in the [Desktop
> Entry] section.
Fixed. (I'll let the upstream know about it)
Please see:
-> https://pjp.fedorapeople.org/onionshare.spec
-> https://pjp.fedorapeople.org/onionshare-0.6-4.fc19.src.rpm
-> http://koji.fedoraproject.org/koji/taskinfo?taskID=7851242
Thank you.
---
[1] -> https://fedoraproject.org/wiki/Packaging:SourceURL#Github
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747
--- Comment #6 from Robert Mayr ---
Ok, a few other comments:
1) The guidelines for the github commit contain also a shortcommit instruction.
I think it's better to add it.
2) You should use either $RPM_BUILD_ROOT or %{buildroot}, don't mix them up.
3) in the %files section you have %{_datadir}/* - is the package the owner of
all the stuff beside it? It's better to define the single directories
separately, IMHO.
4) Use valid macros for the name instead of hardcoding
5) Your desktop file has a deprecated "Encoding" instruction in the [Desktop
Entry] section.
https://developer.gnome.org/desktop-entry-spec/#deprecated-items
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747
--- Comment #5 from pjp ---
(In reply to Robert Mayr from comment #4)
> The source is not ok, and as the guidelines say, you should use the commit
> in github: http://fedoraproject.org/wiki/Packaging:SourceURL#Github
> http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
> I see you're using {_datarootdir}, just use {_datadir}.
Yep, fixed!
Please see:
-> https://pjp.fedorapeople.org/onionshare.spec
-> https://pjp.fedorapeople.org/onionshare-0.6-3.fc19.src.rpm
-> http://koji.fedoraproject.org/koji/taskinfo?taskID=7839887
Thank you.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747
--- Comment #4 from Robert Mayr ---
The source is not ok, and as the guidelines say, you should use the commit in
github: http://fedoraproject.org/wiki/Packaging:SourceURL#Github
I'm also not able to find the installation of the desktop file, could you add
it?
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
I see you're using {_datarootdir}, just use {_datadir}.
Thanks, Robert.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 pjp changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #3 from pjp --- Hello Robert, Thank you so much for this review, I appreciate it. (In reply to Robert Mayr from comment #2) > [!]: Package consistently uses macros (instead of hard-coded directory names). > You use %global to define the same name as %name, why? Right, it should have been onionshare_gui; It's fixed now. > Generic: > [!]: Sources can be downloaded from URI in Source: tag > Note: Could not download Source0: > https://github.com/micahflee/onionshare/archive/onionshare-0.6.tar.gz > See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags > > Please fix this, github uses redirects, so your source should be known as > v0.6.tar.gz. Add at least a comment or refer to the other solution in the > link above. > > onionshare.src: W: invalid-url Source0: > https://github.com/micahflee/onionshare/archive/onionshare-0.6.tar.gz HTTP > Error 404: Not Found > 2 packages and 0 specfiles checked; 0 errors, 5 warnings. > > See comment above to fix this. Yep, fixed now. Please see: -> https://pjp.fedorapeople.org/onionshare.spec -> https://pjp.fedorapeople.org/onionshare-0.6-2.fc19.src.rpm -> http://koji.fedoraproject.org/koji/taskinfo?taskID=7834260 Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 Robert Mayr changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747
Robert Mayr changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|robyd...@gmail.com
Flags|needinfo?(robyd...@gmail.co |
|m) |
--- Comment #2 from Robert Mayr ---
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
The source file has a desktop file, please install it properly.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"BSD (2 clause)", "GPL (v3 or later)", "Unknown or generated". 6 files
have unknown license. Detailed output of licensecheck in
/home/robyduck/1151747-onionshare/licensecheck.txt
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python2.7/site-packages/onionshare,
/usr/lib/python2.7/site-packages/onionshare_gui
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python2.7/site-
packages/onionshare_gui, /usr/lib/python2.7/site-packages/onionshare
[?]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/applications
(torbrowser-launcher, filesystem), /usr/share/pixmaps(torbrowser-
launcher, filesystem)
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory names).
You use %global to define the same name as %name, why?
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[?]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Fix the warnings if possible.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[?]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
https://github.com/micahflee/onionshare/a
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 pjp changed: What|Removed |Added URL||https://onionshare.org/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 pjp changed: What|Removed |Added CC||robyd...@gmail.com Flags||needinfo?(robyd...@gmail.co ||m) --- Comment #1 from pjp --- @Robert: could you please review this one? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
