[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740

Mikolaj Izdebski  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1190740
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

needinfo canceled: [Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Mat Booth  has canceled Package Review
's request for Mat Booth
's needinfo:
Bug 1190740: Review Request: mycila-xmltool - simple library to do common
operations on xml
https://bugzilla.redhat.com/show_bug.cgi?id=1190740
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740

Mat Booth  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(mat.booth@redhat. |
   |com)|
Last Closed||2020-08-20 13:17:13




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740

Sopot Cela  changed:

   What|Removed |Added

   Assignee|msima...@redhat.com |mat.bo...@redhat.com
  Flags|needinfo?(sc...@redhat.com) |



--- Comment #8 from Sopot Cela  ---
No progress was made from my side. Assigning to Mat since I will not be able to
spend time on this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740

Michael Simacek  changed:

   What|Removed |Added

  Flags||needinfo?(sc...@redhat.com)



--- Comment #7 from Michael Simacek  ---
Any progress on this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740



--- Comment #6 from Michael Simacek  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues
--
- Group tags are obsolete - remove them.
- License tag is incorrect.
- I don't see any MIT in the source code. Why do you think it should be
  there?
- No license file. Both ASL 2.0 and MIT require the license file to be
  shipped with the source.
- %pom_xpath_remove
pom:project/pom:build/pom:plugins/pom:plugin/pom:configuration
  This looks a bit dangerous as it will delete any configuration of any
  plugin that might appear there in the future.
  I'd suggest using this instead (untested):
  %pom_xpath_remove pom:useDefaultManifestFile
- It's a package rename - therefore it should have proper provides and
  obsoletes.
- Please unify whitespace. Currently there is a mix of spaces and tabs
  that looks horrible when opened in editor with different configuration
  than yours.
- Javadoc %description should refer to %{name}, not %{summary}.
  So it should be: This package provides javadoc for %{name}.
- Please don't declare variables for every name component, they just
  make the spec less readable (i.e. get rid of the two globals)
- Changelog entry doesn't correspond to the current version.
- Requires on java-headless are unnecessary, they should be generated by
  the tooling automatically.
- Test failures - did you investigate why they fail. Have you tried just
  disabling particular failing test instead of the whole suite?
- You have runtime dependency on junit, because you're missing the test
  scope. I'd suggest using %pom_change_dep macro instead of removing and
  adding, because it avoids exactly this kind of errors.
- Executable readme.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[!]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[!]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[!]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 1 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740

Michael Simacek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||msima...@redhat.com
 Blocks|201449 (FE-DEADREVIEW)  |
   Assignee|nob...@fedoraproject.org|msima...@redhat.com
  Flags||fedora-review?




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740
Bug 1190740 depends on bug 1190735, which changed state.

Bug 1190735 Summary: Review Request: mycila-pom - Mycila parent POM
https://bugzilla.redhat.com/show_bug.cgi?id=1190735

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740



--- Comment #5 from Sopot Cela  ---
There was a paste error in the previous comment. These urls are the latest and
greatest:

Spec URL: https://sopotc.fedorapeople.org/mycilla-xmltool/mycila-xmltool.spec
SRPM URL:
https://sopotc.fedorapeople.org/mycilla-xmltool/mycila-xmltool-4.4.ga-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740

Sopot Cela  changed:

   What|Removed |Added

 CC||sc...@redhat.com



--- Comment #4 from Sopot Cela  ---
This version of pom builds for rawhide with latest upstream version:

Spec URL: https://sopotc.fedorapeople.org/mycilla-xmltool/mycila-pom.spec
SRPM URL:
https://sopotc.fedorapeople.org/mycilla-xmltool/mycila-xmltool-4.4.ga-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740

gil cattaneo  changed:

   What|Removed |Added

 Blocks||201449 (FE-DEADREVIEW)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740



--- Comment #3 from Guido Grazioli guido.grazi...@gmail.com ---
aargh; they did change groupId and artifactId so many times, even while i was
maintaining both packages (they were optional dependencies of objenesis).

Anyway, I think it would be better to go ahead with your two reviews, then
obsolete the two older packages (I did not update for very long time and are
outdated both for java packaging guidelines and release version) when your
packages are deployed. About the naming, up to you.

Maybe give a peek at how the naming/obsolete/provide thing was handled at the
time all the jakarta-* packages were renamed to apache-*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740



--- Comment #2 from zzamb...@redhat.com ---
hello,
I looked at the package you posted, you are right, but artifactId and groupId
in pom.xml have changed since then. I have downloaded sources (using fedpkg) of
newest version of that package (3.3) and artifactId in pom is xmltool, but
current version of that library uses artifactId mycila-xmltool and groupId
has changed from com.mycila.xmltool to com.mycila. I am not sure if
updating of existing package or creating new package is better solution in this
case.

But in case of new package I think name mycila-xmltool would make more sense
because it is same as artifactId and also new web page of that library names it
Mycila XML Tool : http://code.mycila.com/xmltool/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740

Guido Grazioli guido.grazi...@gmail.com changed:

   What|Removed |Added

 CC||guido.grazi...@gmail.com



--- Comment #1 from Guido Grazioli guido.grazi...@gmail.com ---
https://admin.fedoraproject.org/pkgdb/package/xmltool/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740

zzamb...@redhat.com changed:

   What|Removed |Added

 Blocks||1190746




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1190746
[Bug 1190746] Review Request: mycila-license-maven-plugin - Manage license
header of your project
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1190740] Review Request: mycila-xmltool - simple library to do common operations on xml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190740

zzamb...@redhat.com changed:

   What|Removed |Added

 Depends On||1190735




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1190735
[Bug 1190735] Review Request: mycila-pom - Mycila parent POM
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review