[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Fedora Update System changed: What|Removed |Added Fixed In Version|2.0.1-1.fc22|2.0.1-1.fc23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #41 from Fedora Update System --- owncloud-client-2.0.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #40 from Fedora Update System --- owncloud-client-2.0.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||2.0.1-1.fc22 Resolution|--- |NEXTRELEASE Last Closed||2015-09-17 21:31:37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #39 from Fedora Update System --- owncloud-client-2.0.1-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update owncloud-client'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15945 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #38 from Fedora Update System --- owncloud-client-2.0.1-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15945 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #37 from Fedora Update System --- owncloud-client-2.0.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update owncloud-client'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15569 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #36 from Fedora Update System --- owncloud-client-2.0.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15569 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #35 from Fedora Update System --- owncloud-client-2.0.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update owncloud-client'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15376 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #34 from Fedora Update System --- owncloud-client-2.0.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15376 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #33 from Fedora Update System --- owncloud-client-1.8.4-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update owncloud-client'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14997 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #32 from Fedora Update System --- owncloud-client-1.8.4-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update owncloud-client'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14998 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #31 from Fedora Update System --- owncloud-client-1.8.4-3.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update owncloud-client'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14999 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #29 from Fedora Update System --- owncloud-client-1.8.4-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14998 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #30 from Fedora Update System --- owncloud-client-1.8.4-3.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14999 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #28 from Fedora Update System --- owncloud-client-1.8.4-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14997 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #27 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Nikos Roussos changed: What|Removed |Added Flags||fedora-cvs? --- Comment #26 from Nikos Roussos --- New Package SCM Request === Package Name: owncloud-client Short Description: The ownCloud Client Upstream URL: http://owncloud.org/sync-clients/ Owners: comzeradd Branches: f21 f22 f23 InitialCC: anvil germano -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Rex Dieter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #25 from Rex Dieter --- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #24 from Nikos Roussos --- Thanks. Updated SPEC: https://comzeradd.fedorapeople.org/specs/owncloud-client.spec SRPM: https://comzeradd.fedorapeople.org/srpms/owncloud-client-1.8.4-3.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Kevin Kofler changed: What|Removed |Added CC||ke...@tigcc.ticalc.org Blocks||928937 (qt-reviews) Alias||owncloud-client Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #23 from Rex Dieter --- yes it could, but it's not a requirement, see comment #16 and comment #17 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Guillaume Kulakowski changed: What|Removed |Added CC||guilla...@kulakowski.fr --- Comment #22 from Guillaume Kulakowski --- The ownClound client 2.0 is avalaible. The review could be based on the last version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #21 from Rex Dieter --- for 8, specifically, remove the whole %package client and %description client sections (if that wasn't clear) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805
--- Comment #20 from Rex Dieter ---
Looking good, really close, thanks.
8. MUST remove extraneous
%package client
(there is no ownclient-client-client)
and move the
Provides: mirall = 1.8.4
Obsoletes: mirall < 1.8.0
included there to the main pklg
9. SHOULD amend Provides to use %{version}-%{release} instead of hard-coded
version, for example, change
Provides: mirall = 1.8.4
to
Provides: mirall = %{version}-%{release}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #19 from Nikos Roussos --- Thanks for the review. I updated the spec. I think I fixed all of the above issues. SPEC: https://comzeradd.fedorapeople.org/specs/owncloud-client.spec SRPM: https://comzeradd.fedorapeople.org/srpms/owncloud-client-1.8.4-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805
--- Comment #18 from Rex Dieter ---
Here we go:
naming: ok mostly
1. SHOULD: I'd suggest naming -common as -libs instead, it's a more common
practice. And adjust dependencies accordingly
2. SHOULD replace
%{_datadir}/icons/hicolor/16x16/apps/*
%{_datadir}/icons/hicolor/48x48/apps/*
...
with single/simpler glob:
%{_datadir}/icons/h%{_sysconfdir}/hicolor/*/apps/*
3. MUST fix dir ownership, you include:
%config %{_sysconfdir}/ownCloud/sync-exclude.lst
but nothing owns the %{_sysconfdir}/ownCloud , please add
%dir %{_sysconfdir}/ownCloud
4. MUST fix obsoletes/provides. you include Obsoletes: for mirall, but no
matching provides, please add in the right places:
# main pkg:
Obsoletes: mirall < 1.8.0
Provides: mirall = %{version}-%{release}
# -devel subpkg
Obsoletes: mirall-devel < 1.8.0
Provides: mirall-devel = %{version}-%{release}
# -common/-libs subpkg, depending on 1 above
Obsoletes: mirall-common < 1.8.0
Provides: mirall-common = %{version}-%{release}
# -nautilus subpkg, with fixed spelling
Obsoletes: mirall-nautilus < 1.8.0
Provides: mirall-nautilus = %{version}-%{release}
(and move Obsoletes to match their subpkg locations)
sources: ok
ce82c234fca674062599b3ceb4ac50c6 owncloudclient-1.8.4.tar.xz
5. MUST validate appdata, add
BuildRequires: libappstream-glib
and to %check section:
appstream-util validate-relax --nonet
%{buildroot}%{datadir}/appdata/%{name}.appdata.xml
6. MUST: -devel pkg includes static libs, so add to -devel pkg:
Provides: %{name}-static = %{version}-%{release}
(or alternatively, omit
%{_libdir}/libhttpbf.a
%{_includedir}/httpbf.h
from packaging altogether if you're sure nothing else needs it)
7. MUST licensing: NOT ok. looks like the stuff under csync/ dir is all
LGPLv2+, and only the client code is GPLv2 (no +), so I'd recommend adding
(including comments):
(main)
# -libs are LGPLv2+, rest GPLv2
License: LGPLv2+ and GPLv2
(in -libs/-devel subpkgs)
License: LGPLv2+
Please address all MUST items, and I think we're good to go.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #17 from Rex Dieter --- Updating whenever is fine, it's not a review blocker. Can happen now or later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #16 from hannes --- There's a new version 2 available, perhaps we could directly use this one? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #15 from Rex Dieter --- Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=10856900 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #14 from Rex Dieter --- Lots of drive-by reviews, I guess I can do a formal review today to help out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #13 from Nikos Roussos --- I updated to 1.8.4 and added an appdata file https://comzeradd.fedorapeople.org/specs/owncloud-client.spec https://comzeradd.fedorapeople.org/srpms/owncloud-client-1.8.4-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu --- Comment #12 from Rex Dieter --- > Actually, before installing mirall manually, it was impossible to find it > with searching "owncloud" in Software. That requires appdata to be added (not currently included). shouldn't be too hard to add, but it's not a review blocker. see also: https://fedoraproject.org/wiki/Packaging:Guidelines#AppData_files > Can we have transparent upgrade from mirall to owncloud-client when available Yes, Obsoletes/Provides in the .spec here would handle that, and ensure things 'just work' as expected -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Jibec changed: What|Removed |Added CC||jb.holcr...@gmail.com --- Comment #11 from Jibec --- Can you also make sure that we can find Owncloud Client in Software ? Before and after install. Actually, before installing mirall manually, it was impossible to find it with searching "owncloud" in Software. Can we have transparent upgrade from mirall to owncloud-client when available ? Should I make bugs for those requests ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #10 from Dams --- FTR, 1.8.1 has been released. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Xavier Bachelot changed: What|Removed |Added CC||xav...@bachelot.org --- Comment #9 from Xavier Bachelot --- (In reply to Nikos Roussos from comment #6) > (In reply to Eugene A. Pivnev from comment #5) > > Another note: please remove (to be sure about 3rd-parties) src/3rdparty/: > > * qjson > > * qtlockedfile > > * sqlite3 > > Can you elaborate on that. Remove them from where? On %install section? Remove them in the %prep section to make sure the bundled libs are not used for the build. There's already a line removing some : "rm -rf src/3rdparty/qtlockedfile src/3rdparty/qtsingleapplication" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #8 from Nikos Roussos --- *** Bug 1214155 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Nikos Roussos changed: What|Removed |Added CC||sud...@sudhirkhanger.com --- Comment #7 from Nikos Roussos --- *** Bug 1214148 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #6 from Nikos Roussos --- Fix minor issues mentioned above SPEC: https://comzeradd.fedorapeople.org/specs/owncloud-client.spec SRPM: https://comzeradd.fedorapeople.org/srpms/owncloud-client-1.8.0-3.fc21.src.rpm (In reply to Eugene A. Pivnev from comment #5) > Another note: please remove (to be sure about 3rd-parties) src/3rdparty/: > * qjson > * qtlockedfile > * sqlite3 Can you elaborate on that. Remove them from where? On %install section? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Eugene A. Pivnev changed: What|Removed |Added CC||ti.eug...@gmail.com --- Comment #5 from Eugene A. Pivnev --- Another note: please remove (to be sure about 3rd-parties) src/3rdparty/: * qjson * qtlockedfile * sqlite3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Dennis Gilmore changed: What|Removed |Added CC||dgilm...@redhat.com --- Comment #4 from Dennis Gilmore --- a bug I noticed is that the client complains that it can not verify the ca for my server. even though firefox and everything else is able to validate it just fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805
Paul Howarth changed:
What|Removed |Added
CC||p...@city-fan.org
--- Comment #3 from Paul Howarth ---
Things I noticed from a quick look at the spec file:
The package does not need to provide itself:
Provides: owncloud-client = %{version}-%{release}
Should the Obsoletes have associated Provides? Will the package be going to
anywhere other than Rawhide?
The description and summary of the common sub-package need tidying up:
"... common files for owncloud-client and owncloud-client ..."
(Summaries and Descriptions should also generally start with a capital letter)
Use %license rather than %doc for COPYING
There should be a virtual -static provide for the libhttpbf.a static library:
http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #2 from Nikos Roussos --- Yes, good point. Updated files: spec: https://comzeradd.fedorapeople.org/specs/owncloud-client.spec srpm: https://comzeradd.fedorapeople.org/srpms/owncloud-client-1.8.0-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #1 from Dams --- Thank you for opening the review bug. Should ownclient-client-common obsolete mirall-common <= 1.8.0 ? (And ditto for -devel and -nautilus packages) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Nikos Roussos changed: What|Removed |Added CC||an...@livna.org Blocks||1178093 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1178093 [Bug 1178093] Package name should contain owncloud -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
