[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206086

Charalampos Stratakis  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 CC||cstra...@redhat.com
 Resolution|--- |CURRENTRELEASE
Last Closed||2016-09-27 10:47:15



--- Comment #8 from Charalampos Stratakis  ---
Since the package has been built for quite some time now, the review request
bugzilla should be closed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206086



--- Comment #7 from Upstream Release Monitoring 
 ---
social's scratch build of
openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 for
git://pkgs.fedoraproject.org/openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6
and rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11426591

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206086

Alan Pevec ape...@redhat.com changed:

   What|Removed |Added

 Status|NEW |MODIFIED
   Fixed In Version||python-oslo-versionedobject
   ||s-0.1.1-1.fc23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206086

Haïkel Guémar karlthe...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #5 from Haïkel Guémar karlthe...@gmail.com ---
New Package SCM Request
===
Package Name: python-oslo-versionedobjects
Short Description: OpenStack Olso common versionedobjects library
Upstream URL: http://launchpad.net/oslo
Owners: hguemar,apevec
Branches: f22
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206086

Patrick Uiterwijk puiterw...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206086



--- Comment #6 from Patrick Uiterwijk puiterw...@redhat.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206086

Chandan Kumar chku...@redhat.com changed:

   What|Removed |Added

 CC||chku...@redhat.com



--- Comment #1 from Chandan Kumar chku...@redhat.com ---
This is un-official review of the package.

Suggestions:
[1.] Group tag is optional in Fedora and is only needed if you want this
package to be built for EPEL5. See
http://fedoraproject.org/wiki/EPEL:Packaging#Group_tag. You can remove Group
tag from both package and sub-package.

[2.] Change the URL from launchpad to pypi,
URL: https://pypi.python.org/pypi/oslo.versionedobjects

[3.] Use %{version} tag in Source0
Source0:   
https://pypi.python.org/packages/source/o/%{sname}/%{sname}-%{version}.tar.gz

[4.] Move doc building steps from %install section to %build section

export PYTHONPATH=$( pwd ):$PYTHONPATH
pushd doc
sphinx-build -b html -d build/doctrees   source build/html
popd
# Fix hidden-file-or-dir warnings
rm -fr doc/build/html/.buildinfo

[5.] Mock build is failing and giving:

Extension error:
Could not import extension oslosphinx (exception: No module named oslosphinx)

To fix this:

Add this line in %prep section:
# make doc build compatible with python-oslo-sphinx RPM
sed -i 's/oslosphinx/oslo.sphinx/' doc/source/conf.py

[6.] in %files section, please include other files also present in the python
package tarball.
%doc AUTHORS CONTRIBUTING.rst README.rst PKG-INFO ChangeLog

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206086



--- Comment #2 from Haïkel Guémar karlthe...@gmail.com ---
1. good catch
2. launchpad url is valid too
3. good catch
4. good catch
5. does not fail in rawhide, you probably use an older release chroot with an
older python-oslo-sphinx (we dropped these kind of patches) 
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9345063
build.log:
https://kojipkgs.fedoraproject.org//work/tasks/5064/9345064/build.log
During reviews, we should focus on rawhide support unless stated otherwise
(packager expresses his intent to package on released Fedora, which is not the
case for openstack kilo builds)
6. good catch for AUTHORS and ChangeLog, other files are not really relevant
for packaging

= updated

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206086



--- Comment #3 from Lukas Bezdicka soc...@v3.sk ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find LICENSE in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
 1 files have unknown license. Detailed output of licensecheck in
 /home/social/1206086-python-oslo-versionedobjects/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
 Note: Test run failed
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
 Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.

Python:
[x]: Binary eggs must be removed in %prep
 Note: Test run failed
[x]: Python eggs must not download any dependencies during the build process.
 Note: Test run failed
[x]: A package which is used by another package via an egg interface should
 provide egg info.
 Note: Test run failed
[x]: Package meets the Packaging Guidelines::Python
 Note: Test run failed
[x]: Package contains BR: python2-devel or python3-devel

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
 oslo-versionedobjects-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.

[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206086

Lukas Bezdicka soc...@v3.sk changed:

   What|Removed |Added

 CC||soc...@v3.sk
   Assignee|nob...@fedoraproject.org|soc...@v3.sk
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206086

Lukas Bezdicka soc...@v3.sk changed:

   What|Removed |Added

   Assignee|soc...@v3.sk|nob...@fedoraproject.org
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Lukas Bezdicka soc...@v3.sk ---
mock failed because of missing python-oslo-client and python-oslo-concurrency
which both just passed reviews, the issue with different SPEC/SRPM is now
resolved, giving +

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review