[Bug 1224390] Review Request: ignition-math - Small, Fast, High Performance Math Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1224390

Rich Mattes  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-01-04 22:22:04



--- Comment #7 from Rich Mattes  ---
Built and submitted, closing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1224390] Review Request: ignition-math - Small, Fast, High Performance Math Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1224390

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1224390] Review Request: ignition-math - Small, Fast, High Performance Math Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1224390



--- Comment #4 from Upstream Release Monitoring 
 ---
rmattes's scratch build of ignition-math-2.2.3-1.fc22.src.rpm for f24 completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11525500

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1224390] Review Request: ignition-math - Small, Fast, High Performance Math Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1224390



--- Comment #5 from Rich Mattes  ---
Updated to the latest upstream release (2.2.3)

Spec URL: http://rmattes.fedorapeople.org/RPMS/ignition-math/ignition-math.spec
SRPM URL:
http://rmattes.fedorapeople.org/RPMS/ignition-math/ignition-math-2.2.3-1.fc22.src.rpm

rpmlint:
$ rpmlint ./ignition-math.spec ../RPMS/x86_64/ignition-math-*
../RPMS/noarch/ignition-math-doc-2.2.3-1.fc22.noarch.rpm 
ignition-math.x86_64: W: invalid-url URL:
http://ignitionrobotics.org/libraries/math 
ignition-math-debuginfo.x86_64: W: invalid-url URL:
http://ignitionrobotics.org/libraries/math 
ignition-math-devel.x86_64: W: invalid-url URL:
http://ignitionrobotics.org/libraries/math 
ignition-math-devel.x86_64: W: only-non-binary-in-usr-lib
ignition-math-devel.x86_64: W: no-documentation
ignition-math-doc.noarch: W: invalid-url URL:
http://ignitionrobotics.org/libraries/math 
4 packages and 1 specfiles checked; 0 errors, 6 warnings.

I think the website being down is a temporary issue.

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11525500

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1224390] Review Request: ignition-math - Small, Fast, High Performance Math Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1224390

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
Eveerything looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1224390] Review Request: ignition-math - Small, Fast, High Performance Math Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1224390

Rich Mattes  changed:

   What|Removed |Added

 Blocks||1247414




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1247414
[Bug 1247414] gazebo-6.4.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1224390] Review Request: ignition-math - Small, Fast, High Performance Math Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1224390



--- Comment #3 from Rich Mattes  ---
> What is the relation to ignition_math2? Does it supersede this version?
Yes, it does supersede this version. Upstream adds the major version to the
tarball name, but it's the same project.  I've updated the spec to the 2.2.2
release of ignition-math.

> %check is present, but the result is ignored. Is there a reason to ignore the 
> result?
A test was failing on i686.  I've included a patch that fixes the failing unit
test.  I've also updated the spec to fail when unit tests fail, after printing
out the failure log.

> I suggest using %global _docdir_fmt %{name}.
Good call, added.

Updated spec and SRPM can be found at:

Spec URL: http://rmattes.fedorapeople.org/RPMS/ignition-math/ignition-math.spec
SRPM URL:
http://rmattes.fedorapeople.org/RPMS/ignition-math/ignition-math-2.2.2-1.fc22.src.rpm

rpmlint:
$ rpmlint ignition-math.spec ../RPMS/x86_64/ignition-math-*
../RPMS/noarch/ignition-math*
ignition-math-devel.x86_64: W: only-non-binary-in-usr-lib
ignition-math-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 2 warnings

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=10980494

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1224390] Review Request: ignition-math - Small, Fast, High Performance Math Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1224390



--- Comment #2 from Rich Mattes  ---
Thanks.  The unit tests were disabled because one of them was failing on i686. 
I'm working with upstream to get a fix in place, and will have an updated
package once that's done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1224390] Review Request: ignition-math - Small, Fast, High Performance Math Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1224390

Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Questions and suggestion


What is the relation to ignition_math2? Does it supersede this version?

%check is present, but the result is ignored. Is there a reason to ignore the
result?

I suggest using %global _docdir_fmt %{name}.


Package Review
==

Legend:
[x] = Pass, [-] = Not applicable, [?] = question

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
ASL 2.

[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: Apache (v2.0), BSD (3 clause), Unknown or generated. 6
 files have unknown license. Detailed output of licensecheck in
 /var/tmp/1224390-ignition-math/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
-devel requires the main package.

[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/lib64/pkgconfig(pkgconfig), /usr/lib64/cmake(pulseaudio-libs-
 devel, phonon-devel, cmake, qt5-qtlocation, qt5-qtbase)
OK.

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

[Bug 1224390] Review Request: ignition-math - Small, Fast, High Performance Math Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1224390

Rich Mattes richmat...@gmail.com changed:

   What|Removed |Added

 Blocks||1225692




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1225692
[Bug 1225692] Tracker for Fedora Robotics SIG
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review