[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #20 from Fedora Update System --- jmh-1.10.5-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System --- jmh-1.10.5-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update jmh'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14608 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #18 from Fedora Update System --- jmh-1.10.5-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14608 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #17 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #16 from gil cattaneo --- (In reply to Jonny Heggheim from comment #15) > Is the status correct now? Yes thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #15 from Jonny Heggheim --- Is the status correct now? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 Jonny Heggheim changed: What|Removed |Added Assignee|nob...@fedoraproject.org|heg...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 Jonny Heggheim changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #14 from gil cattaneo --- Jonny, re-assign the bug to you, please -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 Jonny Heggheim changed: What|Removed |Added Assignee|heg...@gmail.com|nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #13 from gil cattaneo --- Sorry ... dont generate a branch for F22 New Package SCM Request === Package Name: jmh Short Description: Java Microbenchmark Harness Upstream URL: http://openjdk.java.net/projects/code-tools/jmh/ Owners: gil Branches: f23 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #12 from gil cattaneo --- Please, changes Status field in "assigned" Thanks in advance -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from gil cattaneo --- New Package SCM Request === Package Name: jmh Short Description: Java Microbenchmark Harness Upstream URL: http://openjdk.java.net/projects/code-tools/jmh/ Owners: gil Branches: f22 f23 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #10 from gil cattaneo --- (In reply to Jonny Heggheim from comment #9) > Approved! > > You decide if you leave the license header like now or change it as > suggested in comment #7 Done. Spec URL: https://gil.fedorapeople.org/jmh.spec SRPM URL: https://gil.fedorapeople.org/jmh-1.10.5-2.fc22.src.rpm - fix samples sub-package license Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 Jonny Heggheim changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Jonny Heggheim --- Approved! You decide if you leave the license header like now or change it as suggested in comment #7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #8 from Jonny Heggheim --- > Done. I await the reply by jmh mail list. > http://mail.openjdk.java.net/pipermail/jmh-dev/2015-August/002037.html > I am not aware of where their bug tracker ... :( I could not find it either :\ > Already documented (near the license field) I missed it > This package is for rawhide (at most for f23). in these 2 branches these > directories should be handled by our java tools and do not need to add extra > owned directories. see file.dir file if you use fedora >= 22 in the > 1246846-jmh folder Great, I did not know :) > If is not a problem i prefer leave as is Not a problem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846
--- Comment #7 from Jonny Heggheim ---
Would it make sense to change the license to reflect each package?
$ diff -U 1 jmh.spec jmh-jonny.spec
--- jmh.spec2015-08-29 15:17:43.0 +0200
+++ jmh-jonny.spec2015-08-29 17:41:32.230865881 +0200
@@ -7,3 +7,3 @@
# 2 files have unknown license, reported @
http://mail.openjdk.java.net/pipermail/jmh-dev/2015-August/002037.html
-License: BSD and GPLv2 with exceptions
+License: GPLv2 with exceptions
URL: http://openjdk.java.net/projects/code-tools/jmh/
@@ -75,2 +75,3 @@
Summary: JMH Samples
+License: BSD
$ rpm -qp --queryformat '%{NAME}: %{LICENSE}\n' jmh-*.noarch.rpm
jmh: GPLv2 with exceptions
jmh-core-benchmarks: GPLv2 with exceptions
jmh-core-ct: GPLv2 with exceptions
jmh-core-it: GPLv2 with exceptions
jmh-generator-annprocess: GPLv2 with exceptions
jmh-generator-asm: GPLv2 with exceptions
jmh-generator-bytecode: GPLv2 with exceptions
jmh-generator-reflection: GPLv2 with exceptions
jmh-javadoc: GPLv2 with exceptions
jmh-parent: GPLv2 with exceptions
jmh-samples: BSD
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #6 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/jmh.spec SRPM URL: https://gil.fedorapeople.org/jmh-1.10.5-1.fc22.src.rpm - update to 1.10.5 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10879637 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #5 from gil cattaneo --- (In reply to Jonny Heggheim from comment #4) > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "BSD (3 clause)", "GPL (v2)", "Unknown or generated". 2 files > have unknown license. > jmh-65fdc5d5f65d/jmh-core/src/main/java/org/openjdk/jmh/annotations/ > Benchmark.java > jmh-65fdc5d5f65d/jmh-core/src/main/java/org/openjdk/jmh/profile/ > WinPerfAsmProfiler.java > > Please contact upstream to clarify licensing. Best if they put proper > license header and release new version. Done. I await the reply by jmh mail list. http://mail.openjdk.java.net/pipermail/jmh-dev/2015-August/002037.html I am not aware of where their bug tracker ... :( > [x]: License file installed when any subpackage combination is installed. > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > All packages are GPL, except samples that is BSD Already documented (near the license field) > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/share/maven-poms/jmh, /usr/share/java/jmh > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/java/jmh, > /usr/share/maven-poms/jmh This package is for rawhide (at most for f23). in these 2 branches these directories should be handled by our java tools and do not need to add extra owned directories. see file.dir file if you use fedora >= 22 in the 1246846-jmh folder > This is my second review. Overall good package, I would also consider moving > the Maven metadata in jmh-parent into jmh-core (like how jsch-agent-proxy > does it) If is not a problem i prefer leave as is -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846
--- Comment #4 from Jonny Heggheim ---
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "GPL (v2)", "Unknown or generated". 2 files
have unknown license.
jmh-65fdc5d5f65d/jmh-core/src/main/java/org/openjdk/jmh/annotations/Benchmark.java
jmh-65fdc5d5f65d/jmh-core/src/main/java/org/openjdk/jmh/profile/WinPerfAsmProfiler.java
Please contact upstream to clarify licensing. Best if they put proper license
header and release new version.
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
All packages are GPL, except samples that is BSD
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/maven-poms/jmh, /usr/share/java/jmh
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/java/jmh,
/usr/share/maven-poms/jmh
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 Jonny Heggheim changed: What|Removed |Added Assignee|nob...@fedoraproject.org|heg...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 Jonny Heggheim changed: What|Removed |Added CC||akurt...@redhat.com, ||heg...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #3 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/jmh.spec SRPM URL: https://gil.fedorapeople.org/jmh-1.10.4-1.fc22.src.rpm - update to 1.10.4 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10784083 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #2 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/jmh.spec SRPM URL: https://gil.fedorapeople.org/jmh-1.10.3-1.fc22.src.rpm - update to 1.10.3 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10703274 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #1 from gil cattaneo --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10487833 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246846] Review Request: jmh - Java Microbenchmark Harness
https://bugzilla.redhat.com/show_bug.cgi?id=1246846 gil cattaneo changed: What|Removed |Added Blocks||1245633 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1245633 [Bug 1245633] metrics-3.1.2 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
