[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 --- Comment #11 from Fedora Update System --- zeal-0.1.1-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2015-10-31 22:36:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 --- Comment #10 from Fedora Update System --- zeal-0.1.1-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 --- Comment #9 from Fedora Update System --- zeal-0.1.1-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update zeal' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-758f0f8d38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- zeal-0.1.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update zeal' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-c4ab19fa91 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 --- Comment #7 from Fedora Update System --- zeal-0.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-c4ab19fa91 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 --- Comment #6 from Michel Alexandre Salim --- Excellent, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 Jackson Isaac changed: What|Removed |Added Flags|fedora-review? |fedora-review+ |needinfo?(jacksonisaac2008@ | |gmail.com) | --- Comment #5 from Jackson Isaac --- Hi, Looks good to me. Review + from me. Thank you for adding relevant links of mail discussions and upstream issue link in the spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 Michel Alexandre Salim changed: What|Removed |Added Status|NEW |ASSIGNED Flags||needinfo?(jacksonisaac2008@ ||gmail.com) --- Comment #4 from Michel Alexandre Salim --- Per FESCo meeting minutes, bundling is now allowed provided the package does not work without, upstream has been contacted (and the conversation recorded) and the package metadata shows what is bundled: https://lists.fedoraproject.org/pipermail/devel/2015-October/215429.html https://paste.fedoraproject.org/276064/44243383/ Package is now updated (plus adding the license info for qxt files) Spec URL: https://salimma.fedorapeople.org/specs/devtools/zeal.spec SRPM URL: https://salimma.fedorapeople.org/specs/devtools/zeal-0.1.1-2.fc23.src.rpm COPR builds: https://copr.fedoraproject.org/coprs/salimma/zeal/builds/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885
Michel Alexandre Salim changed:
What|Removed |Added
Flags|needinfo?(michel@michel-slm |
|.name) |
--- Comment #3 from Michel Alexandre Salim ---
(In reply to Jackson Isaac from comment #2)
> In Source0 is the '#/%{name}-%{version}.tar.gz' (Git tag) necessary ? The
> release tarball and url with tag link/points to the same file.
>
Yes. You can try doing spectool -gf on the spec file without the
#/%{name}-%{version}.tar.gz -- you'll get v%{version}.tar.gz as the file name.
They do not point to the same file. There's a mailing list discussion about
this (how best to get properly-named source tarballs out of Github).
> There are few issues related to licensing and 3rd party libraries being
> included in the source.
>
I don't think there's an issue with licensing (apart from needing to update the
license info), but inclusion of 3rd party lib is indeed bad, let me see if I
can build zeal against the upstream libqxt instead.
> I tried running zeal and clicked on open url but nothing opened up. I don't
> know if that if the desired behavior or I did something wrong.
>
Hmm, what Open URL? You need to go to File->Options, switch to the Docsets tab
and install something.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885
Jackson Isaac changed:
What|Removed |Added
CC||mic...@michel-slm.name
Flags||needinfo?(michel@michel-slm
||.name)
--- Comment #2 from Jackson Isaac ---
In Source0 is the '#/%{name}-%{version}.tar.gz' (Git tag) necessary ? The
release tarball and url with tag link/points to the same file.
There are few issues related to licensing and 3rd party libraries being
included in the source.
I tried running zeal and clicked on open url but nothing opened up. I don't
know if that if the desired behavior or I did something wrong.
Other than that looks good to me.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in /home/jacksonisaac/fedora-
review/1265885-zeal/diff.txt
See: http://fedoraproject.org/wiki/Packaging/SourceURL
- update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in zeal
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
database
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "Unknown or generated". 50 files have unknown
license. Detailed output of licensecheck in /home/jacksonisaac/fedora-
review/1265885-zeal/licensecheck.txt
==> Files under src/3rdparty/qxtglobalshortcut/ are licensed with BSD 3 Clause
by The libQtx project and also GPL 3 by the zeal project.
Refer
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
==> There is a fork of third party package under src/3rdparty/. This is also a
reason for the licensing issue mentioned above.
Refer https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Licensing
If possible, it can be packaged as a subpackage. Awaiting reply from the
contributor for further clarification.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in zeal
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 Jackson Isaac changed: What|Removed |Added CC||jacksonisaac2...@gmail.com Assignee|nob...@fedoraproject.org|jacksonisaac2...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1265885] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1265885 --- Comment #1 from Michel Alexandre Salim --- COPR builds: https://copr.fedoraproject.org/coprs/salimma/zeal/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
