[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Blocks||201449 (FE-DEADREVIEW)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/V6FIPGWBHMG3BV7HYDNSTXBW7HZBW3IZ/

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(i.gnatenko.brain@ |
   |gmail.com)  |
Last Closed||2018-08-22 03:30:22



--- Comment #10 from Igor Gnatenko  ---
Unfortunately I don't have time to work on these review requests anymore,
sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MUCSPLLHMXP6WZKZSM6YWIOZBMWG7OME/

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579



--- Comment #9 from Ankur Sinha (FranciscoD)  ---
Ping? :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YEI74EN4AG2GX764HPJKXQCPNA7KELWR/

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 CC||sanjay.an...@gmail.com
  Flags||needinfo?(i.gnatenko.brain@
   ||gmail.com)



--- Comment #8 from Ankur Sinha (FranciscoD)  ---
Hello,

If the package has been reviewed, should we import it to SCM?

Cheers!
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ASHH476EU7HUQ4IYL3APOWCNKJ6JCTVV/

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Bug 1279579 depends on bug 1291010, which changed state.

Bug 1291010 Summary: [ARM] terminate called after throwing an instance of 
'std::length_error'
https://bugzilla.redhat.com/show_bug.cgi?id=1291010

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |EOL



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Igor Gnatenko  changed:

   What|Removed |Added

  Alias|itktools|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Mike McCune  changed:

   What|Removed |Added

 Status|MODIFIED|POST



--- Comment #7 from Mike McCune  ---
This bug was accidentally moved from POST to MODIFIED via an error in
automation, please see mmcc...@redhat.com with any questions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Sat6QE Jenkins  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
Packaging is OK. Let's hope we can get #1291010 fixed at some point.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Depends On||1291010




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1291010
[Bug 1291010] [ARM] terminate called after throwing an instance of
'std::length_error'
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579



--- Comment #4 from Upstream Release Monitoring 
 ---
ignatenkobrain's scratch build of itktools-0.3.1-0.2.git5a21673.fc24.src.rpm
for f24 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12082859

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579



--- Comment #3 from Igor Gnatenko  ---
New SPEC: https://ignatenkobrain.fedorapeople.org/neurofedora/itktools.spec
New SRPM:
https://ignatenkobrain.fedorapeople.org/neurofedora/itktools-0.3.1-0.2.git5a21673.fc24.src.rpm

I'm not sure if I did exclude tests properly, but I kicked off scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=12082859

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579



--- Comment #5 from Igor Gnatenko  ---
All tests failed on arm due to
26: Test timeout computed to be: 1500
26: terminate called after throwing an instance of 'std::length_error'
26:   what():  vector::_M_fill_insert

I see the same problem with DiffusionKurtosisFit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279579] Review Request: ITKTools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||itktools



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279579] Review Request: itktools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Igor Gnatenko  changed:

   What|Removed |Added

Summary|Review Request: ITKTools -  |Review Request: itktools -
   |Practical command line  |Practical command line
   |tools based on the ITK  |tools based on the ITK
  Alias|ITKTools|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279579] Review Request: ITKTools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
The name should really be lowercase, it's a bother to remember complex
capitalization.
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming says
"Package names should be in lower case and use dashes in preference to
underscores."

You *could* build the documentation, would be nice to have a pdf with the help.

No need to rm -rf build/ in %prep: %autosetup will recreate the whole source
directory anyway. This applies also to a few other packages that I reviewed; I
forgot to mention it before.

#!/usr/bin/env python3 → #!/usr/bin/python3.

- license is OK (Apache)
- license file is present, %license is used
- latest version
- no scriptlets needed or present
- package builds and installs

Build fails in tests, I'll kick of a scratch build.


Note to self: check explicit Requires: python3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279579] Review Request: ITKTools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579



--- Comment #2 from Upstream Release Monitoring 
 ---
zbyszek's scratch build of ITKTools-0.3.1-0.1.git5a21673.fc24.src.rpm for
rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12024667

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279579] Review Request: ITKTools - Practical command line tools based on the ITK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279579

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1276941 (fedora-neuro)
  Alias||ITKTools




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review