[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2016-01-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #24 from Anssi Johansson  ---
The above EPEL6 osbs-client issue is being tracked in bug 1296032.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2016-01-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #22 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2016-01-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #21 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.el5 has been pushed to the Fedora EPEL 5 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2016-01-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #20 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2016-01-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #19 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2016-01-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-05 16:36:40



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2016-01-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #18 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #16 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update koji-containerbuild'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-e856684420

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #17 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update koji-containerbuild'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-18264539b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #15 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update koji-containerbuild'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-5b67cbb3ff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #14 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update koji-containerbuild'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-fae06c3c21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.el5 has been pushed to the Fedora EPEL 5 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update koji-containerbuild'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-62912880b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #12 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.el5 has been submitted as an update to Fedora EPEL
5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-62912880b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #11 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.el6 has been submitted as an update to Fedora EPEL
6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-e856684420

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #10 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-18264539b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #9 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-fae06c3c21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #8 from Fedora Update System  ---
koji-containerbuild-0.5.5-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-5b67cbb3ff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/koji-containerbuild

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400

Adam Miller  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Adam Miller  ---
APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #5 from Pavol Babinčák  ---
Spec URL:
https://pbabinca.fedorapeople.org/koji-containerbuild/koji-containerbuild.spec
SRPM URL:
https://pbabinca.fedorapeople.org/koji-containerbuild/koji-containerbuild-0.5.5-1.fc23.src.rpm

Differences from previous srpm:
https://github.com/release-engineering/koji-containerbuild/compare/koji-containerbuild-0.5.4-3...koji-containerbuild-0.5.5-1


(In reply to Adam Miller from comment #4)
> Notes
> -
> 
> The subpackages are missing the license.
Fixed.

> 
> BuildRoot definition is no longer needed, please remove it.
> 
> %clean section is no longer needed, please remove it.
> 
These are needed for EPEL 5 https://fedoraproject.org/wiki/EPEL:Packaging So I
guess you can use fedora-review -D EPEL5. I'm not sure how to solve the issue
it printed:

- EPEL5: Package does run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
  beginning of %install.

as spec file has that in the beginning of %install.


> %define should be %global unless there's a specific need for %define in
> macro expansion.
> 
Fixed.

> There is technically a dangling directory of /usr/lib/koji-builder-plugins
> but I think that's fine since the dependency chain will pull that. You could
> alternatively have the package own the directory just for good house
> keeping. I don't have a firm opinion about it though and I don't consider it
> a blocker for package review.
I see. I guess koji could own that directory. But currently there are no
plugins nor configuration in koji to reference that directory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #4 from Adam Miller  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later)", "Unknown or generated". 11 files have
 unknown license. Detailed output of licensecheck in
 /home/admiller/reviews/1284400-koji-containerbuild/review-koji-
 containerbuild/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/koji-builder-plugins
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/koji-builder-plugins,
 /usr/lib/koji-hub-plugins
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Buildroot is not present
 Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in koji-
 containerbuild-hub , koji-containerbuild-builder , koji-
 containerbuild-cli
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or dow

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-12-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #3 from Pavol Babinčák  ---
Spec URL:
https://pbabinca.fedorapeople.org/koji-containerbuild/koji-containerbuild.spec
SRPM URL:
https://pbabinca.fedorapeople.org/koji-containerbuild/koji-containerbuild-0.5.4-3fc23.src.rpm
Description: Koji support for building layered container images
Fedora Account System Username: pbabinca

Differences from previous srpm:
https://github.com/release-engineering/koji-containerbuild/compare/koji-containerbuild-0.5.4-2...koji-containerbuild-0.5.4-3

Differences from previously linked spec file:
https://github.com/release-engineering/koji-containerbuild/compare/35196bb9e1b4d8e73fa7441ccdb05a826198e81a...koji-containerbuild-0.5.4-3

This time spec file should create the same srpm as provided in URL above.

For the record previous spec and srpm are located here:
https://pbabinca.fedorapeople.org/koji-containerbuild/previous-2015-11-23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #2 from Adam Miller  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Permissions on files are set properly.
  Note: See rpmlint output
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- Package contains BR: python2-devel or python3-devel
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later)", "Unknown or generated". 11 files have
 unknown license. Detailed output of licensecheck in
 /home/admiller/reviews/1284400-koji-containerbuild/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/koji-builder-plugins,
 /usr/lib/python2.7/site-packages/koji_containerbuild
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/koji-builder-plugins,
 /usr/lib/python2.7/site-packages/koji_containerbuild, /usr/lib/koji-
 hub-plugins
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Buildroot is not present
 Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and re

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-11-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400

Adam Miller  changed:

   What|Removed |Added

 CC||admil...@redhat.com
   Assignee|nob...@fedoraproject.org|admil...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

2015-11-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #1 from Pavol Babinčák  ---
Spec URL:
https://raw.githubusercontent.com/release-engineering/koji-containerbuild/develop/koji-containerbuild.spec
SRPM URL:
https://pbabinca.fedorapeople.org/koji-containerbuild/koji-containerbuild-0.5.4-2fc23.src.rpm
Description: Koji support for building layered container images
Fedora Account System Username: pbabinca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review