[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #61 from Fedora Update System --- FEDORA-2020-7d4505de5e has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #60 from Fedora Update System --- FEDORA-2020-1f943f6cc7 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-04-01 00:17:03 --- Comment #59 from Fedora Update System --- FEDORA-2020-7d4505de5e has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #58 from Fedora Update System --- FEDORA-2020-9185d89caf has been pushed to the Fedora 30 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-9185d89caf` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9185d89caf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #57 from Fedora Update System --- FEDORA-2020-1f943f6cc7 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-1f943f6cc7` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-1f943f6cc7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Fedora Update System changed: What|Removed |Added Status|NEW |ON_QA --- Comment #56 from Fedora Update System --- FEDORA-2020-7d4505de5e has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-7d4505de5e` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d4505de5e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Status|MODIFIED|NEW --- Comment #55 from José Matos --- Thank you Neal. I think that now we should be awarded the "Spring cleanings" badge. :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #54 from Fedora Update System --- FEDORA-2020-9185d89caf has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9185d89caf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #53 from Neal Gompa --- Looks good to me. With that, this package is finally APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #52 from José Matos ---
(In reply to Neal Gompa from comment #51)
> The only remaining issue is that you're missing the following line in the
> python-nikola-doc subpackage files section:
>
> > %dir %{_datadir}/doc/%{pypi_name}
>
> Please add that.
Good catch, now on hindsight it is obvious. :-)
I have added that line not to python-nikola-doc but to nikola that installs it.
Spec URL: https://jamatos.fedorapeople.org/python-nikola.spec
SRPM URL: https://jamatos.fedorapeople.org/python-nikola-8.0.4-9.fc32.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #51 from Neal Gompa ---
The only remaining issue is that you're missing the following line in the
python-nikola-doc subpackage files section:
> %dir %{_datadir}/doc/%{pypi_name}
Please add that.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #50 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/doc/nikola
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/doc/nikola
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 184320 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds i
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #49 from José Matos ---
(In reply to Neal Gompa from comment #48)
> Err strike that, it should be instead:
>
> > Source0:
> > https://github.com/getnikola/nikola/archive/v%{version}/nikola-%{version}.tar.gz
New version with that change incorporated:
Spec URL: https://jamatos.fedorapeople.org/python-nikola.spec
SRPM URL: https://jamatos.fedorapeople.org/python-nikola-8.0.4-8.fc32.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #48 from Neal Gompa ---
Err strike that, it should be instead:
> Source0:
> https://github.com/getnikola/nikola/archive/v%{version}/nikola-%{version}.tar.gz
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #47 from Neal Gompa ---
Please fix SourceURL:
> Source0:https://github.com/getnikola/nikola/archive/v%{version}.tar.gz
This should be the following:
> Source0:
> https://github.com/getnikola/nikola/archive/v%{version}/%{name}-%{version}.tar.gz
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #46 from José Matos --- (In reply to Neal Gompa from comment #45) > The Requires: and Provides: lines you have need to move to the > python3-nikola subpackage definition. They don't take effect otherwise. You are right. New sources here: Spec URL: https://jamatos.fedorapeople.org/python-nikola.spec SRPM URL: https://jamatos.fedorapeople.org/python-nikola-8.0.4-6.fc32.src.rpm I have removed tabs from the spec file, I did not mentioned in the changes because it mainly a cosmetic change. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #45 from Neal Gompa --- The Requires: and Provides: lines you have need to move to the python3-nikola subpackage definition. They don't take effect otherwise. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Flags|needinfo?(jama...@fc.up.pt) | --- Comment #44 from José Matos --- (In reply to Neal Gompa from comment #43) > > Please document the bundled dependencies and their versions and why, per the > policy. > > Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling > Cf. > https://fedoraproject.org/wiki/Bundled_Libraries#Requirement_if_you_bundle > > I would prefer to see tzlocal unbundled, though I can accept this upstream > preferring otherwise as long as it is documented properly. FWIW I agree with you and I intend to work on unbundling tzlocal, if possible to have this work applied upstream. The other module it is not in pypi and so not it causes less concern. The new version with just that change is here: Spec URL: https://jamatos.fedorapeople.org/python-nikola.spec SRPM URL: https://jamatos.fedorapeople.org/python-nikola-8.0.4-6.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Neal Gompa changed: What|Removed |Added Flags|needinfo?(ngomp...@gmail.co |needinfo?(jama...@fc.up.pt) |m) | --- Comment #43 from Neal Gompa --- (In reply to José Matos from comment #42) > Hi Neal, > > what is missing in this review? > > > FWIW in my todo list there is just a small issue, that can be done at ay > time. > According to nikola's source: > > """ > We ship some third-party things with Nikola. They live here, along with > their > licenses. > > Packages: > > * tzlocal by Lennart Regebro, CC0 license (modified) > * datecond by Chris Warrick (Nikola contributor), 3-clause BSD license >(modified) > """ > > The second is very small and from one of nikola's main contributors. > I asked about tzlocal and it can be done, with just a small change, either by > using the system tzlocal and by changing to pytz: > https://groups.google.com/forum/#!topic/nikola-discuss/3vXZFJF_-h4 Please document the bundled dependencies and their versions and why, per the policy. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling Cf. https://fedoraproject.org/wiki/Bundled_Libraries#Requirement_if_you_bundle I would prefer to see tzlocal unbundled, though I can accept this upstream preferring otherwise as long as it is documented properly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Flags||needinfo?(ngomp...@gmail.co ||m) --- Comment #42 from José Matos --- Hi Neal, what is missing in this review? FWIW in my todo list there is just a small issue, that can be done at ay time. According to nikola's source: """ We ship some third-party things with Nikola. They live here, along with their licenses. Packages: * tzlocal by Lennart Regebro, CC0 license (modified) * datecond by Chris Warrick (Nikola contributor), 3-clause BSD license (modified) """ The second is very small and from one of nikola's main contributors. I asked about tzlocal and it can be done, with just a small change, either by using the system tzlocal and by changing to pytz: https://groups.google.com/forum/#!topic/nikola-discuss/3vXZFJF_-h4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #41 from Solomon Peachy --- I just finished porting my site; had to redo a bunch of templates but that was expected. Thanks for getting a modern nikola version properly packaged! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #40 from José Matos --- New version: Spec URL: https://download.copr.fedorainfracloud.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/01308945-python-nikola/python-nikola.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/01308945-python-nikola/python-nikola-8.0.4-5.fc33.src.rpm Add the obsoletes to nikola to cope with any possible upgrade path. Meanwhile since python.markdown is available in Fedora 31 I made the tests universal. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #39 from Solomon Peachy --- Adding obseletes tags sounds like a fine idea. I installed the COPR packages over the top of my 7.8.15 packages, which in turn were (heavily) modified from the pre-retirement 7.7.11-3.fc24 packages. (Other than the version bump the main change was a complete removal of the python2 subpackages) (I'm still working on getting my site to generate with v8.0, I think all that remains is porting my old theme) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #38 from José Matos --- Which version did you had installed? One option is for nikola to obsolete python2 or python3 subpackages older than 8. In nikola: Obsoletes: python2-nikola < 8 Obsoletes: python3-nikola < 8 What do you think? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #37 from Solomon Peachy --- Ah! you are correct, I didn't have the 'nikola' subpackage installed. But the thing is, I was upgrading over the old, pre-retirement python3-nikola package (which I'd been rebuilding and updating all this while), which didn't use a separate subpackage for the main executable.. I can easily see other folks making this same mistake... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #36 from José Matos --- (In reply to Solomon Peachy from comment #35) > FWIW, the nikola-8.0.4-4.fc31 package in the COPR doesn't work; there's no > 'nikola' binary. Have you installed the nikola subpackage? $ rpm -ql nikola /usr/bin/nikola /usr/share/doc/nikola/extending.rst /usr/share/doc/nikola/manual.rst /usr/share/doc/nikola/theming.rst /usr/share/licenses/nikola /usr/share/licenses/nikola/LICENSE.txt /usr/share/man/man1/nikola.1.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #35 from Solomon Peachy --- FWIW, the nikola-8.0.4-4.fc31 package in the COPR doesn't work; there's no 'nikola' binary. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #34 from José Matos --- The spec URL was right but the srpm was not, it should be: SRPM URL: https://download.copr.fedorainfracloud.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/01285992-python-nikola/python3-nikola-8.0.4-4.fc33.noarch.rpm There was typo, it was not release 3 but release 4 as it is in the spec file. The build was already complete in copr so it was my fault in copy and pasting. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #33 from José Matos --- Changed the requirement from git to git-core: Spec URL: https://download.copr.fedorainfracloud.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/01285459-python-nikola/python-nikola.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/01285459-python-nikola/python-nikola-8.0.4-3.fc33.src.rpm What is missing now? :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #32 from Neal Gompa --- Use "git-core" instead of "git" to reduce the build dependencies to what you just need for "%autosetup -S git" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #31 from José Matos --- OK. New version that calls directly pytest. Spec URL: https://download.copr.fedorainfracloud.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/01285459-python-nikola/python-nikola.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/01285459-python-nikola/python-nikola-8.0.4-3.fc33.src.rpm The conditional code can be removed as soon as python3-markup update lands in F31: https://bodhi.fedoraproject.org/updates/FEDORA-2020-75db077717 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #30 from Elliott Sales de Andrade --- Upstream tests using the pytest executable directly, so you should just do that and not bother with `python setup.py test`. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #29 from José Matos --- (In reply to Neal Gompa from comment #27) > (In reply to Elliott Sales de Andrade from comment #26) > > Neal? > > Could you update to 8.0.3 and also fill out the changelog for your updates? > The changelog is missing information about your version bump... I have been busy at lot more than what I was expecting. :-( Let us see if this now finally is ready. Spec URL: https://download.copr.fedorainfracloud.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/01251909-python-nikola/python-nikola.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/01251909-python-nikola/python-nikola-8.0.4-2.fc33.src.rpm Caveats: - the tests fail on F30 (possibly a missing dependency, actually the dependency in F30 too ancient for the requirements). - on F31 it runs 0 tests there is a warning saying: WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #28 from José Matos --- (In reply to Neal Gompa from comment #27) > (In reply to Elliott Sales de Andrade from comment #26) > > Neal? > > Could you update to 8.0.3 and also fill out the changelog for your updates? > The changelog is missing information about your version bump... I am quite busy in the next couple of weeks, but after the Friday 13th my available time will allow me to do this and other updates that have pilling up. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Neal Gompa changed: What|Removed |Added Flags|needinfo?(ngomp...@gmail.co | |m) | --- Comment #27 from Neal Gompa --- (In reply to Elliott Sales de Andrade from comment #26) > Neal? Could you update to 8.0.3 and also fill out the changelog for your updates? The changelog is missing information about your version bump... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Elliott Sales de Andrade changed: What|Removed |Added Flags||needinfo?(ngomp...@gmail.co ||m) --- Comment #26 from Elliott Sales de Andrade --- Neal? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Bug 1353169 depends on bug 1718688, which changed state. Bug 1718688 Summary: Review Request: python-phpserialize - a port of the serialize and unserialize functions of php to python https://bugzilla.redhat.com/show_bug.cgi?id=1718688 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Bug 1353169 depends on bug 1718687, which changed state. Bug 1718687 Summary: Review Request: python-typogrify - Filters to enhance web typography, including support for Django & Jinja templates https://bugzilla.redhat.com/show_bug.cgi?id=1718687 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Bug 1353169 depends on bug 1718686, which changed state. Bug 1718686 Summary: Review Request: python-ghp-import2 - A GitHub Pages import tool https://bugzilla.redhat.com/show_bug.cgi?id=1718686 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Bug 1353169 depends on bug 1718685, which changed state. Bug 1718685 Summary: Review Request: python-smartypants - Python with the SmartyPants https://bugzilla.redhat.com/show_bug.cgi?id=1718685 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Bug 1353169 depends on bug 1718682, which changed state. Bug 1718682 Summary: Review Request: python-micawber - a small library for extracting rich content from urls https://bugzilla.redhat.com/show_bug.cgi?id=1718682 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #25 from José Matos --- Update to the latest stable release with all the required dependencies available: Spec URL: https://copr-be.cloud.fedoraproject.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/00929296-python-nikola/python-nikola.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jamatos/nikola-playground/fedora-rawhide-x86_64/00929296-python-nikola/python-nikola-8.0.2-1.fc31.src.rpm This package and all the other python packages that this package requires are available at https://copr.fedorainfracloud.org/coprs/jamatos/nikola-playground/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Depends On||1718688 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1718688 [Bug 1718688] Review Request: python-phpserialize - a port of the serialize and unserialize functions of php to python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Depends On||1718687 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1718687 [Bug 1718687] Review Request: python-typogrify - Filters to enhance web typography, including support for Django & Jinja templates -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Depends On||1718686 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1718686 [Bug 1718686] Review Request: python-ghp-import2 - A GitHub Pages import tool -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Depends On||1718685 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1718685 [Bug 1718685] Review Request: python-smartypants - Python with the SmartyPants -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Depends On||1718682 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1718682 [Bug 1718682] Review Request: python-micawber - a small library for extracting rich content from urls -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #24 from José Matos --- (In reply to Neal Gompa from comment #23) > > as compared with the large list of Requires: but I am not sure how the > > package pinning that upstream uses will play with this. For some packages, > > sometimes the requirement specifies a particular version. > > You'll have to edit that anyway, since the nikola executable is a setuptools > wrapper that would validate dependencies anyway. I does not that, at least for the version available in copr: python-nikola-7.8.15-2. It has been working without any complaints even although I changed the Requires field in spec but not the requirements.txt. I have used the basic stuff: nikola build nikola clean nikola new_page ... FWIW what you say makes sense :-) but I do not see it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #23 from Neal Gompa --- > as compared with the large list of Requires: but I am not sure how the > package pinning that upstream uses will play with this. For some packages, > sometimes the requirement specifies a particular version. You'll have to edit that anyway, since the nikola executable is a setuptools wrapper that would validate dependencies anyway. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
José Matos changed:
What|Removed |Added
Flags|needinfo?(jama...@fc.up.pt) |
--- Comment #22 from José Matos ---
(In reply to Neal Gompa from comment #21)
> nikola 8.0rc1 is out: https://getnikola.com/blog/nikola-v800rc1-is-out.html
>
> You might want to target this, as barring any grave issues, it'll become 8.0.
I saw that, but for the moment I am busy with other issues
(traveling/conference).
In a cursory look it seems as if the requirements for ws4py was dropped
replaced by python3-aiohttp that is already in python.
There is a new dependency for python-babel that is already in fedora.
So in terms of new dependencies this is good news. :-)
So it should be easy after the submission of some of the packages that are on
copr to get nikola 8 ready for review.
Two points that may show later:
1) regarding the previous packaged version I removed the python?-nikola-extras
because the dependencies size is very small when compared with the main
package;
2) it would be nice to use the automatic python requirement generator:
%{?python_enable_dependency_generator}
as compared with the large list of Requires: but I am not sure how the package
pinning that upstream uses will play with this. For some packages, sometimes
the requirement specifies a particular version.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Neal Gompa changed: What|Removed |Added Flags||needinfo?(jama...@fc.up.pt) --- Comment #21 from Neal Gompa --- nikola 8.0rc1 is out: https://getnikola.com/blog/nikola-v800rc1-is-out.html You might want to target this, as barring any grave issues, it'll become 8.0. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Flags|needinfo?(jama...@fc.up.pt) | --- Comment #20 from José Matos --- (In reply to Elliott Sales de Andrade from comment #19) > Any more updates? Hi Elliot, I was expecting for nikola 8.0.0 release to rebase the spec file. Since it is taking longer than I was expecting, I decided to proceed with the latest stable release 7.8.15. I have a working spec file and I have created rpms for all the remaining python packages that were not yet packaged in fedora. In one case I had to create another package because it was a dependency for one of the packages that nikola requires. The final result is in copr: https://copr.fedorainfracloud.org/coprs/jamatos/nikola-playground/ The srpms are at https://jamatos.fedorapeople.org/python-nikola/ From the dependencies of nikola there is one that has problems building in Fedora 29/rawhide: python-ws4py because of async being a keyword in python 3.7. That is the only one that is commented in the Requires/BuildRequires. Some others have issues with %check for several issues. I have disabled temporarily those tests to have a working prototype. My only issue with python-nikola as it is is the bundling of several components, including themes and java script. For some of the fonts it is possible like it was done before to replace the contents with symbolic links (that is the purpose of the Requires glyphicons-halflings-fonts that is not yet used but that has at least 4 copies). I will be busy in the next couple of weeks and I intend to proceed with the process, cleaning and submitting the other python packages until that finally python-nikola is ready for consideration. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com Flags||needinfo?(jama...@fc.up.pt) --- Comment #19 from Elliott Sales de Andrade --- Any more updates? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Bug 1353169 depends on bug 1372345, which changed state. Bug 1372345 Summary: Review Request: python-piexif - Pure Python library to simplify exif manipulations with python https://bugzilla.redhat.com/show_bug.cgi?id=1372345 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Flags|needinfo?(jama...@fc.up.pt) | --- Comment #18 from José Matos --- I am, but right now I am at a time where real live is getting in the way. Lots of exams and tests to assess. :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Neal Gompa changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Neal Gompa changed: What|Removed |Added CC||jama...@fc.up.pt Flags||needinfo?(jama...@fc.up.pt) --- Comment #17 from Neal Gompa --- @Jose: Are you still interested in reviving nikola? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added CC||domi...@greysector.net --- Comment #16 from Dominik 'Rathann' Mierzejewski --- FYI, nikola-7.8.1 was released recently. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #15 from Igor Gnatenko ---
(In reply to José Matos from comment #14)
> (In reply to Neal Gompa from comment #13)
> > I agree with Igor here. If this can't be used as a Python module, then it
> > shouldn't be packaged in such a manner.
>
> My first reaction was, oh no we are not getting one more time in the
> argument of python modules versus python applications... :-)
>
> In the defense of the python- prefix in the name we can consider that:
>
> * nikola is available through pypi.python.org
> https://pypi.python.org/pypi/Nikola
All python crap is distributed there ;)
>
> * the package consist mostly of a python module with a script on /usr/bin
> that is a wrapper that calls the nikola module:
> if __name__ == '__main__':
> sys.exit(
> load_entry_point('Nikola==7.7.12', 'console_scripts', 'nikola')()
> )
Actually question if there is documentation which says import nikola. If it
doesn't it's better to name it nikola and ship only py3 version.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #14 from José Matos ---
(In reply to Neal Gompa from comment #13)
> I agree with Igor here. If this can't be used as a Python module, then it
> shouldn't be packaged in such a manner.
My first reaction was, oh no we are not getting one more time in the argument
of python modules versus python applications... :-)
In the defense of the python- prefix in the name we can consider that:
* nikola is available through pypi.python.org
https://pypi.python.org/pypi/Nikola
* the package consist mostly of a python module with a script on /usr/bin that
is a wrapper that calls the nikola module:
if __name__ == '__main__':
sys.exit(
load_entry_point('Nikola==7.7.12', 'console_scripts', 'nikola')()
)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Depends On||1372345 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1372345 [Bug 1372345] Review Request: python-piexif - Pure Python library to simplify exif manipulations with python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #13 from Neal Gompa --- I agree with Igor here. If this can't be used as a Python module, then it shouldn't be packaged in such a manner. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #12 from Igor Gnatenko ---
(In reply to José Matos from comment #11)
> > > %if 0%{?fedora} <= 24
> > > Provides: python-%{srcname} = %{version}-%{release}
> > > Obsoletes: python-%{srcname} < 7.7.11-1
> > > %endif
> > no way, you should use %python_provide
>
> This is an application that uses python and not a python library.
Then rename package to "nikola" and build only py3 version.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #11 from José Matos ---
> > %if 0%{?fedora} <= 24
> > Provides: python-%{srcname} = %{version}-%{release}
> > Obsoletes: python-%{srcname} < 7.7.11-1
> > %endif
> no way, you should use %python_provide
This is an application that uses python and not a python library.
If, as been suggested in the mailing list, upstream drops support for python 2
do you suggest that python-nikola should provide python2-nikola even if it is
using python3?
If this were a python library that I could use like "import nikola" I would
wholeheartedly agree with you.(In reply to Igor Gnatenko from comment #10)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #10 from Igor Gnatenko ---
> %if 0%{?fedora} <= 24
> Provides: python-%{srcname} = %{version}-%{release}
> Obsoletes: python-%{srcname} < 7.7.11-1
> %endif
no way, you should use %python_provide
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #9 from José Matos --- (In reply to Neal Gompa from comment #8) > If /usr/bin/nikola is functionally equivalent between py2 and py3, why not > just switch it all to py3? Especially since upstream prefers py3 anyway? For historical reasons. :-) Initially nikola was only available on python 2. The python-2 packages allowed to use a set of tools that used the python-2 packages. I did not want to change the main version during F24. But as soon as upstream drops support for python-2 the python2-nikola packages will be obsoleted by the corresponding python3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #8 from Neal Gompa --- If /usr/bin/nikola is functionally equivalent between py2 and py3, why not just switch it all to py3? Especially since upstream prefers py3 anyway? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #7 from José Matos --- (In reply to Neal Gompa from comment #6) > You've still not changed the /usr/bin/nikola link to point to > /usr/bin/nikola3. > > Please do so. Actually that was the first thing I did, in comment 3. :-) Since I had no feedback I decided to continue with current F24 branch, since to make nikola default to nikola3 is a small change. In any case it follows with the corresponding changes: Spec URL: https://jamatos.fedorapeople.org/python-nikola.spec SRPM URL: https://jamatos.fedorapeople.org/python-nikola-7.7.12-2.fc24.src.rpm python-nikola becomes python3-nikola for Fedora > 24 and it continues to be python2-nikola for previous versions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #6 from Neal Gompa --- You've still not changed the /usr/bin/nikola link to point to /usr/bin/nikola3. Please do so. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #5 from José Matos --- Ping again. :-) I have updated the package to 7.7.12: http://koji.fedoraproject.org/koji/buildinfo?buildID=788779 and I have updated correspondingly: Spec URL: https://jamatos.fedorapeople.org/python-nikola.spec SRPM URL: https://jamatos.fedorapeople.org/python-nikola-7.7.12-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #4 from José Matos --- Ping... I am updating the package to the latest version that is available at updates-testing for F24: Spec URL: https://jamatos.fedorapeople.org/python-nikola.spec SRPM URL: https://jamatos.fedorapeople.org/python-nikola-7.7.11-3.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #3 from José Matos --- (In reply to Neal Gompa from comment #1) > Please update the spec to follow the current guidelines (python2 stuff in a > python2 subpackage, unversioned binaries to use the python 3 version, etc.). > > See https://fedoraproject.org/wiki/Packaging:Python Spec URL: https://jamatos.fedorapeople.org/python-nikola.spec SRPM URL: https://jamatos.fedorapeople.org/python-nikola-7.7.9-3.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Neal Gompa changed: What|Removed |Added Assignee|nob...@fedoraproject.org|ngomp...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com --- Comment #1 from Neal Gompa --- Please update the spec to follow the current guidelines (python2 stuff in a python2 subpackage, unversioned binaries to use the python 3 version, etc.). See https://fedoraproject.org/wiki/Packaging:Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
