[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #34 from Fedora Update System --- nitroshare-0.3.2-9.fc24, qhttpengine-0.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-07-21 19:21:14 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #33 from Fedora Update System --- nitroshare-0.3.2-9.fc23, qhttpengine-0.1.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #32 from Fedora Update System --- nitroshare-0.3.2-9.fc24, qhttpengine-0.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-68d6628c64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #31 from Fedora Update System --- nitroshare-0.3.2-9.fc23, qhttpengine-0.1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d951a498d5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #30 from Fedora Update System --- nitroshare-0.3.2-9.fc23 qhttpengine-0.1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d951a498d5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #28 from Fedora Update System --- nitroshare-0.3.2-8.fc23, qhttpengine-0.1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d951a498d5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #27 from Fedora Update System --- nitroshare-0.3.2-8.el7, qhttpengine-0.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9e775d66cb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #26 from Fedora Update System --- nitroshare-0.3.2-8.fc24, qhttpengine-0.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-68d6628c64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #25 from Fedora Update System --- nitroshare-0.3.2-8.el7 qhttpengine-0.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9e775d66cb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #24 from Fedora Update System --- nitroshare-0.3.2-8.fc23 qhttpengine-0.1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d951a498d5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #23 from Fedora Update System --- nitroshare-0.3.2-8.fc24 qhttpengine-0.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-68d6628c64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #22 from Fedora Update System --- nitroshare-0.3.2-6.fc24, qhttpengine-0.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-68d6628c64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #21 from Fedora Update System --- nitroshare-0.3.2-6.fc23, qhttpengine-0.1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d951a498d5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System --- qhttpengine-0.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9e775d66cb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #18 from Fedora Update System --- qhttpengine-0.1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d951a498d5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #19 from Fedora Update System --- qhttpengine-0.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9e775d66cb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #17 from Fedora Update System --- qhttpengine-0.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-68d6628c64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #16 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/qhttpengine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #15 from Raphael Groner --- (In reply to Igor Gnatenko from comment #14) > (In reply to Raphael Groner from comment #13) > > Thanks again! Removing alias to allow general search for package bugs. > > I don't think that it makes sense to remove. It's easier to find review > request. There's a link in PkgDB. An alias blocks RHBZ from full text search. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #14 from Igor Gnatenko --- (In reply to Raphael Groner from comment #13) > Thanks again! Removing alias to allow general search for package bugs. I don't think that it makes sense to remove. It's easier to find review request. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Raphael Groner changed: What|Removed |Added Alias|qhttpengine | --- Comment #13 from Raphael Groner --- Thanks again! Removing alias to allow general search for package bugs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #12 from Igor Gnatenko --- everything looks good, APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184
--- Comment #11 from Raphael Groner ---
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14855484
(In reply to Igor Gnatenko from comment #10)
> > %{?!_pkgdocdir:%global _pkgdocdir %{_docdir}/%{name}}
> could be removed
Needed for EPEL7, %{_pkgdocdir} is not defined there.
> > mkdir -p %{_target_platform}
> better to move into %prep
We don't want an empty folder created for rpmbuild -bp, it's common practice to
do it so in %make.
> > cp -ap examples %{buildroot}%{_pkgdocdir}
> just mark as %doc in -doc subpkg
Guidelines forbid to mix %doc with %{_pkgdocdir}. We've to use %{_pkgdocdir}
cause you instructed me to use cmake installation of documentation files, the
examples folder is an addition.
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
> > pushd %{_target_platform}/tests
> > ctest %{?_smp_mflags}
> don't pushd to tests, just to _target_platform
> add -VV to ctest invocation to easy identify bugs if there
> also do popd after
Fixed. Although, popd is obsolete. -VV does not give any obvious improvement to
build.log, anyways added.
> > %{_pkgdocdir}/
> mark as %doc
Useless, see above.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184
--- Comment #10 from Igor Gnatenko ---
> %{?!_pkgdocdir:%global _pkgdocdir %{_docdir}/%{name}}
could be removed
> mkdir -p %{_target_platform}
better to move into %prep
> cp -ap examples %{buildroot}%{_pkgdocdir}
just mark as %doc in -doc subpkg
> pushd %{_target_platform}/tests
> ctest %{?_smp_mflags}
don't pushd to tests, just to _target_platform
add -VV to ctest invocation to easy identify bugs if there
also do popd after
> %{_pkgdocdir}/
mark as %doc
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #9 from Raphael Groner --- Tests and doc fixed. Sorry for being so dumb in first steps. Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14851458 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #8 from Igor Gnatenko --- > All fixed, except tests. I don't know how to build/run the tests, please help. %build %cmake -DBUILD_TESTS=ON %check ctest -VV Also documentation stuff should be fixed similar way, not by manual running doxygen. There is -DBUILD_DOC -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184
--- Comment #7 from Raphael Groner ---
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14849719
(In reply to Igor Gnatenko from comment #2)
> > Provides: cmake(%{modname})
> I thought that it should come automatically... Rex?
Confirmed and fixed. It's a magic internal feature of rpmbuild.
> > Requires: %{name} = %{version}-%{release}
> Missing %{?_isa}
Fixed.
> > %cmake
> I would recommend to make out-of-tree builds
What are out-of-tree builds? Do you mean to not build binaries into source
folder? If yes, fixed.
> Others from first glance looks great!
Thanks.
(In reply to Igor Gnatenko from comment #2)
> Issues:
> ===
> - ldconfig called in %post and %postun if required.
> Note: /sbin/ldconfig not called in qhttpengine
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
> - %check is present and all tests pass.
> Note: test suite is not built/ran
> - qhttpengine-devel.x86_64: E: useless-provides cmake(QHttpEngine)
> Note: yeah, remove it
> - BuildRequires: gcc-c++ is missing
> - Would be great to build docs as well
All fixed, except tests. I don't know how to build/run the tests, please help.
(In reply to Igor Gnatenko from comment #4)
> > Requires: cmake
> also add here %{?_isa} as well, because package installs cmake files in
> %{_libdir}
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Igor Gnatenko changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #6 from Igor Gnatenko --- https://bugzilla.redhat.com/show_bug.cgi?id=1309794 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #5 from Igor Gnatenko --- Raphael, would be happy if you will review simple qt package - bug qtscrob. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184
--- Comment #4 from Igor Gnatenko ---
> Requires: cmake
also add here %{?_isa} as well, because package installs cmake files in
%{_libdir}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184
--- Comment #3 from Igor Gnatenko ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- ldconfig called in %post and %postun if required.
Note: /sbin/ldconfig not called in qhttpengine
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
- %check is present and all tests pass.
Note: test suite is not built/ran
- qhttpengine-devel.x86_64: E: useless-provides cmake(QHttpEngine)
Note: yeah, remove it
- BuildRequires: gcc-c++ is missing
- Would be great to build docs as well
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 15 files have
unknown license. Detailed output of licensecheck in
/home/brain/1354184-qhttpengine/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
qhttpengine-devel , qhttpengine-debuginfo
[!]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not inc
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Igor Gnatenko changed: What|Removed |Added Alias||qhttpengine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184
Igor Gnatenko changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||ignate...@redhat.com,
||rdie...@math.unl.edu
Assignee|nob...@fedoraproject.org|ignate...@redhat.com
--- Comment #2 from Igor Gnatenko ---
> Provides: cmake(%{modname})
I thought that it should come automatically... Rex?
> Requires: %{name} = %{version}-%{release}
Missing %{?_isa}
> %cmake
I would recommend to make out-of-tree builds
Others from first glance looks great!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 --- Comment #1 from Raphael Groner --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14847721 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354184] Review Request: qhttpengine - HTTP server for Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1354184 Raphael Groner changed: What|Removed |Added Blocks||928937 (qt-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
