[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-09-12 10:23:49 |2016-11-19 16:08:08



--- Comment #24 from Fedora Update System  ---
python-django-jsonfield-1.0.3-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Igor Gnatenko  changed:

   What|Removed |Added

   Priority|urgent  |unspecified
 CC|ignate...@redhat.com|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #23 from Fedora Update System  ---
python-django-jsonfield-1.0.3-1.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b313ece71e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||ignate...@redhat.com



--- Comment #22 from Zbigniew Jędrzejewski-Szmek  ---
*** Bug 1370533 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #21 from Zbigniew Jędrzejewski-Szmek  ---
Can this be closed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #20 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-django-jsonfield

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #19 from Germano Massullo  ---
Ankur, thank you very much for your work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #18 from Ankur Sinha (FranciscoD)  ---
- rpmlint issue fixed
- builds on rawhide and f25
- file list more detailed

Looks good!

XXX APPROVED XXX


/me just realised he forgot to set the fedora-review ? flag.
Oh well, setting it to + directly :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #17 from Ankur Sinha (FranciscoD)  ---
Looking at this now.

In the future, can you please update the changelog when you update the spec?
It's hard to figure out what's changed by just looking at the spec. You don't
need to bump the release if you don't want to, but a new change log entry is
still helpful. 

(Changelog is supposed to document spec changes - at the moment, it says "first
commit to fedora git" which isn't exactly true - that fits better in the SCM
git commit log instead)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Germano Massullo  changed:

   What|Removed |Added

 Depends On|1387376 |



--- Comment #16 from Germano Massullo  ---
Removed all EPEL referencies due Django 1.8 not yet planned to be released into
such repository

spec file:
https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield-1.0.3-1.fc24.src.rpm


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1387376
[Bug 1387376] Missing EPEL7 package
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #15 from Ankur Sinha (FranciscoD)  ---
Ah, we'll have to wait for the maintainer there to fix it then. No worries.
Let's hope it's done quickly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Germano Massullo  changed:

   What|Removed |Added

 Depends On||1387376




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1387376
[Bug 1387376] Missing EPEL7 package
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #14 from Germano Massullo  ---
1) I confirm that EL = 7 only;
2) unfortunately I have just found out that python-django-formtools has not yet
a build in EPEL7 stable repository

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #13 from Ankur Sinha (FranciscoD)  ---
Review:

[+] OK
[-] NA
[?] Issue

** Mandatory review guidelines: **
 [?] rpmlint output:
[asinha@cs-as14aho-2-herts-ac-uk  django-jsonfield]$ rpmlint
~/rpmbuild/SPECS/python-django-jsonfield.spec ./*.rpm
python2-django-jsonfield.noarch: E: description-line-too-long C
django-jsonfield is a reusable Django field that allows you to store validated
JSON in your model.
python2-django-jsonfield.noarch: E: description-line-too-long C It silently
takes care of serialization. To use, simply add the field to one of your
models.
python3-django-jsonfield.noarch: E: description-line-too-long C
django-jsonfield is a reusable Django field that allows you to store validated
JSON in your model.
python3-django-jsonfield.noarch: E: description-line-too-long C It silently
takes care of serialization. To use, simply add the field to one of your
models.
python-django-jsonfield.src: E: description-line-too-long C django-jsonfield is
a reusable Django field that allows you to store validated JSON in your model.
python-django-jsonfield.src: E: description-line-too-long C It silently takes
care of serialization. To use, simply add the field to one of your models.
3 packages and 1 specfiles checked; 6 errors, 0 warnings.

^
Not a blocker, but it'll be nice to keep rpmlint less vocal ;)

 [+] License is acceptable (...)
 [+] License field in spec is correct
 [+] License files included in package %docs if included in source package
 [+] License files installed when any subpackage combination is installed
 [+] Spec written in American English
 [+] Spec is legible
 [+] Sources match upstream unless altered to fix permissibility issues
Getting
https://files.pythonhosted.org/packages/source/j/jsonfield/jsonfield-1.0.3.tar.gz
to /tmp/review/jsonfield-1.0.3.tar.gz
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0
100  7950  100  79500 0  33896  0 --:--:-- --:--:-- --:--:-- 33896
Getting
https://raw.githubusercontent.com/bradjasper/django-jsonfield/master/LICENSE to
/tmp/review/LICENSE
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
100  1054  100  10540 0  11172  0 --:--:-- --:--:-- --:--:-- 11212
a7c7df31627069a97c9ba91b599c0845  /tmp/review/jsonfield-1.0.3.tar.gz
a7c7df31627069a97c9ba91b599c0845 
/home/asinha/rpmbuild/SOURCES/jsonfield-1.0.3.tar.gz
36efd2db6f0b18098392657e783bf223  /tmp/review/LICENSE
36efd2db6f0b18098392657e783bf223  /home/asinha/rpmbuild/SOURCES/LICENSE

 [+] Build succeeds on at least one primary arch
 [+] Build succeeds on all primary arches or has ExcludeArch + bugs filed
 [+] BuildRequires correct, justified where necessary
 [-] Locales handled with %find_lang, not %_datadir/locale/*
 [-] %post, %postun call ldconfig if package contains shared .so files
 [+] No bundled libs
 [-] Relocatability is justified
 [+] Package owns all directories it creates
 [-] Package requires others for directories it uses but does not own
 [+] No duplication in %files unless necessary for license files
 [+] File permissions are sane
 [+] Package contains permissible code or content
 [-] Large docs go in -doc subpackage
 [+] %doc files not required at runtime
 [-] Static libs go in -static package/virtual Provides
 [-] Development files go in -devel package
 [-] -devel packages Require base with fully-versioned dependency, %_isa
 [-] No .la files
 [-] GUI app uses .desktop file, installs it with desktop-file-install
 [-] File list does not conflict with other packages' without justification
 [+] File names are valid UTF-8

** Optional review guidelines: **
 [+] Query upstream about including license files
 [-] Translations of description, summary
 [+] Builds in mock
 [+] Builds on all arches
 [?] Functions as described (e.g. no crashes)

I haven't verified this. Please do so before you push to Fedora SCM just to be
sure.

 [-] Scriptlets are sane
 [-] Subpackages require base with fully-versioned dependency if sensible
 [-] .pc file subpackage placement is sensible
 [-] No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin
 [-] Include man pages if available

Naming guidelines:
 [+] Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+
 [+] Package names are sane
 [+] No naming conflicts
 [+] Spec file name matches base package name
 [+] Version is sane
 [+] Version does not contain ~
 [+] Release is sane
 [+] %dist tag
 [-] Case used only when necessary
 [-] Renaming handled correctly

Packaging guidelines:
 [-] Useful without external bits
 [-] No kmods
 [-] Pre-built binaries, libs removed in %prep
 [+] Sources contain only redistributable code or content
 

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

  Flags|needinfo?(sanjay.ankur@gmai |
   |l.com)  |



--- Comment #12 from Ankur Sinha (FranciscoD)  ---
Doesn't build on rhel7 at the moment. The python2-django-formtools also need to
go into the if else conditional. Here's the scratch build I tried:

http://koji.fedoraproject.org/koji/taskinfo?taskID=16136061

Looking at the general spec now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Germano Massullo  changed:

   What|Removed |Added

  Flags||needinfo?(sanjay.ankur@gmai
   ||l.com)



--- Comment #11 from Germano Massullo  ---
spec file:
https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield-1.0.3-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #10 from Germano Massullo  ---
(In reply to Miro Hrončok from comment #7)
> Just a note: You are doing Python 3 conditionals, but still use python2-
> prefix for Python 2 subpackage, that's not being used in (RH|EP)EL.

I am sorry but I have not found any packaging rule that concerns python2 prefix
not being used on EPEL7
https://fedoraproject.org/wiki/Packaging:Python
https://fedoraproject.org/wiki/EPEL:Packaging

I will make a new package in 48 hours

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Germano Massullo  changed:

   What|Removed |Added

   Priority|unspecified |urgent



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Sundeep Anand  changed:

   What|Removed |Added

 Blocks||1365839




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1365839
[Bug 1365839] Review Request: python-django-notifications-hq - GitHub
notifications alike app for Django
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Sundeep Anand  changed:

   What|Removed |Added

 CC||suan...@redhat.com



--- Comment #9 from Sundeep Anand  ---
*** Bug 1386760 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sanjay.an...@gmail.com
   Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #8 from Germano Massullo  ---
(In reply to Miro Hrončok from comment #7)
> Just a note: You are doing Python 3 conditionals, but still use python2-
> prefix for Python 2 subpackage, that's not being used in (RH|EP)EL.
> 
> Is there a rationale?

Do you mean
%package -n python2-django-%{pypi_name}
?

By reading your comment, I have just found out that the package would not
compile on EPEL7 because the python2 prefix of some of its dependencies.
I will edit as soon as possible the spec file like I have already done in past
for package python-django-model-utils
http://pkgs.fedoraproject.org/cgit/rpms/python-django-model-utils.git/tree/python-django-model-utils.spec

Thank you

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Miro Hrončok  changed:

   What|Removed |Added

 CC||mhron...@redhat.com



--- Comment #7 from Miro Hrončok  ---
Just a note: You are doing Python 3 conditionals, but still use python2- prefix
for Python 2 subpackage, that's not being used in (RH|EP)EL.

Is there a rationale?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|ignate...@redhat.com|nob...@fedoraproject.org
  Flags|needinfo?(ignatenko@redhat. |
   |com)|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Germano Massullo  changed:

   What|Removed |Added

  Flags||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #6 from Germano Massullo  ---
All problems fixed

spec file:
https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield-1.0.3-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #5 from Germano Massullo  ---
As soon as possible I will integrate patch [1] that solves test problems in
1.0.3

[1]:
https://github.com/bradjasper/django-jsonfield/commit/d2d2c58815501b13d8bc7988c06594135afae39f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #4 from Germano Massullo  ---
(In reply to Igor Gnatenko from comment #3)
> > # tests disabled because DB_ENGINE should be configured
> > # but during installation process this is not posssible
> it is possible. you can configure some sqlite in memory
> 

Fixed

spec file:
https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield.spec

srpm file:
https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield-1.0.1-1.fc24.src.rpm


> > %if 0%{?fedora} || 0%{?rhel} > 7
> > %global with_python3 1
> > %endif
> %if 0%{?rhel} && 0%{?rhel} <= 7
> %bcond_with python3
> %else
> %bcond_without python3
> %endif

There is no packaging guideline that forces bcond use

> > %{python3_sitelib}/*
> it's too generic.

There is no packaging guideline that forbids to use it, instead the Python
guidelines's mention it in the template model

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



--- Comment #3 from Igor Gnatenko  ---
> %if 0%{?fedora} || 0%{?rhel} > 7
> %global with_python3 1
> %endif
%if 0%{?rhel} && 0%{?rhel} <= 7
%bcond_with python3
%else
%bcond_without python3
%endif

> # tests disabled because DB_ENGINE should be configured
> # but during installation process this is not posssible
it is possible. you can configure some sqlite in memory

> %{python3_sitelib}/*
it's too generic.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Igor Gnatenko  changed:

   What|Removed |Added

Summary|python-django-jsonfield - A |Review Request:
   |reusable Django field that  |python-django-jsonfield - A
   |allows you to store |reusable Django field that
   |validated JSON in your  |allows you to store
   |model   |validated JSON in your
   ||model



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org