[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Bug 1392090 depends on bug 1401337, which changed state. Bug 1401337 Summary: Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library https://bugzilla.redhat.com/show_bug.cgi?id=1401337 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Bug 1392090 depends on bug 1401337, which changed state. Bug 1401337 Summary: Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library https://bugzilla.redhat.com/show_bug.cgi?id=1401337 What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Peter Robinson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-12-21 23:23:09 --- Comment #10 from Peter Robinson --- Pushed. Global and summary fixed. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 --- Comment #9 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/pychromecast -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Bug 1392090 depends on bug 1401337, which changed state. Bug 1401337 Summary: Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library https://bugzilla.redhat.com/show_bug.cgi?id=1401337 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Bug 1392090 depends on bug 1401337, which changed state. Bug 1401337 Summary: Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library https://bugzilla.redhat.com/show_bug.cgi?id=1401337 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Bug 1392090 depends on bug 1392089, which changed state. Bug 1392089 Summary: Review Request: python-zeroconf: Pure Python Multicast DNS Service Discovery Library https://bugzilla.redhat.com/show_bug.cgi?id=1392089 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Peter Robinson changed: What|Removed |Added Depends On||1401337 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1401337 [Bug 1401337] Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Peter Robinson changed: What|Removed |Added Summary|Review Request: |Review Request: |pychromecast: Python|pychromecast - Python |library to communicate with |library to communicate with |the Google Chromecast. |the Google Chromecast -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 --- Comment #8 from Peter Robinson --- Fixed those two points locally, requested maint on the other package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Athos Ribeiro changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Athos Ribeiro --- > Those two are minor quirks I would fix on commit. Do you want me to update > them? Not really, I trust you will address those. python2-zeroconf is still not in Fedora and bug 1392089 on which this bug depends on, might not solve the issue, as pointed out in that bug. I know you are an experienced packager and I do trust your judgement on how to solve the issue. The package looks good and this review is complete. Since all dependencies are not in Fedora yet, see [1] for reference. [1] https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#A_note_on_dependencies -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 --- Comment #6 from Peter Robinson --- > spec file line 2 reads: > %define with_tests 0 > > Guidelines sugest we use %global instead, as you can see in [1]. Note that > this is not a must. > > The Summary tag ends with period a period. Please see [2]. Those two are minor quirks I would fix on commit. Do you want me to update them? > After your feedback on those points I will consider this review done, sice > the package looks good. > > We would still need to find a solution for bug 1392089 in order to include > python2-zeroconf in fedora, since this bug depends on it. I'll deal with that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090
Athos Ribeiro changed:
What|Removed |Added
Flags|needinfo?(athoscribeiro@gma |
|il.com) |
--- Comment #5 from Athos Ribeiro ---
Hi Peter,
This is not a problem in this package, but I'd suggedt to be careful with
wildcards in python3 packages, since sometimes your package may end up owning
%{python3_sitelib}/__pycache__, which belongs to system-python-libs
spec file line 2 reads:
%define with_tests 0
Guidelines sugest we use %global instead, as you can see in [1]. Note that this
is not a must.
The Summary tag ends with period a period. Please see [2].
After your feedback on those points I will consider this review done, sice the
package looks good.
We would still need to find a solution for bug 1392089 in order to include
python2-zeroconf in fedora, since this bug depends on it.
[1]
https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define
[2] https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Peter Robinson changed: What|Removed |Added Flags||needinfo?(athoscribeiro@gma ||il.com) --- Comment #4 from Peter Robinson --- Please continue the review or should I get someone else to continue it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 --- Comment #3 from Peter Robinson --- Updated, spec as before SRPM: https://pbrobinson.fedorapeople.org/pychromecast-0.7.7-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 --- Comment #2 from Peter Robinson --- (In reply to Athos Ribeiro from comment #1) > I am not sure if we can use this name for the package. See > https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging: > NamingGuidelines#Outdated_Python_package_naming_conventions The binary packages are called python2- and python3- so I don't see what the issue is. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Bug 1392090 depends on bug 1209685, which changed state. Bug 1209685 Summary: protobuf-v3.1.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1209685 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 --- Comment #1 from Athos Ribeiro --- I am not sure if we can use this name for the package. See https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Outdated_Python_package_naming_conventions Would you use the template on https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file? It would really improve readability with all those macros set there. As pointed in https://fedoraproject.org/wiki/Packaging:Python#Reviewer_checklist , %python_provide macro must be used. are there any reasons for not including the README file under %doc? Any comments on why you decided to use github instead of pypi for sources? I am just curious since you used pypi for the other python package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.
https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Athos Ribeiro changed: What|Removed |Added Status|NEW |ASSIGNED CC||athoscribe...@gmail.com Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
