[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966

Mattia Verga  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2021-06-07 12:58:38



--- Comment #15 from Mattia Verga  ---
Package has been imported, closing ticket.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #14 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libcloudproviders

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #13 from Carlos Soriano  ---
(In reply to Robert-André Mauchin (afk until Mon 11) from comment #12)
> Yes the review is fine. You just need to *create the repo* with fedrepo-req
> within 60 days. You can import your SRPM any time later.

Perfect, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #12 from Robert-André Mauchin (afk until Mon 11) 
 ---
Yes the review is fine. You just need to *create the repo* with fedrepo-req
within 60 days. You can import your SRPM any time later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #11 from Carlos Soriano  ---
Ah I see.
Just to be in the same page, that means the review is fine, I can change few
details and it's still fine, and I can import the package to Fedora as long as
it is under 60 days?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #10 from Robert-André Mauchin  ---
Well it just works. Import it into Fedora when you're ready. Be aware that a
Review request validity is 60 days, if you try to create your repo with
fedrepo-req after 60 days, it will throw you an error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #9 from Carlos Soriano  ---
Thanks Robert!

Not sure how package process works, but don't take it to production yet. We
still need to fix upstream exit() call and in the final spec we will have 0.2.0
version for the library. I wanted to make sure is buildable by Fedora before
bumping to that version upstream

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Robert-André Mauchin  ---
All okay, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #7 from Carlos Soriano  ---
Sorry about that, must be our new spam countermeasures in GNOME GitLab (I'll
look into it). I was aware one rightful rule for spec review is to not require
logins, so thanks for trying anyway.

I put it now in a fpaste:
https://paste.fedoraproject.org/paste/7d7QkODJgPWql14nWzGX1A

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #6 from Robert-André Mauchin  ---
If I do login, the file is 404ing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #5 from Robert-André Mauchin  ---
The link you provided ask me to login, don't you have a direct link for it
please?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #4 from Carlos Soriano  ---
Here is the updated spec. It was basically what you mentioned in the comment,
except for changing .1 to 0.1 since it's a preview version.
https://gitlab.gnome.org/snippets/17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #3 from Carlos Soriano  ---
Thanks Robert for the review, it's my first package so a little noobie here.
I'll fix the spec and the upstream stuff tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966



--- Comment #2 from Robert-André Mauchin  ---
Rpmlint complains about other things:

 - Your description line is too long, split it to stay below 80 characters per
line.

 - libcloudproviders.x86_64: W: shared-lib-calls-exit
/usr/lib64/libcloudproviders.so.0.1.1 exit@GLIBC_2.2.5

This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

Since you're on the upstream team, you probably could fix that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487966

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,


There are several issues:

 - You install a *.so in libdir: you must run ldconfig in %post and %postun
   See https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries

%post
/sbin/ldconfig

%postun
/sbin/ldconfig

 - You install a systemd user unit dir: these must be handled by systemd
scriplets too. See
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd

  First you need to modify your systemd BR by adding a macro before it:

%{?systemd_requires}
BuildRequires: systemd

  Then you add the scriplets in %post, %preun, %postun:

%post
%systemd_post libcloudproviders.service

%preun
%systemd_preun libcloudproviders.service

%postun
%systemd_postun_with_restart libcloudproviders.service

 - The Release tag should starts at 1, not 0 (0.1 if it's a development
snapshot).

 - Why do you split %files? Just reunite the two sections:

%files
%doc CHANGELOG README.md
%license LICENSE
%{_libdir}/libcloudproviders.so.*
%{_libexecdir}/cloudproviderd
%{_datadir}/cloud-providers/org.freedesktop.CloudProviderServerExample.ini
%{_datadir}/dbus-1/services/org.freedesktop.CloudProviderServerExample.service
%{_userunitdir}/libcloudproviders.service

 - Your changelog is empty! It must contain the date, name, version and so on:

* Sun Sep  3 2017 Carlos Soriano  - 0.1.1-1
- Initial RPM release


Once all of this is fixed, I'll continue the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org