[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332



--- Comment #11 from Fedora Update System  ---
php-icewind-smb2-2.0.3-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-02 11:22:41



--- Comment #10 from Fedora Update System  ---
php-icewind-smb2-2.0.3-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332



--- Comment #9 from Fedora Update System  ---
php-icewind-smb2-2.0.3-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a6ae84a0c4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
php-icewind-smb2-2.0.3-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f22dd61331

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332



--- Comment #7 from Fedora Update System  ---
php-icewind-smb2-2.0.3-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f22dd61331

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332



--- Comment #6 from Fedora Update System  ---
php-icewind-smb2-2.0.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a6ae84a0c4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/php-icewind-smb2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #4 from Remi Collet  ---
Thanks for the review

https://pagure.io/releng/fedora-scm-requests/issue/3590
https://pagure.io/releng/fedora-scm-requests/issue/3591
https://pagure.io/releng/fedora-scm-requests/issue/3592

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332

William Moreno  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #3 from William Moreno  ---
Package Review
==

Not bloquers here, package aproved

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Rpmlint
---
Checking: php-icewind-smb2-2.0.3-1.fc28.noarch.rpm
  php-icewind-smb2-2.0.3-1.fc28.src.rpm
php-icewind-smb2.noarch: W: spelling-error Summary(en_US) smbclient ->
clientele
php-icewind-smb2.noarch: W: spelling-error Summary(en_US) libsmbclient ->
clientele
php-icewind-smb2.noarch: W: summary-not-capitalized C php wrapper for smbclient
and libsmbclient-php
php-icewind-smb2.noarch: W: spelling-error %description -l en_US smbclient ->
clientele
php-icewind-smb2.noarch: W: spelling-error %description -l en_US libsmbclient
-> clientele
php-icewind-smb2.noarch: W: spelling-error %description -l en_US api -> API,
pi, ape
php-icewind-smb2.noarch: W: spelling-error %description -l en_US autoload ->
auto load, auto-load, tautology
php-icewind-smb2.src: W: spelling-error Summary(en_US) smbclient -> clientele
php-icewind-smb2.src: W: spelling-error Summary(en_US) libsmbclient ->
clientele
php-icewind-smb2.src: W: summary-not-capitalized C php wrapper for smbclient
and libsmbclient-php
php-icewind-smb2.src: W: spelling-error %description -l en_US smbclient ->
clientele

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332



--- Comment #2 from William Moreno  ---
Spec URL:
https://git.remirepo.net/cgit/rpms/php/icewind/php-icewind-smb2.git/plain/php-icewind-smb2.spec?id=a7b1f277b2f2d4cf40e7cb642127a09a8ffab661
SRPM URL: http://rpms.remirepo.net/SRPMS/php-icewind-smb2-2.0.3-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332



--- Comment #1 from Remi Collet  ---
Updated to 2.0.3

Spec:
https://git.remirepo.net/cgit/rpms/php/icewind/php-icewind-smb2.git/plain/php-icewind-smb2.spec?id=a7b1f277b2f2d4cf40e7cb642127a09a8ffab661
Srpm: http://rpms.remirepo.net/SRPMS/php-icewind-smb2-2.0.3-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332

Remi Collet  changed:

   What|Removed |Added

 Blocks||1433919
  Alias||php-icewind-smb2




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1433919
[Bug 1433919] Version 11.0.2 is avaliable
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org