[Bug 1534567] Review Request: golang-github-spacemonkeygo-openssl - OpenSSL bindings for Go

2019-01-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1534567

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|POST|CLOSED
 CC||quantum.anal...@gmail.com
   Fixed In Version||golang-github-spacemonkeygo
   ||-openssl-0-0.3.20171219gite
   ||863d83.fc28
 Resolution|--- |CURRENTRELEASE
Last Closed||2019-01-16 07:20:15



--- Comment #6 from Elliott Sales de Andrade  ---
This was built some time ago.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1534567] Review Request: golang-github-spacemonkeygo-openssl - OpenSSL bindings for Go

2018-01-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1534567



--- Comment #4 from Marek Skalický  ---
Thanks for the review. I've updated the changelog entry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534567] Review Request: golang-github-spacemonkeygo-openssl - OpenSSL bindings for Go

2018-01-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1534567



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-spacemonkeygo-openssl. You may
commit to the branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534567] Review Request: golang-github-spacemonkeygo-openssl - OpenSSL bindings for Go

2018-01-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1534567

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
You forgot to add the commit date in the %changelog entry:

* Mon Jan 15 2018 Marek Skalický  -
0-0.1.20171219gite863d83

Package is approved but please fix this before import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534567] Review Request: golang-github-spacemonkeygo-openssl - OpenSSL bindings for Go

2018-01-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1534567



--- Comment #2 from Marek Skalický  ---
Thanks for the quick review and suggestions how to fix problems. I've addressed
all your comments.

Spec URL:
https://mskalick.fedorapeople.org/golang-github-spacemonkeygo-openssl/golang-github-spacemonkeygo-openssl.spec
SRPM URL:
https://mskalick.fedorapeople.org/golang-github-spacemonkeygo-openssl/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534567] Review Request: golang-github-spacemonkeygo-openssl - OpenSSL bindings for Go

2018-01-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1534567

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
 - If you package a dev snapshot, you should provide the commit date in the
Release: field.

%global commit  e863d83e403e8d694fa7d17f4af3cd176624ef12
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global commitdate  20171219

Name:   golang-%{provider}-%{project}-%{repo}
Version:0
Release:0.1.%{commitdate}git%{shortcommit}%{?dist}

   And:

* Mon Jan 15 2018 Marek Skalický  -
0-0.1.20171219gite863d83

 - You should remove:

%files
%license LICENSE
%doc README.md AUTHORS

as it only contains doc and license

 - Tests fail on all arches:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24218445

+ go test -compiler gc -ldflags ' -extldflags '\''-Wl,-z,relro
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
github.com/spacemonkeygo/openssl
# github.com/spacemonkeygo/openssl
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/key_test.go:80:
Fatal call has possible formatting directive %s
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/key_test.go:294:
Fatal call has possible formatting directive %s
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha1_test.go:38:
Fatal call has possible formatting directive %x
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha1_test.go:76:
Fatal call has possible formatting directive %x
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha256_test.go:38:
Fatal call has possible formatting directive %x
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha256_test.go:76:
Fatal call has possible formatting directive %x
FAILgithub.com/spacemonkeygo/openssl [build failed]

To solve this, I propose you a simple patch which replaces the problematic
"Fatal" with "Fatalf":

diff -up
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go.fix_go_warning
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go
--- openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go.fix_go_warning
   2018-01-06 00:06:25.0 +0100
+++ openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go2018-01-15
20:00:40.727292766 +0100
@@ -77,7 +77,7 @@ func TestMarshal(t *testing.T) {
 }
 tls_der := x509.MarshalPKCS1PrivateKey(tls_key)
 if !bytes.Equal(der, tls_der) {
-t.Fatal("invalid private key der bytes: %s\n v.s. %s\n",
+t.Fatalf("invalid private key der bytes: %s\n v.s. %s\n",
 hex.Dump(der), hex.Dump(tls_der))
 }

@@ -291,7 +291,7 @@ func TestMarshalEC(t *testing.T) {
 t.Fatal(err)
 }
 if !bytes.Equal(der, tls_der) {
-t.Fatal("invalid private key der bytes: %s\n v.s. %s\n",
+t.Fatalf("invalid private key der bytes: %s\n v.s. %s\n",
 hex.Dump(der), hex.Dump(tls_der))
 }

diff -up
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go.fix_go_warning
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go
---
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go.fix_go_warning   
2018-01-06 00:06:25.0 +0100
+++ openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go2018-01-15
20:01:38.878103115 +0100
@@ -35,7 +35,7 @@ func TestSHA1(t *testing.T) {
 }

 if expected != got {
-t.Fatal("exp:%x got:%x", expected, got)
+t.Fatalf("exp:%x got:%x", expected, got)
 }
 }
 }
@@ -73,7 +73,7 @@ func TestSHA1Writer(t *testing.T) {
 }

 if got != exp {
-t.Fatal("exp:%x got:%x", exp, got)
+t.Fatalf("exp:%x got:%x", exp, got)
 }
 }
 }
diff -up
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go.fix_go_warning
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go
---
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go.fix_go_warning 
  2018-01-06 00:06:25.0 +0100
+++ openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go   
2018-01-15 20:02:17.046978632 +0100
@@ -35,7 +35,7 @@ func