[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-05-09 17:22:13 --- Comment #15 from Fedora Update System --- python-sphinxcontrib-apidoc-0.2.1-6.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 --- Comment #14 from Fedora Update System --- python-sphinxcontrib-apidoc-0.2.1-6.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-864dc74943 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- python-sphinxcontrib-apidoc-0.2.1-6.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6683babf40 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 --- Comment #12 from Fedora Update System --- python-sphinxcontrib-apidoc-0.2.1-6.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-864dc74943 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 --- Comment #11 from Fedora Update System --- python-sphinxcontrib-apidoc-0.2.1-6.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6683babf40 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 --- Comment #10 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sphinxcontrib-apidoc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 Javier Peña changed: What|Removed |Added Status|NEW |POST Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504
--- Comment #9 from Javier Peña ---
Review notes:
- The rpmlint notes about macros in comments are expected. Unit tests are
currently disabled due to an issue in the tagged version, and should be enabled
in the future.
The package is APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (unspecified)", "BSD (2 clause)", "Unknown or generated".
34 files have unknown license. Detailed output of licensecheck in
/tmp/1565504-python-sphinxcontrib-apidoc/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.6/site-
packages/sphinxcontrib, /usr/lib/python2.7/site-packages/sphinxcontrib
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
-sphinxcontrib-apidoc , python3-sphinxcontrib-apidoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported N
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 --- Comment #8 from Chandan Kumar --- Updated spec: https://chandankumar.fedorapeople.org/python-sphinxcontrib-apidoc.spec SRPM: https://chandankumar.fedorapeople.org/python-sphinxcontrib-apidoc-0.2.1-6.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 --- Comment #7 from Chandan Kumar --- Updated spec: https://chandankumar.fedorapeople.org/python-sphinxcontrib-apidoc.spec SRPM: https://chandankumar.fedorapeople.org/python-sphinxcontrib-apidoc-0.2.1-5.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504
--- Comment #6 from Javier Peña ---
Two final issues I have found on a test fedora-review run, and we should be
done:
- Even if we do "py.test ||", fedora-review fails when running unit tests, so
we'd better comment it out.
- In the %files section, we have:
%{python2_sitelib}/sphinxcontrib
...
%{python3_sitelib}/sphinxcontrib
Fedora-review complains that the directory is already owned by other package,
so we could try to be more specific and use:
%{python2_sitelib}/sphinxcontrib/apidoc
...
%{python3_sitelib}/sphinxcontrib/apidoc
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 --- Comment #5 from Chandan Kumar --- Updated SPEC: https://chandankumar.fedorapeople.org/python-sphinxcontrib-apidoc.spec SRPM: https://chandankumar.fedorapeople.org/python-sphinxcontrib-apidoc-0.2.1-4.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 Chandan Kumar changed: What|Removed |Added CC||chku...@redhat.com --- Comment #4 from Chandan Kumar --- Hello Jpena, Thanks for the comment. Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-sphinxcontrib-apidoc.spec SRPM: https://chandankumar.fedorapeople.org/python-sphinxcontrib-apidoc-0.2.1-3.fc27.src.rpm Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504
--- Comment #3 from Javier Peña ---
Hi Chandan,
Thanks for the fixes. I still have some comments:
- The with_python3 snippet still needs to be changed (see comment 1)
- Please include python BRs within "%if 0%{?with_python3} ... %endif",
otherwise a RHEL 7 rebuild would fail.
- I have checked in a venv, and the tests do not get installed. So we can
remove the following line:
rm -r $(find %{_buildrootdir} -type d -name 'tests') || /bin/true
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 --- Comment #2 from Chandan Kumar --- Hey Jpena, Thanks for the review. Below is the updated SPEC: https://chandankumar.fedorapeople.org/python-sphinxcontrib-apidoc.spec SRPM: https://chandankumar.fedorapeople.org/python-sphinxcontrib-apidoc-0.2.1-2.fc27.src.rpm Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504
Javier Peña changed:
What|Removed |Added
CC||jp...@redhat.com
Assignee|nob...@fedoraproject.org|jp...@redhat.com
--- Comment #1 from Javier Peña ---
Hi Chandan,
I have some initial comments on the spec:
* For the with_python3 statement, the latest Fedora reviews use the following
snippet:
%if 0%{?fedora} || 0%{?rhel} > 7
%global with_python3 1
%endif
* Python 3 build requirements are missing
* There is a test directory in the PyPi tarball. I'm not sure if we want to
keep it, if not we should %exclude it in the %files section.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1565504] Review Request: python-sphinxcontrib-apidoc - A Sphinx extension for running sphinx-apidoc on each build
https://bugzilla.redhat.com/show_bug.cgi?id=1565504 Yatin Karel changed: What|Removed |Added CC||yka...@redhat.com Blocks||1550514 (RDO-ROCKY) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1550514 [Bug 1550514] Tracker: Blockers and Review requests for new RDO Rocky packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
