[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473 Mattia Verga changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2021-06-11 14:13:42 --- Comment #11 from Mattia Verga --- Package imported, closing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sassist -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/R4KK4MQ76BFUG4H3UN5GCOT2J7FM3UGQ/
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473 Robert-André Mauchin changed: What|Removed |Added Flags|needinfo?(zebo...@gmail.com | |) | --- Comment #9 from Robert-André Mauchin --- what do you mean? I already approved your package, now you need to request the repo and build it. If you're lost, your next step is https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/V2A6RLCSWHJETP6GAGRZKUB5YUF3O4FU/
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473 Charles Rose changed: What|Removed |Added Flags||needinfo?(zebo...@gmail.com ||) --- Comment #8 from Charles Rose --- (In reply to Robert-André Mauchin from comment #7) > Package approved. Hello Robert-Andre, Can you help move this along the next steps? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2SZK7AQ2LPTHAOE4X2XWORO2U4MLKMXG/
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #7 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/BBY67L3OAAU6RMN23QYDLOLPAMFJXS4E/
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473 --- Comment #6 from Charles Rose --- (In reply to Robert-André Mauchin from comment #5) > I'd like to see the updated SPEC Here you go: https://github.com/dell/sassist/blob/master/pkg/sassist.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5FKAADPCAA2QRUWT3ICO7C6LDVAZ37CM/
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473 --- Comment #5 from Robert-André Mauchin --- I'd like to see the updated SPEC -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4J2SJOY72UHIK5UOTF7ISAUFOVUNXCJ7/
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473 --- Comment #4 from Charles Rose --- (In reply to Robert-André Mauchin from comment #3) > - Perms are incorrect: > > sassist.noarch: E: non-standard-executable-perm /usr/bin/sassist.sh 555 > > It should be 755. Fixed. > > - Your changelog entries are missing the release info: > > * Thu Jun 14 2018 Charles Rose - 0.8.2-1 Fixed. > > - You should also execute the systemd scriptlets for > sassist-collect.service: The sassist-collect service is not started/stopped under user-control but is triggered a volume is mounted: media-iDRAC_NATOSC.mount: ... BindsTo=sassist-collect.service ... sassist-collect.service: ... RefuseManualStart=true ... > > %post > %systemd_post sassist.service > %systemd_post sassist-collect.service > > %preun > %systemd_preun sassist.service > %systemd_preun sassist-collect.service > > %postun > %systemd_postun_with_restart sassist.service > %systemd_postun_with_restart sassist-collect.service > -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2EQHTI22MBHUNHSNXFWLCYCRS4M54ENQ/
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473
--- Comment #3 from Robert-André Mauchin ---
- Perms are incorrect:
sassist.noarch: E: non-standard-executable-perm /usr/bin/sassist.sh 555
It should be 755.
- Your changelog entries are missing the release info:
* Thu Jun 14 2018 Charles Rose - 0.8.2-1
- You should also execute the systemd scriptlets for sassist-collect.service:
%post
%systemd_post sassist.service
%systemd_post sassist-collect.service
%preun
%systemd_preun sassist.service
%systemd_preun sassist-collect.service
%postun
%systemd_postun_with_restart sassist.service
%systemd_postun_with_restart sassist-collect.service
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 11 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/sassist/review-sassist/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473 --- Comment #2 from Charles Rose --- Thank you for your review. I have made the suggested changes: https://github.com/dell/sassist/blob/master/pkg/sassist.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/RNYVNIIEREKZUUHTRB4BCQ46DQHLRP65/
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- Not needed:
Group:
rm -rf -- "%{buildroot}"
%clean
rm -rf -- "%{buildroot}"
%defattr(-,root,root,-)
- Source0 should be d/l from a remote source:
Source0:
https://github.com/dell/sassist/archive/%{version}/%{name}-%{version}.tar.gz
- Should't be needed:
Requires: systemd-units
Requires(post): systemd-units
Requires(postun): systemd-units
Requires: systemd
it is implied by %{?systemd_requires}.
- However you need:
BuildRequires: systemd
- The license must be installed with %license:
%license COPYING
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/TCC2VHPGYR7MMIUS4HV6VKAGBTR7USW3/
