[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-10-23 17:07:04 --- Comment #24 from Fedora Update System --- textern-0-0.4.20180821git5339fb6.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #23 from Fedora Update System --- textern-0-0.4.20180821git5339fb6.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5048640cb8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OMZMNILO6GAKY6TXQYGTNPAHTGGVSCJA/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #22 from Pavel Raiskup --- Artificial prefixes only make the Linux distributions different. Especially for trivial add-on case (it is almost always leaf package), one would have to ask what would be the benefits for even more complicated guidelines. In postgresql-* case we used to use this anti-pattern and those few examples now evoke that the packages are sub-packages from postgresql.spec. So we've had several package-rename tasks in TODO list since ever. There's very "fortunate" situation with the browser plugin mechanisms nowadays, though, because they are (almost?) impossible to package downstream. That said, there are many topics waiting for Fedora guidelines, but not this one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/QHUPKFQM5ENADCKLHKPY4WB26ODDTANR/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #21 from Robert-André Mauchin --- I disagree, I specifically did not mention the prefix because this package is not a web extension, but a helper program working with the web extension through the native messaging host mechanism. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/EVTFFII4AOU2Z6IBU5RQOO4MSV2EHBFW/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #20 from Jason Tibbitts --- The "webextension" prefix wouldn't come from upstream, it would come from Fedora. This will be considered an "addon package" according to the packaging guidelines. It is very common in Fedora to prefix the upstream name with a something indicating that the package is a module, plugin or addon to some other system. Anyway, the question was raised so I'm just letting you know what the packaging guidelines will be saying in the future. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7YHWD3DQBA75DW2IE6BE3AOBTC7SHSIX/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #19 from Pavel Raiskup --- Hmm. I don't think any prefix would help (ask upstream maintainer why the prefix neither is there..). Of course, if you think I should add a word "webextension" somewhere - so 'dnf search webextension' hits the package, fill a PR. FWIW: $ sudo dnf search webextension Last metadata expiration check: 1:26:52 ago on Wed 22 Aug ... = Name Matched: webextension ... webextension-token-signing.x86_64 : Firefox extension for ... (only _one_ package) 'dnf search firefox' gives me ~8 hits 'dnf search mozilla' gives me ~50 hits. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4ZN2KUFJ3S2Q7T4UBHVJMSBTZ6TMLL3R/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #18 from Jason Tibbitts --- This package probably should have been named webextension-textern to match the other webextension we have. This will be formalized into packaging guidelines as soon as I am able to get around to writing them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GMY447GK32BW2JWRZGAH4QQUX52ZYPAL/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #17 from Fedora Update System --- textern-0-0.4.20180821git5339fb6.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5048640cb8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/EVRJ5BHUCIAE2XZ5WJZMR2N6MFRIODZP/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 Pavel Raiskup changed: What|Removed |Added Status|POST|MODIFIED --- Comment #16 from Pavel Raiskup --- Thanks, I did s/GPLv3/GPLv3+/. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HOCUK2TALHRPQR43OBZIGGCMZX5GZIZN/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||zbys...@in.waw.pl --- Comment #15 from Zbigniew Jędrzejewski-Szmek --- (In reply to Lukáš Tyrychtr from comment #3) > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: make > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 That's fedora-review being plain wrong. See https://bugzilla.redhat.com/show_bug.cgi?id=1613069, https://pagure.io/packaging-committee/issue/497#comment-146293. > [?]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/lib64/mozilla/native- > messaging-hosts(webextension-token-signing, chrome-gnome-shell) The rule to not co-own directories is mostly outdated too. If there's a "-filesystem" package that owns those directories, then it's better to depend on it, but when there isn't, it's better for unrelated packages to co-own a directory than to introduce unwanted Requires. (In this case depending on mozilla-filesystem is fine, my comment was about the general case.) > License: GPLv3 The license is tagged wrong. Looking at the SPDX identifiers in https://github.com/jlebon/textern/blob/master/native/textern.py and other places shows that the license is GPLv3+. Unfortunately the GPLv3 LICENSE text is very long and one cannot tell if the program is license GPLv3 or GPLv3-or-later just by looking at the LICENSE file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/3APNFESNGQJER2WV67RT2EECCIA3HGYZ/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #14 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/textern -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/NK6I36TVKH5WOC5APSDHHD2THOXNGDCB/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #13 from Pavel Raiskup --- I don't think so, at least upstream doesn't name it that way. I guess that the native "server" could well serve it's purpose also for chromium users one day (or at least icecat, etc.). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/EAI25VVLR2JBJYDAPNQEJS6OX6WEWXGK/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 Igor Gnatenko changed: What|Removed |Added CC||i.gnatenko.br...@gmail.com --- Comment #12 from Igor Gnatenko --- Shouldn't the package be named `firefox-textern`? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XDPM62WEUJNE7YBFDIEUSFF222SFF76H/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #11 from Robert-André Mauchin --- Sounds good, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OM2AZXDA3WBBFPSOEI2DAK62J45DL46K/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #10 from Pavel Raiskup --- Thanks a lot! Spec URL: https://raw.githubusercontent.com/praiskup/textern-rpm/master/textern.spec SRPM URL: https://praiskup.fedorapeople.org/textern-0-0.3.20180821git5339fb6.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GJK4IKPRUFLRUF4L7CLZQQPYNCMKIHXV/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #9 from Lukáš Tyrychtr --- (In reply to Robert-André Mauchin from comment #7) > (In reply to Lukáš Tyrychtr from comment #3) > > Note that i do not actually understand the mock install failure, i can > > install the package just fine. > > > In hat case check in results/root.log and search for "Error:". You'll get > the reason why it failed. The error was that for some reason python3-inotify_simple was not found in the repository, but it was some sort of temporary failure, it installs just fine now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/H3KKLCHATDWKLTYCTCW4HEHCKNFE6YK7/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528
--- Comment #8 from Robert-André Mauchin ---
- As Lukáš noted, add a comment explaining why the patch is needed.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
- I don't get this:
# curl https://api.github.com/repos/jlebon/textern/tarball/5339fb6 > tarball
Source0:jlebon-textern-%gitrev.tar.gz
Grab the tar.gz directly:
Source0:%url/archive/%{gitrev}/%{name}-%{gitrev}.tar.gz
- Version/Release is not good. See the rules on versioning a snapshot:
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots
%global commit 5339fb6ae33c72c27f2769d0fc3dabb6191b5d3a
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global snapshotdate20180821
%global debug_package %nil
# this enforces us to create non-noarch package
%global native_dir %_libdir/mozilla/native-messaging-hosts
%global __brp_python_bytecompile :
Name: textern
Version:0
Release:0.3.%{snapshotdate}git%{shortcommit}%{?dist}
Summary:Firefox add-on for editing text in your favorite external
editor
License:GPLv3
URL:https://github.com/jlebon/textern
Source0:%url/archive/%{shortcommit}/%{name}-%{shortcommit}.tar.gz
And
%prep
%autosetup -p1 -n textern-%commit
Note the 0.3 instead of 3 for a pre-release.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/X22HRM5MYNXSJNSVW7WR3LJC7KTGL7OY/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #7 from Robert-André Mauchin --- (In reply to Lukáš Tyrychtr from comment #3) > Note that i do not actually understand the mock install failure, i can > install the package just fine. > In hat case check in results/root.log and search for "Error:". You'll get the reason why it failed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2ZVDSU3DODKPWIKZVXL3QO3BW6IFVWYF/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #6 from Lukáš Tyrychtr --- Strange, also run on F28, tried the default mock config and also rawhide. However as this was one of my first reviews and one of the reasons for it is that i need to get sponsored to the packager group myself you probably should wait if someone else can verify my results. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5VKVFXZRGTWF76A3Y5A6PLYY6XCXL5CD/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #5 from Pavel Raiskup --- Run on fedora 28: $ fedora-review -b 1619528 ... [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build pr ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ICYEDGEY3NY5MWO2MNG7E7ZFEH3I3ODN/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #4 from Pavel Raiskup --- Since not all projects depend on /bin/make, I'd rather keep that BuildRequirement on place (one day we could have no /bin/make in default buildroot, same as we have no python/gcc/perl/etc). The install failure is weird. What system did you run fedora-review on, and what chroot did you use? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LG5I7SWWXS34YSSZR4K5YQ3T6WEX5XJ2/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 Pavel Raiskup changed: What|Removed |Added Blocks||1619610 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1619610 [Bug 1619610] mozilla-filesystem to own %_libdir/mozilla/native-messaging-hosts -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YH5NTOCQFYHOQI5HDSUPGP7OQAPAMZB5/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528
Lukáš Tyrychtr changed:
What|Removed |Added
CC||lukastyryc...@gmail.com
--- Comment #3 from Lukáš Tyrychtr ---
Note that i do not actually understand the mock install failure, i can install
the package just fine.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: make
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* BSD (unspecified)". 12
files have unknown license. Detailed output of licensecheck in
/home/ltyrycht/1619528-textern/licensecheck.txt
[?]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib64/mozilla/native-
messaging-hosts(webextension-token-signing, chrome-gnome-shell)
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #2 from Pavel Raiskup --- Spec URL: https://raw.githubusercontent.com/praiskup/textern-rpm/master/textern.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/praiskup/textern/fedora-rawhide-x86_64/00789565-textern/textern-0.git5339fb6-3.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MOEIW5ASN6FRJEE55Q6YD4TO7NFKGMEQ/
[Bug 1619528] Review Request: textern - Firefox add-on for editing text in your favorite external editor
https://bugzilla.redhat.com/show_bug.cgi?id=1619528 --- Comment #1 from Pavel Raiskup --- Test builds: https://copr.fedorainfracloud.org/coprs/praiskup/textern/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/RSB75VROVWA55R6LKPY3K7734LEOWRMC/
